GitLab

This CL finishes off the componentization of
//chrome/browser/captive_portal by putting the componentized files in
the captive_portal namespace. The CL additionally removes all
now-unnecessary references to the captive_portal namespace from within
these files.

Bug: 1030692
Change-Id: Ia9bb3498413aa95cdd6eeb2a652061e6dbca6b11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038778
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738672}

The Apps Foundation team is implementing metrics for measuring success
and OKR progress. This metric measures whether an app that is
uninstalled was within 7 days of having been installed. A new histogram
was created to track this metric.

BUG=1044710
REVIEWERS:
    bcwhite: please review histograms.xml

Change-Id: I030dfc65835118e2ba15480ad779db64d304e272
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035501Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Nancy Wang <nancylingwang@chromium.org>
Commit-Queue: Alex Linker <ajlinker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738671}

This reverts commit 3599b7a3.

Reason for revert: Incorrectly reverted...see https://bugs.chromium.org/p/chromium/issues/detail?id=1012527#c9

Original change's description:
> Revert "Reland "Call MFShutdown in places where MFStartup is called""
> 
> This reverts commit 5019665f.
> 
> Reason for revert: broke capture_unittests on chromeos-amd64-generic-rel per http://crbug.com/1048934
> 
> Original change's description:
> > Reland "Call MFShutdown in places where MFStartup is called"
> > 
> > This reverts commit 5be12bf8.
> > 
> > Reason for revert: Fixing the issue, and running on more trybots
> > 
> > Original change's description:
> > > Revert "Call MFShutdown in places where MFStartup is called"
> > > 
> > > This reverts commit abf9a1f5.
> > > 
> > > Reason for revert: Broke tests on Win7 dbg, see linked bug
> > > 
> > > Original change's description:
> > > > Call MFShutdown in places where MFStartup is called
> > > > 
> > > > Bug: 1012527
> > > > Fixed: 1012527
> > > > Change-Id: Id9ef248aadb0aa24704dec973b60ea23c9e1f1ed
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032332
> > > > Commit-Queue: Ted Meyer <tmathmeyer@chromium.org>
> > > > Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
> > > > Cr-Commit-Position: refs/heads/master@{#738063}
> > > 
> > > TBR=xhwang@chromium.org,tmathmeyer@chromium.org
> > > 
> > > Change-Id: I267213cc06b42769736c7eb337432ade7953de20
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Bug: 1012527
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036057
> > > Reviewed-by: Marc Treib <treib@chromium.org>
> > > Commit-Queue: Marc Treib <treib@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#738130}
> > 
> > TBR=xhwang@chromium.org,treib@chromium.org,tmathmeyer@chromium.org
> > 
> > Change-Id: I8f87e933e133d0dcbf9904c002af7738af450f41
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: 1012527
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037811
> > Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
> > Commit-Queue: Ted Meyer <tmathmeyer@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#738344}
> 
> TBR=xhwang@chromium.org,treib@chromium.org,tmathmeyer@chromium.org
> 
> Change-Id: Ieba1f172a5a2bed58e338f15c638c6deae8b0685
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1012527, 1048934
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037855
> Reviewed-by: Kenneth Russell <kbr@chromium.org>
> Commit-Queue: Kenneth Russell <kbr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#738410}

TBR=xhwang@chromium.org,kbr@chromium.org,treib@chromium.org,tmathmeyer@chromium.org

Change-Id: I6ca750208e811eeda8acd9c6f57924a9cb57f04d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1012527, 1048934
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040191Reviewed-by: Ted Meyer <tmathmeyer@chromium.org>
Commit-Queue: Ted Meyer <tmathmeyer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738670}

BUG=chromium:878390

Change-Id: I0a5dd1e09f42a0332fd107cdecb677d499d4cef6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020769
Auto-Submit: Ross McIlroy <rmcilroy@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738669}

This CLs organizes most of the drag and drop logic to its own
manager service, in preparation for more complex logic. This CL
does not change any implementation and only moves code around.

Follow up CLs will modify the drag interactions to only modify the
DOM and allow canceling drag sessions, with drop being the commit
to move tabs or tab groups. This will also prepare the manager to
be able to support dragging tabs from other windows into place.

Bug: 1048894
Change-Id: Ieb66ee859a09b972f178a8c50513aa2f284e08d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036932Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738668}

This CL adds custom chromevox announcements for all
settings pages in the system tray.

Bug: 1009714
Change-Id: Ied1735f1afc1289de6c66fb449c1bce70ac5fd25
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037956Reviewed-by: Tim Song <tengs@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738667}

We weren't yet calling out explicitly that TRACE_EVENT_NESTABLE_ASYNC
should be preferred over TRACE_EVENT_ASYNC.

Bug: 1038710
Change-Id: Ib0e386d435a17ca0f21354e4ce5c955e0616fef5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037996
Auto-Submit: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738666}

This CL creates a SharedImageRepresentationGLTexture for Ozone-based
SharedImages. The representation creates a GLImage from the pixmap
via GLImageNativePixmap::Initialize and then binds it to a GL texture.

Like in the case of the Pixmap Dawn representation, synchronization
will be added in a future CL.

Also, updates SharedImageBackingOzone to properly track the cleared
rect now that it is being used on SIRGLTexture::BeginAccess as per
chromium-review.googlesource.com/1990195.

Bug: 1023997,996470
Change-Id: Icacf20bc0f754fbc8acb37693618f2aca64568e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913085
Commit-Queue: Brian Ho <hob@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738665}

Going through each of the usages will take some care, so I want to
essentially fix the API in a no-op pass and properly migrate each of
the callsites independently (or in batches).

Bug: 783819
Change-Id: I91e5d4cbf327dfc08d16296ccc6213a347779a48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039171Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738664}

Also fixing the remaining copy related testing that are failing due to
strict mode

Bug: 1046062
Change-Id: I5a07db2b9ee16fb50094a968eab80f34d9b5addd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028928Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Haiyang Pan <hypan@google.com>
Cr-Commit-Position: refs/heads/master@{#738663}

On the last round of r738645 rdevlin.cronin@ requested two fixes which I
forgot to actually apply before submitting. Oops!

Tbr: rdevlin.cronin@chromium.org
Bug: None
Change-Id: I17eefb78fdddd1d04feca946b506bf6725cccb8c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039892Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738662}

Bug: 992074
Change-Id: I2b54639a15222d2c30cf419c606b62ebd28597e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951893
Commit-Queue: Katie Dektar <katie@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738661}

This change adds different foreground icon colors to the toolbar buttons
for the hovered and pressed states when the high contrast ink drop
feature is enabled. This is to support the desired platform high contrast
colors. Future work will add foreground color support to other buttons.

New theme properties were added to support the additional _HOVERED and
_PRESSED state high contrast colors. When not in high contrast, these
are the same as the normal icon color. In high contrast (+ flag) they
return the selected text HC color. These new colors are used to create
images in the toolbar buttons for the various button states.

New helper functions we added to ToolbarButton to simplify setting the
images for the different button states, including one that just uses
the standard colors returned by |GetForegroundColor|.

In the future, we might want to do work to allow icons to be separated
from colors to allow for easier recoloring.

Bug: 776871
Change-Id: Id72d8c60a23889f018044a5fcce7abd9359ad61a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029492Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738660}

This removes the code from input_injector_mac.cc that tried to
calculate the correct offset from the desktop configuration and passes
the correct (adjusted) coordinates.

Bug: 946001
Change-Id: Iedea08a9d019c0fcdfa615b1e83a88ed4474f2c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029448Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738659}

Address closure issues caused by moving to more restrictive rules:
  * Tweaked how BluetoothAdapter 'info' was bubbled up to be non-null.
  * The code was previously shoving undeclared 'removed' and
    'connectionStatus' properties into the bluetooth.mojom.DeviceInfo
    struct. I moved this 'removed' property to a separate map (it's a
    hacky property only used for the bluetooth-internals page, so it
    makes no sense to actually add to the struct) and completely tore
    out the notion of a 'connectionStatus' from being attached to a
    DeviceInfo since it was actually not used (!).

Tested by building webui_closure_compile with this CL based on top of
crrev.com/c/2006413, and by manually testing
chrome://bluetooth-internals to verify no regressions were introduced.

Fixed: 1047809
Change-Id: Id5abfec261602e67e9f9783a5621bec7bd97cc65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038078
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738658}

Roll broadwell AFDO profile from 81-4028.0-1580732019-benchmark-81.0.4044.6-r1 to 81-4028.0-1580732019-benchmark-81.0.4044.9-r1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-broadwell-chromium
Please CC c-compiler-chrome@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Tbr: c-compiler-chrome@google.com
Change-Id: I34ce681dc21ae74541fdfdcf1aab407dce7265c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039378Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#738657}

This CL ensures that AppActivityRegistry::OnAppActive
returns early if the application is already active.

Bug: 1034551
Change-Id: I5133e8b799e4231130f2ae5518469eaf29158dd0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037967
Commit-Queue: Yilkal Abe <yilkal@chromium.org>
Reviewed-by: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738656}

The structured-clone-any.js test is slow as it creates a new database
for each of over a hundred test cases, leading to long (>20s) run
times on debug builds. This would lead to occasional timeouts.

Use the WPT "variant" mechanism and shard the test down to just 20
cases per shard, which drops the test times down to just a few seconds
each (on debug builds).

Bug: 991415
Change-Id: I5fa792ea0042c7ff6ea29d926a459c625958d10d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036957
Auto-Submit: Joshua Bell <jsbell@chromium.org>
Commit-Queue: Jarryd Goodman <jarrydg@chromium.org>
Reviewed-by: Jarryd Goodman <jarrydg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738655}

Roll airmont AFDO profile from 81-4028.0-1580726817-benchmark-81.0.4044.6-r1 to 81-4028.0-1580726817-benchmark-81.0.4044.9-r1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-airmont-chromium
Please CC c-compiler-chrome@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Tbr: c-compiler-chrome@google.com
Change-Id: Ib0eaf6a46c9b7b303b37c1a851a2fa469b8942c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039992Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#738654}

Several browser_test test suites implemented the same version of a
helper function to check if a particular element is visible. This CL
refactor these tests to use an already commonly available util function.

The original isVisible functionality is moved to isChildVisible and
isVisible is adjusted to directly check the element parameter. Call sites
that relied on the previous behavior have been refactored to use
isChildVisible.

Bug: 814436
Change-Id: I1d75f0562cd8ba789fab3e89bbd115ea7c85862b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030921Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com>
Cr-Commit-Position: refs/heads/master@{#738653}

https://skia.googlesource.com/skia.git/+log/d2ccbb522eb0..4777e3addec4

git log d2ccbb522eb0..4777e3addec4 --date=short --first-parent --format='%ad %ae %s'
2020-02-05 robertphillips@google.com Cleanup program building a bit
2020-02-05 brianosman@google.com In SkRuntimeEffect, just use hash of SkSL as the ID
2020-02-05 bsalomon@google.com GrTextureEffect handles insets for float rects as well as integer rects.
2020-02-05 csmartdalton@google.com Don't use tessellation FB barrier after NVIDIA 440.00

Created with:
  gclient setdep -r src/third_party/skia@4777e3addec4

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: scroggo@google.com
Change-Id: Icc40f76aca82b67c728dd312101548eed0e36d3d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039690Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#738652}

which is 0x101 (in response to 0x1) instead of 0x102. This only affects unit tests.

BUG=1045010

Change-Id: I38610619dfde7c409ee226468e61ca0ab2b37059
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024848Reviewed-by: Harald Alvestrand <hta@chromium.org>
Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com>
Cr-Commit-Position: refs/heads/master@{#738651}

As per Polymer style guide identifiers should be camelCase, this CL
changes site_settings_page to conform to style.

Additionally the mis-naming which caused the associated bug is fixed.

Bug: 1049082
Change-Id: I2c57d987c70e6587cc98f7b3749f6c948d3ffb3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037675Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com>
Cr-Commit-Position: refs/heads/master@{#738650}

The usage of ProxyBypassRules in TrustedSourcesManager isn't
appropriate, since ProxyBypassRules was only designed to be used for
proxy rules. It implicitly allows rules such as <-loopback> and <local>,
which TrustedSourcesManager may not want.

With the newly introduced SchemHostPortMatcher, which implements the
most ProxyBypassRules has but more general, we can replace the usage of
ProxyPypassRules with it for TrustedSourcesManager.

Bug: 1030092
Change-Id: Ia0742d589fdbc083e8bbecbd64aacca573b8be91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036368Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Shimi Zhang <ctzsm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738649}

Roll silvermont AFDO profile from 81-4028.0-1580727432-benchmark-81.0.4044.6-r1 to 81-4028.0-1580727432-benchmark-81.0.4044.9-r1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-silvermont-chromium
Please CC c-compiler-chrome@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Tbr: c-compiler-chrome@google.com
Change-Id: Ic58d4b29910477c6a2c6fb823433d3ffe4dc1e21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039377Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#738648}

Using these metrics, we can track if any particular websites are broken
when users change their iOS default text size.

Bug: 1046356
Change-Id: Ia324cce81bf2926affc93c1622fcc6f6cde53dcb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029515Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Robbie Gibson <rkgibson@google.com>
Cr-Commit-Position: refs/heads/master@{#738647}

When computing outline rects in an inline formatting context,
the coordinate system needs to be relative to the root of the
inline formatting context, because the algorithm needs to
call |LayoutObject| functions, which uses the coordinate
system for inline |LayoutObject|s.

This patch fixes not to accumulate line box offset. For the
inline direction, this is usually zero and is not visible,
but non-zero `padding-left` can expose this difference.

Bug: 1048070
Change-Id: I30dfabcca621136b6d78892a1856c1336c7438eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038296Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738646}

Bug: None
Change-Id: I22230d6e321f38c5870ef0a02770d4b74ec36472
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031743Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738645}

This will be used to validate that property data is the right type as
described by the schema. This amends an existing script that will use a
json+ld file checked into third_party.

Bug: 1044250
Change-Id: I781f4f50a0331655e36a03b7fc26d9c54c0ae87c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036892Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Commit-Queue: Sam Bowen <sgbowen@google.com>
Cr-Commit-Position: refs/heads/master@{#738644}

Adds calls to QuotaManagerProxy::NotifyWriteFailed() where write
errors might occur in Cache storage code. With this information, quota
can reasonably guess if the disk is out of space and decide if any
actions should be taken at that point.

Bug: 997258
Change-Id: I7e385b1b40c1ee1117d3964a77e589a29dcbd51c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008286
Commit-Queue: Jarryd Goodman <jarrydg@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Ben Kelly <wanderview@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738643}

This reverts commit 18bb0cd4.

Reason for revert: This implementation does not work for local Windows account.

Original change's description:
> Check if user has password in security connect API
> 
> In chrome.enterprise.reportingPrivate.getDeviceInfo API, screen lock
> secured flag now check if user has password on Windows.
> 
> The code behavior matches SecureConnect native host: 291830502
> 
> Bug: 1047785
> Change-Id: Iffc94d9cf179f85f353b8d245b90f5dd759c4bd6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031703
> Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org>
> Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#737709}

TBR=pastarmovj@chromium.org,sacomoto@chromium.org,zmin@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1047785
Change-Id: I84ba226964e98e228438153e0b73fec74efa122a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039631Reviewed-by: Owen Min <zmin@chromium.org>
Reviewed-by: Gustavo Sacomoto <sacomoto@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738642}

* Reorder includes and policy handlers to combine ones for same
platform/build conditions in the same group.
* Find and remove several duplicates.

Bug: 1042185
Change-Id: I34fb3589e338101e7ea5648a1982b9e4fae599f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038652Reviewed-by: Oleg Davydov <burunduk@google.com>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Commit-Queue: Nikita Podguzov <nikitapodguzov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738641}

and add new owners.
No longer working on project, and not committer either.

Bug: none
Change-Id: I85396d30e127ed0a542529561fdc4cf022951c51
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033349Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738640}

This change adds a CompromisedPasswordsObserver interface to the
password store allowing subscribers to be notified about changes to the
stored compromised credentials.

Bug: 1047726
Change-Id: I10e8938bad7ad7503791f8c109df23384b4392c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037574
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738639}

Adds UKM support for reporting the capture time of the main frame (in
ms) for a paint preview. Support for memory overhead and on-disk size
may be added to this dataset in future, but is out-of-scope for this CL
as getting reliable memory metrics is non-trivial and on-disk size is
handled on a per-implementation basis.

Bug: 1038390
Change-Id: Iaaf77b3722633773455babd3e7e51cd95f713577
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988222
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738638}

Bug: 1047762
Change-Id: I33e3ecc44228a50df727f57433e0138c5ad9d479
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036547Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Haiyang Pan <hypan@google.com>
Cr-Commit-Position: refs/heads/master@{#738637}

Move Theme settings alongside other night_mode code.

Bug: 1047357
Change-Id: I1e32fe0f49d002f6c29852d9cbe9180a44fbc7aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036432
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Sinan Sahin <sinansahin@google.com>
Cr-Commit-Position: refs/heads/master@{#738636}

A call to DynamicTo<Text> where "from" is a HTMLBRElement will
return null.
We need to be able to handle this condition, so a null check was
added before "text_node" is dereferenced.

Bug: 928948
Change-Id: I5d27b63e905035c8d12d41bf3d2a86adc5a82bbf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031937Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Jacques Newman <janewman@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#738635}

Split out webgl as an initial test module.

Bug: 1048907
Change-Id: Iadad65e4a0480196670e697767850fdd99f4a35b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038278Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738634}

This implements the section related to 'manifest objects' in the Omaha
protocol:
https://cs.chromium.org/chromium/src/docs/updater/protocol_3_1.md

```
A manifest object contains details about how to fetch and apply an
update.
*`arguments`: A string, indicating command-line arguments that should
be passed to the binary specified in `run`. Default: "".
*`run`: A path within the CRX archive to an executable to run as part
of the update. The executable is typically an application installer.
If unsent or the empty string, no particular update-delivered
installer needs to be run. Default: "" (empty string).
```

Such values are being parsed and passed over as an optional parameter
to the CrxInstaller::Install call. An std::unique_ptr is used to
avoid forcing all callers of CrxInstaller::Install to use the
base::Optional type.

The //chrome/updater code picks up this parameter and, on Windows,
it runs the program specified by the update response. The other
platforms don't implement this call yet but code will land soon
for macOS.

This change is transparent for the component and extensions updaters
since their installers ignore these optional parameters.
A compliant server would not respond with {run, arguments} for
these update_client requests.

Bug: 1042218
Change-Id: I00368182d0aa1189893808c1b6972284c5b3407e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036287Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738633}