- 20 Jul, 2018 40 commits
-
-
Yutaka Hirano authored
Based on UMA data, it's fairly common for extensions to modify WebSocket cookie headers. Support this in the network service. Only adding cookie headers is supported. Extensions don't see cookie headers that would be sent to the network. Extensions cannot express an intent not to attach cookies. Bug: 721400 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I462735930f63a8d45cc66604888bae2e71e6345f Reviewed-on: https://chromium-review.googlesource.com/1143088 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#576770}
-
Jared Saul authored
A sign-in promo pops up right after a card is saved locally. This also introduces a "Manage cards" bubble, with a footnote of a sign-in promo. An organized list of the diffs -- https://screenshot.googleplex.com/kMBPkpWZYsq.png A rough doc I quickly put together of the changes in this CL -- https://docs.google.com/document/d/1DarGyLBDSBWcsumcxhpojuvugUTUU6r5j6uI0RZZAo0/edit?usp=sharing Here are different screenshots explaining why we chose to have the promo not display a title -- Using promo's title (The string isn't updated in this screenshot): https://screenshot.googleplex.com/kiYnAynyedD Empty promo title, using main bubble title: https://screenshot.googleplex.com/rT3F9RETsgq No promo title, using main bubble title: https://screenshot.googleplex.com/nMXOdNvysbR This is what the mocks were like (with the old UI): https://screenshot.googleplex.com/AhXfxONG0sO Additionally, this is what the sync promo looks like: https://screenshot.googleplex.com/J3huQ06Y5X8 Sign-in promo on the Manage Cards view: https://screenshot.googleplex.com/MJqf5Fbhnpa Sync promo on the Manage Cards view: https://screenshot.googleplex.com/cNLy78Ts80k Metrics, additional browser tests, and omnibox icon animation to follow. Bug: 855186 Change-Id: I74ecdd802da960120baacfdd771c90cb126fbd10 Reviewed-on: https://chromium-review.googlesource.com/1134514 Commit-Queue: Jared Saul <jsaul@google.com> Reviewed-by:Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#576769}
-
src-internal-chromium-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ea9328b8e855..9cf0f36d349f Created with: gclient setdep -r src-internal@9cf0f36d349f The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:852038,chromium:852034 TBR=mmoss@chromium.org Change-Id: I07282894134f4ba5d4aa6f4888c92d79871a1a1f Reviewed-on: https://chromium-review.googlesource.com/1144283Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#576768}
-
Makoto Shimazu authored
Adding tests to check if DNT header is perserved when a page is controlled by a service worker but requests fall back to the network. Bug: 853085 Change-Id: I9beeda397d4fbdef13aee11e36af3efaaec142f1 Reviewed-on: https://chromium-review.googlesource.com/1139458Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#576767}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I0d3804ca43ac6e26ef1d835e3c0366563a60501d Reviewed-on: https://chromium-review.googlesource.com/1144491Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#576766}
-
Tien-Ren Chen authored
This CL changes the pre-snapping policy of <video> so that only the size of the contents is pre-snapped, while the location will exactly match the content box's final location. BUG=730284 Change-Id: I6d02bb09fc5d570f74b94923b6b806e16ed4f119 Reviewed-on: https://chromium-review.googlesource.com/1144256 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#576765}
-
Yoshifumi Inoue authored
This patch get rid of redundant |NOTREACHED()| from |CompositeEditCommand:: Apply()| since we can apply any commend to plaintext-only content editable. Bug: 863708 Change-Id: Id3e7377d88ffc16f0a8f32f13002de01e3184b67 Reviewed-on: https://chromium-review.googlesource.com/1143112Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#576764}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/0ddcb32d165e..d26f5c315d5e git log 0ddcb32d165e..d26f5c315d5e --date=short --no-merges --format='%ad %ae %s' 2018-07-19 benjhayden@chromium.org Extend Descriptor to support more test suites. Created with: gclient setdep -r src/third_party/catapult@d26f5c315d5e The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Iee2a3a754e9b51f68976a6a52dd91f506549aa12 Reviewed-on: https://chromium-review.googlesource.com/1144066Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#576763}
-
Tommy Martino authored
This CL addresses a UX regression caused in this revision: https://chromium.googlesource.com/chromium/src/+/fa89015c94aa96aed4bcf1452b8c808de3ab627c Specifically, the extra height which compensates for corner rounding in the footer was removed. In pixel terms, this shrunk the footer row from 40px to 36px. This CL reintroduces the extra height. Change-Id: Ib5d6c1d0a8af1bd63c960597654f85982e280e3a Bug: 865479 Reviewed-on: https://chromium-review.googlesource.com/1143688Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/5deb17553471..20c1311957dd git log 5deb17553471..20c1311957dd --date=short --no-merges --format='%ad %ae %s' 2018-07-19 robliao@chromium.org Replace Right Single Quotation Mark (U+2019) with Apostrophe (U+0027) Created with: gclient setdep -r src/third_party/depot_tools@20c1311957dd The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I296e4d351a0d74113cf3956101ee574fea4a89fe Reviewed-on: https://chromium-review.googlesource.com/1144028Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#576761}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/e34766b47b67..eb4ac1447746 git log e34766b47b67..eb4ac1447746 --date=short --no-merges --format='%ad %ae %s' 2018-07-19 sawlani@google.com chromeos_config: Customize lakitu-full build config. 2018-07-19 pprabhu@chromium.org sysmon: Ignore lab servers in chromeos9- 2018-07-19 mikenichols@chromium.org metrics: Introduce float based timings metric. 2018-07-19 dhanyaganesh@chromium.org CreateTarball: print unformatted results from lsof 2018-07-19 dgarrett@google.com generic_stages: Remove _ExtractStages helper. 2018-07-19 xixuan@chromium.org SkylabSuite: Add swarming task priority for skylab suite. Created with: gclient setdep -r src/third_party/chromite@eb4ac1447746 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I8c33981d0d3fcc3d58eef9187a040dc36d024d18 Reviewed-on: https://chromium-review.googlesource.com/1144024Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#576760}
-
Justin Novosad authored
BUG=788439 TBR=zmo@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ib758904323adb6039d21f916d4aed9fdc631278e Reviewed-on: https://chromium-review.googlesource.com/1144275 Commit-Queue: Justin Novosad <junov@chromium.org> Reviewed-by:
Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#576759}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 942c9ea0. With Chromium commits locally applied on WPT: 1f227e06 "Implement FeaturePolicy sync-script (as an experimental feature policy)" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21567 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: rouslan@chromium.org, mathp@chromium.org: external/wpt/payment-request TBR=foolip No-Export: true Change-Id: Ib97b8245f59ff04b9715a5cce4ad78947d677cd3 Reviewed-on: https://chromium-review.googlesource.com/1144529 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#576758}
-
Wenzhao Zang authored
cr_checkbox started to use FlexBox in https://chromium-review.googlesource.com/c/chromium/src/+/1033346 So the custom margin is no longer needed. Bug: 864935 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Idf0d2eb549a026cee160dc16e37cc2b770a5fc89 Reviewed-on: https://chromium-review.googlesource.com/1144476Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#576757}
-
chrome://flags#enable-web-authentication-cable-supportKim Paulhamus authored
caBLE is a transport option for the WebAuthN API Bug: 837088 Change-Id: I81ea955bb95848161a927fb2a1b84773cf572d24 Reviewed-on: https://chromium-review.googlesource.com/1144418 Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
Jun Choi <hongjunchoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#576756}
-
Tetsui Ohkubo authored
ARC++ notifications are shown above scroll bar, so we temporarily make scroll bar invisible as a workaround. When the limitation is removed from ARC++, the flag will be removed and the scroll bar will be restored. TEST=manual BUG=858940 Change-Id: I6931c6406c9feb2bb4159d737205187bdc88b86b Reviewed-on: https://chromium-review.googlesource.com/1140014Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#576755}
-
Xing Liu authored
Uses weak pointer in DownloadServiceImpl to fix a potential memory corruption in |pending_tasks_|. Bug: 860771 Change-Id: Ib84f4c27aa4d2f1e7560434d41175ecba0a622e5 Reviewed-on: https://chromium-review.googlesource.com/1144464Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#576754}
-
Kenichi Ishibashi authored
As a comment in ServiceWorkerRequestHandler::InitializeHandler() says[1], we may call it but do nothing when S13nServiceWorker is enabled. Skip tests for InitializeHandler() when S13nServiceWorker is enabled. [1] https://cs.chromium.org/chromium/src/content/browser/service_worker/service_worker_request_handler.cc?l=232&rcl=e09f67110c9a517c981814b643b69c8de0833aac Bug: 860361 Change-Id: I55afa47c165c33d82b38e9e2b89b153ff8aaffb2 Reviewed-on: https://chromium-review.googlesource.com/1144580Reviewed-by:
-
Tommy C. Li authored
On the New Tab Page, when the user clicks the fake Google search box, i.e. the "fakebox", we give the Omnibox "invisible focus". This is a unique state where we set the Omnibox is focused and capturing key events, but the caret is invisible. In the past, the caret being invisible was sufficient for the Omnibox to be "invisibly" focused. In MD Refresh, however, we have three new focus indicators: 1. Focus ring 2. Placeholder text 3. Background color change This CL updates all three of the above visual indicators for the Omnibox to be keyed on the invisible-focus state rather than the ordinary focus state. This solves the flicker present in the below bug and actually follows the concept of invisible-focus correctly. The concept of invisible-focus is kind of evil, and long term, we would like to get rid of it -- but this is a short term fix for MD Refresh. Bug: 859826 Change-Id: I2e0ede93e69485745bbf119a3f366b0dbfa197ab Reviewed-on: https://chromium-review.googlesource.com/1144211 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#576752}
-
Kunihiko Sakamoto authored
Bug: 803774 Change-Id: I9c9f9ff1a070b0bcf86312f6a80c56146b9d475b Reviewed-on: https://chromium-review.googlesource.com/1143095Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
-
Ryan Hansberry authored
Integrates MultiDeviceSetupClient into TetherService. If the chromeos::features::kEnableUnifiedMultiDeviceSetup flag is enabled, Instant Tethering will only be displayed in Settings and Quick Settings if a verified MultiDevice host exists. Bug: 824568 Change-Id: Iad6b6778a2986c7c92176bc7d8f4ac47bd47f5e3 Reviewed-on: https://chromium-review.googlesource.com/1141145 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#576750}
-
Yutaka Hirano authored
virtual/outofblink-cors and virtual/outofblink-cors-ns should inherit existing test expectations. There is a dedicated bug for virtual/outofblink-cors, https://crbug.com/854630, but that doesn't make sense as none of them are OOR-CORS specific, so I changed the bug number. TBR=dcheng@chromium.org No-Try: true Bug: 834185, 854630, 859988, 862184 Change-Id: I4886c8ed063e95306d79234649dbc54a8bb53100 Reviewed-on: https://chromium-review.googlesource.com/1144582Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#576749}
-
Ria Jiang authored
Some SitePerProcessHitTestBrowserTest are failing with feature VizDisplayCompositor turned on. This is because the current way of getting the page-scale-factor of the last frame doesn't work with VizDisplayCompositor - VizDisplayCompositor doesn't use RenderWidgetHostImpl::SubmitCompositorFrame so last_frame_metadata_ is never set. This CL updates those tests to use RenderFrameSubmissionObserver to get the last RenderFrameMetadata. Bug: 848325, 848325 Change-Id: Ic20e6c4a591dbc7c3c499869910b4f342b99c3cb Reviewed-on: https://chromium-review.googlesource.com/1139088 Commit-Queue: Ria Jiang <riajiang@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#576748}
-
Min Qin authored
For cross origin redirects, Chrome starts a new navigation request. Since the ResourceDownloader is already created, CancelRequest() is needed to destroy it. BUG=831073 Change-Id: I97456d6659fd61cf9af39b037fa95a448ab80185 Reviewed-on: https://chromium-review.googlesource.com/1143690Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#576747}
-
Alex Moshchuk authored
Bug: 865802 Change-Id: I8c6a6eb45d29c9cdd1aec9557baebd3bd58cb332 Tbr: dmurph@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1144521Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#576746}
-
dpapad authored
Instead of having a fixed 200px width, make it occupy 50% of the available space. Bug: 704428 Change-Id: I8f647da9c2fee631548cbb0691733ade82fb7230 Reviewed-on: https://chromium-review.googlesource.com/1144137Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#576745}
-
David Black authored
Now that we have indication in the OnInteractionStarted event if we are handling a voice interaction or not, we can move the commit logic in the case of a non-voice interaction. Doing so allows us to properly clear the stage whenever a new interaction is started. This fixes a bug in which notifications failed to clear the stage. Bug: 111396118 Change-Id: I288ee685f9e8fa8c385c0dbb0896c03838c53a4e Reviewed-on: https://chromium-review.googlesource.com/1144429Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#576744}
-
Paul Irish authored
Change-Id: If3ca6a8deb29680e213e151ab7aa91ddec1c19e3 Reviewed-on: https://chromium-review.googlesource.com/1144449Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Paul Irish <paulirish@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#576743}
-
Khushal authored
This reverts commit f9395d77. Use the GrContextOptions::PersistentCache API provided by skia to persist shaders generated internally by skia for OOP raster to disk. This requires using a special client id to namespace these shaders, similar to the one used by the InProcessCommandBuffer for viz. While the shaders for different sources are stored seperately on disk, they are finally merged into a single memory cache in the GPU process. In order to maintain a seperate cache for skia generated shaders, this also plumbs the client id for a loaded shader to the GPU process. TBR=tsepez@chromium.org Bug: 854416,840559, 865138 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I65544ccaff96c3154a822dbc2500468fbcac8a0b Reviewed-on: https://chromium-review.googlesource.com/1142829 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#576742}
-
Brandon Jones authored
Received feedback that the previous enums went against platform norms Bug: 854382 Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I278fbbc204f45e5032ac081e535bae5f62bc1cd3 Reviewed-on: https://chromium-review.googlesource.com/1144249Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#576741}
-
src-internal-chromium-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bb5cc39baf68..ea9328b8e855 Created with: gclient setdep -r src-internal@ea9328b8e855 The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ibaf6bcb28b885b5e0e03f0499fe67cb127e721db Reviewed-on: https://chromium-review.googlesource.com/1144027Reviewed-by:
-
Theresa authored
BUG=863763 Change-Id: I5a60e0c8f8c79bf4e6f3763d31f006595c063c2b Reviewed-on: https://chromium-review.googlesource.com/1144439 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#576739}
-
Daniel Park authored
> Scrolls if the NTP is finished loaded > If not loaded at time of method call, adds an observer to delay scrolling until loading finishes Bug: 865747 Change-Id: I8f80d1692d762efa6bba39560b148950883c4952 Reviewed-on: https://chromium-review.googlesource.com/1144319Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Daniel Park <danielpark@chromium.org> Cr-Commit-Position: refs/heads/master@{#576738}
-
Bence Béky authored
Add new bucket and record histogram if push is cancelled because resource was found in cache. This bucket was missing by mistake. Add new bucket and record histogram if push is rejected because push is disabled. This functionality was just added at https://crrev.com/c/1141282. Bug: 232040, 862805 Change-Id: I70af4cfc077bd65baccc7fe06cadb7dfe29d42fe Reviewed-on: https://chromium-review.googlesource.com/1142958 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Reviewed-by:
-
Dale Curtis authored
This codifies assumptions about the API into variables which are used to disable or start the internal reporting timer for WTR. Specifically these two assumptions are codified: - That in shutdown the timer should not be able to start, and should be stopped. - That when a seek starts, a subsequent play call is required to allow the timer to start again. Previously these were handled by forcing the timer state to false when those events are in flight. In the case of a seek, something like OnShown() might end up called first and restart the timer. BUG=none TEST=new tests. Change-Id: Ia14c3cdf8a3e383915372eb8ab813a1e4b78e530 Reviewed-on: https://chromium-review.googlesource.com/1144301 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#576736}
-
Dale Curtis authored
Specifically if the base component has started finalize and another component (AC, controls, etc) starts finalizing it's possible that it has a higher end timestamp than the base component finalize. Instead we should clamp to the maximum of the current time value given to RecordWatchTime() instead of using a higher ending timestamp. BUG=none TEST=new unittests Change-Id: Idd32571ea4d6b7b937ca61a4606e2f8e7efc7e53 Reviewed-on: https://chromium-review.googlesource.com/1144302Reviewed-by:
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/5527682463d1..abf9829bc411 git log 5527682463d1..abf9829bc411 --date=short --no-merges --format='%ad %ae %s' 2018-07-19 tsepez@chromium.org Remove some unused default values in cfxjse_context.h. 2018-07-19 tsepez@chromium.org Change some ASSERTS() to early returns in cfxjse_class.cpp Created with: gclient setdep -r src/third_party/pdfium@abf9829bc411 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I90519b33ad62d5aea3b4a37ba0e4a8fef148a724 Reviewed-on: https://chromium-review.googlesource.com/1144026Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#576734}
-
Alexander Alekseev authored
This Cl makes buttons correctly spaced on Welcome screen and Powerwash screen. Assistant opt-in screen now uses cros-shared button style. Bug: 857443,852034 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ia90416579b6fefa409ccb4eba7eafeb019136409 Reviewed-on: https://chromium-review.googlesource.com/1142894 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#576733}
-
Bill Orr authored
As previously announced (https://groups.google.com/a/chromium.org/d/msg/blink-dev/-s4pWwshKhI/M78h2_scBwAJ), the WebVR Origin Trial is ending after M68 as WebVR is replaced by the WebXR Device API and Origin Trial. WebVR can still be manually enabled through chrome://flags. BUG=758265 Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I752ac8d61c8436abd80a511cc66d4aad502d0245 Reviewed-on: https://chromium-review.googlesource.com/1144278Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Commit-Queue: Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#576732}
-
Mounir Lamouri authored
This reverts commit 94b0138d. Reason for revert: <INSERT REASONING HERE> Original change's description: > Revert "[Picture-in-Picture] Update window playback when video src changes." > > This reverts commit 93488940. > > Reason for revert: PictureInPictureWindowControllerBrowserTest.UpdateVideoSrcKeepsPictureInPictureWindowOpened is very flaky: https://crbug.com/865410 > > Original change's description: > > [Picture-in-Picture] Update window playback when video src changes. > > > > This CL make sure the Picture-in-Picture window playback state is > > reflected when video src changes. It is a follow-up to > > https://chromium-review.googlesource.com/1089331 > > > > Bug: 726619 > > Change-Id: Ic756c03aa023d3e4e229c7495686ea8f322503e3 > > Reviewed-on: https://chromium-review.googlesource.com/1133168 > > Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> > > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > > Reviewed-by: Matthew Wolenetz <wolenetz@chromium.org> > > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#576428} > > TBR=dalecurtis@chromium.org,wolenetz@chromium.org,beaufort.francois@gmail.com,mlamouri@chromium.org,jochen@chromium.org > > Change-Id: I2b35b9ef8c119915b1c07f9f12321439c3242ab2 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 726619, 865410 > Reviewed-on: https://chromium-review.googlesource.com/1143324 > Reviewed-by: Christian Dullweber <dullweber@chromium.org> > Commit-Queue: Christian Dullweber <dullweber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#576454} TBR=dalecurtis@chromium.org,wolenetz@chromium.org,beaufort.francois@gmail.com,mlamouri@chromium.org,jochen@chromium.org,dullweber@chromium.org Change-Id: Ia3931e803814eb9bf8bf56d44fd922f409cd5d8c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 726619, 865410 Reviewed-on: https://chromium-review.googlesource.com/1144560 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#576731}
-
