- 07 Apr, 2017 40 commits
-
-
fserb authored
BUG=708165,708044,708961 Review-Url: https://codereview.chromium.org/2797333002 Cr-Commit-Position: refs/heads/master@{#462989}
-
hanxi authored
Revert of media: Implement MediaDrmStorageImpl with tests (patchset #4 id:60001 of https://codereview.chromium.org/2791903004/ ) Reason for revert: This CL causes MediaDrmStorageImplTest failing on chromium.linux/Android Tests: https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Tests/builds/40330 BUG=709601 Original issue's description: > media: Implement MediaDrmStorageImpl with tests > > Implement MediaDrmStorageImpl using PrefService. > > TBR=sdefresne@chromium.org > BUG=493521 > TEST=New unit tests added. > > Review-Url: https://codereview.chromium.org/2791903004 > Cr-Commit-Position: refs/heads/master@{#462929} > Committed: https://chromium.googlesource.com/chromium/src/+/d0b7b3b7e9f7d4e4c1f8276c5b416eaa05ac9bb0 TBR=yucliu@chromium.org,sdefresne@chromium.org,xhwang@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=493521 Review-Url: https://codereview.chromium.org/2808563002 Cr-Commit-Position: refs/heads/master@{#462988}
-
dpapad authored
BUG=709409 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2805283002 Cr-Commit-Position: refs/heads/master@{#462987}
-
thestig authored
BUG=537099 Review-Url: https://codereview.chromium.org/2808503003 Cr-Commit-Position: refs/heads/master@{#462986}
-
bokan authored
This is a test for the urgent fix landed in crrev.com/2791513002. BUG=704410 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2807753002 Cr-Commit-Position: refs/heads/master@{#462985}
-
vmpstr authored
Most of the changes replace canvas read pixels call in favor of first getting the bitmap, and then doing a readpixels on that. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2792133002 Cr-Commit-Position: refs/heads/master@{#462984}
-
sebsg authored
BUG=709529 TBR=rouslan@chromium.org Review-Url: https://codereview.chromium.org/2805913002 Cr-Commit-Position: refs/heads/master@{#462983}
-
rego authored
As agreed on https://chromium-review.googlesource.com/465440 the tests that are considered manual due to the "interact" flag, but that the feature hasn't been implemented yet ":focus-within" are skipped for now. There's one manual test "hover-001-manual.html" that is also skipped in this patch. BUG=706118 Review-Url: https://codereview.chromium.org/2803213002 Cr-Commit-Position: refs/heads/master@{#462982}
-
sorin authored
[ RUN ] RequestSenderTest.RequestSendSuccess [54568:29108:0407/114750.146:3888807750:FATAL:url_request_filter.cc(54)] Check failed: 0u == hostname_interceptor_map_.count(make_pair(scheme, hostname)) (0 vs. 1) After enabling PingManagerTest, the subsequent RequestSenderTest may fail because the PingManagerTest does not unregister its interceptors correctly. TBR=waffles@chromium.org BUG=349547 Review-Url: https://codereview.chromium.org/2805903003 Cr-Commit-Position: refs/heads/master@{#462981}
-
juliatuttle authored
Reporting is a spec for delivering out-of-band reports from various other parts of the browser. See http://wicg.github.io/reporting/ for the spec, or https://goo.gl/pygX5I for details of the planned implementation in Chromium. This adds an Observer interface by which parts of Reporting can observe cache updates. Expected users are the DeliveryAgent and Serializer. BUG=704259 Review-Url: https://codereview.chromium.org/2778373003 Cr-Commit-Position: refs/heads/master@{#462980}
-
xlai authored
HostSharedBitmapManager is shifted to components/display_compositor. ChildSharedBitmapManager is shifted to services/ui/public/cpp/bitmap. The Mojo messages used in allocating shared bitmap is decoupled from render_message_filter.h and moved to cc/ipc/shared_bitmap_manager.mojom. Note that the SharedBitmapManager is an associated mojo interface of RenderMessageFilter so as to maintain the existing FIFO order of mojo messages between the two SharedBitmap allocation functions and the rest of RenderMessageFilter functions. BUG=670162 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2717213004 Cr-Commit-Position: refs/heads/master@{#462979}
-
dougt authored
Here we are implementing one IAccessibility method, accLocation(), in terms of ui::AXPlatformNodeWin. The idea is that we can forward IAccessibility calls to ui::AXPlatformNodeWin and then slowly trim down, and maybe remove, BrowserAccessibilityWin. This CL adds a small helper method that allows the cast conversation of platform_node_, which is created in AXPlatformNode, from a AXPlatformNode to AXPlatformNodeWin. If this result is nullptr, we will fall back to using the BrowserAccessibilityWin implementation. BUG=703369 Review-Url: https://codereview.chromium.org/2763043002 Cr-Commit-Position: refs/heads/master@{#462978}
-
lgarron authored
Also renames PageInfoPopupViewBrowserTest to PageInfoBubbleViewBrowserTest. BUG=708379 Review-Url: https://codereview.chromium.org/2797923003 Cr-Commit-Position: refs/heads/master@{#462977}
-
gogerald authored
Design doc: https://docs.google.com/document/d/1izV4uC-tiRJG3JLooqY3YRLU22tYOsLTNq0P_InPJeE To test: 1) Install BobPay.apk from https://drive.google.com/a/google.com/file/d/0B3ISiXgGE1MNc1FCNlZkN3FMMWs/view?usp=sharing 2) Enable chrome://flags/#android-payment-apps. 3) Navigate to https://rsolomakhin.github.io/pr/bob/. 4) Click "Buy" button on the webpage. BUG=707246 Review-Url: https://codereview.chromium.org/2807733002 Cr-Commit-Position: refs/heads/master@{#462976}
-
rajendrant authored
This CL records the network data use for downloading favicons. Also the size of non 200 responses for favicon requests are recorded. BUG=698347 Review-Url: https://codereview.chromium.org/2764893003 Cr-Commit-Position: refs/heads/master@{#462975}
-
Daniel Cheng authored
BUG=578344 R=danakj@chromium.org Review-Url: https://codereview.chromium.org/2805893003 . Cr-Commit-Position: refs/heads/master@{#462974}
-
pdfium-deps-roller authored
https://pdfium.googlesource.com/pdfium.git/+log/1e8c39f18df6..6a5c20cd0874 $ git log 1e8c39f18..6a5c20cd0 --date=short --no-merges --format='%ad %ae %s' 2017-04-07 npm Remove the ICC transform where it is never initialized. Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Review-Url: https://codereview.chromium.org/2796303010 Cr-Commit-Position: refs/heads/master@{#462973}
-
sahel authored
BUG=526463 Review-Url: https://codereview.chromium.org/2802993003 Cr-Commit-Position: refs/heads/master@{#462972}
-
dougt authored
In converting accLocation() in BrowserAccessibility to use AXPlatformNode, we found that the simple model of using local coordinates plus a global offset just doesn't work. In Views we've been able to get away with this simple model because Views do not have the same nested transformations that the web can like rotation and scaling. This change also allows us to remove GetGlobalCoordinateOffset() as the x.() and y.() of the result of GetScreenBoundsRect() can be used instead. BUG=703369 Review-Url: https://codereview.chromium.org/2795543002 Cr-Commit-Position: refs/heads/master@{#462971}
-
hongchan authored
This CL add two assertions that abstracts the checks for JavaScript traits. - should().ownProperty() - should().inheritFrom() BUG=702708 TEST=webaudio/unit-tests/audit.html Review-Url: https://codereview.chromium.org/2805773002 Cr-Commit-Position: refs/heads/master@{#462970}
-
glebl authored
Because of the implementation specific of the layout opportunity iterator an empty opportunity can mean 2 things: - search for layout opportunities is exhausted. - opportunity has an infinite size. That's because CS is infinite. This patch fixes DCHECK crashes when we return an infinite opportunity. BUG=635619 Review-Url: https://codereview.chromium.org/2801053004 Cr-Commit-Position: refs/heads/master@{#462969}
-
zpeng authored
This CL updates third_party/checkstyle to 7.6.1 so checkstyle would work with Java 8 lambda features. BUG=703238 Review-Url: https://codereview.chromium.org/2799303003 Cr-Commit-Position: refs/heads/master@{#462968}
-
lgarron authored
BUG=661799 Review-Url: https://codereview.chromium.org/2800563002 Cr-Commit-Position: refs/heads/master@{#462967}
-
kylixrd authored
Added EscapeString() to convert certain characters into XML escape (&xxx;) sequences BUG=708705 Review-Url: https://codereview.chromium.org/2803613003 Cr-Commit-Position: refs/heads/master@{#462966}
-
bpastene authored
TBR=jbudorick@chromium.org BUG= Review-Url: https://codereview.chromium.org/2800113002 Cr-Commit-Position: refs/heads/master@{#462965}
-
kbr authored
https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/d0783b8..32cfddc BUG=685232, 701060, 709351 TEST=bots TBR=zmo@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2798083005 Cr-Commit-Position: refs/heads/master@{#462964}
-
zpeng authored
This CL updates WebApkInstaller so that the murmur2 hash of the best badge icon would be calculated and passed to the WAM server in WebAPK proto along with the url of the best badge icon. BUG=649771 Review-Url: https://codereview.chromium.org/2676863002 Cr-Commit-Position: refs/heads/master@{#462963}
-
tedchoc authored
BUG=695306 Review-Url: https://codereview.chromium.org/2802303002 Cr-Commit-Position: refs/heads/master@{#462962}
-
minch authored
1. Sticky keys 2. Tap dragging Changes in this CL, 1. Add four functions in AccessibilityDelegate interface. This is used to show above two a11y features in system menu. BUG=632107 Review-Url: https://codereview.chromium.org/2802783002 Cr-Commit-Position: refs/heads/master@{#462961}
-
jbauman authored
This software isn't under our control, so suppress deadlock warnings we can't fix. BUG=691029 Review-Url: https://codereview.chromium.org/2807523002 Cr-Commit-Position: refs/heads/master@{#462960}
-
dgozman authored
This is a logical thing to do by itself, improves performance and makes it easier to reason about things. It may also help to prevent crashes if we somehow get into inconsistent state by not calling delegate methods at random times. Although not directly fixing the linked crash, I expect it to go away. BUG=704346 TBR=dtrainor@chromium.org Review-Url: https://codereview.chromium.org/2799783006 Cr-Commit-Position: refs/heads/master@{#462959}
-
hongchan authored
This CL is the second part of the conversion. It manually replaces: - RELEASE_ASSERT() with CHECK(). - ASSERT(...args) with one or more DCHECK_op(arg). With this CL the following script returns 0 result. ``` cd ${CHROME_SRC}/third_party/WebKit/Source/platform/audio grep -rnw . -e 'ASSERT(' ``` BUG=707655 Review-Url: https://codereview.chromium.org/2803073002 Cr-Original-Commit-Position: refs/heads/master@{#462904} Committed: https://chromium.googlesource.com/chromium/src/+/f90cae07269c724f98ca3c196ea37ce7f6a801d5 Review-Url: https://codereview.chromium.org/2803073002 Cr-Commit-Position: refs/heads/master@{#462958}
-
wychen authored
BUG=693650 Review-Url: https://codereview.chromium.org/2803823004 Cr-Commit-Position: refs/heads/master@{#462957}
-
rtoy authored
The v8 bindings layer does the finite check for us so we don't have to check again. BUG=709061 TEST=covered by existing tests Review-Url: https://codereview.chromium.org/2804083004 Cr-Commit-Position: refs/heads/master@{#462956}
-
boliu authored
These are the only two (important) calls that do not have a return value, so can be made oneway. "oneway" is roughly equivalent to being asynchronous, since binder calls are synchronous by default. This is like an early test to make sure oneway doesn't cause issues. BUG=689758 Review-Url: https://codereview.chromium.org/2799683007 Cr-Commit-Position: refs/heads/master@{#462955}
-
skau authored
Flips the polarity of the --enable-native-cups flag to --disable-native-cups. BUG=583155 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2475813002 Cr-Commit-Position: refs/heads/master@{#462954}
-
dschuyler authored
This CL applies a pull request submitted to Polymer to add RTL support for paper-sliders. BUG=696437 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2801193002 Cr-Commit-Position: refs/heads/master@{#462953}
-
servolk authored
BUG=708808 Review-Url: https://codereview.chromium.org/2805533005 Cr-Commit-Position: refs/heads/master@{#462952}
-
macourteau authored
Screenshot: http://imgur.com/a/7WXgf BUG=602666 Review-Url: https://codereview.chromium.org/2807583003 Cr-Commit-Position: refs/heads/master@{#462951}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/7d3d87233190..4e3abc1ad5f0 $ git log 7d3d87233..4e3abc1ad --date=short --no-merges --format='%ad %ae %s' 2017-04-07 reed cacherator upscales colortables to unify caching 2017-04-03 halcanary SkMultiPictureDocument : clean up MultiPictureDocumentReader interface 2017-04-07 robertphillips Make GrCopySurfaceOp friendlier to GrSurfaceProxy (take 2) 2017-04-07 scroggo Simplify subset computation in SkGifImageReader 2017-04-06 mtklein stop disabling threadsafe statics 2017-04-07 borenet Fix missing valgrind.supp in recipe-bundled tasks 2017-04-07 kjlubick Add ChromeOS Test/Perf jobs and recipe changes 2017-04-06 halcanary SkTypeface_win_dw: populate_glyph_to_unicode uses lowest unichar 2017-04-06 mtklein simplify SkRRect serialization 2017-04-06 mtklein Try disabling MSAN workarounds in SkJpegCodec 2017-04-07 borenet Reland: Use bundled recipes for all test/perf tasks 2017-04-06 mtklein jumper, gather_f16 Created with: roll-dep src/third_party/skia BUG=538133 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: I31295c32b1fde854b28bc400f41c82c3c9bfe307 Reviewed-on: https://chromium-review.googlesource.com/471049Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#462950}
-