GitLab

Bug: 827128
Change-Id: Id23ecbb271fc2b27b6bd06a66d260d1dd4dfe27b
Reviewed-on: https://chromium-review.googlesource.com/1028553
Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559361}

BUG=837155

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I51327a0a0fcd8f23050ccc214f0169e8b6740e6d
Reviewed-on: https://chromium-review.googlesource.com/1051262Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Xing Xu <xing.xu@intel.com>
Cr-Commit-Position: refs/heads/master@{#559360}

Users need to be able to preview any of the possible voices in order to
be able to pick a reasonable default. Now, to preview the voice, the
tts_handler requests the tts_controller to speak directly, which allows
for more control over the voice used than window.speechsynthesis.

Re-ordering page after discussion with a11y team about common use-cases.

Bug: 823359
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I0e12d1a2865ae5ab9281b5a08d578ad49b1999f2
Reviewed-on: https://chromium-review.googlesource.com/1052925
Commit-Queue: Katie Dektar <katie@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559359}

Current we have a NOTREACHED() which essentially DCHECK that
MediaDrmBridge::IsKeySystemSupported(key_system) must return true. This
DCHECK is based on the fact that we called the same function when
deciding whether the key system is supported [1]. However, that is
called in the browser process and the DCHECK is in the GPU process.
Also, the DCHECK could happen much later. Further, the implemenation of
MediaDrmBridge::IsKeySystemSupported() actually calls into Java
MediaDrm, where it's hard to assume what it'll return.

This CL removes the NOTREACHED() so that if that happens we'll just
fail. UMA is also added to track how often this happens in the field.

[1] See CdmMessageFilterAndroid::OnQueryKeySystemSupport()

Bug: 843784
Change-Id: I6ce743033811e4d2bfbde75ccb715697e6205063
Reviewed-on: https://chromium-review.googlesource.com/1062803
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559358}

https://pdfium.googlesource.com/pdfium.git/+log/33515fbec463..98ec53359b8e

$ git log 33515fbec..98ec53359 --date=short --no-merges --format='%ad %ae %s'
2018-05-16 rharrison Add support for PartionRealloc to return nullptr
2018-05-16 thestig Update third_party/base/bits.h.
2018-05-16 tsepez Remove some more unused #defines
2018-05-16 tsepez Move FX_LBUN shorthand codes from .h to .cpp file

Created with:
  roll-dep src/third_party/pdfium
BUG=chromium:783022


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I6a02d43557a7e40c91e953fb0a1324bb44d7710d
Reviewed-on: https://chromium-review.googlesource.com/1062772
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#559357}

This CL adds Stability.ChildFrameCrash.Visibility which is logged after
detecting that a sad subframe is shown.  The logged enum describes the
timing of a renderer crash in relation to whether the subframe is
visible or not.

Bug: 841493
Change-Id: Ic893764817bd1a9aa31684d53f858a398a31dfc8
Reviewed-on: https://chromium-review.googlesource.com/1054099Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Lucas Gadani <lfg@chromium.org>
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559356}

CMake does not like .cc files mixed with .h files in add_library targets
so we filter only for .cc files.

Bug: 827294
Change-Id: I793d39b90d5f38d9c66704b19c39d0cc48ebdf43
Reviewed-on: https://chromium-review.googlesource.com/1062076
Commit-Queue: Peter Wen <wnwen@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559355}

Currently MediaDrmBridge::Create() is doing a lot of work, including
initializing storage and fetching origin ID. We also plan to handle
provisioning as part of MediaDrmBridge creation (see Bug).

Given MediaDrmBridge::Create() is a static function, there's no easy way
to hold objects we created before MediaDrmBridge is finally created and
initialized. For example, today we have to bind MediaDrmStorageBridge
into a callback. This makes the code harder to read. Also, if the
storage never fires the initialization callback, the object will be held
in the callback even after CdmFactory is destroyed, making the lifetime
more complex. For another example, for finish provisioning before firing
|cdm_created_cb|, we also need a way to hold the created-not-provisioned
CDM.

This CL adds a MediaDrmBridgeFactory to hold the async creation logic
and temporary objects. AndroidCdmFactory owns MediaDrmBridgeFactory so
that if AndroidCdmFactory is destroyed, the creation of CDM is cancelled
cleanly.

Bug: 834965
Change-Id: I890d800e7ef86df85a8b027d41154148db706e57
Reviewed-on: https://chromium-review.googlesource.com/1059011Reviewed-by: John Rummell <jrummell@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559354}

Implement NGBoxFragmentPainter::AdjustForScrolledContent among requisite
support methods. Falls back on the underlying layout object for overflow
computation for now as scrolling and overflow isn't supported by NG yet.

Test: fast/overflow/overflow-with-local-background-attachment.html
Bug: 714962
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Idd77f7ef5c55f320255325045ed5cc00d14fa159
Reviewed-on: https://chromium-review.googlesource.com/1062325Reviewed-by: Aleks Totic <atotic@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559353}

SitePerProcess and IsolateOrigins work on Chrome Desktop (including Chrome OS).
We don't want to make them work on Android, because enterprises that want and
can use SI on Desktop might not have an Android fleet capable of it yet. For
those that do also want SI on Android, these new Android-specific settings
enable that.

BUG=783842,760761

TEST=Enable one of the new Android-specific policy settings (e.g.
IsolateOriginsAndroid) for an enterprise-managed Android device, then follow the
verification steps given in https://support.google.com/chrome/a/answer/7581529
(under "Verify Site Isolation"). Then do the same but with the other policy
setting (e.g. SitePerProcessAndroid). For both, check also that enabling only
the Android-specific policies does not enable SI on Desktop machines in the same
management domain.

Change-Id: Id304937132723a6856b0e507bc4b9d801403c429
Reviewed-on: https://chromium-review.googlesource.com/1026390Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Chris Palmer <palmer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559352}

A series of tests in viz_browser_tests and viz_content_browsertests have been
fixed, but no re-enabled.

This re-enables them.

TBR=kylechar@chromium.org
TEST=viz_browser_tests, viz_content_browsertests

Bug: 	794961
Change-Id: Ife0401cc891696a549aa180cbc0cf0034bc5bc5c
Reviewed-on: https://chromium-review.googlesource.com/1062812Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559351}

In the WebUI dialog, this is shown with the same display icon [1].
In the Views dialog, this uses the new input icon [2].

[1] https://cs.chromium.org/chromium/src/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js?l=962
[2] https://cs.chromium.org/chromium/src/chrome/browser/ui/views/media_router/cast_dialog_sink_button.cc?sq=package:chromium&l=36

Bug: 826393
Change-Id: I44333292ba95695fd64b5421303a1c8d75a74459
Reviewed-on: https://chromium-review.googlesource.com/1052912Reviewed-by: Adam Parker <amp@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559350}

This CL adds the controller changes for the download progress infobar.
UX : https://docs.google.com/presentation/d/1wfX6QkEzDbt3Bx2hj6v85_lND1iSUUfXIZN6TMhREuo

Key points :
1 - The controller listens to all the updates from downloads and offline
content agggregator. It converts download items into offline items,
keeps track of all the offline items in a current session.
2 - The state transitions between accelerating, downloading one or more
files, downloads complete/failed/pending etc is handled in the controller as per the UX.

Bug: 1003754
Change-Id: Id7d3d9f91616c79facbcf87a82346f70709e2af2
Reviewed-on: https://chromium-review.googlesource.com/1003873Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559349}

Removes the last dubious API surface (size_t usage) in the core ABI and
documents the ABI as stable.

Bug: 822034,819046
Change-Id: I60438dd6613d45738514a92ce8c21777b859bfee
Reviewed-on: https://chromium-review.googlesource.com/1062932Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559348}

In Blink, we parse floating point numbers such as those from ARIA value now from strings to doubles.

In the midst of conversions, we incur some amount of errors (trailing garbage) when converting from doubles to floats.

To see this, within Blink,

LOG(ERROR) << "Float valueNow=" << base::NumberToString(float_value);

for the snippet:
<div role="progressbar" aria-valuenow=0.05>

You will see:
0.05000000074505806

V8 uses doubles in its underlying number type.

For the purposes of automation, default to a precision of 2 decimal places.

Since the underlying data is always available, we can consider exposing a more full featured api like GetFloatAttribute(int precision) to the wrapping js and on up to chrome.automation.AutomationNode, if needed.

Bug: 841972
Change-Id: Ideb979d43d7ed28bae8a5293f0f40fb2a7c79199
Reviewed-on: https://chromium-review.googlesource.com/1058448Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559347}

The issue here is that viewports_need_updating_ is uninitialized until
OnResume, and that leaves viewports uninitialized until the first
DrawFrame after OnResume.

However, some incoming calls from mojo, such as UpdateLayerBounds may
be processed before that first DrawFrame.

The fix is to initialize viewports_need_updating_ to true, so viewports
are created in InitializeRenderer, before mojo calls are processed.

This then creates a new bug, where we lose the UVs set by a call to
UpdateLayerBounds before the first OnResume/DrawFrame. We need to cache
the bounds and can reapply them when creating new viewports.

BUG=839108

Change-Id: Ieef7f98d9606fe033095e8b8a8e9cde92afdcccc
Reviewed-on: https://chromium-review.googlesource.com/1062930Reviewed-by: Klaus Weidner <klausw@chromium.org>
Commit-Queue: Bill Orr <billorr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559346}

R=hinoka@chromium.org

Bug: 843638
Change-Id: I80fc3f991b697298c8866d6e81ea64e7c1aed256
Reviewed-on: https://chromium-review.googlesource.com/1062944Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Commit-Queue: Sergey Berezin <sergeyberezin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559345}

They were missing the snapshot-level annotations (prod, ver, plat, and
channel), client ID, and report ID.

Bug: 842806
Change-Id: Ic6784728d57e747515197bc45e990cb2bb684834
Reviewed-on: https://chromium-review.googlesource.com/1062807Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559344}

Bug: 842865
Change-Id: I46f2b69c56ae157e72d4e513e326094fb050b288
Reviewed-on: https://chromium-review.googlesource.com/1058592Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559343}

Sometimes a function would have multiple signatures in the IDL files
with the difference just being some of the arguments are optional.
This patch improves the deduplication logic to correctly support
array.splice(start, ?deleteCount, ...items)

Change-Id: Ie9230d54dadd1c8c7cadbb92afc37fbfa87ea857
Reviewed-on: https://chromium-review.googlesource.com/1062885Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559342}

A min-height was only supposed to apply within settings, so this CL
moves that back.

Even after that though, the cr-radio-button would have a forced 40px
height due to how disc-wrapper and ripples were styled. This CL adjusts
the styling such that the circle only takes up 16x16 space in the layout,
and instead the ripple is absolutely positioned and out of the layout.

Note that settings has styling to override min-height and padding
of cr-radio-buttons, so visuals before and after this CL is unchanged, but
this will make replacing paper-radio-button with cr-radio-button
outside of settings easier.

Bug: 840527
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Idc7d52cd8ced581bd81ac682cadf97ae4948fb55
Reviewed-on: https://chromium-review.googlesource.com/1060517Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559341}

Implement the frontend mojo interface for chrome://snippets-internals
and talk to the backend interface.

Bug: 830931
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ifc1e1d890153ac90a62fff82e15cdb8724ca0b09
Reviewed-on: https://chromium-review.googlesource.com/1053381
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559340}

- Move ui/arc into ash/system/message_center/arc
- Merge ui_arc_unittests into ash_unittests

Bug: 768439
Change-Id: I56dd855ee2b4defefd9c57fd0c1b5bda453e61e7
Reviewed-on: https://chromium-review.googlesource.com/1053302
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559339}

Animating looks bad for OOBE, and doesn't really make things look much
better in general.

Bug: internal b/77704079
Test: cast something
Change-Id: I37784c5952873eb0f8d1e0f79e8dd650f176f73f
Reviewed-on: https://chromium-review.googlesource.com/1047997Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Thoren Paulson <thoren@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559338}

Bug: 838354
Change-Id: Icf745b379da838efcddf58a723c03fa71ad814c4
Reviewed-on: https://chromium-review.googlesource.com/1060640
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559337}

Currently, when the keyboard is shown, we check if it obscures the
focused window. If it does, we move the focused window upwards so that
it's no longer obscured by the text field.

While this works well for the docked keyboard, it doesn't make much
sense for the floating keyboard. Thus, we change the logic to use
the occluded bounds of the keyboard to check whether it obscures the
focused window. The occluded bounds is the same as the actual bounds
for the docked keyboard, but is empty for the floating keyboard. This
means that the floating keyboard will no longer cause the focused
window to move upwards.

Bug: 838731
Change-Id: Id5de5c35980c69443be114631840bdfb64f26b3e
Reviewed-on: https://chromium-review.googlesource.com/1059976Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559336}

Change-Id: I5e9e977d1fd072b8b7f2b3ce8193214bb6c8fe4a
Reviewed-on: https://chromium-review.googlesource.com/1060431Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559335}

Bug: 831803
Change-Id: Ib1d125d22cbec36fc09e544db00d8c4cd10b5190
Reviewed-on: https://chromium-review.googlesource.com/1045839
Commit-Queue: Peter Williamson <petewil@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559334}

This fixes a problem when the StoreKit is dismissed, the URL stays on the omni box.
Where it should be reverted to the last item.

Bug: 842725
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I2c645289209d0ae03b09d60e9b90d42565bca057
Reviewed-on: https://chromium-review.googlesource.com/1060346Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559333}

This change was made by the update-test-expectations script.

Recent test results history:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=http/tests/appcache/abort-cache-onchecking-resource-404.html,http/tests/d
om/create-contextual-fragment-from-svg-document-range.html,http/tests/cache/zero-length-xhr.html

Bug: 762008, 762399, 762423
Change-Id: If563520cb19cc426ddf93581570cfb3d4b76f7d5
Reviewed-on: https://chromium-review.googlesource.com/1062601Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559332}

Bug: 834993
Test: --enable-features=EnableHomeLauncher, --new-wallpaper-picker
Change-Id: I499db4f6bbb5511f5feb6da0b5df5ccd7ef1143f
Reviewed-on: https://chromium-review.googlesource.com/1058490
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559331}

Bug: 806990
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I88014d77169c3b6f75c5905fa4219b8be92e6fa4
Reviewed-on: https://chromium-review.googlesource.com/1060265Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559330}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8de3800ce55b..ed1bb34fc59e

$ git log 8de3800ce..ed1bb34fc --date=short --no-merges --format='%ad %ae %s'
2018-05-16 ehmaldonado gclient: Remove condition_value.
2018-05-16 ehmaldonado gclient: Merge hook_os with hooks and deps_os with os.
2018-04-26 ehmaldonado Reland "bot_update: Patch on gclient by default."

Created with:
  roll-dep src/third_party/depot_tools
BUG=chromium:839925,chromium:839925,chromium:643346


The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I593c53bdc762894bd3c7bdf61337327f4e2763f9
Reviewed-on: https://chromium-review.googlesource.com/1062929Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#559329}

https://chromium.googlesource.com/catapult.git/+log/d95db22a613c..a7e134aa0dbf

$ git log d95db22a6..a7e134aa0 --date=short --no-merges --format='%ad %ae %s'
2018-05-16 szager Refactor browser_interval_profiling_controller
2018-05-16 benjhayden Add google-signin to third_party/polymer2.
2018-05-16 nednguyen Add logging of the apk name picked by android backend settings
2018-05-16 benjhayden Add paper-checkbox to third_party/polymer2.
2018-05-16 benjhayden Add polymer-redux to third_party.
2018-05-16 eyaich Updating telemetry smoke-test-mode flag to not take a value
2018-05-16 benjhayden Add paper-input to third_party/polymer2.
2018-05-16 nednguyen Make sure Telemetry use <benchmark>/<story_name> consistenly when printing to stdout

Created with:
  roll-dep src/third_party/catapult
BUG=chromium:839645,chromium:843516,chromium:840427


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=sullivan@chromium.org

Change-Id: I25330250acecec6a49829102e25e07ff8b35db93
Reviewed-on: https://chromium-review.googlesource.com/1062933
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#559328}

This reverts commit 1f4fc1f7.

Reason for revert: Speculating that this is the root cause of https://crbug.com/843725

Original change's description:
> Add dummy benchmarks to chromium waterfalls
>
> Bug: 840427
> Change-Id: I44364a9c3954b14118c77c51cfd454be3919c1f2
> Reviewed-on: https://chromium-review.googlesource.com/1055776
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Reviewed-by: Ned Nguyen <nednguyen@google.com>
> Commit-Queue: Emily Hanley <eyaich@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#559076}

TBR=nednguyen@google.com,eyaich@chromium.org,jbudorick@chromium.org

Bug: 843725
Change-Id: I10fa2c1c631e3d43b31f610f4af40756840e9ba2
Reviewed-on: https://chromium-review.googlesource.com/1062711Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Emily Hanley <eyaich@chromium.org>
Commit-Queue: Emily Hanley <eyaich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559327}

No change to logic.

This removes the 'public' visibility modifier from methods on public
interfaces, as these methods are implicitly public (and this is a lint
warning on the Android side).

Bug: 843420
Test: N/A
Change-Id: I17ea506f8cb7965c80e2489d985d1a3f2476fb50
Reviewed-on: https://chromium-review.googlesource.com/1062965Reviewed-by: Paul Miller <paulmiller@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559326}

Add edit link for NTP custom backgrounds. This should only
be visible when both the flag is enabled and a custom theme is
not being used.

Bug: 839152
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I00cb54167ba099da18d5999eb60c98c7bf8f2447
Reviewed-on: https://chromium-review.googlesource.com/1060126
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559325}

Creates new tableviewtextactionbuttonitem and tableviewtextactionbuttoncell for signed in, but not synced, state in recent tabs.
Can be reused for signin promo when that time comes.

Screenshot: https://drive.google.com/open?id=14BFzN7256LtFGvGUl2yU9HDOFqaBQisJ

Bug: 822988
Change-Id: I9634282b7e65d2d740db43f6425413a69b25b5b8
Reviewed-on: https://chromium-review.googlesource.com/1048873
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559324}

The cause is a typical mojo message race. SessionController and
MediaController use different mojo message pipes. The problem
happens when two or more users are added to the system and somehow
MediaController call is delayed after SessionController calls.
As a result, MediaController calls contains a stale capture states
array (less than actual users). MultiProfileMediaTrayView uses
a user index based on SessionController's view and would hit an
index out of bound error when accessing the stale data.

Make MultiProfileMediaTrayView::OnMediaCaptureChanged use size of
the passed-in |capture_states| to fix the problem. This should be
fine since it is transient and there should soon be another
MediaController::NotifyCaptureState call.

Bug: 842442
Change-Id: Ife6ea23c85d27e2e89a042bb849ef03af4ccc061
Reviewed-on: https://chromium-review.googlesource.com/1062716Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559323}

|current_size_| is unused so this CL removes it.

Bug: 672962
Change-Id: Ief6fc89d6e207672e12a5e1c929ff6dc0ba5f5dd
Reviewed-on: https://chromium-review.googlesource.com/1062655Reviewed-by: Saman Sami <samans@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559322}