GitLab

Use View's property for these two member variables in MdTextButton.

TBR=cjgrant@chromium.org,derat@chromium.org
BUG=957270

Change-Id: I4d06fad56f0f48f88be184847851bfed9e94c4ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609614
Commit-Queue: Wei Li <weili@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659262}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/ccf1a17964ab..4e4b7dee3c41


git log ccf1a17964ab..4e4b7dee3c41 --date=short --no-merges --format='%ad %ae %s'
2019-05-13 alevkoy@chromium.org Mark moblab-generic-vm experimental
2019-05-13 mikenichols@chromium.org chromeos-config:  Disable build affinity for CQ builders
2019-05-13 saklein@chromium.org scarlet-pre-cq: Use -chrome_internal.


Created with:
  gclient setdep -r src/third_party/chromite@4e4b7dee3c41

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Change-Id: I8be8e88bbec9b4fa1c00e8810591283c89dbb676
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610350Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#659261}

crrev.com/c/1604427 removed the result field from the heartbeat reponse
and made set_interval_seconds take its field. However, the server side
change didn't take effect on time so the host still sees the 'SUCCESS'
result and interprets it as a 1s heartbeat delay, which is too frequent
and thus a "tarchycardia".

This CL prevents future host tarchycardia by enforcing a minimum
heartbeat interval on the host.

Bug: 954695
Change-Id: I87b3a52bafa17dd46246b4f488e4478d7884e91f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610852Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659260}

When a.com embeds a PDF in b.com, {embed, object}.postMessages sends the
messages from a.com to the WebRemoteFrame corresponding to the GuestView.

On the browser side, the target RenderFrameHost is determined to be the outer
WebContents's frame that is used to attach MimeHandlerViewGuest. This means
at the end of routing, the IPC ends up going to a dead RenderFrameHost (dropped
on the way since there is no RenderFrame to handle it).

This CL fixes this issue by a) checking if target RenderFrameHost is live, and
b) if not try to find an inner delegate or drop the message.

Note that this CL fixes several tests which currently fail (or timeout) with
--enable-features=MimeHandlerViewInCrossProcessFrame (the list of such tests
is included in the linked bug). This CL fixes some of those tests and together
with https://crrev.com/c/1607425 should make most tests including all of the
PDFExtensionTest* pass (with the flag).

Bug: 961786
Change-Id: I876b971f40d54f3386e23b9750420bbfc1bbbe01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606769
Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659259}

This should help investigating a recurring crash (see linked bug).

Bug: 957121
Test: none
Change-Id: I78f30855201ebd9fb4d8d1738131f5c2308f1e44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586227
Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org>
Commit-Queue: Peter Beverloo <peter@chromium.org>
Auto-Submit: Vladislav Kaznacheev <kaznacheev@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Tim Song <tengs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659258}

Bug: 960564, 900188
Change-Id: Ie4650b0aa9d57a9932a6b2cace8ca46a01fa4130
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601687Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659257}

The main goal is to avoid session start delay while chrome is
attempting to fetch fresh child user's policy. The user session manager
implements fetch timeout (so tests pass without this), but waiting for
it adds some 10s to test login.

To fix this:
*   have login manager mixin mark child users as requiring policy
*   add support for configuring policy test server (in addition to
    session manager cache) to user policy mixin
*   add utility method to fake gaia to setup child user credentials
    (needed as policy fetch will be blocked on getting policy
     auth token)

Bug: None

Change-Id: I5a2e65a4cbf1e9ce192fb0ac750a1661f895e462
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602153Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Denis Kuznetsov <antrim@chromium.org>
Reviewed-by: Aga Wronska <agawronska@chromium.org>
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659256}

Bug: 931843
Change-Id: I585768f94c6b71558b35b0a1598bb1bc65cc6f2f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610571Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Commit-Queue: Sophie Chang <sophiechang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659255}

Also skip lofi fallback test in M74, that fails due to server support
removed.

Bug: 934875
Change-Id: Ic5d0d00d63d95cf458e0afc3eaf0a3cf16743c01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611078Reviewed-by: Robert Ogden <robertogden@chromium.org>
Commit-Queue: rajendrant <rajendrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659254}

This CL add a check to properly populate fullscreen option.

Bug: 942156
Change-Id: I8227a91cac36c57ff1f63065af8cea72f34ee344
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610585Reviewed-by: Tommy Steimel <steimel@chromium.org>
Commit-Queue: Jazz Xu <jazzhsu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659253}

Follow up for issue 959125 where we add a test for an AudioWorklet to
verify that if a source connected to an AudioWorklet stops, the
AudioWorklet still continues to call process.

Bug: 960590, 959125
Test: the-audioworklet-interface/simple-input-output.https.html
Change-Id: I3db82c29737c084c576d81bd067741ca5e1845ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600406Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659252}

Change-Id: If951059de8e60009df6a3f4b9075bdda56dd761e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604042
Auto-Submit: Lakshman Annadorai <lakshmana@chromium.org>
Reviewed-by: Mike Wittman <wittman@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659251}

This CL changed the way how we handle conversion failures from strings.
Instead of using the default values, this CL returns 'false' to indicate
the conversion errors. This returned result is useful in case we need to
handle more complex type conversions such base::optional type.

Also, this CL simplify the type converter function definitions since we
only need to and from string conversions, not between arbitrary two
types.

BUG=938501

Change-Id: I1e6d8510c39a9a240161aa0b36c2141ab62ed0e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606772
Commit-Queue: Wei Li <weili@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659250}

Bug: 927840
Change-Id: I97ca518d172c0e208b0d8828c2c73d78c0b4523a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610223Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Greg Kerr <kerrnel@chromium.org>
Auto-Submit: Greg Kerr <kerrnel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659249}

https://pdfium.googlesource.com/pdfium.git/+log/3475b482fefa..b2d0ebdef207


git log 3475b482fefa..b2d0ebdef207 --date=short --no-merges --format='%ad %ae %s'
2019-05-13 thestig@chromium.org Remove unneeded iostream includes.
2019-05-13 thestig@chromium.org Remove a static initializer in fx_dib_main.cpp.
2019-05-13 patrik@pspdfkit.com Add documentation about pixel tests and in files.
2019-05-13 tsepez@chromium.org Make CXFA_LayoutItem inherit from fxcrt::TreeNode<>.


Created with:
  gclient setdep -r src/third_party/pdfium@b2d0ebdef207

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=pdfium-deps-rolls@chromium.org

Change-Id: I85e8ee93c39abd4e47d1af92719757c4fe257a13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610839Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#659248}

Language details page allows the user to choose whether or not Translate
should be offered for a given language. If Translate cannot be offered for
a language such as the last Translate-blocked language or the target
language, the option to "Offer Translate" is disabled for it.

Demo: https://drive.google.com/file/d/0B2sUCLY7X-D2enZRZE9hUmUwa0pjNkpYWHVFbzV6cEhDbUVr/view?usp=sharing

Bug: 957688
Change-Id: I0a6b6286c2097c460bb41c33b274e96d9cde3fbf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601979Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659247}

Js2at is a project that allows web pages and ChromeVox to exchange messages that
conform to a set of approved schemas, and can allow page behavior to be
customized.

Note: js2at is currently built as an extension. If it is ever built into the
browser the connection mechanism may change, and this line may no longer be
necessary.

The following code connects to js2at:
chrome.runtime.onConnectExternal.addListener((port) => {
  if (port.name === 'js2at->cvox') { /* Do something */ }
});
js2atPort.onMessage.addEventLister(receiveMessageCallback);
js2atPort.postMessage(messageToSend);

Bug: None
Change-Id: I5d662c641d6534d6c02bb2777ae13c0a3a725dfa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610477Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659246}

We have identified a slightly larger set of tests which we would like
skia_renderer_content_browsertests to run.

This increases the list from 4 tests to 20. With the runtime of the
suite increasing from 6.6s to 9.6s

TEST=skia_renderer_content_browsertests

Bug: 956140
Change-Id: Iac40ecdc8104a8b8c03d50fba80c0641288e0c02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605161Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659245}

This reverts commit 310bb105.

Reason for revert: Broke build
https://ci.chromium.org/p/chromium/builders/ci/Android%20Release%20%28Nexus%205X%29/19635

Original change's description:
> Progress on the Revamped context menu
> 
> This CL consists of:
> - Improvements for URL formatting (i18n and emphasizing)
> - Addition of grey background while loading
> - Addition of favicons, monograms, and thumbnails
> - Addition of checkered pattern behind the transparent PNGs
> - Some visual polish and fixes
> 
> Bug: 655359
> Change-Id: I6ebf13b6097780db22c05804f2b9cdf6d1ee8461
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595114
> Reviewed-by: Theresa <twellington@chromium.org>
> Commit-Queue: Sinan Sahin <sinansahin@google.com>
> Cr-Commit-Position: refs/heads/master@{#659233}

TBR=twellington@chromium.org,sinansahin@google.com

Change-Id: I8f9de27b1749a19e650dc3339b4de2fc2a996039
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 655359
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611079Reviewed-by: Alexei Filippov <alph@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659244}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/4894cb22..cbffd54f

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Iae123c0e8b47b31ff3a196c65a393f23580406c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609671Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#659243}

Fails to compile.

Bug: 962650,790202
Change-Id: Id515d645a8d701a3d495c41a170a5272a689c4f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610259
Commit-Queue: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Auto-Submit: John Budorick <jbudorick@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659242}

This change updates a couple of strings in the reset process to match
suggestions from UX team.

TBR=dbeam@chromium.org

Bug: 960766
Change-Id: I6c908f31e5241725de936724480dbac864f3132c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610575
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Auto-Submit: Adam Langley <agl@chromium.org>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#659241}

Roll ICU to e3d32ff from 3a162e7
https://chromium.googlesource.com/chromium/deps/icu.git/+log/3a162e7..e3d32ff

Testing code in
https://chromium-review.googlesource.com/c/v8/v8/+/1601370
To test, in v8, after build debug, run
tools/run-tests.py  --outdir=out/x64.debug unittests/DateCache.AdoptDefaultMixed

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Test: v8 unittests - DateCache:AdoptDefault*
Bug: chromium:950851
Change-Id: Ia540496882f4eca408706c86199904ebb0f74336
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607506Reviewed-by: Jungshik Shin <jshin@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659240}

This is a reland of 42b45514

Original change's description:
> Notifications: Delay closing out of workarea bounds pop-ups.
> 
> When the pop-up is expanded to show inline settings, the new height can overflow
> the work area. Deleting the pop-up in this scenario triggers a crash as we're
> still in the same call stack.
> 
> BUG=957033
> 
> Change-Id: Ie8d4db393893b662b72f9c04317f9ca640a25607
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600155
> Commit-Queue: Tim Song <tengs@chromium.org>
> Reviewed-by: Peter Boström <pbos@chromium.org>
> Reviewed-by: Peter Beverloo <peter@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#658793}

Bug: 957033
Change-Id: Id9209d2a648b234f933dbbf9de908a193b4b61df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609665Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Tim Song <tengs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659239}

No functional changes.

Bug: 960587
Change-Id: I2a6d00cde5bd1da04c126848733f6abb160367e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601326Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659238}

https://swiftshader.googlesource.com/SwiftShader.git/+log/8ef6d1fe29cc..628604eefdb9


git log 8ef6d1fe29cc..628604eefdb9 --date=short --no-merges --format='%ad %ae %s'
2019-05-13 hliatis@google.com Implement vk_android_native_buffer (basic)


Created with:
  gclient setdep -r src/third_party/swiftshader@628604eefdb9

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:b/122837237
TBR=swiftshader-team+autoroll@google.com

Change-Id: I170b7a13d5fd9dd59b2dd70e40ed09f49ca7b35c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610342Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#659237}

This reverts commit 4f6f29a2.

Reason for revert:
Speculative revert for possibly breaking BookmarkBubbleViewTest.SyncPromoNotSignedIn
https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/33302?blamelist=1

Original change's description:
> Native Theme support for System Tray Focus Rings
>   -> Set Native Theme for UnifiedSystemTrayView
>   -> Remove hardcoded transparency for all focus rings
>   -> Add transparency to default focus border color in common theme
> 
> Bug: 948959
> Change-Id: Ia4ee4315a894623ca9e5c20944972ce29714e2c3
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597114
> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org>
> Reviewed-by: Tim Song <tengs@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#658705}

TBR=sky@chromium.org,tengs@chromium.org,beccahughes@chromium.org,amehfooz@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 948959
Change-Id: I9c42c2c959cdaa63fcad61719e62a2036a905086
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610860Reviewed-by: Alexei Filippov <alph@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659236}

Bug: 962555, 962636
Change-Id: I959445bef4bbc94f8e8b96c813205a49ab59419f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610606Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Commit-Queue: Shrek Shao <shrekshao@google.com>
Cr-Commit-Position: refs/heads/master@{#659235}

This reverts commit 7e9793c1.

Reason for revert: Likely caused a test break on ASAN
AccessibilityWinBrowserTest.TestPutAccValueInEditable

https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8913554617299105712/+/steps/content_browsertests_on_Windows-10-15063/0/logs/Deterministic_failure:_AccessibilityWinBrowserTest.TestPutAccValueInEditable__status_CRASH_/0

Original change's description:
> Refactor to handle ignored nodes that pass into the browser AX tree
> 
> * Introduces the concept of "in the tree" vs "ignored" in Blink without
>   changing the actual behavior. No ignored nodes are sent to the browser
>   accessibility tree.
> * Adds new function IsIgnoredPassThrough, for use when an object is
>   ignored, but should be passed through to the browser-side anyways.
>   This will be used to allow different types of ignored nodes to pass
>   through, instead of all at once.
> * Refactors browser-side code to walk only the unignored tree.
> 
> Bug:651614
> 
> Change-Id: Idbd85949a8505f8a03a08e3e002bb893619d6757
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535171
> Commit-Queue: Jacques Newman <janewman@microsoft.com>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
> Cr-Commit-Position: refs/heads/master@{#659089}

TBR=dmazzoni@chromium.org,kinuko@chromium.org,dtseng@chromium.org,aboxhall@chromium.org,mrobinson@igalia.com,kbabbitt@microsoft.com,janewman@microsoft.com

Change-Id: I1683253edf6af1498a805482eb9479a055d51af4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 651614
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610026Reviewed-by: Alexei Filippov <alph@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659234}

This CL consists of:
- Improvements for URL formatting (i18n and emphasizing)
- Addition of grey background while loading
- Addition of favicons, monograms, and thumbnails
- Addition of checkered pattern behind the transparent PNGs
- Some visual polish and fixes

Bug: 655359
Change-Id: I6ebf13b6097780db22c05804f2b9cdf6d1ee8461
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595114Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Sinan Sahin <sinansahin@google.com>
Cr-Commit-Position: refs/heads/master@{#659233}

Bug: 957260
Change-Id: Ie4200dbd0916044bee1f9cd177eeb38812f5dba3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594234
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659232}

This is improving the mojo design to have a mojo interface on which the client
can send request and observe.

Bug: 919860
Change-Id: I26dccb64009c1544ecc091d2532b53ce57fd3e40
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547060
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Eliot Courtney <edcourtney@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659231}

//skia/test_fonts' Fuchsia implementation makes use of the fuchsia.fonts
io and sys libraries, so should depend on all of them.

TBR=borenet

Bug: 952652
Change-Id: I1bd2dff61a9029069e640390435b3c86d62efa54
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610697
Commit-Queue: Wez <wez@chromium.org>
Auto-Submit: Wez <wez@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Eric Boren <borenet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659230}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7a3d1fb7569a..417f2332fcf4


git log 7a3d1fb7569a..417f2332fcf4 --date=short --no-merges --format='%ad %ae %s'
2019-05-13 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (nontrivial).


Created with:
  gclient setdep -r src/third_party/depot_tools@417f2332fcf4

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: Icda62c83e67de596f70a7912e8032f0fdb51bae9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610341Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#659229}

* adding _MS to constants names
* sorting constants names
* removing constants names with value 0
* removing one unnecessary parameter in one of functions

Change-Id: I86fbf202bb3c128bf8427478ba035f7543946016
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607801Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Marcin Wiącek <marcin@mwiacek.com>
Cr-Commit-Position: refs/heads/master@{#659228}

Change-Id: Ie519c2a70970a52b3f8b734c112eed7d2c346245
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610576Reviewed-by: Bill Orr <billorr@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659227}

Currently, profiles are passed once to Create() and once to
GetLabels(). This is problematic because certain formatters, e.g.
AddressContactFormLabelFormatters, are created specifically for the
profiles passed to Create(), and the profiles could potentially change
between the calls to Create() and GetLabels().

Now, LabelFormatters store a constant reference to a collection of
profiles to ensure that the LabelFormatter and the labels it creates are
guaranteed to be made for the same profiles.

Bug: 958333
Change-Id: I242e3a24483afa614ea8256182d57b376abcdec9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598492
Commit-Queue: Caitlin Fischer <caitlinfischer@google.com>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659226}

Our largest SQLite patch,
0001-Virtual-table-supporting-recovery-of-corrupted-datab.patch,
contains the implementation of a virtual table extension that contains
custom recovery logic. The automated tests for the extension use
SQLite's infrastructure base on Tcl, and don't run on CQ.

This CL rewrites the tests to use C++ and //sql, so they can be run on
CQ. A follow-up CL will replace the recovery code with a rewritten
version that lives in the Chromium tree.

This CL also adds a test covering the edge cases of the recovery code's
SQLite varint decoding logic, which has proven useful for debugging the
rewritten recovery code.

Bug: 945204
Change-Id: I50c6cbf6f94dc698915e6fb4925769051396cb4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603604Reviewed-by: Chris Mumford <cmumford@google.com>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659225}

CL is deleting unused interpolators in Stack.java and moving more interpolators for sharing into CompositorAnimator.java

Change-Id: I081039763d64d618809ad7066eb83c2021220e90
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594725Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Marcin Wiącek <marcin@mwiacek.com>
Cr-Commit-Position: refs/heads/master@{#659224}

Previously the app_mode_loader was packaged into a .app bundle. But
because the Info.plist is modified as part of creating app shim
shortcuts, only the executable was code signed. This left the Info.plist
as an un-sealed resource. Under stricter code signing verification rules
required for macOS notarization, an .app bundle cannot have an un-sealed
Info.plist.

To work around this, place the un-bundled executable in the Framework's
Helpers directory and store the Info.plist file under Resources. When
building app shims at runtime, the .app bundle structure will be created
manually (rather than copying the whole pre-built bundle).

Created app shims will still not be validly signed .app bundles, but the
components carried within Chrome will pass validation.

Test: Browser menu > More tools > Create shortcut creates an app
      shortcut that launches.

Bug: 960886, 850199
Change-Id: Ia4521ee436bc3288084004e247fd9765fb93816a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609886Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659223}