GitLab

BUG=

Review URL: https://codereview.chromium.org/327583002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276067 0039d316-1c4b-4281-b951-d872f2087c98

This will be implemented at a different level, reverting the non-useful
parts of r275478

TBR=jbauman
BUG=314190

Review URL: https://codereview.chromium.org/326563003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276066 0039d316-1c4b-4281-b951-d872f2087c98

The TransitionPageHelper in the embedder listens for this before fading out the transition layer.

Design doc: https://docs.google.com/a/chromium.org/document/d/17jg1RRL3RI969cLwbKBIcoGDsPwqaEdBxafGNYGwiY4/edit# 
Implementation details: https://docs.google.com/a/chromium.org/document/d/1kREPtFJaeLoDKwrfmrYTD7DHCdxX1RzFBga2gNY8lyE/edit#heading=h.bng2kpmyvxq5 
BUG=370696

Review URL: https://codereview.chromium.org/320493002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276065 0039d316-1c4b-4281-b951-d872f2087c98

Update help for cflags to reference new escaping behavior. We now escape spaces. The main reason it didn't do this before was pkg-config integration, but we now have specialized scripts to wrap pkgconfig.

Improve error message when a label doesn't match. This is a common one to run into.

Add the origin when a load fails. Previously if you mistyped a label in a dependency you would get a message about the file not loading but no location, which made it very hard to track down. This plumbs through the original location to the actual load.

R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/318383003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276064 0039d316-1c4b-4281-b951-d872f2087c98

Also fixes some build errors on non-Linux platforms.

R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/323643004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276063 0039d316-1c4b-4281-b951-d872f2087c98

which tracks the number of streams open when a QUIC session crypto handshake timed out.

Review URL: https://codereview.chromium.org/323933003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276056 0039d316-1c4b-4281-b951-d872f2087c98

Security
These libraries will only be used for internal testing only and will not be shipped.  It will not have any security impact on chrome.

Why QUnit?
1. Open source and good community support
2. Easy to configure which makes it easy to integrate with the browser test framework
3. Easy code coverage support with blanket.js
4. Its TDD style is consistent with our C++ GTest.
5. Support DOM interactions (unlike the JS2Gtest framework)

BUG=378537

Review URL: https://codereview.chromium.org/300363002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276055 0039d316-1c4b-4281-b951-d872f2087c98

The permission warning when both "tabs" and "sessions" present becomes 
"Access your browsing history on all your signed-in devices".

The permission warning when both "history" and "sessions" present becomes
"Read and modify your browsing history on all your signed-in devices".

The warning for tabs + history + sessions is the same as history + sessions.

R=kalman@chromium.org,meacer@chromium.org
BUG=123266,377607

Review URL: https://codereview.chromium.org/323633003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276054 0039d316-1c4b-4281-b951-d872f2087c98

was set on the wrong QuicConfig object.

Review URL: https://codereview.chromium.org/321003002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276053 0039d316-1c4b-4281-b951-d872f2087c98

Missing plugin file is a common cause of plugin loading failure. Explictly
report this case instead of relying on system error codes.

Note that for plugins with dependencies, this only catches the case that the
real plugin file is missing. Missing dependencies will still be reported through
error codes. One example of this is that the widevinecdmadapter.dll file depends
on widevinecdm.dll.

BUG=345852

Review URL: https://codereview.chromium.org/320523002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276052 0039d316-1c4b-4281-b951-d872f2087c98

Eliminate redirects field. Leave it up to clients to log the redirect chain if
so desired. It is not worth sending this list over the pipe each time we see
a redirect.

Add support for "follow_redirects" request parameter. Rename it with an "auto_"
suffix for greater clarity.

R=davemoore@chromium.org

Review URL: https://codereview.chromium.org/324023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276051 0039d316-1c4b-4281-b951-d872f2087c98

Calling IsOffline() could race and return an answer for a different type.

BUG=381282

Review URL: https://codereview.chromium.org/317933002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276050 0039d316-1c4b-4281-b951-d872f2087c98

This patch makes some improvements to the perf profiler in telemetry:

1. Add a prebuilt perf binary to be run on the Linux x86_64 host. This
   lets us rely on always having a recent perf binary present, allowing
   us to use source code annotation by default on Android. The binary
   also includes patches needed for importing perf data into Trace
   Viewer.

2. Use better defaults for running perf. Most importantly, sample at
   2000 Hz instead of the default 100 Hz.

3. On the Linux host, disable kernel symbol hiding for more complete
   symbolization. Note that this is also required by the new version of
   perf which this patch adds.

4. Turn on all CPUs on Android while running perf. This works around
   a bug in perf where samples from CPUs that were brought online while
   perf was running were not collected. The rationale for doing this
   only for perf instead of performance tests in general (to reduce noise)
   is that having all CPUs enabled for a long time is likely to lead to
   thermal throttling.

BUG=375754
TEST=tools/telemetry/run_tests --browser=android-content-shell TestAndroidProfilingHelper;
     tools/telemetry/run_tests --browser=android-content-shell TestPerfProfiler;
     build/android/chrome_profiler/run_tests

Review URL: https://codereview.chromium.org/316143002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276049 0039d316-1c4b-4281-b951-d872f2087c98

A few tweaks, per designer's request.

BUG=331453

for one-line change to c/b/ssl/ssl_blocking_page.cc:
TBR=palmer@chromium.org

Review URL: https://codereview.chromium.org/319303003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276048 0039d316-1c4b-4281-b951-d872f2087c98

R=davemoore@chromium.org

Review URL: https://codereview.chromium.org/323593002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276047 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
Speculative revert for breaking TestAccessibleHWND unit test.
http://build.chromium.org/p/chromium.win/builders/Win%207%20Tests%20x64%20%283%29/builds/14186

Original issue's description:
> Removing WTL from content runner.
> 
> The _Module object is used by ATL COM classes to lock the module, like so
> 
> _pAtlModule->Lock();
> 
> For example when CreateInstance is called:
> 
> BrowserAccessibility* BrowserAccessibility::Create() {
>   CComObject<BrowserAccessibilityWin>* instance;
>   HRESULT hr = CComObject<BrowserAccessibilityWin>::CreateInstance(&instance);
> 
> We need to get rid of WTL so we can get rid of ATL since it
> causes many problems. See bug for details.
> 
> BUG=5027
> TEST=chrome runs. Accessibility works.
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275987

TBR=jam@chromium.org,cpu@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=5027

Review URL: https://codereview.chromium.org/323003007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276046 0039d316-1c4b-4281-b951-d872f2087c98

This test was flaky, because of a race condition between JavaScript
snippets and input events sent to a renderer via IPC.

This CL modifies the JavaScript bits to check whether chagnes in DOM
caused by the expected input events have been carried out.

See also https://groups.google.com/a/chromium.org/d/msg/chromium-dev/rDxk2D824QI/bMleOa0DcQcJ

This CL also enables the test on all platforms.

BUG=346297

Review URL: https://codereview.chromium.org/316163003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276045 0039d316-1c4b-4281-b951-d872f2087c98

This was tested with:

$ gn gen out/Debug_gn --args='use_ozone=true'
$ ninja -C out/Debug_gn events_ozone events_ozone_evdev

BUG=None
TEST=see above
R=brettw@chromium.org
TBR=ben@chromium # for ui/ changes
NOTRY=true

Review URL: https://codereview.chromium.org/322983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276044 0039d316-1c4b-4281-b951-d872f2087c98

R_ARM_RELATIVE relocations are the bulk of dynamic relocations (the .rel.dyn
section) in libchrome.<version>.so.  The ELF standard representation of them
is wasteful.

Packing uses run length encoding to store them more efficiently.  Packed
relocations are placed in a new .android.rel.dyn section.  Packing reduces
the footprint of libchrome.<version>.so in the filesystem, in APK downloads,
and in memory when loaded on the device.

A packed libchrome.<version>.so is designed so that it can be loaded directly
on Android, but requires the explicit support of a crazy linker that has been
extended to understand packed relocations.

A packed libchrome.<version>.so cannot currently be used with the standard
Android runtime linker.

See README.TXT and src/*.h for design and implementation notes.

BUG=

Review URL: https://codereview.chromium.org/310483003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276043 0039d316-1c4b-4281-b951-d872f2087c98

Fixes compiling of content_shell with Ozone

TBR=spang@chromium.org
NOTRY=true
BUG=none

Review URL: https://codereview.chromium.org/328763002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276042 0039d316-1c4b-4281-b951-d872f2087c98

R=leng@chromium.org

Review URL: https://codereview.chromium.org/324843002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276041 0039d316-1c4b-4281-b951-d872f2087c98

In HostZoomMapImpl::SetZoomLevelForWebContents() we currently make the
assumption that the WebContents passed in will always have a non-null
last-committed navigation entry, but this leads to failures on the
fuzzing tests. This CL removes that assumption, and ignores attempts to
set zoom if no such entry exists.

BUG=382320

Review URL: https://codereview.chromium.org/320863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276040 0039d316-1c4b-4281-b951-d872f2087c98

Per details logged on connect bug and crbug, when linked as a Windows
subsystem binary, the _fileno() for stdin/stdout/stderr are incorrectly set
to 0,1,2 rather than all -2 (because there's no console attached). This 
was broken between VS2010->VS2012 and is still broken in the latest VS2013
update.

So, instead of only checking _fileno, we also check the underlying HANDLE
to confirm that it's valid for that stream before aborting.

BUG=358267
BUG=https://connect.microsoft.com/VisualStudio/feedback/details/785119/#tabs

Review URL: https://codereview.chromium.org/324493003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276039 0039d316-1c4b-4281-b951-d872f2087c98

This CL implements the plumbing required for the Java android client to communicate with the C++ client via Java Native Interface.

BUG=329109

Review URL: https://codereview.chromium.org/319273003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276038 0039d316-1c4b-4281-b951-d872f2087c98

BUG=374335

Review URL: https://codereview.chromium.org/324803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276037 0039d316-1c4b-4281-b951-d872f2087c98

Fix the notification center label to read
"Chromium Notifications" or "Chrome Notifications"
instead of "Notifications" on Win and Linux and CrOS.
Mac is already working properly.

Passed message_center_unittests and interactive_ui_tests

BUG=350449

Review URL: https://codereview.chromium.org/318173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276036 0039d316-1c4b-4281-b951-d872f2087c98

Collapsing the permission for "kTabs" and "kHostsAll". The former is automatically included in the latter.

This CL reduces the number of install time permissions shown to the user when the extension asks for both "kTabs" and "kHostsAll" permission. The former automattically includes all the information in the latter and we only need to show the latters message.

BUG=380797
R=meacer, jww

Review URL: https://codereview.chromium.org/311113006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276034 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276028 0039d316-1c4b-4281-b951-d872f2087c98

This wires up the ChildProcessLauncher and SandboxedProcessLauncherDelegate.
No restrictive policies are currently registered or enforced, i.e. renderers
should not be locked down. However, to keep NPAPI plugins working, an allow-by-
default policy exists.

BUG=367863
R=jam@chromium.org

Review URL: https://codereview.chromium.org/303293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276026 0039d316-1c4b-4281-b951-d872f2087c98

On some ChromeOS devices, there would be extra effert to copy content
from a window to the screen when the window is not full-sized.

This change tries to replace the windows by a full-screen window and
let different decoders draw on different areas of the window.

This did improve the performance a lot. After this change, the time
took by the thumbnail test is improved from 7 seconds to 1.6 seconds.

Due to crbug/270064, we cannot run two fullscreen X apps. The chrome
should be stopped before unning the vda_unittest.

    # touch /var/run/disable_chrome_restrat
    # restart ui

BUG=chrome-os-partner:28176
TEST=Run the test on peach-pit

Review URL: https://codereview.chromium.org/271593010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276025 0039d316-1c4b-4281-b951-d872f2087c98

New test was added that ensures larger images are accepted.

BUG=TBD

Review URL: https://codereview.chromium.org/320043003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276024 0039d316-1c4b-4281-b951-d872f2087c98

BUG=https://code.google.com/p/nativeclient/issues/detail?id=3114
TEST=compile "nacl_io_untrusted" ninja target

Review URL: https://codereview.chromium.org/320103004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276023 0039d316-1c4b-4281-b951-d872f2087c98

In kitkat, android introduces a new API to support adaptive playback:
https://developer.android.com/about/versions/android-4.4.html

This change enables adaptive playback on kitkat devices for MSE so that we don't need to tear down decoders during config changes.

Tested with the youtube dash MSE demo page, and i saw no pauses during config changes.

BUG=357726

Review URL: https://codereview.chromium.org/323563002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276022 0039d316-1c4b-4281-b951-d872f2087c98

Build fix with gcc 4.8 and C++11 enabled. gcc was complaining because it
requires 'override' to be specified *before" __attribute__ (WARN_UNUSED_RESULT
in this case).

Review URL: https://codereview.chromium.org/322833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276021 0039d316-1c4b-4281-b951-d872f2087c98

This fixes a bug introduced in r275656.

BUG=358271
TEST=Test pages play on Android.
R=jrummell@chromium.org

Review URL: https://codereview.chromium.org/325793003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276020 0039d316-1c4b-4281-b951-d872f2087c98

When emulating another device in DevTools (including touch),
overscroll navigation is confusing for the user:
- if device does not support touch, user is not used
to the overscroll navigation and may be surprised;
- with content not filling the whole view, overscroll navigation
looks unnatural.

BUG=369938

Review URL: https://codereview.chromium.org/313083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276019 0039d316-1c4b-4281-b951-d872f2087c98

Switch repaint benchmark to use invalidation micro benchmark to generate
the invalidations. Initial implementation supports three modes:
- fixed_size: create invalidations with a random mid point and a fixed size.
- layer: invalidate the entire layer (previous behavior of repaint benchmark)
- viewport: invalidate the entire viewport
- random: invalidate a random rect inside the viewport

Depends on https://codereview.chromium.org/298723013/

R=vmpstr@chromium.org,nduca@chromium.org,tonyg@chromium.org
BUG=376379

Review URL: https://codereview.chromium.org/292663014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276018 0039d316-1c4b-4281-b951-d872f2087c98

Add a browsertest for the feedback service, to serve as a basis for more extensive testing for Issue 146003005.

BUG=NONE

Review URL: https://codereview.chromium.org/197883010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276017 0039d316-1c4b-4281-b951-d872f2087c98

This changes the HandleView to obtain the themed version of the
Drawable, if available.

BUG=381705

Review URL: https://codereview.chromium.org/323823003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276016 0039d316-1c4b-4281-b951-d872f2087c98

There was a TODO in cc/debug/rendering_stats_instrumentation.h for
renaming the RenderingStats objects in order to depict the thread
for which they are.

Patch for doing the same.

Review URL: https://codereview.chromium.org/290413003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276015 0039d316-1c4b-4281-b951-d872f2087c98