GitLab

This whitelist matches the current list in app_current_window_internal_api.cc for SetShape(). That whitelist will be removed in a separate cl.

BUG=374433,323773,356200,327507,354258
R=kalman@chromium.org

Review URL: https://codereview.chromium.org/290043006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271140 0039d316-1c4b-4281-b951-d872f2087c98

The layer_tree_host() is never null and this is DCHECKed in the
constructor.

R=enne
BUG=

Review URL: https://codereview.chromium.org/289063009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271139 0039d316-1c4b-4281-b951-d872f2087c98

establish connection with remote endpoint.

If we don't send signal, TCP based cricket::Port(s) think they are still
connecting.

BUG=https://code.google.com/p/webrtc/issues/detail?id=3249
R=sergeyu@chromium.org

Review URL: https://codereview.chromium.org/288923014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271138 0039d316-1c4b-4281-b951-d872f2087c98

BUG=364675
TBR=jchaffraix@chromium.org

Review URL: https://codereview.chromium.org/294443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271137 0039d316-1c4b-4281-b951-d872f2087c98

The tests use EXPECT_EQ with a constant variable equal to false,
that tricks GCC 4.7+ into beliving the variable should be compatible to null
pointers in some internal macro. This CL workarounds that by
using EXPECT_TRUE(a == b) instead.

BUG=https://code.google.com/p/googletest/issues/detail?id=458
TBR=mek
NOTRY=true

Review URL: https://codereview.chromium.org/290723002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271136 0039d316-1c4b-4281-b951-d872f2087c98

Added histogram Network.Shill.UserInitiatedEvents for sampling
the number of user-initiated events in shill. Currently only
tracks the user-initated WIFI scans.

Added histogram Network.Shill.WiFi.TransmitBitrateMbps for sampling
the transmit bitrate for the wifi device. The bitrate is updated
every minutes when wifi is connected to a network.

Added histogram Network.Shill.WiFi.UserInitiatedConnectionResult
for sampling the outcome of user-initiated connection attempts.
This histogram is updated everytime the wifi connection is initiated
by the user.

Consolidate the histograms for DHCPOptionFailureDetected, where there
was one histogram per technology type. Instead, changed to one only
histogram, with each technology type as a bucket under the histogram.

BUG=chromium:368761,chromium:369135,chromium:369545
TEST=Start chrome, browse to chrome://histograms to make
sure these histograms exist after manually
initiate/establish a wifi network connection.
NOTRY=true

Review URL: https://codereview.chromium.org/273883003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271135 0039d316-1c4b-4281-b951-d872f2087c98

This is causing crashes related to the resource bundle. Not
doing this makes content_shell's initial cursor invisible,
but it's better than crashing.

BUG=chromium:362755
TEST=link_freon chromeos build
TBR=dnicoara
NOTRY=true

Review URL: https://codereview.chromium.org/292563002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271134 0039d316-1c4b-4281-b951-d872f2087c98

Content should not have knowledge of NaCl. Moving per process NaCl debug
stub port information to NaClBrowser.

More explicitly distiquish between the case where the debug port is not yet
known versus when it is unused.

Switch debug port to being a per-process value (as it is).

This relands r270907 with a fix to make it work with disable_nacl=1
and therefore ASAN.

BUG=None
TEST=trybots
R=jam@chromium.org,sehr@chromium.org

Review URL: https://codereview.chromium.org/286143010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271133 0039d316-1c4b-4281-b951-d872f2087c98

Read the target encode bitrate and bind it to the "encoded" callback
before actually encode the frame instead of reading the target bitrate
after frame has been encoded . This gives a more accurate value of
the encode bitrate each frame was encoded at.

Review URL: https://codereview.chromium.org/286203004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271132 0039d316-1c4b-4281-b951-d872f2087c98

R=iannucci@chromium.org
BUG=

Review URL: https://codereview.chromium.org/282363006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271131 0039d316-1c4b-4281-b951-d872f2087c98

TBR=szager@chromium.org
BUG=

Review URL: https://codereview.chromium.org/294473004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271130 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TBR=ericu@chromium.org, erg@chromium.org
NOTRY=true
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/290233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271121 0039d316-1c4b-4281-b951-d872f2087c98

R=darin@chromium.org

Review URL: https://codereview.chromium.org/290113004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271110 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271109 0039d316-1c4b-4281-b951-d872f2087c98

So that we can avoid creating PassThroughFilter.
The CL also makes FilterChain::GetHead() a little more efficient (SyncDispatcher calls it once for receiving each message).

BUG=None
TEST=None
R=darin@chromium.org

Review URL: https://codereview.chromium.org/291583005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271107 0039d316-1c4b-4281-b951-d872f2087c98

Currently we pass the service path of networks as the "GUID" in the
networkingPrivate implementation on Chrome OS. We should be using the
actual GUID (if one exists) or create a GUID if one does not.

Note: This change should not break any existing usage since the GUID
value should be transparant to the implementation. (This will have the
positive side effect of making the GUID consistent across sessions).

BUG=284827
For fake_wifi_service.cc:

R=asargent@chromium.org, pneubeck@chromium.org
TBR=mef@chromium.org

Review URL: https://codereview.chromium.org/275543005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271106 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271105 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
R=stevenjb@chromium.org

Review URL: https://codereview.chromium.org/282103009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271104 0039d316-1c4b-4281-b951-d872f2087c98

BUG=374392
TBR=erg
NOTRY=True

Review URL: https://codereview.chromium.org/287003010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271103 0039d316-1c4b-4281-b951-d872f2087c98

In HWNDMessageHandler::ShowWindowWitState(), when ui::SHOW_STATE_DEFAULT
is passed as state, the window grabs activation after being shown. The
correct behavior would be to activate the widget if and only if the
can_activate flag is set. HWNDMessageHandler::Show() method already does
this since r244605.
Also, the DefaultWidgetDelegate should honor InitParams::can_activate
flag.

BUG=340736

Review URL: https://codereview.chromium.org/154783002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271102 0039d316-1c4b-4281-b951-d872f2087c98

Each time we add a new platform in the default build, products that want
only a single platform have to add an entry to GYP_DEFINES to turn it back
off.

This introduces a new setting, ozone_auto_platforms. If this is turned off
in GYP_DEFINES, we'll only build platforms that are explicitly enabled.

TEST=runhooks
BUG=none

Review URL: https://codereview.chromium.org/288273002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271101 0039d316-1c4b-4281-b951-d872f2087c98

In a multi-monitor setup, when switching from extended mode to mirror mode,
it is possible for the external monitor to receive events between when its
RootWindowController is Shutdown()ed (which destroyes the screen-position
client) and the root-window is destroyed. So make sure the client is there
before trying to use it to convert the event's location to screen space.

BUG=358266
R=oshima@chromium.org

Review URL: https://codereview.chromium.org/286913009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271100 0039d316-1c4b-4281-b951-d872f2087c98

R=enne@chromium.org, piman@chromium.org, enne, piman
BUG=374287

Review URL: https://codereview.chromium.org/290563005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271098 0039d316-1c4b-4281-b951-d872f2087c98

this is the biggest chunk I can pull out vaguely cleanly.  It does contain a
couple of fake calls to keep the compiler happy.
This CL also makes SetUpMetadata a member in order to ease testing in a later CL.

This depends on https://codereview.chromium.org/261843004/.

BUG=108012

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270016

Review URL: https://codereview.chromium.org/266333002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271097 0039d316-1c4b-4281-b951-d872f2087c98

R=avi@chromium.org

Review URL: https://codereview.chromium.org/292443004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271096 0039d316-1c4b-4281-b951-d872f2087c98

There's only one caller of this method now that CompositeAndReadback
is gone, so just inline the code to make things easier to read.

R=enne@chromium.org, enne
BUG=374287

Review URL: https://codereview.chromium.org/289903008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271095 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TBR=ericu@chromium.org, erg@chromium.org
NOTRY=true
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/291573006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271094 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
May be bad.

Original issue's description:
> Enable QUIC 17.
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270592

TBR=rtenneti@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/291643003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271092 0039d316-1c4b-4281-b951-d872f2087c98

This moves the logic for nexe downloading outside the trusted plugin. This is
part of a series of changes to remove FileDownloader and its associated logic.

I've tried to make this change small so it will be easy to review. A followup
change will clean up some of the accounting logic post-download to make this
path simpler and easier to follow.

BUG=370556
R=bbudge@chromium.org

Review URL: https://codereview.chromium.org/276423003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271090 0039d316-1c4b-4281-b951-d872f2087c98

This may be too restrictive, but seems like a good start.

BUG=365012
TEST=covered by tests
R=ben@chromium.org

Review URL: https://codereview.chromium.org/287183003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271089 0039d316-1c4b-4281-b951-d872f2087c98

The original version required 34 float ops (16mul + 11sub + 5add + 2div).
This version removes some of the intermediate dot products, reducing the
max number of operations to 19 (6mul + 2div + 11sub).  It also avoids using
doubles, warranted by the removal of several intermediate operations that might
otherwise incur significance loss.

In local (release build) benchmarks, this reduced the typical CPU cost of a call to
QuadF::Contains(...) by 2/3, both with GCC and Clang on an ARM v7 device.

Review URL: https://codereview.chromium.org/291493003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271088 0039d316-1c4b-4281-b951-d872f2087c98

BUG= 348437
TEST=Manual, see bug

Review URL: https://codereview.chromium.org/274273004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271086 0039d316-1c4b-4281-b951-d872f2087c98

Original files: content/public/common/favicon_url.*

BUG=359586

Review URL: https://codereview.chromium.org/284183004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271085 0039d316-1c4b-4281-b951-d872f2087c98

BUG=374022
R=isherman@chromium.org

Review URL: https://codereview.chromium.org/284313002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271084 0039d316-1c4b-4281-b951-d872f2087c98

Some cleanup.

BUG=373862
TEST=manual
NOTRY=True

Review URL: https://codereview.chromium.org/288103005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271083 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271082 0039d316-1c4b-4281-b951-d872f2087c98

This pulls in the following Native Client changes:

r13168: (mseaborn) Non-SFI NaCl: Enable running more tests with nonsfi_loader
r13169: (dyen) Make toolchain build upload linux 64 bit hosted toolchain.
r13170: (dschuff) Add bot selectors for new PNaCl mac and windows bots
r13171: (dyen) Removed old toolchain management files.
r13172: (mseaborn) PNaCl: Remove unnecessary use of "-Ttext" option when doing bitcode linking
r13173: (petarj) [MIPS] Switch to newer versions of the tools
r13174: (noelallen) Create GROUPS for trusted and untrusted targets to avoid using default toolchain...
r13175: (noelallen) Pin latest bionic version number.
r13176: (jvoung) Remove deprecated NaClDescIoDescMakeFromHandle.
r13177: (jvoung) Add more detailed perf markers to clarify perf of NaCl ELF file load.
r13178: (petarj) [MIPS] Fix incorrect use of assembly macro in the test
r13179: (bradnelson) Use SO_EXCLUSIVEADDRUSE on Windows instead of SO_REUSEADDR.
r13180: (mseaborn) command_tester.py: Don't write output file if the test failed
r13181: (mseaborn) readlink() syscall: Add missing test and fix to work on larger buffer sizes

BUG=none
TEST=browser_tests and nacl_integration

Review URL: https://codereview.chromium.org/286033003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271081 0039d316-1c4b-4281-b951-d872f2087c98

Fix the "gn check" header errors.

Remove the extra "gles2_utils" target which "gn check" flags as an error. This target is actually inseparable from "command_buffer_common" but exists this way to prevent cycles in GYP files (but not GYP targets). GN doesn't have this problem, so I merged them.

Moved the GPU targets out into build files closer to their files (gpu/command_buffer/client and .../common). This leaves a BUILD.gn file in gpu/ with a comment listing the forwarding locations, since that's where people will look for a BUILD.gn file first.

Delete the duplicate gfx_unittests target, leave a comment for where it is in case somebody does a search for that name.

Make webp compile on Windows

Make ui/gfx compile on Windows. There were some duplicate symbols for ozone. I changed some of the filtering around to do += instead of exclusion. I think in these cases it's easier to follow and maintain.

BUG=
R=piman@chromium.org, urvang@google.com

Review URL: https://codereview.chromium.org/288033016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271080 0039d316-1c4b-4281-b951-d872f2087c98

Adds a meta-target "//base/allocator" that forwards to tcmallor or nothing depending on the build configuration.

Write tcmalloc target definition.

Write base unit tests prefs, and some support targets from base.gypi.

Fix a bunch of added files in the base target that were exposed by linking the unit tests.

Removes toolkit_uses_gtk which was removed from the GYP build.

BUG=
R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/288203003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271079 0039d316-1c4b-4281-b951-d872f2087c98

This adds special handling for variables that begin with underscores, which is inspired by Dart. Such variables are not imported when doing an import, which gives .gni files a way to have intermediate private variables that won't pollute the scopes of the files that include them.

This also applies to the root build config, which can have private values now.

Adds some missing unused variable checks. This was disabled because processing imports would mean all imported variables were unused, and files not using all of them would get unused variable errors. This adds the option to mark merged values on a scope as used, which is used for imported values.

BUG=341738
R=cjhopman@chromium.org

Review URL: https://codereview.chromium.org/287693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271078 0039d316-1c4b-4281-b951-d872f2087c98