- 16 Oct, 2014 40 commits
-
-
dcheng authored
BUG=none TBR=sky@chromium.org Review URL: https://codereview.chromium.org/659103002 Cr-Commit-Position: refs/heads/master@{#299910}
-
rnephew authored
BUG= Review URL: https://codereview.chromium.org/606853002 Cr-Commit-Position: refs/heads/master@{#299909}
-
aurimas authored
Fix indentation issue to allow enabling Checkstyle indentation rule. BUG=318404 Review URL: https://codereview.chromium.org/652173003 Cr-Commit-Position: refs/heads/master@{#299908}
-
gunsch authored
R=bulach@chromium.org BUG= Review URL: https://codereview.chromium.org/660683002 Cr-Commit-Position: refs/heads/master@{#299907}
-
lliabraa authored
BUG=418602 NOTRY=true NOTREECHECKS=true Review URL: https://codereview.chromium.org/663553002 Cr-Commit-Position: refs/heads/master@{#299906}
-
mdempsky authored
This splits out the policy-to-BPF-program handling code from SandboxBPF into a new "PolicyCompiler" class. Additionally, it extracts an interface "TrapRegistry" to decouple PolicyCompiler from Trap (which should probably eventually be renamed something like SIGSYSTrapRegistry). Most significantly this CL means bpf_dsl no longer depends on SandboxBPF, which also now focuses primarily on the task of installing a compiled policy. BUG=414363 Review URL: https://codereview.chromium.org/660433002 Cr-Commit-Position: refs/heads/master@{#299905}
-
lliabraa authored
iOS does not have this requirement, but we've been installing the 10.6 SDK on the buildbot slaves to make the 'find_sdk.py --verify' call happy. However, iossim no longer builds with 10.6 so it's time to update the mac_sdk_min for iOS to 10.8 and remove the false requirement for official builds. BUG=418602 Review URL: https://codereview.chromium.org/660783004 Cr-Commit-Position: refs/heads/master@{#299904}
-
cmasone authored
Several configs in the Linux GN build are used in only one place. Defining these configs in build/config/linux/BUILD.gn makes them get resolved on all Linux-derived platforms, during both target builds and host-tool builds. This doesn't work on CrOS, which does not need or want the packages references by these configs. gconf is used in multiple places, so moving the config won't work. Instead, the gconf config is only resolved when building for a Linux target. BUG=None TEST=GN build for Linux and CrOS R=jamesr Review URL: https://codereview.chromium.org/655343002 Cr-Commit-Position: refs/heads/master@{#299903}
-
gayane authored
Histogram is in minutes. In case logs are uploaded by multiple tasks the interval between those is not recorded. BUG=421543 Review URL: https://codereview.chromium.org/633373011 Cr-Commit-Position: refs/heads/master@{#299902}
-
viettrungluu authored
R=sky@chromium.org BUG=423134 Review URL: https://codereview.chromium.org/656213002 Cr-Commit-Position: refs/heads/master@{#299901}
-
bauerb authored
In order for the test to work, this CL also adds a success callback to SupervisedUserService::AddAccessRequest() and moves the logging of the success value to the client of AddAccessRequest, i.e. the SupervisedUserInterstitial. BUG=412314 Review URL: https://codereview.chromium.org/661763002 Cr-Commit-Position: refs/heads/master@{#299900}
-
qsr authored
Also fix parsing of validation files. TBR=ppi@chromium.org Review URL: https://codereview.chromium.org/640223003 Cr-Commit-Position: refs/heads/master@{#299899}
-
treib authored
Also, replace the deprecated CHROME namespace with PERMISSION_CHROME_URL (see https://cs.corp.google.com/#piper///depot/google3/google/kidsmanagement/v1/permissions_common.proto&l=30 ) BUG= Review URL: https://codereview.chromium.org/640223002 Cr-Commit-Position: refs/heads/master@{#299898}
-
dmichael authored
Its lifetime is scoped to the RenderFrame, and it might go away before the hosts that refer to it. BUG=423030 Review URL: https://codereview.chromium.org/653243003 Cr-Commit-Position: refs/heads/master@{#299897}
-
pfeldman authored
TBR=jochen BUG=423738 Review URL: https://codereview.chromium.org/656033005 Cr-Commit-Position: refs/heads/master@{#299896}
-
skia-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/skia/+log/30bc88c..7851a56 CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg TBR=rmistry@google.com Review URL: https://codereview.chromium.org/656683006 Cr-Commit-Position: refs/heads/master@{#299895}
-
dtseng authored
BUG=417106 TEST=none Review URL: https://codereview.chromium.org/647343004 Cr-Commit-Position: refs/heads/master@{#299894}
-
rch authored
BUG= Review URL: https://codereview.chromium.org/638373004 Cr-Commit-Position: refs/heads/master@{#299893}
-
mkwst authored
BUG=420994 Review URL: https://codereview.chromium.org/661743002 Cr-Commit-Position: refs/heads/master@{#299892}
-
henrika authored
TBR=rkc@chromium.org BUG=422275 TEST=Manual tests using DVLOGs to confirm valid microphone mute states. Review URL: https://codereview.chromium.org/645923002 Cr-Commit-Position: refs/heads/master@{#299891}
-
sdefresne authored
There is an indirect dependency from PrefMetricsService on TemplateURLService that cause an incorrect ordering of the factories instantiation when using a TestingProfile, as can be seen in the following callstack: TemplateURLServiceFactory::GetForProfile(Profile*) chrome::(anonymous namespace)::GetDefaultSearchProviderTemplateURL(Profile*) chrome::(anonymous namespace)::NewTabURLDetails::ForProfile(Profile*)1 chrome::HandleNewTabURLRewrite(GURL*, content::BrowserContext*) content::BrowserURLHandlerImpl::RewriteURLIfNecessary(GURL*, content::BrowserContext*, bool*) (anonymous namespace)::SampleNewTabPageURL(Profile*) PrefMetricsService::RecordLaunchPrefs() PrefMetricsService::PrefMetricsService(Profile*) PrefMetricsService::Factory::BuildServiceInstanceFor(content::BrowserContext*) Add an explicit dependency to fix the ordering. BUG=373326 Review URL: https://codereview.chromium.org/659973002 Cr-Commit-Position: refs/heads/master@{#299890}
-
igsolla authored
When the browser receives the toggleFullscreenModeForTab IPC we ask the app to show the custom ViewGroup (containing a FullscreenView with the web contents in fullscreen). If later (for the video element case) a ContentVideoView is created then we add it to the custom ViewGroup. The next steps (in subsequent changes) are: 1. Add tests for fullscreen for non-media elements in the WebView. 2. Changes to ensure that the power saver blocker works for video elements contained inside other elements. 3. Changes to ensure that scrolling works in fullscreen. This change also removes the now unused disallow_fullscreen_for_non_media_elements setting and simplifies the JNI interface in ContentVideoView. BUG=398485 Review URL: https://codereview.chromium.org/618013003 Cr-Commit-Position: refs/heads/master@{#299889}
-
viettrungluu authored
R=finnur@chromium.org BUG=423134 Review URL: https://codereview.chromium.org/660703002 Cr-Commit-Position: refs/heads/master@{#299888}
-
sugoi authored
Follow up to https://codereview.chromium.org/605373002/ The flag was working fine to disable the YUV decoding (which was the goal for M39), but didn't seem to work to enable it. Adding it to render_process_host_impl.cc seems to fix this issue. BUG= Review URL: https://codereview.chromium.org/661583003 Cr-Commit-Position: refs/heads/master@{#299887}
-
qsr authored
TBR=ppi@chromium.org Review URL: https://codereview.chromium.org/663493002 Cr-Commit-Position: refs/heads/master@{#299886}
-
viettrungluu authored
R=michaeln@chromium.org BUG=423134 Review URL: https://codereview.chromium.org/657303002 Cr-Commit-Position: refs/heads/master@{#299885}
-
sergiyb authored
BUG=380709 R=phajdan.jr@chromium.org Review URL: https://codereview.chromium.org/656903002 Cr-Commit-Position: refs/heads/master@{#299884}
-
alemate authored
Revert of Revert of ChromeOS NetworkScreenHandler should not call CheckAndResolveLocale on UI thread. (patchs… (patchset #1 id:1 of https://codereview.chromium.org/653123002/) Reason for revert: The speculative revert didn't help. Original issue's description: > Revert of ChromeOS NetworkScreenHandler should not call CheckAndResolveLocale on UI thread. (patchset #17 id:320001 of https://codereview.chromium.org/620563002/) > > Reason for revert: > Speculatively reverting for https://crbug.com/422703 > > Original issue's description: > > ChromeOS NetworkScreenHandler should not call CheckAndResolveLocale on UI thread. > > > > BUG=419030 > > > > Committed: https://crrev.com/d52dffddbf0abe5ca55509a9cdedcd9b0674bb1c > > Cr-Commit-Position: refs/heads/master@{#298860} > > TBR=dzhioev@chromium.org,nkostylev@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=422703 > > Committed: https://crrev.com/f09329c436f4929c1f9ffd59e49aa4aef441338b > Cr-Commit-Position: refs/heads/master@{#299480} TBR=dzhioev@chromium.org,nkostylev@chromium.org NOTREECHECKS=true NOTRY=true BUG=422703 Review URL: https://codereview.chromium.org/658903004 Cr-Commit-Position: refs/heads/master@{#299883}
-
chrome-tpm authored
Cr-Commit-Position: refs/heads/master@{#299882}
-
nkostylev authored
BUG=422918 Review URL: https://codereview.chromium.org/654173005 Cr-Commit-Position: refs/heads/master@{#299881}
-
mohan.reddy authored
Alerting the error for use to use c++11 constructs |override| and |final| instead of OVERRIDE and FINAL respctively BUG=417463 Review URL: https://codereview.chromium.org/653883002 Cr-Commit-Position: refs/heads/master@{#299880}
-
mkwst authored
Most of ShellBrowserMain's implementation was layout test-specific. This patch moves all of that to LayoutTestBrowserMain, and adjusts the delegate to call that function when DRT is enabled. BUG=420994 NOTRY=true Review URL: https://codereview.chromium.org/649223004 Cr-Commit-Position: refs/heads/master@{#299879}
-
dpolukhin authored
Screen lock activates with keyboard accelerator Ctrl+Shift+L and bower button. BUG=413926 TEST=manual Review URL: https://codereview.chromium.org/620663005 Cr-Commit-Position: refs/heads/master@{#299878}
-
maruel authored
$ git log c28b74ff7..f9e401bab --date=short --format='%ad %ae %s' | sed 's/@chromium\.org//' 2014-10-15 vadimsh Handle Ctrl+C more gracefully when uploading files. 2014-10-07 vadimsh Cache os.listdir calls. 2014-10-07 maruel Add "swarming.py reproduce" to run locally a swarming task. 2014-10-07 vadimsh Cache results of get_native_path_case() calls. R=pgervais@chromium.org BUG= Review URL: https://codereview.chromium.org/655363002 Cr-Commit-Position: refs/heads/master@{#299877}
-
plundblad authored
By adding chromevox_compress_js=0 to your GYP_DEFINES, you can run ChromeVox directly from its sources. The source files are symlinked into the extension directory in the output directory. This is good for faster development and debugging, but ChromeVox itself becomes slow to load in this mode. This also changes ChromeVox next to follow the same flag, hence being compressed by default. When doing so, the classic background page and ChromeVox next's background page are compiled together instead of being loaded one after the other. This is necessary because they import the same modules and the ones from Chromevox next will overwrite the ones from classic after classic gets initialized. Some of the targets in chromevox.gyp are consolidated. The main reason is because many targets that copy or compress scripts need to have the whole picture to not copy over the same files more than once which is racy. BUG=421136 Review URL: https://codereview.chromium.org/656813002 Cr-Commit-Position: refs/heads/master@{#299876}
-
Mitsuru Oshima authored
BUG=424109 TBR=mukai@chromium.org Review URL: https://codereview.chromium.org/660773002 Cr-Commit-Position: refs/heads/master@{#299875}
-
ksakamoto authored
When |path_| is empty, MemEnv created in LazyOpen() should be passed to leveldb::DestroyDB. Otherwise, on Windows lebeldb tries to delete all files in current directory that look like leveldb files. This should fix ServiceWorkerContextTest.DeleteAndStartOver test on Windows, so re-enable it. BUG=420124 TEST=content_unittests --gtest_filter=ServiceWorkerContextTest.* Review URL: https://codereview.chromium.org/651133004 Cr-Commit-Position: refs/heads/master@{#299874}
-
Mitsuru Oshima authored
renamed existing PowerButtonController to ShutdownDialog BUG=None TEST=covered by unit tests Committed: https://crrev.com/0d921cdf45872ebff6c22da6a21c12d44054a860 Cr-Commit-Position: refs/heads/master@{#299821} R=mukai@chromium.org Review URL: https://codereview.chromium.org/654343002 Cr-Commit-Position: refs/heads/master@{#299873}
-
jzern authored
bug/build fix release + cherry-pick from pre-rc3 to deal with a mips build issue Review URL: https://codereview.chromium.org/653803003 Cr-Commit-Position: refs/heads/master@{#299872}
-
Sergey Ryazanov authored
Pair of ClientSession and ServerSession holds WebRTC connection which tunnels DevTools UNIX socket. Once cloud based signaling channel doesn't exist at the moment connections work on a single android device. For manual testing the testing APK has launch activity which lets to start service which tunnels Chrome Shell socket to another local socket (only works when Chrome Shell signed with the same certificate). BUG=383418 TEST=Automatic: LocalSessionBridgeTest, SessionControlMessagesTest. See description for manual testing. R=mnaganov@chromium.org Review URL: https://codereview.chromium.org/537253003 Cr-Commit-Position: refs/heads/master@{#299871}
-