GitLab

Currently we get a UKM source ID from the frame in
WebRequestAPI::MaybeProxyURLLoaderFactory but it's too early - the frame
has not been fully committed yet, and the UKM source ID for the previous
URL is returned.

Get the UKM source ID in
WebRequestProxyingURLLoaderFactory::CreateLoaderAndStart, to work around
the problem.

Bug: 1119320
Change-Id: I1fdd8d301aad916b11eef50e521d7f42087ed41c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362071Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Maksim Orlovich <morlovich@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799948}

https://android.googlesource.com/platform/external/perfetto.git/+log/72e31331da03..ef0fb4c2707e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: I979f0a122615ebd44d02a080547697ec4672488c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365333Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#799947}

Encoded bitstreams can contain frames that are worse than the
specified tolerance, while the quality of the overall stream is
good. To evaluate with the overall quality, this CL adds an option
to PSNR and SSIMVideoFrameValidator that the validation fails
when the average of the values are worse than their tolerances.

Bug: 1045825
Test: video_encode_accelerator_tests on rammus
Change-Id: I3d68616081d00a164d0495ed9b295bc6afa0e235
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359876Reviewed-by: David Staessens <dstaessens@chromium.org>
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799946}

Bug: b/162880032
Test: added new AmbientControllerTest
Change-Id: I9e1104b6d3a8999b2799efa29fc656545b77289a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339642
Commit-Queue: Tao Wu <wutao@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799945}

The `ntp-grid` element is going to be useful for new components outside
of new_tab_page. This CL moves `ntp-grid` into a common location.

Bug: 1115301
Change-Id: Ia8b2e8bb0cebad38b71e17f0eaf251b3bc59e482
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362814
Commit-Queue: Alex Ilin <alexilin@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799944}

The AgentSchedulingGroup class is effectively empty, and is not yet
instantiated by anything.
The mojo interface is currently empty.

Bug: 1111231
Change-Id: I0c22cf38033a43c15594863d565b688319a69668
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348241
Commit-Queue: Tal Pressman <talp@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799943}

there's already a dot.

Bug: 1107145
Change-Id: Idda3fc05e148dc8623221bff280c2de965bb1d4f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358491Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Stephen Sigwart <ssigwart@gmail.com>
Cr-Commit-Position: refs/heads/master@{#799942}

In addition, alphabetize few outlier methods to make it consistent
with the rest of the code here.

Change-Id: Iefdd9657e4507f393ee1c2e60dcde33012f2a592
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363218
Auto-Submit: Piotr Bialecki <bialpio@chromium.org>
Commit-Queue: Klaus Weidner <klausw@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799941}

There is also a test named canvas-createImageBitmap-e_srgb.html in
wpt/html/canvas/element/manual/wide-gamut-canvas. This CL carries back
three recent changes I made to that copy of the test.

1. commit 407ec471:
Run sRGB Blob tests with multiple image formats

2. commit a2c09a7b:
Add AVIF to canvas-createImageBitmap-e_srgb.html

The AVIF test images pattern-srgb.avif and pattern-srgb-transparent.avif
were generated from pattern-srgb.png and pattern-srgb-transparent.png
using the 'avifenc' program in libavif v0.8.0 with the following command
lines:

avifenc --speed 0 --yuv 420 --cicp 1/13/1 --range full \
    pattern-srgb.png pattern-srgb.avif
avifenc --speed 0 --yuv 420 --cicp 1/13/1 --range full \
    pattern-srgb-transparent.png pattern-srgb-transparent.avif

3. commit 6c2ddda1:
Generate one promise_test() for each image format

third_party/blink/tools/run_web_tests.py -t Default \
fast/canvas/color-space/canvas-createImageBitmap-e_srgb.html

Test: 
Change-Id: Ic887a9a77170c6ba18db7022180193c205954ed0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360117Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Wan-Teh Chang <wtc@google.com>
Cr-Commit-Position: refs/heads/master@{#799940}

Bug: 1045266
Change-Id: Ibb0b121d814795aa5b513c740cb32cdac3332188
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355555
Commit-Queue: Claude van der Merwe <cvandermerwe@google.com>
Reviewed-by: Jimmy Gong <jimmyxgong@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799939}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9b259fd1b84c..90adfcb7b606

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC alexmos@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1116656,chromium:1118191,chromium:1119325,chromium:1119485,chromium:1119510
Tbr: alexmos@google.com
Change-Id: I18dfeab2c6c67392c2d39275608344cf4809f1fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365275Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#799938}

Given that ZPS is enabled by default for Desktop and Android, we don't
necessarily require new Features to gate ZPS experiments. A dedicated
about:flag entry, however, is helpful in that it allows opting in or
out of trending zero-suggest experiment.

- The added feature does not change any behavior in Chrome.
- Adds about:flags entries for Desktop and Android.

Bug: 1117219

Change-Id: I146f86af97d37dfb294da956580b832b208f5686
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360951
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Tomasz Wiszkowski <ender@google.com>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799937}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/afdbedf7..d2f63b51

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I94d5e24e14db83f9634a752d915709d5f9bffd76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365415Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#799936}

This will host the Multidevice Internals UI for Chrome browser and
ChromeOS where features such as logging displays will be placed to aid
with debugging efforts. Screenshot here:
https://screenshot.googleplex.com/tijC8cu68OA.

Change-Id: I3544b8652690c5f7a9621750072b9244297f2f1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350228
Commit-Queue: Juliet Levesque <julietlevesque@google.com>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799935}

Change the generated HTML to include the HTML import polyfil and to not
include the scripts from <cr_elements> because they'll be included via
HTML imports by the elements that use them.

Change the test harness to detect if HTML Import polyfil is available
and wait for imports to finish before starting the test.

Bug: 1111393
Change-Id: I2a8d55bee39f8386e75183bcbb79fbbf15204d03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362167
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799934}

Netlogs can be found at: https://drive.google.com/drive/folders/1IuWYSGRKp_Dr160bEdBb9zQb47kxqOgW?usp=sharing
no_zero_rtt.json shows that the requests were only sent with 1-RTT keys.

The experiment forces requests to wait for 1-RTT handshake.

Change-Id: I5e1dab537a3d2f2b11199bae34e781e14b6885fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363954
Commit-Queue: Renjie Tang <renjietang@chromium.org>
Reviewed-by: David Schinazi <dschinazi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799933}

Fill in the callback set on tracking IPCs posted to frames while in the backforward cache, with UMA tracking.

Bug: 111034
Change-Id: I28b1fe273a6e5c2da3e92945176d8d997e344a3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340166
Commit-Queue: Harkiran Bolaria <hbolaria@google.com>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799932}

Let's get the string in first. I will decide on the method signature
later.

Bug: 1113612, 1119570
Change-Id: I7fab36cfa1a16ca0d9f48144ae596153dc308ffe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365513Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: My Nguyen <myy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799931}

Explicitly remove the copy constructor and assignment operator with
the delete keyword.

Bug: 1010217
Change-Id: I374c943dd4a09898ac41d529fc8b63e82f68cc46
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359664Reviewed-by: Florin Malita <fmalita@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799930}

Provide buttons to trigger Register/Unregister Send/Receive Surfaces,
and SendText, Accept, Open, Reject, Cancel events with a selection from
list of ShareTargets in the Nearby Sharing Service. Displays results
from events in a list on the tab, seen in the following screenshot:
https://screenshot.googleplex.com/UiyAoJ8Lwzw

Bug: 1093634
Change-Id: I085c836b21aeeaa77595d71c1e732f2dee6519ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315800
Commit-Queue: Juliet Levesque <julietlevesque@google.com>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Josh Nohle <nohle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799929}

Replace the deprecated macros with explicit deletions.

Bug: 1010217
Change-Id: I1c37c7d97421ed530af9a37fd65983cc22bba0e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365228
Commit-Queue: Daniel Hosseinian <dhoss@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Auto-Submit: Daniel Hosseinian <dhoss@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799928}

Bug: 1101877
Change-Id: I0fdf95df121f5f0b3783d7005f2c7988f49837e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362365Reviewed-by: Thanh Nguyen <thanhdng@chromium.org>
Commit-Queue: Jia Meng <jiameng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799927}

Implement ProduceGLTexture() method for
SharedImageBackingScopedHardwareBufferFenceSync.

Bug: 1091945
Change-Id: Ic251e2e82b293bc2394782baf72533703bfefdc4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363972
Auto-Submit: vikas soni <vikassoni@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799926}

This CL records a histogram for the duration of each continuous hover
on the omnibox. This metric is needed for the M86 simplified domain
display experiment. It will allow us to finetune the hover thresholds
and also to see how often users after partially expanding the URL.

Bug: 1111078
Change-Id: I50969ff2fe1bc8fbf4a339de32deeba84139179d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363999
Commit-Queue: Emily Stark <estark@chromium.org>
Reviewed-by: Christopher Thompson <cthomp@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799925}

Replace the deprecated macros with explicit deletions.

Change-Id: Ia6991f4582b98ae535c496bd411caf3928c08c01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365853
Commit-Queue: Daniel Hosseinian <dhoss@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Auto-Submit: Daniel Hosseinian <dhoss@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799924}

This class includes phone metadata such as connection state and battery
levels. It also includes a few inner types such as enums representing
various states.

This CL adds a test for the class, but the class is not instantiated in
real code yet. A follow-up CL will utilize this class within a larger
phone model.

Bug: 1106937
Change-Id: I40be26a6381c70033d35fb0eae7cb8de2e50a09d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365295Reviewed-by: Regan Hsu <hsuregan@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799923}

mb configs for the beta/stable trybots, and make them available
through the chrome_internal_verifier.

Bug: 1105530
Change-Id: I176854111a9a9f8ae5efd432222246a51ae30baa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365094Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Commit-Queue: Jeff Yoon <jeffyoon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799922}

Add visibility state for Quick Answers controller to guard the sequence
and prevent timing issues.

Bug: b/163563982
Test: Manual Test
Change-Id: I43c8c1a8644f32c1205487fdf04887115878f4dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355252
Commit-Queue: Yue Li <updowndota@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799921}

ChromeOS SystemMemoryPressureEvaluator will support D-Bus in the future
and is not suitable to be in //base. No change in behavior.

Bug: b/149833548
Change-Id: Idda02628e1a64f3c18e9f70fabdf4e78f3b40161
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352464Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Brian Geffon <bgeffon@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: Kuo-Hsin Yang <vovoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799920}

Using wpt-import in Chromium f6fa5f43.
With Chromium commits locally applied on WPT:
3b705a74 "WPT: Service Worker: Add unexpected state check to wait_for_state()"
49fd0e16 "Origin isolation: add initial popup WPTs"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
foolip@chromium.org, lpz@chromium.org, robertma@chromium.org:
  external/wpt/tools

NOAUTOREVERT=true
TBR=foolip@google.com

No-Export: true
Change-Id: Ib73437298aec450bd6aeaa65defd6e448e50faa2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363590Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#799919}

For unbundled consent to be available for extensions to use, Chrome
needs to be able to explicitly request for it in an API call body.
Additionally, extension developers should be able to toggle the use of
unbundled consent during the transition into using unbundled consent.

This CL adds both requirements. The changes include adding an optional
parameter 'enableGranularPermissions' in GetAuthToken for developers to
toggle unbundled consent and adjusting Chrome's API calls accordingly
depending on the value of this optional parameter.

Bug: 1100535
Change-Id: I5051ebe2b304a0a93f4e98aea447c0668e5e0a3a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350544
Commit-Queue: William Lin <williamlin@google.com>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Alex Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799918}

What: Ensure the CM runtime feature only looks enabled in renderer when
the browser process base::Feature is also enabled.

Why: It is currently impossible to do feature detection for the API,
as you do not know whether the client has the browser feature enabled.

How: Adds a depends_on condition to our existing runtime feature which
uses a webruntime feature matching the browser process base::Feature.

This requires removing API related expectations from
web_tests/webexposed until the browser side feature is enabled by
default/for testing.

Bug: 1115786
Change-Id: I1db0583551d25cc3def51a89ebddbbbed675362a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353732Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: John Delaney <johnidel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799917}

This CL adds the regrouped menu as a new menu, and controlled by a finch
flag. This CL also add a new custom view binder for divider lines.

Bug: 1118323
Change-Id: Ie37e1edcb27055e940ae12e5d9eee253da42c7a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363974Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Sinan Sahin <sinansahin@google.com>
Commit-Queue: Gang Wu <gangwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799916}

Bug: 1085419
Change-Id: I3d2dee5f2241aa244cf1bdc2f5d7d8cf7005908d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365095Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799915}

In the hide-on-interaction field trial, we were previously handling
navigations only in DidFinishNavigation(). That is, when a navigation
began, we didn’t change the elision state until it commited in
DidFinishNavigation(). This worked well for renderer-initiated
navigations, where the visible URL doesn’t update until the navigation
commits. But it didn’t work for browser-initiated navigations, where
the URL would update at the very beginning of the navigation and
inherit the elision state of the previous navigation until
DidFinishNavigation (see screencast in crbug.com/1111665).

The fix for this is rather tricky and not perfect. For a
browser-initiated navigation, the order of events is as follows:
- URL is updated (triggering EmphasizeURLComponents)
- DidStartNavigation
- DidFinishNavigation
Because the URL is updated at the first step, we need to set the
elision state in EmphasizeURLComponents. Even setting in
DidStartNavigation would be too late, as we could still get a flash of
the new URL with the previous navigation’s elision applied to it. The
problem, though, is that we don’t know if we should elide the URL
until the navigation finishes, because the elision logic depends on
whether the navigation was same-document and if it changed the visible
URL’s path. (In particular, for same-document navigations that only
change the fragment, we ignore those and don’t have them change the
elision state at all.) Therefore, in EmphasizeURLComponents(), we
don’t know for sure whether we should leave the URL elided if it
already is elided, or if we should unelide and reset to the
on-page-load state.

I wasn’t able to think up a perfect solution for this, but the best I
can come up with is to make our best guess how to elide in
EmphasizeURLComponents(), and then fix it up as we get more
information in DidStartNavigation() and
DidFinishNavigation(). Specifically, EmphasizeURLComponents() elides
to the simplified domain if the URL had already been elided, and shows
the full URL otherwise. DidStartNavigation() then fully resets to the
on-page-load state for cross-document navigations, and
DidFinishNavigation() fully resets to the on-page-load state for
same-document navigations that changed the path (which we don't know
until the navigation commits). There remains a weirdness where a
browser-initiated navigation will initially briefly show the
simplified domain of the destination before updating to the full URL
in DidStartNavigation(), but I think this is far better than briefly
showing the destination URL truncated where the previous page’s URL
was truncated.

Bug: 1111665, 1109778
Change-Id: Ia1528254b8203dee93bd0964666b76d4b15bfd46
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360803
Commit-Queue: Emily Stark <estark@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799914}

Now that all Infobars have been converted to the Overlay framework,
DCHECKs can replace early returns to ensure that infrastructure exists
for all Infobars.

Bug: 1030357
Change-Id: I293755ae96b4f9eba763ffb1158f5e2260d3306b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363324
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Auto-Submit: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799913}

BUG=1108460

Change-Id: Ie5eb700075a15cc1cec52f500831115a161f100c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364080Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799912}

https://quiche.googlesource.com/quiche.git/+log/58468984dc04..8607b29d7b55

$ git log 58468984d..8607b29d7 --date=short --no-merges --format='%ad %ae %s'
2020-08-19 fayang Log handshake completion time in quic_connection_stats. Logging only.

Created with:
  roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src

Change-Id: I841c661b04d19a245616b17d0d111ac23165ab58
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363220
Commit-Queue: Haoyue Wang <haoyuewang@chromium.org>
Commit-Queue: David Schinazi <dschinazi@chromium.org>
Auto-Submit: Haoyue Wang <haoyuewang@chromium.org>
Reviewed-by: David Schinazi <dschinazi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799911}

Bug: 1117589
Change-Id: Id2e0e344553189018324ebfe30418419944400c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363434
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799910}

As one of the first steps in making the build work with Python 3,
we will need a way to indicate which actions still require Python 2
to run (most work fine under Python 3 already, but some do not).

This CL introduces a python2_action() template, which works just
like a regular action() rule, but ensures that the script runs
under Python 2 instead of whichever Python version you happen to be
running.

This CL also switches //tools/metrics:histograms_xml to use it
(because it seems to need it) as a proof that it works correctly
and does not regress in a normal (python 2) build.

Bug: 941669, 1118214
Change-Id: I98fbc073cf9443acece3caaae2ed35f9d60c38e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363655
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799909}