- 26 Oct, 2018 40 commits
-
-
Xianzhu Wang authored
The regression was caused by 1px bigger visual rect of the scrolling background. Now snap PaintLayerScrollableArea::ScrollingBackgroundDisplayItemClient::VisualRect() to whole pixels. This matches the original original visual rect of scrolling background before crrev.com/c/1297131. Bug: 898877 Change-Id: I7b8df7850a5a7fb680ea903064247d72fa9d9278 Reviewed-on: https://chromium-review.googlesource.com/c/1300593Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#603228}
-
Min Qin authored
The crash seems to caused by a destroyed download. But the only way to destroy a download is to have 2 download with the same id, so the unique_ptr will demolish the first. Dump some information when this happens Will revert this once the problem is found on canary/dev BUG=898859 Change-Id: I05474aba4ee98474ff99ce32747b763605d9d804 Reviewed-on: https://chromium-review.googlesource.com/c/1302673 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#603227}
-
Jun Choi authored
Implement UI view and model that renders available BLE security keys to the WebAuthN UI. Bug: 877344 Change-Id: Ie44c848799cf5a637f9c048d2e9ec292ddf845fc Reviewed-on: https://chromium-review.googlesource.com/c/1257789 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#603226}
-
manuk authored
This is the first of 3 CL's to replace the global static helper functions which manipulate the DOM with classes. In this CL, we: - Replaced the functions createCellForPropertyAndRemoveProperty and addResultTableToOutput with OutputMatch, which is responsible for generating individual HTML rows from individual omnibox matches. - Moved the data class PresentationInfoRecord and the constants array of PresentationInfoRecord's PROPERTY_OUTPUT_ORDER from omnibox.js to omnibox_output.js as that's where it's now used. Bug: 891303 Change-Id: If653e16763a3956b0576bf677ede1570626007d7 Reviewed-on: https://chromium-review.googlesource.com/c/1293757 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#603225}
-
Michael Spang authored
Since bb1059e5 ("ozone: drm: Clean up error handling around page flips") we only keep one set of framebuffers alive for a group of crtcs that are mirroring (i.e., they should always be showing the same framebuffer). It turns out it is not true that mirrors always show the same buffer; when we modeset a crtc on entering mirror mode, we may allocate a new framebuffer for that purpose and only set that framebuffer on one of the crtcs. Until the first page flip, the two crtcs will show different images. To avoid a crash when we try to page flip, go back to keeping a modeset buffer for each CRTC. This crash only happens if we have to allocate a new buffer for modesettings; in some circumstances, we're able to reuse a buffer and there's no crash. Bug: 888553, b/117854747, b/117863342, b/117631111 Test: ozone_unittests; boot grunt with two hardware mirrored displays Change-Id: Ib903e00a8975aac16e40ed685b809bbba8bb9124 Reviewed-on: https://chromium-review.googlesource.com/c/1302110 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#603224}
-
Gayane Petrosyan authored
Update owners to pauljensen@ and mef@ for all active *DNS* histograms. Change-Id: Ib95d4488d408ab86b4723320c1074af92445150a Reviewed-on: https://chromium-review.googlesource.com/c/1126173 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#603223}
-
Sandra Sun authored
This patch implements snapping after pressing arrow key. We add the snapping logic in ScrollManager::LogicalScroll(). We also introduce an abstract class SnapSelectionStrategy with 3 subclasses: EndPositionStrategy, DirectionStrategy, and EndAndDirectionStrategy. The snap point selection algorithm would query some values from one of the classes during the search. This would keep the algorithm in one place and we can simply change the strategy used to update the behavior. The refactoring for SnapSelectionStrategy has required changes in code for other scroll types (gesture, programming) snapping. Previously all the scroll snap uses EndPositionStrategy. With new strategies added, we update the strategy for fling and scrollBy to EndAndDirectionStrategy. Bug: 821928 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Id4fbc2219c7f5dcdba415e2d79ceaa55845ba193 Reviewed-on: https://chromium-review.googlesource.com/c/1131223 Commit-Queue: Sandra Sun <sunyunjia@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#603222}
-
Gayane Petrosyan authored
These are histograms that have not been viewed in the last 6 months, but still report data on the Stable channel. Set these histograms to stop being recorded for Chrome releases after 2018-08-30. We will file bugs via Monorail (crbug) reminding owners about the approaching histogram expiry – initially 30 days prior to expiry, and also with follow-up alerts. The metrics dashboards will also display a warning for anyone viewing a soon-to-expire histogram. Owners and/or users of these histograms: Please comment on this CL if you think that any affected histogram should not have an expiry date set! This should be uncommon. Otherwise, there are a few options going forward: * If the histogram is no longer needed, please send a follow-up CL to delete the recording code and to mark the histogram as <obsolete>. (You can also remove the expiry date in the same CL.) * If you want to set a different expiry date, please send a follow-up CL to do so. * If neither of the above apply, then keep an eye out for Monorail bugs as the histogram expiry date approaches. For more info on how unused histograms are identified, see https://goto.google.com/uma-unused-histograms-cleanup Bug: 850539 Change-Id: I28711dd547ecc0d7ab0c45d507bbdc8749b8d093 Reviewed-on: https://chromium-review.googlesource.com/c/1126170 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#603221}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/6fe32f898af3..385bf2e04812 git log 6fe32f898af3..385bf2e04812 --date=short --no-merges --format='%ad %ae %s' 2018-10-26 tsepez@chromium.org Rename NewPDFWindow() => NewPWLWindow() Created with: gclient setdep -r src/third_party/pdfium@385bf2e04812 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I4e0ec0dc8f2646646ce973cad1b2b0eb47010116 Reviewed-on: https://chromium-review.googlesource.com/c/1302214Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#603220}
-
Anthony Vallee-Dubois authored
Bug: 891307 Change-Id: I9b3c2429dc9ebe96d3f06e904aaddfdb034c83f7 Reviewed-on: https://chromium-review.googlesource.com/c/1296809Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#603219}
-
Livvie Lin authored
With the addition of the File chip to the left of the URL display, there isn't a need for the file:// in the URL. Screenshot (Linux): https://drive.google.com/file/d/1uG7UHdcpW9YSiSESdQKJTWwKEvTkqvyF/view?usp=sharing Screenshot (Windows): https://drive.google.com/file/d/1XWLeaBPLJ7sD-5YeboKbmMdC2T-K_9ZC/view?usp=sharing Bug: 818528 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I865474182f3863237b3a2b3cd58132115a7d47ca Reviewed-on: https://chromium-review.googlesource.com/c/1274985 Commit-Queue: Livvie Lin <livvielin@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#603218}
-
Dmitry Titov authored
Bug: 896481 Change-Id: Ib5cc008bdc896632b4ae65c14091af9cad343ee1 Reviewed-on: https://chromium-review.googlesource.com/c/1300112Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Commit-Queue: Dmitry Titov <dimich@chromium.org> Cr-Commit-Position: refs/heads/master@{#603217}
-
Jun Choi authored
Callback for BluetoothAdapterFactory::GetAdapter() may be invoked synchronously for ChromeOS devices. This results in discovery of FidoBleDevices that were already known to BluetoothAdapter not being notified to UI embedder, and WebAuthN UI would not show new Bluetooth devices on device selection view --even when FidoBleDevices are discovered. To avoid such hairpinning, invoke FidoDeviceDiscovery::StartInternal asynchronously. Bug: 823686 Change-Id: Idc6c4d1d12d76a15118f15366e734325ba1819c0 Reviewed-on: https://chromium-review.googlesource.com/c/1300798 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#603216}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/99b71dfd4a7c..59ebf23f9ffe git log 99b71dfd4a7c..59ebf23f9ffe --date=short --no-merges --format='%ad %ae %s' 2018-10-26 eladalon@webrtc.org Refactor structs in rtc_event_log_parser_new.h 2018-10-26 eladalon@webrtc.org Delta compression efficiency improvement for non-existent base 2018-10-26 thaloun@chromium.org Fix extra setdscp call introduced by bad merge. 2018-10-26 erikvarga@webrtc.org Add a function for enabling the congestion window and pushback controller in the webrtc::SendSideCongestionController. Created with: gclient setdep -r src/third_party/webrtc@59ebf23f9ffe The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I37ee2f8d6b13a1789c437b854858140cb26d2de6 Reviewed-on: https://chromium-review.googlesource.com/c/1302798Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#603215}
-
John Abd-El-Malek authored
Also use CertVerifyProcChromeOS. TBR=nasko@chromium.org, pmarko@chromium.org Bug: 862043, 887007 Change-Id: I5250a59fc18073ef4997dcb881392e79d080ded2 Reviewed-on: https://chromium-review.googlesource.com/c/1292830Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#603187} Reviewed-on: https://chromium-review.googlesource.com/c/1303052Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#603214}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7d20bc42f453..63fdd972c866 git log 7d20bc42f453..63fdd972c866 --date=short --no-merges --format='%ad %ae %s' 2018-10-26 herb@google.com Combine mask loops in bitmap device 2018-10-26 brianosman@google.com On second thought, remove GrColor4s 2018-10-26 herb@google.com Remove functional part of unique glyphs from the builder 2018-10-26 brianosman@google.com Use SkColor4f functionality, rather than SkPM4f.h inline functions 2018-10-26 halcanary@google.com SkQP/Java: remove unneeded stack trace, count tests correcctly 2018-10-26 halcanary@google.com skqp/.../assets/.gitignore: remove important things 2018-10-26 brianosman@google.com Revert "Remove memory used by unique glyphs" 2018-10-26 brianosman@google.com Remove SkPM4fPriv.h, inline the two functions at call-sites 2018-10-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 e9503ae90a9d..3ce69ba3eb60 (1 commits) 2018-10-26 mtklein@google.com remove RP bench 2018-10-26 mtklein@google.com use Steps in SkSRGBGammaColorFilter 2018-10-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 38ff83043a35..50b105973431 (1 commits) 2018-10-26 scroggo@google.com Fix bug decoding JCS_RGB jpeg files 2018-10-26 benjaminwagner@google.com Fix Bazel formatting. 2018-10-26 michaelludwig@google.com Extract per-edge quad vertex tesselation code into reusable interface 2018-10-26 mtklein@google.com add a test for extend range sRGB roundtripping 2018-10-26 csmartdalton@google.com ccpr: Unregister path listeners when their cache entries are evicted 2018-10-26 mtklein@google.com move unspecialized routines out of SkOpts 2018-10-26 scroggo@google.com Reformat public.bzl 2018-10-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader fde88d96a58b..38ff83043a35 (1 commits) Created with: gclient setdep -r src/third_party/skia@63fdd972c866 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel BUG=chromium:897031,chromium:896776 TBR=brianosman@chromium.org Change-Id: Ie2a6213901c7888513732bbe5b6ab8c59b9af155 Reviewed-on: https://chromium-review.googlesource.com/c/1302703Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#603213}
-
Gayane Petrosyan authored
Change-Id: I7d58e0a1e4045c0a4c7bef4441710da4dd4faf42 Reviewed-on: https://chromium-review.googlesource.com/c/1300077 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#603212}
-
David Tseng authored
TBR=dtseng@chromium.org Change-Id: Ia6992ae1dd1fcf34077186f2445aa8c68cf5355a Reviewed-on: https://chromium-review.googlesource.com/c/1302820Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#603211}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/687f318e303c..387085f89da6 git log 687f318e303c..387085f89da6 --date=short --no-merges --format='%ad %ae %s' 2018-10-26 harrytczhang@google.com Added oauth id for Android performance metrics to whitelist. Created with: gclient setdep -r src/third_party/catapult@387085f89da6 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I389d7b83eca4d46266571e169790e9db718e7b65 Reviewed-on: https://chromium-review.googlesource.com/c/1302796Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#603210}
-
Erik Luo authored
Inputs created by `UI.createInput()` lack toolbar-specific features included by `new UI.ToolbarInput`. This updates IndexedDB's key filter to use the ToolbarInput with better focus logic, 'x' clear button, and consistency with others. Screenshot: https://imgur.com/a/wi1NJde Bug: 863802 Change-Id: I3015e7dd061f32d4a6be414fdfa0928dc72667ed Reviewed-on: https://chromium-review.googlesource.com/c/1294723 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#603209}
-
Peter Kasting authored
This was used to protect against multiple initializations and guarantee the initialization would always send a "mode changed" callback. But multiple initializations don't hurt anything, and none of the clients look like they rely on getting an initial callback on initialization (which makes sense, since this controller should be initialized before any client in non-test scenarios). This also changes the observer method to be explicitly about touch UI, since there's no longer really a concept of an "MD mode". Bug: none Change-Id: Ie0cd0a943ef30ac8ec360ab2d6652404658a68c2 Reviewed-on: https://chromium-review.googlesource.com/c/1300418Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#603208}
-
Min Qin authored
DownloadProvider sets the extra as Uri. Chrome should also do the same so the security team can handle them properly. BUG=899105 Change-Id: I264ed29c9a9f7c730531116ab4261e2de71481b9 Reviewed-on: https://chromium-review.googlesource.com/c/1302099Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#603207}
-
Peter Kotwicz authored
This CL removes the manifest_package from the JSON config. This enables NewSplashWebApk.apk and WebApk.apk to use the same config. BUG=899274 Change-Id: Ibcc95142239de6055e60f7cc02f109cbde03408b Reviewed-on: https://chromium-review.googlesource.com/c/1302105 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#603206}
-
Benjamin Ackerman authored
The webstore_api_constants is no longer being used, so removing it. Bug: 882045 Change-Id: If0ab15c26eb70c89a9bad3d236c0fa62b71ef2fb Reviewed-on: https://chromium-review.googlesource.com/c/1299545 Commit-Queue: Benjamin Ackerman <ackermanb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#603205}
-
Sam Maier authored
Bug: 872904 Change-Id: Ida80736a33c98bb9e4faea1864f921d7d0d58c81 Reviewed-on: https://chromium-review.googlesource.com/c/1302699 Commit-Queue: Sam Maier <smaier@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#603204}
-
Brian Salomon authored
This version of SkCanvas::drawImageRect doesn't use the constraint as there is no source rect. Bug: skia:5679 Change-Id: I16bc18690704e2c2bd30f509e2fc54422b78ed83 Reviewed-on: https://chromium-review.googlesource.com/c/1302656Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#603203}
-
Findit authored
This reverts commit c626ad1c. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 603187 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2M2MjZhZDFjYjRiOTVjMTRkYzA4NGFlMjgyN2YzYjhkMTQzYTI4YWEM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/8527 Sample Failed Step: compile Original change's description: > Support policy-pushed trust anchors on ChromeOS with network service. > > Also use CertVerifyProcChromeOS. > > Bug: 862043, 887007 > Change-Id: I42bc36d58065db35cc70a1a2c587affec25a955a > Reviewed-on: https://chromium-review.googlesource.com/c/1292830 > Reviewed-by: Nasko Oskov <nasko@chromium.org> > Reviewed-by: Pavol Marko <pmarko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#603187} Change-Id: I67243629f4caf63da6e1e943dd9321a4b0e9f7a7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 862043, 887007 Reviewed-on: https://chromium-review.googlesource.com/c/1303175 Cr-Commit-Position: refs/heads/master@{#603202}
-
Mohamed Amir Yosef authored
The APIs for storing the laziness information in InstanceIDBridge accept the app id and the sender id as parameters, and internally call buildSubscriptionUniqueId() However, the APIs for storing the messages themselves in GCMDriver accept the subscription ids directly. This CL does the following: 1- It unifies both APIs to accept subscription ids. 2- It also moves all APIs to the a new class LazySubscriptionsManager. This way all APIs live next to each other and also simplifies the dependencies between both the InstanceIDBridge and the GCMDriver. 3- Moves the relevant tests from InstanceIDBridgeTest.java and deletes it since it contains no other test. Bug: 882887 Change-Id: I4b7937ba1adce72a1312e49d541f9398bb7b9ec9 Reviewed-on: https://chromium-review.googlesource.com/c/1288432Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#603201}
-
Mina Almasry authored
Currently we return the video pts if available, and that causes complications if the audio is longer than the video. Instead, return the max of the audio and video pts. Bug: b/117606837 Test: curl problematic stream, cast youtube, cast_media_unittests Change-Id: Ic54dee250b9026417249aa9034665839d119dcdd Reviewed-on: https://chromium-review.googlesource.com/c/1302701 Commit-Queue: Mina Almasry <almasrymina@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#603200}
-
Mason Freed authored
NOTRY=true TBR=dmazzoni@chromium.org Here are the findit links: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy5gELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKvAWNocm9taXVtLndlYmtpdC9XZWJLaXQgTGludXggVHJ1c3R5IExlYWsvMjU3NzAvd2Via2l0X2xheW91dF90ZXN0cy9kbWx5ZEhWaGJDOTBhSEpsWVdSbFpDOW1ZWE4wTDNOamNtOXNiQzFpWldoaGRtbHZjaTl6Ylc5dmRHZ3RjMk55YjJ4c0wzTmpjbTlzYkMxa2RYSnBibWN0YzJWc1pXTjBhVzl1TG1oMGJXdz0MCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyxQELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKOAWNocm9taXVtLmxpbnV4L0xpbnV4IFRlc3RzIChkYmcpKDEpLzc1Mjk1L3dlYmtpdF9sYXlvdXRfdGVzdHMvZG1seWRIVmhiQzkwYUhKbFlXUmxaQzltWVhOMEwzTmpjbTlzYkdsdVp5OXVieTFvYjNabGNpMWtkWEpwYm1jdGMyTnliMnhzTG1oMGJXdz0MCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy4QELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKqAWNocm9taXVtLmxpbnV4L0xpbnV4IFRlc3RzIChkYmcpKDEpLzc1Mjk1L3dlYmtpdF9sYXlvdXRfdGVzdHMvZG1seWRIVmhiQzltY21GamRHbHZibUZzWDNOamNtOXNiR2x1WjE5MGFISmxZV1JsWkM5bVlYTjBMM05qY205c2JHbHVaeTl1Ynkxb2IzWmxjaTFrZFhKcGJtY3RjMk55YjJ4c0xtaDBiV3c9DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw Bug: 899347 Change-Id: I8c0acfa91d22845c6020e4544c853b16bf85a712 Reviewed-on: https://chromium-review.googlesource.com/c/1302819Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#603199}
-
chromium-autoroll authored
Note: net manually updated to include fix for new location for INFO_FEATURE_WLAN and _LOOPBACK. The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I506624881b41e75ca3dae289c545673a40c17f07 Reviewed-on: https://chromium-review.googlesource.com/c/1302854Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#603198}
-
Matt Swartwout authored
Bug: None Test: None Change-Id: Ib19c2d505e63522ac1c2c1798c2de37a5afa53d1 Reviewed-on: https://chromium-review.googlesource.com/c/1303035Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Matt Swartwout <mwswartwout@google.com> Cr-Commit-Position: refs/heads/master@{#603197}
-
Xi Han authored
Bug: 899280 Change-Id: Ie3ac551233bfee2b4fc59fd87884eead21a1debf Reviewed-on: https://chromium-review.googlesource.com/c/1302102Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#603196}
-
Xiaohan Wang authored
- Add "vp09" parsing in widevine_cdm_component_installer.cc - Add |supports_vp9_profile2| in media::CdmCapability and media::mojom::KeySystemCapability. - In chrome_key_system.cc, read |supports_vp9_profile2| and decide whether EME_CODEC_VP9_PROFILE2 is supported. CDM supports VP9 profile 2. Bug: 707127 Test: No functionality change for now. Will update test when Widevine Change-Id: I2441e65dbf29bdc0d30cdb3f5d26e38afd0e90df Reviewed-on: https://chromium-review.googlesource.com/c/1297462Reviewed-by:
John Rummell <jrummell@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#603195}
-
Xi Han authored
This reverts commit aa60c219. Reason for revert: it breaks network_service_webview_instrumentation_test_apk on Mojo Android Build: https://bugs.chromium.org/p/chromium/issues/detail?id=899376 Bug:899376 Original change's description: > Start ServiceManger before creating BrowserMainLoop. > > This CL instantiates the ServiceManagerContext before creating > the BrowserMainRunner. It splits the startup path into two, > with/without starting the full browser. The changes are implemented > behind a flag "allow-start-service-manager-only". > > Bug: 846846,729596 > Change-Id: I3584db0d89a10e59d6041e0f4412aaffdc840568 > Reviewed-on: https://chromium-review.googlesource.com/c/1113802 > Commit-Queue: Xi Han <hanxi@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Cr-Commit-Position: refs/heads/master@{#603092} TBR=gab@chromium.org,jam@chromium.org,hanxi@chromium.org Change-Id: I866cc2148d529d0d7a02d0ac75b2817d1695a8c9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 846846, 729596 Reviewed-on: https://chromium-review.googlesource.com/c/1303042Reviewed-by:
Xi Han <hanxi@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#603194}
-
Tommy Steimel authored
This CL adds a check in MediaViewerUtils to prevent creating a pending view intent if the intent will throw a FileUriExposedException. This will prevent the "Open with" option from showing up. Bug: 893544 Change-Id: Id32d202a0bd9975bca7a93d2be7dc291cf8aab45 Reviewed-on: https://chromium-review.googlesource.com/c/1302104Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#603193}
-
Luke Halliwell authored
Bits of code have snuck into the local branch without making it upstream. Add all of those bits here. Bug: None Test: Cast CQ Change-Id: I6e042ae5dd83653e3f3656fcc9559e7b71a77c9c Reviewed-on: https://chromium-review.googlesource.com/c/1300613Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Simeon Anfinrud <sanfin@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Commit-Queue: Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#603192}
-
Adam Langley authored
These names are already in the “cbor” namespace, thus we end up using a cbor::CBORReader to get a cbor::CBORWriter and it's stuttery. I defer entirely to the owner's personal preferences here because the above is obviously just my personal preference. But, thanks to clang-format, this only took five minutes to do. (TBR for web_package due to non-semantic change of underlying API.) TBR=kinuko@chromium.org Change-Id: I8b34506ebe2aad2779548da0fb451ced61381ccf Reviewed-on: https://chromium-review.googlesource.com/c/1289509 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#603191}
-
Lucas Furukawa Gadani authored
Bug: 832879 Change-Id: Ib39e8caade4114b396337fa2efc04f4a54f69ed3 Reviewed-on: https://chromium-review.googlesource.com/c/1301843Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#603190}
-
John Abd-El-Malek authored
Bug: 862043 Change-Id: I78c19396fbacfdf0bc1ee2bffa07b61e75f0ee4b Reviewed-on: https://chromium-review.googlesource.com/c/1300793Reviewed-by:
Doug Turner <dougt@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#603189}
-