- 22 Sep, 2020 40 commits
-
-
Mark Mentovai authored
8e602f66 (https://chromium-review.googlesource.com/c/2420529) was checked in expediently over the weekend for ${reasons}. This addresses review feedback by refactoring the implementation into library code as needed, and adding full proper tests. Bug: 1130270 Test: chrome/installer/mac/signing/run_mac_signing_tests.py Change-Id: I23a2a2d5ab43a05849f1211f021577cd4ee4b476 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422275 Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#809502}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2fb4be6e85e6..679e180840fc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC huangdarwin@google.com,lgrey@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1099917 Tbr: huangdarwin@google.com,lgrey@google.com Change-Id: I4989e4f151e74c8b00767daf8178a344870d94ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424745Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809501}
-
My Nguyen authored
Proposed new name found in http://go/cros-input-methods Rationale: http://go/cros-input-methods-naming Current view: http://screen/88pFX6hVswESHpL New view: http://screen/ADm7EfmdcEuPfSe Bug: 1113439 Change-Id: I60b9164a76f405ad8d43d5029aa0e4d231095c13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421989Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#809500}
-
Olivier Yiptong authored
Consolidate the cache readiness hook implementations in the base class because all the implementations ended up the same. Bug: 1043306 Change-Id: I814c4eb4ca464247336f263ba98af1a1dfd39d7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422352 Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#809499}
-
Rune Lillesveen authored
Iframes should paint a solid background if the embedding iframe has a used color-scheme different from the used color-scheme of the embedded root element. This CL resolves the background taking the owner_color_scheme_ into account. A follow-up CL will implement the paint side to allow painting the backdrop for iframes. Bug: 1058822 Change-Id: Iadbaeeef32866c150b65a458ebd2a3a78014519d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418854 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#809498}
-
Yi Gu authored
This patches aligns the expiry date with other hit testing metrics. Bug: 1130642 Change-Id: I7a4529982c2f1a824f17b24c53f7df2dfffc73ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424827Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#809497}
-
Robbie McElrath authored
This is a followup to crrev.com/c/2412810, which fixed the controls positioning during page loads in every case except the one we were supposed to fix in the original bug. The issue with that CL was that it always set the controls height to be the same as the previous height, or 0 if there weren't controls before. However, the renderer defaults the controls to expanded initially, so collapsing them on first load wasn't the right behavior. To fix this I make onLayout position new controls so that the same amount of them is showing as *the last time a view was set*, and defaults to an expanded view. This is the behavior the renderer follows. Bug: 1128391 Change-Id: I6a2c65629a8d24476e7c2e07158295574cac0c37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423007Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#809496}
-
Nathan Zabriskie authored
Currently, shared images in OOPR mode are cleared only during BeginRasterCHROMIUM. This can present some issues when an application triggers a readback of the image before it has been drawn to. This CL changes CanvasResourceProvider::Clear to also support OOPR mode to allow for shared images to be cleared when they're created. Bug: 1023281, 1023259 Change-Id: Ia6bc76efd65156b14a430f7db197868628385325 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388434Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Nathan Zabriskie <nazabris@microsoft.com> Cr-Commit-Position: refs/heads/master@{#809495}
-
Michael Hansen authored
This updates the Nearby Share subpage and device name dialog to call the settings mojo for reading and writing the device name instead of accessing prefs directly. This is in preparation for a follow-up CL which will add validation and error checking when setting the device name. Bug: b:161297140 Change-Id: If7cad62416c2662e9c070ecaa91b47e43fe3dfae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2420773 Commit-Queue: Michael Hansen <hansenmichael@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#809494}
-
Matthew Denton authored
Adds BrokerProcess:BrokerType to BrokerProcess. It currently only includes SIGNAL_BASED, but will be used to add USER_NOTIF Also adds ForkSignalBasedBroker() in BrokerProcess, in order to factor out the signal mechanism-specific code from BrokerProcess::Init(). Includes some other minor (but related) refactors. Bug: 1117351 Change-Id: Idadeaafb4ef7bb0f952fd0d901cbfb91d59b3486 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407059 Commit-Queue: Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#809493}
-
Trevor Perrier authored
Bug: 1127531, 1068667 Change-Id: I4248c6b444906ea5587d985571b70f2231ef3f04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342638Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Commit-Queue: Trevor Perrier <perrier@chromium.org> Cr-Commit-Position: refs/heads/master@{#809492}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/82c70d97576c..3c7133e86f13 2020-09-22 treehugger-gerrit@google.com Merge "Larger default buffer config in UI." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I526878e58bfdef6d13f45a029d2cdac26e67feb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424624Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809491}
-
yjliu authored
Bug: N/A Change-Id: I8b9b5abfdf29006bc01fcdc8c3e5e1b45f1b3033 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417404Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Jun Liu <yjliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#809490}
-
George Burgess IV authored
It seems that this constructor call was intended to be used as a scope guard. In order for that to happen, there has to be a variable name here. Bug: 1130379 Change-Id: I1a0df33ddd216ce45cf24238857dbc3d7a8d3913 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2420918Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#809489}
-
Robert Liao authored
This reverts commit 08741021. Reason for revert: Breaks TabSearch on Mac. See http://crbug.com/1131162 . Original change's description: > Remove a few conversion methods on WebWidgetClient. > > Use the WidgetBase implementations instead of going via the > WebWidgetClient. > > BUG=1097816 > > Change-Id: Ib08b5748806fe3862ac291d354043326d3172282 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419129 > Reviewed-by: danakj <danakj@chromium.org> > Commit-Queue: Dave Tapuska <dtapuska@chromium.org> > Cr-Commit-Position: refs/heads/master@{#809421} TBR=danakj@chromium.org,dtapuska@chromium.org Change-Id: I4a5f560c73177acfa6d01464bc37eade2a87af62 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1097816, 1131162 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424494Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#809488}
-
Kevin McNee authored
It appears to be possible for the guest view message filter to outlive the BrowserContext during profile shutdown. We now observe this and clear the filter's pointer to the BrowserContext. We also now destroy the filter on the UI thread for simplicity. The filter does not use weak pointers on the IO thread as a comment previously claimed. Bug: 1129705 Change-Id: If8483653d55c13cde0594e551ee27027060255af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419376 Commit-Queue: Kevin McNee <mcnee@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#809487}
-
James Vecore authored
The icon has been updated and moved settings to os-settings. Change-Id: I5acb37a20105bbb634c33525d32375e16a4045f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424645 Commit-Queue: James Vecore <vecore@google.com> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: James Vecore <vecore@google.com> Reviewed-by:
-
Tommy Li authored
Previous CL added GOC Variations for on-focus: https://chromium-review.googlesource.com/c/chromium/src/+/2422473 This CL adds the exact same variations for on-clobber. It also makes the on-clobber Desktop only, as we never implemented the UI hook for Mobile (either Android or iOS). Bug: 1106096 Change-Id: If5cc05667e86892b8d491777e950e37ef81a3f8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424545 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Auto-Submit: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#809485}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1600775907-52df3750a6dec0d6a74672a50b3faa88175a1e9e.profdata to chrome-linux-master-1600797595-fd8ddba8caaa456739bdf5b1d17d7be117d929dc.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com Change-Id: Ic0799fe621347b2cc8f49f03e6cc407984d71b47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424966Reviewed-by:
-
Jazz Xu authored
Change-Id: I191a218b74d95b898959ba5050557840dbf9aa33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421639Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#809483}
-
Joshua Peraza authored
3e065b11d0ca linux, mac: disable cfi-icall for cross-dso calls 76c6de22e1c2 [fuchsia] Enable ConvertInvalidUTF8ToUTF16 90344b24ed1c fuchsia: suppress -Wconversion warnings a98ee20e578f [crashpad] Prepare crashpad for base::string16 switch 1c77abe90956 fuchsia: Centralize disabling of Wconversion 36d4bb83b3d7 Remove base dependency from no_cfi_icall This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/2422809 with changes to google_chrome_behaviors.cc to fix the compile failure in crbug/1130851. Bug: 1130851 Change-Id: I1f6029b97c4ac643b218db4dd33d3f54ee778370 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423048Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Auto-Submit: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/master@{#809482}
-
Carlos IL authored
This extends interstitial.decision.repeat_visit and interstitial.ssl. did_user_revoke_decisions2 to match other interstitial histograms. Also extends mixed content autoupgrade histograms since the launch is still ongoing. Change-Id: I5b5ff0c088ab7ebf2636b8b0f6d59f2556e8da90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422477 Commit-Queue: Carlos IL <carlosil@chromium.org> Auto-Submit: Carlos IL <carlosil@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#809481}
-
Wenbin Zhang authored
This reverts commit 0b0e0753. Reason for revert: Android builders failing after this is checked in. Error message is related: error: incompatible types: String cannot be converted to GURL Original change's description: > Migrate NavigationHandle from String URLs to GURL > > Migrates NavigationHandle to use GURL internally and adds getUrlString > for callsites that still need URLs to be a string (to be fixed in > followups). > > Some unit tests needed to be moved to Instrumentation tests, one > requiring a change to CriteriaHelper to allow checking for a condition > after every task. > > QualityEnforcerUnitTest was too difficult to migrate to Instrumentation > tests, so it now uses JUnitTestGURLs to use GURL in junit tests. > > Bug: 783819 > Change-Id: I1283d5d7d1946e666e964f8d24aeaf0352eb8805 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419140 > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Commit-Queue: Michael Thiessen <mthiesse@chromium.org> > Cr-Commit-Position: refs/heads/master@{#809396} TBR=yfriedman@chromium.org,mthiesse@chromium.org Change-Id: Idb17bbf3cba4034c8ce47afc331b77117608ab9b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 783819 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425006Reviewed-by:
Wenbin Zhang <wenbinzhang@google.com> Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Cr-Commit-Position: refs/heads/master@{#809480}
-
chrome://newtabEsmael El-Moslimany authored
When the default search engine is changed, chrome://newtab is loaded on the tabs with a NTP loaded. chrome://newtab will redirect to the NTP associated with the new default search engine. Bug: 1129499 Change-Id: I03360bb781c7bf94e2db65f282ee163386dd26cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423169Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#809479}
-
Bence Béky authored
Bug: 1113661 Change-Id: I88015ab4eb033eafb9b2801ad025c7bfc1d70c3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423166 Commit-Queue: Nick Harper <nharper@chromium.org> Auto-Submit: Bence Béky <bnc@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#809478}
-
Philip Rogers authored
This patch adds three UseCounters for measuring dark mode usage: 1. kForcedDarkMode which is set for pages loaded with forced dark mode. 2. kPreferredColorSchemeDark which is set when prefers-color-scheme media queries will match dark. 3. kPreferredColorSchemeDarkSetting which is set when the preferred color scheme dark setting is set (i.e., the system is in dark mode). This can differ from #2 in cases where the system is in dark mode and forced dark mode is enabled, resulting in prefers-color-scheme being "light" in some cases. Bug: 1131028 Change-Id: I85bc9db6ef30ce0dfc4f78c0c51d039bb04a100d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423168Reviewed-by:
-
Mitsuru Oshima authored
Bug: None Change-Id: I710de4d31154bf05d3574cc527e055006ba08b3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410728 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#809476}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/44623aeccd06..9ff58ddd0adf 2020-09-22 lehoangq@gmail.com Metal: Support array of matrices varying. 2020-09-22 geofflang@google.com Vulkan: Add features to modify sampling parameters 2020-09-22 timvp@google.com Vulkan: Allocate descriptor pools with layouts 2020-09-22 jmadill@chromium.org Use c++ thread_local for current thread. 2020-09-22 geofflang@google.com Initialize InternalFormat::blendSupport. 2020-09-22 jmadill@chromium.org Pass #pragma optimize setting down to compilation. 2020-09-22 jmadill@chromium.org Give restricted gold tests executable bit. 2020-09-22 jmadill@chromium.org Test Runner: Improve sharding validation. 2020-09-22 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from fe878dedd5ad to 6aadd31a5f98 (1 revision) 2020-09-22 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Loader from a148cdd49041 to 8fdc21e4078d (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: syoussefi@google.com Test: Test: CQTest: Test: DrawCallPerfBenchmark.Run/vulkan_nullTest: Test: EGLContextASANTest.DestroyContextInUse/ES3_Vulkan Change-Id: Ie96095d144fdf6a8c0ae33c5ad7adfadd385ecdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424571Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a9be76de8b43..187b04b35777 2020-09-22 robertphillips@google.com Increase testing of GrThreadSafeUniquelyKeyedProxyViewCache wrt GrResourceCache purging 2020-09-22 michaelludwig@google.com GrClipStack::contains, add fast path for axis-aligned paths If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1108408 Tbr: csmartdalton@google.com Change-Id: Ic5e5b7e2fc8d3d724090936345c99eeb615e3118 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424575Reviewed-by:
-
Donn Denman authored
Adds a default-disabled Feature to override the policy that Contextual Search applies to plain HTTP pages. This allows disabling the recent change that treats HTTP just like HTTPS landed in https://crrev.com/c/2393526. Enabling the Feature will allow us to go back to the legacy policy, and allow us to measure the impact of the policy change accurately. BUG=1124397,1129969 Change-Id: If9ceab183053a573b45a3db6051b55c625c21755 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422264 Commit-Queue: Donn Denman <donnd@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#809473}
-
Isuru Pathirana authored
This CL updates the VideoCaptureDeviceFactoryWin/VideoCaptureDeviceMFWin implementations to use D3D11 with the MF device source and capture engine. The VideoCaptureDeviceFactoryWin creates and manages an IMFDXGIDeviceManager and associated D3D11 device instance. It provides the IMFDXGIDeviceManager to the MF device source and also plumbs it to the VideoCaptureDeviceMFWin implementation. The VideoCaptureDeviceMFWin implementation subsequently provides the IMFDXGIDeviceManager to the MF capture engine on initialization. Providing a MF DXGI device manager to the MF device source and capture engine is required for zero-copy capture (it allows the Windows frame server service and MF capture engine to keep captured video frames in GPU memory and expose MF samples backed by D3D11 textures). Bug: 1120900 Change-Id: Ic5367d03f337daab2220f8d87d1bfe51f6ca8b72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370092Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Markus Handell <handellm@google.com> Reviewed-by:
Rafael Cintron <rafael.cintron@microsoft.com> Reviewed-by:
Ilya Nikolaevskiy <ilnik@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Isuru Pathirana <Isuru.Pathirana@microsoft.com> Cr-Commit-Position: refs/heads/master@{#809472}
-
Piotr Bialecki authored
CL followup - make XRDepthData into an union so that it is possible to express that the data sent over mojom boundary is either still valid, or that new data has arrived. For discussion, see: https://crrev.com/c/2391619/comment/177fee99_a1338219/ Change-Id: I240357a32dc7fadcae379c3b5f1ca29bdeffcb6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417570Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#809471}
-
Mason Freed authored
This seems like a leftover - likely there used to be more after the if(). Change-Id: I4671f52e73de2e5e573e267de6d5444a03caf2f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424523 Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: Yu Han <yuzhehan@chromium.org> Reviewed-by:
Yu Han <yuzhehan@chromium.org> Cr-Commit-Position: refs/heads/master@{#809470}
-
Alexandre Courbot authored
Quick and easy fixes reported by clang-tidy. BUG=None TEST=video.DecodeAccel.h264 passes on Kukui. Change-Id: I8345f2eb44fc3c2b4a29772d9e2fcdf1a2a0c032 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421996 Commit-Queue: Fritz Koenig <frkoenig@chromium.org> Reviewed-by:
Fritz Koenig <frkoenig@chromium.org> Cr-Commit-Position: refs/heads/master@{#809469}
-
Olivier Yiptong authored
This change consolidates all QueueShareMemoryRegionWhenReady() overrides in the base class implementation, because, it turns out, it's the same code on all platforms. Bug: 1043306 Change-Id: If26b5e9b5e2361e4e66b21bcfdd2e93484c1a15b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421637 Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Reviewed-by:
-
Gang Wu authored
This reverts commit cb2f5900. Reason for revert: https://ci.chromium.org/p/chromium/builders/ci/Lollipop%20Phone%20Tester/27059 Original change's description: > [Instant Start] Avoid pre-native GURL usage > > Remove native dependency of > ReturnToChromeExperimentsUtil.shouldShowStartSurfaceAsTheHomePage() > and PseudoTab.readAllPseudoTabsFromStateFile() so that they can be > called without leading to native initialization. > > Benchmarking results using http://crrev.com/c/2373287: > > 100 samples on Nexus 5X > Median Diff with control p-value > FirstDrawCompletedTime 414.0ms -29.0ms (-7.00%) 0.000000 > SingleTabTitleAvailableTime 287.0ms -31.5ms (-10.98%) 0.000000 > FeedStreamCreatedTime 836.5ms -39.5ms (-4.72%) 0.000030 > FeedContentFirstLoadedTime 1898.5ms -0.5ms (-0.03%) 0.534189 > FeedsLoadingPlaceholderShown 234.0ms -2.0ms (-0.85%) 0.629761 > > 100 samples on Pixel 2 XL > Median Diff with control p-value > FirstDrawCompletedTime 176.0ms -18.0ms (-10.23%) 0.000000 > SingleTabTitleAvailableTime 131.0ms -14.0ms (-10.69%) 0.000000 > FeedStreamCreatedTime 424.0ms -31.0ms (-7.31%) 0.000180 > FeedContentFirstLoadedTime 1137.0ms -18.5ms (-1.63%) 0.075061 > FeedsLoadingPlaceholderShown 107.0ms -1.0ms (-0.93%) 0.718766 > > 100 samples on Pixel 3 XL > Median Diff with control p-value > FirstDrawCompletedTime 155.0ms -13.5ms (-8.71%) 0.000000 > SingleTabTitleAvailableTime 117.0ms -13.0ms (-11.11%) 0.000000 > FeedStreamCreatedTime 356.0ms -35.5ms (-9.97%) 0.000001 > FeedsLoadingPlaceholderShown 94.5ms -2.0ms (-2.12%) 0.007312 > FeedContentFirstLoadedTime 924.0ms -6.5ms (-0.70%) 0.034100 > > Bug: 1041865 > Change-Id: I640aaeb6f2dae64b9152fd94d0cd354a487f5bf5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372900 > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Michael Thiessen <mthiesse@chromium.org> > Reviewed-by: Xi Han <hanxi@chromium.org> > Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#809226} TBR=mthiesse@chromium.org,hanxi@chromium.org,agrieve@chromium.org,wychen@chromium.org Change-Id: I7d864239a477c7875bc79f1e39be54d18a72c9ff No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1041865,1131139 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424983Reviewed-by:
Gang Wu <gangwu@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#809467}
-
Sorin Jianu authored
This is a Windows follow up for the change: Updater: Do not updatecheck in ControlService wake during --install https://chromium-review.googlesource.com/c/chromium/src/+/2414559 There is some amount of code duplication between implementation of various RPC functions. This issue must be addressed at some point, if more RPC functions are added. Bug: 1128397 Change-Id: I23e0875bf76e5b878423105fff805eb91061cb64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424648 Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#809466}
-
Nate Fischer authored
No change to logic. This disables flaky tests in StartSurfaceLayoutTest. Bug: 1130830 Test: out/Default/bin/run_chrome_public_test_apk -f StartSurfaceLayoutTest.* Change-Id: Iaa2a802b0cc1cbe29c316f6f2a3d2409c7d72756 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422688 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#809465}
-
Stephen McGruer authored
Passing an async function to async_test will soon be disallowed in WPT, as any asserts thrown will be turned into unhandled promise rejections and the test will timeout. If a test needs async functions it should use promise_test instead. (The naming conflict is a sad historical legacy; WPT had async_test long before EcmaScript spec'd promises!) Bug: https://github.com/web-platform-tests/wpt/issues/21435 Change-Id: I0a31872525844a1540aea548e329929e8097663e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414923Reviewed-by:
John Rummell <jrummell@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#809464}
-
Yue Zhang authored
Bug: 1130814 Change-Id: If8d93fb7c134637f399735637ff031abbe31ebc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411671Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
-
