- 09 Jul, 2020 40 commits
-
-
Songtao Xia authored
This is to add cdp support for the frontend to send window segments info to the backend, to be consumed by the platform. The explainer for window segments is at: Explainer: https://github.com/webscreens/window-segments/blob/master/EXPLAINER.md During discussion of the dual screen explainer, it was agreed that the change will be reviewed at CR time. The explainer is at: https://docs.google.com/document/d/1KMsmEXdjmn4h4iIl0n74N1EHxwwNUzh6R2p7GHrdtTI/ This change can be tested with web_tests. But it relies on a frontend CL and one more platform CL for a user to see the effect. The frontend CL (WIP) is at: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2245774 The platform CL: https://chromium-review.googlesource.com/c/chromium/src/+/2262193 Change-Id: I6309b8bea0b24b0d098a82a02045115f00d2b34f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248131Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Songtao Xia <soxia@microsoft.com> Cr-Commit-Position: refs/heads/master@{#786932}
-
Mark Pearson authored
And synchronize their expiration dates. Bug: 1089572 Change-Id: Iee4d817e66893a53417843365d0c9cbd895a2db2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283054Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#786931}
-
James Cook authored
This includes display name and URL (used for non-local file systems). Bug: 1090587 Test: open/save files with Google Drive and ARC++ Change-Id: I5d986688e33f20784ef938d3349c6e7f4b842a4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289072 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Cr-Commit-Position: refs/heads/master@{#786930}
-
Charlie Hu authored
This CL is based on the spec change on https://github.com/w3c/webappsec-feature-policy/pull/388/files?short_path=1a56774. Since the parameter names are removed in this change, feature names will have to change so that they remain meaningful. This will be addressed in follow-up CLs. Change-Id: Ic87dcb5bf26e440dd5041ae31d7b248e7d85d93a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2281104Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#786929}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Ia737f897200c0587010342261a500ac8092bace0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290317Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#786928}
-
Colin Tan authored
Change-Id: I3228c76d910a983f2f66d02bd55eeb174aac0bff Bug: 1081230 Change-Id: I3228c76d910a983f2f66d02bd55eeb174aac0bff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261254Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Colin Tan <colta@microsoft.com> Cr-Commit-Position: refs/heads/master@{#786927}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/0e4aa978b55b..9bb8ef0cdaae 2020-07-09 khokhlov@google.com devil: Fix determining the tracing path 2020-07-09 dproy@chromium.org trace_viewer: Make links open in new tab If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1102378 Tbr: rmhasan@google.com Change-Id: I0f3d31bc61639e9611ec1dfaf3ada29dce85b606 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290411Reviewed-by:
-
Greg Guterman authored
Bug: 1095060 Change-Id: I294941df9f901e15a6919cf69f0bf1973518668d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290554Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Gregory Guterman <guterman@google.com> Cr-Commit-Position: refs/heads/master@{#786925}
-
James Cook authored
This allows filtering by file type, like *.png. Bug: 1090587 Test: manual with Ctrl-O/Ctrl-S Test: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/file Change-Id: I990f77d98ea823b097770fc9cc3e6d87029e058c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286569 Auto-Submit: James Cook <jamescook@chromium.org> Commit-Queue: Greg Kerr <kerrnel@chromium.org> Reviewed-by:
-
Liviu Tinta authored
Add TRACE calls to scroll related methods to help with troubleshooting. TRACE the following methods: ScrollTree::SetScrollOffset, ScrollTree::OnScrollOffsetAnimated, ScrollableArea::ScrollOffsetChanged. Bug: 1087088 Change-Id: If0b29816aa7092041f071e6c9b72941105581e52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288288 Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#786923}
-
Peter Wen authored
Previously we passed in the transitive interface classpath to each java target for compiles. This means that if A depends on B which depends on C, any changes to C will require that both A and B are re-compiled, even if B does not change after compilation, since A directly depended on both B and C. After switching to direct interface classpaths, a change in C no longer automatically means that A needs to be recompiled, thus speeding up the build and reducing the number of edges in our build graph. This is a step towards being explicit about what each target actually depends on. Since each directory needs to have its BUILD.gn files updated to include missing direct deps (for annotations, imports, parameters, transitive classes), a temporary allowlist has been added to make the transition easier. Follow-up CLs will remove each entry from the allowlist after updating all the BUILD.gn files in that directory. Transitive classes generated by turbine in the META-INF/TRANSITIVE dir are also added to the classpath. This removes the necessity of adding a direct dependency on an indirectly used class (e.g. method on parent of parent class). Bug: 1082904 Change-Id: Ideb374c985bc278e5c14bde4da06f8725d9359d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289614 Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#786922}
-
Michael Chang authored
Currently, the server assumes that each function will be called by a managed thread. Instead, we should create a sequenced task runner when the server is initialized, so that we can use to post tasks. Also adding a check for whether the .install executable is actually executable or not. Change-Id: I502613e9e9172078eb24549696cea002d99cc4ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284442Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Michael Chang <donchan@microsoft.com> Cr-Commit-Position: refs/heads/master@{#786921}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/496a4d532ff5..af5653134716 2020-07-09 simonmacm@google.com Merge "Add power consumption as predicted by the power profile to time in state metrics." 2020-07-09 treehugger-gerrit@google.com Merge "tracing: Fix start callback not firing before tracing stops" 2020-07-09 aninditaghosh@google.com Add build rule for Python dependency If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Idde72ea1c0c912475af0b07d836473f5ac9e4e0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290185Reviewed-by:
-
rbpotter authored
Remove an assertion that the zoom buttons are never focused while invisible outside of Print Preview. In certain cases (e.g. embedded PDFs), this can still happen. Bug: 1103029 Change-Id: I2ba06da1e6245b62bd011ae3e45daaa01560e926 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288343 Commit-Queue: dpapad <dpapad@chromium.org> Auto-Submit: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#786919}
-
Christopher Cameron authored
Add a method GLImage::IsInUseByWindowServer. This is implemented only macOS, and queries the IOSurfaceIsInUse method. Roll the the function GLImageIOSurface::CanCheckIOSurfaceIsInUse into the GLImageIOSurface::IsInUseByWindowServer function. Add two accessors to viz::OutputPresenter::OverlayData. One is IsInUseByWindowServer (which calls the method on the GLImage). The second returns the mailbox for the the overlay. Add viz::SkiaOutputDeviceBufferQueue::in_use_by_window_server_overlays_, which is a map from gpu::Mailbox to viz::OutputPresenter::OverlayData. When overlays are swapped in SkiaOutputDeviceBufferQueue:: DoFinishSwapBuffers, move them into this map, and remove any entries that are no longer in use. Bug: 1100750 Change-Id: I32ccc4aee6e0392e258bc03086f70f06a5b2bdc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274776 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#786918}
-
Ilia Samsonov authored
Bug: 1068400 Change-Id: Ia3b42950b133474e4b6775b3fde59fd22b9ac522 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288758Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#786917}
-
dpapad authored
Specifically: - cr_searchable_drop_down_tests.js - cr_view_manager_tests.js - iron_list_focus_test.js Also in this process, realized that cr-searchable-drop-down was using the deprecated KeyEvent#code attribute, and updated it to use KeyEvent#key instead. Bug: 1000989 Change-Id: I5c421562f5ee90c5f1ea42b7cb2b1c6fd2aa31a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289080Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#786916}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Ic319c9d76b19fc614177232f0cd8347a1e3816a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290230Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#786915}
-
Darwin Huang authored
Complete and expose previously incomplete feature policy integration. Also, use separate clipboard-read and clipboard-write feature policies, as opposed to the previous single clipboard feature policy. Previously, https://crrev.com/c/1913466 aimed to add Feature Policy integration to the Clipboard API. Unfortunately, this integration wasn't complete, so sites didn't have the option to allow cross-origin iframes to access the clipboard at all after this change. Complete the integration to allow sites to enable this feature policy. Also, as feature and permission policies are being merged, use clipboard-read and clipboard-write as feature policy names, so that the feature policy and permission names match. Verified by via automated WPTs, and also manually tested by running this example[1], which fails without this CL, and succeeds with the CL. Intent to prototype and ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/IDAapW6w4to/iSH1MXRFCgAJ [1]: https://smart-flicker-baroness.glitch.me/ Bug: 1074489 Change-Id: I09125d74510ed6c868d84936df595d02326619b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164248 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Alex Russell <slightlyoff@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#786914}
-
John Abd-El-Malek authored
Change-Id: I1f522f3504d2ba61f24a8703ef8b2972bec0c68c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290314 Auto-Submit: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#786913}
-
Jeremy Roman authored
This is somewhat verbose, but allows us to avoid the unhandled rejection being visible to script without having to make this hack even worse. Instead of actually calling activate(), this mirrors the spec structure by simply calling to underlying logic, passing a resolver where it makes sense and not (in this case, passing a substitute object) where it doesn't. The web test is added to SlowTests because it uses timeouts to check that things don't happen, and the additional test makes the timeouts 6 seconds total -- which is the test runner timeout. Slow tests get 5x longer before they are aborted. The alternative would have been to shorten the timeouts in this test, but that may have made the test more flaky. Bug: 1102081 Change-Id: Ied9d26e32ee426bf0a135279a9063f104d0e6460 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290231 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Auto-Submit: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#786912}
-
Chris Harrelson authored
In an earlier CL (*) a condition around various compositing steps was accidentally removed. This CL re-adds the condition. (*) https://chromium-review.googlesource.com/c/chromium/src/+/2283630 Bug: 1102702 Change-Id: I7e0364f5320b7e20c3c9c49812477a17a7ca6179 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290078 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#786911}
-
Erik Chen authored
This CL addresses some comments from sky@ from https://chromium-review.googlesource.com/c/chromium/src/+/1024296. Bug: 832879 Change-Id: I8919f8aa71daf85dbacf4841ae12829b7a156bb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1028178 Commit-Queue: Erik Chen <erikchen@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#786910}
-
Daniel Nicoara authored
DisplayConfigurationParams makes a copy of the mode. Need to compare modes by value to verify it's a valid mode. BUG=None TEST=Run cast_shell on desktop and ensure no crashes due to display configuration failure. Change-Id: I405ccb87333d270f1b8cbbe4ee187e2bd9bdcc57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288818Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#786909}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/dab10eae8a82..c98988de119f 2020-07-09 tommek@google.com Added validation tests for copying to 2d-array textures If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ia70f01c0d65e85c91556d7e26b9a68462e429ffc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289655Reviewed-by:
-
Henrique Ferreiro authored
Bug: 533069 Change-Id: I6819e53641013f2f079abb0a65bf86b1363f5558 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287300Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#786907}
-
Anastasia Helfinstein authored
This reverts commit 2e0cfc50. Reason for revert: crbug/1103769 Original change's description: > [Switch Access] Detect menus and modal dialogs > > If the user navigates to a modal or system menu (other than by focus > automatically jumping there), we should still use the custom behavior > for modals. > > AX-Relnotes: n/a. > Bug: None. > Change-Id: Ie0b963f1540568cdd8f249ee016e787de45c0b3b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270468 > Auto-Submit: Anastasia Helfinstein <anastasi@google.com> > Reviewed-by: David Tseng <dtseng@chromium.org> > Commit-Queue: Anastasia Helfinstein <anastasi@google.com> > Cr-Commit-Position: refs/heads/master@{#785946} TBR=dtseng@chromium.org,anastasi@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: None. Change-Id: I4d285382d993d5082814da6f43e0122558777010 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290350Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#786906}
-
Collin Baker authored
Fixed: 1103167 Change-Id: Ibfd33d4148ad4a776b4112860eaf36f95c9b127d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289061Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#786905}
-
Liviu Tinta authored
Fix following lint problems noticed in cc/trees/property_tree.cc: 1138:Use int16/int64/etc, rather than the C type long [runtime/int] [4] 1999:Add #include <string> for string [build/include_what_you_use] [4] 1678:Add #include <utility> for move [build/include_what_you_use] [4] 2081:Add #include <algorithm> for max [build/include_what_you_use] [4] Bug: 1087088 Change-Id: I56179eb0989acae48535dc3665ee89aba948bfcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289917Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Cr-Commit-Position: refs/heads/master@{#786904}
-
Anastasia Helfinstein authored
This change sets up the infrastructure for future development of an alternate form of selection via Switch Access called Point Scanning. (go/cros-switch-point-scanning has more details). Specifically, this change creates a PointScanController to drive the logic and a PointScanLayer to draw the UI, as well as a command-line to develop behind. Currently, if the flag kEnableSwitchAccessPointScanning is enabled, Switch Access draws a vertical line through the center of the screen when the feature is turned on. Bug: 1061537 Change-Id: Ifba390904d5e94ee5edbe494a6799168a95a7272 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092731 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#786903}
-
danakj authored
These are flaky because they are ending before composite happens, and then their log messages don't appear in the test results. R=avi@chromium.org, jarhar@chromium.org Bug: 1103759, 866140 Change-Id: I3b651439f7b5b14e7c6f5e53bf8b335d8014f980 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289943Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Joey Arhar <jarhar@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#786902}
-
Xiaohan Wang authored
ComPtr<T>::GetAddressOf() is banned. Previously we abuse GetAddressOf() for input array of T*. This CL creates an array explicitly to get rid of this abuse. Bug: 914910 Change-Id: Id4ea06d3d188d9e7d1a5f692549f0914bc41707d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290254 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Auto-Submit: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#786901}
-
Brandon Jones authored
Bug: 1099831 Change-Id: Ifd896b7caf8fedcf3083a8fc4ea6c8b1d85b94c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290073 Commit-Queue: Brandon Jones <bajones@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#786900}
-
Robbie McElrath authored
crrev.com/c/2247154 introduced a regression that caused empty seed files to be considered valid. When requesting a new seed from the service, we create an empty 'new' seed file that will possibly get written to the by the service at a later point. If the service doesn't write an updated seed to the empty file, WebView is supposed to try the old seed file. Because we now consider empty seed files valid, we don't fall back to the old file anymore if there's an empty new file, which will be the case any time a new seed has been requested. Test: out/aw/bin/run_webview_instrumentation_test_apk \ Test: --gtest_filter='*VariationsSeedLoaderTest#testHaveEmptyNewSeed' Bug: 1103003 Change-Id: Ic34a685cb7623bf1d70823edc491346551e7a144 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286271 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#786899}
-
Chris Hamilton authored
This CL introduces a strongly typed FrameToken mojo struct. Subsequent CLs will migrate all code to use this type. BUG=1096617 Change-Id: I139e5c14ff29c9fe7437f9cc805d38da6999460a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288208Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
Yves Arrouye authored
When requesting device state, if the device state restore mode is set to RESTORE_MODE_NONE in the response and there is a value for the initial_state_response field, process that field immediately. See go/cros-oobe-state-determinations for design. Bug: chromium:1102607 Test: xvfb-run unit_tests --gtest_filter="*AutoEnrollmentClientImplTest*" Change-Id: Ida3976a196f9df516f6886f7bc4e56bb186e3cb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283586Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Yves Arrouye <drcrash@chromium.org> Cr-Commit-Position: refs/heads/master@{#786897}
-
Yusuf Sengul authored
Bug: 1101123 Change-Id: Ic34c0e3a3e59a4311de4746b36479e0bc839a025 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278067 Commit-Queue: Yusuf Sengul <yusufsn@google.com> Reviewed-by:
Rakesh Soma <rakeshsoma@google.com> Cr-Commit-Position: refs/heads/master@{#786896}
-
Mike Dougherty authored
Bots rolled with the following script: git grep -l '12a6159' | xargs sed -i '' -e 's/12a6159/12a6163b/g' to update: infra/config/lib/builders.star infra/config/subprojects/chromium/master-only/ci.star testing/buildbot/mixins.pyl testing/buildbot/waterfalls.pyl then configs were generated with: ./infra/config/main.star ./testing/buildbot/generate_buildbot_json.py CIPD packages: infra_internal/ios/xcode/mac 12a6163b infra_internal/ios/xcode/ios 12a6163b Bug: 1102933 Change-Id: I647e328ed6e8b0b7160a930eb97fb98f400944b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285387 Auto-Submit: Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
-
Christopher Cameron authored
Bug: 1076568 Change-Id: I795e2d1a992a3f25cf6255a8ed263c26a12f9794 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289545 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#786894}
-
Xiaohan Wang authored
Microsoft::WRL::ComPtr<T>::GetAddressOf() is banned due to the ease of causing memory leaks. Also replace CopyTo(foo.GetAddressOf()) with As(&foo) since CopyTo(&foo) does not work if we are copying to different interfaces. ComPtr::ReleaseAndGetAddressOf() is safe but ComPtr::operator& is still preferred. Bug: 914910 Change-Id: Ifc70f64a9d584883b2162fafce6ef12d18647dbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289440 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Auto-Submit: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
-
