GitLab

BUG=chromium-os:18876
TEST=See issue.

Review URL: http://codereview.chromium.org/7528016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96054 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=andreip
Review URL: http://codereview.chromium.org/7607002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96053 0039d316-1c4b-4281-b951-d872f2087c98

clicking.
BUG=90994
TEST=none


Review URL: http://codereview.chromium.org/7541056

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96052 0039d316-1c4b-4281-b951-d872f2087c98

BUG=87457
TEST=none


Review URL: http://codereview.chromium.org/7558003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96049 0039d316-1c4b-4281-b951-d872f2087c98

"in which we beef up the unit tests and find several bugs"

1- When parsing the xml response components not mentioned there were left in "updating" state so they got stranded there.
2- Wrong condition :
   if ((item->status != CrxUpdateItem::kNoUpdate) ||

       (item->status != CrxUpdateItem::kUpToDate))
   So again some components are stranded in the kNoUpdate state.

Also a new precondition ScheduleNextRun() cannot be called if a url_fetcher is in progress.

BUG=61602
TEST=included
Review URL: http://codereview.chromium.org/7601019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96048 0039d316-1c4b-4281-b951-d872f2087c98

TEST=None
BUG=83242

Review URL: http://codereview.chromium.org/7599003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96047 0039d316-1c4b-4281-b951-d872f2087c98

BUG=76788
TEST=no change visible

Review URL: http://codereview.chromium.org/7575010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96046 0039d316-1c4b-4281-b951-d872f2087c98

Step 1 was https://bugs.webkit.org/show_bug.cgi?id=53521

This is step 2.

3 is to remove WebIDBTransactionCallbacks::onTimeout from the webkit api.

BUG=
TEST=llvm/Debug/browser_tests --gtest_filter=IndexedDBBrowser*


Review URL: http://codereview.chromium.org/7550055

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96044 0039d316-1c4b-4281-b951-d872f2087c98

BUG=XXXX
TEST=XXXX

Review URL: http://codereview.chromium.org/7210034

TBR=ycxiao@chromium.org
Review URL: http://codereview.chromium.org/7605007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96042 0039d316-1c4b-4281-b951-d872f2087c98

This corrects an issue causing file URL access to default on for <all_urls> and file:/// permissions. We also revert all extension's "allow file access" flags to false since we can't distinguish between extensions that were installed with the bug present and those where the user clicked allow file access.

BUG=91577
TEST=ExtensionServiceTest.DefaultFileAccess

Review URL: http://codereview.chromium.org/7574017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96041 0039d316-1c4b-4281-b951-d872f2087c98

BUG=90558
TEST=none

Review URL: http://codereview.chromium.org/7529051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96040 0039d316-1c4b-4281-b951-d872f2087c98

BUG=90759
TEST=Set the IncognitoEnabled policy to false. Start the browser with the --incognito switch. An error message should be displayed, and a normal browser is started.


Review URL: http://codereview.chromium.org/7562009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96039 0039d316-1c4b-4281-b951-d872f2087c98

Inline virtuals must be empty.

BUG=none
TEST=green clang bot

Review URL: http://codereview.chromium.org/7608002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96038 0039d316-1c4b-4281-b951-d872f2087c98

in any blank icons if none can be found.

R=estade@chromium.org
BUG=92073
TEST=none


Review URL: http://codereview.chromium.org/7600010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96037 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None


Review URL: http://codereview.chromium.org/7599023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96036 0039d316-1c4b-4281-b951-d872f2087c98

BUG=XXXX
TEST=XXXX

Review URL: http://codereview.chromium.org/7210034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96035 0039d316-1c4b-4281-b951-d872f2087c98

BUG=77634
TEST=None

R=akalin@chromium.org

Review URL: http://codereview.chromium.org/7528026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96033 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7604004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96032 0039d316-1c4b-4281-b951-d872f2087c98

Encrypted OAuth1 all access token and secret with system salt for now, will replace this with user suplemental key once that gets exposed from cryptohome.

Also fixed crash on re-adding the same user to the system.

BUG=chromium-os:18634, chromium-os:18551
TEST=open /home/cronos/user/Preferences and make sure oauth token and secert are encrypted now
Review URL: http://codereview.chromium.org/7584026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96031 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7108044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96030 0039d316-1c4b-4281-b951-d872f2087c98

Move filename determination logic to net_util so that it's not split between net_util and download_util.

BUG=78085
TEST=net_unittests --gtest_filter=*Generate*FileName


Review URL: http://codereview.chromium.org/7300005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96029 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7572025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96028 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=

Review URL: http://codereview.chromium.org/7606001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96027 0039d316-1c4b-4281-b951-d872f2087c98

Probably since it was added at revision r8.

BUG=None
TEST=None

R=evan@chromium.org

Review URL: http://codereview.chromium.org/7558023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96026 0039d316-1c4b-4281-b951-d872f2087c98

closure_blocks_leopard_compat_stub.

This was originally checked in at r95892, but the stripping was disabled in
r95895 because the original implementation resulted in a double-strip, and
you can't strip something again once it's been turned into an MH_DYLIB_STUB.

BUG=91978
TEST=Builds remain green
Review URL: http://codereview.chromium.org/7598037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96025 0039d316-1c4b-4281-b951-d872f2087c98

Revert 96013 - Use MessageLoopProxy instead of MessageLoop to dispatch notifications in ObserverListThreadsafe.

BUG=91589

Review URL: http://codereview.chromium.org/7584016

TBR=adamk@chromium.org
Review URL: http://codereview.chromium.org/7605002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96024 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96023 0039d316-1c4b-4281-b951-d872f2087c98

The automation proxy launcher is only producing ASCII log messages, so
regular strings are fine. In the process, fix an unwanted & in one of
the log messages which causes a format string error.

The video capture test is generating a filename and should be using
FILE_PATH_LITERAL to get the right kind of string for the platform.


Review URL: http://codereview.chromium.org/7519028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96022 0039d316-1c4b-4281-b951-d872f2087c98

Includes:
make-linux: handle the case where there are no ldflags
make-linux: add an rpath for shared libraries

Review URL: http://codereview.chromium.org/7599016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96020 0039d316-1c4b-4281-b951-d872f2087c98

BUG=91861
TEST=

Review URL: http://codereview.chromium.org/7491068

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96018 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/7572003
Patch from Anuj Bansal <anujb@google.com>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96017 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=


Review URL: http://codereview.chromium.org/7591001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96014 0039d316-1c4b-4281-b951-d872f2087c98

BUG=91589

Review URL: http://codereview.chromium.org/7584016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96013 0039d316-1c4b-4281-b951-d872f2087c98

ExtensionHistoryApiTest.FLAKY_MiscSearch is timing out on ChromeOS builds.

BUG=76170
TEST=Chromium OS tester goes green.
TBR=skerner@chromium.org

Review URL: http://codereview.chromium.org/7598038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96011 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:17870
TEST=manual testing on chromeos-chrome on linux

Review URL: http://codereview.chromium.org/7529036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96010 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7601026


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96009 0039d316-1c4b-4281-b951-d872f2087c98

BUG=80230
TEST=api tests

Review URL: http://codereview.chromium.org/7599027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96008 0039d316-1c4b-4281-b951-d872f2087c98

Every field present in the address editor should be included in the list of distinguishing fields to avoid empty profile labels.

BUG=91722
TEST=unit_tests --gtest_filter=AutofillProfileTest.PreviewSummaryString


Review URL: http://codereview.chromium.org/7528017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96006 0039d316-1c4b-4281-b951-d872f2087c98

This makes the bubbles ten pixels shorter and implements
the Bubble class's fade-in/fade-out behavior for GTK+ (which
also e.g. makes bookmark bubbles now fade away when you
click their "Done" buttons or "Remove" links, like on other
platforms).

BUG=chromium-os:8473
TEST=manual: configured the setting bubbles to fade in and out and checked that they looked correct

Review URL: http://codereview.chromium.org/7529038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96004 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96002 0039d316-1c4b-4281-b951-d872f2087c98