GitLab

BUG=270135
For sync/util/get_session_name.cc (comment change only):
TBR=tim@chromium.org

Review URL: https://codereview.chromium.org/25112004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227700 0039d316-1c4b-4281-b951-d872f2087c98

> reland "views: change WrenchMenu to use each model's command ID's when creating MenuItemView's"
> 
> the original cl (hhttps://codereview.chromium.org/25667005/) was reverted because of crash in bug 304756, this cl relands it with the fixes. 
> 
> this is in preparation for dynamic recent tabs model and menu: 
> 
> * WrenchMenu: 
> - for each menu item, MenuItemView::GetCommand() used to be separate and different from MenuModel::GetCommandIdAt(model_index); they are the same now. 
> - different range of command id's are reserved for recent tabs and bookmarks. 
> - command id's of all items in the wrench menu and all its submenus can't clash, except for separator and IDC_SHOW_HISTORY, the latter of which is in both wrench menu and recent tabs submenu. 
> 
> * RecentTabsSubMenuModel: 
> - make all command ids within range, use different ids among device name headers. 
> 
> * BookmarkMenuDelegate 
> - makes sure only maximum number of menu items allowed is created. 
> - add test. 
> 
> BUG=256750
> TEST=wrench menu and all its submenus still work.
> 
> Review URL: https://codereview.chromium.org/26455004

The new test has memory leaks. When the previous menu delegate is freed it doesn't
free the menu it creates in Init, I suspect this normally is handled by the views
system itself.

Example of leaks:
http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28valgrind%29%286%29/builds/21625

You can reproduce the leaks by building for chromeos and running under valgrind:
http://www.chromium.org/developers/how-tos/using-valgrind

TBR=kuan@chromium.org

Review URL: https://codereview.chromium.org/26546004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227699 0039d316-1c4b-4281-b951-d872f2087c98

When Windows runs in Ash (i.e. Metro), it is a full screen environment
separate from the traditional desktop.  Many Win32 common dialog functions
however only support the desktop.  Opening such dialogs in Metro mode will
open them on the desktop, and to the user it will either appear as though
nothing happened (in the best case), or hang their browser (in the worst
case, if the dialog is modal).

Long term the goal is to enable these functions through their Metro
counterparts (usually in the form of a system charm that opens on the side
side of the display).

BUG=291280

Review URL: https://codereview.chromium.org/26523002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227698 0039d316-1c4b-4281-b951-d872f2087c98

BUG=262999

Review URL: https://codereview.chromium.org/24280010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227697 0039d316-1c4b-4281-b951-d872f2087c98

> Added the Prerender.ModPagespeedHeader.* histograms to histograms.xml. 
> Extended the data extraction to also handle X-Page-Speed headers.
> 
> (dup of 20832003 which I can't commit with my personal email account)
> 
> BUG=267695
> 
> Review URL: https://codereview.chromium.org/26279004

This test caused a leak on the memory bots. Details can be found here:
http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28valgrind%29%283%29/builds/30782/

TBR=matterbury@google.com

Review URL: https://codereview.chromium.org/26670002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227696 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/26611002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227695 0039d316-1c4b-4281-b951-d872f2087c98

This reverts r227562 to reland r227544.

Original description: "Move SuspendObserver,
UserActivityNotifier, and VideoActivityNotifier from
chrome/browser/chromeos/power to ash/system/chromeos/power."

This iteration makes ash::Shell's destructor destroy
VideoActivityNotifier before VideoDetector to avoid a
use-after-free.

BUG=none

Review URL: https://codereview.chromium.org/26569003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227694 0039d316-1c4b-4281-b951-d872f2087c98

R=sievers

Review URL: https://codereview.chromium.org/26091002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227693 0039d316-1c4b-4281-b951-d872f2087c98

BUG=299620

Review URL: https://codereview.chromium.org/26562003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227692 0039d316-1c4b-4281-b951-d872f2087c98

BUG=170921
TEST=everything still works

Review URL: https://codereview.chromium.org/26552002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227691 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/25892006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227690 0039d316-1c4b-4281-b951-d872f2087c98

BUG=292393

Review URL: https://codereview.chromium.org/25845003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227689 0039d316-1c4b-4281-b951-d872f2087c98

We do this in LoadExtension and InstallOrUpdateExtension, and
missing it in ReloadExtension can cause hard-to-understand or
possibly even flaky failures.  The extra call does nothing in the
case that there aren't any loading views.

I didn't add this to EnableExtension because that doesn't run the
message loop at all, so the failure to wait for views to load is
less surprising.

Review URL: https://codereview.chromium.org/26451005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227688 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227687 0039d316-1c4b-4281-b951-d872f2087c98

This doesn't need to be scoped to just Mac 64-bit.  This fails on the
Blink canaries 100% of the time.

R=ben@chromium.org
BUG=302156

Review URL: https://codereview.chromium.org/26546003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227686 0039d316-1c4b-4281-b951-d872f2087c98

Extended the data extraction to also handle X-Page-Speed headers.

(dup of 20832003 which I can't commit with my personal email account)

BUG=267695

Review URL: https://codereview.chromium.org/26279004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227685 0039d316-1c4b-4281-b951-d872f2087c98

Digital persona hooks us in bad ways, leading to obscure crashes. In
particular their hook procedures trigger sending messages, leading to
states we are not set up to handle, nor should we have to handle.

BUG=291265
TEST=none
R=cpu@chromium.org

Review URL: https://codereview.chromium.org/26541003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227684 0039d316-1c4b-4281-b951-d872f2087c98

BUG=70076,304715

Review URL: https://codereview.chromium.org/26292005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227683 0039d316-1c4b-4281-b951-d872f2087c98

BUG=265769
TEST=build

Review URL: https://codereview.chromium.org/26479002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227682 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/26320006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227681 0039d316-1c4b-4281-b951-d872f2087c98

modally on the desktop, causing the browser to appear hung 
with no indication to the user that it is waiting on input 
from a modal dialog on the desktop.

This patch hides the "Print with system dialog..." link in 
Print Preview iff metro.

BUG=291345

Review URL: https://codereview.chromium.org/25033006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227680 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/26314003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227679 0039d316-1c4b-4281-b951-d872f2087c98

1. Put category-remaining node into this category node rather than parallel with it.
2. Fix a bug in menu-view.js.

BUG=259206,305097
NOTRY=True

Review URL: https://codereview.chromium.org/26478002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227678 0039d316-1c4b-4281-b951-d872f2087c98

When native app window visibility changes due to either show/hide or minimize/un-minimize, the RWH will now be notified so that page visibility events fire in the renderer.

BUG=157300
TEST=Install window-state-sample (https://chrome.google.com/webstore/detail/window-state-sample/gjijpbgljcllmmhmbcdcaegdandpgpml). Hiding or minimizing the window will cause document.webkitHidden to be true. This can be observed by looking at its checkbox under the "last 10 seconds" readout area after restoring visibility.

Review URL: https://codereview.chromium.org/23473005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227677 0039d316-1c4b-4281-b951-d872f2087c98

BUG=305274
Test=Load Browser sample app on Linux GTK build, drag some text outside of the webview, perhaps outside of the window. The webview will crash.

Review URL: https://codereview.chromium.org/26168006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227676 0039d316-1c4b-4281-b951-d872f2087c98

the original cl (hhttps://codereview.chromium.org/25667005/) was reverted because of crash in bug 304756, this cl relands it with the fixes. 

this is in preparation for dynamic recent tabs model and menu: 

* WrenchMenu: 
- for each menu item, MenuItemView::GetCommand() used to be separate and different from MenuModel::GetCommandIdAt(model_index); they are the same now. 
- different range of command id's are reserved for recent tabs and bookmarks. 
- command id's of all items in the wrench menu and all its submenus can't clash, except for separator and IDC_SHOW_HISTORY, the latter of which is in both wrench menu and recent tabs submenu. 

* RecentTabsSubMenuModel: 
- make all command ids within range, use different ids among device name headers. 

* BookmarkMenuDelegate 
- makes sure only maximum number of menu items allowed is created. 
- add test. 

BUG=256750
TEST=wrench menu and all its submenus still work.

Review URL: https://codereview.chromium.org/26455004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227675 0039d316-1c4b-4281-b951-d872f2087c98

When loading a video from Drive user switch to the next picture and clicked on the screen, then we were getting an error. This was happening because the video was already detached from the media controls, but still available in the image view. This patch addresses this issue by checking if both - video is being displayed and it is attached to the media controls.

TEST=Partly by browser_tests. Manually tested using repro steps in the bug entry.
BUG=305102

Review URL: https://codereview.chromium.org/26288003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227674 0039d316-1c4b-4281-b951-d872f2087c98

Move GestureEventFilter-related tests from the general router tests to the more
specific GestureEventFilterTest. Create GestureEventFilterClient and
TouchpadTapSuppressionControllerClient interfaces to remove explicit InputRouter
dependencies.

BUG=301807,302592

Review URL: https://codereview.chromium.org/26376002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227673 0039d316-1c4b-4281-b951-d872f2087c98

R=dmichael@chromium.org
BUG=303818

Review URL: https://codereview.chromium.org/26571002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227672 0039d316-1c4b-4281-b951-d872f2087c98

Previously though TraceEvent is copyable, the copy has side-effect that
will clear the convertable pointers in the source TraceEvent. This
hadn't been a problem before https://codereview.chromium.org/23531042/
which added TraceBuffer::Clone() so exposed the potential problem.

Make ConvertableToTraceFormat ref-counted to allow copying of
TraceEvents.

This also simplifies the client code and trace_event.h because
scoped_refptrs can be assigned just like other types of variables.

TEST=existing tests
BUG=none

Review URL: https://codereview.chromium.org/26266003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227671 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds a short cut key to open the new window by adding the shortcut attribute to the new-window command.

BUG=256242
TEST=manually

Review URL: https://codereview.chromium.org/26340007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227670 0039d316-1c4b-4281-b951-d872f2087c98

The content client interface now requests a RequestContext.

BUG=None
TEST=Run views_examples_with_content_exe and select WebView from the menu. It no longer crashes.

Review URL: https://codereview.chromium.org/26550002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227669 0039d316-1c4b-4281-b951-d872f2087c98

The crop rectangle has to be updated when resizing the window. This patch does that by listening to the onresize event within the cropping tool class.

TEST=Tested manually. Open a picture, try to crop. Then resize the window. The crop rectangle should reflect the new window size.
BUG=284946

Review URL: https://codereview.chromium.org/26445002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227668 0039d316-1c4b-4281-b951-d872f2087c98

This cleans up some renderer-specific stuff to make it easier to read the code
changes when moving QuotaFileIO to the browser.

BUG=246396

Review URL: https://codereview.chromium.org/26560003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227667 0039d316-1c4b-4281-b951-d872f2087c98

- Removed everything except for frame count, paint/record/rasterize time and
pixel count.
- Cleaned up variable naming.
- Removed RasterStats struct. Replaced by direct usage of
RenderingStatsInstrumentation.

R=nduca@chromium.org
BUG=234308,280638

Review URL: https://codereview.chromium.org/26031002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227666 0039d316-1c4b-4281-b951-d872f2087c98

This is a copy of https://chromiumcodereview.appspot.com/23022006, which was reverted due to perf regression. The root cause was WebContentsImpl::GetWebkitPrefs using GetLastCommittedEntry, which caused compositing to be disabled and higher memory usage on Mac. I've removed that part of the change and will investigate separately how to best fix it.

BUG=273710

Review URL: https://codereview.chromium.org/25654005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227665 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227663 0039d316-1c4b-4281-b951-d872f2087c98

Calling PluginStream methods may cause the instance to be deleted, causing a UAF.
Modify the code to update members before calling PluginStream methods.

BUG=304787

Review URL: https://codereview.chromium.org/26526002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227661 0039d316-1c4b-4281-b951-d872f2087c98

This is crashing on the Blink canaries.

BUG=299149

Review URL: https://codereview.chromium.org/26549002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227660 0039d316-1c4b-4281-b951-d872f2087c98

BUG=302037

Review URL: https://codereview.chromium.org/26494002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227659 0039d316-1c4b-4281-b951-d872f2087c98