- 04 Aug, 2020 40 commits
-
-
Domenic Denicola authored
This finishes testing all the ways in which document.domain can affect cross-window access. Bug: 1042415 Change-Id: Id56aad05178333c480f0682fc00bddc28829769d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335636Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#794674}
-
Maxime Charland authored
The subtitle for the Reading List has been change to explicitly mention "Read Later". Bug: 1098328 Change-Id: I3d5c1759f782a8e2c404b3aca2299a96922d6be2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336783Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Commit-Queue: Maxime Charland <mcharland@google.com> Cr-Commit-Position: refs/heads/master@{#794673}
-
Joe DeBlasio authored
The New Tab Page in CCTs doesn't work quite like you'd expect (since they don't happen in organically), so this CL prevents using the NTP as the default "safe page" for Safety Tips when a better recommendation isn't available. Instead, this CL either navigates back (if possible), or closes the CCT (if not possible). This isn't an ideal solution either, but there probably isn't a magical option. Bug: 1007029 Change-Id: I63f53e361d734f4b26480467f74b182612dd210b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2334591 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#794672}
-
Adrienne Walker authored
When indexeddb moves to the storage service, this static getter will use the file system proxy for the storage service instead of an unrestricted one. See: https://chromium-review.googlesource.com/c/chromium/src/+/2079642 Bug: 1052045 Change-Id: I8e02c888ea548d4fd60bda4c221f785a442a3aab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333057 Auto-Submit: enne <enne@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#794671}
-
Rune Lillesveen authored
Move to NeverFixTests since the keyword is not supported and group with previously failing clip issues. R: ikilpatrick@chromium.org Bug: 966283 Change-Id: I77f3c51a78c6f621d240f35b253b05f8f587e435 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333201 Auto-Submit: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#794670}
-
Collin Baker authored
This name is more discoverable and is consistent with chrome/browser/ui/in_product_help. Bug: 1106523 Change-Id: Ie611c9c25333ff349b8a2bc4c7110f6d1c047edd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332700Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#794669}
-
Aaron Colwell authored
Adding crash logging to the BrowserContext destructor to help diagnose cases where a RenderProcessHost object still references a BrowserContext that is being destroyed. These situations can potentially lead to UAF bugs so this logging should help us detect potential issues earlier. This change will make it easier to debug the crashes that caused http://crrev.com/c/2305674 to get reverted without causing user visible crashes. This change also fixes a few tests that were accidentally keeping around objects that kept a RenderProcessHost alive beyond the lifetime of its BrowserContext. Bug: 1099998 Change-Id: I45f9e2e281807b9364f560e675447a9f5d3a69c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324408Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Aaron Colwell <acolwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#794668}
-
Min Qin authored
If clicking on a tile triggers a search, currently the AQS params are missing as the search URL is built directly from TemplateUrlService. This CL fixes that behavior by going through the AutocompleteController to find the right AutocompleteMatch, and build the search URL from it. BUG=1110034 Change-Id: I6479726c93b8dd71d21c2753c35284d7fd5abc35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324770 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by: Ender
💬 =🕐 (ping me for faster reviews) <ender@google.com> Cr-Commit-Position: refs/heads/master@{#794667} -
Haiyang Pan authored
This could enable users to use avd.py script via CIPD, rather than checking out the entire chromium source. Bug: 1112429 Change-Id: Ie4693191da4a2ddcb21930af8886b7ec5b54ba72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2334685Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#794666}
-
Boris Sazonov authored
Creates WebSigninBridge class that listens to IdentityManager and AccountReconcilor on the native side and notifies the code on the Java side when the sign-in process is completed. Bug: 1093741 Change-Id: Ia2b00ac796a46e6d332ad4df11982fc49bbbd218 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327051 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#794665}
-
Aaron Krajeski authored
This reverts commit 5abb4e4d. Reason for revert: crbug.com/1112723 was the real culprit Original change's description: > Revert "Add managed text view in Security settings page." > > This reverts commit 835d50e1. > > Reason for revert: Linux CFI failures https://ci.chromium.org/p/chromium/builders/ci/Linux%20CFI > > Original change's description: > > Add managed text view in Security settings page. > > > > Screenshot: http://screen/zaaBRbPGsTd > > > > Bug: 1097310 > > Change-Id: I26b76f2071d4e2ee5b4fc5ff04868b24bed88a8c > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316829 > > Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> > > Reviewed-by: Natalie Chouinard <chouinard@chromium.org> > > Reviewed-by: Varun Khaneja <vakh@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#794260} > > TBR=vakh@chromium.org,chouinard@chromium.org,xinghuilu@chromium.org > > Change-Id: I065975a7f0ee2fbb6d04b22c36adc12bc8502d13 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1097310 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333685 > Reviewed-by: Aaron Krajeski <aaronhk@chromium.org> > Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#794520} TBR=vakh@chromium.org,aaronhk@chromium.org,chouinard@chromium.org,xinghuilu@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1097310 Change-Id: I4d1c5b5050ad570b411c2843d84f2acb4769e30d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337113Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#794664}
-
Curt Clemens authored
NearbyShareCertificateStorageImpl requires that Initialize be called before calling any functions that rely on LevelDB. This change queues up any calls made before initialization succeeds so that the caller doesn't have to wait for initialization to complete. Change-Id: I9f6de24826c9b5d449142366ceb86828f8e0ef4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332332 Commit-Queue: Curt Clemens <cclem@google.com> Reviewed-by:
Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#794663}
-
John Lee authored
Bug: 1084620 Change-Id: I6f09aad6cd13fd5c6edbb6015edc3d09a7cc5ff5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333171 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#794662}
-
yilkal authored
This cl fixes the bug where the child user is stuck in EDU account addition flow when the user's parental control setting is 'Only allow certain sites'. Inorder to prevent this error from happening we will do only safe search filter for the EduCoexistence webview and not enforce the 'Only allow certain cites' settings potentially set by the child's parents. "https://accounts.google.com" is manually whitelisted. This is because there is a race condition where we don't know whether the WebContent is an inner WebContent belonging to EduCoexistence flow or not by the time throttling happens. This happens because navigation to accounts.google.com is started before the <webview> WebContents is attached to the outer WebContents hosted by the EduCoexistence flow WebUI. We are making this exception only to the webview that is present in the EDUCoexistence flow. The exception is made because the parent is present with the child during the flow. Extending this exception to every inner webcontents will may allow the child to break parental settings. Bug: 1079510 Change-Id: I4f3e65e58537a845613b0c49b03f801f0a3caa08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316443Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Yilkal Abe <yilkal@chromium.org> Cr-Commit-Position: refs/heads/master@{#794661}
-
Mohamed Amir Yosef authored
Follow up CL will make use of this API. Bug: 1108181 Change-Id: I931e2aac81ff5164b129c8556b0bb27d1e15fc6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333835Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#794660}
-
Mike Wittman authored
Updates the image builder to support non-relocatable ELF images and instantiates the tests for the non-relocatable images. Replaces GetElfBaseVirtualAddress() with GetRelocationOffset(). Relocation is a well defined concept in the ELF standard, while 'base virtual address' is not, and is at odds with the 'base address' concept. For clarity, avoids the implicit assumption that the first load segment's file offset is 0. Makes the handling of the ELF base address consistent among the functions. Bug: 1101023 Change-Id: I6eac949a79a02e7e3a662f604193bf414d5ad38f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305570 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#794659}
-
Tibor Goldschwendt authored
The dummy module helps us build out the module infrastructure. This CL adds the dummy module plus a few management functions to register and render modules. + Add feature flag to enable NTP modules. Fixed: 1110055 Change-Id: Iea63854a82bc9facacb7f75aad2d26f629e60e9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333526 Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#794658}
-
Rebekah Potter authored
This reverts commit 7e3a7255. Reason for revert: Consistent failures of external/wpt/html/semantics/scripting-1/the-script-element/module/dynamic-import/alpha/base-url-worker.sub.html in blink_web_tests on multiple builders started after this change landed. Original change's description: > [WPT] Test script's base URL used in dynamic imports > > This CL checks base URL used in resolving relative URL-like > specifiers in dynamic imports() from > > - `<script>`s, > - worker top-level scripts, and > - worker scripts imported by `importScripts()`. > > This is for https://github.com/whatwg/html/issues/5751. > > Bug: 1082086 > Change-Id: I778fb4d34b2e61f57799600006963c93aee5272c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198835 > Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> > Reviewed-by: Domenic Denicola <domenic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#794492} TBR=hiroshige@chromium.org,domenic@chromium.org Change-Id: I2fd1c341c96d0364a6dbe6cce31a8c2630403b27 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1082086 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335460Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#794657}
-
Xiaoling Bao authored
Bug: 1068797 Change-Id: Iaf56825d95fdb1ba502dfb2d8538f288192e3c28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332572 Commit-Queue: Xiaoling Bao <xiaolingbao@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#794656}
-
Clark DuVall authored
Follow up after feedback on http://crrev.com/c/2328302. Bug: 1111909 Change-Id: If3107a6bc513d2aad898e8bc87c8436392ee057d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335385 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#794655}
-
minch authored
Delete the useless test since we have home screen launcher and new designed shelf in tablet mode now. Bug: 838756 Change-Id: I9621ea11edfa15cfac89207ea935c6180c997240 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335031Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#794654}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/504a6f1944fe..97713d6f163e 2020-08-04 fawazm@google.com [WebAuthn] Capture use metric If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1034663 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4155a396e9c1b8b6e83bb9b1f62a315c0ffc1993 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336899Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794653}
-
Lucía Cantú-Miller authored
Chromedriver will now have the option to connect to Chrome through a pipe instead of a websocket. In this commit the PipeSetUp method is added to chrome_lancher to create the two pipes needed to communicate. Bug: chromedriver:3480 Change-Id: I7e3b70a7ef72b756a092b36d02dc3c091bfeb04f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336015 Commit-Queue: Lucía Cantú-Miller <cantumiller@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#794652}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 23 histograms that have been used to generate alerts in the past 90 days and do not already have a date later than or within 60 days of 2021-01-31. TBR=chromium-metrics-reviews@google.com Change-Id: I4b31022f574227500224575d96382aafd461a96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337013Reviewed-by:
Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Cr-Commit-Position: refs/heads/master@{#794651}
-
Alice Wang authored
This CL enables AccountPickerBottomSheetTest on the bot MM as the tests have been improved a lot since they were disabled last time. Ignore-CQ-Freeze: true Bug: 1093050 Change-Id: Iadb620fab1993f2f5275bde93f0364e72a26488d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333193 Auto-Submit: Alice Wang <aliceywang@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Reviewed-by:
Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#794650}
-
Jan Wilken Dörrie authored
This change adds the algorithms from [alg.nth.element] and the remaining algorithms from [alg.binary.search] to util::ranges. Bug: 1071094 Change-Id: Id5556ce982d5144e1f1aeaacfe5eb97a2abe73b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332195 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#794649}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3000d6b8c25c..21efb7c7ddbc 2020-08-04 michaelludwig@google.com Fix inversion unit test 2020-08-04 jlavrova@google.com Chromium Project Code Inclusion 2020-08-04 brianosman@google.com Revert "Revert "Revert "Put top level FPs into their own functions""" 2020-08-04 jvanverth@google.com Reland "Revise GrMtlGpu::onUpdateBackendTexture." 2020-08-04 borenet@google.com Revert "[recipes] Verify that we actually deleted the file/dir on android" 2020-08-04 michaelludwig@google.com Fix inversion tracking across simplifies in GrShape 2020-08-04 borenet@google.com [recipes] Verify that we actually deleted the file/dir on android If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: herb@google.com Change-Id: Ibfae48ea8ba0c4c25ec591741f5ce7bb563d06e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336898Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794648}
-
Sergey Ulanov authored
Replace with more inclusive terms per Chromium style guide. Change-Id: I96e2433b10f0ecb9a208b33ba9a3ddd2155a7a8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337093 Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#794647}
-
Justin DeWitt authored
Change-Id: I549a9ea085e420e4275dc6e4c50d6a38564882e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337095Reviewed-by:
Peter Williamson <petewil@chromium.org> Commit-Queue: Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#794646}
-
Xing Liu authored
Now we expose the initial time shown in the date time picker and read the previous scheduled start time and show them in the date time picker when the user press the change button in download home or info bar. Bug: 1110541 Change-Id: I7c562c6b3f3bcee0cb295d3b28b5830f82271b14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325075Reviewed-by:
Hesen Zhang <hesen@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#794645}
-
Sylvain Defresne authored
The settings UI needs to be dismissed when all the UI is teared down to allow the proper unregistration of observers (and other order dependent unregistration). This is because -dealloc is not called at a deterministic point in time (due to autorelease pool). Bug: 1111785 Change-Id: Ife4bb0ae9002cedb49017b2827f369db528360f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332822 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#794644}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d14d99cd75b8..7176f54720e6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I34d76da53041d27f486c51c6f97ce952f20470e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337073Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794643}
-
Chris Lu authored
Only iOS14 users will be able to configure their default browsers, so only show the NTP promo for those users. Bug: 1111499 Change-Id: Iba281a4c96482b1f45b5ee7986dbb02ed87eb93c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330732 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Auto-Submit: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#794642}
-
Jiawei Li authored
This reverts commit ffc6f22e. Reason for revert: key events cannot reach its target with this change. Particular app cannot adjust volume via button. Bug: Internal b/162242786 Test: manual on device Original change's description: > [chromecast] Enable element focus for WebContentController > > Focus did not work due to two distinct problems, both of which caused > page-level focus to be absent, which in turn meant that blink-level > focus was suppressed. > > - The aura::Window on which focus was attempted does not have an > OnWindowFocused observer. This change focuses the Window that does. > > - Wayland app's aura::Windows are not visible. This change adds a check > for an ancestor that is an exo window. > > Bug: b/156123509 > Test: manual on device > Change-Id: Ib4e8a5101bbc28d2b7a0448aff8142c8cffa2a76 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274201 > Reviewed-by: Daniele Castagna <dcastagna@chromium.org> > Reviewed-by: Daniel Nicoara <dnicoara@chromium.org> > Reviewed-by: Albert Chaulk <achaulk@chromium.org> > Commit-Queue: Kevin Schoedel <kpschoedel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#786469} TBR=achaulk@chromium.org,dnicoara@chromium.org,kpschoedel@chromium.org,dcastagna@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: b/156123509 Change-Id: Ifd988ad2469c2797d43e74c9194f2b28b7c31753 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335395 Commit-Queue: Jiawei Li <lijiawei@chromium.org> Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#794641}
-
Claude van der Merwe authored
CrosNetworkConfig::OnGetManagedProperties was running OnceCallback twice under certain circumstances (like forgetting a disconnected VPN network), causing chrome to crash. Added a return statement after the first time the OnceCallback is run. Bug: 1111431 Change-Id: Ib901bed15c2ec0923915f0963cc27563fb3162e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329924 Commit-Queue: Claude van der Merwe <cvandermerwe@google.com> Reviewed-by:
Jon Mann <jonmann@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#794640}
-
Robert Liao authored
BUG=1108460 Change-Id: I95b3e7b6832bbd56775cee959a6bc17f24ae99fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332688 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Auto-Submit: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#794639}
-
Weiliang Chen authored
SkiaRenderer no longer uses GLRendererCopier. Remove an interface that is only used by the SkiaRenderer. R=miu Bug: 1044594 Change-Id: I49c337f02504d79f7e639feee35782b50a5a4c26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321215 Commit-Queue: weiliangc <weiliangc@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#794638}
-
Daniel Rubery authored
Cookies are not needed for full hash lookups, so we can stop sending and saving them. This CL makes this change and adds a test that we don't save cookies. Bug: 1049833 Change-Id: Id32c3d4007ae7936da5ec7bbae543b819ae7bf63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122452 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#794637}
-
Anthony Vallee-Dubois authored
Bug: 1112795 Change-Id: I5b30f12e33573c9109d5ff2ea030f3651b74b134 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336280Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#794636}
-
chrome://managementTina Wang authored
Mock: https://docs.google.com/presentation/d/1Tbe2Uh3QTYUKOkxo89npxkthhvEwLgCz13f5xW4KRRw/edit#slide=id.g8cf6ed5ed7_4_220 Screenshot: https://screenshot.googleplex.com/z6vcmmk63ML Bug: 1111037 Change-Id: Iab795d0349561f9428e12e5fc0ecb7330ef1332b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329749Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Tina Wang <tinazwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#794635}
-