GitLab

The resulting JSON is equivalent, but now everything is smashed into one line.

This shaves 30% off the size of the NetLog dumps.

BUG=132160


Review URL: https://chromiumcodereview.appspot.com/12226132

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182207 0039d316-1c4b-4281-b951-d872f2087c98

Wait 30 secs before activating PowerSaveBlocker to dismiss small uploads.

BUG=173119


Review URL: https://chromiumcodereview.appspot.com/12226005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182206 0039d316-1c4b-4281-b951-d872f2087c98

Currently we are just coalescing scrollUpdates and we end up not utilizing
this when we have interleaved scrollUpdate and pinchUpdates. This change makes
that possible and makes sure the gesture_event_queue doesnt get flooded with
interleaved scroll and pinch updates.

BUG=174189


Review URL: https://chromiumcodereview.appspot.com/12225056

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182205 0039d316-1c4b-4281-b951-d872f2087c98

For current impl, Resource ID of a file is not updated for this sequence:
 (1) Add a file with resource_id_1
-- wait for synced --
 (2) Delete the file
 (3) Add a file with resource_id_2, and same content with the first file.

If the (2) and (3) come together, (2) is squashed into (3). And then (3) becomes nop since the content is not modified.

As the result, the metadata of the file has wrong Resource ID and all other change is ignored.

(notry, since most of try jobs are passed, and failed try looks not related to the patch)

BUG=175667
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/12223088

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182204 0039d316-1c4b-4281-b951-d872f2087c98

This patch changes "add language" overlay page in chrome://settings/language
from listed links to drop-down menu.

This patch only affects Chrome OS settings page.

BUG=133346
TEST=try bots

Review URL: https://chromiumcodereview.appspot.com/12087105

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182203 0039d316-1c4b-4281-b951-d872f2087c98

BUG=http://code.google.com/p/chromium/issues/detail?id=172102


Review URL: https://chromiumcodereview.appspot.com/12036096

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182202 0039d316-1c4b-4281-b951-d872f2087c98

Make sure on_asan_mac_host() always returns 1 on non-Darwin systems.

BUG=170629, 174873
TBR=thakis
Review URL: https://codereview.chromium.org/12256005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182201 0039d316-1c4b-4281-b951-d872f2087c98

> Added suppression for WebLayerTreeViewImpl::setShowDebugBorders().
> 
> TBR=zhaoqin
> BUG=175985
> 
> Review URL: https://codereview.chromium.org/12260007

TBR=atwilson@chromium.org
Review URL: https://codereview.chromium.org/12257006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182200 0039d316-1c4b-4281-b951-d872f2087c98

TBR=zhaoqin
BUG=175985

Review URL: https://codereview.chromium.org/12260007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182199 0039d316-1c4b-4281-b951-d872f2087c98

BUG=175657
TEST=Files.app harness launches without error.
TBR=mtomasz@chromium.org, haruki@chromium.org

Review URL: https://codereview.chromium.org/12258002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182198 0039d316-1c4b-4281-b951-d872f2087c98

Native Messaging API is useful only on desktop OSes, i.e. on Linux, OSX and 
Windows. Disable it in all other configurations. Also improved how we handle 
the case when native messaging is disabled is handled: now the app will get 
disconnect notification.

BUG=142915
TBR=thakis@chromium.org


Review URL: https://chromiumcodereview.appspot.com/12218099

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182197 0039d316-1c4b-4281-b951-d872f2087c98

Previously, it was easy to resize the nav, so the file list would disappear. We shouldn't let users break the ui.

TEST=Follow the bug's repro steps.
BUG=175958


Review URL: https://chromiumcodereview.appspot.com/12217164

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182196 0039d316-1c4b-4281-b951-d872f2087c98

BUG=152854


Review URL: https://chromiumcodereview.appspot.com/12217129

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182195 0039d316-1c4b-4281-b951-d872f2087c98

When a shell window was closed, it wasn't removed from the registry immediately
(it was removed in a callback from OnNativeClose, which happens a bit later.)
This meant that when the app was loaded again, the window was still in the
registry with a stale pointer to the old extension. ExtensionSettingsHandler
was tickling this by iterating shell windows on extension load.

BUG=174250


Review URL: https://chromiumcodereview.appspot.com/12210107

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182194 0039d316-1c4b-4281-b951-d872f2087c98

Also gradually deprecate FileUtilHelper since its code is no longer
used in the actual code path (used only in unittests).

Original review (with lgtm): https://codereview.chromium.org/12223006/

No changes made from the original review (the link error should be gone now by other gypi change that is already landed)

BUG=146215
TEST=content_unittests:LocalFileSystem*
TBR=jam, tzik, tbarzic (original reviewers)

Review URL: https://codereview.chromium.org/12209068

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182193 0039d316-1c4b-4281-b951-d872f2087c98

All the changes are in comment.

BUG=175657
TEST=none
TBR=mtomasz@chromium.org, haruki@chromium.org

Review URL: https://codereview.chromium.org/12262006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182192 0039d316-1c4b-4281-b951-d872f2087c98

Since this is just removal of unused code, I TBR James for the OWNER's review...

TBR=jhawkins@chromium.org
BUG=175850

Review URL: https://chromiumcodereview.appspot.com/12207138

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182191 0039d316-1c4b-4281-b951-d872f2087c98

This updates the CSS flexbox property names to their most recent
iterations, displays the entire footer in a flexbox to make the layout
more obvious, and rearranges the footer's right-side flexbox so that it
always has the same width.

The logo on the footer's left side is resized once when the page is
rendered to make it the same width as the right side.  This keeps the
nav dots centered in the footer.

BUG=


Review URL: https://chromiumcodereview.appspot.com/12038090

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182190 0039d316-1c4b-4281-b951-d872f2087c98

This patch includes:
- Adding proxy implementation (DircetoryReaderResource and PepperDirectoryReaderHost)
- Merging PPB_DirectoryReader_impl into PepperDirectoryReaderHost

BUG=106129
TEST=browser_tests --gtest_filter=\*DirectoryReader\*


Review URL: https://chromiumcodereview.appspot.com/11958033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182189 0039d316-1c4b-4281-b951-d872f2087c98

BUG=6295515


Review URL: https://chromiumcodereview.appspot.com/11280284

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182188 0039d316-1c4b-4281-b951-d872f2087c98

This is a resubmit of https://codereview.chromium.org/12041059

BUG=175308, 170921

Review URL: https://codereview.chromium.org/12249003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182187 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182181 0039d316-1c4b-4281-b951-d872f2087c98

The launcher install is now done by the webstore, so this code is no longer
needed.

BUG=None


Review URL: https://chromiumcodereview.appspot.com/12208146

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182179 0039d316-1c4b-4281-b951-d872f2087c98

Introducing chrome::GetTotalBrowserCount() in browser_finder.cc which counts browsers across all desktops and profiles (this is the desired count for most BrowserList::empty() and BrowserList::size() consumers).

Otherwise calling a specific BrowserListImpl's size() when appropriate.

BUG=129187


Review URL: https://chromiumcodereview.appspot.com/12212120

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182178 0039d316-1c4b-4281-b951-d872f2087c98

Renamed  --is-asan-mac-builder to --is-asan-mac-builder-hackfix per Nico's suggestion.
Added more comments.

BUG=170629, 174873
TBR=thakis
Review URL: https://codereview.chromium.org/12255003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182175 0039d316-1c4b-4281-b951-d872f2087c98

This causes a PRECONDITION error when two clients try to delete duplicated files.
The conflict is ignorable on this case, so we can just drop the etag matching. 

(notry, since most of try jobs are passed, and failed try looks not related to the patch)

BUG=175682
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/12209115

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182174 0039d316-1c4b-4281-b951-d872f2087c98

It turns out that r181918, which pinned the Clang revision on Mac ASan
bots worked a little too well, pinning the version on *all* Mac bots.

This reverts the Clang roll. We will then fix update.sh to get the Mac
ASan pinning correct, and then re-land the roll.

BUG=174873, 170629

Review URL: https://codereview.chromium.org/12256002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182173 0039d316-1c4b-4281-b951-d872f2087c98

The shortcut code on mac can only handle v2 apps, so we keep the menu item
hidden there.

BUG=175691
R=estade@chromium.org


Review URL: https://chromiumcodereview.appspot.com/12223120

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182172 0039d316-1c4b-4281-b951-d872f2087c98

Android browser compositor does not have access directly to the
LayerTreeHost, only the compositor. This CL allows to set the
device scale factor from the compositor interface.

BUG=175589


Review URL: https://chromiumcodereview.appspot.com/12220110

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182171 0039d316-1c4b-4281-b951-d872f2087c98

Clean up some manifest unit tests.

BUG=159265
TBR=sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/12042096

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182170 0039d316-1c4b-4281-b951-d872f2087c98

BUG=166797
TEST=run_py_tests.py testSwitchToFrame


Review URL: https://chromiumcodereview.appspot.com/12217149

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182169 0039d316-1c4b-4281-b951-d872f2087c98

This CL fixes some typos, broken links and other small issues in extension docs. 

Thanks for Sunny Jerry (ratsunny@gmail.com). Some of these mistakes were discovered by him and listed at https://code.google.com/p/chrome-documentation-chs/source/browse/documentation/error_list.txt .

BUG=173630,168952,119535,167355
TEST=none

Review URL: https://chromiumcodereview.appspot.com/12223068

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182168 0039d316-1c4b-4281-b951-d872f2087c98

In logging.h, the NOTIMPLEMENTED_POLICY macro defines the behavior of the NOTIMPLEMENTED() macro.  For case 5 (log only once per call-site), code that uses stream output operators would fail to compile.  For example, in ui/aura/root_window_host_linux.cc:747:

  NOTIMPLEMENTED() << "Unsupported bits-per-pixel " << image->bits_per_pixel;

The solution is to add EAT_STREAM_PARAMETERS to the end of the definition in base/logging.h.  This will log call sites as "not implemented" but will not log the additional custom messages.

TEST=Compiled chrome with compiler define set to NOTIMPLEMENTED_POLICY=5 and ran to confirm desired NOTIMPLEMENTED() behaviors.


Review URL: https://chromiumcodereview.appspot.com/12221152

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182167 0039d316-1c4b-4281-b951-d872f2087c98

1. Add a border bar to the top of the footer button area.
2. Change the inset size of the footer and scroll_content. The existing
   code scrolls the contents right after the button content, but a
   buffer is necessary.


Review URL: https://chromiumcodereview.appspot.com/12221126

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182166 0039d316-1c4b-4281-b951-d872f2087c98

With the new full page NTP the detached bookmark bar was no longer visible.

The problem was that we relied on an instance of NewTabUI to control the bookmark bar visibility. The new full page NTP no longer has an instance of NewTabUI so the bookmark bar was never visible.

Fix was to move the relevant code out of NewTabUI and into BookmarkTabHelper.

BUG=175146
TEST=Ran with instant extended enabled. Verified that the detached bookmark bar was visible.
Added a new test BookmarkInstantExtendedBrowsertest.DetachedBookmarkBar. Verified that the test fails without my patch and passes with it.

Review URL: https://chromiumcodereview.appspot.com/12217127

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182165 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
Review URL: https://codereview.chromium.org/12221167

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182164 0039d316-1c4b-4281-b951-d872f2087c98

BUG=155269

Review URL: https://chromiumcodereview.appspot.com/12220123

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182163 0039d316-1c4b-4281-b951-d872f2087c98

When I added the resource provider fence concept, I didn't
extend the read-fence long enough (it currently only protects
the current frame). This extends the read-lock for one frame.

BUG=172995

Review URL: https://chromiumcodereview.appspot.com/12220095

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182162 0039d316-1c4b-4281-b951-d872f2087c98

ShutdownAndBlock function can be called multiple times safely.
So checking |shutdown_completed_| in OnDisonnected function is not necessary.

BUG=174431
TEST=Checked no crash at sing out.


Review URL: https://chromiumcodereview.appspot.com/12212133

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182161 0039d316-1c4b-4281-b951-d872f2087c98

BUG=174924
TEST=on lumpy, launch the settings page, and confirm the setting is hidden.

R=nona@chromium.org
TBR=nkostylev@chromium.org
# TBR for just inverting the flag...

Review URL: https://chromiumcodereview.appspot.com/12207143

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182160 0039d316-1c4b-4281-b951-d872f2087c98