- 28 Apr, 2017 40 commits
-
-
Daniel Cheng authored
Like the WTF::String change, this leaves the the Find() overload that takes a StringView, start offset, and a case sensitivity option for a followup CL. Bug: 709815 Change-Id: I8f98fe0b41eb99a525ca608690c8ae0bdcebf6a6 Reviewed-on: https://chromium-review.googlesource.com/489368Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#467872}
-
jinsukkim authored
Native layer is already calculating some frame info about top control (position + update flag). This CL passes the values to Java layer so that it won't repeat those operations again. Review-Url: https://codereview.chromium.org/2841033002 Cr-Commit-Position: refs/heads/master@{#467871}
-
aelias authored
Revert of Only do Smart Select if one word is selected. (patchset #4 id:60001 of https://codereview.chromium.org/2838023002/ ) Reason for revert: Null pointer crash http://crbug.com/715526 BUG=715526 Original issue's description: > Only do Smart Select if one word is selected. > > There is a bug where after "Select All" Smart Select will suggest a different > (smaller) selection. This CL checks if the selection only has one word. Since > longpress/double tap only selects one word, if we have multiple words we can assume > it comes from "Select All" and not do Smart Select. > > BUG=714106 > > Review-Url: https://codereview.chromium.org/2838023002 > Cr-Commit-Position: refs/heads/master@{#466856} > Committed: https://chromium.googlesource.com/chromium/src/+/03f5058e764e8b2b01d571f29426075a83f6049b TBR=timav@chromium.org,amaralp@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=714106 Review-Url: https://codereview.chromium.org/2848793002 Cr-Commit-Position: refs/heads/master@{#467870}
-
wangjimmy authored
Indicates whether an error has been encountered by the interface endpoint client. If true, method calls made on this interface will be dropped (and may already have been dropped). BUG=695635 Review-Url: https://codereview.chromium.org/2840333002 Cr-Commit-Position: refs/heads/master@{#467869}
-
luoe authored
When logging a URL with a port number in the console, 'http://localhost:8000', our linkifier incorrectly treats the '8000' port number as a line number. Using our existing granular URL regexes, this patch makes the linkifier ignore the URL part before the 'path' when looking for a line/column number. BUG=701865 Review-Url: https://codereview.chromium.org/2843073003 Cr-Commit-Position: refs/heads/master@{#467868}
-
mmoss authored
I think this used to be built by the old Windows official builders, but I have no idea if it was ever even used, and AFAICT, it hasn't ever been built by the current (PGO) builders, and hasn't been missed. It seems we don't really need it (especially not for the official continuous builders, which appear to be the only ones that currently build the "chrome_official_builder" target). R=dimu@google.com, dpranke@google.com Review-Url: https://codereview.chromium.org/2846963002 Cr-Commit-Position: refs/heads/master@{#467867}
-
hiroshige authored
This enables module scripts in Blink behind a flag. This CL implements module-script-related steps of "prepare a script" in ScriptLoader and thus makes the module implementation code paths that are committed previously to be executed, if the runtime flag is enabled. This CL also reorganizes the test expectations for module-related tests. BUG=594639 Review-Url: https://codereview.chromium.org/2781713003 Cr-Commit-Position: refs/heads/master@{#467866}
-
khorimoto authored
This property is necessary because the networking stack must show a dialog to users the first time they connect to a given host device which alerts the user that tethering will use mobile data and battery. This change adds the new property to the networkingPrivate IDL file and pipes it through from NetworkState. Currently, the value is hard-coded to "false", but this value will be propagated through the network stack from the Tether component in a follow-up CL. BUG=672263 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2844363003 Cr-Commit-Position: refs/heads/master@{#467865}
-
csashi authored
accepted previous save card prompt. BUG=715617 Review-Url: https://codereview.chromium.org/2839683002 Cr-Commit-Position: refs/heads/master@{#467864}
-
chrome-release-bot authored
Cr-Commit-Position: refs/heads/master@{#467863}
-
juliatuttle authored
I'm going to build a general persistence mechanism for //net instead of tediously plumbing out to the profile's prefs (which gets really messy with isolated app contexts and such), so I'm removing the old persistence stuff until that's done. BUG=704259 Review-Url: https://codereview.chromium.org/2835923005 Cr-Commit-Position: refs/heads/master@{#467862}
-
sque authored
This field represents the CPU temperature at each thermal zone in degrees Celsius. BUG=chromium:709102 Review-Url: https://codereview.chromium.org/2802593005 Cr-Commit-Position: refs/heads/master@{#467861}
-
tengs authored
This CL also changes UnlockManager to use the new interface for ProximityMonitor. Review-Url: https://codereview.chromium.org/2845433003 Cr-Commit-Position: refs/heads/master@{#467860}
-
mthiesse authored
BUG=715674 Review-Url: https://codereview.chromium.org/2840353002 Cr-Commit-Position: refs/heads/master@{#467859}
-
alito authored
This is the next iteration of the modal dialog based on UX team's latest proposal. Strings are still not finalized. BUG=690020 Review-Url: https://codereview.chromium.org/2847643002 Cr-Commit-Position: refs/heads/master@{#467858}
-
dspaid authored
Add a metric to track the type of encryption used by chromeos user homedirectories. This histogram is added in chromeos at https://chromium-review.googlesource.com/c/486439/ BUG=714926 TEST=./validate_format.py && ./pretty_print.py Review-Url: https://codereview.chromium.org/2842723002 Cr-Commit-Position: refs/heads/master@{#467857}
-
dpapad authored
BUG=715906 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2846103003 Cr-Commit-Position: refs/heads/master@{#467856}
-
skobes authored
For everything else we should rely on SAC::DidRequestShowFromMainThread. Additionally, ensure that show-from-main requests are processed in synchronous compositing mode (which commits directly to the active tree). BUG=606395 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2842553003 Cr-Commit-Position: refs/heads/master@{#467855}
-
rob.buis authored
Implement request id in PaymentDetailsInit as well as id getter in PaymentRequest. In order for this functionality to make sense we pass the id to the payment app and make sure to set it in the PaymentResponse through the requestId attribute. Added PaymentRequestIdTest as a payment integration test for verifying the PaymentResponse contains the free-form identifier specified in PaymentDetailsInit. Added PaymentRequestTest.DetailsIdIsSet unit test to verify that PaymentDetailsInit.id is reflected in PaymentRequest.id. Added external/wpt/payment-request/payment-request-id.https.html to test that PaymentDetailsInit.id is reflected in PaymentRequest.id and that not providing an id generates a UUID. Added manual test external/wpt/payment-request/payment-request-response-id.html for verifying the PaymentResponse contains the free-form identifier specified in PaymentDetailsInit. Intent to Implement and Ship thread: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/WaHAg3wh7jw/vWAqxSnOCgAJ BUG=701254 TEST=PaymentRequestIdTest, DetailsIdIsSet Review-Url: https://codereview.chromium.org/2770193003 Cr-Commit-Position: refs/heads/master@{#467854}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/770ad6af2778..9c9ac13a2b02 $ git log 770ad6af2..9c9ac13a2 --date=short --no-merges --format='%ad %ae %s' 2017-04-27 nednguyen [Telemetry] Enable more useful error stack for native crash with faulthandler tool Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I61cb05f2da5d607d6d4d98e2e1a275147a8e984d Reviewed-on: https://chromium-review.googlesource.com/489435 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#467853}
-
findit-for-me authored
Revert of Roll googletest to 1.8.0. (patchset #7 id:340001 of https://codereview.chromium.org/2779193002/ ) Reason for revert: Findit(https://goo.gl/kROfz5) identified CL at revision 467833 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2I1MzlmYTExMjNhMTllNjQ5OWY1ODU4MmRhNTVjYTVhZjlkZjk0YTQM Original issue's description: > Roll googletest to 1.8.0. > > GoogleTest (gtest) and GoogleMock (gmock) are now hosted into the same > googletest repository. In order to cope with this, the googletest > repository is now sourced at third_party/googletest. > > The file/directory layout of Google Test is not yet considered stable. > To minimize disruption while Google Test stabilizes, Chromium code will > be insulated from third_party/googletest. > > * testing/gtest/include/gtest/ and testing/gmock/include/gmock have > been populated with headers that forward into the appropriate locations of > third_party/googletest > > * testing/BUILD.gn has been populated with the targets > //testing/gtest(:gtest_main) and //testing/gmock(:gmock_main), which > depend on the appropriate //third_party/googletest targets. > > All Chromium code should keep depending on the targets and headers > in testing/{gtest,gmock} for now. > > BUG=630705 > TBR=rkc > > Review-Url: https://codereview.chromium.org/2779193002 > Cr-Commit-Position: refs/heads/master@{#467833} > Committed: https://chromium.googlesource.com/chromium/src/+/b539fa1123a19e6499f58582da55ca5af9df94a4 TBR=thakis@chromium.org,dpranke@chromium.org,agl@chromium.org,rkc@chromium.org,skobes@chromium.org,pwnall@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=630705 Review-Url: https://codereview.chromium.org/2847043002 Cr-Commit-Position: refs/heads/master@{#467852}
-
Tommy Nyquist authored
This CL adds support for invoking a callback when the underlying model has finished loading. In addition, it exposes the restul of the initialization as a boolean method. The result of the initialization is always posted back, even if the result is already known. The CL implements both the C++ and the Java bridge implementation of this. BUG=706309 Change-Id: I09310d658ed0d0b9a9ef78dfd401d3ef49dd339e Reviewed-on: https://chromium-review.googlesource.com/486969 Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#467851}
-
afakhry authored
Basically, it is desired to see how many feedbacks are filed from the sad tab page relative to other sources. BUG=715682 Review-Url: https://codereview.chromium.org/2844193002 Cr-Commit-Position: refs/heads/master@{#467850}
-
warx authored
Changes: Add a window property for set/get whether an aura window is considered activatable for pointer window activation. Modify CanFocusWindow in FocusRules to allow optional check for ui::Event. This is a stage one implementation for crbug.com/657525. BUG=657525 TEST=added test coverage Review-Url: https://codereview.chromium.org/2809073002 Cr-Commit-Position: refs/heads/master@{#467849}
-
kapishnikov authored
Related CLs: https://codereview.chromium.org/2842333002/ https://codereview.chromium.org/2843223002/ BUG=712738 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2843293002 Cr-Commit-Position: refs/heads/master@{#467848}
-
dspaid authored
Cryptohome.DircryptoMigrationEndStatus histogram should use the DircryptoMigrationEndStatus, not DircryptoMigrationStartStatus. BUG=715870 TEST=./validate_format.py && ./pretty_print.py Review-Url: https://codereview.chromium.org/2848463002 Cr-Commit-Position: refs/heads/master@{#467847}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/227fee38..71c1795a Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2852523002 Cr-Commit-Position: refs/heads/master@{#467846}
-
danakj authored
When it will only be used for a single frame, there is no need to fallback for complex frames. This restores behaviour for CSSPaint module to before https://codereview.chromium.org/2833593002/. R=ikilpatrick@chromium.org, pdr@chromium.org TBR=senorblanco BUG=671433 Review-Url: https://codereview.chromium.org/2840093002 Cr-Commit-Position: refs/heads/master@{#467845}
-
zijiehe authored
ProcessStatsStub is an interface to receive process resource usage information from a ProcessStats. ProcessResourceUsage is a structure to store the resource usage of one process. AggregatedProcessResourceUsage is a structure to store the resource usgaes of several processes. ProcessStatsAgent is an interface to retrieve resource usage of one process. CurrentProcessStatsAgent is a ProcessStatsAgent implementation to retrieve resource usage from current process. ForwardProcessStatsAgent receives resource usage from a third-party and forwards the latest usage as a ProcessStatsAgent. ProcessStatsSender is a class to regularly report resource usages from various ProcessStatsAgent implementations to a ProcessStatsStub. It merges several non-empty ProcessResourceUsage into one AggregatedProcessResourceUsage. This is typical useful on Windows: we need to calculate the resource usages from both network process and desktop process. R=sergeyu@chromium.org, jamiewalch@chromium.org BUG=650926 Review-Url: https://codereview.chromium.org/2775983003 Cr-Original-Commit-Position: refs/heads/master@{#467753} Committed: https://chromium.googlesource.com/chromium/src/+/5928f440f84065ab45f848dcd135e3c2f52ca5bb Review-Url: https://codereview.chromium.org/2775983003 Cr-Commit-Position: refs/heads/master@{#467844}
-
hanxi authored
This CL hides the "Site setting" action when notifications are shown by WebAPKs. The "additional settings in the app" link will be removed from the notification settings for WebAPKs in the System UI in Android O. Before Android O, the settings gear to open app-specific settings shown on the rear of a notification following a long-press will be gone as well. BUG=654539 Review-Url: https://codereview.chromium.org/2826223002 Cr-Commit-Position: refs/heads/master@{#467843}
-
thakis authored
BUG=661774 Review-Url: https://codereview.chromium.org/2843333004 Cr-Commit-Position: refs/heads/master@{#467842}
-
xlai authored
https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/40d75ac..f7157c2 BUG=696223,715696 TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2844703002 Cr-Commit-Position: refs/heads/master@{#467841}
-
tetsui authored
URLsToEntriesWithAccess is heavy operation especially on slow storage devices such as MTP connected ones. Previously, progress center was updated only after URLsToEntriesWithAccess was finished. As a result, it took more than 30 seconds for a user to receive feedback in some cases. BUG=712547 TEST=manually tested. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2846763002 Cr-Commit-Position: refs/heads/master@{#467840}
-
mmenke authored
from content, chrome, and net/. URLRequestJob itself now has a default implementation, which gets the response code from the headers returned by GetResponseInfo. We eventually want to remove this method, since it's redundant, and has weird behavior for just when it is and is not safe to call. BUG=688481 Review-Url: https://codereview.chromium.org/2835533002 Cr-Commit-Position: refs/heads/master@{#467839}
-
sergeyu authored
WebRTC creates threads internally. Thread::Stop() is a blocking operation, so it's not allowed on the network thread. To work around this problem WebrtcTransport::PeerConnectionWrapper uses ScopedAllowIO when closing PeerConnection. But it's not longer enough - some threads are stopped later when the factory is destroyed. Updated PeerConnectionWrapper destructor to destroy the PeerConnectionFactory with ScopedAllowIO. BUG=714699 Review-Url: https://codereview.chromium.org/2847803003 Cr-Commit-Position: refs/heads/master@{#467838}
-
ltian authored
Add a transparent Activity in Chrome to handle the Browser Action Intent. This CL also deals with parsing the information of Browser Action request from the Intent. Later, this Activity will open a context menu from Chrome with the request information. BUG=706696 Review-Url: https://codereview.chromium.org/2786283002 Cr-Commit-Position: refs/heads/master@{#467837}
-
dmurph authored
Since blobs can die during transit (pending mojo change), we can prevent this by holding onto the blob handles in the IDBRequest until we get the response back from the browser. R=pwnall,jsbell BUG=351753,710736,713409 Review-Url: https://codereview.chromium.org/2828953002 Cr-Commit-Position: refs/heads/master@{#467836}
-
twellington authored
There's a report of a crash when trying to disable the fading background view during ChromeHomeNewTabPage creation. This change adds a null check and retrieves the fading background view from the activity each time it is neeed rather than caching. BUG=716015 Review-Url: https://codereview.chromium.org/2850623003 Cr-Commit-Position: refs/heads/master@{#467835}
-
hzl authored
Previously when test results presentation does not receive any json input file, the script will raise a parser error. This is confusing to developer, because they may mistake the parser error in this script as the cause of the crash, instead of the reason why no json input file is given at the first place. In this cl, test results presentation will not raise error anymore when no json file is given. BUG=715972 Review-Url: https://codereview.chromium.org/2845973004 Cr-Commit-Position: refs/heads/master@{#467834}
-
pwnall authored
GoogleTest (gtest) and GoogleMock (gmock) are now hosted into the same googletest repository. In order to cope with this, the googletest repository is now sourced at third_party/googletest. The file/directory layout of Google Test is not yet considered stable. To minimize disruption while Google Test stabilizes, Chromium code will be insulated from third_party/googletest. * testing/gtest/include/gtest/ and testing/gmock/include/gmock have been populated with headers that forward into the appropriate locations of third_party/googletest * testing/BUILD.gn has been populated with the targets //testing/gtest(:gtest_main) and //testing/gmock(:gmock_main), which depend on the appropriate //third_party/googletest targets. All Chromium code should keep depending on the targets and headers in testing/{gtest,gmock} for now. BUG=630705 TBR=rkc Review-Url: https://codereview.chromium.org/2779193002 Cr-Commit-Position: refs/heads/master@{#467833}
-