- 15 Oct, 2018 25 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/681692726fc0..646d917d3c71 git log 681692726fc0..646d917d3c71 --date=short --no-merges --format='%ad %ae %s' 2018-10-15 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-10-15 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@646d917d3c71 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=egdaniel@chromium.org Change-Id: I411ca0c376ef6d52873afc59dc2a5457452da816 Reviewed-on: https://chromium-review.googlesource.com/c/1280102Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#599571}
-
Hiroshi Ichikawa authored
Looks like the macro is deprecated per the comment at the bottom of the file. Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: If7763f67d427d03c150ec10b28a3d570ceef0f67 Reviewed-on: https://chromium-review.googlesource.com/c/1272758Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#599570}
-
Takashi Sakamoto authored
BUG=888904 Change-Id: I82f7cc310b32a18df79dd46756d685aee03f0276 Reviewed-on: https://chromium-review.googlesource.com/c/1272935Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#599569}
-
Naoki Fukino authored
We have been showing the notification after successful ext4 migration. This notification is getting less useful since most users have already migrated to ext4, and we hear several feedback reports that the notification was shown at unexpected timing. Let's remove the notification as a simple fix and a clean-up. (Removing the notification was approved by PM.) Bug: 894707 Test: Manually confirmed that the notification was not shown after migration on Kevin. Change-Id: Ide3237a57a127974eed6f1619fc5e096f911f72a Reviewed-on: https://chromium-review.googlesource.com/c/1278666 Commit-Queue: Naoki Fukino <fukino@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#599568}
-
Anand K. Mistry authored
BUILD.gn rules already exclude the zip_archiver from being built and packaged if NaCl is disabled. BUG=841518 Change-Id: Ib4f1a7e204c91fd17fb3c9edb6b5618075ef9f9c Reviewed-on: https://chromium-review.googlesource.com/c/1279176Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#599567}
-
Noel Gordon authored
Convert this test to a testharness test. With CL:823582 this test does not crash, and does crash prior to that change. Note: this test uses shadomDOM V0 registerElement and createShadowRoot since the crash does not reproduce when using shadowDOM V1 methods. Bug: 789094, 804047 Change-Id: Ia65c2f75b805ed99a7401d5b64110601f917a5d7 Reviewed-on: https://chromium-review.googlesource.com/c/1278456Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#599566}
-
Takashi Sakamoto authored
BUG=888904 Change-Id: I65002e69cc3dba6acb061bcc4853d10ede1cbe68 Reviewed-on: https://chromium-review.googlesource.com/c/1272958Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#599565}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/dd78844442fe..76988a8c5288 git log dd78844442fe..76988a8c5288 --date=short --no-merges --format='%ad %ae %s' 2018-10-15 tandrii@chromium.org git cl: compute reviewers and ccs before pushing change to Gerrit. Created with: gclient setdep -r src/third_party/depot_tools@76988a8c5288 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:877717 TBR=agable@chromium.org Change-Id: Ia5c90f260a9239b90bd2f366c0bdd0c66eabfc53 Reviewed-on: https://chromium-review.googlesource.com/c/1279283Reviewed-by:
-
Fergal Daly authored
This is the agreed name for this attribute. Bug: 805271 Change-Id: I806c8933d90e98d2e132b7b260f8544563b1f94d Reviewed-on: https://chromium-review.googlesource.com/c/1278620Reviewed-by:
Fergal Daly <fergal@chromium.org> Reviewed-by:
-
Rakina Zata Amni authored
In some cases such as multiple frame webpages, idle task might never execute or take a noticably long time to execute. This might lead to incorrect number of find-in-page result and not highlighting matches because the scoping is never trigerred. This CL adds a deadline to scoping idle tasks to ensure all scoping happens in a timely manner. Bug: 890622,893465 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I8ec998d4c2f42377361c1f7b95c1497a80368ef6 Reviewed-on: https://chromium-review.googlesource.com/c/1270196 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#599562}
-
Darren Shen authored
When we enter window overview mode (e.g. by dragging the top of an app), we need to hide the virtual keyboard because: 1) It blocks the overview mode UI for no reason. 2) The previews of windows have blank space at the bottom because that's where the keyboard is. Bug: 893856 Change-Id: I4f79f6bf603fd074a62b7ba29366ec5af18bbab2 Reviewed-on: https://chromium-review.googlesource.com/c/1278565 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#599561}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/697d4bdafa2b..2b20c6f0282d Created with: gclient setdep -r src-internal@2b20c6f0282d The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ib00679b4c903bd02023cbd5fbe3be9b14f6f7fc9 Reviewed-on: https://chromium-review.googlesource.com/c/1279281Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#599560}
-
David Staessens authored
This change removes the "Mesa Gallium driver" from the blacklist in the vaapi JPEG decoder. TEST=ran VDA tests on Grunt Bug: 828119 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I1100cbebcc7f2a2eca3c6109fa120db764543a95 Reviewed-on: https://chromium-review.googlesource.com/c/1256462 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#599559}
-
Renee Wright authored
Bug: 894665 Change-Id: Ie894955b7f5095c19135385437392d8c12dc3223 Reviewed-on: https://chromium-review.googlesource.com/c/1278428 Commit-Queue: Renée Wright <rjwright@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I67abe9bb58b68b07a46a61a2850fe08329656d1c Reviewed-on: https://chromium-review.googlesource.com/c/1280049Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#599557}
-
Patti authored
This reverts commit 2bd206ee. Reason for revert: This patch may be the culprit behind cc_unittest TreeSynchronizerTest.SynchronizeScrollTreeScrollOffsetMap failing on Linux ChromiumOS MSan Tests [20 out of the last 20 builds have failed] and Linux MSan Tests [21 out of the last 21 builds have failed]. Reverting to try and fix. Original change's description: > BrowserControlsState updates CC and commits to Blink > > The linked bug is a result of the fact that we send and handle browser > controls state updates on both the main and compositor threads. When a > non-animated hide is followed by a animated hide, we start an animation > on the compositor thread but immediately hide the top controls on the > main thread. When we commit the browser controls delta, the controls > hide but the animation continues to play so the next frame re-shows the > controls. Additional updates may stop the animation so we'd see the > controls in a half-way hidden state. > > Currently, UpdateBrowserControlsState sends animated commands to be > handled by CC (since Blink doesn't know how to animate), but because of > https://crbug.com/754346, non-animated commands are sent to Blink. When > the browser process sends a series of interweaved commands to the render > this leads the the clamping bug discussed above. > > This CL fixes this issue by making the compositor-side the real source- > of-truth and pushing the changes to Blink. Both CC and Blink must be > made aware of the browser controls constraints, since scrolls may be > handled by either. However, we now always inform CC first and let it > push the differences to Blink. This happens as part of > ApplyViewportChanges during a commit. > > Bug: 861618 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I6cb6a6480804fff05e6aee65166bf0d303fb677d > Reviewed-on: https://chromium-review.googlesource.com/c/1205797 > Reviewed-by: Chris Harrelson <chrishtr@chromium.org> > Reviewed-by: enne <enne@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Commit-Queue: David Bokan <bokan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#599523} TBR=bokan@chromium.org,chrishtr@chromium.org,enne@chromium.org,alexmos@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 861618 Change-Id: I6738ee1fb616e2b06b5a466546a8f47bcaeb7d79 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/c/1278460Reviewed-by:
Patti <patricialor@chromium.org> Commit-Queue: Patti <patricialor@chromium.org> Cr-Commit-Position: refs/heads/master@{#599556}
-
Victor Vasiliev authored
This was temporary measure to debug the source of internal errors, and it was never ported into google3 copy of QUIC. R=rch@chromium.org Change-Id: I1b1d94d21b3a8dbb4f8ff1cd276bd801126d64bd Reviewed-on: https://chromium-review.googlesource.com/c/1277929Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Cr-Commit-Position: refs/heads/master@{#599555}
-
John Z Wu authored
This is necessary to receive updates from the sync server. Bug: 867548 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I72d0f260d376a16337ddeb1c7a94e7a45508c04a Reviewed-on: https://chromium-review.googlesource.com/c/1277984Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#599554}
-
Xianzhu Wang authored
The original functions dumpChildFrameScrollPositions(), dumpChildFramesAsText() and dumpChildFramesAsMarkup() did almost the same thing while each had its own applicable condition. Combine them to simplify API and prevent wrong usages. This is a pre-cleanup of making pixel tests not dump text by default (https://chromium-review.googlesource.com/c/chromium/src/+/1277654). Bug: 703899 Change-Id: I41adff013a512e6e247b3c12080a71dd3a8ac99f Reviewed-on: https://chromium-review.googlesource.com/c/1278057 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#599553}
-
Patti authored
This reverts commit 3acd2385. Reason for revert: This patch may be the culprit behind consistent failures in three bots - win-asan [23 out of the last 23 builds have failed], Win 7 Tests x64 (1) [48 out of the last 48 builds have failed], and Win7 Tests (1) [45 out of the last 45 builds have failed]. Reverting to try and fix. Original change's description: > Removes EnableSurfaceLayerForVideoMS flag. > > Because the conditions in which we turn on surfaces for videos have grown > more complicated, and because surfaces for MS (MediaStream) has pretty much been implemented, > it has been decided that special-casing MS videos was no longer required. > > Bug: 746182 > Change-Id: Ie79c56ba80707c9b3e102eba9bcc712e994065b2 > Reviewed-on: https://chromium-review.googlesource.com/c/1250095 > Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> > Reviewed-by: Chris Harrelson <chrishtr@chromium.org> > Reviewed-by: Emircan Uysaler <emircan@chromium.org> > Reviewed-by: Fady Samuel <fsamuel@chromium.org> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Reviewed-by: Frank Liberato <liberato@chromium.org> > Cr-Commit-Position: refs/heads/master@{#599492} TBR=beaufort.francois@gmail.com,chrishtr@chromium.org,fsamuel@chromium.org,mlamouri@chromium.org,emircan@chromium.org,liberato@chromium.org,lethalantidote@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 746182 Change-Id: I251dae1ff54c43d16e91108a741507a33523a475 Reviewed-on: https://chromium-review.googlesource.com/c/1277800Reviewed-by:
-
Kent Tamura authored
compactTestOutput() passed a wrong object to resultLine() for unmerged tests. Change-Id: I78df2252b8168c67cc0dbdcccac8fbc10774fd6f Reviewed-on: https://chromium-review.googlesource.com/c/1278427Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#599551}
-
Rouslan Solomakhin authored
Before this patch, launching a Payment Handler CCT would show a black patch on device bottom keys. The keys were still there, but the foreground and background were the same color. This happened only on Oreo and Pie. Nougat and earlier versions continued to work OK. This patch disables windowLightNavigationBar in the style of the DimmingDialog, which dims the background behind the Payment Handler CCT. This property is available in API versions 28 and higher. After this patch, launching a Payment Handler CCT shows the navbar buttons. Bug: 890183 Change-Id: I42126f434f928f80355c849c3a2fd3d1e6e85b13 Reviewed-on: https://chromium-review.googlesource.com/c/1259364Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#599550}
-
Sam McNally authored
This is a reland of https://crrev.com/c/1277133, omitting touching the test removed in https://crrev.com/c/1278063. Bug: 891197 Change-Id: Icfd030e958686d7d0bcdc74cb07962eb1409b784 Tbr: noel@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1278618Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#599549}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/16d54c785eba..697d4bdafa2b Created with: gclient setdep -r src-internal@697d4bdafa2b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I12369a7f2282826f0cc98b0943254591d3169a09 Reviewed-on: https://chromium-review.googlesource.com/c/1279979Reviewed-by:
-
Tommy Steimel authored
This CL removes the code that dynamically sets the overlay play button size based on the video size. Instead, this just sets the button at 72px by 72px. This solves *most* cases of a bug where the loading spinner was slightly off-center on certain sizes. Bug: 894866, 877113 Change-Id: I96ccda8921ffddddf009fa0b7ee28907201a966f Reviewed-on: https://chromium-review.googlesource.com/c/1278860Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#599547}
-
- 14 Oct, 2018 15 commits
-
-
Marcin Wiacek authored
1. for these @IntDef, which are indexing tables - adding info, which tables should be updated after updating @IntDef value (change after https://crbug.com/616321) + removing info about dynamically created tables (which don't have to be updated). 2. making @IntDef comments more consistent. 3. adding few JavaDoc links. 4. replacing Int[] and String[] mappings with switch All changes are helping in ensuring that all updates for @IntDef will be done in this way, that mappings will not be broken and values will correctly filled. 5. making CONTENT_TYPES private inside PermissionInfo and ContentSettingException. Good practice for making tables immutable. Change-Id: I313ed930e74fd1b7dd48ed7ec47ac2f42f8ca6f3 Reviewed-on: https://chromium-review.googlesource.com/c/1262797Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Cr-Commit-Position: refs/heads/master@{#599546}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I779e4d8dd28999f714a703e6734c2a407be4acf0 Reviewed-on: https://chromium-review.googlesource.com/c/1279978Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6c21aec541cd..16d54c785eba Created with: gclient setdep -r src-internal@16d54c785eba The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I71d4cb21844e112af9f153295f1b4f90e28fb6f3 Reviewed-on: https://chromium-review.googlesource.com/c/1279977Reviewed-by:
-
Michael Lippautz authored
This is a reland of 7f08809a Original change's description: > [gin] Allow posting non-nestable tasks through V8 > > Will be used to allow V8 posting top-level tasks. > > Bug: chromium:843903 > Change-Id: I97caa705b561fa8832ef8a11abfc3eefe47ec3f8 > Reviewed-on: https://chromium-review.googlesource.com/c/1273140 > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#598802} Tbr: jochen@chromium.org Bug: chromium:843903 Change-Id: I52e95076a32e0648c4c77530689b41757f7420c8 Reviewed-on: https://chromium-review.googlesource.com/c/1277798Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#599543}
-
Chris Blume authored
The blink_perf.image_decoder perf test is missing its Monorail component. This CL adds it. BUG=872828 Change-Id: Ie095d0bced3bb18474024010cb76b588fe43be3c Reviewed-on: https://chromium-review.googlesource.com/c/1278630 Commit-Queue: Chris Blume <cblume@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#599542}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/591995ddc7d4..6c21aec541cd Created with: gclient setdep -r src-internal@6c21aec541cd The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I81f1929c8c4ed03da73f274bcd0bc60dce7e3156 Reviewed-on: https://chromium-review.googlesource.com/c/1279976Reviewed-by:
-
Nektarios Paisios authored
TBR=dmazzoni@chromium.org, aleventhal@chromium.org Change-Id: I847215cb433d9252d53bd660516da7e1b73869f2 Reviewed-on: https://chromium-review.googlesource.com/c/1278915 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#599540}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c0e867da1e21..591995ddc7d4 Created with: gclient setdep -r src-internal@591995ddc7d4 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Iba9c878dd6b73373fcecd196e0e4c466761ea721 Reviewed-on: https://chromium-review.googlesource.com/c/1279975Reviewed-by:
-
Thomas Tangl authored
This CL changes the behavior of the signin-allowed toggle on the privacy page: - When the user is syncing and tries to turn the toggle off, the toggle remains on and the sign-out dialog is opened. - When the user turns off sync, they can normally use the toggle. TBR= scottchen@chromium.org, jochen@chromium.org Bug: 892745 Change-Id: If606532345645ae91a93212abc8ba7e521db56ed Reviewed-on: https://chromium-review.googlesource.com/c/1278637Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#599538}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2a4881c3734b..c0e867da1e21 Created with: gclient setdep -r src-internal@c0e867da1e21 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ia674894df63ee3100778d07c46ff11f37d7dfd62 Reviewed-on: https://chromium-review.googlesource.com/c/1279974Reviewed-by:
-
Mathias Bynens authored
Update the examples to prefer `const` over `let` or `var`, per the Google JavaScript style guide [1]. Also update the spec links to point to the latest available draft [2] instead of a versioned snapshot, since that’s what we aim to implement. [1] https://google.github.io/styleguide/jsguide.html [2] https://tc39.github.io/ecma262/ Change-Id: If019e533a1aa320fefe02185c64fe1b632e26c81 Reviewed-on: https://chromium-review.googlesource.com/c/1122220Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#599536}
-
BUG=762641 TBR=achuith@chromium.org Change-Id: Idbd7085f4d721c9cb0316d896b739008dbdea75a Reviewed-on: https://chromium-review.googlesource.com/c/1279954 Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#599535}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/37c51b14cd92..2a4881c3734b Created with: gclient setdep -r src-internal@2a4881c3734b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Id4a56a295796f42cfe5587fa0241d8822a85da4d Reviewed-on: https://chromium-review.googlesource.com/c/1279972Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/23775a2e9736..681692726fc0 git log 23775a2e9736..681692726fc0 --date=short --no-merges --format='%ad %ae %s' 2018-10-14 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version Created with: gclient setdep -r src/third_party/skia@681692726fc0 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=egdaniel@chromium.org Change-Id: I7d5f1c3c0480f58a4a9b09b9feddbe30b75cd5c8 Reviewed-on: https://chromium-review.googlesource.com/c/1279973Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/63d979f75159..a56b72d4cdcb git log 63d979f75159..a56b72d4cdcb --date=short --no-merges --format='%ad %ae %s' 2018-10-14 vapier@chromium.org pylintrc: mark mox as deprecated Created with: gclient setdep -r src/third_party/chromite@a56b72d4cdcb The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Id3cbcf43a1c8fc692cfc0668b87f64f94ef2b133 Reviewed-on: https://chromium-review.googlesource.com/c/1279968Reviewed-by:
-
