- 17 Jun, 2020 31 commits
-
-
Tom Anderson authored
This CL switches to x11::Event for most functions, with the minimal changes necessary to continue building. This introduces many no-op diffs that look like this: - bool XYZ::DispatchXEvent(XEvent* xev) { + bool XYZ::DispatchXEvent(x11::Event* x11_event) { + XEvent* xev = &x11_event->xlib_event(); There are a few substantial changes in test code which involve initializing an XProto event in addition to an Xlib event. For most of these, the strategy is to use an intermediate XCB event (which is the wire format) which gets parsed into the Xlib and XProto events. However, for a couple of XInput events, it's easier to directly initialize the Xlib event and the XProto event separately. BUG=1066670 R=nickdiego,sky CC=msisov Change-Id: I987fa17f621e001c352baf75220f0d4f2d4d98d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240355Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#779114}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I8a6c442ce71a8de0dd1f0a125f3478b82e0f5ce1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246909Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#779113}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I085175894bde227be31d4b02d75beb23c726f427 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248922Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#779112}
-
Jarryd authored
In the current state, persistence (durable storage) is granted only to ImportantSites. A list of origins is populated with the following, in order: 1. Origins with high engagement (installed adds to engagement score) 2. Origins with notification permission 3. Origins that have persistence already 4. Origins that are bookmarked The list is then sorted by a calculated score, and then the list is chopped to a max length of 10. This change splits out installed origins from this logic. Now, DurableStoragePermissionContext::DecidePermission() will query ImportantSitesUtil for a set of installed origins and check if the requesting origin is in that set before querying for ImportantSites. If the origin is found to be installed, we can grant the permission and return early. Bug: 933259 Change-Id: I2636f8eb5d4ecc5e58c343ec0ab7ed15ab0ee6fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236727Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#779111}
-
Bettina authored
Bug: 1069793 Change-Id: I8ebbee52399d1bfc2bc2ce3b7c9bfe89a27619d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248491 Auto-Submit: Bettina Dea <bdea@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#779110}
-
Wenyu Fu authored
Bug: 1094925 Change-Id: If72bd5ba7c9d97d113ee86944ae71d3c685a5ed2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248484Reviewed-by:
Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Cr-Commit-Position: refs/heads/master@{#779109}
-
Yu Han authored
Prior to this CL, image input type will always use a Block layout when the image src can't be loaded. This prevents web developers from changing the layout via CSS display property. This CL fixes the issue by creating a Layout object based on the CSS computed styles. Web developers can change image's fallback text layout via CSS display property. If none is passed in, it defaults to inline-block, which is the default layout of the input image type. Spec: https://html.spec.whatwg.org/multipage/rendering.html#images-3:represents-5 Bug: 948066 Change-Id: I907432485472c472608b9d84d36fa2df29412f7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212963Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Yu Han <yuzhehan@chromium.org> Cr-Commit-Position: refs/heads/master@{#779108}
-
Sammie Quon authored
This will help identify tablet related bugs. Test: none Bug: 1072049 Change-Id: I2fb86d3a246fccf68c0ddebfc7a75ce81cec97c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248676 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#779107}
-
Charlie Hu authored
This CL splits the parsing logic and semantic logic in |FeaturePolicyParser| so that parsing logic can be easily substituted. This is pre-work to implement permission policy parser which uses structured header format. (https://github.com/w3c/webappsec-feature-policy/issues/376) Change-Id: I116e69a562974d21e0d3a53b15cfbb3276b37d72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236726 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#779106}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/38accb0f0337..d49aa6fb8b3a 2020-06-16 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-06-16 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I8f6541f41d69837663409d1a5a3199ef4e1836d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246901Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#779105}
-
Brian Sheedy authored
Switches the GPU maps pixel tests back to expected colors instead of using Skia Gold. The test is currently too noisy (~1500 unique images in Gold), and while inexact matching is handling the vast majority of these images, it's causing the triage log to be filled with nothing but results for this one test. Additionally, the large number of images is making the diff server (what is used to calculate the diff shown between a particular image and the next closest) quite slow. So, keep this test as an expected color test until some improvements can be made in Gold to address these issues. TBR=kbr@chromium.org Bug: 1078914 Change-Id: I11e5102e90c8df2e294a1898991443b040422ac0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248492Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#779104}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/9b15236686b2..4615971566e1 2020-06-16 sugoi@google.com Cleanup: using the proper Image subregion structure If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I06b507dc975db30715fffd3dd824f7f1f3d84c5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247096Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#779103}
-
Becca Hughes authored
Change the link rel type to media-feed and remove the requirement for the type attribute since the rel type is more specific. BUG=1053599 Change-Id: I5ead97e0ed5979cec79e32b9aea14f6b9cd39d43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238500Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#779102}
-
Jesse Schettler authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/9d2399ea2761..60f6f4105492 $ git log 9d2399ea2..60f6f4105 --date=short --no-merges --format='%ad %ae %s' 2020-06-03 yhong runtime_probe,hardware_verifier: HW compliance check for USB cameras 2020-05-29 fletcherw lorgnette: convert ListScanners to proto impl 2020-06-15 zuan system_api: Add cryptohome UserDataAuth kill switch to features 2019-08-14 kdgwill system_api: Add DBus service constants for CfM Broker 2020-06-09 ahassani dlcservice: Add is_removable 2020-06-05 briannorris shill: wifi: drop all 802.11w parsing, D-Bus property 2020-05-21 akhouderchah hermes: Parse LPA error codes properly 2020-06-09 cylai system_api: build attestation dbus api into go packages 2020-06-09 cylai system_api: gn-format BUILD.gn Created with: roll-dep src/third_party/cros_system_api Bug: b:157577191 Change-Id: Ifc1dafda0feb14d3c2d2210c630e04afef6ab7c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248887 Commit-Queue: Jesse Schettler <jschettler@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#779101}
-
Yu Han authored
Prior to this CL, img with CSS height, width and a title attribute is treated as inline text without the CSS dimensions applied. The reason is that title attribute is treated as a backup for alt text [1]. Thus, this prevents the img to be treated as replaced element with intrinsic dimensions [2]:represents-2, but it's treated as non-replaced text [2]:represents-3 where the CSS dimensions are ignored. The fix is instead of checking the HTMLElement::AltText(), check only the presence of alt attribute when determining if the element should be treated as a replaced element. I had considered making the fix in [1] so that AltText() doesn't fallback to title. However, I decided against it to minimized the impact of this change and only fix it when the img doesn't represent an image and defaults to its fallback behavior. [1] https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/renderer/core/html/html_image_element.cc;l=321 [2] https://html.spec.whatwg.org/multipage/rendering.html#images-3 Bug: 958250 Change-Id: I78b3d84d8237b72505fdc5389702d119d61ae405 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239473 Commit-Queue: Yu Han <yuzhehan@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#779100}
-
Sunny Sachanandani authored
Bug: 1052991 Change-Id: Id0a7f5a98485564f55f343e5711ef69e960c4d1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248490Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#779099}
-
Lei Zhang authored
Move all of ChromeComponentExtensionResourceManager's data into an inner Data class that initializes normally. Then create an instance of the Data class on demand, instead of during browser startup. Bug: 1095198 Change-Id: Ifce2f3a2ed32db84d8435ea4c8be095876f5a150 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247679Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#779098}
-
David Maunder authored
PersistedTabData provides a mechanism for acquiring serialized UserData objects in storage and attaching them to a Tab. The caching mechanism provides the capability to cache callbacks acquiring the same data which yields a performance improvement. It also means we avoid a bug of the following: 1 FooTabData.from(...) 2 FooTabData.from(...) 3 setUserData changing what is stored on FooTabData 4 2) returning after 3) and changing what is stored on FooTabData Bug: 1059602 Change-Id: Ib3534922ace1a653068caa17a78a7eb46d307dd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236045Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: David Maunder <davidjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#779097}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ia315257f38575847d67d75d40aa57f3e05ebab9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247345Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#779096}
-
Mustafa Emre Acer authored
This CL adds a new enum (IDNSpoofChecker::Result) and returns it from IDN spoof checking code. This result will then be used to convert some punycode fallback cases to other types of UI (interstitials or safety tips). Bug: 1095120 Change-Id: I68c1b3c639edc3f71a0f2c4d3d5adbce7a689c9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246833 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#779095}
-
Nigel Tao authored
In general, if M files #include a utility header and that header file also #include's N files then, very roughly speaking, compilation has to process O(M * N) lines of code. This can get increasingly expensive the more a utility library becomes a dumping ground of all manner of miscellaneous helpers, increasing both M and N. A general counter- measure is to move #includes out of the .h file and into the .cc files that actually depend on the specific type (e.g. FilePath, TimeDelta, UnguessableToken, etc). This commit does that for the base::Time and base::TimeDelta types. Bug: 1086733 Change-Id: Id6009c8377d27eea5c48f1b22c757410e2f13f0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247938Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#779094}
-
Mei Liang authored
This CL does the following: 1. Let LayoutTab extends PropertyModel and converts all the private variables to a PropertyKey. 2. Updates all setters and getters to use the PropertyModel#set() and PropertyModel#get(). 3. Delete all FloatProperty 4. Move all computational logic out of LayoutTab. Change-Id: Ia9c74c79b90b52f13d554198fda05837b3ab79ec Bug: 1070284 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149626Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#779093}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/959037e082f6..f4e6ae915eda 2020-06-16 stuartmorgan@google.com Fixes missing newlines in headers 2020-06-16 syoussefi@chromium.org Vulkan: Use GPU path for copy to sRGB textures 2020-06-16 timvp@google.com Remove mProgramState from ProgramExecutable::isCompute() 2020-06-16 timvp@google.com Remove mProgramState from ProgramExecutable::updateActiveImages() 2020-06-16 m.maiya@samsung.com Vulkan: Ensure tiling mode compatibility while deciding copy path If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: courtneygo@google.com Test: Test: Build/CQ Change-Id: I7ebce81a53473bbca5c8b0ad7dcc00c81fddeb04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248938Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#779092}
-
Xiang Ji authored
Minor changes: - Add pyperclip in the test lib - Only two clients machine in AD is enough for WebProtect tests Bug: 1090582 Change-Id: I3bfa3e12b531f65eaeb29712e01695769fc0491f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246849Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Dominique Fauteux-Chapleau <domfc@chromium.org> Commit-Queue: Xiang Ji <jxiang@google.com> Cr-Commit-Position: refs/heads/master@{#779091}
-
Cammie Smith Barnes authored
There were several occurrences of "Replaced With PageLoad.Cients.Ads" among obsolete histograms. Change-Id: I4b6f09f0397825af7dc633059a0b9794a45e69c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247325Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Cammie Smith Barnes <cammie@chromium.org> Cr-Commit-Position: refs/heads/master@{#779090}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0811b8c48729..b1201523fc7a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC liberato@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1091256,chromium:1092340,chromium:1095517 Tbr: liberato@google.com Change-Id: I6168ce247f3825029a10a7b199e5bf426e58dee4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248920Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#779089}
-
Sven Zheng authored
Change-Id: I1a932db9798696bc293da6b791031115def0daa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248881 Auto-Submit: Sven Zheng <svenzheng@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#779088}
-
Peter Kasting authored
* Fix typos in readme. * Add remaining aliases to functional.h. * Add TODOs for remaining range-based algorithms in algorithm.h. * Provide implementation and test for ranges::lower_bound(). Bug: 1095795 Change-Id: Icfdb99d91dabab4d68013a25b86451ce8c0ed6d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248886 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#779087}
-
Nate Fischer authored
No change to logic, only adds logs. This adds logs to see how users are interacting with the crash UI. Bug: 1084179 Test: Manual - locally add Log.i() calls and verify this works correctly Change-Id: I007f4ddf5871d63a746b2f405a20c543015a42e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241463 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Hazem Ashmawy <hazems@chromium.org> Cr-Commit-Position: refs/heads/master@{#779086}
-
Darwin Huang authored
https://chromium.googlesource.com/chromium/deps/sqlite.git/+log/b5399f70d477..0879314d807e $ git log b5399f70d..0879314d8 --date=short --no-merges --format='%ad %ae %s' 2020-06-16 huangdarwin Identifiers "TRUE" and "FALSE" cannot take on their boolean constant values if they are operands of the "." operator. Created with: roll-dep src/third_party/sqlite/src Bug: 1094247 Change-Id: I6539c874bb2cc04d283b61b9e6dee3060f08bf0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248668 Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Chris Mumford <cmumford@google.com> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#779085}
-
danakj authored
R=avi@chromium.org Bug: 866140 Change-Id: Iacc56bf472eaa3eab2938889089dad7a7132e143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248175Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#779084}
-
- 16 Jun, 2020 9 commits
-
-
chrome://flagsRyan Sturm authored
This CL marks omnibox-spare-renderer as enabled in chrome://flags until M92 as we investigate the feature again. Bug: 730587 Change-Id: I96f0ddb6027aca8daf5c72ca4dcbb72a4ca963ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247344Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#779083}
-
Brian Sheedy authored
Switches the unittests in //build/android off the version of pymock from //third_party and onto the version made available via vpython. Bug: 1094489 Change-Id: I0fe024c582b1335eecf1e0b9d05e18122284da07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246190 Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#779082}
-
Ben Joyce authored
Last set of test filters to convert. Bug: 1005891 Change-Id: Ie0692a52eda6f3b38debda2a12a7e5b4398b14ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248882Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: benjamin joyce <bjoyce@chromium.org> Cr-Commit-Position: refs/heads/master@{#779081}
-
Alex Ilin authored
This CL replaces custom keydown handlers in SigninEmailConfirmationDialog and in SigninErrorDialog with "autofocus" HTML attribute. The custom handlers were added to make "confirm" default action when pressing enter. Autofocus achieves the same goal with less code and better accessibility. This CL is a continuation of https://crrev.com/c/2238154. Bug: 1084479 Change-Id: I3a61d325052d42cf0d5b1b213f7e6e1a4c821dab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245903Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#779080}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ad327885..50097bb2 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib80d7aa917637333fb80779c7fba7710e0077dd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248839Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#779079}
-
Li Lin authored
Bug: b/158798335 Test: unit tests Change-Id: If70621c33e7b6f6da85e8ed570b3c412874503d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242574 Commit-Queue: Li Lin <llin@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#779078}
-
Bailey Berro authored
This change extends the timeout of the DisplayChangeDialog from 10 seconds 15 seconds Bug: 860097 Change-Id: I68dfdde3778ffd42dcb1e92d64df6c392b89541b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245678 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Auto-Submit: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#779077}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/103a73ea1ff1..2e94de596ef3 2020-06-16 tommi@webrtc.org Add GetSctpStats to PeerConnectionInternal, remove sctp_data_channels() If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I2f5c905398516c44cd6f3b7f1a1a84b81528d4c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247089Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#779076}
-
Marco Paniconi authored
https://chromium.googlesource.com/webm/libvpx.git/+log/c1765573149e..5174eb5b9236 $ git log c17655731..5174eb5b9 --date=short --no-merges --format='%ad %ae %s' 2020-06-15 marpan vp9-svc: Fix to dynamic resize for svc denoising 2020-06-11 angiebird Let SetExternalGroupOfPicturesMap use c-style arr 2020-06-08 angiebird Fix assertion error in simple_encode.cc 2020-05-29 angiebird Refactor simple_encode_test.cc Created with: roll-dep src/third_party/libvpx/source/libvpx Change-Id: I64c9f20e7795bfe513e39b76607ad555de05b48b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248481Reviewed-by:
James Zern <jzern@google.com> Commit-Queue: Marco Paniconi <marpan@google.com> Cr-Commit-Position: refs/heads/master@{#779075}
-