- 24 Jan, 2019 40 commits
-
-
Victor Vasiliev authored
R=rch@chromium.org Change-Id: Ice7bfcd52126101d273d8dc3adf455d25cb84830 Reviewed-on: https://chromium-review.googlesource.com/c/1423417Reviewed-by:
Misha Efimov <mef@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Cr-Commit-Position: refs/heads/master@{#625609}
-
Oskar Sundbom authored
It's flaky. Bug: 924918 Tbr: slangley@chromium.org Change-Id: If65b35130b4ae4f6ca043720e3fed3870018dcb6 Reviewed-on: https://chromium-review.googlesource.com/c/1433758 Commit-Queue: Oskar Sundbom <ossu@chromium.org> Reviewed-by:
Oskar Sundbom <ossu@chromium.org> Cr-Commit-Position: refs/heads/master@{#625608}
-
Jérôme Lebel authored
This screen will contain all the sync settings, and will be used from the Google services settings. Screenshot: https://screenshot.googleplex.com/tRPHd54W8js Related to: crrev.com/c/1416144 Bug: 914059 Change-Id: Icb11824cdda7d8250df8f01c48cbf6ace798f962 Reviewed-on: https://chromium-review.googlesource.com/c/1416522Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#625607}
-
Daniel Bratell authored
third_party/blink/renderer/platform/loader/fetch/fetch_context.h defines a blink::ResourceType enum which, if it's known by the compiler, prevents the new code in canvas_resource_provider.cc from compiling. In some extreme jumbo builds, the compiler knows about third_party/blink/renderer/platform/loader/fetch/fetch_context.h when compiling that file and the compilation fails because symbol lookup is ambiguous. This renames the enum back to CanvasResourceType just to get all the builds happy again. Bug: 920626 Change-Id: I746325ede29cbb3fba5c9790b12af0b8925c81e3 Reviewed-on: https://chromium-review.googlesource.com/c/1433239Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#625606}
-
Vadym Doroshenko authored
FormFieldData has 2 fields related to value: 1.value - what returns .value property of input element 2.typed_value - the last value typed by the user If |typed_value| is not-empty it should be used instead of |value| in order to save user typed value, not one that was set by JavaScript. Along the way, it is fixed a bug in Mojo related to passing FormData: |typed_value| was set to |value|. Bug: 919799 Change-Id: If20fda8f72ad04d1409cc35f40100ab1b30412b0 Reviewed-on: https://chromium-review.googlesource.com/c/1404093Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#625605}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ecb1a0897978..4f593680baf5 git log ecb1a0897978..4f593680baf5 --date=short --no-merges --format='%ad %ae %s' 2019-01-24 hjd@google.com Merge "perfetto-ui: Fix summary tracks for non pid groups" Created with: gclient setdep -r src/third_party/perfetto@4f593680baf5 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I62bc53e88c26a18ac1a4715e84397bbc1e7c2216 Reviewed-on: https://chromium-review.googlesource.com/c/1433736Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#625604}
-
Daniel Bratell authored
If output buffers got full while running the tests, the script would hang, polling the process forever and it would never return a return_code from proc.poll(). This might have caused some random timouts but if so, it is unclear what 64 KB output filled up the buffers, unless the buffers were smaller than local testing would indicate. This stores stdout and stderr in temporary files and reads those files back into memory after the process has finished. Bug: 882852 Change-Id: I4e6ace2bb783fadcde3f43643ccad03c58ef519a Reviewed-on: https://chromium-review.googlesource.com/c/1425736 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#625603}
-
Fredrik Söderquist authored
Make a separate SameSizeAsComputedStyleBase struct and inherit from that instead of composing. Make sure the access specifiers match (so that for instance the reference counter will place in the correct spot in the layout). So the layout changes like: *** Dumping AST Record Layout 0 | struct SameSizeAsComputedStyle - 0 | class RefCounted<SameSizeAsComputedStyle> (base) - 0 | uint32_t ref_count_ - 8 | struct SameSizeAsComputedStyle::ComputedStyleBase base_ - 8 | void *[7] data_refs - 64 | unsigned int [4] bitfields_ + 0 | struct SameSizeAsComputedStyleBase (base) + 0 | void *[7] data_refs + 56 | unsigned int [4] bitfields + 72 | class RefCounted<SameSizeAsComputedStyle> (base) + 72 | uint32_t ref_count_ 80 | void *[1] own_ptrs 88 | void * data_ref_svg_style | [sizeof=96, dsize=96, align=8, And to exemplify with the change to field from [1], the change to the SameSize... structs will be: 0 | struct blink::SameSizeAsComputedStyle 0 | struct blink::SameSizeAsComputedStyleBase (base) 0 | void *[7] data_refs - 56 | unsigned int [4] bitfields + 56 | unsigned int [5] bitfields - 72 | class RefCounted<SameSizeAsComputedStyle> (base) - 72 | uint32_t ref_count_ + 76 | class RefCounted<SameSizeAsComputedStyle> (base) + 76 | uint32_t ref_count_ 80 | void *[1] own_ptrs 88 | void * data_ref_svg_style | [sizeof=96, dsize=96, align=8, rather than: 0 | uint32_t ref_count_ 8 | struct SameSizeAsComputedStyle::ComputedStyleBase base_ 8 | void *[7] data_refs - 64 | unsigned int [4] bitfields_ + 64 | unsigned int [5] bitfields_ - 80 | void *[1] own_ptrs + 88 | void *[1] own_ptrs - 88 | void * data_ref_svg_style + 96 | void * data_ref_svg_style - | [sizeof=96, dsize=96, align=8, + | [sizeof=104, dsize=104, align=8, - | nvsize=96, nvalign=8] + | nvsize=104, nvalign=8] Note primarily the layout of |ref_count_| from RefCounted<>. (Layout data courtesy of 'clang++ -fdump-record-layouts', with slight edits for improved readability.) [1] https://chromium-review.googlesource.com/c/chromium/src/+/1421188 Change-Id: I5f34a9bcdf86e3ddb8488bb14e531bba694c919b Reviewed-on: https://chromium-review.googlesource.com/c/1430010Reviewed-by:Emil A Eklund <eae@chromium.org> Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#625602}
-
Vasilii Sukhanov authored
- The method is useless because it should only be called in response to UserTriggeredGeneratePassword. - PasswordManagerClient Mojo interface was renamed as it describes password generation. Bug: 845458 Change-Id: I638945168fe31cfe7284219e3fc212de6c33fa7b Reviewed-on: https://chromium-review.googlesource.com/c/1426789 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#625601}
-
Maxim Kolosovskiy authored
Button titles are not used in Beta, Stable channels at the moment. They will be crowdsourced later (as a part of crbug.com/896719). Button titles inference is expensive, especially, for <form>less forms. See the metric PasswordManager.ButtonTitlePerformance.NoFormTag. This will be fixed as a part of new parser refactoring. This CL temporarly disables button titles before branch point. Bug: 910546 Change-Id: I55ac7d3bcbdc895e165cd3a46288fe089b558967 Reviewed-on: https://chromium-review.googlesource.com/c/1432854 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Auto-Submit: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#625600}
-
Yves Gerey authored
Since Luci migration, some links were 404ing. Bug: chromium:815092 Change-Id: I8bc8095114f60c24ed9ef0383d566318eed3196a Reviewed-on: https://chromium-review.googlesource.com/c/1401041Reviewed-by:
Eric Foo <efoo@chromium.org> Commit-Queue: Yves Gerey <yvesg@google.com> Cr-Commit-Position: refs/heads/master@{#625599}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/3eaf277cc935..f580d4907862 git log 3eaf277cc935..f580d4907862 --date=short --no-merges --format='%ad %ae %s' 2019-01-24 lamontjones@chromium.org BuildStore: Redirect FinishBuild function through BuildStore 2019-01-24 lamontjones@chromium.org BuildStore: Redirect ExtendDeadline function through BuildStore Created with: gclient setdep -r src/third_party/chromite@f580d4907862 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: If65a8c20a0084c75f56f9ec4d41ee369f187be0d Reviewed-on: https://chromium-review.googlesource.com/c/1433735Reviewed-by:
-
Aidan Wolter authored
This is a reland of 9df0aa65 Original change's description: > Enable connectivity checker for fuchsia > > We are using the default connectivity checker, and adding the switch > |--require-wlan| to allow developers to force connections to only WLAN > network interfaces. > > Fuchsia devices typically have an ethernet cable connected for > development, which causes the connectivity checker to always return connected. > For some tests and development, we need to force the usage of WLAN > interfaces, thus this switch was needed. > > Run cast with --require-wlan, observe disconnected > > Bug: 777973 > Test: net_unittests && Run cast with no flags, observe connected && > Change-Id: I359c57a83ce42eb81e5795c0c2c7b711b907471e > Reviewed-on: https://chromium-review.googlesource.com/c/1419903 > Reviewed-by: Paul Jensen <pauljensen@chromium.org> > Reviewed-by: Luke Halliwell <halliwell@chromium.org> > Reviewed-by: Wez <wez@chromium.org> > Commit-Queue: Aidan Wolter <awolter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#625258} Bug: 777973 Change-Id: Ib5a94f9a3e833b1ee11d01d7c364887d3790e360 Reviewed-on: https://chromium-review.googlesource.com/c/1432832Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Commit-Queue: Aidan Wolter <awolter@chromium.org> Auto-Submit: Aidan Wolter <awolter@chromium.org> Cr-Commit-Position: refs/heads/master@{#625597}
-
Dominik Röttsches authored
https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz.git/+log/89bcfb204c73..36fb2b4da971 $ git log 89bcfb204..36fb2b4da --date=short --no-merges --format='%ad %ae %s' 2019-01-23 behdad [AAT] In InsertionChain, set mark to previous-position if inserting 2019-01-23 behdad [AAT] Re-enable tests MORX-31 and MORX-41 2019-01-23 behdad [AAT] Remove mark_set from InsertionChain 2019-01-23 behdad [test/text-rendering-tests] Update from upstream 2019-01-22 behdad More of previous 2019-01-22 behdad Fix sign-compare error resulted from promoting unsigned integers to signed larger ints 2019-01-22 behdad Cast HB_UNTAG results to uint8_t 2019-01-22 behdad More -Wcast-error fix 2019-01-22 behdad Better fix for -Wcast-align errors 2019-01-22 behdad More -Wcast-error fixes 2019-01-22 behdad pragma GCC diagnostic error "-Wsign-compare" 2019-01-22 behdad Fix cast-align error 2019-01-22 behdad [CI] Remove gcc 4.2 bots 2019-01-22 behdad Convert all other enum class consts to static constexpr 2019-01-22 behdad Convert unsigned enum class consts to static constexpr 2019-01-22 behdad Convert tag enum class consts to static constexpr 2019-01-22 behdad Convert boolean enum class consts to static constexpr 2019-01-22 behdad Make some enum constants unsigned 2019-01-22 behdad Whitespace 2019-01-22 behdad pragma GCC diagnostic error "-Wvla" 2019-01-22 alfie Fix grammar 2019-01-22 alfie Grammar fix 2019-01-20 behdad Remove wrongly added files 2019-01-20 behdad Use enum for class constant 2019-01-20 behdad [CFF] Use enum for tableTag 2019-01-20 behdad Use static constexpr for large class constants 2019-01-21 khaledhosny Regular spaces will do 2019-01-21 alfie Adding leading space for code example 2019-01-21 alfie Fix description of example 2019-01-21 alfie Added option to build docs to docs 2019-01-19 behdad Fix sign compare warnings 2019-01-19 behdad Fix warning 2019-01-19 ebrahim [dwrite] Fix delete-non-virtual-dtor warning (#1550) Created with: roll-dep src/third_party/harfbuzz-ng/src R=bashi@chromium.org,behdad@chromium.org,behdad@google.com,drott@chromium.org,eae@chromium.org,jshin@chromium.org Bug: 924063 Change-Id: I1905bc8185a4a2541ebdad7cfaca466d2fea8413 Reviewed-on: https://chromium-review.googlesource.com/c/1426708 Commit-Queue: Dominik Röttsches <drott@chromium.org> Auto-Submit: Dominik Röttsches <drott@chromium.org> Reviewed-by:
-
Vaclav Brozek authored
Inside libphonenumber the max phone number (PhoneNumberUtil::kMaxLengthForNsn) is 16. The regexp matching inside PhoneNumberUtil::IsViablePhoneNumber takes a very long time on inputs with about 1000 characters (the associated bug contains a 1400 character (UTF8) input making the check run for one minute). Before passing to PhoneNumberUtil, Chromium's own phone_number_i18n.cc does a preliminary check on the string length, discarding strings longer than kMaxPhoneNumberSize. Allowing for some trimming inside PhoneNumberUtil, lowering this cap to 40 seems like a conservative approach, and much lower than today's 1000. This prevents spending a minute on regex checking inside PhoneNumberUtil in the particular fuzzer input from the associated bug. Bug: 924169 Change-Id: Iafcc518c10a4f6b9d684674c17c16922fb0ce988 Reviewed-on: https://chromium-review.googlesource.com/c/1431615Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#625595}
-
Yuki Shiino authored
Removes dead code. Change-Id: I39593fb6f5613ada4c603cfb6b0cda54e55f366f Reviewed-on: https://chromium-review.googlesource.com/c/1430301 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#625594}
-
Chromium WPT Sync authored
Using wpt-import in Chromium a1712789. With Chromium commits locally applied on WPT: 1061788d "Reland "Add quota usage details tests for all other storage backends."" bcd3934d "Add a test for ServiceWorker and AppCache interaction with claim()" 8e4e5d72 "Fix preload tests failing on wpt.fyi dashboard" f643497e "[resource-timing] Modify is_secure_context_ based on resource" 20defaa4 "[LayoutNG] ComputeReplacedSize min/max width/height fix" 05cdb4d1 "Add tentative WPT tests for stale while revalidate handling." 875e732f "Revert "Add tentative WPT tests for stale while revalidate handling."" fe2a6a46 "Split sxg-referrer.tentative.https.html" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/resources rouslan@chromium.org, mathp@chromium.org: external/wpt/payment-request NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I237bd4a4d06e63cea5993bd1896b4563cf83c7e0 Reviewed-on: https://chromium-review.googlesource.com/c/1433598Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#625593}
-
Julie Jeongeun Kim authored
This CL removes AccountTrackerService from SyncConfirmationHandler and uses IdentityManager instead of it. Bug: 922792, 922793 Change-Id: Id9e6a9f171b1d700f82137c822a81040f0169a17 Reviewed-on: https://chromium-review.googlesource.com/c/1433386Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#625592}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/44c6e848379b..84a9da3eb94c Created with: gclient setdep -r src-internal@84a9da3eb94c The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I57a7b38a3de72f9d48ba0c6eb14b088839195605 Reviewed-on: https://chromium-review.googlesource.com/c/1433734Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#625591}
-
Daniel Bratell authored
Per request by current owner thakis. Change-Id: Ie5418521d4ada0e21ea6b2b852b8ab7d3abbcaf6 Reviewed-on: https://chromium-review.googlesource.com/c/1430091Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#625590}
-
edchin authored
#import web_state.h since it is an ObjC header. Bug: 923973 Change-Id: Ieeefaf1204899e836033eae2fa52593f3a0de197 Reviewed-on: https://chromium-review.googlesource.com/c/1429242 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Auto-Submit: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#625589}
-
Ehsan Karamad authored
This CL adds the logic for reporting potential and actual violations of the unoptimized-images policy. Bug: 915788 Change-Id: Ide886ef8d04af0f7a36f63b99be8269cf8d2014d Reviewed-on: https://chromium-review.googlesource.com/c/1421740 Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#625588}
-
Matthew Cary authored
Note that the orderfile will be produced in orderfile.arm64.out, which is currently not used when building (orderfile.arm.out is used regardless of target_cpu). This makes sense as we use the same orderfile on all architectures, but is potentially confusing. Bug: 922460 Change-Id: I5f4b627529d3f9a4f20115a2609e512d83c4b88c Reviewed-on: https://chromium-review.googlesource.com/c/1417833 Commit-Queue: Matthew Cary <mattcary@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#625587}
-
Yuli Huang authored
Encapsulate window resizing by preview's aspect ratio only in preview.js and reduce dependency between main.js/preview.js. BUG=None TEST=Tested by resizing/maximizing windows. Change-Id: I135bffa77833d1a5d3e7e1b085ce324932b918e8 Reviewed-on: https://chromium-review.googlesource.com/c/1429901Reviewed-by:
Heng-ruey Hsu <henryhsu@chromium.org> Commit-Queue: yuli <yuli@chromium.org> Cr-Commit-Position: refs/heads/master@{#625586}
-
Olivier Robin authored
Some tests add some HTTP header as side effect. As Translate tests check these headers, reset them before test start. Bug: 924093 Change-Id: I3791907e347d4d265a0d0f6079eb3dd860d48cae Reviewed-on: https://chromium-review.googlesource.com/c/1429043Reviewed-by:
John Wu <jzw@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#625585}
-
Eric Willigers authored
Even though the 'top' property accepts unitless lengths when specified as a longhand, the shorthand 'inset' that sets 'top' does not allow unitless lengths. Discussed in https://github.com/w3c/csswg-drafts/issues/3525 RESOLVED: Do not allow quirks in 'inset' shorthand BUG: 924691 Change-Id: I53f642e48e8f5d4754aebb70c18d9abc7b7e6248 Reviewed-on: https://chromium-review.googlesource.com/c/1432272Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#625584}
-
Luciano Pacheco authored
Some browser tests mounts the Downloads mount point with profile root instead of MyFiles path, so they fail when using GetDownloadsFolderForProfile, this CL fixes this by only appending /Downloads when the mount point path is /MyFiles which is the condition that the devices run. MyFilesVolume flag will be enabled in follow up CL. Bug: 873539 Change-Id: Ibbbd5743567a0c5c6cf0995a3ab6fee909648f1f Reviewed-on: https://chromium-review.googlesource.com/c/1428000 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#625583}
-
Kent Tamura authored
We have bunch of "Trace(blink::Visitor*" in Blink though their classes are also in blink namespace. This CL removes a part of such unnecessary blink::. This CL has no behavior changes. This CL was produced by the following command on zsh: % for i in **/*.{h,cc}; sed -i "" -e "s/Trace(blink::/Trace(/g" $i Change-Id: I01c7f8c201593c413ddab3fc98d39c2933cc0dfb Reviewed-on: https://chromium-review.googlesource.com/c/1433388Reviewed-by:Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#625582}
-
Yuki Shiino authored
[CallWith=Isolate] + EnteredDOMWindow(isolate) is clearer and less error-prone than [CallWith=EnteredWindow]. For example, there were confusions that *.idl said [CallWith=EnteredWindow], but *.cc said func(LocalDOMWindow* calling_window). void func(v8::Isolate* isolate) { LocalDOMWindow* entered_window = EnteredDOMWindow(isolate); ... } is clearer and less error-prone. This patch removes the last usage of [CallWith=EnteredWindow], and we'll be able to retire both of [CallWith=CurrentWindow] and [CallWith=EnteredWindow]. Change-Id: I8c77c5c0e9560beea9def45f5b392843b3be152f Reviewed-on: https://chromium-review.googlesource.com/c/1430361Reviewed-by: -
Lei Zhang authored
Fix some nits along the way. Change-Id: Ie31ceda05a9e72ede0817493dafc7946e63bb79d Reviewed-on: https://chromium-review.googlesource.com/c/1433594Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#625580}
-
Yuzu Saijo authored
This CL changes the timing of starting OomIntervention monitor from DocumentAvailableInMainFrame to DocumentOnLoadCompletedInMainFrame so that intervenion would not be triggered during loading. Change-Id: I6b41e051c53b283eeb3ecfe672a7fbd512302c1f Reviewed-on: https://chromium-review.googlesource.com/c/1424757 Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Reviewed-by:
-
Lei Zhang authored
The underlying issue has been fixed. BUG=915555,919562 Change-Id: Ice2b607fbeb1ce4910143c2837ecd677ec5d0b78 Reviewed-on: https://chromium-review.googlesource.com/c/1427120Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#625578}
-
Kunihiko Sakamoto authored
Since certificate chain is unversioned. Change-Id: Ic612245d38bb949a51456ffb1dd4a55d863f7409 Reviewed-on: https://chromium-review.googlesource.com/c/1433637Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#625577}
-
Martin Robinson authored
The AuraLinux and Windows backends previously had their own map of all platform nodes, while the Views node delegate had a map for nodes it managed. Instead of keeping two maps, one containing only a subset of nodes, just keep one map in AXPlatformNodeBase. This will also be useful for allowing the Views delegate to map between unique ids and nodes from other delegates in the future. Bug: 895833 Change-Id: I67005241282ea0dbc2c6a5f3fa4b22940058c3c3 Reviewed-on: https://chromium-review.googlesource.com/c/1429040Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Martin Robinson <mrobinson@igalia.com> Cr-Commit-Position: refs/heads/master@{#625576}
-
Yoshifumi Inoue authored
This patch change |NGBoxFragmentPainter:PaintTextChild()| not to paint text outside screen similar to |InlineTextBoxPainter::Paint()| by checking overflow rectangle and |PaintInfo::GetCullRect()|. This patch makes paint/appending-text.html 22% faster, 180.2ms to 147.03ms on my local Windows box. Bug: 714962 Change-Id: I60e82cd0b4a50ef2d8bafc1fc3b3c21c5a49e460 Reviewed-on: https://chromium-review.googlesource.com/c/1429316 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Kent Tamura authored
https://chromium-review.googlesource.com/c/1417390 inserted a code fragment to a wrong place, which was below an early-return. So InvalidateStatefulFormControlList() was not called in some cases. This CL fixes it, and adds a unit test. Bug: 923691 Change-Id: I0aa630aeabd96d83609c0188d1fe57494b35f690 Reviewed-on: https://chromium-review.googlesource.com/c/1429321 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Alexey Baskakov authored
- Do not allow to turn a normal profile into an incognito profile dynamically. - Every OffTheRecord profile must have parent Original profile. Bug: 277296 Change-Id: Iebf5a5776cc7290708a7fc6c756a23b4c81465f2 Reviewed-on: https://chromium-review.googlesource.com/c/1424102Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#625573}
-
Hitoshi Yoshida authored
Blink had a non-standard extended attribute [Default] to specify a default parameter on an optional argument. Beside it, WebIDL spec defines [Default] to annotate the default bindings behavior of an operation. It is confusing to keep having non-standard [Default], so this CL renames Blink specific [Default] to [DefaultValue]. Bug: 924419 Change-Id: I789d179c19df7a31c5082c55de3b266092118828 Reviewed-on: https://chromium-review.googlesource.com/c/1433333Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#625572}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/947f4685c628..3eaf277cc935 git log 947f4685c628..3eaf277cc935 --date=short --no-merges --format='%ad %ae %s' 2019-01-24 ahassani@chromium.org paygen: Add chromeos-release-test bucket when in debug mode Created with: gclient setdep -r src/third_party/chromite@3eaf277cc935 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ia954f2a39d2dc3105bfb17b24f672467824dc6aa Reviewed-on: https://chromium-review.googlesource.com/c/1433435Reviewed-by:
-
Rob Buis authored
Make make_element_type_helpers.py use snake case for element includes to match get_file_basename usage in make_element_factory.py. Change-Id: I072df8791c44e5863e2bc563cfb0fea3705b36e7 Reviewed-on: https://chromium-review.googlesource.com/c/1412357 Commit-Queue: Rob Buis <rbuis@igalia.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#625570}
-
