GitLab

This CL plumbs an URLLoader Factory (and other related information)
from navigation url loader impl to Previews URLLoader during creation.
This allows Previews URLLoader to create an underlying network service
URLLoader for fetching a lite page preview. This adds URLLoaderClient
handling for the serving loader, and allows both URLLoaders to actually
handle URLLoaderRequests instead of always falling back.

This is the minimal CL to be able to attempt server HTTPS lite page
previews. Browser tests will be turned on as more behavior is supported.

Bug: 921740
Change-Id: I8993d00d76c1013eb08b06c544f1c1a491a11da1
Reviewed-on: https://chromium-review.googlesource.com/c/1434521
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Robert Ogden <robertogden@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632761}

This is a reland of 6b9ae2f7

Speculative revert showed that this CL was not an issue.

Original change's description:
> Android: Clean up unused Tab methods
>
> Now that https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/813849
> landed, the methods left unused in Tab can be cleaned up.
>
> Bug: 925242
> Change-Id: I64e0d8a6868644ce1843fbc965b6a3fa920d8e11
> Reviewed-on: https://chromium-review.googlesource.com/c/1470285
> Reviewed-by: Ted Choc <tedchoc@chromium.org>
> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#632406}

TBR=tedchoc@chromium.org

Bug: 925242
Change-Id: I6622ace18a59b0cf370dddcafdcc6e8fb55b4d6b
Reviewed-on: https://chromium-review.googlesource.com/c/1474983Reviewed-by: Ian Vollick <vollick@chromium.org>
Commit-Queue: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632760}

https://i.imgur.com/nDH165a.png

Change-Id: I19f7662098f6bee115b2b55f1e695875a5eda822
Reviewed-on: https://chromium-review.googlesource.com/c/1474843
Commit-Queue: John Lee <johntlee@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632759}

Change-Id: Iece05010a8cb249333707fe6e8634099a81d7243
Reviewed-on: https://chromium-review.googlesource.com/c/1469423
Commit-Queue: Nick Harper <nharper@chromium.org>
Reviewed-by: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632758}

Intent to deprecate:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/ma2J2RumrmM/nmhnTmB5CAAJ
(Consensus on the thread is that removal is OK.)

Chrome status dashboard entry:
https://www.chromestatus.com/feature/4992562146312192

Bug: 877521
Change-Id: I5dc1cce6d313f2b4138b784899cff00078ee2abe
Reviewed-on: https://chromium-review.googlesource.com/c/1464225Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Danyao Wang <danyao@chromium.org>
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632757}

Removes the code for using the VrCore-side fake head tracking service
in VR tests. This functionality was added a long time ago, but never
actually used because enabling it caused VrCore to crash randomly.

Equivalent functionality has been around on Chrome's end for a while.

Bug: 931414
Change-Id: Icb7c4931b177d1357368add1e915103bfeaef71e
Reviewed-on: https://chromium-review.googlesource.com/c/1471511Reviewed-by: Klaus Weidner <klausw@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632756}

The test was flaky because the ScriptResource can be
garbage collected before the test finished.

This CL keeps the ScriptResource alive, by loading the
script as a parser-inserted script.
This uses a Blink-specific behavior -- a parser-inserted
<script> keeps alive its corresponding ScriptResource
but a dynamically-inserted <script> doesn't.
This is somehow hacky, but seems to work.

Bug: 841466, 906320, 927296, 922951
Change-Id: Ia45787d917191d81917e89f6843ad8b0cbcc7e76
Reviewed-on: https://chromium-review.googlesource.com/c/1475077Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Mythri Alle <mythria@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632755}

Bug: 922200
Change-Id: I3ce9fcbcfee18e98f82f08393c8cae6230b6e84e
Reviewed-on: https://chromium-review.googlesource.com/c/1471301
Commit-Queue: Jacob DeWitt <jacde@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632754}

Bug: 932670
Change-Id: I5f832dfa54d88dfde2d29a7ff749c0ecb8687862
Reviewed-on: https://chromium-review.googlesource.com/c/1475878
Auto-Submit: Sidney San Martín <sdy@chromium.org>
Reviewed-by: Asanka Herath <asanka@chromium.org>
Commit-Queue: Asanka Herath <asanka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632753}

Some compilers are less forgiving about this than clang.

Change-Id: Iad07f21fcc38b8701c7c05609048805114d2ef44
Reviewed-on: https://chromium-review.googlesource.com/c/1201854
Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org>
Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632752}

Using wpt-import in Chromium 7a5376ac.
With Chromium commits locally applied on WPT:
14c11107 "Implement `Sec-CH-Lang`"
af3b056c "[WPT] [wasm] Add JS-API tests for wasm threads"
df760ab0 "Don't skip past auto-height flexboxes in quirks mode."
c3f69282 "New wpt tests for absolute position"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
jsbell@chromium.org:
  external/wpt/resources

NOAUTOREVERT=true
TBR=kyleju

No-Export: true
Change-Id: Iaeb1e8fc641b38193b9f6cc19c334b5e906f6fa1
Reviewed-on: https://chromium-review.googlesource.com/c/1475823Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#632751}

The tests that now run for YUV decoding are MipsAddedWhileOriginalInUse,
MipsAddedSubsequentDraw, and BasicMips.

This change adds a helper method to GpuImageDecodeCache called
GetUploadedPlaneForTesting and makes a few additional miscellaneous
fixes to the cache.

Bug: 900672
Change-Id: I7563206944125cdcea168ca3264c85ea5eb8e7fa
Reviewed-on: https://chromium-review.googlesource.com/c/1471261
Commit-Queue: Madeleine Barowsky <mbarowsky@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632750}

Make a separate android entry for enabling ServiceWorkerForegroundPriority in the fieldtrial_testing_config.json.

Bug: 928904
Change-Id: Id94e960c6a2031f854e92855011b585b3c61c4bb
Reviewed-on: https://chromium-review.googlesource.com/c/1474112Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632749}

content::responsiveness::Watcher can cause crashes of DCHECK
for checking mismatched events when tab-dragging is involved.

This is happening because Watcher watches both MessageLoopUI
and WindowEventDispatcher (through NativeEventObserver), but
OnWindowEventDispatcherFinishedProcessingEvent can be called
unexpectedly. When the dragged tab is attached to another
window, it means its WindowTreeHost and WindowEventDispatcher
is destructed, which causes FinishedProcessingEvent in a way
that Watcher thinks unmatched. More specifically:
. MessageLoopUI processes an event, Watcher::WillRunTaskOnUIThread
   is called.
2. WindowEventDispatcher::OnWindowEventDispatcherStartedProcessing
3. the event is to start dragging, creates a nested message loop.
4. MessageLoopUI processes another event, Watcher::WillRunTaskOnUIThread
5. if this causes attaching of the dragged tab, it closes the
   dragged browser window
6. close causes WindowEventDispatcher::OnWindowEventDispatcherFinishedProcessing
   on remaining events (for 2., in this case)
7. On Watcher::DidRunEventOnUIThread, it receives the identifier
   from 6 (i.e. the event for 2), but the last metadata_ui is
   from 4 (i.e. the task of messageloopUI), so mismatch happens

Absolutely the problem is the timing for 6, but it can happen
on other scenarios. This CL simply ignore mismatches on ChromeOS
with WindowService, and clears currently_running_metadata_ui_.
This will lose some data points for a short period of time, but
that can be acceptable for now.

Bug: 929813
Test: manually
Change-Id: I5f98d084bcbf7674ed62e790ccfbb804cd9cd3e7
Reviewed-on: https://chromium-review.googlesource.com/c/1474688Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632748}

Bug: 930350
Change-Id: I438dfe6f06cafed09668b1eb885e8f88ec41f1e7
Reviewed-on: https://chromium-review.googlesource.com/c/1461502
Commit-Queue: Kayce Basques <kayce@google.com>
Auto-Submit: Kayce Basques <kayce@google.com>
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632747}

Updated expected failure message based on rolled in webrtc change
that now enables calling addTransceiver with multiple send encodings.

Bug: webrtc:10075
Change-Id: Ia9f92aa5c41f42e996bc6c560315a2cf8b9cfe21
Reviewed-on: https://chromium-review.googlesource.com/c/1475801Reviewed-by: Steve Anton <steveanton@chromium.org>
Commit-Queue: Amit Hilbuch <amithi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632746}

Bug: 932188
Change-Id: Ifa2342a2620a6a63beb00dda306784062271d4e6
Reviewed-on: https://chromium-review.googlesource.com/c/1474992Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Jonathan Metzman <metzman@chromium.org>
Commit-Queue: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632745}

StartupContext creates helper classes wrapping the incoming and outgoing
service directory handles, to simplify use of them by component
implementations.

WebRunner & CastRunner are updated to use the StartupInfo helper, and
the CastRunner test StartCastComponent helper is updated to place the
CastChannel service in the component's incoming service directory, for
now.

Bug: 920920
Test: Existing component tests (e.g. cast_runner_integration_tests)
Change-Id: I92e9f0f0aad26aecef0da036684bb66733a267ac
Reviewed-on: https://chromium-review.googlesource.com/c/1473820
Auto-Submit: Wez <wez@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632744}

I don't believe it's necessary - at least, cq fully pass without it.

Bug: 931348

Change-Id: I8cfee39eeb5ddc46ffa8c78b5f3c7fa3b324af06
Reviewed-on: https://chromium-review.googlesource.com/c/1475000Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632743}

This CL adds a feature flag to experiment with unbolding
suggestion text in the omnibox.

Bug: 931332
Change-Id: I7ef5ced1a1e86f46e37e1695c7b3d20558e58b3c
Reviewed-on: https://chromium-review.googlesource.com/c/1475746Reviewed-by: Kevin Bailey <krb@chromium.org>
Commit-Queue: Orin Jaworski <orinj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632742}

This allows us to construct a SequenceManager and vend task queues
before launching a thread.  This should be useful in blink for
launching workers (which currently have a worker scheduler on top of a
MessageLoop), if we need an IO Thread scheduler (it looks like we might
the IO thread is congested during startup) and for the BrowserThreadTest
with a BrowserUIThreadScheduler.

The message_pump_factory_ was added to base::Thread to support these
two use cases:
https://cs.chromium.org/search/?q=message_pump_factory&type=cs

Bug: 863341, 872372
Change-Id: Ic30052e8af4a9351467792e70b7d7b65027d8a9a
Reviewed-on: https://chromium-review.googlesource.com/c/1462801
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Auto-Submit: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632741}

Bug: 930941
Change-Id: I53a45cd823e2c2efaa8cc246dff92be12b2293c3
Reviewed-on: https://chromium-review.googlesource.com/c/1471241
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Auto-Submit: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632740}

TaskRunner::PostTask() takes a OnceCallback. Replace usage of
base::Bind(), which produces a RepeatingCallback, with base::BindOnce()
when the callback is created as a temporary inside of PostTask(). The
following regex was used to find instances that could be replaced:

(Post(?:Delayed)?Task)\((?:\n\s*)?FROM_HERE,(?:\n)?\s*base::Bind\(

Also replace any usage of base::Passed(&var) with std::move(var) for
variables passed to base::BindOnce(). base::Passed() isn't needed for
move-only types with OnceCallbacks.

This CL was uploaded by git cl split.

R=sandersd@chromium.org

Bug: 714018
Change-Id: Ie4957f7669b72f804505f85e1bb8a71a63918441
Reviewed-on: https://chromium-review.googlesource.com/c/1475641
Auto-Submit: kylechar <kylechar@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632739}

Most drive metrics will be obsolete once DriveFS ships, so set their expiry to
M75 and take ownership.

Set offline to the end of the year so we can re-evaluate then.

WebstoreWidgetApp emitting code has already been removed so just mark them as
obsolete.

Bug: 931519
Change-Id: I6a545c2335e0a5f3f9ad3b480fce01f091d206a0
Reviewed-on: https://chromium-review.googlesource.com/c/1475133Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632738}

Sets the unfocused omnibox background to the same color as the results
popup, which is conventionally white.

Also enables the location bar border stroke in this mode, which already
exists for high contrast mode.

Bug: 931836
Change-Id: I97e0a5c768c739f4f037d9e3abdb99115b14999d
Reviewed-on: https://chromium-review.googlesource.com/c/1474281Reviewed-by: Kevin Bailey <krb@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Auto-Submit: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632737}

TBR=smut

Change-Id: Ie63a87a644a29d45c4ef5c4b06e6383908db756a
Reviewed-on: https://chromium-review.googlesource.com/c/1474466Reviewed-by: iOS Autoroller <ios-autoroller@chromium.org>
Commit-Queue: iOS Autoroller <ios-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632736}

TaskRunner::PostTask() takes a OnceCallback. Replace usage of
base::Bind(), which produces a RepeatingCallback, with base::BindOnce()
when the callback is created as a temporary inside of PostTask(). The
following regex was used to find instances that could be replaced:

(Post(?:Delayed)?Task)\((?:\n\s*)?FROM_HERE,(?:\n)?\s*base::Bind\(

Also replace any usage of base::Passed(&var) with std::move(var) for
variables passed to base::BindOnce(). base::Passed() isn't needed for
move-only types with OnceCallbacks.

This CL was uploaded by git cl split.

R=yuweih@chromium.org

Bug: 714018
Change-Id: I5d3dabe31b239acb3e4ba6db7527fda5a3cd5f4a
Reviewed-on: https://chromium-review.googlesource.com/c/1475635
Auto-Submit: kylechar <kylechar@chromium.org>
Reviewed-by: Yuwei Huang <yuweih@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632735}

https://skia.googlesource.com/skia.git/+log/28bafb01c90c..1b85323f10e7


git log 28bafb01c90c..1b85323f10e7 --date=short --no-merges --format='%ad %ae %s'
2019-02-15 halcanary@google.com ICU: enable on wasm
2019-02-15 robertphillips@google.com Remove GrContextPriv.h from GrRenderTargetContext.h
2019-02-15 herb@google.com Reland "Use bulk interface for paths"
2019-02-15 halcanary@google.com SkPDF: simplify subsetting code
2019-02-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src b698b62f..5862f084 (425 commits)
2019-02-15 herb@google.com Revert "Use bulk interface for paths"
2019-02-15 brianosman@google.com Add curve visualization back, guard eval
2019-02-15 herb@google.com Revert "Calculate strike in path case"


Created with:
  gclient setdep -r src/third_party/skia@1b85323f10e7

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=stephana@chromium.org

Change-Id: I2b3ce4c382b09bf1f3b266acf2a5338845d1d54c
Reviewed-on: https://chromium-review.googlesource.com/c/1475700Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#632734}

This change assigns:
  enable-navigation-tracing
  trace-upload-url
to tracing@ and marks them to expire in M80.

Bug: None
Change-Id: Ie28496728d26409ca979a08d2a33db9999c143c9
Reviewed-on: https://chromium-review.googlesource.com/c/1475808
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: oysteine <oysteine@chromium.org>
Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632733}

TaskRunner::PostTask() takes a OnceCallback. Replace usage of
base::Bind(), which produces a RepeatingCallback, with base::BindOnce()
when the callback is created as a temporary inside of PostTask(). The
following regex was used to find instances that could be replaced:

(Post(?:Delayed)?Task)\((?:\n\s*)?FROM_HERE,(?:\n)?\s*base::Bind\(

Also replace any usage of base::Passed(&var) with std::move(var) for
variables passed to base::BindOnce(). base::Passed() isn't needed for
move-only types with OnceCallbacks.

This CL was uploaded by git cl split.

R=jamescook@chromium.org

Bug: 714018
Change-Id: I58e7176c3d3a4544593f14ba4f170379f291aedd
Reviewed-on: https://chromium-review.googlesource.com/c/1475732
Auto-Submit: kylechar <kylechar@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632732}

https://chromium.googlesource.com/catapult.git/+log/798bb03c8950..5212cf739dd8


git log 798bb03c8950..5212cf739dd8 --date=short --no-merges --format='%ad %ae %s'
2019-02-15 simonhatch@chromium.org Dashboard - Blacklist last_alerted_revision on TestMetadata migration


Created with:
  gclient setdep -r src/third_party/catapult@5212cf739dd8

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:932564
TBR=sullivan@chromium.org

Change-Id: I86439098e08b20743531f63f7c706ce253107093
Reviewed-on: https://chromium-review.googlesource.com/c/1475695Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#632731}

Even though they almost never changes, Chrome checks the
certificate of all known modules on a background
sequence on every startup.

This CL introduces a cache that avoids redoing this expansive
operation if the certificate of a DLL didn't change.

Bug: 932267
Change-Id: Id523bd7794c43c5282a213a888c3291d1a35e78c
Reviewed-on: https://chromium-review.googlesource.com/c/1450812
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632730}

Don't layer the sad tab overlay over the NTP, since it doesn't matter of the web
process bails for about://newtab.  Interestingly enough, this is a possible
outcome.

Bug: 932618
Change-Id: I9cc2afdb0e5ca6ac9de9a9e8ad91146574392e99
Reviewed-on: https://chromium-review.googlesource.com/c/1475793
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Auto-Submit: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632729}

The flakiness seems to be fixed by
https://chromium.googlesource.com/chromium/src/+/3d8e0ad7f87d2c3b91cfe528ab9948ce4299a3dd

BUG=843467

Change-Id: I55903000c2d035b98b42eb91c65745a3a61e8f80
Reviewed-on: https://chromium-review.googlesource.com/c/1474848Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632728}

The exact same test was being added twice.

Change-Id: Id0708a361cc2f5eb1fba49c3da02672e58d3acc5
Bug: 927900
Reviewed-on: https://chromium-review.googlesource.com/c/1474809Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632727}

Includes fix for an affected test with brittle logic for determining
request IDs in MockHostResolver.  The new API has different effects on
the logic for generating such IDs.

Also fixed HangingHostResolver to always return ERR_DNS_CACHE_MISS when
source is LOCAL_ONLY to match HangingHostResolver::ResolveFromCache()
behavior.

Bug: 922699
Change-Id: I388dfc2a42feb49ca055160eb1bbcee05bb05de9
Reviewed-on: https://chromium-review.googlesource.com/c/1457215
Auto-Submit: Eric Orth <ericorth@chromium.org>
Commit-Queue: Asanka Herath <asanka@chromium.org>
Reviewed-by: Asanka Herath <asanka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632726}

Bug: 932305
Change-Id: I3176382e360aa70944437d92bbbee7b9aa7cd0e3
Reviewed-on: https://chromium-review.googlesource.com/c/1474838
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632725}

This starts listening for model switches to reset the model on the
TabGrid accordingly.

Also makes the flag visible in about://flags.

BUG=931025

Change-Id: Ie53e362e831039f4fe101a051e36349f8988a9b4
Reviewed-on: https://chromium-review.googlesource.com/c/1471292
Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632724}

All the notification scheduler code lives in
chrome/browser/notifications/scheduler.


Bug: 930968
Change-Id: Idfe8fd3ba7b3e8f3e9b295b2f4e8d7b14ce5df9a
Reviewed-on: https://chromium-review.googlesource.com/c/1464456
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632723}

Remove the MonochromeApplication class from TrichromeChrome's manifest
so that the regular ChromeApplication will be used instead, to avoid
trying to set up Monochrome-specific things. Update the comment in
MonochromeApplication to make it clear that it's not used by
Trichrome and that it must only be used for things that are specific to
Monochrome being a WebView implementation.

This fixes the startup crash caused by Trichrome attempting to use
BIND_EXTERNAL_SERVICE for its child processes when the Trichrome
manifest does not declare the services as external.

Bug: 917417
Test: install and launch trichrome_chrome_apk
Change-Id: If857dfb73b75e15c73398779a159ce7bb1ad56cb
Reviewed-on: https://chromium-review.googlesource.com/c/1474997
Commit-Queue: Richard Coles <torne@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Auto-Submit: Richard Coles <torne@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632722}