- 23 Oct, 2019 40 commits
-
-
Trent Apted authored
This only affects debug builds. Turns a console error like FATAL:web_ui_data_source_impl.cc(296)] Check failed: resource_id != -1 (-1 vs. -1) into something a like FATAL:web_ui_data_source_impl.cc(296)] Check failed: resource_id != -1 (-1 vs. -1) for assets/02_west.png Change-Id: Iac2ffb57ef7fe734b165edabb1cc2ddd00660f14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874748 Auto-Submit: Trent Apted <tapted@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#708668}
-
Tatiana Buldina authored
Bug: chromedriver:3179 Change-Id: If5d9ad3884411d7c42307793d28e88ccd33538e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874243Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#708667}
-
Dominique Fauteux-Chapleau authored
Bug: 944625 Change-Id: Iccee30e7a2da35fc22ee895cf59dc129c0e8298f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865592 Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#708666}
-
Steven Bennetts authored
Bug: 965089 Change-Id: Ib2161502c7e5c2a6051c66b43b911f2f9fdd7115 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874688 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#708665}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ie518520073986d8350b787f94d239f8759ca6776 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875317Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708664}
-
Jesse McKenna authored
This change adds function GetUserDataSuffix(), which returns the install suffix (e.g. "" for the primary install mode, " SxS", " Beta", or " Dev") given a path in the User Data folder. It is based on GetInstallSuffix(), which does the same given a path in the Application folder. This new function is the first part of finding the location of chrome.exe from within the User Data directory, where Progressive Web App (PWA) launchers are planned to be. The next step will be a function that uses the install mode from FindInstallMode(GetUserDataSuffix()) to get the full path of chrome.exe, which PWAs can then use to launch. Change-Id: If69859fc5f36b7d2d2c4262a1955bd432d983597 Bug: 960245 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866977 Commit-Queue: Jesse McKenna <jessemckenna@google.com> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#708663}
-
Lucas Furukawa Gadani authored
Bug: 984550, 860403 Change-Id: Id41142246f83fa05153e97b93bee8ffaf73215d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854185Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#708662}
-
Oriol Brufau authored
When serializing grid-template-rows/columns of a grid container, we need to handle auto repeat() specially in order to insert the line names at the correct places. Before this patch, this was skipped for indices before the insertion point of the auto repeat, and in case the auto repeat had no line name. The latter logic was wrong, if there is an auto repeat we still need the special code after the insertion point, even if it has no line names. The proper condition to check is whether there is no auto repeat. The patch also avoids a 2nd call to GridAutoRepeatRows/Columns since we already have the value in a variable. BUG=1011329 TEST=external/wpt/css/css-grid/parsing/grid-template-columns-computed-nogrid.html TEST=external/wpt/css/css-grid/parsing/grid-template-columns-computed.html TEST=external/wpt/css/css-grid/parsing/grid-template-rows-computed-nogrid.html TEST=external/wpt/css/css-grid/parsing/grid-template-rows-computed-withcontent.html TEST=external/wpt/css/css-grid/parsing/grid-template-rows-computed.html There are some test failures because integer repeat() is still expanded at computed-value time (http://crbug.com/989004). Change-Id: I16d06275384ab8c7866b4981ba8dcc665258b29d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857125Reviewed-by:
Manuel Rego <rego@igalia.com> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#708661}
-
Ben Pastene authored
I've received enough questions regarding led & chromium bots to warrant a small doc, I think. This isn't meant to be a full overview of what's possible with led, but might be a good starting point for someone that's not familiar with it. (ie: The target audience is someone that's not very familiar with our infra/bots.) Change-Id: I629f3872aa5f0b2da0ec4821ba1befea47bdd3da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518458Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#708660}
-
Juanmi Huertas authored
We are adding a very basic fuzzer architecture for canvas. We are adding the seed_corpuses of all of the tests implemented for canvas and inserting them blindly into the canvas_fuzzer. A nice to_do would be to use the random input from the fuzzer to guide a creation of a proper test for canvas related stuff only. Change-Id: I79ae58ace3b9c2835367ab3d53153b8b8d11885d Bug: 1016869 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865352 Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Cr-Commit-Position: refs/heads/master@{#708659}
-
Ken MacKay authored
When building Chromecast unit tests on a component build, I see link errors like: ld.lld: error: undefined symbol: mojo::StructTraits<bluetooth::mojom::UUIDDataView, WTF::String>::Read(bluetooth::mojom::UUIDDataView, WTF::String*) >>> referenced by uuid.mojom-shared.h:129 (gen/device/bluetooth/public/mojom/uuid.mojom-shared.h:129) >>> obj/third_party/blink/public/mojom/web_bluetooth_mojo_bindings_blink/web_bluetooth.mojom-blink.o:(mojo::internal::Serializer<bluetooth::mojom::UUIDDataView, WTF::String>::Deserialize(bluetooth::mojom::internal::UUID_Data*, WTF::String*, mojo::internal::SerializationContext*)) This CL fixes those errors. Change-Id: I2f9fabd66013c33461c76d5e6306c600569da9c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866626Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#708658}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ea58518db3b8..4900f195bb83 Created with: gclient setdep -r src-internal@4900f195bb83 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I43ef3c7b7ab8d4be04e2eca4fe5c64207ccdb8e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875315Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708657}
-
Yusuke Sato authored
This is to make sure that starting the proxy in UpgradeInstance() will always succeed even after Chrome crashes and restarting. Once b/142140355 is fixed, the proxy will detect Chrome crashes by itself and exit, but in theory, the proxy may exit after restarted Chrome calls UpgradeInstance(). This CL is to prevent the race. BUG=b:143175381 TEST=kill Chrome, verify restarted Chrome can start ARCVM Change-Id: Id408c6525f5b7a53d095ce36777a4300ec313cb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874788Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#708656}
-
Maksim Moskvitin authored
NigoriSyncBridgeImpl puts pending commit with keystore initialization if it received default Nigori in MergeSyncData(). There is no guarantee that this commit will be successfully processed before the browser restart. The state is persisted regardless of commit completeness. In old implementation, non-initialized state loaded from the storage can't transit to initialized. The fix is to trigger keystore initialization after loading the state. Bug: 1016706, 922900 Change-Id: I8e38a1c9e925971b9023078fb28d561d3c1c538a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875753 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#708655}
-
Anatoliy Potapchuk authored
Bug: 1012629 Change-Id: Iac0c0492356159598055acf15ef27aad008bf43e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876351Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#708654}
-
sczs authored
- Create InfobarSaveCardTableVC class and configures it on its Coordinator. - Implements InfobarSaveCardTableVC Cancel button. - Implements infobarModalHeightForWidth on InfobarSaveCardCoordinator, this is using the same code as InfobarPasswordCoordinator for now. It might be worth creating a util file that all subclassed Coordinators can use but I want to make sure its really needed first. Screenshot: https://drive.google.com/open?id=1sNsb5OhfsgNOvom4OqvumJt7ChNwVVDG Bug: 1014652 Change-Id: I704ee0c047b8bb12e58dfd0a45fdd8f6348131e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872769Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#708653}
-
Josh Nohle authored
Use the max time any device feature was modified as the CryptAuthDevice's last_update_time. Bug: 990441, 951969 Change-Id: I96fd92611ddfb535070fa421bf78b1a77a64e655 Fixed: 990441 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865659 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#708652}
-
Lucas Furukawa Gadani authored
Bug: 839343 Change-Id: I166ce93bd88f5e5939fe345259f6efd558459b8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872812 Auto-Submit: Lucas Gadani <lfg@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Mohamed Amir Yosef authored
This CL is only renaming the methods PasswordFormManager: :UpdateUsername() PasswordFormManager: :UpdatePasswordValue() Change-Id: I093cc06d994ee06af039af7e6202589b5fdda754 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876412 Auto-Submit: Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#708650}
-
Torne (Richard Coles) authored
Log tags are automatically prefixed with "cr_" by the logging system, and may not contain dots as this often causes them to be stripped by our log sanitizers. This is now checked by presubmit, but there were many cases that predated the check. Therefore: - remove any "cr." and "cr_" prefixes from TAG values. - replace any remaining dots in TAG values with underscores. Change-Id: Ife8709d2b1631483bbacbed0babc54b7f6da3662 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873158 Auto-Submit: Richard Coles <torne@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#708649}
-
Stephen McGruer authored
TBR=sky@chromium.org Bug: 1017206 Change-Id: I4a9524309a8d1452f9fd8af26ee143fbb07d7956 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876022Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#708648}
-
Andrew Luo authored
Bug: 1016864 Change-Id: I285a3ff74b620b2d1ddc4800929094b25cb06178 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873962Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Andrew Luo <aluo@chromium.org> Cr-Commit-Position: refs/heads/master@{#708647}
-
edchin authored
This CL fixes the issue in which the bottom toolbar covers over the last row of tabs. This was caused by the inset not being properly reset when rotating between portrait and landscape. The TabGridBottomToolbar is smart about rotation changes. It automatically adjusts it's intrinsicContentSize, so this does not need to be adjusted by the TabGridViewController. The user of TabGridBottomToolbar just needs to set insets to the intrinsicContentSize given by TabGridBottomToolbar. Bug: 1003768 Change-Id: Ib61039bf7d872ebe27d1971ba5848afafa643af0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874611Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#708646}
-
Evan Stade authored
They are moved from BrowserObserver to NavigationObserver Bug: none Change-Id: Ic84eb9be76e5f5018ea4da82331b3b982dcd8dde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831995 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#708645}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/3c660b0e0c31..0cdd39db4443 git log 3c660b0e0c31..0cdd39db4443 --date=short --no-merges --format='%ad %ae %s' 2019-10-23 lalitm@google.com Merge "perfetto: bump trace_processor and traceconv to faebe62" Created with: gclient setdep -r src/third_party/perfetto@0cdd39db4443 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I569545d75974e8db27318af3c44468a90e40a38c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875313Reviewed-by:
-
Guido Urdaneta authored
Also perform an extra null check when the frame is converted to a WebFrame. Bug: 1017121 Change-Id: I2e85f8db9917076a6865b4411e69dc81230764c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876410Reviewed-by:
Armando Miraglia <armax@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#708643}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a9f11bf14bce..a1ed9d1a8492 git log a9f11bf14bce..a1ed9d1a8492 --date=short --no-merges --format='%ad %ae %s' 2019-10-23 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader a68a80a4dbf9..7738ed713e7b (6 commits) Created with: gclient setdep -r src/third_party/angle@a1ed9d1a8492 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@google.com Bug: None Change-Id: Ibe146b2cb2333cfa10eb75f8a2485d220ccbf65d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876072Reviewed-by:
-
Steven Bennetts authored
This adds compress="gzip" to: * App Management in OS Settings * Crostini installer * Mobile setup page * Guest session tab * SMB share dialog * Debugging UI: chrome://cryptohome, chrome://drive-internals R=melzhang@google.com,lxj@google.com,khorimoto@chromium.org,baileyberro@chromium.org Bug: 965089 Change-Id: I37ab9f9773216a8ea2172879f05643bf6c74d5ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874807Reviewed-by:
Anand Mistry <amistry@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#708641}
-
Josh Nohle authored
CryptAuth decided it will only use one Instance ID token: the one corresponding to CryptAuth v2 Enrollment. Bug: 990430 Change-Id: I663a0c337ddc061ec8607eda0b0d014437d97ee4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866992Reviewed-by:
-
Etienne Bergeron authored
This CL is changing the way RunList tests are executed. The motivation for this change is to allow adding many more tests in the following CL where the ItemizeTextToRuns(...) will be refactored. Bug: 1017194 R=robliao@chromium.org Change-Id: I6f5b70c8752fe2ddecab9cdfbf863065a52dcc4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873159 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#708639}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4f178d08de67..21bfa401ddea git log 4f178d08de67..21bfa401ddea --date=short --no-merges --format='%ad %ae %s' 2019-10-23 saza@webrtc.org Update APM config on RuntimeSetting pre amplifier gain change Created with: gclient setdep -r src/third_party/webrtc@21bfa401ddea If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: Iac95db50e4271ceefbceb9e1fc8299b38cf18e96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875312Reviewed-by:
-
Evan Stade authored
Bug: 268984 Change-Id: I614c426f7f1dc633a8bcc667e05ef107a53dfe1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869757Reviewed-by:
Tommy Martino <tmartino@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#708637}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: Ia06cdb391c903720de87e5d558b5cbe2796c3a05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876441Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708636}
-
Michael Spang authored
Since 0467279e ("Reland "[Chromecast] Fix thread safety issues in CastAudioJson."") we need to use a full task environment to avoid a CHECK failure calling base::CreateSequencedTaskRunner(). Bug: 143135800 Test: cast_media_unittests Change-Id: Ib07489414e4b13c74a7441a0f6d3fb4d73f6351c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874808 Auto-Submit: Michael Spang <spang@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#708635}
-
Bailey Berro authored
Updates the error string shown when adding a printer fails for a non-descript reson. Bug: 1011586 Change-Id: I89ef561ad96b60020c0e04cc492bdd5fda738f3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874592 Auto-Submit: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#708634}
-
Henrique Ferreiro authored
https://crrev.com/c/1756744 removed all usage of this class but didn't remove the file. Bug: 919392 Change-Id: Ifbf0aa85b1a93330105392ef514ed4503434a23f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875104Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#708633}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/5e634c8999e6..a3f0da56e4c9 git log 5e634c8999e6..a3f0da56e4c9 --date=short --no-merges --format='%ad %ae %s' 2019-10-23 52076061+digit-google@users.noreply.github.com BUILD.gn: Fix fuchsia build (#1944) Created with: gclient setdep -r src/third_party/glslang/src@a3f0da56e4c9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=radial-bots+chrome-roll@google.com,jonahr@google.com Bug: None Change-Id: I63ca43349336f7ba7bdb6b60db451220d4a89f04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876071Reviewed-by:
-
Julie Jeongeun Kim authored
This CL converts GraphExecutor graph_executor.mojom to new Mojo types using PendingReceiver, ReceiverSet, and Remote. Bug: 955171 Change-Id: I4ef4ad439b4eaa7b6e607a734f8f04a9a84776cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850681 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Cr-Commit-Position: refs/heads/master@{#708631}
-
Lily Chen authored
This change updates CookiePolicyBrowserTest to work under SameSiteByDefaultCookies and CookiesWithoutSameSiteMustBeSecure. This adds "SameSite=None;Secure" to some cookies which are accessed in a third party context in tests. Bug: 1006816 Change-Id: I7c4dc3d96f8cb718f9178fff93a000ce16c1d7f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830288Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#708630}
-
Jonah Ryan-Davis authored
Add a new DisplayType ANGLE_VULKAN_SWIFT_SHADER with the flags --use-angle=vulkan-swiftshader to run Chrome on the "SwANGLE" backend. Bug: 1015454 Change-Id: Ie2a3797d9c64fa8cd46b8a601fe615e69775ccc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865603 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#708629}
-
