- 18 Dec, 2019 40 commits
-
-
John Abd-El-Malek authored
Change-Id: I2078a3fb0c795be2a879a036e73eec32ace4d2a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961268Reviewed-by:
Darin Fisher <darin@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#726002}
-
Victor Vasiliev authored
This way, it can be used in QUIC code that does not depend on QuicStreamFactory. R=rch@chromium.org Bug: 1011392 Change-Id: I5d585067012ec7e5c28779080326ebdd1318203a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973171Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#726001}
-
Devlin Cronin authored
Attempt to deflake ExtensionBindingsApiTest.LastError. The test was failing with a segmentation fault, which most likely happened when trying to de-reference an ExtensionHost that could be null. Try to fix this by: - ASSERTing the ExtensionHost exists (at least giving us a good error message if it does not) - Waiting for a "ready" message from the extension, which guarantees the background page has been created. Bug: 1035011 Change-Id: I13510ea649f6488f216bf50bd4cf00bb9d521292 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972263Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#726000}
-
Jeroen Dhollander authored
This is a reland of crrev.com/c/1894296 The commit was reverted in crrev.com/c/1971041 because the new browser tests failed when run by the |linux-chromeos-chrome| trybot. The tests failed because the |fake_s3_server_main| binary was not copied over to the sandboxes used by the |linux-chromeos-chrome| trybot while it runs its tests. This is fixed by adding the |fake_s3_server_main| as a runtime dependency of the |browser_unittests| build target. Original change's description: > Add Assistant integration tests using a fake S3 server. > > These tests run as browser tests, use the real libassistant code and use a fake > s3 server to replay previously recorded conversations. > > This allows the Assistant to run CQ tests that verify the basic interactions > are not broken. > > More specifically, this uses a FakeS3Server library that was previously > created by the LibAssistant team. On the ChromeOS side I added hooks to > tell LibAssistant to use the FakeS3Server, and a test-fixture to start/stop > the fake S3 server during the browsertests. > > BUG: b/141264108 > TESTS: in target |browser_tests| with names |AssistantBrowserTest.*| > > Change-Id: I89985c9e34eaa21a17eef69fa5b472fa39486d30 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894296 > Reviewed-by: Sam McNally <sammc@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Commit-Queue: Jeroen Dhollander <jeroendh@google.com> > Cr-Commit-Position: refs/heads/master@{#725214} TBR=xiyuan@chromium.org,sammc@chromium.org, xiaohuic@chromium.org TBRing reviewers: - Note There were no changes in any file since crrev.com/c/1894296 except |chrome/test/BUILD.gn| - xiyuan@ please look at assistant_test_api.h - sammc@ please look at assistant.mojom - xiaohuic@ please look at the assistant code Change-Id: I514daac006c1254db26adf8b0fd3f6be652f4581 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971225Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jeroen Dhollander <jeroendh@google.com> Cr-Commit-Position: refs/heads/master@{#725999}
-
Elly Fong-Jones authored
Bug: 825305 Change-Id: Ib3643d72e2ac9226a58838dad2738ecacccd569e Tbr: sidereal@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972759Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#725998}
-
Yusuke Sato authored
This will allow chromeos::CrostiniManager to access SchedulerConfigurationManager. BUG=1011559 TEST=arc.Boot, ARCVM still starts Change-Id: Idf76dbf595a652c09ca444fa90c9738976553dc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972293Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#725997}
-
https://crbug.com/1030618Saman Sami authored
We're failing at unregistration time. See if the registration succeeded at all. Bug: 1030618 Change-Id: I34465971c8a622d9f4c86614b1514ab3282af2ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973959Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#725996}
-
Rakib M. Hasan authored
Bug links without numbers cannot be used in the new test expectations format. Bug: 986447 Change-Id: I32c6dcf656c8bcc010bbb37b2aec76939f51d980 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973153Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#725995}
-
John Budorick authored
Encountered this while working on emulator tests. Should ensure that the test runner gets more information if we fail to unzip the data dependencies on the device. Change-Id: I8302a1b9abf13a60a3f4055dc03292ac9865ea23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973357Reviewed-by:
Yun Liu <yliuyliu@google.com> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#725994}
-
Elly Fong-Jones authored
This reverts commit f34c7c2b. Reason for revert: Likely culprit for frequent test flakes on win7 dbg bot. Sample failing build: https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29 Sample failure stack: [1744:6088:1218/071720.166:FATAL:native_window_occlusion_tracker_win.cc(420)] Check failed: FALSE. A root window did not get its occlusion state set Backtrace: base::debug::CollectStackTrace [0x6F2A256C+60] (o:\base\debug\stack_trace_win.cc:284) base::debug::StackTrace::StackTrace [0x6EFAA18E+78] (o:\base\debug\stack_trace.cc:206) base::debug::StackTrace::StackTrace [0x6EFAA102+34] (o:\base\debug\stack_trace.cc:203) logging::LogMessage::~LogMessage [0x6EFE9AC0+144] (o:\base\logging.cc:628) aura::NativeWindowOcclusionTrackerWin::WindowOcclusionCalculator::ComputeNativeWindowOcclusionStatus [0x647E0ADC+1660] (o:\ui\aura\native_window_occlusion_tracker_win.cc:418) base::internal::FunctorTraits<void (aura::NativeWindowOcclusionTrackerWin::WindowOcclusionCalculator::*)() __attribute__((thiscall)),void>::Invoke<void (aura::NativeWindowOcclusionTrackerWin::WindowOcclusionCalculator::*)() __attribute__((thiscall)),aura: [0x647F372C+28] (o:\base\bind_internal.h:498) base::internal::InvokeHelper<0,void>::MakeItSo<void (aura::NativeWindowOcclusionTrackerWin::WindowOcclusionCalculator::*)() __attribute__((thiscall)),aura::NativeWindowOcclusionTrackerWin::WindowOcclusionCalculator *> [0x647F369F+79] (o:\base\bind_internal.h:598) base::internal::Invoker<base::internal::BindState<void (aura::NativeWindowOcclusionTrackerWin::WindowOcclusionCalculator::*)() __attribute__((thiscall)),base::internal::UnretainedWrapper<aura::NativeWindowOcclusionTrackerWin::WindowOcclusionCalculator> >, [0x647F35F5+85] (o:\base\bind_internal.h:671) base::internal::Invoker<base::internal::BindState<void (aura::NativeWindowOcclusionTrackerWin::WindowOcclusionCalculator::*)() __attribute__((thiscall)),base::internal::UnretainedWrapper<aura::NativeWindowOcclusionTrackerWin::WindowOcclusionCalculator> >, [0x647F3584+84] (o:\base\bind_internal.h:640) base::OnceCallback<void ()>::Run [0x6EF62360+80] (o:\base\callback.h:99) base::OneShotTimer::RunUserTask [0x6F1F8DB9+265] (o:\base\timer\timer.cc:265) base::internal::TimerBase::RunScheduledTask [0x6F1F88D5+293] (o:\base\timer\timer.cc:227) base::internal::BaseTimerTaskInternal::Run [0x6F1F875C+60] (o:\base\timer\timer.cc:50) base::internal::FunctorTraits<void (base::internal::BaseTimerTaskInternal::*)() __attribute__((thiscall)),void>::Invoke<void (base::internal::BaseTimerTaskInternal::*)() __attribute__((thiscall)),base::internal::BaseTimerTaskInternal *> [0x6F1F9CAC+28] (o:\base\bind_internal.h:498) base::internal::InvokeHelper<0,void>::MakeItSo<void (base::internal::BaseTimerTaskInternal::*)() __attribute__((thiscall)),base::internal::BaseTimerTaskInternal *> [0x6F1F9C0F+79] (o:\base\bind_internal.h:598) base::internal::Invoker<base::internal::BindState<void (base::internal::BaseTimerTaskInternal::*)() __attribute__((thiscall)),base::internal::OwnedWrapper<base::internal::BaseTimerTaskInternal> >,void ()>::RunImpl<void (base::internal::BaseTimerTaskIntern [0x6F1F9B65+85] (o:\base\bind_internal.h:671) base::internal::Invoker<base::internal::BindState<void (base::internal::BaseTimerTaskInternal::*)() __attribute__((thiscall)),base::internal::OwnedWrapper<base::internal::BaseTimerTaskInternal> >,void ()>::RunOnce [0x6F1F9AF4+84] (o:\base\bind_internal.h:640) base::OnceCallback<void ()>::Run [0x6EF62360+80] (o:\base\callback.h:99) base::TaskAnnotator::RunTask [0x6F116BF7+1447] (o:\base\task\common\task_annotator.cc:144) base::internal::TaskTracker::RunSkipOnShutdown [0x6F1A354D+61] (o:\base\task\thread_pool\task_tracker.cc:778) base::internal::TaskTracker::RunTaskWithShutdownBehavior [0x6F1A2C1C+108] (o:\base\task\thread_pool\task_tracker.cc:796) base::internal::TaskTracker::RunTask [0x6F1A2289+2521] (o:\base\task\thread_pool\task_tracker.cc:639) base::internal::TaskTracker::RunAndPopNextTask [0x6F1A0FA6+598] (o:\base\task\thread_pool\task_tracker.cc:512) base::internal::WorkerThread::RunWorker [0x6F1C47CE+2270] (o:\base\task\thread_pool\worker_thread.cc:321) base::internal::WorkerThread::RunSharedCOMWorker [0x6F1C3E92+34] (o:\base\task\thread_pool\worker_thread.cc:261) base::internal::WorkerThread::ThreadMain [0x6F1C3C3A+250] (o:\base\task\thread_pool\worker_thread.cc:213) base::`anonymous namespace'::ThreadFunc [0x6F2CCF4D+301] (o:\base\threading\platform_thread_win.cc:112) BaseThreadInitThunk [0x7740343D+18] RtlInitializeExceptionChain [0x77919802+99] RtlInitializeExceptionChain [0x779197D5+54] Task trace: Backtrace: aura::NativeWindowOcclusionTrackerWin::WindowOcclusionCalculator::ScheduleOcclusionCalculationIfNeeded [0x647DF4F2+290] (o:\ui\aura\native_window_occlusion_tracker_win.cc:433) aura::NativeWindowOcclusionTrackerWin::WindowOcclusionCalculator::ProcessEventHookCallback [0x647DFBB4+324] (o:\ui\aura\native_window_occlusion_tracker_win.cc:600) Original change's description: > Use unoccluded desktop region to calculate root window occlusion. > > Bug: 1029842 > Change-Id: I285c8dec077575ce246c476645e2ff4a3294124c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951775 > Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#725750} TBR=chrisha@chromium.org,fdoray@chromium.org,davidbienvenu@chromium.org Change-Id: I3de865e1e2bfbc0178f117ff5756394b52f1de88 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1029842 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974052Reviewed-by:
-
Kaan Alsan authored
When the currently snapped area's offset is a float number it would not get ignored when exectuing a directional scroll. This happened because the scrollable area's current scroll offset would be rounded, while the snap area's position offset was not. Now when DirectionStrategy compares the snap area's offset to the the current offset for determining whether to snap, it will round the difference to an int. Bug: 959859,989738 Change-Id: I41f79182e923ea7104f678142d9fc4e971a3b881 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969052Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Kaan Alsan <alsan@google.com> Cr-Commit-Position: refs/heads/master@{#725992}
-
Nodir Turakulov authored
Add a fully-qualified target name, e.g. "//chrome/test:browser_tests" in additional non-fully qualified target "browser_tests". This will be used for the new test result storage. Bug: 1033761 Change-Id: Ic58221ab01931162ed44f0be3db0469f22a6d598 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972572 Commit-Queue: Nodir Turakulov <nodir@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#725991}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e6a2ad81ab40..8d97c155be33 git log e6a2ad81ab40..8d97c155be33 --date=short --first-parent --format='%ad %ae %s' 2019-12-18 bsalomon@google.com Remove SkRuntimeEffect.h include from SkColorFilterPriv.h Created with: gclient setdep -r src/third_party/skia@8d97c155be33 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: borenet@google.com Change-Id: I93da70cf39fcc832a369ce3db82c133623dd4b82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973941Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#725990}
-
Francois Doray authored
https://crbug.com/1032348 tells us that there are browsers with no active tab in some cases when --restore-last-session is specified. To get a better undertanding of the problem, this CL adds a CHECK to get a crash report if a Browser doesn't have an active tab at the end of SessionRestoreImpl::ProcessSessionWindows(). Bug: 1032348 Change-Id: Ic6919429ba9a1ece3a21230c0d63c9d2bb2a79bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966523 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#725989}
-
Sasha McIntosh authored
Allow individual buckets for recording the 1-10KB range of small memory metrics. For some metrics like Memory.Experimental.Gpu2.Small.ServiceDiscardableManager the 0-10KB bucket captures 88% of samples. This change affects all Memory.Experimental.*.Small.* metrics. Change-Id: I47faf6060f82642ea20438e57e9563d01e6e949e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940450Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Sasha McIntosh <sashamcintosh@chromium.org> Cr-Commit-Position: refs/heads/master@{#725988}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Id3477c6bb3b2d2f07ca40f951404e46217eee746 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973942Reviewed-by:
-
Ken Rockot authored
Migrates some directories off of deprecated base::Bind, base::Callback, etc, and onto the newer APIs. Specifically this covers: - components/services/ - components/signin/ - components/sync_preferences/ Fixed: 1007742, 1007733, 1007731 Change-Id: I38a1ef61cd324d5a4d220ada708c0c524368387a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972510Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#725986}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/4399459c1920..82a9846c4377 git log 4399459c1920..82a9846c4377 --date=short --first-parent --format='%ad %ae %s' 2019-12-18 rharrison@google.com Adding in missing APIs for MSL support in Dawn (#943) Created with: gclient setdep -r src/third_party/shaderc/src@82a9846c4377 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com Change-Id: I9882c1813526c43e80b609ef7c95512cdf60c975 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973939Reviewed-by:
-
Elly Fong-Jones authored
Bug: 859169 Change-Id: Ia13d5991de4fc8a580309c129da2bd0a2dca4f95 Tbr: wangxianzhu@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972758Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/f5a3b2d93548..c58ff87e3200 git log f5a3b2d93548..c58ff87e3200 --date=short --first-parent --format='%ad %ae %s' 2019-12-18 vapier@chromium.org cros_portage_upgrade: switch RunGit API to stdout/stderr names 2019-12-18 saklein@chromium.org Sdk/Update: Switch separatedebug to splitdebug. 2019-12-17 dhanyaganesh@chromium.org chromeos_config: Disable HW tests on veyron_rialto-release 2019-12-17 dhanyaganesh@chromium.org cros_test: self.tast is an array of size 1 2019-12-17 vapier@chromium.org cbuildbot: disable blamelist on Android PFQs 2019-12-17 tcwang@google.com chromeos_config: Remove AFDO generate and uprev from branch PFQ builder. 2019-12-17 vapier@chromium.org signing: imagefile: fix delete test under Python 3.7 2019-12-17 engeg@google.com OWNERS: add engeg 2019-12-17 dburger@chromium.org Extract goma extra env common to in / out chroot to helper. 2019-12-17 tomhughes@chromium.org config: Make hatch release builds sign accessory_rwsig Created with: gclient setdep -r src/third_party/chromite@c58ff87e3200 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: I82e7b45d6d5c26fe1565c2d054efe874cf2abcad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973937Reviewed-by:
-
Elly Fong-Jones authored
Bug: 1035439 Change-Id: I60754b95ffd6c8bc4584ceaf7e80b95cec325c21 Tbr: danan@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973048Reviewed-by:
-
Michael Thiessen authored
Reason for revert: Broke Linux MSan Tests. See https://ci.chromium.org/p/chromium/builders/ci/Linux%20MSan%20Tests/21213 for first failing build. Reland fixes uninitialized variable in shell/common/shell_content_client.h Original change's description: > Decouple Scheme Registration from ContentMain > > Split off of > https://chromium-review.googlesource.com/c/chromium/src/+/1901591, see > that CL (and the bug) for additional context. > > The followup to this CL locks the SchemeRegistry on first use to ensure > schemes aren't added after GURL is used (which could lead to bugs). This > means that Scheme initialization must happen before ContentMain in order > for Java to use GURL before running ContentMain (I set the ContentClient > in JNI_Onload, and register schemes after the CommandLine is initialized > in content library_loader_hooks). > > Because of that, ContentMainDelegate had to have a ContentClient > available earlier, so I added an API to ContentMainDelegate for the > embedder to create their ContentClient on-demand. > > Because I wanted to avoid registering schemes multiple times, > url_schemes.cc had to be made stateful and remember whether schemes had > already been registered (Schemes could be registered by ContentMain > after JNI_Onload already registered them for Android). > > Doc: https://docs.google.com/document/d/1kDKqBaq-b6EbUm0F4ea7ARoksUcj1KUx3qxFuSXEwM4/edit > > Bug: 783819 > Change-Id: I0f6884b2def87dcca77e722cd3d3800017c18749 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945926 > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Albert J. Wong <ajwong@chromium.org> > Commit-Queue: Michael Thiessen <mthiesse@chromium.org> > Cr-Commit-Position: refs/heads/master@{#725799} TBR=ajwong@chromium.org,mthiesse@chromium.org,jam@chromium.org Change-Id: I27a2a49dc23610350ec9f3f96ed9824e2eeed0d5 Bug: 783819 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973198 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#725981}
-
Henrique Nakashima authored
Cleanup code is not necessary anymore as long as the key is not used. Bug: 1022108 Change-Id: Ia3e6a8f7ec489fcc2e69caa511809a95525af317 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972783Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#725980}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/0a3fbd76a9e7..24f39c439784 git log 0a3fbd76a9e7..24f39c439784 --date=short --first-parent --format='%ad %ae %s' 2019-12-18 aerotwist@chromium.org Enables Karma to load images 2019-12-18 sigurds@chromium.org [timeline] Don't offer stop option during profiler initialization Created with: gclient setdep -r src/third_party/devtools-frontend/src@24f39c439784 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1013624 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4421ae515195a9e4ffdae562f53849c16751ac9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973940Reviewed-by:
-
Jonathan Backer authored
The clients of SharedContextState (OOP-R, SharedImage, and SkiaRenderer) do not care which GLSurface is bound as default FBO in the common case. Changing the current surface has a non-trivial cost on Android Adreno devices, even with virtual contexts enabled. This CL does a bit of caching to avoid these unnecessary calls. Change-Id: I0e3ec6308659644a725723295ef0b3109f22794f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969736 Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#725978}
-
Yue Zhang authored
Bug: 1033970 Change-Id: Ie613cdad54be7153a184c1babd8344660a950233 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972942Reviewed-by:
-
Mila Green authored
Add a new executable to the mac updater project. It copies the bundle to the appropriate ~/Library location and creates a launchd item to run "GoogleUpdate --ua" every 5 hours. Bug: 1031293 Change-Id: I02026497d31c5ca8739ffede4d86252e6ab55492 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954549 Commit-Queue: Mila Green <milagreen@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#725976}
-
Elly Fong-Jones authored
This test is flaky under asan & tsan. Bug: 1029250 Change-Id: I9fd12f89cafdd0d01de1b59941f7d0bf07212c1a Tbr: bokan@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972503Reviewed-by:
-
James Cook authored
Chrome OS sync and browser sync can both be encrypted with a shared passphrase. However, a user can choose to leave OS sync enabled and browser sync disabled, or vice versa. Show the sync passphrase error notification when either feature is enabled. Bug: 1033222, 1013466 Test: updated unit_tests Change-Id: If4b8eddb76f7c9be1de3a7f094c692b2d03b7c6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972899 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#725974}
-
Eugene But authored
Add semi colon to avoid breaking Xcode indexing. Bug: 1015113 Change-Id: I9dff5b679b24267e3edc0ac83ce5f52a294ded9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972938 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#725973}
-
Raymond Toy authored
Change destroy_cb_ to be base::OnceClosure Bug: 1007799 Change-Id: I86335290007d31af994d7ddf22c536645aea6595 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972934 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#725972}
-
Clemens Arbesser authored
Before this CL, if no cc network filtering was specified, all credit cards would be rejected. Bug: b/146424039 Change-Id: I49e0013b8dce9deb255fcb7549bdccd0c57264fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973819 Auto-Submit: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#725971}
-
Mitsuru Oshima authored
Bug: 1034078, Test: Covered by unittest Change-Id: If9dd8a777b83a02e572c2f1953e70e5ce6d4a439 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1968241 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#725970}
-
Elly Fong-Jones authored
Bug: 1029778 Change-Id: Icc3de412daa929da50c8aef9f2d5792f6a336538 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972306Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#725969}
-
Etienne Bergeron authored
This CL is fixing the regression in selection drawing (see crbug/1033829). The bug is caused by an incorrect handling of selection_color(...). The color is applied twice. The selection color should only applied while drawing to avoid re-doing the layout when selection changed. The code of RenderText::Draw(...) is taking into account the selection and is drawing the text in the right color. The selection color should *not* be copied in the |layout_colors_|. To be able to test this code, this CL is also adding a test_api::Draw(...) and a way to mock calls to the canvas. Previously, the test used DrawVisualText(...) and a mock version of class SkiaTextRenderer. Unfortunately, that code doesn't handle the selection. The Draw(...) test API is using the same TextLog class. Bug: 1033829, 1025561 Change-Id: Ia84c5c03ed33675dbf3a04b0359b65b21dba323e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972814 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
-
Antonio Gomes authored
... to use the corresponding WTF constructions. BUG=787254 R=haraken@chromium.org Change-Id: I195720eba44a4ba96f9b82b7ebb3684a1fa3349e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973992Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#725967}
-
Francois Doray authored
Failures were due to a race in Mojo notifications for renderer tear-down and setup. Let's see if the problem still exists. Bug: 874851 Change-Id: Ia28012b8189a5236879abf444bac9295d9159453 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972532 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ddd35ae7e933..a8a5c96f0b89 Created with: gclient setdep -r src-internal@a8a5c96f0b89 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I977ff88397c8783f2c69169a745e6f07de7bafe5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973935Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#725965}
-
Kaan Alsan authored
This is a speculative fix to try to deflake the layout test on Mac. Bug: 1034789 Change-Id: I8fff3f743f079ec593fb76f6797f7dc955022aab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973960Reviewed-by:
-
Matt Menke authored
Previously, it would make NetworkIsolationKeys replace hostnames with eTLD+1's regardless of scheme. Bug: 1030824 Change-Id: I79889920ed99f8d13d7a470e6aa2b2f7ac480f6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972577Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#725963}
-
