- 30 Nov, 2018 40 commits
-
-
Giovanni Ortuño Urquidi authored
This reverts commit b74b9644. Reason for revert: ios_chrome_web_egtests failing https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/ios-slimnav/465 ../../ios/chrome/browser/web/tab_order_egtest.mm:74: error: -[TabOrderTestCase testChildTabOrdering] : Exception: ActionFailedException Exception Name: ActionFailedException Exception Reason: An action failed. Please refer to the error trace below. Exception with Action: { "Action Name": "Locate element bounds", "Element Matcher": "web view in web state" } Exception Details: Error Trace: [ { "Description": "Couldn't locate a bounding rect for element with ID normal-link; either it isn't there or it has no area.", "Error Domain": "com.google.earlgrey.ElementInteractionErrorDomain", "Error Code": "2" } ] Bundle ID: org.chromium.gtest.generic-unit-test Original change's description: > [ios] Remove forward swipe for reading list. > > Bug: 909724 > Change-Id: I24c3341ca5245d599ce43cba8b17c164e38e3618 > Reviewed-on: https://chromium-review.googlesource.com/c/1354414 > Commit-Queue: Justin Cohen <justincohen@chromium.org> > Reviewed-by: Olivier Robin <olivierrobin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#612291} TBR=justincohen@chromium.org,olivierrobin@chromium.org Change-Id: I3b9b6b9b2a61eaaa11924b5b3e189034831c59d0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 909724 Reviewed-on: https://chromium-review.googlesource.com/c/1356176Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#612568}
-
Takashi Toyoshima authored
This patch makes BrowserContext manages per-profile CORS access lists even if NetworkService is enabled, and use it to setup initial access lists for the non-primary NetworkContext. It will also work for restoring per-profile CORS settings on network service restarts. This patch makes following tests work even with --enable-features=OutOfBlinkCors,NetworkService. - CrossOriginReadBlockingExtensionTest.ProgrammaticContentScriptVsAppCache - CrossOriginReadBlockingExtensionTest.WebViewContentScript - ExtensionWebRequestApiTest.ExtensionRequests - PlatformAppBrowserTest.Isolation Bug: 908324, 891891 Change-Id: Ib0cfc2f5633f25187366a4d7d63168d60ea51f71 Reviewed-on: https://chromium-review.googlesource.com/c/1351208Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#612567}
-
Andrew Grieve authored
This reverts commit 8adb2d69. Reason for reland: Fixed the bug :) > Original change's description: > > Cronet: Simplify repackage rules > > > > * Use dist_jar() rather than a custom script > > * Avoids needing to extract .jars. > > * Avoids needing to reference ".javac.jar" files, which > > are somewhat of an implementation detail. > > > > * Added jar_excluded_patterns support to dist_jar() > > > > * Merges zip.py and dist_jar.py, since they were doing the > > same thing. > > > > Spot checked that these two jars are the same before/after: > > * cronet/cronet_impl_common_java.jar > > * cronet/cronet_impl_native_java.jar > > TBR=pauljensen@chromium.org,agrieve@chromium.org,estevenson@chromium.org Bug: 910311 Change-Id: I87508b663d3747a1d0b367cdddb1b19e2f02ef8f Reviewed-on: https://chromium-review.googlesource.com/c/1356138 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#612566}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/dd530811aba9..457b44f3cd29 git log dd530811aba9..457b44f3cd29 --date=short --no-merges --format='%ad %ae %s' 2018-11-30 recipe-roller@chromium.org Roll recipe dependencies (nontrivial). Created with: gclient setdep -r src/third_party/depot_tools@457b44f3cd29 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I2ec7b71c5e62214778330fa53407dc489487cf9f Reviewed-on: https://chromium-review.googlesource.com/c/1356380Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612565}
-
Moe Ahmadi authored
- Adds a feature and corresponding flags in order to gate the integration. - Modifies ARQuickLookTabHelper to inform delegate only if download was successful. - Hooks up ARQuickLookTabHelper in DownloadServiceManager. - Sets up ARQuickLookCoordinator and ARQuickLookTabHelper in browser coordinator. - Replaces the test USDZ file with a smaller one. - Adds EG tests. Bug: 908696 Change-Id: I37482d356b2e5db5ac09f46df957a3b0cdc48879 Reviewed-on: https://chromium-review.googlesource.com/c/1351980 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#612564}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 5dcf57f5. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=kyleju No-Export: true Change-Id: I8cc0905c42dadfdb85ad346341e028534d559e97 Reviewed-on: https://chromium-review.googlesource.com/c/1356327 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612563}
-
Kent Tamura authored
Bug: 622551 Change-Id: I2d1911ef91081777978ea1a0fb45280434b2a5f5 Reviewed-on: https://chromium-review.googlesource.com/c/1351983 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#612562}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/0de9e8166ee4..ae7e8f53c6eb git log 0de9e8166ee4..ae7e8f53c6eb --date=short --no-merges --format='%ad %ae %s' 2018-11-30 ahassani@chromium.org chroot_util: bring TempDirInchroot from moblab_vm.py 2018-11-30 achuith@chromium.org cros_run_vm_test: Move to lib/cros_test.py 2018-11-30 wonderfly@google.com chromeos_config: Add a lakitu-master-release 2018-11-30 wonderfly@google.com chromite: Fix spacing and the use of terms Created with: gclient setdep -r src/third_party/chromite@ae7e8f53c6eb The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I66154a7782966dcb5a66ecabf6d052d540319c62 Reviewed-on: https://chromium-review.googlesource.com/c/1356379Reviewed-by:
-
Jun Choi authored
Add dialog before BLE device selection view instructing the user to begin pairing process. Bug: 877344 Change-Id: I9f8bf8b011231a20a09ebbb2ab8073792df276ef Reviewed-on: https://chromium-review.googlesource.com/c/1356122 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#612560}
-
Matt Reynolds authored
Adds HidHapticGamepadBase and platform-specific implementations for win/mac/linux. HidHapticGamepadBase allows HID gamepads with simple output reports to handle vibration commands generated through the Gamepad API. BUG=910296 Change-Id: I38fa4d4ee1f14ccf94fafd88d400aac869d00195 Reviewed-on: https://chromium-review.googlesource.com/c/1354650 Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Ovidio Henriquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#612559}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/63d69d7792c1..1b98245e3cb7 git log 63d69d7792c1..1b98245e3cb7 --date=short --no-merges --format='%ad %ae %s' 2018-11-30 dpranke@chromium.org Move typ's expectation-processing code into expectations_parser.py. Created with: gclient setdep -r src/third_party/catapult@1b98245e3cb7 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:835690 TBR=sullivan@chromium.org Change-Id: I55c7cfc5493c487cb0e0a0eebb63b2bf0ce9e35f Reviewed-on: https://chromium-review.googlesource.com/c/1356236Reviewed-by:
-
Sam McNally authored
Bug: 909056 Change-Id: I8fbfc11a3076c014cf20d711d82fea36183c0792 Reviewed-on: https://chromium-review.googlesource.com/c/1356171 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#612557}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: I3425ada8dfe3c3e3376827f3db98260b6bc0760e Reviewed-on: https://chromium-review.googlesource.com/c/1356266Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#612556}
-
Joel Hockey authored
To be used in tast test: https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/1351973 * Added chrome.fileManagerPrivate.unsharePathWithCrostini. This function complements the existing fileManagerPrivate.sharePathsWithCrostini. * Added util.getEntries which returns a Promise with an object of all entries of a provided volume keyed by fullPath. This is a handy wrapper over the existing util.readEntriesRecursively. Bug: 907231 Change-Id: Ieccdc76a6457fed44d85633e9a02c658424b967d Reviewed-on: https://chromium-review.googlesource.com/c/1354755Reviewed-by:
Stuart Langley <slangley@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#612555}
-
Scott Little authored
This CL adds support for restricting the lazy loading of frames and images separately by field trial parameters. For lazy image loading, to avoid the performance hit from repeatedly locking the mutex in NetworkStateNotifier, the value of NetworkStateNotifier::SaveDataEnabled() is queried once for each frame and used for all images in that frame. Bug: 901571 Change-Id: Ic08416ebe40b6377d5c383616b4f0ceff920637a Reviewed-on: https://chromium-review.googlesource.com/c/1354694 Commit-Queue: Scott Little <sclittle@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#612554}
-
Dominic Farolino authored
Remove ResourceResponse::{AppendRedirectResponses, RedirectResponses} and usages of them, because they are never called in the codebase. Change-Id: Id1c78939b8ab1fc5cdabc044f426fee09cecc1ba Reviewed-on: https://chromium-review.googlesource.com/c/1348738 Commit-Queue: Dominic Farolino <domfarolino@gmail.com> Reviewed-by: -
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/f737d4bdb38d..75a486e0a03a git log f737d4bdb38d..75a486e0a03a --date=short --no-merges --format='%ad %ae %s' 2018-11-30 thestig@chromium.org Export defines to dependents of the "pdfium" target. 2018-11-29 thestig@chromium.org Bump up |kMaxObjectNumber|. 2018-11-29 thestig@chromium.org Make CBC_SymbolInfo::Lookup() return a const pointer. 2018-11-29 thestig@chromium.org Fix WideString() vs {} confusion in fxbarcode. Created with: gclient setdep -r src/third_party/pdfium@75a486e0a03a The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:910009,chromium:910198 TBR=dsinclair@chromium.org Change-Id: I84cd9d7ccecc0acb72b8e8fe91394b486affea8f Reviewed-on: https://chromium-review.googlesource.com/c/1356130Reviewed-by:
-
Kent Tamura authored
Form-associated custom elements should support 'disabled' content attribute and <fieldset disabled> ancestors. It affects form submission, focusability, :disabled :enabled CSS selectors. Implementation: - HTMLElement::IsDisabledFormControl() is hooked to refer to ListedElement::IsActuallyDisabled(). This affects :disabled selector. - HTMLElement::MatchesEnabledPseudoClass() is hooked to support :enabled selector. - HTMLElement::AttributeChanged() handles 'disabled' attribute change. - HTMLElement::SupportsFocus() takes into account IsDisabledFormControl() - ElementInternals::AppendToFormData() aborts if IsDisabledFOrmControl(). - HTMLFieldSetElement should handle form-associated custom elements as well as HTMLFormControlElements. - Form-associated checks in ElementInternals is updated so that SetFormValue() and 'form' work in constructors. Note that 'disabledStateChangedCallback' will be implemented by a following CL. Bug: 905922 Bug: https://github.com/w3c/webcomponents/issues/187 Change-Id: If4a348b6f3fec5cd6faab6da04ac2de1c228caf7 Reviewed-on: https://chromium-review.googlesource.com/c/1354752Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#612551}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2913923e0dae..f7089e1b9227 Created with: gclient setdep -r src-internal@f7089e1b9227 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I7f9981d4589099b6e997c934720e4ee88514f964 Reviewed-on: https://chromium-review.googlesource.com/c/1356111Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612550}
-
Sam McNally authored
Bug: 909056 Change-Id: I6ed186ccb13a6373c8ed0ef559a30892cc89dd1c Reviewed-on: https://chromium-review.googlesource.com/c/1356169 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#612549}
-
Hayato Ito authored
While in working on the WIP CL, https://crrev.com/c/1350441, I've found that there is an edge case where fast flat tree traversal might return dirty result. So it would be safe to guard the feature of fast flat tree traversal by the runtime flag, and continue to develop under the flag. This CL is basically rewriting the following two CLs with runtime flag, - https://crrev.com/c/1337225 - https://crrev.com/c/1341744 and bring back old code which runs when the flag is disabled. BUG: 906494 Change-Id: I7a1940643925c1ef583cf55f1a79bfa0190ef40c Reviewed-on: https://chromium-review.googlesource.com/c/1356167Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#612548}
-
Pavel Feldman authored
Change-Id: I12c8ed2052b171ab91658fd9f734117f18fc826b Reviewed-on: https://chromium-review.googlesource.com/c/1354688Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#612547}
-
Meilin Wang authored
Add a new UMA histogram metrics to record the number of button clicks on Assistant UI (close, minimize, back, keyboard input toggle, voice input toggle, settings). Test: local compile and manually test. Change-Id: Ie3959d32b728f02aa6207740d56b3e21f87219c3 Reviewed-on: https://chromium-review.googlesource.com/c/1318837 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#612546}
-
Martin Kreichgauer authored
This is a refactoring followup to https://chromium-review.googlesource.com/c/chromium/src/+/1356223/. Change-Id: Ic92c73908914f49a38cae1192dcf054901018430 Reviewed-on: https://chromium-review.googlesource.com/c/1356134Reviewed-by:
Adam Langley <agl@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#612545}
-
Tom Anderson authored
R=thakis,dpranke Bug: 110002 Change-Id: I8da8e50930e973bd4bfac261571a66b7bad92778 Cq-Include-Trybots: luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng;luci.chromium.try:win_archive;luci.chromium.try:win_x64_archive;master.tryserver.chromium.android:android_archive_rel_ng Reviewed-on: https://chromium-review.googlesource.com/c/1351716 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#612544}
-
Matt Falkenhagen authored
A virtual test was already marked as flaky, but the root test itself is also flaky. Bug: 910452 Change-Id: I579264a4b6ef4bab235028d1bce46ceeded8481d TBR: mlamouri No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1355309Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#612543}
-
Maggie Chen authored
UMA GPU.DirectComposition.SwapChainCreationResult3 with different protected video types are created to record the pass/fail status for protected video swap chain creation. Bug: 906722 Change-Id: I558ec85ba75db030f86bd1a11c19410ff391d35c Reviewed-on: https://chromium-review.googlesource.com/c/1352053Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
-
Jan Wilken Dörrie authored
This change introduces a new Autofill section into the Chrome settings UI. This section contains "Passwords", "Payment Methods" and "Addresses and more", which prior to this change were part of the People section. In particular, this change: - Renames passwords_and_forms_page to autofill_page - Moves autofill entries from people_page.html to autofill_page.html - Adds a chrome://settings/autofill route for the new section, renaming the previously existing autofill route to chrome://settings/addresses - Removes the kAutofillHome feature flag and related conditionals - Removes a few now obsolete strings from settings_strings.grdp Bug: 907035, 854562 Change-Id: I479841db651c23813ab1ac1525f712d0ff9266c2 Reviewed-on: https://chromium-review.googlesource.com/c/1348039Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#612541}
-
Kent Tamura authored
Change-Id: Ib559e2a6cbc1e91c545f598050399bdd03053e19 Bug: 843412 Reviewed-on: https://chromium-review.googlesource.com/c/1354799 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
iOS Autoroller authored
TBR=smut Change-Id: Ie8510ff0de91ae4699d532e3657cfdfad4436de3 Reviewed-on: https://chromium-review.googlesource.com/c/1356031Reviewed-by:
iOS Autoroller <ios-autoroller@chromium.org> Commit-Queue: iOS Autoroller <ios-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#612539}
-
Kurt Horimoto authored
FullscreenModel knows enough information to calculate these insets, so it makes sense for the calculation to occur there. Exposing the viewport insets in FullscreenController will allow chrome/ layer UI code to easily account for viewport adjustments. This API will be used to mask non-modal UIAlertController presentation. Bug: 674649 Change-Id: I469cb133ef5d27bffcd4de5070bd12820514740e Reviewed-on: https://chromium-review.googlesource.com/c/1339460 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#612538}
-
Sam McNally authored
Bug: 909056 Change-Id: If6daa91932bad99510e267ef91cc6808bceeccfa Reviewed-on: https://chromium-review.googlesource.com/c/1356162 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
-
Kent Tamura authored
TBR=hiroshige@chromium.org Bug: 910139 No-Try: true Change-Id: Id37fd777ff192446fd37a1eec58f298b82334ca8 Reviewed-on: https://chromium-review.googlesource.com/c/1356170 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Sammie Quon authored
Overview will show all windows related by transient on the same thumbnail. Currently we will get blank spaces since the MRU list may contain two windows related by transient, and the transient ancestor or descendant of the most recent window will get transformed onto the transient related windows thumbnail, leaving a blank space. Introduce a function which removes all transient descendants from a given list if their transient root exists in the same list. First usage is overview but may need to extend to alt tab in future. Test: ash_unittests WindowUtilTest.RemoveTransientDescendants Bug: 844829 Change-Id: Ic2f9b476bc353b50a197be8fcf7bb3f2e3d44c49 Reviewed-on: https://chromium-review.googlesource.com/c/1355249 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#612535}
-
Klaus Weidner authored
BUG=809826 Change-Id: I41250680f22aacac2c1f193276d5d0e0beaa2a00 Reviewed-on: https://chromium-review.googlesource.com/c/1356228Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#612534}
-
Martin Kreichgauer authored
In [0], the U2F spec says to default the App ID to the originating site's Facet ID, which is (with some ambiguity) defined as the origin followed by a forward slash [1]. Firefox and cryptotoken, on the other hand, default the App ID to just the origin without any trailing path component. This change aligns Chrome's behavior for App IDs in WebAuthn with that of cryptotoken and Firefox. Also adds a check to ensure requests originating from cryptotoken do not have an empty App ID because they cannot be defaulted in any meaningful way. [0] https://fidoalliance.org/specs/fido-v2.0-id-20180227/fido-appid-and-facets-v2.0-id-20180227.html#determining-if-a-caller-s-facetid-is-authorized-for-an-appid [1] https://fidoalliance.org/specs/fido-v2.0-id-20180227/fido-appid-and-facets-v2.0-id-20180227.html#determining-the-facetid-of-a-calling-application Change-Id: Iab2c18f03fb92a150b00a56a1c39490e52188e0e Reviewed-on: https://chromium-review.googlesource.com/c/1356223 Commit-Queue: Martin Kreichgauer <martinkr@chromium.org> Reviewed-by:
-
Sam McNally authored
Bug: 909056 Change-Id: I0134351962bb3332f90f9430751241f0bf6c2eb5 Reviewed-on: https://chromium-review.googlesource.com/c/1355304Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a8224556fcd5..2913923e0dae Created with: gclient setdep -r src-internal@2913923e0dae The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=mmoss@chromium.org Change-Id: Iceaec0eb03d97ed599a7d10e7cb91c00a15e71dd Reviewed-on: https://chromium-review.googlesource.com/c/1356127Reviewed-by:
-
Sam McNally authored
Bug: 909056 Change-Id: Ic571f2d16d9d906bc176d34f539e53f57b2acbb3 Reviewed-on: https://chromium-review.googlesource.com/c/1355301Reviewed-by:
-
Giovanni Ortuño Urquidi authored
The ArrayTraits specialization for base::span with a specified size was considered to be missing. This caused accessors in mojom traits that returned a base::span with a specified size to fail to compile with: error: static_assert failed due to requirement 'internal::AlwaysFalse<span<const unsigned char, 6> >::value' "Cannot find the mojo::ArrayTraits specialization. Did you forget to include the corresponding header file?" Change-Id: I61ab07f2a1f74ea2eb5073b2776c995ce86b6255 Reviewed-on: https://chromium-review.googlesource.com/c/1356159 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#612529}
-
