GitLab

TBR=sky@chromium.org
BUG=383408

Review URL: https://codereview.chromium.org/334443004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276456 0039d316-1c4b-4281-b951-d872f2087c98

BUG=372381

Review URL: https://codereview.chromium.org/316813002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276452 0039d316-1c4b-4281-b951-d872f2087c98

Classes of errors tackled: whitespace, include-what-you-use, explicit
constructors, parameter names, include guards, bracing, and one
use of "unsigned long" in IPC.

This does not tackle use of non-const references, since those should
be carefully reviewed and affects the callers. Also, several uses
of "long" remain in content/child when implementing Blink interfaces.

R=cmumford@chromium.org,ericu@chromium.org,tsepez@chromium.org
BUG=381456

Review URL: https://codereview.chromium.org/311263014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276451 0039d316-1c4b-4281-b951-d872f2087c98

Add a Label view to Tab for displaying the title.
Remove Tab::PaintTitle, bounds and font members.
Remove unnecessary Tab::Get[Title|Icon]Bounds helpers.
Update the text on Tab::SetData, not during paint.
Use gfx::DirectionalityMode, remove the Label enum.

Add gfx::ALIGN_TO_HEAD to gfx::HorizontalAlignment.
Add Label::GetHorizontalAlignment for ALIGN_TO_HEAD.
Always flip left/right in Label::SetHorizontalAlignment.
Have Tab and MessageBoxView use ALIGN_TO_HEAD.

Update comments and tests, related minor cleanup.

TODO: Make Label cache RenderText objects.
TODO: Make RenderText support ALIGN_TO_HEAD.

BUG=240037
TEST=No visible Views tab title changes.
R=sky@chromium.org

Review URL: https://codereview.chromium.org/323993002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276450 0039d316-1c4b-4281-b951-d872f2087c98

Do not de-reference Profile on the IO thread in BrowsingDataRemover::ClearNetworkPredictorOnIOThread.

BUG=365030

Review URL: https://codereview.chromium.org/328703002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276449 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276448 0039d316-1c4b-4281-b951-d872f2087c98

BUG=313751
TBR=glider@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/325253002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276447 0039d316-1c4b-4281-b951-d872f2087c98

Please reply to the V8 sheriff mstarzinger@chromium.org in case of problems.

TBR=mstarzinger@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/323333002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276446 0039d316-1c4b-4281-b951-d872f2087c98

We need it for the "Remote unsync" project. If user accidentally signed-in in the library then he should be able to clean his passwords. date_synced designates the time the password was downloaded from the sync server. All passwords with (date_synced >= sign-in time) are to be deleted.

BUG=362679

Review URL: https://codereview.chromium.org/316243002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276445 0039d316-1c4b-4281-b951-d872f2087c98

Move //chrome/common/thumbnail_score.{cc,h} into history component
Since it does not depends on anything outside of //base and there
is no plan to componentize thumbnails, it can be moved to
//components/history/core/common

BUG=372363
TEST=unit_tests --gtest_filter=Thumb*
R=sdefresne,blundell,sky

Review URL: https://codereview.chromium.org/304273010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276444 0039d316-1c4b-4281-b951-d872f2087c98

They are not used in test or for troubleshooting.

BUG=382976
R=rlarocque@chromium.org

Review URL: https://codereview.chromium.org/323133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276442 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276440 0039d316-1c4b-4281-b951-d872f2087c98

Double-clicking is broken because we didn't hit the repeat count path.
Someday we will not have NativeEvent and this insanity will go away.

BUG=323965
TEST=link_freon double clicking
NOTRY=true

Review URL: https://codereview.chromium.org/319133006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276438 0039d316-1c4b-4281-b951-d872f2087c98

It turned out that we should update the focused text input client not only when native focus/blur but also when native activate/deactivate.

See crbug.com/377479 for details.

Also this CL fixes the initial text input focus on CrOS login screen.

BUG=323376,290701
TEST=Confirmed that the Omnibox gets the text input focus by default when a new window is created.

Review URL: https://codereview.chromium.org/294023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276437 0039d316-1c4b-4281-b951-d872f2087c98

App shims are now created for ephemeral apps in the user data directory
to ensure that they have dock icons. App shims are not copied to the
Applications folder as ephemeral apps should be hidden from the OS.

BUG=375027
TEST=Launch an app ephemerally and ensure it has a dock icon, but does
not appear in Spotlight search results. Install the app fully and
ensure it now has both a dock icon and appears in Spotlight.

Review URL: https://codereview.chromium.org/311293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276436 0039d316-1c4b-4281-b951-d872f2087c98

This domain is getting turned down.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276434 0039d316-1c4b-4281-b951-d872f2087c98

Fetching remaining space is not implemented yet, hence we should not show the
indicator in Files app for provided file systems.

Note, that since provided file systems are read only, there is no actual need
for this feature.

This is temporary. Once the R/W support is added, we should bring back the
indicator.

TEST=Tested manually with experimental providing extensions.
BUG=375020

Review URL: https://codereview.chromium.org/324253003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276433 0039d316-1c4b-4281-b951-d872f2087c98

TBR=samuong

Review URL: https://codereview.chromium.org/323383004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276431 0039d316-1c4b-4281-b951-d872f2087c98

Along the way, it fixes the filter regexp so that ("txt") will
not match "foo.xtxt", etc.

BUG=373659

Review URL: https://codereview.chromium.org/329763003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276430 0039d316-1c4b-4281-b951-d872f2087c98

Previously, it would persist logs in uncompressed form. 
This CL changes the code to compress logs before they're 
saved. A new pair of prefs is introduced for storing 
these logs, while reading from the old pref is still 
maintained to not lose old logs. 

Additionally, this makes the metrics log discard limit 
(currently 50k) be checked against the compressed size 
rather than the uncompressed size. 

Simplifies the format used to store logs, now simply 
storing the compressed log bytes and corresponding hash 
for each log. The size and checksum fields are removed. 
(Size was redundant while the checksum is not no longer 
necessary now that we store the log hash.) 

Deletes some tests that inspected the actual pref 
values are removed, in favor of tests that check that 
serializing and de-serializing works as expected. 

Finally, also introduces GzipUncompress() that is 
needed for tests that inspect log manager logs. 

BUG=382076
TBR=agl@chromium.org

Review URL: https://codereview.chromium.org/318203004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276429 0039d316-1c4b-4281-b951-d872f2087c98

This adds a unit test that would fail after landing
the https://codereview.chromium.org/287193003 CL without any further
changes, documenting one regression it caused.

R=brianderson, enne
BUG=376649,374287

Review URL: https://codereview.chromium.org/321193002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276428 0039d316-1c4b-4281-b951-d872f2087c98

This appears to be causing the Google Chrome Win bot to have a compiler failure.
http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/builds/24886

> Enable building and output-ing of browser_tests.exe for official Windows builds.
> 
> BUG=379986
> 
> Review URL: https://codereview.chromium.org/323163003

TBR=anandc@chromium.org

Review URL: https://codereview.chromium.org/327273003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276427 0039d316-1c4b-4281-b951-d872f2087c98

BUG=347425,378621

Review URL: https://codereview.chromium.org/318353002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276422 0039d316-1c4b-4281-b951-d872f2087c98

* and replace it with ui::GetScaleForScaleFactor
* Minor simplification of if blocks in FaviconService

BUG=372212
R=ananta@chromium.org

Review URL: https://codereview.chromium.org/326143002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276421 0039d316-1c4b-4281-b951-d872f2087c98

Update API tests so they don't assume service_path == GUID

BUG=381786

TBR=mef (updated test expectations in components/wifi/fake_wifi_service.cc)

Review URL: https://codereview.chromium.org/320063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276420 0039d316-1c4b-4281-b951-d872f2087c98

Removed the App Info header from the Create Shortcuts dialog for Apps,
as requested by UI, since it is always clear which app the shortcuts
are being created for. The info still appears when creating shortcuts for
bookmark (URL) apps.

BUG=NONE

Review URL: https://codereview.chromium.org/307873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276419 0039d316-1c4b-4281-b951-d872f2087c98

This is dead code as the Blink bits were removed in
http://src.chromium.org/viewvc/blink?view=revision&revision=156126

Review URL: https://codereview.chromium.org/326823003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276417 0039d316-1c4b-4281-b951-d872f2087c98

The old organization was an attached and unattached section. With the hint text of when it was last attached this is unnecessary. The suggestions section now has all galleries that the app didn't start with permission for.

BUG=359704

Review URL: https://codereview.chromium.org/321443003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276415 0039d316-1c4b-4281-b951-d872f2087c98

This puts the existing malware & phishing text into the new security interstitial layout. Since it's not polished enough yet, this CL keeps it behind a flag.

Down the line, I'm going to want to make a new c/b/resources/security_interstitial/ folder and move all of the related SSL & SB files into there. But it doesn't make sense to do that yet, until we deprecate the older versions.

BUG=381260

Review URL: https://codereview.chromium.org/319193002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276414 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/323163004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276413 0039d316-1c4b-4281-b951-d872f2087c98

BUG=382120

Review URL: https://codereview.chromium.org/324083006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276412 0039d316-1c4b-4281-b951-d872f2087c98

Specifically:
IViewManagerInit::Connect->EmbedRoot
IViewManager::Connect->Embed

R=ben@chromium.org

Review URL: https://codereview.chromium.org/328873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276411 0039d316-1c4b-4281-b951-d872f2087c98

This simplifies a lot of code.

BUG=315312

Review URL: https://codereview.chromium.org/326433002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276410 0039d316-1c4b-4281-b951-d872f2087c98

R=sky@chromium.org
http://crbug.com/365012

Review URL: https://codereview.chromium.org/322923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276409 0039d316-1c4b-4281-b951-d872f2087c98

BUG=368721
TBR=davidben@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/332433002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276408 0039d316-1c4b-4281-b951-d872f2087c98

This policy when set will prevent the renderer process from making Win32K.sys calls via user32/gdi32 on
Windows 8 and beyond.

The following intercepts are needed for getting basic renderer functionality.
1. gdi32!GdiDllInitialize:
2. gdi32!GetStockObject.
3. user32!RegisterClassW.

The above functions are called during renderer process initialization. We intercept these APIS by
EAT patching the corresponding dlls and return fake success values from those.

The intercepts live in the process_mitigations_win32k_interception.cc/.h files. The rest of the changes
are plumbing with the sandbox policy framework.

While basic renderers work well now on Windows 8, pepper flash does not as it sends an IPC to the renderer
to creating the transport DIB. Justin is aware of this problem and thinks we can workaround this.

BUG=365160

Added gdi and user32 interceptors for the win32k lockdown project.

Review URL: https://codereview.chromium.org/318603003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276407 0039d316-1c4b-4281-b951-d872f2087c98

This function will be componentized and so cannot reference g_browser_process.
google_util::AppendGoogleLocaleToURL() will be handled in followup work.

BUG=373203

Review URL: https://codereview.chromium.org/327833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276406 0039d316-1c4b-4281-b951-d872f2087c98

Necessarily added support for mocking StreamListenSocket::GetLocalAddress.
Also cleaned up the int-to-string conversion in DevToolsHttpHandlerImpl.

BUG=382682

Review URL: https://codereview.chromium.org/319593013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276405 0039d316-1c4b-4281-b951-d872f2087c98

- No need to use scoped_ptr.get() in conditionals.
- Check return value from SharedMemory::GiveToProcess().
- Remove a NOTREACHED(), as memory sharing can fail.

Review URL: https://codereview.chromium.org/322173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276404 0039d316-1c4b-4281-b951-d872f2087c98

This takes into account test retries, and only looks
at the final result.

BUG=381733
R=sky@chromium.org

Review URL: https://codereview.chromium.org/316903003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276403 0039d316-1c4b-4281-b951-d872f2087c98