- 24 May, 2018 40 commits
-
-
Antonio Gomes authored
This CL migrates ContentHashFetcher away from URLRequestFetcher to SimpleURLLoader. In order to accomplish this, a few other related changes are also performed: 1) The regular flow of the code is ContentVerifier -> ContentHash -> ContentHashFetcher. In ContentVerifier, for instance, UI, IO and "File tasks" threads take place. Previously, the URLRequestFetcher logic residing in ContentHashFetcher executed in the "file tasks" thread. As part of the migration from URLRequestFetcher to SimpleURLLoader machinery, this CL also changes the ContentHashFetcher logic to execute to the IO thread. Note that it could be possible to keep the new SimpleURLLoader logic in the "file tasks" thread. However, this would impose a way bigger change, and require unittests to be considerably rewritten as well (see for patchsets 7, 8 and 9. The issue is that mojo objects are not thread safe. We could create a new URLLoaderFactory for the extensions thread, but then we'd need to create a new one when the network service crashes (Something this SharedURLLoaderFactory one, already bound to the IOThread, magically handles), but that would be significantly more complicated. 2) content_verifier_hash_fetch_behavior_browsertest.cc was changed to support running with the network service feature both enabled and disabled. This is a pattern that is also present in various other unittests. In summary, the migration to use SimpleURLLoader performed here includes also a change in the thread that ContentHashFetcher runs on, but no functionality change is expected from this CL. BUG=773295,844926 Change-Id: If570f69d01ff75ac59d8d043f8687621336dddcf Reviewed-on: https://chromium-review.googlesource.com/1056587 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#561480}
-
Colin Blundell authored
IdentityTestEnvironment::WaitForAccessTokenRequest* currently assume that access token requests are handled asynchronously in the production code. Specifically, they assume that in the following test flow (wherein all steps are invoked in the same iteration of the runloop): 1. Invoke production method that makes an access token request 2. Invoke WaitForAccessTokenRequest* 3. WaitForAccessTokenRequest* runs a runloop waiting for the callback that an access token request was received the callback being waited for in 3 will not occur as part of 1. We are about to change PrimaryAccountAccessTokenFetcher to handle access token requests synchronously as part of easing the migration of the codebase from SigninManager/ProfileOAuth2TokenService to IdentityManager (see crbug.com/843510 for details). To enable that change, this CL makes IdentityTestEnvironment::WaitForAccessTokenRequest* agnostic as to whether the production code handles access token requests by posting a task to query ProfileOAuth2TokenService or by calling into ProfileOAuth2TokenService synchronously. We do so by changing IdentityTestEnvironment to handle the callback that an access token request was received via a posted task, thus allowing for the above test flow to continue to work as expected even if that callback is received in step 1. We also rename the relevant methods to WaitForAccessTokenRequestIfNecessary* to reflect the new semantics. Bug: 843510 Change-Id: Iae9785ce1bdaa9d8cb64958c27e22831c3369a5c Reviewed-on: https://chromium-review.googlesource.com/1070206 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#561479}
-
Mikel Astiz authored
Prior to this patch, it was buried in GetTabNodeFromLocalTabId() which sometimes made a lookup only (if the tab ID was already associated) and some other times vended a new sync ID (via TabNodePool::AssociateWithFreeTabNode()). We refactor the APIs to surface this logic more explicitly in the only calling site, in LocalSessionEventHandlerImpl. As a bonus point, a related test is added to SessionSyncBridgeTest, which also passes prior to this patch. Bug: 843554 Change-Id: Ie9a2b136dbfb631e43d3abf2c345c07036670eb9 Reviewed-on: https://chromium-review.googlesource.com/1071572Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#561478}
-
Emilio Cobos Álvarez authored
Setting width to the same value causes style recalc to optimize out layout, so this test isn't measuring what it thinks it's measuring. Note that this change is expected to make the test slower. Bug: 845946 Change-Id: I3a5e063ec5f41f9570cf75cf33bdc31655d3d61c Reviewed-on: https://chromium-review.googlesource.com/1071627Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Emilio Cobos Álvarez <emilio@chromium.org> Cr-Commit-Position: refs/heads/master@{#561477}
-
Guido Urdaneta authored
Setting it in the same task appears to cause reentrancy issues that result in a browser crash. A test is added in a follow-up CL at https://crrev.com/c/1068683 Bug: 845142 Change-Id: I1dfe690f9fb10743dba6d2165722b9f09142496e Reviewed-on: https://chromium-review.googlesource.com/1070370 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#561476}
-
Vasilii Sukhanov authored
The class contained some functions used only on Mac. With this CL the "Update password" bubble is gone. Bug: 832676 Change-Id: Ifebaa0edcd445ee64605fd85fc6b2b24a2ba6646 Reviewed-on: https://chromium-review.googlesource.com/1065973 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#561475}
-
Vadym Doroshenko authored
Methods implementation mostly are mostly todos. Bug: 831123 Change-Id: I5fe4d43804cab243e174e4b683191ef751024833 Reviewed-on: https://chromium-review.googlesource.com/1068188 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#561474}
-
Mahesh Machavolu authored
Samsung smart select feature uses the extracted text returned from SmartClipCallback->onSmartClipDataExtracted . This API earlier used to return the Clip rect of the text that is being extracted. But, this was removed in https://codereview.chromium.org/2667283007/ . Now for Samsung Galazy Note 8, there is a new stylus feature called "Translate" which also uses the same API for translating hovered text. This API makes use of the Clip Rect for recognizing the hovered area text and tries to translate it. So, adding this clip rect back again. Bug: 783732 Change-Id: I54e2f32f7862a2a4a2536b0113094d945160c714 Reviewed-on: https://chromium-review.googlesource.com/762544 Commit-Queue: AJITH KUMAR V <ajith.v@samsung.com> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
AJITH KUMAR V <ajith.v@samsung.com> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#561473}
-
Greg Kraynov authored
Change-Id: I15858d42c4f2f6404225f129878335c19e22bf97 Reviewed-on: https://chromium-review.googlesource.com/1070031 Commit-Queue: Greg Kraynov <kraynov@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#561472}
-
sebsg authored
Bug: 845615 Change-Id: Ia8da247d2c7bc5a836b1ad1c3912c686be2c0190 Reviewed-on: https://chromium-review.googlesource.com/1069532Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#561471}
-
Colin Blundell authored
Opportunistic cleanup to make the GCM embedder directory under //ios/chrome parallel with the GCM embedder directory under //chrome. TBR=sdefresne@chromium.org Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Idebde38dc33d29a5f74f15385d532df4a54d62a7 Reviewed-on: https://chromium-review.googlesource.com/1068943 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Nicolas Zea <zea@chromium.org> Cr-Commit-Position: refs/heads/master@{#561470}
-
Daniel Bratell authored
A recent change in blink added a dependency on services/network which indirectly use winsock2.h for htons a ntohs. Since blink uses its custom ntohs and htons for Windows, those clash. This changes so that blink also uses winsock2.h for htons, ntohs. Bug: 839982 Change-Id: I5bebce4e62227512da2c922dc41a564ce442f388 Reviewed-on: https://chromium-review.googlesource.com/1070973Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#561469}
-
Bence Béky authored
This change can be merged into Beta or Stable to prevent the crash from happening for the time being. Later it can be reverted and the underlying issue investigated and fixed. Bug: 842575 Change-Id: I66daf2d6f2f41a4b2d7bde6c3001934e862320dd Reviewed-on: https://chromium-review.googlesource.com/1070327 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#561468}
-
Hannes Payer authored
This reverts commit 5fa0b1a7. Reason for revert: This is not correct since external memory reporting may 1) start an incremental V8 gc which 2) invokes wrapper tracing 3) which may fail if GC is forbidden, c.f. crbug/846093 I will look into this offline. Bug:chromium:846093, chromium:846061 Original change's description: > [oilpan] Move CompleteSweep() to ScheduleGCIfNeeded() during allocation to play safe. > > CompleteSweep() needs to be called before we call ReportMemoryToV8(). This change > makes this dependency more explicit. > > Change-Id: I044af54bcfdc8a7457edbb492fba6bfe4ff210aa > Reviewed-on: https://chromium-review.googlesource.com/1069271 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Commit-Queue: Hannes Payer <hpayer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#560987} TBR=haraken@chromium.org,hpayer@chromium.org,mlippautz@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I06899e2e5bf0c4303afdd946fd3e6a99f2954530 Reviewed-on: https://chromium-review.googlesource.com/1071288Reviewed-by:
-
Rakina Zata Amni authored
We are mojoifying browser<->renderer communication of Find-in-page. In this CL, we are converting the StopFinding function to mojo. Mojoifying doc: https://goo.gl/JenyGm Previous CLs: Mojoify FindInPage::ActivateNearestFindResult crrev.com/c/1051525 Mojoify FindInPage::GetNearestFindResult crrev.com/c/1051143 Mojoify FindInPage::FindMatchRects crrev.com/c/1049770 Add FindInPage mojo interface with ClearActiveFindMatch crrev.com/c/1027393 Future CLs: Mojoify FindInPage::Find Find-in-page APIs Bug: 819919 Change-Id: I00ba17b6e13d839ee4dbee9597e9f6ac0ea990e6 Reviewed-on: https://chromium-review.googlesource.com/1058731 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#561466}
-
Takashi SAKAMOTO authored
Bug: 845371 Change-Id: I6ccd560af4739f472035b6ff357346e7d6cc4cf8 Reviewed-on: https://chromium-review.googlesource.com/1071048 Commit-Queue: Takashi Sakamoto <tasak@google.com> Reviewed-by:
-
David 'Digit' Turner authored
This CL augments the .build_config file of APK with a new entry at native['extra_shared_libraries'] that list extra shared libraries that can be packaged into the final APK (but which may be processed differently from the list in native['libraries']. This entry will be used later when building an App Bundle module that depends on the APK's .build_config. This is required because the full list of native libraries is determined by a set of complex rules performed by the android_apk() rule, which would be difficult to replicate in a different one without lots of code duplication, or making android_apk() even more complicated that it currently is. + Add a flag in the APK's .build_config file telling it whether the libraries are stored uncompressed (and page-aligned) in the APK. This will allow reproducing the same compression setting when generating the bundle later. BUG=820459 R=agrieve@chromium.org, estevenson@chromium.org, yfriedman@chromium.org Change-Id: I7a4fa94e68370dbc167c1f9729d152f4692fdaff Reviewed-on: https://chromium-review.googlesource.com/1047865 Commit-Queue: David Turner <digit@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#561464}
-
Hajime Hoshi authored
This CL adds TaskType information to post the compositor/worker task runners. Bug: 841172 Change-Id: If1da5fefa86f18fb6523539eb953c1f769d202bd Reviewed-on: https://chromium-review.googlesource.com/1068898Reviewed-by:
-
Mirko Bonadei authored
Change Log: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+log/30de20488b..014f02a3ec Full diff: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+/30de20488b..014f02a3ec Bug: 845158 Change-Id: Ife1d55b8fb44493de01446ee8781dee35a8ccd23 Reviewed-on: https://chromium-review.googlesource.com/1071468Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#561462}
-
Greg Kraynov authored
Change-Id: I1aa07b72b008f76a94edc7c6372aff3bcea7062c Reviewed-on: https://chromium-review.googlesource.com/1070976Reviewed-by:
-
David Bokan authored
Currently, the effective root scroller for a frame is selected immediately after that frame performs a layout or style update. This is problematic for selecting an implicit root scroller since changes in a child frame can affect whcih element we select in the parent. Since promotion can cause a layout, this leads to potential infinite loops, lifecycle violations and a generally messy integration with the document lifecycle. This patch removes the style and layout hooks in favor of a full frame tree walk after the layout step of the main frame. This has a few important implications: - Selection is done in post order, i.e. child frames perform selection before parents. This means selection is performed after we've resolved everything it depends on. Thus, selection doesn't affect the lifecycle in any frames but the one being selected. - Since selection occurs after layout, when each document lifecycle is in LayoutClean, any changes need to be synchronously updated to ensure we leave selection in LayoutClean. - Selection can still be initiated from frame navigations which happen outside the document lifecycle. In those cases we don't need to synchronously update any changes. - Synchronous, script-initiated layout updates no longer cause a frame to perform selection. e.g. If a page calls document.rootScroller = a; The root scroller wont be effective until the next time a full lifecycle update is performed at BeginMainFrame. Causing a layout, via element.scrollTop for example, will not cause promotion. This required updating several tests to ensure we update the lifecycle before making assertions. (Some non-rootscroller tests also had to be updated since they weren't performing a lifecycle update between navigations and the layout viewport wasn't updated.) Bug: 838683 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I0649a50832432c03bf1bf638b6d46e440854bc1c Reviewed-on: https://chromium-review.googlesource.com/1060032 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#561460}
-
Mathieu Perreault authored
This is a complement to https://chromium-review.googlesource.com/c/chromium/src/+/1045990 which added support for this panel to the render view context menu. Bug: 842014 Change-Id: I2bb3bdd8c4a65871c34ad642cbe2de16c791c267 Reviewed-on: https://chromium-review.googlesource.com/1067656 Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#561459}
-
Michael Hablich authored
This is a roll-back to V8 6.8.275. This is the most stable candidate out of the latest Canaries. If this commit results in failures in Blink please contact the Blink sheriff. They may need to make changes to Blink because of the roll-back. When in doubt please try to contact the committer and reviewers of this CL before reverting it. TBR=machenbach@chromium.org Change-Id: I67b3659ac6033efb71753f32f7f9b4d69f806c6b Reviewed-on: https://chromium-review.googlesource.com/1071571Reviewed-by:
Michael Hablich <hablich@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Hablich <hablich@chromium.org> Cr-Commit-Position: refs/heads/master@{#561458}
-
Noel Gordon authored
Bug: 839243 Change-Id: I9a726ce45a4ff500835dd8fdcd1372169250527e Reviewed-on: https://chromium-review.googlesource.com/1071415Reviewed-by:
Naoki Fukino <fukino@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#561457}
-
Vadym Doroshenko authored
Only origin is needed from observed_form, let's expose only it. It has benefits, that it it wouldn't be needed to implement GetObservedForm in NewPasswordFormManager. Bug: 831123, 845826 Change-Id: I0b9ad0ff8ffeaf37bdef08bf73359cb46267faec Reviewed-on: https://chromium-review.googlesource.com/1070371Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#561456}
-
Marc Treib authored
Nothing here requires thread-affinity, so let's relax the restriction and go with the recommended way. This includes using a SequenceChecker instead of a ThreadChecker, and using SequencedTaskRunnerHandler::Get() instead of ThreadTaskRunnerHandler::Get(). Bug: 846238 Change-Id: I6175c7cff26b4dad1329bd22bef816a0ed33e320 Reviewed-on: https://chromium-review.googlesource.com/1069358 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#561455}
-
Pavol Marko authored
As requested by translation process feedback. Bug: b:78220246 Change-Id: I73fbc519ad23e59ea738ec5e11a644de06af4b2d Reviewed-on: https://chromium-review.googlesource.com/1071467Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#561454}
-
Noel Gordon authored
Test working well in RELEASE/DEBUG/MSAN: now re-enable on ASAN Bug: 845087 Change-Id: I5d7d82c9eca3d0b3fbbfb58bd2d34050d089f8d7 Reviewed-on: https://chromium-review.googlesource.com/1071413Reviewed-by:
Stuart Langley <slangley@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#561453}
-
Hajime Hoshi authored
It looks like the CL https://chromium-review.googlesource.com/c/chromium/src/+/1058990 lost the information. This CL adds the infromation again. Bug: 841172 Change-Id: I9eda1527dedb50c99c742140ad05c1848f37de6b Reviewed-on: https://chromium-review.googlesource.com/1071159Reviewed-by:
-
Felix Ekblom authored
This CL add a callback to sendStandBy() and sendWakeUp() that is run once requests have been been made on D-Bus to put displays to sleep or wake them up. Additionally, an API test is added ensuring that calls to the functions propagate to the D-Bus client. BUG=b:78171027 Change-Id: I7c529ce328bcd8ce67d96d357f71dfbc0da229cf Reviewed-on: https://chromium-review.googlesource.com/1053780Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Commit-Queue: Felix Ekblom <felixe@chromium.org> Cr-Commit-Position: refs/heads/master@{#561451}
-
chromite-chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/02f8ae585af8..b887ecda57d6 $ git log 02f8ae585..b887ecda5 --date=short --no-merges --format='%ad %ae %s' 2018-05-21 rockot Add ARC++ Mojo support libs to chrome deployment Created with: roll-dep src/third_party/chromite BUG=chromium:822034 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I6cde13dee4c436f61fb8a14598575f3e0ad70110 Reviewed-on: https://chromium-review.googlesource.com/1071239Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#561450}
-
Colin Blundell authored
Moves this service out of //components/printing/service and into the canonical location for services within //components. As part of this move, explicitly adds the //printing OWNERS as the OWNERS of the service (before, this was inherited via //components/printing). This CL has NOPRESUBMIT=true because the code move triggers a bunch of presubmit warnings that are out of scope to fix in this CL. NOPRESUBMIT=true TBR=jam@chromium.org, dcheng@chromium.org Change-Id: Ibc57c165f01696cded02760e8a11a65f5d9a1e81 Reviewed-on: https://chromium-review.googlesource.com/958468 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#561449}
-
Javier Ernesto Flores Robles authored
Bug: 845472 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ie46d8b73d9cc16f8156d0c07e82811bab46bd933 Reviewed-on: https://chromium-review.googlesource.com/1070974 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
-
Jérôme Lebel authored
Changing -[IdentityView setName:email:] to -[IdentityView setTitle:subbtitle:]. Bug: 827072 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I9c6a3da00bf5f396b38a92a25d1c6318994ca5da Reviewed-on: https://chromium-review.googlesource.com/1068672 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#561447}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8517631bf410..e9c81ee2ea3a $ git log 8517631bf..e9c81ee2e --date=short --no-merges --format='%ad %ae %s' 2018-05-24 skia-bookmaker Update markdown files Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=allanmac@chromium.org Change-Id: Ia29955fec10d8a046fdf88ca2a1cbbcd4844804b Reviewed-on: https://chromium-review.googlesource.com/1071240 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#561446}
-
Javier Ernesto Flores Robles authored
Removes duplicated icon package. Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ib4ed2ab9aeab2fa1cd81ab8804148732657f9ec1 bug: 845472 Reviewed-on: https://chromium-review.googlesource.com/1070968 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
-
Olga Sharonova authored
In audio service. Bug: 845446 Change-Id: Ibcf287d7e4642388b8c4f4a88de57bf0450dc56a Reviewed-on: https://chromium-review.googlesource.com/1068735 Commit-Queue: Olga Sharonova <olka@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#561444}
-
Mattias Nissler authored
Extend the TPM firmware update code to be able to deal with different TPM firmware update flows, represented by a newly introduced Mode enum. In addition to the previously-existing powerwash update flow, add a mode constant for the state preserving update flow. Change the chrome://chrome UI to request state-preserving TPM updates if allowed. BUG=chromium:788719 TEST=New unit tests, manual integration testing against platform functionality. Change-Id: I7b2340b0a470d9f4bb393cde0ca01d91db3d442e Reviewed-on: https://chromium-review.googlesource.com/1016918 Commit-Queue: Mattias Nissler <mnissler@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#561443}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1f156687a201..4e9b50ab86b9 $ git log 1f156687a..4e9b50ab8 --date=short --no-merges --format='%ad %ae %s' 2018-05-23 mmoss Revert recent gclient.py changes to fix Chrome releases. Created with: roll-dep src/third_party/depot_tools BUG=chromium:846194 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ibf3ae599c18c25b60f08d954ced9e1b2d91b7c0d Reviewed-on: https://chromium-review.googlesource.com/1071232Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#561442}
-
Vaclav Brozek authored
Autocomplete attributes are string properties of DOM elements. For parsing password forms, a few special values are important. This CL adds a few functions to password_form_conversion_utils to compute an enum representation of the autocomplete attributes, and a simple cache to keep those computed values to minimize string comparisons. Bug: 833838 Change-Id: I6c386895be9af54ae1e31c715795a26b29eb0e5c Reviewed-on: https://chromium-review.googlesource.com/1027881Reviewed-by:
-
