- 18 Aug, 2020 40 commits
-
-
Jan Wilken Dörrie authored
This change changes the check of the kEnableOverwritingPlaceholderUsernames feature to only happen after a field with `may_use_prefilled_placeholder` has been found. Furthermore, it sets the feature to be disabled by default. Bug: 1022291 Change-Id: I95ec86619c5a691c077cf913250564f6deae39b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351922 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#799209}
-
Joe DeBlasio authored
This CL makes a small tweak to the common word list following discussions. It also makes it slightly easier to import changes by automating the regex generation step. Fixed: 1117241 Change-Id: Ie57db990a8898f42a46f2f323897038595b83242 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363307Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#799208}
-
Rayan Kanso authored
With the flag enabled, PBS permissions are no longer tied to installability for the browser's default engine. The ContentSettings permission is checked directly. Tested by creating a PBS registration on the browser's default search engine (with & without the flag). Also added a unit test. Bug: 1117598 Change-Id: I11fc91c962f77d761f47b0d25736ed713bb6de09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362705 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#799207}
-
Sean McAllister authored
Currently, ChromeOS defines the OS_LINUX directive as well as OS_CHROMEOS. We're working to separate these two, so we're making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS explicit. Bug: 1110266 Change-Id: I7d5724c1cd9720e917ca71d3af4eda1a6959fdfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352433 Commit-Queue: Sean McAllister <smcallis@google.com> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Evgenii Stepanov <eugenis@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Reviewed-by:
Ben Greenstein <bengr@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Reviewed-by:
Derek Schuff <dschuff@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Parastoo Geranmayeh <parastoog@google.com> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#799206}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 175 histograms that show frequent access in the past 90 days. These are the 90% most frequently used histograms over that time that do not already have a date later than or within 60 days of 2021-02-14. TBR=chromium-metrics-reviews@google.com Change-Id: I72efdeebd966a7e2d6c1a420c4b7612fd6474a9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362648Reviewed-by:
Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Cr-Commit-Position: refs/heads/master@{#799205}
-
Becca Hughes authored
This is a reland of 0158f88d TBR=tiborg@chromium.org Original change's description: > Setup NTP for Kaleidoscope module > > This CL moves the Kaleidoscope NTP module upstream > into the Kaleidoscope repo. > > The public Kaleidoscope module is now responsible for > loading the resources into the NTP page. > > Also adds the KaleidoscopeDataProvider to the NTP. > > BUG=1114862 > > Change-Id: Ibc255ea9d7fd05b10cb151d0f1e86b0f94b192cb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354717 > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#798391} Bug: 1114862 Change-Id: I46a7d3e5044dc505766ad6fa1e03b9a7ae8f8380 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359553Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#799204}
-
Wez authored
FidlMessageFromBlink() populates the |incoming_transfer| field of the resulting fuchsia.web.Message with any |ports|, but the BlinkMessageFromFidl() API only considered |outgoing_transfer|. Round- trip messages between the two would therefore drop any associated ports. Bug: b/154200695 Change-Id: Ib5b2346d321219166b62d5b60473852a7ffd9d61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362589 Auto-Submit: Wez <wez@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#799203}
-
Garrett Beaty authored
Bug: 1109276 Change-Id: I8ae88b588b60e3e1c931ed43bf83585ac04a536b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363548Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#799202}
-
Dale Curtis authored
This ensures that portrait 4k videos get hardware accelerated decoding. R=sandersd Bug: 1103432 Change-Id: I6ac1c75eac7d21c6cd2c57edac368b84c56ffa85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2361183 Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dan Sanders <sandersd@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#799201}
-
Mohamed Mansour authored
Implements the ITableProvider and ITableItemProvider for UIA. Currently just supports TableView's column headers. Row headers are not supported in TableView's control. AX-Relnotes: Column Headers in TableView are announceable. Bug: 1078623 Change-Id: I7c8ba49cd8de9fffe471e91c4d6d4e759c9ddc29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348541 Commit-Queue: Mohamed Mansour <mmansour@microsoft.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#799200}
-
Garrett Beaty authored
Bug: 1109276 Change-Id: Ief72c4d315bb12cb588454cc09555e6e6f6e51b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362995 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c298799c3081..7929aebd9197 2020-08-18 sigurds@chromium.org Hide uninformative origin in frame tree view 2020-08-18 wolfi@chromium.org Update frame tree icons 2020-08-18 sigurds@chromium.org Update protocol 2020-08-18 sigurds@chromium.org [ts] Type-check resources/ClearStorageView.js with TypeScript 2020-08-18 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-08-18 jacktfranklin@chromium.org Rename `Element` => `LayoutElement` in LayoutPane 2020-08-18 changhaohan@chromium.org Expose isInDarkMode test from get-stylesheet 2020-08-18 szuend@chromium.org [ts] Type-check ui/ReportView.js with TypeScript 2020-08-18 szuend@chromium.org [issues] Update 'no issues detected' label 2020-08-18 jacktfranklin@chromium.org Improve public methods support in bridges 2020-08-18 wolfi@chromium.org Fix error/warning counter tooltip to show correct count 2020-08-18 jobay@google.com [e2e] fix flaky console test 2020-08-18 jacktfranklin@chromium.org Copy devtools_entrypoint sourcemaps into resources 2020-08-18 szuend@chromium.org [ts] Type-check ui/XWidget.js with TypeScript 2020-08-18 szuend@chromium.org [ts] Type-check ui/Infobar.js with TypeScript 2020-08-18 szuend@chromium.org [issues] Update third-party issues checkbox label 2020-08-18 szuend@chromium.org [ts] Type-check ui/TextEditor.js with TypeScript 2020-08-18 szuend@chromium.org [ts] Type-check ui/ListModel.js with TypeScript 2020-08-18 alexrudenko@chromium.org Add a button to reveal the element to the Layout pane 2020-08-18 alexrudenko@chromium.org Revert "Suggest accessible color" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1051466,chromium:1080589,chromium:1093227,chromium:1093247,chromium:1109177,chromium:1112692 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I5184b2d5b3d228e8eec98e646599493cae47bf3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363061Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799198}
-
Omer Katz authored
This method is not used and would not compile if we tried to use it. Change-Id: I1d97d6ad4e0d3924e902a34e2ecc4d0a4c7604d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362893 Auto-Submit: Omer Katz <omerkatz@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#799197}
-
Nohemi Fernandez authored
Currently the cancel confirmation alert is shown on all screens derived from "Sync & Google Services" even if there is no "Cancel" button on the navigation bar. Bug: 1115504 Change-Id: I4b8793af8fcb7f7f1bf081d352c18f0f192c6e69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358679Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#799196}
-
Chris Lu authored
It is no longer true that presenting_ will always be false when PresentOverlayForActiveRequest is called. This can occur if the current active request is dismissed by being removed from the queue and adds another overlay in its completion callback. Instead, the DCHECK can be moved after the OverlayPresentationContext checks, which should be enough to early return when an overlay is already being presented. Bug: 1114547 Change-Id: I1756df163dfb10e96537449491d0cfc5295c4aed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360376 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Auto-Submit: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#799195}
-
Chris Cunningham authored
Profile 2 requires bitdepth of 10 or 12. Change-Id: I7155d19f34ad3f7b126b7fc6b0134d74d5c85814 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2361343 Auto-Submit: Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#799194}
-
Friedrich Horschig authored
This CL implements the functionality of the eye icon. Clicking it either masks or unmasks the password. Screenshot in the bug. Bug: 1114720, 1092444 Change-Id: I1005e61961171caae5b0d0e1ea3c79ef6c3273ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362850 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#799193}
-
Devlin Cronin authored
Modify GetEffectiveDocumentURL() to take a MatchOriginAsFallbackBehavior to indicate in which cases the origin of a frame should be used as a fallback, in the case where the frame's URL is insufficient (such as about: and data: frames). If MatchOriginAsFallbackBehavior::kAlways is specified (as is the case when match_origin_as_fallback is specified as true in the manifest for a content script), the frame tree is no longer traversed. This allows scripts to inject on opaque frames where the extension has access to the frame's initiator, but the frame tree contains cross- origin frames. Update the tests for the same, and add new tests for matching a frame's origin as a fallback with path-specific match patterns; note that these are not fully supported yet. Bug: 55084 Change-Id: I86ccf56c3b05e92851ecca3748d8d973a098522f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343323Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#799192}
-
Mason Freed authored
These two were used only for pre-FormControlsRefresh, and are no longer needed. This CL renames the prior LayoutThemeMacRefresh, which is the replacement, over to LayoutThemeMac. This CL removes ~2700 lines of dead code. :-) Fixed: 846357 Change-Id: If8f463c66c4366b66334ed0a7cb7660395139fb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360314 Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#799191}
-
Chris Cunningham authored
ParseVideoCodecString() and ParseAudioCodecString() now accept "" for mime_type. This affords reuse of for this complex parsing code by WebCodecs, where encoded media is not containerized (no mime type). The two existing callers of these functions require mime types, but they already validate the mime type is present at a higher level. Bug: 1113824, 1094191 Change-Id: Ifc3f0a30dd94e4979e184e8879d3f365b28d6ebf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359408 Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
-
Andrew Grieve authored
Another attempt at preventing OOM for android-archive-rel Bug: 1098333 Change-Id: I8307209b7ce9ef7220bb0e2cbb14becce5e03a1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2361182Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#799189}
-
Clemens Arbesser authored
With this CL, STARTING and BROWSE controller states no longer require the UI to be shown while running lite scripts. Effectively, this delays the attachment of the UI until the first PROMPT is shown. Note that this is specifically for the beginning of lite scripts. It is not yet possible to dynamically detach the UI mid-flow - this CL is only about the delayed initial attachment of the UI. Bug: b/162065211 Change-Id: Ia91498e0570fbaff76dd81c65f3462de26c04425 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359070 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#799188}
-
Matthias Körber authored
Adds logic to migrate a legacy name to the structured representation: If the full name is set, but there is no status assigned, depending on the verification status of the overall profile it is either set to kUserVerified or kObserved. All other tokens are reset and reparsed. If the full name is not set, the first, middle and last tokens are marked as kObserved and the full name is formatted. In the legacy implementation, a profile should not be merged with another profile if it is already user verified. With structured names, this situation changes because it is still beneficial to learn the structure of a name although the name itself should not change. This CL adds the logic for this case. Change-Id: I7c27e86dd210bd9dc4954a1796ea57a1409ba886 Bug: 1099202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358673 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#799187}
-
Henrique Nakashima authored
Reheat the graph if node grouping criteria changes. Bug: 1117259 Change-Id: I9be8e2dd6c1ed523fe0ae8a9a71fcb16176bfb18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360495 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#799186}
-
Anders Hartvoll Ruud authored
The selector '#container > div' has higher specificity than a single #id selector, so in a browser which supports setting the animation- timeline via the animation shorthand (which we don't support yet but will soon), the animation-timeline always becomes auto. To fix this, use longhands instead. This prepares for animation-timeline-in-shorthand support. Bug: 1074052 Change-Id: I7d8a5ad2a315eb251cc0f42f5a54b1cf3b54ee45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360374Reviewed-by:
Kevin Ellis <kevers@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#799185}
-
Yuke Liao authored
This CL disables 2 more interactive_ui_tests that are failing. Bug: 1111979 Change-Id: I5d6d3fb393acd827be6f3cafcd713faff00c20b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363062 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Auto-Submit: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#799184}
-
Moe Ahmadi authored
Beta finch config: cr/322802704 Change-Id: I626064d11e0a5d681db64111adad26aabf94dd95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353522 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#799183}
-
Haiyang Pan authored
This test suite is pretty stable on fyi MM for the past 200 builds, except for the failures caused by offending CLs And the test pool has enough capacity. Keep it running on 8 core to shorten the test runtime. Bug: 997376, 1098111 Change-Id: I02b9d2cc2ae9dd4e4635b5cb231291e7b6925d45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355568 Auto-Submit: Haiyang Pan <hypan@google.com> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
-
Roman Sorokin authored
Bug: b/162972077 Change-Id: I6b206a78bd5efe3eecb74767ec86e069914ce815 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340973Reviewed-by:
Drew Wilson <atwilson@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#799181}
-
Yunke Zhou authored
Bug: 1101318 Change-Id: Ie14f5f199af160aee865570b364ef8387e5a0499 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359993Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Yunke Zhou <yunkez@google.com> Cr-Commit-Position: refs/heads/master@{#799180}
-
John Delaney authored
Adds new owners file specifically for the AdsPLMO directory. Change-Id: I01028ae59ee4b27211f8deb189199c0ae05fd65c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359587Reviewed-by:
-
Eric Seckler authored
Augments the existing Power.CpuTimeSecondsPerCoreTypeAndFrequency with an equivalent metric that is approximated from per-core time_in_state instead of per-thread time_in_state. The latter is not widely supported (only on newer Pixel devices). For this purpose, extends base's CPU class to support reading and parsing the time_in_state stats file in /sys. Bug: 1081760 Change-Id: I8cfb2510a0a6be59cd515e8704033de903898e22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359078 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Auto-Submit: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#799178}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/297207f64cc3..a651373fa953 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC csharp@google.com,guidou@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1041781,chromium:1057100,chromium:1075562 Tbr: csharp@google.com,guidou@google.com Change-Id: Ia1c894bdfe1c77e1107727c5d5b0481f54a0abf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363058Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799177}
-
ziyangch authored
BUG=internal b/163629769 Test=Locally build. Change-Id: I3a6a7bd9f9a34299b98d753058072afed64547d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350495Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
Simeon Anfinrud <sanfin@chromium.org> Commit-Queue: Ziyang Cheng <ziyangch@chromium.org> Cr-Commit-Position: refs/heads/master@{#799176}
-
Omer Katz authored
Ephemeron tracing used to be only on mutator thread. We recently restructured it in a way that allows for concurrenncy. This, the TraceEphemeron method can be concurrent and should use GetSafe. Bug: 986235 Change-Id: Ib10ad7eef383f41d2a70d966d04904a54bc96e76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358970 Auto-Submit: Omer Katz <omerkatz@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
-
Nela Kaczmarek authored
This change creates a struct AffiliationFetcherDelegate::Result to support both affiliations and groupings. Bug: 1108279 Change-Id: I0b02ba3dc606204c9b8e5a25394a7e9cab02eb3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357809 Commit-Queue: Nela Kaczmarek <nelakaczmarek@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#799174}
-
David Bokan authored
A text fragment occurs in a URL fragment and begins with ":~:text=...". It is used to highlight and scroll the provided text into view when the page is loaded. For user privacy reasons, we restrict scrolling the text into view unless the navigation occurred via a user gesture. See: https://github.com/WICG/scroll-to-text-fragment#security-considerations for more details. However, it is common (particularly on social and messaging services where content is user-generated) for links to be served via a redirect. A typical example (from chat.google.com) works like this: 1. User receives and clicks a link to https://example.com#:~:text=foo" 2. chat.google.com opens a new tab using window.open("", "_blank") 3. chat.google.com calls document.write on the newly opened window to write a <meta> tag-based client redirect to google.com/url?url=https://example.com... which is the URL redirection service with the destination URL as a query param. 4. google.com/url then calls window.location and writes "https://example.com#:~:text=foo" into it 5. the new tab finally navigates to example.com The only navigation that had a user gesture attached to it is the initial empty document navigation in step 2. This means the example.com page is navigated to without a user gesture and the text fragment is blocked. A similar pattern is seen on many popular services: Twitter, Instagram, Facebook Messenger, etc. This CL solves the above scenario by introducing a "text fragment token". This token grants its holder permission to invoke a text fragment. The token can be used during load to invoke the text fragment, or it can be passed into a navigation to grant permission to the next page without requiring a user gesture. However, in either case, the token is consumed so a page cannot both invoke a text fragment and pass the token. The token is created in only in DocumentLoader's constructor and while processing a same-document navigation. For regular navigations, it is only created if the current navigation was user initiated. For same-document navigations, it's created only if browser-initiated and the navigation has a text fragment. This mechanism can be thought of as a user gesture that applies only to text fragment and whose lifetime extends across navigations but cannot be copied and is always consumed on use. Bug: 1055455 Change-Id: Icddd849937d24b579bbeb5a4b9f87539d8339905 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159324Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/88816e373d30..552d3e3d5ee9 2020-08-18 peah@webrtc.org Reland "Add ability to state whether the APM output will be used" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: If8f1de19bb7b318b044df7e80301e96784292581 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363207Reviewed-by:
-
Dirk Pranke authored
It turns out the work I did on the "wrapped_*" targets in gn_isolate_map was somewhat overlapping with the already-existing iOS work to declare things as "generated_scripts". However, the generated_scripts did not include test_env.py. So, this CL rearranges things so that the generated script will call test_env.py, and then we can share logic between the generated_script targets (and every target on iOS and LaCrOS) and use that as the basis for the rest of the work going forward. Bug: 816629 Change-Id: I9d55c3f1587defcb599ddf1df838dd9ed5b6a12c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357917Reviewed-by:
-
Daniel Rubery authored
This CL extends the expiry of SBClientDownload.DownloadRequestDuration, since it is a generally useful top-level metric for Safe Browsing's download protection. It marks obsolete SBClientDownload.ArchiveDownloadExtensions, which is not as useful and was not being used. Fixed: 1109837, 1105086 Change-Id: Ib3f4081a8a5d1ef733243ac7c41ba2011526fd48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2361002 Auto-Submit: Daniel Rubery <drubery@chromium.org> Reviewed-by:
-
