- 17 Oct, 2020 19 commits
-
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/9cee07983fc9..fba124a48346 2020-10-16 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision e7588486..2aa0b3d2 (817908:818053) 2020-10-16 joedow@google.com Fixing ASAN container-overflow error in DxgiOutputDuplicator 2020-10-16 hta@webrtc.org Deprecate GetRemoteAudioSSLCertificate If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1138446 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: If173831dc9addf52127f4f37482cbc5154db4486 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481936 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818189}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d77d4ca4c542..0a749cf45c8c 2020-10-16 jalyn@microsoft.com Settings: Add Keyboard Shortcuts Docs Link If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:174309 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic073f147340416c9dfd109302d7ae02e98581e06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481728Reviewed-by:
-
Victor Hugo Vianna Silva authored
The method is unused. SyncEnums::ENCRYPTION_COMPLETE also becomes unused and is deprecated. Bug: 1033040 Change-Id: I100ed858d43151d437076947c1cf5fcf5831af3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2479164 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#818187}
-
Greg Thompson authored
It doesn't provide any additional signal over other data sources. BUG=1138415 R=chromium-metrics-reviews@google.com Change-Id: I56185e4be8055ff49c72cb3f8016dc943cdbc397 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2479562 Auto-Submit: Greg Thompson <grt@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Yann Dago <ydago@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#818186}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/426436686c95..3c12c8877aee If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC rbpotter@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1091475,chromium:1138953 Tbr: rbpotter@google.com Change-Id: I1587b38184a10a8f521f38e09298f127972516a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482164Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818185}
-
Stefan Zager authored
Speculative fix for crasher. Root cause is most likely one of these: https://chromium-review.googlesource.com/c/chromium/src/+/2220868 https://chromium-review.googlesource.com/c/chromium/src/+/2113390 On further reflection, it really doesn't make sense to force the root GraphicsLayer of a throttled frame to get hooked up into the layer tree. We can dispense with DisableCompositingQueryAsserts, because the call to CanBeComposited will already check for throttling. If that call comes back 'true', then the child frame *better* have advanced its lifecycle far enough to allow compositing state queries. BUG=1133662 Change-Id: Ie3be72c7ccc9837d15268e6e6fe39e39227dfd5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482047Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#818184}
-
Aya ElAttar authored
Changed "*.company.com" to "company.com" to avoid confusion with blacklist-url-patterns Change-Id: Ica9df34c04da6ba09786f5b9f8372d93dd87ec62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467863Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Cr-Commit-Position: refs/heads/master@{#818183}
-
Michael Crouse authored
The DataUse.BytesReceived histogram does not cover larger reports from the OS and makes it difficult to measure changes in data use. Bug: 1132481 Change-Id: I2a0df744f0178ce16aad75cf024c86f28b0d11aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459792 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
rajendrant <rajendrant@chromium.org> Auto-Submit: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#818182}
-
Edward Lesmes authored
Generate DIR_METADATA files and remove metadata from OWNERS files for //ui/webui. Bug: 1113033 Change-Id: I9d5c935d025198d732be6dfaa135c1c59abd7107 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477520 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Cr-Commit-Position: refs/heads/master@{#818181}
-
Xing Liu authored
If require_lite_mode is set to true, download later dialog will show only when lite mode(data saver) is enabled. Bug: 1137925 Change-Id: I8655750cac482fa65cd848b4a688fe97366f634e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469457Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#818180}
-
Mario Bianucci authored
Currently, if no point in |points_| has the same timestamp as |metadata_|, everything in the map is erased. However, this sometimes results in some points that have timestamps later than the metadata's being erased. Particularly, this can occur when the API is first used, since the point used to make the metadata wasn't sent to viz by the browser process, since it didn't know to send them yet. However, if it then sends points before this metadata makes it to viz, those points would be erased since none match metadata's timestamp. This could cause future trails to not be drawn too. This change fixes that by only removing points that have timestamps earlier than metadata's timestamp. Bug: 1132043 Change-Id: I1da7b4ca7de8e816cebb67dece7a2bb1743cddf7 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429963 Commit-Queue: Mario Bianucci <mabian@microsoft.com> Reviewed-by:
weiliangc <weiliangc@chromium.org> Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#818179}
-
Aleks Totic authored
HasNonCollapsedBorderDecoration is a LayoutObject flag used in painting. If flag is set, fragment participates in BorderDecoration painting. Setting this flag in a way compatible with LayoutNG was problematic: In Legacy, flag got reset every time style changed, and manually set in Legacy table layout. Because collapsed_borders is a property of Table, Cell needed its table to set the flag properly. Table was not available to cell when SetStyle was initially called, so flag had to be manually set in LayoutNGTableRow::AddChild. This patch adds HasNonCollapsedBorderDecoration flag to table cells. The flag has to be passed from LayoutNGTableRow through ConstraintSpace. Bug: 958381 Change-Id: I7800d0c918ff78139df6748bed8a95c64cb19395 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473806 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#818178}
-
Jesse Schettler authored
Add temporary text to display when an unsupported file type is selected. The text will be removed once all available file types are supported. Bug: 1059779 Change-Id: Ib4cb062439cbcb732b565a88f92a992794f7768d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480730Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#818177}
-
Vincent Boisselle authored
Other related changes: > Added a gate for the feature in the action manager that would have prevented the problem on not spreading on clients that don't have the feature enabled > Added test coverage. Bug: 1139394 Change-Id: Ib9105b038f506e897fdca7fb99a987bd473e1a2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481302Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Vincent Boisselle <vincb@google.com> Cr-Commit-Position: refs/heads/master@{#818176}
-
Josiah K authored
Focus following should work in more cases than handled previously, since we're now listening for all high-level chrome.automation focus updates, instead of low-level views::View AXEvent and related focus updates. AX-Relnotes: New Javascript-based magnifier focus following behind flag - focus following should work in more cases than handled previously. Bug: 1131153 Change-Id: I1e34255000a320df942462690c6a7ea1b6d0612e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466622 Commit-Queue: Josiah Krutz <josiahk@google.com> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#818175}
-
Matt Wolenetz authored
Includes implementation of CrossThreadMediaSourceAttachment (CTMSA) and updates to MediaSource and SourceBuffer to use it. CTMSA owns a lock that it takes on most operations. It also provides a utility method (RunExclusively()), which is used by the MSE API to take that same lock during most operations on the API. The same thread attachment provides a basic version of the same, though no lock is used. CTMSA understands whether or not it is attached, has ever started closing, and whether or not either of the attached contexts has ever destructed. It conditions cross-thread operations to safely behave when one or both contexts is being destructed. MediaSource is given its own small lock that it uses to guard its reference to the attachment instance, when attached. This is required because attachment start is synchronous on the main thread, even if the MediaSource is owned by worker context. CTMSA and MediaSource cooperate to ensure mutex and safety of the two-stage attachment start. In MediaSource::ContextDestroyed(), further care is taken to prevent attachment start success when worker context destruction is possibly racing the main thread's attempt to start attachment. `context_already_destroyed_`, protected by MediaSource's lock, is used to prevent that start from succeeding. MediaSource's context destruction can no longer always assume that accessing the demuxer via the WebMediaSource (and WebSourceBuffers) is safe. The worker version of MediaSource context destruction uses the attachment's RunExclusively() to safely know if it can cleanly Close the underlying demuxer, or if instead it must do a simpler shutdown. Future specification work will likely determine some signal to the media element when the worker-owned MediaSource's context is shutdown, yet the element itself is still alive. For now, sane results are returned by the attachment (nothing buffered nor seekable), with no other error provided. Possible app workarounds might include main and worker watchdogs and being careful about when the main thread explicitly terminates the worker. This experimental implementation attempts to retain BackgroundVideoOptimization, even for MSE-in-Workers, but does not support AudioVideoTracks in the worker MediaSource or SourceBuffer. Plumbing of appropriately-identified track metadata parsed from initialization segment in the worker is used to populate (and remove) media element AudioVideoTracks that should agree with the track id's used internally in WebMediaPlayerImpl to accomplish BackgroundVideoOptimization. As a simplification, CTMSA assumes it can be used for at most one attachment. Effectively, this assumes that the currently on-by-default MediaSourceRevokeObjectURLOnAttach feature behavior will be always-on soon. If CTMSA is not unregistered automatically after successful attachment start (e.g., if that feature is disabled) and if the app attempts to re-use the corresponding object URL for a later attachment, that attachment will be rejected by CTMSA. Note that the same-thread attachment would still allow such re-use when that feature is disabled. Updated web-test: mediasource-worker-attach.html changed to ...-play.html and fixed New web-test: mediasource-worker-play-terminate-worker.html Manual test: page refreshing while running mediasource-worker-play*.html BUG=878133 Change-Id: I21f6542b90d51bdc28096500fb1441d202ab4ee8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459431 Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
Will Cassella <cassew@google.com> Cr-Commit-Position: refs/heads/master@{#818174}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f9c7b2803461..be8004d2fb6c 2020-10-16 bsalomon@google.com Revert "New variant of SkImage::MakeFromYUVATextures." 2020-10-16 mtklein@google.com switch SkTPin impl to pin NaN to lo 2020-10-16 tdenniston@google.com Don't run SVG tests on tsan bots for now 2020-10-16 bsalomon@google.com New variant of SkImage::MakeFromYUVATextures. 2020-10-16 mtklein@google.com impl SkTPin with std::{min,max} If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: robertphillips@google.com Change-Id: Ia45b648f97c4969da3a1ddfb88062beaf4435a92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481937Reviewed-by:
-
Daniel Classon authored
The "Ok Google" tags should show up all the time, not just when Ok Google is enabled. While this fixed the bug with the tags not showing up, the search tag priority is still really low. In my testing, "Hey goog" and "Okay goog" led to the search results being shown, but as soon as Google is added, other Google related search items take precedence. Fix this by changing search priority from Low to Medium. Fixed: 1136629 Change-Id: Id13ae98b5a699a0853382413730c8079cdf658fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476521 Commit-Queue: Daniel Classon <dclasson@google.com> Reviewed-by:
-
Dale Curtis authored
NVIDIA has indicated that they don't expect overlays to work properly prior to the 455 driver. Confusingly, 456.38 appears to be the first r455 driver. R=zmo Bug: 1113893, 1056267 Change-Id: I7db3a1332628b64a9e480543b2b4d5434c91fd4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481065 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#818171}
-
- 16 Oct, 2020 21 commits
-
-
Sky Malice authored
TBR: fhorschig@chromium.org Bug: 1139520 Change-Id: I762bf5cdbc6237b03faac49597ef1cf61e2e29b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481939Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#818170}
-
Esmael El-Moslimany authored
Bug: 1076506 Change-Id: Iaa0f04eaf7e159424b6ab44f5b526dec04b79e1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481685 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Auto-Submit: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#818169}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2851aa91..1cf32d03 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6a7ed4ea79fb0022d19f667ad2dd56b13ae8243c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481643Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818168}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/09ac7d906427..51ff0d0509b6 2020-10-16 jmadill@chromium.org Trace Tests: Add vsync-limited mode with a GPU timer. 2020-10-16 jmadill@chromium.org Perf Tests: Add offscreen mode. 2020-10-16 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Loader from 14ad927e679a to 970c132746b1 (1 revision) 2020-10-16 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Tools from 1abaced34b84 to ee0de094ddff (1 revision) 2020-10-16 jmadill@chromium.org Suppress Mac/AMD/GL dEQP failures with standalone mode. 2020-10-16 jmadill@chromium.org Remove flaky check in TimerQueriesTest. 2020-10-16 cnorthrop@google.com Capture/Replay: Fix GL_HALF_FLOAT_OES vertex attrib type name 2020-10-16 jmadill@chromium.org Suppress fragment out int tests on Intel/Mac/GL. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Test: Test: Free Fire MEC Change-Id: I97b73eabe1b4ca84b1c7e5fef15ba05c21cdd245 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481882Reviewed-by:
-
Xida Chen authored
Bug: 1138993 Change-Id: I8e8519c9a41c086dab9c5f00465c8e3a7c22978d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477040Reviewed-by:
Kevin Ellis <kevers@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#818166}
-
Michael Checo authored
Bug: 1132952 Test: browser_tests --gtest_filter=OSSettingsCupsPrinterPageV3Test.All Change-Id: Ib32f26778d72f7b9c8ccf85883a2d0a09f335b84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481662Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I3702e9e4cd4e2f874a95aead6d402c553f0189dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481884Reviewed-by:
-
Gavin Williams authored
This change introduces darker colors to Settings search page to improve the background contrast ratio to reach ARIA standards. Add a variable for prompt color and icon opacity to <cr-toolbar-search-field> so these attributes can maintain different values in non-Settings surfaces (Downloads search, Bookmarks search, etc.). Settings screenshot: http://screen/BohiVQV9iENxyZM Downloads screenshot: http://screen/3QNNWn7ZusdeUSU Bookmarks screenshot: http://screen/4PqfQQKNMDaCMsV Bug: 1040957 Change-Id: Ib6d4371c84b40f8a74ee68bc545b25ce0d0c4b6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469663Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/68ab63fe46c8..426436686c95 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC rbpotter@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1136507,chromium:1138515 Tbr: rbpotter@google.com Change-Id: Ideb7e02f121ecfed2da09e473bfeeb4ecd7159f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481883Reviewed-by:
-
evliu authored
This CL updates the paths for the Speech On-Device API (SODA) tests. Bug: 1128306 Change-Id: Ic5aa1f30114b1f79daa9de594fcde716a1b65177 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481747Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#818161}
-
Carlos Knippschild authored
Nothing to be merged though. Change-Id: Iaaa819c8efec686380a275d1369a1befb5bd3902 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481827 Auto-Submit: Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
-
Joe DeBlasio authored
Change-Id: I8b7d141ed54af0e5ee35a8f4e340deb90297ed01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481904 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#818159}
-
Henrique Nakashima authored
These will be internal classes, but while the implementations that use them are not modularized, they need to be in the public target. Only change is to make them package-private so external dependencies on TabModelOrderController aren't added. Bug: 1138005 Change-Id: Ief09c129337463872bec8400fe169c970ce7b466 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469537Reviewed-by:
-
Aidan Wolter authored
When the GATT connectibility is not changing, then do not bother printing a log. Bug: b/139314817 Test: None Change-Id: If80ce46817126baa2ee953bae7eda0f5e3be8695 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472419Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Aidan Wolter <awolter@chromium.org> Auto-Submit: Aidan Wolter <awolter@chromium.org> Cr-Commit-Position: refs/heads/master@{#818157}
-
Jesse Schettler authored
The value of a select element is always a string, so the Polymer properties bound to select element values are also strings. Fix the annotations for these properties to indicate the correct types. Bug: 1059779 Change-Id: I4ee229694f7925ac152d7de838779d36b9e9b56c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481051 Commit-Queue: Jesse Schettler <jschettler@chromium.org> Reviewed-by:
-
Sky Malice authored
TBR: siashah@google.com Bug: 1139488 Change-Id: I2d149addf553a4c83eabfc45aaba811e79817e93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481944 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 6a9de74d. With Chromium commits locally applied on WPT: 1c2c60bf "Synchronize classList on SVGElement.className.baseVal updates" 2f19541f "Fix AtomicStringTable lowercase translator." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I30da50b9c897450c8afb82f871bc650bd6d4e902 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481582Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818154}
-
Carlos IL authored
Bug: 1042877 Change-Id: Ib4ba9d336bde09e82c17594dcd105448b2ff8916 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454853 Commit-Queue: Carlos IL <carlosil@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Auto-Submit: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#818153}
-
Gordon Seto authored
Add a visual outline around the currently focused image. Screenshot: https://screenshot.googleplex.com/9Bwy5ZFcFoVuWX4.png Bug: 702730 Change-Id: I9c091d022ed3f230b99894fc35c1afb3c807c075 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476627Reviewed-by:
-
Liquan (Max) Gu authored
Context: PaymentRequestEvent.openWindow() fails with a cross-origin error caused by some unknown factors. Change: * Reverted the reverting CL: crrev.com/c/2220705 Bug: 1075481 Change-Id: I2a3452f58d5686e0dcfcd1ba0e30229e69bfe280 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459389Reviewed-by:
Sahel Sharify <sahel@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#818151}
-
Sky Malice authored
TBR: dominickn@chromium.org Bug: 1139496 Change-Id: I65f4c3e974ec832e102803213fcdb4c1c7ff6079 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481744Reviewed-by:
-
