GitLab

Remove the Blink API implementations which still accepted a WebString
for the sender Id, which is not being used anymore.

BUG=424601

Review URL: https://codereview.chromium.org/663813002

Cr-Commit-Position: refs/heads/master@{#301348}

Change section data rewriter internal interface to take a section
directly, rather than a pointer to section data.  Remove some of
the more confusing instances of data pointers being passed between
pack and unpack functions.

Readability only.  No behavioural effects.

BUG=385553

Review URL: https://codereview.chromium.org/650293006

Cr-Commit-Position: refs/heads/master@{#301347}

Brings in fix for undefined read detected on WebRTC's MSan bot.

R=tommi@chromium.org
BUG=

Review URL: https://codereview.chromium.org/677383002

Cr-Commit-Position: refs/heads/master@{#301346}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/8bdbc43..3c4e91b

TBR=leviw@chromium.org,yurys@chromium.org

Review URL: https://codereview.chromium.org/680023002

Cr-Commit-Position: refs/heads/master@{#301345}

The logging_like_official_build gyp setting was removed in this CL:
https://codereview.chromium.org/189603007

BUG=334021

Review URL: https://codereview.chromium.org/682603002

Cr-Commit-Position: refs/heads/master@{#301344}

ExtensionService is not initialized.

BUG=426787

Review URL: https://codereview.chromium.org/658183003

Cr-Commit-Position: refs/heads/master@{#301343}

This patch prevents low-memory devices from crashing on Chrome start up.
Instead of relying on the Linker.sInBrowserProcess field, which can have
an incorrect value on these devices, the mmap check (whether the device supports
loading libraries directly from APK files) is performed inside
LibraryLoader.onNativeInitializationComplete, which is guaranteed to be called
only in the process thread.

In addition, two extra possible values are added to the UMA histogram:
Unknown (the mmap check was not carried out) and Successful (a library was
successfully loaded directly from the APK).

Finally, this patch removes the deprecated
LibraryLoader.onNativeInitializationComplete() method (with no arguments), which
was replaced by LibraryLoader.onNativeInitializationComplete(Context context) in
https://codereview.chromium.org/643923004/.

BUG=423699,390618

Review URL: https://codereview.chromium.org/663543003

Cr-Commit-Position: refs/heads/master@{#301342}

This CL includes following changes.
- Change openView_.firstNode to openView_.firstChild.
- Convert dynamically decorated metric functions to standard form to annotate them.
- Make MetadataCache.get's callback nullable.

BUG=406995
TEST=run browser_tests gtest_filter=*FileManager*

Review URL: https://codereview.chromium.org/673933003

Cr-Commit-Position: refs/heads/master@{#301341}

This prevents file lock problems on those tests shutdown on windows.

BUG=427420

Review URL: https://codereview.chromium.org/682593002

Cr-Commit-Position: refs/heads/master@{#301340}

This method allows clients to register a callback to receive notification
whenever the set of cookies stored in a cookie store that would be sent for a
request to a specific URL changes.

BUG=395146

Review URL: https://codereview.chromium.org/676073003

Cr-Commit-Position: refs/heads/master@{#301339}

BUG=392145

Review URL: https://codereview.chromium.org/622793002

Cr-Commit-Position: refs/heads/master@{#301338}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/a443537..8bdbc43

TBR=leviw@chromium.org,yurys@chromium.org

Review URL: https://codereview.chromium.org/639753005

Cr-Commit-Position: refs/heads/master@{#301337}

BUG=405876
TEST=manual tests on Linux ChromeOS build
TBR=nkostylev@chromium.org

Review URL: https://codereview.chromium.org/680013002

Cr-Commit-Position: refs/heads/master@{#301336}

New entries which are passed to DirectoryContents.onNewEntries_ are determined in DorectoryContents.update, but before they are inserted in the file list, the file list may change.
When creating a new directory in Drive, this sometimes occurs.
This CL adds duplication check just before inserting entries.

BUG=423646
TEST=creating a directory in MyDrive By Ctrl-E and check if there's no duplicated folder.

Review URL: https://codereview.chromium.org/676293002

Cr-Commit-Position: refs/heads/master@{#301335}

After finishing playing video, the media_.ended keep true even after a user drag the slider.
This CL check the slider UI whether or not the position is at the end, and show reload button only when it is at the end.

BUG=413000
TEST=check the button after drag the slider for local video and ChromeCast.

Review URL: https://codereview.chromium.org/667513003

Cr-Commit-Position: refs/heads/master@{#301334}

The solution has been approved in skia: https://codereview.chromium.org/666043003/

BUG=

Review URL: https://codereview.chromium.org/639773010

Cr-Commit-Position: refs/heads/master@{#301333}

While directory copying, the original code creates top-level directory
with the same permissions as source one. So if source directory is
read-only, the newly created directory is also read-only, and neither files
nor subdirectories can't be created in it

R=rvargas@chromium.org

TEST=Unit test was updated to check such a use case

Review URL: https://codereview.chromium.org/659303002

Cr-Commit-Position: refs/heads/master@{#301332}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/cc8ec0b..a443537

TBR=leviw@chromium.org,yurys@chromium.org

Review URL: https://codereview.chromium.org/681733002

Cr-Commit-Position: refs/heads/master@{#301331}

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/637233003

Cr-Commit-Position: refs/heads/master@{#301330}

After a render process dies, the main RenderFrameHostImpl can be reused for a
new RenderFrame in a new render process. In this case, the Mojo connection
between the RFHI and the new RenderFrame was not being set up. This CL fixes
the glitch and additionally future-proofs for the case where sub-frames can be
reused as well:

- When the FrameTree resets process state, it instructs the RFHI's affected
  to invalidate their Mojo connections.
- When the RenderFrameHostManager creates a new RenderFrame for an RFHI,
  it instructs that RFHI to set up the Mojo connection if necessary.

BUG=421069
TEST=Navigate to about://omnibox. Kill the tab via the Task Manager and reload.
Observe that the page produces output upon submission of input.

Review URL: https://codereview.chromium.org/666563005

Cr-Commit-Position: refs/heads/master@{#301329}

BUG=230018
TEST=unit_tests:OwnerSettingsServiceChromeOSTest.*

Committed: https://crrev.com/5fa0ee22683b92d67e07c060e8c7a3c4cced51ee
Cr-Commit-Position: refs/heads/master@{#301132}

Review URL: https://codereview.chromium.org/654263003

Cr-Commit-Position: refs/heads/master@{#301328}

This includes the braille IME in the compiled js resources.  As a cleanup,
most of the braille IME externs are removed, consolidating with the
central location in third_party/closure_compiler.  The compiler
used for checking braille IME and chroemvox in the presubmit scripts is
chagned to the one in top-level third_party, isntead of the one
in blink.

R=dtseng, tbreisacher
BUG=

Review URL: https://codereview.chromium.org/665633002

Cr-Commit-Position: refs/heads/master@{#301327}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/193ad3d..cc8ec0b

TBR=leviw@chromium.org,yurys@chromium.org

Review URL: https://codereview.chromium.org/679983002

Cr-Commit-Position: refs/heads/master@{#301326}

BUG=423257
TEST=out/Release/browser_tests --gtest_filter=FileManagerPrivateApiTest.OnFileChanged

Review URL: https://codereview.chromium.org/658013002

Cr-Commit-Position: refs/heads/master@{#301325}

This code is being developed in the mojo repository but it unused in
chromium.

R=aa@chromium.org

Review URL: https://codereview.chromium.org/646943006

Cr-Commit-Position: refs/heads/master@{#301324}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/ff95c8e..193ad3d

TBR=

Review URL: https://codereview.chromium.org/675413002

Cr-Commit-Position: refs/heads/master@{#301323}

BUG=

Review URL: https://codereview.chromium.org/675633005

Cr-Commit-Position: refs/heads/master@{#301322}

According to latest editor's draft http://rawgit.com/w3c/html-api-map/master/index.html
HTML pre tag should be exposed as follow:
MSAA + IAccessible2
Role: IA2_ROLE_PARAGRAPH

AX
AXRole: AXGroup
AXSubrole: (nil)
AXRoleDescription: "group"

This CL depends on blink side CL https://codereview.chromium.org/671003002/ (Reverted)

Re-Land CL https://codereview.chromium.org/663233004/

BUG=426053
TBR=kalman

Review URL: https://codereview.chromium.org/671033002

Cr-Commit-Position: refs/heads/master@{#301321}

liblatency_info_nacl.a will be used by libppapi for nacl_helper_nonsfi.
This CL builds the library, but it is not used yet.
It is now for just making sure it is built properly.
It will be depended on by ppapi_proxy_nacl in a later CL.

BUG=358465
TEST=Ran trybot.

Review URL: https://codereview.chromium.org/671443005

Cr-Commit-Position: refs/heads/master@{#301320}

The responsibility of EntryWatcherService has been moved to WatcherManager
implementations.

Note, that the original code was unnecesarily complicated. After replacing
the observer interface with a simple callback, there is no need for an extra
service managing watchers anymore.

This was possible because with the new design entry watchers will no longer
survive reboots.

TEST=Compiles.
BUG=261491

Review URL: https://codereview.chromium.org/642343004

Cr-Commit-Position: refs/heads/master@{#301319}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/3e1901b..ff95c8e

TBR=

Review URL: https://codereview.chromium.org/652403004

Cr-Commit-Position: refs/heads/master@{#301318}

libtracing_nacl.a will be used by PPAPI library for nacl_helper_nonsfi.
This CL builds the library, but it is not used yet.
It is now for just making sure it is built properly.

BUG=358465
TEST=Ran trybot.

Review URL: https://codereview.chromium.org/650593003

Cr-Commit-Position: refs/heads/master@{#301317}

The test was removed a long time ago:
https://src.chromium.org/viewvc/chrome?revision=228580&view=revision

BUG=104950
TEST=none

Review URL: https://codereview.chromium.org/647763005

Cr-Commit-Position: refs/heads/master@{#301316}

This CL moves the NamedPage enum from ContentsView into AppListModel where
it will be used as a more generic value that represents the state of the
app list.

This is in preparation of notifying code across the chrome/ DEPS boundary
of changes to the app list's state.

BUG=425444

Review URL: https://codereview.chromium.org/675053002

Cr-Commit-Position: refs/heads/master@{#301315}

It looks fixed. The bot is no longer running the test, so ran valgrind
locally.

R=yhirano
NOTRY=true
BUG=417093

Review URL: https://codereview.chromium.org/672143002

Cr-Commit-Position: refs/heads/master@{#301314}

BUG=N/A
TEST=./tools/perf/run_benchmark --browser=android-chrome-shell page_cycler.top_10_mobile --pageset-repeat=1 --report-speed-index

Review URL: https://codereview.chromium.org/671913004

Cr-Commit-Position: refs/heads/master@{#301313}

The registrations of the ServiceWorker scope outside the script directory will be restricted, as per discussion on https://github.com/slightlyoff/ServiceWorker/issues/468.
So this cl changes the scope which is used in PushMessaging tests.

After this patch will land, I will re-intoruce the scope restriction in Blink side by reverting this: https://codereview.chromium.org/672353003/

BUG=423983

Review URL: https://codereview.chromium.org/644763005

Cr-Commit-Position: refs/heads/master@{#301312}

Revert of Enable virtual viewport on all platforms (patchset #5 id:80001 of https://codereview.chromium.org/665963002/)

Reason for revert:
This appears to break the entire world as far as LayoutTests are concerned. Here's a small sample: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=css1%2Fbasic%2Fcontainment.html%2Ccss1%2Fbasic%2Fcomments.html%2Ccss1%2Fbasic%2Fgrouping.html%2Ccss1%2Fbasic%2Fclass_as_selector.html%2Ccss1%2Fbasic%2Finheritance.html%2Ccss1%2Fbasic%2Fcontextual_selectors.html%2Ccss1%2Fbasic%2Fid_as_selector.html

Original issue's description:
> Enable virtual viewport on all platforms except Android WebView.
>
> BUG=148816
>
> Committed: https://crrev.com/e52372c24d2e1e9785703f0563ffc3423f7161cc
> Cr-Commit-Position: refs/heads/master@{#301307}

TBR=aelias@chromium.org,mkosiba@chromium.org,cpu@chromium.org,bokan@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=148816

Review URL: https://codereview.chromium.org/679973003

Cr-Commit-Position: refs/heads/master@{#301311}

This adds a ServiceRegistrationManager that acts as a global repository
of extensions API services to be added to RenderFrameHosts along with
the extensions API permissions that gate access to them.

BUG=389016

Review URL: https://codereview.chromium.org/652793002

Cr-Commit-Position: refs/heads/master@{#301310}

Worked for all other keys except for the media keys where CanAutoAssign would ALWAYS return true even if key was modified by user. Now no commands should be overwritten on update if they have been changed by a user.

BUG=421482
R=finnur@chromium.org

Review URL: https://codereview.chromium.org/667833004

Cr-Commit-Position: refs/heads/master@{#301309}