- 04 Jul, 2018 40 commits
-
-
Sam McNally authored
Returning transient errors when the refresh token isn't loaded yet was better than persistent errors, but it could result in quite a few errors being returned before a success, sometimes causing DriveFS to give up anyway. Avoid this by waiting for the account to be ready before servicing any access token requests. Bug: 855002 Change-Id: I1578f8f9116592e1ee2864a804269a4a49ba8c92 Reviewed-on: https://chromium-review.googlesource.com/1125551Reviewed-by:
Stuart Langley <slangley@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#572482}
-
Yutaka Hirano authored
This CL adds DocumentThreadableLoader::module_id_ to see which module is to blame for the CHECK failure. I'll revert this change once the cause is found. Bug: 837511 Change-Id: I76a724d1d8277d5e70afed85bb5576df99d997ca Reviewed-on: https://chromium-review.googlesource.com/1125546Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#572481}
-
Tetsui Ohkubo authored
This CL does two things: * It decreases height of feature pod hover when the pod doesn't have sub-label. (https://crbug.com/858942) * It increases width of the hover when it doesn't have enough space to show detailed view arrow. Previously, it hid the arrow in such case. In order to do that, it increased the width of feature pod button by 28px because we symmetrically increase the hover width. The arrow and the spacing takes 14px in total. Screenshot(before): http://screen/5bzdLf3rGQn Screenshot(after): http://screen/48Jr2f39Kp7 TEST=manual BUG=858942,858913 Change-Id: If1db17c0fa932188b36b02979374253f5cde084d Reviewed-on: https://chromium-review.googlesource.com/1124199 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#572480}
-
Darren Shen authored
It currently returns a mutable reference, which is discouraged by the style guide. TBR=blundell@chromium.org Change-Id: Ie7537feffeeeacf317deb02cc5fa9e90a186db70 Reviewed-on: https://chromium-review.googlesource.com/1123963 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#572479}
-
Yoshifumi Inoue authored
This patch introduces |NGPhysicalTextFragment::IsGeneratedText()| with |NGTextType::kGeneratedText| to distinguish between normal text and generated text, e.g. hyphen and ellipsis, for sorting fragments with |StartOffset()|. This patch is a preparation of the patch[1]. [1] http://crrev.com/c/1114673 Make Element#innerText specification compliant Bug: 859410 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ic9879985d1b5dd4cab921ce042ebc393043e3166 Reviewed-on: https://chromium-review.googlesource.com/1122061 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#572478}
-
Koji Ishii authored
Following bot results are included. 7403 7404 7406 7414 7419 7422 7433 7442 7450 7454 7467 7472 7480 7484 7490 7494 7499 7507 6 lines were removed and 4 lines were deflaked by consecutive results since 7433. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I65155db15aab968e51e16157ef04bb6a1aa2d5c7 Reviewed-on: https://chromium-review.googlesource.com/1121936 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#572477}
-
Makoto Shimazu authored
This reverts commit ced45ea8. Reason for revert: Concurrently a suspicious CL has been reverted: https://chromium-review.googlesource.com/c/chromium/src/+/1125459 Original change's description: > Disable SessionRestoreTest.MemoryPressureLoadsNotAllTabs on CrOS > > TBR=sky@chromium.org > NOTRY=true > > Bug: 860111 > Change-Id: Ida98cb932b4caf9ffb60622a293dfd2da6b5c29d > Reviewed-on: https://chromium-review.googlesource.com/1125540 > Reviewed-by: Makoto Shimazu <shimazu@chromium.org> > Commit-Queue: Makoto Shimazu <shimazu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#572451} TBR=sky@chromium.org,shimazu@chromium.org Change-Id: I3b5b6a885e76e6090c87873880836b7bb3c344f4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 860111 Reviewed-on: https://chromium-review.googlesource.com/1125559Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#572476}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/22b68f285d2c..5abd99f5f768 git log 22b68f285d2c..5abd99f5f768 --date=short --no-merges --format='%ad %ae %s' 2018-07-04 nednguyen@google.com Make sure that Telemetry only generate skipped entries for filtered stories when test is interrupted Created with: gclient setdep -r src/third_party/catapult@5abd99f5f768 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:860091 TBR=sullivan@chromium.org Change-Id: Ic208e995fe193cd69d99a42f5f62db669770ddeb Reviewed-on: https://chromium-review.googlesource.com/1124704Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#572475}
-
Tetsui Ohkubo authored
Previously, brightness change by slider less than the threshold was not ignored in UnifiedSystemTray, which led to some artifacts (see the video in the bug.) TEST=manual BUG=858948 Change-Id: I14dcbe6f02e0b35cb88b468421ca8416b9285dbe Reviewed-on: https://chromium-review.googlesource.com/1124210Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#572474}
-
Esmael El-Moslimany authored
Bug: 849857 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I870f5fb93644ac7606d6ea2d810cee7ec9444ed7 Reviewed-on: https://chromium-review.googlesource.com/1120681Reviewed-by:
Scott Chen <scottchen@chromium.org> Reviewed-by:
Sasha Morrissey <sashab@chromium.org> Commit-Queue: Sasha Morrissey <sashab@chromium.org> Cr-Commit-Position: refs/heads/master@{#572473}
-
Darren Shen authored
Not used. Can use |GetKeyboardWindow| to do the same thing (check for null). TBR=yhanada@chromium.org Bug: 845780 Change-Id: I4f104099e92032e25c1aec15c3b67850253ad3e8 Reviewed-on: https://chromium-review.googlesource.com/1124737Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#572472}
-
Makoto Shimazu authored
WizardControllerDeviceStateWithInitialEnrollmentTest.ControlFlowWaitSystemClockSyncTimeout is now flaky. It seems affected by crrev.com/c/1118532, but that CL just added some CHECKs to check if it's not captured by ThreadTaskRunnerHandle. I think we need to keep the task runner properly. TBR=jdufault@chromium.org NOTRY=true Bug: 860092 Change-Id: Id7e566d4a48f59e2f2b7121c0875afcd9dc09b24 Reviewed-on: https://chromium-review.googlesource.com/1125554Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#572471}
-
Ramin Halavati authored
Flash content settings are planned to become ephemeral and this feature is behind 'EnableEphemeralFlashPermission' switch. To make the ephemeral case more apparent to the user, the 'Add' buttons for 'Allow' and 'Block' exceptions in Flash content settings are removed and this is done by making the list read only. Bug: 850062 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I0c216cc0f319a579bcab1639f0b7345070b474c8 Reviewed-on: https://chromium-review.googlesource.com/1124360Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#572470}
-
Han Leon authored
This CL changes type of blink::ServiceWorkerStatusCode from 'enum' to 'enum class', then updates everywhere it is accessed. BUG=789854 Change-Id: I837d8b0b06924f8f42fa7246231e654e364523f6 Reviewed-on: https://chromium-review.googlesource.com/1124102 Commit-Queue: Han Leon <leon.han@intel.com> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#572469}
-
Haruka Matsumura authored
This unit test is named SwapTest. But, in actual, Move() function is called. Change-Id: I929047b9a04dd407534c769c5b4edc97f466c0b4 Reviewed-on: https://chromium-review.googlesource.com/1124341 Commit-Queue: Haruka Matsumura <harukamt@google.com> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#572468}
-
Makoto Shimazu authored
This reverts commit 9cd2322d. Reason for revert: This CL seems causing flaky timeouts of HeadlessProtocolBrowserTest.VirtualTimeErrorLoop. https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=headless_browsertests&tests=HeadlessProtocolBrowserTest.VirtualTimeErrorLoop%0A Original change's description: > Implemented headless compositor protocol tests for basic rAF, GIF and CSS animations. > > Change-Id: I956ea3523eb42b6d7f0cf851a126c6a11578912e > Reviewed-on: https://chromium-review.googlesource.com/1121378 > Commit-Queue: Peter Kvitek <kvitekp@chromium.org> > Reviewed-by: Pavel Feldman <pfeldman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#572253} TBR=dgozman@chromium.org,pfeldman@chromium.org,kvitekp@chromium.org Change-Id: I777f261f3d4a69ca15cdc4cb717ea485bc5308c4 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1125480Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#572467}
-
Ian Kilpatrick authored
This is to allow easy user-testing. Bug: 591099 Change-Id: Ib08bbe1144b27c0fa37de9a12be9d4d21d00f52e Reviewed-on: https://chromium-review.googlesource.com/1124138Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#572466}
-
Darren Shen authored
In AppListFolderView, we currently use the virtual keyboard occluded bounds without checking if it's empty first. This means that when we use the floating keyboard, which has empty occluded bounds, AppListFolderView thinks that the occluded y position is 0, so it overscrolls the view off the screen. We change the code to only overscroll if the occluded bounds are not empty. Bug: 860087 Change-Id: Ibab4170a73932c587bb87ef368a1682885189429 Reviewed-on: https://chromium-review.googlesource.com/1124733Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#572465}
-
Makoto Shimazu authored
TBR=yosin@chromium.org NOTRY=true BUG: 860117 Change-Id: Ibcb6d72b0bdefa2f4538cb9b04ee753840c804b7 Reviewed-on: https://chromium-review.googlesource.com/1125545Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#572464}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=amineer@chromium.org Change-Id: I6e2c6362dc91c20f182e74de665e488640571b32 Reviewed-on: https://chromium-review.googlesource.com/1125443Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#572463}
-
CJ DiMeglio authored
This CL is 2/3 in effort to fix the regressions caused by sending unneeded compositor frames. Previously, we created the SurfaceLayer once we pushed the first compositor frame. That first compositor frame was pushed whether we were on screen or not. We would like to prevent that. In order to that, we must create the SurfaceLayer much earlier, such that the signal to not submit frames is accessible. This CL moves SurfaceLayer creation to just after SurfaceLayerBridge creation. Eventually we would want it be during SurfaceLayerBridge creation, but it has yet to be determined if non-video code paths can also move to this new model. The SurfaceLayer is given an id, but kept hidden until we have videos to display. This allows us to have access to the information we need (to be used in a subsequent CL). Bug: 829813 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I49d320a93f26c6bbf94582c22c93539db1cfd5a1 Reviewed-on: https://chromium-review.googlesource.com/1115579Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> Cr-Commit-Position: refs/heads/master@{#572462}
-
Takuto Ikuta authored
This is partial revert of https://chromium-review.googlesource.com/1082010 This improves build parallelism and remove around 5 mins from compile step on android builders in some cases. Bug: 848494 Change-Id: I2d51decd25125e3cfb3e036e142925dfe9358512 Reviewed-on: https://chromium-review.googlesource.com/1121670 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#572461}
-
Matt Menke authored
The one caller was removed in https://chromium-review.googlesource.com/c/chromium/src/+/1064798, but this class was accidentally not removed. Bug: 791702 Change-Id: I311a12aed9bddfc114bcd66856310ac8fc415673 Reviewed-on: https://chromium-review.googlesource.com/1124762Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#572460}
-
Sam McNally authored
Also move the DriveFS feature to a more common location in chromeos/chromeos_features.h. Bug: 859800 Change-Id: Iffffea69c4874ae0583c67e8a8e6a9b50a4951e4 Reviewed-on: https://chromium-review.googlesource.com/1124211Reviewed-by:
Stuart Langley <slangley@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#572459}
-
Tatsuhisa Yamaguchi authored
- Show number inside a circle icon - Show plus icon when count is larger than 9 Bug: 845804 Change-Id: Ieed91875573dde0e03c3da50d0787e87142bdb8b Reviewed-on: https://chromium-review.googlesource.com/1088529 Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#572458}
-
Patti authored
Currently, the global scroll handler gets set as active immediately when the chrome://settings route changes. However, scroll-handling elements such as iron-list may require access to the global scroll handler during a route change. Fix by setting the global scroll handler active value at the next event loop instead of immediately. Bug: 835712 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ie02843a8d556a5b44a87f4ba696cab2eeff23e70 Reviewed-on: https://chromium-review.googlesource.com/1100659Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Patti <patricialor@chromium.org> Cr-Commit-Position: refs/heads/master@{#572457}
-
Noel Gordon authored
Make audioOpenClose test case load only the file it needs. Do the same for openAudio test case but further divide into two test cases: single and multiple tracks (today's openAudio is multiple tracks). Do the single track track case on Downloads, and do the multiple track case on Drive because the multiple track case is too slow on Downloads on MSAN/ASAN bots (causing flakes). Drive runs faster on the bots, and already runs the multiple tracks case without problems. Bug: 859008 Change-Id: Ia730d9342e8b8e4c10afbb652a3d666ee8c3ed4c Reviewed-on: https://chromium-review.googlesource.com/1124720Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#572456}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/20c83a81a0e6..22b68f285d2c git log 20c83a81a0e6..22b68f285d2c --date=short --no-merges --format='%ad %ae %s' 2018-07-03 dtu@chromium.org [pinpoint] Configure the rest of the bots for performance_test_suite. Created with: gclient setdep -r src/third_party/catapult@22b68f285d2c The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:757933 TBR=sullivan@chromium.org Change-Id: Ic1621cb9125c4461fef268080aacf281a334c7fc Reviewed-on: https://chromium-review.googlesource.com/1125380Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#572455}
-
fuchsia-sdk-chromium-autoroll authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I37b555b4e4a7fe2af0cf62dc36341e2d6041e5b4 Reviewed-on: https://chromium-review.googlesource.com/1125516 Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#572454}
-
Mohamed Heikal authored
Since now layout inflation is delayed for WebappActivity, the splashscreen should be shown in preInflationStartup instead of postInflationStartup. This should fix flickering that may occur on some android devices. Bug: 855888 Change-Id: Ica4ef8431b67a15ded1c769a50501323dc545bf3 Reviewed-on: https://chromium-review.googlesource.com/1119260 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#572453}
-
Keishi Hattori authored
Add reason arg to IncrementalMarkingStart trace event so we can see what trigger the incremental marking GC. Bug: 757440 Change-Id: Ibecb88c157dec70e44287a146f93cdf7e5ef6211 Reviewed-on: https://chromium-review.googlesource.com/1124342Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#572452}
-
Makoto Shimazu authored
TBR=sky@chromium.org NOTRY=true Bug: 860111 Change-Id: Ida98cb932b4caf9ffb60622a293dfd2da6b5c29d Reviewed-on: https://chromium-review.googlesource.com/1125540Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#572451}
-
Yuichiro Hanada authored
An extension id of many system IMEs were updated as we merged three system IME extensions into one. This CL updates the enum values of InputMethod.ID2 to new values. Bug: 764240 Change-Id: I6fa61733f26a90b534b6ddc971cff96c2bedec15 Reviewed-on: https://chromium-review.googlesource.com/1124212Reviewed-by:
Shu Chen <shuchen@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#572450}
-
Dominic Farolino authored
By working around a bug in the IDL compiler when generating RequestInit with said compiler, a regression was introduced that stopped TypeErrors from being thrown when RequestInit's signal member does not implement the AbortSignal interface. This CL fixes that regression and adds tests for it. R=kinuko@chromium.org, yoav@yoav.ws Bug: 836873 Change-Id: I6ab7be2ee8356eb7a997b904d121a7061986096a Reviewed-on: https://chromium-review.googlesource.com/1123771Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Dominic Farolino <domfarolino@gmail.com> Cr-Commit-Position: refs/heads/master@{#572449}
-
Evan Stade authored
This relands da08ce6d Single tab mode makes the frame the same color as a tab. There's no change from the original patchset, which was reverted to make it easier to revert the actual culprit 5f93deb6 TBR=msw@chromium.org Bug: 854704 Change-Id: I1fb8eeb5ae736501f79676668b146d1c8ac32193 Reviewed-on: https://chromium-review.googlesource.com/1125512Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#572448}
-
Mounir Lamouri authored
Bug: None Change-Id: I962397a6c916b176970a451093bcef82bea83258 Reviewed-on: https://chromium-review.googlesource.com/1125403Reviewed-by:
apacible <apacible@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#572447}
-
Alexei Filippov authored
It turned out the std::unordered_set does not support concurrent access even to distinct items in the container. Here's the custom implementation of a hash set with keys of void* type. It supports lock-free concurrent access to Insert, Remove, and Contains operations. The latter made as fast as possible since it is on the hot path of the memory allocation hooks. BUG=854399 Change-Id: Ia53eeff08bafc363df2aef8ac5cdd5212f124452 Reviewed-on: https://chromium-review.googlesource.com/1121101Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#572446}
-
Alexei Filippov authored
TBR=dgozman@chromium.org Change-Id: I7ae3a232b69b77061e456ea49d224408bf7c540e Reviewed-on: https://chromium-review.googlesource.com/1125351Reviewed-by:
Alexei Filippov <alph@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#572445}
-
Clark DuVall authored
Cookies will now be stored encrypted by default in the network service. Tested that crbug.com/848361 is fixed with this change. Bug: 789632, 848361, 789644 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ic627501ddf1c5030bbf2a203f005f5ebca92dfd8 Reviewed-on: https://chromium-review.googlesource.com/1104791 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#572444}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/502c3ffce8eb..6784ffa78e70 git log 502c3ffce8eb..6784ffa78e70 --date=short --no-merges --format='%ad %ae %s' 2018-07-03 jvanverth@google.com Add some new PolyUtils tests. Created with: gclient setdep -r src/third_party/skia@6784ffa78e70 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@chromium.org Change-Id: Ia397b3205df508664a61805b623d6a79a591aca7 Reviewed-on: https://chromium-review.googlesource.com/1125421Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#572443}
-