GitLab

R=danakj@chromium.org,enne@chromium.org
BUG=369757,368935

Review URL: https://codereview.chromium.org/266913021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269835 0039d316-1c4b-4281-b951-d872f2087c98

BUG=372487
TBR=darin@chromium.org
TEST=waterfall

Review URL: https://codereview.chromium.org/276343004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269833 0039d316-1c4b-4281-b951-d872f2087c98

The expectation is that clients sending changes to the server always
increment the value. The server only accepts changes if the ids
match, otherwise the change is rejected. This puts the onus on the
client as to how to resolve out of order changes.

BUG=365012
TEST=covered by tests
R=ben@chromium.org

Review URL: https://codereview.chromium.org/277563006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269832 0039d316-1c4b-4281-b951-d872f2087c98

BUG=359742
TEST=run unittests
NOTRY=true

Review URL: https://codereview.chromium.org/278403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269831 0039d316-1c4b-4281-b951-d872f2087c98

Ran in trybot to make sure this is not flaky, 200 runs were successful on win and linux trybots.

BUG=368077
Test=None, internal test only change.

Review URL: https://codereview.chromium.org/271593009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269830 0039d316-1c4b-4281-b951-d872f2087c98

where it makes sense to do so in existing code.

This migration shook out a couple of bugs in mach_logging.h carried over
from mac_logging.h (fixed there too).

R=rsesek@chromium.org, sky@chromium.org

Review URL: https://codereview.chromium.org/278923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269829 0039d316-1c4b-4281-b951-d872f2087c98

This is a stepping stone towards having audio/video renderers accurately
report their buffering state. For now we use the Preroll() callback to
signal that enough data has been buffered.

Notable changes:
  - The kStarting/kStarted states have been merged into kPlaying
  - DoPlay() is now done implicitly after entering the kPlaying state
  - Transitioning from waiting to non-waiting states (or vice versa)
    now controls the starting and stopping of playback

BUG=144683

Review URL: https://codereview.chromium.org/276973004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269828 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269823 0039d316-1c4b-4281-b951-d872f2087c98

crazy_linker: Add a callback feature.
https://android-review.googlesource.com/#/c/92881/

BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/278323002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269822 0039d316-1c4b-4281-b951-d872f2087c98

R=isherman@chromium.org, kalman@chromium.org
BUG=346488

Review URL: https://codereview.chromium.org/232183002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269820 0039d316-1c4b-4281-b951-d872f2087c98

It is possible for a non-menu source to start a nested message loop
(e.g. for dragging a menu-item). So attempting to terminate the current
iteration of the message-loop when the menu is closed can be problematic.
So instead, terminate the message-loop through the DispatcherClient.

BUG=367850, 372208
R=sky@chromium.org

Review URL: https://codereview.chromium.org/279073002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269819 0039d316-1c4b-4281-b951-d872f2087c98

Use the scale factor in the image in the DrawImageIntHelper function in case we are not drawing in pixels.

BUG=370392
R=oshima

Review URL: https://codereview.chromium.org/275693003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269818 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269817 0039d316-1c4b-4281-b951-d872f2087c98

BUG=370460
R=derat@chromium.org

Review URL: https://codereview.chromium.org/278023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269816 0039d316-1c4b-4281-b951-d872f2087c98

Add target_build_type flag to bisect-perf-regression tool to enable bisecting of a Debug build with run-bisect-manual-test.py tool.

The run-bisect-manual-test.py uses bisect-perf-regression.py under the hood, and currently it
is not possible to bisect a Debug build this way.  This CL addresses this.

Also fixes browser.Start() / browser.Close() in manual-test.py.

BUG=370373
NOTRY=true

Review URL: https://codereview.chromium.org/277993002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269815 0039d316-1c4b-4281-b951-d872f2087c98

Includes the C++ BluetoothAdapter and BluetoothSocket API changes,
but does not include platform-specific implementations. Tests are
included since there is sufficient mock code to drive a test.

BUG=349475,364581
TEST=browser_tests --gtest_filter=BluetoothSocketApiTest.Listen

Review URL: https://codereview.chromium.org/278663002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269814 0039d316-1c4b-4281-b951-d872f2087c98

BUG=287784

Review URL: https://codereview.chromium.org/262973004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269813 0039d316-1c4b-4281-b951-d872f2087c98

This broke prerender omnibox tests (Failing on tree, also failed on
trybot runs for the CL).

> Only commit cookie changes in prerenders after a prerender is shown
> Will create a PrerenderCookieStore for each prerender, retaining all cookie
> operations of a prerender until the prerender is shown to the user.
> Forces prerenders to be in a new render process by themselves for this to work.
> BUG=371003
> R=creis@chromium.org, davidben@chromium.org, erikwright@chromium.org, jam@chromium.org, jochen@chromium.org
> 
> Review URL: https://codereview.chromium.org/233353003

TBR=tburkard@chromium.org

Review URL: https://codereview.chromium.org/279173005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269812 0039d316-1c4b-4281-b951-d872f2087c98

> Disable	ICOImageDecoderTest.Decoding
> 
> It fails on Windows.
> 
> BUG=371332
> TBR=pkasting@chromium.org
> 
> Review URL: https://codereview.chromium.org/270703007

TBR=marja@chromium.org

Review URL: https://codereview.chromium.org/284573002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269811 0039d316-1c4b-4281-b951-d872f2087c98

TBR=bruening@chromium.org
BUG=NONE

Review URL: https://codereview.chromium.org/280623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269810 0039d316-1c4b-4281-b951-d872f2087c98

Instead of using the EventFactoryOzone as the PlatformEventSource, allow
ozone's platform implementation to decide what to use as the event-source.
For the evdev ozone-platform, the event-factory (EventFactoryEvdev) remains
as the event source. In the case of X11 ozone-platform, it will create the
X11EventSource (currently used on chromeos and linux-aura) as the
event-source.

BUG=361137
R=spang@chromium.org

Review URL: https://codereview.chromium.org/280033002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269808 0039d316-1c4b-4281-b951-d872f2087c98

with Dr.Memory

TBR=viettrungluu@chromium.org
BUG=372452

Review URL: https://codereview.chromium.org/278393002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269806 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269805 0039d316-1c4b-4281-b951-d872f2087c98

Add a gfx_x11.gyp in //ui/gfx/x/ and define the gfx_x11 target in there,
instead of defining it conditionally in //ui/gfx/gfx.gyp. This allows
including this code from particular components even when X11 is turned
off.

BUG=361137
R=piman@chromium.org, sky@chromium.org

Review URL: https://codereview.chromium.org/275273002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269804 0039d316-1c4b-4281-b951-d872f2087c98

BUG=367094

Review URL: https://codereview.chromium.org/278633003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269803 0039d316-1c4b-4281-b951-d872f2087c98

This test driver has no dependencies on chrome anymore so we can move it
straightforward into components_unittests target (from unit_test).

BUG=367837
TEST=components_unittests --gtest_filter=BookmarkUtils*
R=blundell@chromium.org, sky@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/277093003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269801 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true

Review URL: https://codereview.chromium.org/280563002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269800 0039d316-1c4b-4281-b951-d872f2087c98

Will create a PrerenderCookieStore for each prerender, retaining all cookie
operations of a prerender until the prerender is shown to the user.
Forces prerenders to be in a new render process by themselves for this to work.
BUG=371003
R=creis@chromium.org, davidben@chromium.org, erikwright@chromium.org, jam@chromium.org, jochen@chromium.org

Review URL: https://codereview.chromium.org/233353003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269798 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269797 0039d316-1c4b-4281-b951-d872f2087c98

https://code.google.com/p/skia/source/list?num=22&start=14688
TBR=borenet
BUG=

Review URL: https://codereview.chromium.org/278323003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269796 0039d316-1c4b-4281-b951-d872f2087c98

Dispatch geolocation IPCs on the UI thread. Aside from simplifying the code to avoid a lot of thread hops, this sets things up for converting the code to work on RenderFrames instead of RenderViews.

In the process I also switched the code to use CallbackList which simplifies the registration.

BUG=304341
R=benm@chromium.org, brettw@chromium.org, bulach@chromium.org, caitkp@chromium.org, isherman@chromium.org, mvanouwerkerk@chromium.org, nasko@chromium.org

Review URL: https://codereview.chromium.org/273523007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269795 0039d316-1c4b-4281-b951-d872f2087c98

Mark the "copy" target as a target function so it appears in the correct section of "gn help".

Use get_target_outputs() in the template example, since you should generall do this instead of process_file_template.

Update docs for process_file_template to state that you should use get_target_outputs if possible.

R=cjhopman@chromium.org

Review URL: https://codereview.chromium.org/270613006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269793 0039d316-1c4b-4281-b951-d872f2087c98

Also StubUserAccountsDelegate was replaced with real implementation, so now we have fully functional version of mirror UI on Chrome OS.

BUG=344844
TEST=manually

Review URL: https://codereview.chromium.org/256623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269792 0039d316-1c4b-4281-b951-d872f2087c98

GetPNaClResourceInfo() currently performs a 1 megabyte allocation. Though any
memory allocation can fail, this one is more likely due to its size.

This change mitigates this problem in two ways. If memory allocation fails, we
report an error and return early instead of using memory.

Additionally, this change checks the size of the file before performing a
memory allocation. This should lead to smaller allocations and more successful
plugin loads.

BUG=370965

Review URL: https://codereview.chromium.org/274673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269791 0039d316-1c4b-4281-b951-d872f2087c98

BUG=372381

Review URL: https://codereview.chromium.org/281433004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269790 0039d316-1c4b-4281-b951-d872f2087c98

Creation of a new signin_metrics class to track components/signin UMA.

BUG=357693
TEST=New histograms are called Profile.NumberOfAccountsPerProfile,
Signin.ReconcilerAddedToChrome and Signin.ReconcilerAddedToCookieJar.
There is also a UserCount called
AccountReconcilerDifferentPrimaryAccounts. These can be viewed in
chrome://histograms and chrome://user-actions respectively.
The Profile one can be viewed any time a profile is opened. The others
are best tested the first time you Sign In to Chrome, assuming you
already were signed in to google in the content area with 1 or more
accounts.

Review URL: https://codereview.chromium.org/270673003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269789 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269786 0039d316-1c4b-4281-b951-d872f2087c98

commit 919148f94db54fc04d287eb6a42c0c36b166bbfa
Merge: e2ca3c3 84a5bd9
Author: Jonathan 'Wolf' Rentzsch <jwr.git@redshed.net>
Date:   Sun May 11 21:51:20 2014 -0500

    Merge pull request #16 from mark-chromium/patch-1

    [FIX] Stop using mach_host_self and host_page_size, fixing a port
    right leak. (Mark Mentovai)

commit 84a5bd929213b9e0f059d3bc8c5b738e9fe4e620
Author: Mark Mentovai <mark@chromium.org>
Date:   Fri May 9 16:40:10 2014 -0400

    Stop using mach_host_self and host_page_size, fixing a port right
    leak

    It is incorrect to use mach_host_self without disposing of the send
    send right to the host port with mach_port_deallocate when done with
    it. http://crbug.com/105513 shows the sorts of problems that can
    arise when send rights aren’t properly deallocated.

    mach_host_self was only used by mach_override to be able to call
    host_page_size. host_page_size is unnecessary, because it always
    returns a constant value, PAGE_SIZE, which is also known at
    user-land compile time. See libsyscall/mach/mach_init.c. User code
    is better off just using this macro directly, and not fumbling with
    the system calls to obtain and properly dispose of a send right to
    the host port.

    (You need to mach_port_deallocate the ports you get from
    mach_host_self and mach_thread_self, but you must not normally
    deallocate the one from mach_task_self, because mach_task_self is
    actually just a macro that references a global variable. It doesn’t
    add any port rights at all. See <mach/mach_init.h>. If you bypass
    the macro and call the real mach_task_self system call, you do need
    to call mach_port_deallocate, but this situation is incredibly
    rare.)

R=rsesek@chromium.org

Review URL: https://codereview.chromium.org/282523004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269785 0039d316-1c4b-4281-b951-d872f2087c98

This simplifies NexeLoadManager, which is getting pretty big. This also removes
an unused field from ProgressEvent, and adds a convenience function for posting
a task to dispatch a progress event from the main thread, which is often
necessary to ensure that progress events are posted to the DOM after other
state changes.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269362

R=dmichael@chromium.org

Review URL: https://codereview.chromium.org/270453004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269784 0039d316-1c4b-4281-b951-d872f2087c98

BUG=360588
NOTRY=true

Review URL: https://codereview.chromium.org/284513002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269782 0039d316-1c4b-4281-b951-d872f2087c98