- 27 Nov, 2018 40 commits
-
-
Nigel Tao authored
This will lessen the code review noise in an upcoming commit. Change-Id: I4e933def4b6a10f45ce7545ce990c646a04a7aa4 Reviewed-on: https://chromium-review.googlesource.com/c/1349512Reviewed-by:
Drew Wilson <atwilson@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#611342}
-
Hao Zhang authored
When offering save of expired credit cards with the expiration date fix flow, disables showing the outdated expiration date initially imported (because it will be changed to whatever the user enters in the fix flow anyway.) Bug: 899057 Change-Id: I79c1861046768f0f5470e4c73834784472f29f91 Reviewed-on: https://chromium-review.googlesource.com/c/1350880 Commit-Queue: Hao Zhang <hozhng@google.com> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#611341}
-
Xi Han authored
This relands commit f481306a. The CL got reverted because BrowserMainLoopTest.CreateThreadsInSingleProcess is falling on Windows. In this CL, we remove the call of BrowserMainLoop#InitilaizeMojo() which isn't necessary for the test. Beside, also re-enable two tests which were disabled when the reverting CL landed: * RenderThreadImplBrowserTest.NonResourceDispatchIPCTasksDontGoThroughScheduler The original cl description is: This CL instantiates the ServiceManagerContext before creating the BrowserMainRunner. It splits the startup path into two, with/without starting the full browser. The changes are implemented behind a flag "allow-start-service-manager-only". Bug: 846846,902311 Change-Id: I6e3f6518e414e1298e57b55bd188879461d8f342 Reviewed-on: https://chromium-review.googlesource.com/c/1327413 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#611340}
-
Jesse McKenna authored
Bug: 889029 Change-Id: Ib8e3967d73a0844ba0d0a9ddb318168e0de1594d Reviewed-on: https://chromium-review.googlesource.com/c/1349459 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#611339}
-
Lindsay Pasricha authored
Move to 4 targets: common_lib, ui_lib, test_lib, app_framework Based on the EG2 xcodeproject on github. Also rolled EG2 to a more recent commit hash. Bug: 906201 Change-Id: Ifee6d4de17d8df930ac4760714ee32b0cab89cb5 Reviewed-on: https://chromium-review.googlesource.com/c/1340531Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> Cr-Commit-Position: refs/heads/master@{#611338}
-
Vlad Tsyrklevich authored
This is a reland of 409ceb85 Original change's description: > GWP-ASan: Add crash handler hook. > > After a GWP-ASan exception occurs, a crash handler hook (e.g. a crashpad > UserStreamDataSource) is responsible for looking at the crash and > 1) determining if the exception was related to GWP-ASan, and 2) adding > additional debug information to the minidump if so. > > The crash handler hook determines if the exception was related to > GWP-ASan by finding the AllocatorState address (using a crash key), > reading the allocator state and seeing if the exception occurred in the > bounds of the allocator region. If it did, we extract debug information > about that allocation and report it in the minidump. > > CQ-DEPEND=CL:1339246 > > Bug: 896019 > Change-Id: I63d12b5137098b20ec946e3bddbdcabaf20e430a > Reviewed-on: https://chromium-review.googlesource.com/c/1330283 > Reviewed-by: Mark Mentovai <mark@chromium.org> > Reviewed-by: Brian White <bcwhite@chromium.org> > Reviewed-by: Vitaly Buka <vitalybuka@chromium.org> > Cr-Commit-Position: refs/heads/master@{#611033} TBR=bcwhite@chromium.org Bug: 896019 Change-Id: Ibc35c33ccc816cd2436412e2c6f399908161e7e1 Reviewed-on: https://chromium-review.googlesource.com/c/1351935 Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Cr-Commit-Position: refs/heads/master@{#611337}
-
Bailey Berro authored
This change moves the error toast to the dialog when mounting an SMB share. Previously the flow was: - Click add mount - Dialog closes to SMB Shares parent page - Error/success string is displayed on parent page Now the flow will be: - Click add mount - Dialog stays open but add button becomes disabled - Error/success string is displayed on dialog itself An added advantage of this change is that it improves user experience as it is easier for users to debug error cases when the dialog is still open and they can still see the information they entered. Bug: chromium:887135 Test: browser_tests --gtest_filter=CrSettingsSmb* Change-Id: I6f68cd71a0002372a45975b3d8602809b36a6754 Reviewed-on: https://chromium-review.googlesource.com/c/1316664 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#611336}
-
Xiaocheng Hu authored
As cold mode idle time spellchecker is shipped into M69 Stable and no regression is obversed, this patch removes the flag as cleanup. Bug: 716642 Change-Id: I0b75e7592be063cb53ee9eb68dbf3f0c1af48dd4 Reviewed-on: https://chromium-review.googlesource.com/c/1351869 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#611335}
-
Steve Kobes authored
Bug: 581518 Change-Id: Icc8ef5e53428500a54695bf1a70cda139556ba67 Reviewed-on: https://chromium-review.googlesource.com/c/1349669Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#611334}
-
Paul Jensen authored
They're not used and this change can be easily reverted to add them back. Bug: 908717 Bug: 906936 Change-Id: I81f866c7491a84c1c5b0c87c023d3e43cf9d3a8c Reviewed-on: https://chromium-review.googlesource.com/c/1352330Reviewed-by:
Misha Efimov <mef@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#611333}
-
Jared Saul authored
I want to fix some incorrect function ordering in these files, but I can't upload the CL because it moves a banned base::Closure. Thus, this CL fixes that problem first. Change-Id: I45142929b28015f18d1d848be8cc9eca6ac2f614 Reviewed-on: https://chromium-review.googlesource.com/c/1351256Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Tao Bai <michaelbai@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#611332}
-
Adrienne Walker authored
In https://chromium-review.googlesource.com/c/chromium/src/+/1315962, code was added to add a separate ImageDecodeCache per color space (rather than storing color space on the image objects). However, because CanvasResourceProviders post a task to clean up these locks, the high water mark for discardable memory could be much higher if multiple canvases with different color spaces are used. This has resulted in crashes in shared memory allocation. To work around this for software mode, release locks immediately. This lets the software decodes rely on the discardable system itself to handle the caching behavior instead of blindly locking them until javascript was done executing. Ideally all of this code can be eliminated in the future, which is why a workaround is employed here instead of something more complicated. Bug: 907100 Change-Id: If6380b9e40f6334c125581c2c65f72543d6bb745 Reviewed-on: https://chromium-review.googlesource.com/c/1351773Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#611331}
-
Caleb Rouleau authored
It would be great if I could review changes like https://chromium-review.googlesource.com/c/chromium/src/+/1352339 since I am taking ownership of benchmarking project as a whole. Change-Id: I9c7b65adb5e18e30c6b9c6cdf1fb9f74ff064aea Reviewed-on: https://chromium-review.googlesource.com/c/1351561Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#611330}
-
agrieve authored
This reverts commit 282d95d7. Reason for revert: Still has a missing dep: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8928671892382176864/+/steps/compile__with_patch_/0/stdout Original change's description: > Reland "Cronet: Simplify Android GN logic for srcjars by not using them" > > No need to zip up the generated source just to unzip it again :P > > This reverts commit f4e7bed3. > > Reason for reland: Fixed missing deps in __final_jni template > > TBR=pauljensen@chromium.org,agrieve@chromium.org > > Bug: 908479 > Change-Id: I1177d550eb33737f47192bd70db5358c6392598c > Reviewed-on: https://chromium-review.googlesource.com/c/1351930 > Commit-Queue: agrieve <agrieve@chromium.org> > Reviewed-by: agrieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#611108} TBR=pauljensen@chromium.org,agrieve@chromium.org Change-Id: I5f10f94e023f7413fb19d85624013fbddcb732a5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 908479 Reviewed-on: https://chromium-review.googlesource.com/c/1352516Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#611329}
-
Nick Harper authored
TBR=bnc@chromium.org Change-Id: I789217b4d8eac5be728a38077fb0b0ddc238de36 Reviewed-on: https://chromium-review.googlesource.com/c/1351895Reviewed-by:
Nick Harper <nharper@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#611328}
-
David Black authored
Previously, out of process calls to AssistantScreenContextController and AssistantSetupController were proxied through AssistantController. Now, we expose those subcontrollers directly for binding. Bug: b:119272394 Change-Id: I136d0e025761b4fe99151218512f83eeb00a6541 Reviewed-on: https://chromium-review.googlesource.com/c/1327532 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#611327}
-
Sebastien Lalancette authored
- When suggestions are shown, - When a suggestion has been selected. Added UMA histograms, and extended unit test coverage of some metrics. Also tested manually by looking at local histograms after playing around a test page. Bug: 907902 Change-Id: I5f7a363416d3c0c4b7e1b44a782d5205ed7a6787 Reviewed-on: https://chromium-review.googlesource.com/c/1352331Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#611326}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5552cdf032dd..4f2b94cb9a6b git log 5552cdf032dd..4f2b94cb9a6b --date=short --no-merges --format='%ad %ae %s' 2018-11-27 geofflang@chromium.org Expose EXT_color_buffer_half_float if RGBA16F is renderable. 2018-11-27 jiajia.qin@intel.com ES31: Add swizzle support in SSBO (Part 1) 2018-11-27 jdarpinian@chromium.org WebGL, D3D: Forbid multiple TF outputs in one buffer Created with: gclient setdep -r src/third_party/angle@4f2b94cb9a6b The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:866089 TBR=fjhenigman@chromium.org Change-Id: I2f9f64d4e1a188df1612ecfb8c66b6129dc5a202 Reviewed-on: https://chromium-review.googlesource.com/c/1352244Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#611325}
-
Steven Bennetts authored
Bounds passed over mojo should be in Screen coordinates since Chrome and Ash do not share a common window tree in Mash. For comment-only change to keyboard_controller.mojom: TBR=tsepez@chromium.org Bug: 843332 Change-Id: I40cee828ee5872cf69c4589141a9bb79c7c08cee Reviewed-on: https://chromium-review.googlesource.com/c/1351801 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#611324}
-
Mitsuru Oshima authored
I also added a unit test for occlusion tracker pause during overview transition. Bug: None Test: covered by unittests. Change-Id: I5e8441e176eaa0dc9793d22059edb22e357d899e Reviewed-on: https://chromium-review.googlesource.com/c/1344888 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#611323}
-
David Bienvenu authored
If there are no visible app windows, restoring app window wasn't re-registering events because OnWindowVisiblityChanged notification wasn't generated for root window. Add unit test for going from visible to hidden to occluded. Bug: 813093 Change-Id: I11b5fd7c7dc104ec74699c8e66aa06d9954a5977 Reviewed-on: https://chromium-review.googlesource.com/c/1326621 Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#611322}
-
Ryan Hansberry authored
Allowing overflow scrolling lets users with high page zoom settings scroll across and down overflowing content. Bug: 899774 Change-Id: I9bb6a8ea622b61c1d7b76d3cadb0f9be694fe4d3 Reviewed-on: https://chromium-review.googlesource.com/c/1343191Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#611321}
-
Nicolas Pena authored
This CL aligns the IDL with the spec. Intent to Ship: https://groups.google.com/a/chromium.org/forum/?utm_medium=email&utm_source=footer#!msg/blink-dev/Z3RKovFsA1s/DWt78xngAgAJ Bug: 898768 Change-Id: I88dbc89d30aac7840c47d727d2ed3c8044452b68 Reviewed-on: https://chromium-review.googlesource.com/c/1352429Reviewed-by:
Yoav Weiss <yoav@yoav.ws> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#611320}
-
jonross authored
Currently RenderWidgetHostViewAura allocates a new LocalSurfaceId upon Navigation. However if this navigation is for a hidden view, then we are allocating very early. This has skewed the statistics for embedding times. This updates RenderWidgetHostViewAura::DidNavigate to Invalidate the LocalSurfaceId if hidden. A new one will be allocated once the view is shown. Bug: 655231 Change-Id: I86cc4efade8b927149f57323281a87b0dcd1aac3 Reviewed-on: https://chromium-review.googlesource.com/c/1347446 Commit-Queue: Jonathan Ross <jonross@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#611319}
-
Antoine Labour authored
This is to ensure the memory is properly released on the GPU process side. Bug: 905495 Change-Id: I152494878a602e748eefb29f0f91f364e6752e42 Reviewed-on: https://chromium-review.googlesource.com/c/1347355 Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#611318}
-
Chris Harrelson authored
This ensures that that token is always at the end of a token chunk. This is important because the parser can only yield or pause at token chunk boundaries. Pausing may be forced by a custom element because its createdCallback routine may add a stylesheet, which blocks the HTML parser. Bug: 904966 Change-Id: I9252067f435d048b860cc9725ba23d829c9f644d Reviewed-on: https://chromium-review.googlesource.com/c/1351366Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#611317}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4f83c59eea19..09523b43fc28 git log 4f83c59eea19..09523b43fc28 --date=short --no-merges --format='%ad %ae %s' 2018-11-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 4ad2322aa9cf..67c93d206431 (1 commits) 2018-11-27 mtklein@google.com Reland "move decal_filter_scale inline, walk decal in 32.32"" 2018-11-27 brianosman@google.com Remove tonalshadows GMs 2018-11-27 reed@google.com Revert "migrate to passing paint/ctm for bounds" 2018-11-27 borenet@google.com [infra] Blacklist another SKP for IntelHD405 Vulkan perf bot 2018-11-27 mtklein@google.com Revert "move decal_filter_scale inline, walk decal in 32.32" 2018-11-27 michaelludwig@google.com Reland "Optimize trivial per-edge aa rect tessellation" 2018-11-27 mtklein@google.com move decal_filter_scale inline, walk decal in 32.32 Created with: gclient setdep -r src/third_party/skia@09523b43fc28 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=borenet@chromium.org Change-Id: I4c858d036efb7c4ed9c94a64b17c2e563594b677 Reviewed-on: https://chromium-review.googlesource.com/c/1352241Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#611316}
-
kyle Ju authored
Test bless.html on a local linux machine and all test runs passed. Thus remove bless.html from the TestExpectation file. Bug: 875249 Change-Id: Ic5de42921e496e199b3be79e9920e5366205e9ee Reviewed-on: https://chromium-review.googlesource.com/c/1351599 Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#611315}
-
Mike Dougherty authored
This CL removes macro usage from /ios/chrome/browser/itunes_urls. This CL was uploaded by git cl split. R=mrefaat@chromium.org Bug: 589840 Change-Id: I38d1ef88b752deda3e77f02fdb7208ddc13cd214 Reviewed-on: https://chromium-review.googlesource.com/c/1351964Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#611314}
-
Owen Min authored
Read $policy_dir/enrollment/CloudManagementEnrollmentOptions file. If it contains 'Mandatory', then the enrollment is forced. Bug: 904983 Change-Id: I44452f1c016a0432bf541b3ee6605f24ec3898ff Reviewed-on: https://chromium-review.googlesource.com/c/1349773 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Georges Khalil <georgesak@chromium.org> Cr-Commit-Position: refs/heads/master@{#611313}
-
Nektarios Paisios authored
Also, enables Option-Up and Option-Down on the Mac. R=sky@chromium.org, aleventhal@chromium.org, dmazzoni@chromium.org, pboss@chromium.org Change-Id: I78b32b170e4600c14faf81fdfb1850bb0a720cd6 Bug: 908522 Reviewed-on: https://chromium-review.googlesource.com/c/1337819 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#611312}
-
Mike Dougherty authored
This CL removes macro usage from /ios/web/public/test. This CL was uploaded by git cl split. R=eugenebut@chromium.org Bug: 589840 Change-Id: I507c145fbe39d32120bec413834873ed2d92604e Reviewed-on: https://chromium-review.googlesource.com/c/1351963Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#611311}
-
rajendrant authored
Bug: 898326 Change-Id: Ife17e6b2ce3ad21d5049377318a8e14c70e5ec98 Reviewed-on: https://chromium-review.googlesource.com/c/1351591 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#611310}
-
Henrique Grandinetti authored
Bug: 908443 Change-Id: Icf41f1753450cee63b9296652599f5eb7c4de671 Reviewed-on: https://chromium-review.googlesource.com/c/1351149 Commit-Queue: Henrique Grandinetti <hgrandinetti@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#611309}
-
Thomas Tangl authored
- The kUnifiedConsentGiven pref and the APIs SetUnifiedConsentGiven() and IsUnifiedConsentGiven() are removed from UnifiedConsentService and all dependent services. - UnifiedConsentService::EnableGoogleServices() is added to enable all Google services tied to Unified Consent during opt-in. - The metric UnifiedConsent.RevokeReason is made obsolete. - The item of the histogram UnifiedConsent.SyncAndGoogleServicesSettings that recorded the state of the kUnifiedConsentGiven pref now records the state of kAllUnifiedConsentServicesWereEnabled. Note: This pref is set to true when the user enables all Google services by going through the new opt-in dialog. - Move the code enabling contextual search to UnifiedConsentServiceClient. Bug: 906031 Change-Id: I19bad51196f3bd01c700ad23da117615f32d7c74 Reviewed-on: https://chromium-review.googlesource.com/c/1346400Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#611308}
-
Casey Piper authored
When a registration request is received by Cryptotoken, proxy that request to WebAuthn. Bug: 906881 Change-Id: Ie3aac8bfb8bd4349eb29e7741bd5242b70842236 Reviewed-on: https://chromium-review.googlesource.com/c/1342687 Commit-Queue: Casey Piper <piperc@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#611307}
-
Aaron Colwell authored
- Add ContentBrowserClient::ShouldDisableSiteIsolation() so embedders can disable Site Isolation. - Move Chrome memory checks in ChromeContentBrowserClient from ShouldEnableStrictSiteIsolation() to ShouldDisableSiteIsolation() so they can also disable Site Isolation. - Added tests that verify memory constraints now disable trial isolated origins Bug: 899116 Change-Id: Ibe4cbb93486db7e70cadf9a306d33606a8b33510 Reviewed-on: https://chromium-review.googlesource.com/c/1347443 Commit-Queue: Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#611306}
-
Dale Curtis authored
We should be able to avoid this with careful use of a trampoline through the media thread after PipelineImpl::Stop() completes. This is an updated version of the last CL: https://chromium-review.googlesource.com/c/chromium/src/+/1336659 The difference is we now also preserve the RendererFactorySelector until after renderer shutdown. This passes all the failing tests I could find locally. BUG=521176, 905506 TEST=passes cq. R=sandersd Change-Id: I86c4814a91ee6c41f20f6bb8a05859ac44171d7e Reviewed-on: https://chromium-review.googlesource.com/c/1351791Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#611305}
-
Andres Calderon Jaramillo authored
This CL adds a ScheduleImageDecode() method to RasterInterface that locks a transfer cache entry and sends an image decode request. This is done so that it's convenient for the GpuImageDecodeCache to eventually request image decodes. Note that a new interface was introduced: ImageDecodeAcceleratorInterface. This is necessary to allow RasterImplementation to use ImageDecodeAcceleratorProxy without breaking dependencies. Bug: 868400 Change-Id: Ib24ffa9f5855cc843e1bf83ef4cd2ebb039c04d8 Reviewed-on: https://chromium-review.googlesource.com/c/1313671Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#611304}
-
Aaron Krajeski authored
https://chromium-review.googlesource.com/c/chromium/src/+/1351501 has reverted some perf changes due to high-end mac laptops crashing. Re-add that CL piece by piece, starting here. Re-add 2 tests: a render of google-sheets and an intense shader-based test that will be GPU bound. Bug: 908515 Change-Id: I2d371c1db7e5e1502367fb7c2093f4ec521f3b62 Reviewed-on: https://chromium-review.googlesource.com/c/1352339Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Cr-Commit-Position: refs/heads/master@{#611303}
-