- 28 Jul, 2020 40 commits
-
-
Maria Kazinova authored
Bug: 1075444 Change-Id: I229f5ca4c20bae2d4dda248d88bd80002b960a77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320269 Commit-Queue: Maria Kazinova <kazinova@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#792199}
-
rajendrant authored
This CL adds API to stop the throttling which resumes the paused media responses immediately. Subsequent CL will make use of this to stop throttling on video play stalls. Bug: 1082554 Change-Id: I51137a1158e8aed8bd63e7a6db344aefe94a6720 TBR: kinuko@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309005 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#792198}
-
Tim Schumann authored
These tests are flaky on multiple platforms: NoAutoReloadWhenContentsHidden AutoReloadWhenContentsBecomeVisible BUG: 1110259 TBR=rockot@google.com Change-Id: I2d59b5464a5ff12edb1c66df593b169039378dbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320792 Commit-Queue: Tim Schumann <tschumann@chromium.org> Reviewed-by:
Tim Schumann <tschumann@chromium.org> Cr-Commit-Position: refs/heads/master@{#792197}
-
Jérôme Lebel authored
Adding APIs declaration to support multi windows with SSO. For ChromeIdentityService: bool HandleSessionOpenURLContexts(UIScene* scene, NSSet*) void ApplicationDidDiscardSceneSessions(NSSet*) => crrev.com/c/2316308 API declarations * crrev.com/i/3182384 Implementing APIs * crrev.com/c/2317321 Switching code to use the new APIs Bug: 1103833 Change-Id: I28b5f6c98c23d9c1424500816bf713756bab4c05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316308Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#792196}
-
Rakina Zata Amni authored
See crbug.com/1096135 for context. When doing same-site navigations, we might do a proactive BrowsingInstance swap, but we will reuse the renderer process whenever we can. On history navigations between pages that are same-site but have different BrowsingInstances (not only on cases that are caused by proactive BI swap), we should try to reuse the renderer process. Bug: 1096135 Change-Id: I58f72bedecbbf94e4e05218bb9c15970a502d8a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282553 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#792195}
-
Ren-Pei Zeng authored
crrev.com/c/2234684 introduces a new buffer usage flag for hardware VEA (SCANOUT_VEA_READ_CAMERA_AND_CPU_READ_WRITE). On Kukui this changes buffer layout, and the camera driver failed to capture correct content into the buffer in the RAW->YUV reprocessing case. Since the reprocessing YUV buffer is not used for video encoding, this CL changes the buffer usage for that use case back to the original (SCANOUT_CAMERA_READ_WRITE). This CL also cleans up places that hard-code buffer usage, or makes it verbose when it has to do so. Bug: 1105154 Test: capture_unittests Test: CCA preview, video recording, take normal/Portrait photo (with #zero-copy-video-capture flag on and off) Change-Id: I1c3d88f361faad43994fbf6fedc9514de7947366 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315725Reviewed-by:
Ricky Liang <jcliang@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Ren-Pei Zeng <kamesan@chromium.org> Cr-Commit-Position: refs/heads/master@{#792194}
-
Ian Kilpatrick authored
When we had a column flex-item, which was also a grid, where the percent template added up to something >100% on each layout the grid would grow larger. This was caused by some logic to fix relative-positioned children in: https://chromium-review.googlesource.com/c/chromium/src/+/2093273 However when this value was read within layout, it could refer to the previous layout. If numerous layouts occurred sequentially, this would cause the layouts to grow unbounded. This patch disables this path when read during layout for a flex-item (in NG). During layout the flex-item should have a BoxLayoutExtraInput set. Bug: 1108928 Change-Id: I4d0d41755c9d33eb2b4c217ee6bfdb1acd48cbbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320418Reviewed-by:
David Grogan <dgrogan@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#792193}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Id05e6144b0686b0dfa421f20a38e9dda128947f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2322211Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792192}
-
Tymofii Chudakov authored
This CL fixes the bug in the security_page.html of the chrome privacy settings with the automatic option collapsing while the confirmation dialog pops up. An additional flag is added to the collapse_radio_button.js which disables automatic collapsing. Bug: 1096968 Change-Id: I0dcc56d9ab6f2649ad6e707edbbb631803685c05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294802Reviewed-by:
Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
Sean Harrison <harrisonsean@chromium.org> Commit-Queue: Tymofii Chudakov <tchudakov@chromium.org> Cr-Commit-Position: refs/heads/master@{#792191}
-
Ravjit Singh Uppal authored
Bug: 1096944 Change-Id: If9f17a927771731f8c009a724a3e34d84f73fadb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299629 Commit-Queue: Ravjit Singh Uppal <ravjit@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#792190}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b3038f8cb5c5..6007f3bd6f36 2020-07-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 3f851efa2adc to de309a42385f (16 revisions) 2020-07-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 3b2cd31c7400 to 12c9d4ac61f2 (4 revisions) 2020-07-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from d5a4775cfc77 to c11a19145f1f (3 revisions) 2020-07-28 johnstiles@google.com Fix self-assignment error in SkBitSet. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1085700 Tbr: borenet@google.com Change-Id: If9cba9059a5f859a3d27ab3d28960be4f15c3d7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2322078Reviewed-by:
-
Jan Wilken Dörrie authored
This change modifies the invoke(), begin() and end() function to be constexpr in //util/ranges. This allows making some of the algorithms constexpr as well, which is done in this change for all_of, any_of and none_of. Bug: 1071094 Change-Id: Ic72a5287dfa4623342e5ef5f592b19040797def7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316211 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#792188}
-
Mikel Astiz authored
This patch migrates tests away from deprecated APIs and adopts TestingProfile::Builder for tests in /chrome/browser/android/signin. Rationale: creating or overriding keyed services after the profile has been created is problematic and known to cause hard-to-debug test flakiness, because it bypasses BrowserContextDependencyManager and often leading to use-after-free. This CL was uploaded by git cl split. R=bsazonov@chromium.org Bug: 1106699 Change-Id: Ifa14602b1dab9f9c965e7e4dd55fac20f5cd68d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315154 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#792187}
-
Christopher Lam authored
This CL moves the centralized style sheet to ui/chromeos/colors since it's being used for Views as well as WebUI. A new chrome://resources alias was added so the file can be accessed through chrome://resources/chromeos/colors/cros_colors.generated.css. Bug: 1018654 Change-Id: If7fb5c0aed3fa30746df32587e818a4f420ba49c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306140Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#792186}
-
Steve Anton authored
Bug: 1108472 Change-Id: Ifd5c26736460b3c9f615f99a5abaf909a81b6618 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321847 Auto-Submit: Steve Anton <steveanton@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#792185}
-
Tim Schumann authored
This reverts commit 9c96261a. Reason for revert: This appears to have broken external/wpt/html/cross-origin-opener-policy/reporting/access-reporting/openee-accessed_openee-coop-ro.https.html BUG: 1110254 Original change's description: > [COOP] Access reporting. Fix the python server. > > A python server is used has a communication channel in between documents > from different browsing context group and potentially cross-origin. > > There are two methods: > - one for writing a message. > - one for reading the message. > > I initially supposed we won't need to store more than one message in the > stash. It turns out there are tests doing two write in a row without any > read in the middle. It was throwing an exception when this > happened. > > This patch makes the server to maintain a queue of messages instead. It > doesn't throw errors anymore. > > Bug: chromium:1109194 > Change-Id: I25f8dc2c2a032781a4527a0994e94e46f85e12c9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317865 > Reviewed-by: Pâris Meuleman <pmeuleman@chromium.org> > Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#791901} TBR=clamy@chromium.org,arthursonzogni@chromium.org,pmeuleman@chromium.org Change-Id: I87ba2caa07f80f42aa549929ade392485b968d6f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1109194 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320572Reviewed-by:
-
Himanshu Jaju authored
IncomingShareTargetInfo is used to encapsulate remote device connection details, and IncomingFramesReader is used to read incoming frames from this target. Supports timeout for reading frames as well as cache for unused frames. Bug: 1085068 Change-Id: I94d6f6453031f1c3172d4fecc7370ca15b0c37c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306032 Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#792183}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/0dde0b31cf31..1ed85887c9ec 2020-07-28 kahinds@microsoft.com Detect URL-only strings in localizability check script If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iea3b3b7327a12caf7c775321b039a58ff339d141 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321955Reviewed-by:
-
Zufeng Wang authored
The pref was registered and set in https://chromium-review.googlesource.com/c/chromium/src/+/2294861/20/chrome/browser/chromeos/first_run/first_run.cc Bug: b/159964708 Change-Id: I5daf159e84fa3ec5ce8a70c95098155a199e8f50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321987Reviewed-by:
Rachel Carpenter <carpenterr@chromium.org> Commit-Queue: Zufeng Wang <zufeng@google.com> Cr-Commit-Position: refs/heads/master@{#792181}
-
Gauthier Ambard authored
This CL makes sure to check that there isn't a first responder before setting BVC as first responder. The omnibox can be the first resonder at that point when opened from 3D touch. Fixed: 1103635 Change-Id: I901bebd33ceced169d9848ca8c785d5ef8913ca1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315035 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#792180}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2bdb4051. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools rego@igalia.com: external/wpt/css/css-grid NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Change-Id: I0aa18efc4e8cfc293de2103755faa42d9f6f8abe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321451Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792179}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Id381b1f99a320fbf7c5ce121460dd08736ed1e10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321947Reviewed-by:
-
Keith Lee authored
The committed text length will be used by InputMethodChromeOS to determine the number of characters committed by users. Bug: 1109604 Change-Id: I476539fc38f35f3986a9a05de22f7b8fa9ecd0fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318892 Commit-Queue: Keith Lee <keithlee@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#792177}
-
Hitoshi Yoshida authored
This reverts commit 414b62b0. Reason for revert: Regresses a test on Mac. Bug: 1110239 Original change's description: > Set initial focus on session restore > > Issue: > - When On startup setting is set to "Continue where you left off", > the initial focus is not set after launching the browser. > - Users have to press Tab to focus the window. > - This affects users who rely on screen readers since the window > information is not announced on launch (on UIA mode). > > More context: > - The line calling SetInitialFocus was previously in the code but got > removed after a startup focus refactor: > https://chromium-review.googlesource.com/c/chromium/src/+/1313728 > - The refactor added the call to RestoreFocus on > BrowserView::OnWidgetActivationChanged if the property > restore_focus_on_activation_ is set to True. This property gets set > during BrowserView::Show, but only in the case of session restore, > Show gets called after OnWidgetActivationChanged so RestoreFocus is > never called. > - The inverted call stack on session restore is because AddRestoredTab > on browser_tabrestore calls Activate before showing the window. > > Fix: > - Similar to what we currently have for MacOS, only call Activate > in AddRestoredTab if it is not |from_session_restore|. This way Show > will be called before Activate and thus focus will be set as > expected. > - This change is only made on Windows due to a couple of reasons > 1) crbug.com/1102685 is only present on this platform. > 2) Making this change on Linux would re-introduce crbug.com/1019048. > > Bug: 1102685 > Change-Id: I6e62ebad7693eb5d908770364ba7c8d755ccaa70 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284382 > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: Maria Villarreal <mavill@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#791950} TBR=xiyuan@chromium.org,sky@chromium.org,fdoray@chromium.org,mavill@microsoft.com Change-Id: I258891124447cb71b163b35452b84b999857cf96 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1102685 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2322266Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#792176}
-
Alex Danilo authored
CL:1490354 removed a touch-mode flag. As part of that removal, a potentially useful comment was removed. Reinstate the removed comment. Bug: 934467 No-try: true Change-Id: If4ed10e4361d27d115137ad7e90d5c569bc183a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321911Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#792175}
-
Rainhard Findling authored
* This CL supersedes the previously failed attempts to land those tests (see crrev.com/c/2285386). * Test that each possible CCT status results in the corresponding safety check child status and display string. * Test that CCT being enterprise managed is handled correctly. Bug: 1087263 Change-Id: If13b4458c60b6a5a6c82f1e42e41ebec95d81da1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292213 Commit-Queue: Rainhard Findling <rainhard@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#792174}
-
GioVAX authored
Change-Id: I7e3bb2e1a8a9bc848f3663e8b8edc2c2860dee16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320609Reviewed-by:
Bartosz Fabianowski <bartfab@chromium.org> Commit-Queue: Giovanni Pezzino <giovax@google.com> Cr-Commit-Position: refs/heads/master@{#792173}
-
Jan Wilken Dörrie authored
This change simplifies wstring_embedded_nulls.mojom by removing the union and making it a simple struct wrapping an uint16 array. Bug: 911896 Change-Id: Idd4042f6a7bee8f066f6ce6477d6e5967b4d12be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320571 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
-
Hitoshi Yoshida authored
This reverts commit e2d335fb. Reason for revert: This CL triggers a compile error. Bug: 1110221 Original change's description: > Mac SxS: Don't ask to take default from other Chromium channels > > If another channel of Chromium is already default, don't ask to > become default. > > Bug: 1109417 > Change-Id: I095410b47a64731c7ca7fbafa5f3e3427ec89d42 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318193 > Reviewed-by: Mark Mentovai <mark@chromium.org> > Commit-Queue: Avi Drissman <avi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#792144} TBR=avi@chromium.org,mark@chromium.org Change-Id: I59a405e113cca1abc28c9c01c34166d572c60c31 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1109417 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2322008Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/1f16229c9be9..c11a19145f1f 2020-07-28 jiawei.shao@intel.com Support buffer lazy initialization before CopyTextureToBuffer 2020-07-27 enga@chromium.org Update max storage buffer bindings per stage to 6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I44bd4e012494bb54277fd0509149b13afde20d06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321952Reviewed-by:
-
Eric Roman authored
Bug: 1103764,1109329 Change-Id: I281784e3a1dfd22b2a62f6940d3544aa1060dad6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317751Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#792169}
-
Mikel Astiz authored
If the browser is shut down while in BACKUP_DISPATCHED (i.e. the task was posted but didn't complete yet), then prior to this patch there was a risk that BookmarkStorage was destroyed before the intended save took place, because there was no scheduled write in ImportantFileWriter. This situation should be rare in practice because making a backup is fast, but does lead to test flakiness, and can be reliably reproduced (e.g. with BookmarkBrowsertest.EmitUmaForDuplicates) if an artificial delay is introduced when generating the backup file. While fixing the issue, a few implementation details have been simplified: 1) Backup-generation does not require waiting until it completes before scheduling a regular write, since a SequencedTaskRunner guarantees the ordering in which the tasks will run (and copying a file is a synchronous operation). 2) There is no need to manually implement SaveNow(), since ImportantFileWriter does the same in DoScheduledWrite(). Change-Id: Ib1de11935b4e37d44e4ad79eb77365cfefb4ff7b Bug: 1108803 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320869 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
-
Honglin Yu authored
BUG=chromium:1086044 TEST=python pretty_print.py TEST=python validate_format.py Change-Id: Ia9636b12c195d52627d29e2c1ca0a24ba71bf136 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320392Reviewed-by:
Tony Yeoman <tby@chromium.org> Commit-Queue: Honglin Yu <honglinyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#792167}
-
Marc Treib authored
(as in, whether the actual database files exist on disk) This lets us delete the store (if the corresponding feature flag got disabled) only if it actually exists. This is an alternative (and maybe better) implementation of crrev.com/c/2300439. Bug: 1079297 Change-Id: I3ae84eb87b53e1e7b1e69a20afe68402a7095326 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320278Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#792166}
-
Wolfgang Beyer authored
Change-Id: I185fd95debae1b80e578fbf061f076cd490938b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316866Reviewed-by:
-
My Nguyen authored
This allows for tracking the opportunity for emoji suggestions. Bug: 1108251 Change-Id: Iffbf3b52f0abcde442e203a63c634e710765c6da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318487 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#792164}
-
Mathias Bynens authored
Downstream DevTools CL that impacts the expected results: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2318257 No-Try: true Bug: chromium:1103854 Change-Id: I9ba181977ca662f53d8bbd35b3f2753eb3be859d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320612 Commit-Queue: Mathias Bynens <mathias@chromium.org> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Auto-Submit: Mathias Bynens <mathias@chromium.org> Reviewed-by:
Alex Rudenko <alexrudenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#792163}
-
Jan Wilken Dörrie authored
This change adds a wstring.mojom to chrome_cleaner, renames string16_embedded_nulls.mojom to wstring_embedded_nulls.mojom and makes WStringEmbeddedNulls an alias for String16EmbeddedNulls. Bug: 911896 Change-Id: I9fbf8cb4e0252eb21f66fc89610438da44bd9df8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316357 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
-
Yuki Shiino authored
Bug: 839389, 1108111, 1109761 Change-Id: I67612b91346b98e6503ebb693b45ce1d9f8f0306 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320391Reviewed-by:
-
Trent Apted authored
CIPD package: https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/LmieCUDR23kDvDwIcb-H4-WhIUhmeI0M330ACBOQZIYC Release notes: http://go/media_app-x20/relnotes/Stable/media_app_20200727_RC00.html Bug: b/161847066, b/161687144, b/162047051, b/161959336, b/161405432, b/162183843 Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Change-Id: Iaf451beb875056c83daeb35fd98a852e8c6abd2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320909Reviewed-by:
Bugs Nash <bugsnash@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#792160}
-
