- 18 Mar, 2020 40 commits
-
-
Oksana Zhuravlova authored
This change removes OnInterfaceRequestFromFrame overrides from the following WebContentsObserver subclasses: - AwRenderViewHostExt - PaymentRequestBrowserTestBase - ExtensionWebContentsObserver These overrides are no longer used after the BrowserInterfaceBroker migration. Also marks WebContentsObserver::OnInterfaceRequestFromFrame as deprecated. Bug: 1035522 Change-Id: Ie870ecf28e27dd28af18480a38b01ab56927742f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107700Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#751431}
-
Sam Bowen authored
Add Chrome URL as a property value type and in the extractor, parse a string as a URL if the given property can be a URL. Bug: 1044251 Change-Id: I041ad0bb61c9dc4ba3a2093711c28b88e9adbdff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076704 Commit-Queue: Sam Bowen <sgbowen@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#751430}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/8561f1e80744..4cde8177699c git log 8561f1e80744..4cde8177699c --date=short --first-parent --format='%ad %ae %s' 2020-03-18 treehugger-gerrit@google.com Merge "tp: strip all info from release android trace processor" Created with: gclient setdep -r src/third_party/perfetto@4cde8177699c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ie65e4ca65435a5d60d07f2dc13259d07c89abc00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108662Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751429}
-
Chris Harrelson authored
Bug: 992765, 999019, 995119, 999209, 1045745 [1] https://chromium-review.googlesource.com/c/chromium/src/+/1773869 Change-Id: I80fa5a67740f6c8918e531dedb8bc77ec7f09bbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103708Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#751428}
-
Oksana Zhuravlova authored
This change adds information on how to register embedder-specific interfaces with BrowserInterfaceBroker, as well as a note about renderer kills when a binder for the requested interface is not found. Change-Id: I53651b969454313617bd51abe949ae9e5a471b84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107740 Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/30d08dd0e3c1..1850bf6d1781 git log 30d08dd0e3c1..1850bf6d1781 --date=short --first-parent --format='%ad %ae %s' 2020-03-18 sokcevic@google.com Add unit tests for git_find_releases Created with: gclient setdep -r src/third_party/depot_tools@1850bf6d1781 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Ieb49379cb4bb87bbefec1c79beab5657c3d61efe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108665Reviewed-by:
-
Clark DuVall authored
This hooks up permissions in WebLayer so permission contexts can be added as features are implemented. Right now, all permissions are denied. This includes a few minor fixes to permissions code that are needed for WebLayer to work properly. Bug: 1025609 Change-Id: I30d4c131d8d9c16e29140b0d6c45e955d577a719 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103295 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Reviewed-by:
-
James Cook authored
Enable OS sync in SyncTest, because the feature will be on by default, and because several ModelTypes become OS-specific (e.g. APPS, APP_LIST). Adjust a few test expectations as well. Bug: 1060289 Change-Id: Iee32868b4a2d1ac13b9e63787c2d5e140aa98139 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103651 Commit-Queue: James Cook <jamescook@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#751424}
-
Istiaque Ahmed authored
Use non-deprecated ParseJson instead, which directly returns base::Value anyhow. Bug: 932873 Change-Id: I56c017db0dc8f902284d51a00b95e45509f4a07f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107367Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#751423}
-
David Bokan authored
The text selection popup menu on Android is hidden while the user is scrolling the page. It does this by listening to changes in the GestureListenerManager which tracks the current state of scroll and zoom on a page. However, a page only has a single GestureListenerManager, owned by the top level RenderWidgetHostView(Android). Unfortunately, it seems like OOPIFs were never connected to it so the GestureListenerManager is completely unaware of scrolling within isolated subframes. This CL adds the plumbing to have child frames notify the root widget's GestureListenerManager about the state of any gestures inside them. We also remove the fling condition from IsScrollInProgress. This was necessary in the past where a GestureFlingStart was sent to the renderer after a GestureScrollEnd. However, today, a gesture sequence is entirely framed by a GestureScrollBegin and GestureScrollEnd so we need only listen for these events. Bug: 977215 Change-Id: Ie33245c569c0ce1f6896c1889fcedd6ca31fe2c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101986 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#751422}
-
Patrick Monette authored
This CL modifies PerformanceManagerImpl::DeleteNode() and PerformanceManagerImpl::BatchDeleteNodes() so that the nodes are no longer deleted if the task posted to the PM sequence is never run. This is necessary to ensure the invariant of the graph are still held during shutdown. At destruction, some nodes DCHECKs that their properties are valid according to the invariant of the graph. If the PM task runner has stopped executing its tasks, then those DCHECKs may spuriously fail because a dependent task was not run. This CL also fixes a lint warning by upgrading a loop to a range-based for loop. Bug: 1058705 Change-Id: I835c5aac5cfc9a12d52818e806ec5ba978af261c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106567Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#751421}
-
Elly Fong-Jones authored
These were both marked flaky in 2013. They pass locally, so let's try re-enabling them and seeing if they still flake. Bug: 85930 Change-Id: I6abe61923c8eb54360ae4ef5d93f08351262bd7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108627Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#751420}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d390847cf65f..38a7906eeb00 Created with: gclient setdep -r src-internal@38a7906eeb00 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ie8ba1a82e0a9887601d964ec5ec379c4c54a6800 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108663Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751419}
-
George Steel authored
Create a set of interpation tests for transforms which read the true computed value (as opposed to the resolved value returned by getComputedStyle() which differs drastically in the case of transforms, see https://drafts.csswg.org/css-transforms/#transform-property). As there is currently no universal way to get this value, each test comes in 3 versions: Two variants using computedStyleMap().get().toString() which is supported by chrome. These also have duplicate versions where the zoom property is set as it currently triggers some transform serialization bugs in blink. A version using commitStyles, which in implemented in both firefox and chrome, but currently gives resolved values instead of computed ones in chrome. These assume that "computed value serialization", when referring to a box-size dependent procedure, is used ion its historical context as a deprecated term for what is now "resolved value" (as returned by getComputedStyle()), and the serialization of the true computed value follows the property infobox. This interperetation is currently used by both Firefox and Chromium. A spec issue to update the language around resolved value is at https://github.com/w3c/csswg-drafts/issues/4869 Change-Id: I59afcc9f73906051212cc71570631509920ddc32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103520Reviewed-by:
Kevin Ellis <kevers@chromium.org> Commit-Queue: George Steel <gtsteel@chromium.org> Cr-Commit-Position: refs/heads/master@{#751418}
-
Yury Semikhatsky authored
The change enables top level target handler to auto-attach to service worker when they are created and pause their execution until runIfWaitingForDebugger is received from the client. This brings service worker functionality on par with pages and will enable automation tools to configure a service worker without attaching to every page that may use it. Design document: https://docs.google.com/document/d/1hbTowhyfrf6CaYuNEHjY_OVx2KgZmnbp8kg_wUdGFiA/edit# Bug: 1051687 Change-Id: I24ceb9398bce1ab00afbbe427c508e4fa5a7ead5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107792 Commit-Queue: Yury Semikhatsky <yurys@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#751417}
-
Rohit Agarwal authored
This CL refactors the test params provided by IncognitoDataTestUtils into IncognitoToIncognito, RegularToIncognito and IncognitoToIncognito. Bug: 1035770 Change-Id: Iea45dcb553684c129105252fbef5118eaf8dd747 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106177Reviewed-by:
Rohit Agarwal <roagarwal@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Cr-Commit-Position: refs/heads/master@{#751416}
-
Mila Green authored
Bug: 1055876 Change-Id: I43f29d7d3cd139905fc397d7d0282a39e18dc133 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108524Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
-
Mikhail Khokhlov authored
This CL makes stories in system_health_infinite_scroll benchmark more janky by scrolling faster and in different directions. This is an experiment to evaluate sensitiveness of jank metrics. Bug: b/150125501 Change-Id: I57813de1ab2b0a78841a4e4c7b0997cc342a18a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108147Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/master@{#751414}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/56a118c8..6325afac Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1d0b1d9ffd07dae3b36ed3cf2bc4b6722e6feeca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108642Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751413}
-
Olga Gerchikov authored
Per https://wicg.github.io/scroll-animations/#avoiding-cycles, snapshot scroll timeline state once per frame. Changes made: - Snapshotting is done by saving scroll timeline current time and phase. - Snapshot scroll timeline state as part of the ScrollTimeline constructor. - Every time ScrollTimeline needs to query current time or phase, use the snapshot. - Any scroller layout change calls scroll timeline invalidation. - When scroll timeline is invalidated outside of the document lifecycle update, its state is re-snapshotted and attached animations are marked as outdated. This is required to ensure correctness of user scripts that query animation properties after scroller updates, like the following: scroller.scrollTop = 100; console.log(anim.effect.getComputedTiming().localTime); console.log(timeline.currentTime); - If scroll timeline is invalidated during lifecycle update the same procedure of snapshotting and marking the animations as outdated runs right after the lifecycle update. Bug: 944449 Change-Id: Id4330a15501b3a1312803d06e4ab9e3130ee3ee1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005629 Commit-Queue: Olga Gerchikov <gerchiko@microsoft.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#751412}
-
Livvie Lin authored
Bug: 1058898 Change-Id: I0321b9d53a03c571463b7213eecd4ac8e9b99a44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107682Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Livvie Lin <livvielin@chromium.org> Cr-Commit-Position: refs/heads/master@{#751411}
-
John Smith authored
After https://chromium-review.googlesource.com/c/chromium/src/+/2079840, the NativeThemeDarkAura was almost entirely replaced by a forced to dark version of the platform native theme. This change cleans up the remaining usages as well as removing the files and any straggling includes and build references. Bug: 1058945 Change-Id: I2e10f5467ab3f85ec2af9e254f8f7b6e89b04d1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107686Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: John Smith <johnsm@microsoft.com> Cr-Commit-Position: refs/heads/master@{#751410}
-
Garrett Beaty authored
When the number of builders with the same name goes from 1 to >1 or vice-versa, transient infra failures occur because the scheduler configuration will be updated while there are already builds running that will attempt to trigger the old job name. This change removes that as a problem. Change-Id: I1547659f61912ef758edb53f86f2092e723a7c54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107805 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#751409}
-
Rouslan Solomakhin authored
This patch adds a constant for Google Play Billing, which will have its own logic added in upcoming patches. Bug: 1062362 Change-Id: If47b970b2d0c062bb4622fa0de032b3b38165e5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106885Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#751408}
-
Esmael El-Moslimany authored
The goal of this CL is to make the OneGoogleBar as functional as possible and allow collaboration with the OneGoogle team to make the OneGoogleBar completely functional as well as provide the ability to test end-to-end. The OneGoogleBar is hosted by chrome-untrusted://new-tab-page/one-google-bar. The WebUI NTP embeds this using an iframe. In order for OneGoogleBar overlays to work, this CL uses mouse event forwarding. While this may not be the approach used for launch, it will allow the NTP and OneGoogle teams to test the OneGoogleBar and iterate towards a better approach. The Gmail and Images links are also updated so they open in the top frame. This is temporary until the OneGoogleBar updates those links to use <a target="_top">. Bug: 1039913 Change-Id: Ic265d5bfd5c8728c6ff3b6556cede51c92571863 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106739Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#751407}
-
Hazem Ashmawy authored
No change to logic or user-facing UI. Refactor resuable error messages for webview package error and crash consent to be part of the layout file instead of adding them to the activities views at runtime. Bug: 1061164 Test: manually verify that error messages are shown/hidden as expected with no changes Change-Id: I5939b8c308130c31133d9db9442dc66d327b5245 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107985 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Auto-Submit: Hazem Ashmawy <hazems@chromium.org> Cr-Commit-Position: refs/heads/master@{#751406}
-
Nate Fischer authored
Instead of finishing the Activity, this dismisses the dialog when the user presses "cancel." This permits the user to see information about other crashes, even if they don't want to upload them. Bug: 1062500 Test: Manual Change-Id: Iee6d8e159aa61e77b1de1c97c7621f69657e9f52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108165 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Hazem Ashmawy <hazems@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#751405}
-
Patrick Monette authored
This change makes it possible to create a Node instance without having access to the graph immediately. This will allow making the PerformanceManagerImpl::Create*Node functions static, removing the need to expose PerformanceManagerImpl::GetInstance(). This change also introduce OnJoiningGraph() and OnBeforeLeavingGraph() that are meant to be overridden by derived classes instead of overriding JoinGraph() and LeaveGraph(). This avoids the need for subclasses to remember to call the base version of that virtual function. Bug: 1013127 Change-Id: Id443b8013e59a368fdfdc9a0df9a9929e814da52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107609 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#751404}
-
Eugene But authored
Breadcrumbs rely on NavigationContext::GetError inside WebStateObserver::DidFinishNavigation callback, so this CL allows to log net error code for Breadcrumbs. Additionally the change makes ios/web API more consistent as the same error is passed to WebClient::PrepareErrorPage and WebStateObserver::DidFinishNavigation. Updated tests to check for underlying error and net error code. Bug: 1046223 Change-Id: Ic048e8d6901455c8bdce1fc3e5a2ae7ed33bec10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108340Reviewed-by:
-
Aaron Leventhal authored
NOTRY=true Bug: 1062697 Change-Id: Icd9bb6aae9340c59577011ec19a75796bc5023c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107064Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#751402}
-
Juanmi Huertas authored
The rebase was missing a file. Now it's fixed. This is a reland of 7e0c31e0 Original change's description: > Adding new parameter raster_mode to CreateSharedImageProvider > > Adding a new parameter, raster_mode, that determines if the newly > created CanvasResourceProvider of SharedImage is GPU or CPU. > > In later changes we need to be able to specify this to be false, while > it was defaulted to true inside the CreateSharedImageProvider. > > Here we are just adding the new parameter and fixing all callsites with > true (as it was the earlier value). > > Bug: 1035589 > Change-Id: Ifb640dacf59b0c12ec098645f341bedc93a3ad96 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104213 > Reviewed-by: > Reviewed-by: Aaron Krajeski <aaronhk@chromium.org> > Reviewed-by: Khushal <khushalsagar@chromium.org> > Reviewed-by: Fernando Serboncini <fserb@chromium.org> > Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> > Cr-Commit-Position: refs/heads/master@{#751185} TBR=kbr@chromium.org Bug: 1035589 Change-Id: I427fb7a48c55641ceb81c62cd5e97d9cdd4e1064 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108166 Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Cr-Commit-Position: refs/heads/master@{#751401}
-
Henrique Nakashima authored
This can be used to force parameter values for unit testing. Bug: 1061485 Change-Id: Ic34dac0cb82bf82146b92869292f812dfebd84f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103259Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#751400}
-
Etienne Pierre-doray authored
Otherwise MayBlock may never reach timeout. Bug: 1038867 Change-Id: I6615b5e2447bd47aa22860c29eb87d000a85a77e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105460 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#751399}
-
Alan Screen authored
The user-desired Windows color settings are getting lost when doing PrintingContextWin::UpdatePrinterSettings(). This is due to the color settings getting ignored by the GDI DocumentProperties() call made from CreateDevMode(). The resulting default color setting provided from GDI ends up propagating through to PrintSettingsInitializerWin::InitPrintSettings(). Correct for this by patching the requested color settings into the resulting DEVMODE structure after CreateDevMode() (as opposed to before like for all the other supplied settings). Bug: 789538 Change-Id: I2c4597dba10051150f92baf361103343c1249066 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107575Reviewed-by:
-
Sajjad Mirza authored
When a dsym is present we can get the file that each initializer was from and compare against a list of accepted files. This helps support code coverage on the CQ, which adds 2 additional static initializers. When a dsym is not available, we fall back to counting how many static initializers there are and comparing that against a hardcoded number. Bug: 1059432 Change-Id: I6a1df68371a34724822343198afb14fdd1f9cff8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106349 Commit-Queue: Sajjad Mirza <sajjadm@chromium.org> Reviewed-by:
-
Stepan Khapugin authored
The comment implies that this code prevents side effects from profile changes past applicationWillTerminate from notifications, however no code path seems to touch the profiles/identities at all. Bug: None Change-Id: Ic2a31426e941875f48c31742877ae69d7c75add4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107482 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#751396}
-
yjliu authored
Bug: 1050649 Change-Id: I00606ad48007de35fb1d21420bf44dd042b4cf98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107057 Commit-Queue: Jun Liu <yjliu@chromium.org> Commit-Queue: Christopher Thompson <cthomp@chromium.org> Auto-Submit: Jun Liu <yjliu@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#751395}
-
Andrew Grieve authored
This reverts commit d80699f2. Reason for revert: Broke swarming again: https://ci.chromium.org/p/chromium/builders/ci/android-lollipop-arm-rel/783 Original change's description: > Reland "Make java_deobfuscate not require being built first" > > This reverts commit 0b8c0e6a. > > Reason for revert: Fixed runtime deps > > Original change's description: > > Revert "Make java_deobfuscate not require being built first" > > > > This reverts commit 962e7030. > > > > Reason for revert: Failing on swarming > > https://ci.chromium.org/p/chromium/builders/ci/android-pie-x86-fyi-rel/747 > > > > Original change's description: > > > Make java_deobfuscate not require being built first > > > > > > Makes the tool easier to use, and easier to document how to use by not > > > requiring it to be built first. We have only a single non-prebuilt .java > > > file, so it's easy enough to just check in the .class file for it. > > Bug: 995290 > Change-Id: Ib1f396e07d6b0737133f03f1bded1a2d312ebfc8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106972 > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Sam Maier <smaier@chromium.org> > Cr-Commit-Position: refs/heads/master@{#751322} TBR=agrieve@chromium.org,smaier@chromium.org Change-Id: I7510d193931940176178ad6f68122f634ed59e93 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 995290 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108612Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#751394}
-
Juanmi Huertas authored
Bug: 1035589 Change-Id: I57ea8d46e10a1b2a06902d2e3c4216e1e7212114 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104211Reviewed-by:
Yi Xu <yiyix@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4c07605f8d55..6798043d95ac git log 4c07605f8d55..6798043d95ac --date=short --first-parent --format='%ad %ae %s' 2020-03-18 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 0fe8f345..1386d9f5 (751074:751294) 2020-03-18 mbonadei@webrtc.org Remove apk-patch-size-estimator from DEPS. 2020-03-18 phoglund@webrtc.org Proper fix to the summary options problem. Created with: gclient setdep -r src/third_party/webrtc@6798043d95ac If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1029452 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I2b42b65d9befe8314986605dd427e402cf777a5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106141Reviewed-by:
-
