GitLab

BUG=371406, 392108
R=sky@chromium.org

Review URL: https://codereview.chromium.org/467673002

Cr-Commit-Position: refs/heads/master@{#289523}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289523 0039d316-1c4b-4281-b951-d872f2087c98

We are planning on turning on --enable-new-avatar-menu by default in M38. In this
brave new world, the avatar button is always in the top right corner of the browser,
for all platforms. Previously, on Windows this button lived on the left side.

To make sure that the new world is the one that looks the best, we should always
use the correct orientation for the avatars. This does mean that for people
with the flag turned off, that are using the old style avatar menu on Windows,
they will see the avatars mirror.

BUG=380611
TEST=Start Chrome on Windows with --enable-new-avatar-menu. The avatar in the
avatar bubble should have the same orientation as in chrome://settings.

Review URL: https://codereview.chromium.org/464603002

Cr-Commit-Position: refs/heads/master@{#289522}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289522 0039d316-1c4b-4281-b951-d872f2087c98

These are currently data members, but they are always the same.

This simplifies upcoming app list refactoring.

BUG=403647

Review URL: https://codereview.chromium.org/466293002

Cr-Commit-Position: refs/heads/master@{#289520}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289520 0039d316-1c4b-4281-b951-d872f2087c98

BUG=402732

Review URL: https://codereview.chromium.org/463393002

Cr-Commit-Position: refs/heads/master@{#289519}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289519 0039d316-1c4b-4281-b951-d872f2087c98

BUG=394842

Review URL: https://codereview.chromium.org/468303003

Cr-Commit-Position: refs/heads/master@{#289518}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289518 0039d316-1c4b-4281-b951-d872f2087c98

This CL is a pure refactor of app list search result icon sizes which were
previously constants scattered about the codebase. This CL puts the icon
size as a static function in SearchResult so that there is only one place
the size needs to be changed.

BUG=391348

Review URL: https://codereview.chromium.org/458983004

Cr-Commit-Position: refs/heads/master@{#289517}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289517 0039d316-1c4b-4281-b951-d872f2087c98

accessibility/deleting-iframe-destroys-axcache.html started to fail after this CL.
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/20592

> Ensure there's no layout pending before accessing WebAXObject from TestRunner.
> 
> It's not safe to call WebAXObject functions when there's a layout pending.
> Chrome never does this, it only calls WebAXObject from
> renderer_accessibility_complete, and it makes sure to update layout before
> accessing the accessibility tree.
> 
> TestRunner didn't have the same protections, so this just explicitly updates
> the layout before any accessibility call.
> 
> BUG=393829
> 
> Review URL: https://codereview.chromium.org/469803003

TBR=dmazzoni@chromium.org

Review URL: https://codereview.chromium.org/464403003

Cr-Commit-Position: refs/heads/master@{#289515}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289515 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds a static FrameTree::GloballyFindByID that can be used by to find a FrameTreeNode given a frame tree node id.

BUG=376082

Review URL: https://codereview.chromium.org/429603002

Cr-Commit-Position: refs/heads/master@{#289513}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289513 0039d316-1c4b-4281-b951-d872f2087c98

BUG=401098
TBR=rmcilroy@chromium.org

Review URL: https://codereview.chromium.org/473683003

Cr-Commit-Position: refs/heads/master@{#289512}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289512 0039d316-1c4b-4281-b951-d872f2087c98

BUG=400617

Review URL: https://codereview.chromium.org/469883002

Cr-Commit-Position: refs/heads/master@{#289511}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289511 0039d316-1c4b-4281-b951-d872f2087c98

This appears to have broken gfx_unittests on iOS:

http://build.chromium.org/p/chromium.mac/builders/iOS%20Simulator%20%28dbg%29/builds/17689

> Update iOS deployment target to 7.0
> 
> iOS 6 will no longer be supported.
> 
> Replaces deprecated sizeWithFont: with sizeWithAttributes: (adding a
> ceilf since according to the internet, the former rounds up, and the
> latter does not) to fix compilation.
> 
> BUG=402921
> 
> Review URL: https://codereview.chromium.org/463333002

TBR=stuartmorgan@chromium.org

Review URL: https://codereview.chromium.org/473883002

Cr-Commit-Position: refs/heads/master@{#289510}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289510 0039d316-1c4b-4281-b951-d872f2087c98

NOTE: This is a revival/continuation of https://codereview.chromium.org/333723004, which was started by another developer.

The cc:CopyOutputRequest object assumes the src_subrect region is
in DIP space.  Thus, all calling code should provide the same.

Fixed tests in render_widget_host_view_browsertest.cc that were
completing successfully, even though the implementation was broken
for the high DPI scenarios.

In addition, I updated a number of interface comments to clarify the
difference between src_subrect being in DIP coordinates versus the
dest_size being in physical pixel coordinates.

Dependent on: https://codereview.chromium.org/311253004 (landed at r276139)

BUG=397708,399349

Review URL: https://codereview.chromium.org/462173002

Cr-Commit-Position: refs/heads/master@{#289509}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289509 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Disable WebNavigationApiTest.OpenTab on Windows. (patchset #1 of https://codereview.chromium.org/464243002/)

Reason for revert:
underlying issue should be fixed

Original issue's description:
> Disable WebNavigationApiTest.OpenTab on Windows.
> 
> BUG=402943
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289215

TBR=joaodasilva@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=402943

Review URL: https://codereview.chromium.org/469223002

Cr-Commit-Position: refs/heads/master@{#289508}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289508 0039d316-1c4b-4281-b951-d872f2087c98

This small patch is just some layer tree host test changes from
https://codereview.chromium.org/134623005/ split out.  These are
useful even without those changes, so can land separately.

R=danakj@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/475533004

Cr-Commit-Position: refs/heads/master@{#289507}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289507 0039d316-1c4b-4281-b951-d872f2087c98

UserImageSyncObserver obtained profile in a strange and wrong way. Now it uses
GetProfileByUser.

BUG=NONE
TEST=manually

Review URL: https://codereview.chromium.org/474603002

Cr-Commit-Position: refs/heads/master@{#289506}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289506 0039d316-1c4b-4281-b951-d872f2087c98

This will help to investigate cases of Chrome running out of renderer
services on Android.

BUG=396568
R=yfriedman@chromium.org

Review URL: https://codereview.chromium.org/464403002

Cr-Commit-Position: refs/heads/master@{#289505}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289505 0039d316-1c4b-4281-b951-d872f2087c98

* show ID when "Developer Mode" is checked

BUG=393670

Review URL: https://codereview.chromium.org/462273003

Cr-Commit-Position: refs/heads/master@{#289504}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289504 0039d316-1c4b-4281-b951-d872f2087c98

BUG=239656

Review URL: https://codereview.chromium.org/287153006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271719 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/460133002

Cr-Commit-Position: refs/heads/master@{#289503}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289503 0039d316-1c4b-4281-b951-d872f2087c98

RenderTextHarfBuzz will be enabled by default in the future, when the relevant bugs are fixed.

BUG=321868
R=msw

Review URL: https://codereview.chromium.org/469083002

Cr-Commit-Position: refs/heads/master@{#289502}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289502 0039d316-1c4b-4281-b951-d872f2087c98

Certain Android devices, as well as stylus and mouse inputs, may report zero
for the touch size. These sizes are used when constructing the rect for touch
handle insersection tests.  However, gfx::RectBase will always report false when
performing the intersection test if either rect is empty.  Add an appropriate
epsilon minimum touch size when forming the touch bounding box rect.

BUG=402795

Review URL: https://codereview.chromium.org/462163002

Cr-Commit-Position: refs/heads/master@{#289501}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289501 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#289500}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289500 0039d316-1c4b-4281-b951-d872f2087c98

R=jkummerow@chromium.org
TBR=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/473843002

Cr-Commit-Position: refs/heads/master@{#289499}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289499 0039d316-1c4b-4281-b951-d872f2087c98

Use X509_chain_up_ref, EVP_PKEY_dup, and newly-added X509_up_ref
instead. Also RAII OpenSSLClientKeyStore.

BUG=none

Review URL: https://codereview.chromium.org/474663002

Cr-Commit-Position: refs/heads/master@{#289498}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289498 0039d316-1c4b-4281-b951-d872f2087c98

BUG=396157

Review URL: https://codereview.chromium.org/427673006

Cr-Commit-Position: refs/heads/master@{#289497}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289497 0039d316-1c4b-4281-b951-d872f2087c98

Make "Join other network dialog" and "Join mobile network dialog" opens properly on multiple signin screen

BUG=397100

Review URL: https://codereview.chromium.org/443673002

Cr-Commit-Position: refs/heads/master@{#289496}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289496 0039d316-1c4b-4281-b951-d872f2087c98

Nexus10 is currently timing out before rendering the first frame of
filter_terrain.svg. By extending the test from 5 to 10 seconds, we
should give it more of a chance to render. This should also reduce
noise on the other platforms.

R=dtu@chromium.org
BUG=402884

Review URL: https://codereview.chromium.org/462143002

Cr-Commit-Position: refs/heads/master@{#289495}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289495 0039d316-1c4b-4281-b951-d872f2087c98

BUG=235037

Review URL: https://codereview.chromium.org/465393002

Cr-Commit-Position: refs/heads/master@{#289494}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289494 0039d316-1c4b-4281-b951-d872f2087c98

This caused a compile failure on the Chrome OS bots:

http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Builder%20%28dbg%29/builds/50095/steps/compile/logs/stdio

> Test that simulates touch exploration and checks speech on tabs and also the empty bookmark bar.
> 
> BUG=393768, 395895
> 
> Review URL: https://codereview.chromium.org/447893003

TBR=evy@chromium.org

Review URL: https://codereview.chromium.org/463373005

Cr-Commit-Position: refs/heads/master@{#289493}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289493 0039d316-1c4b-4281-b951-d872f2087c98

This caused failures on the Linux ASan bot:

http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%283%29/builds/6417/steps/cc_unittests/logs/DelegatingRendererWithTileOOM

> Still produce quad when tile OOM and on demand raster is not allowed
> 
> When on demand raster is not allowed, when tiles are OOM, checkerboard
> or solid color quad should be produced rather than nothing.
> 
> Add a unittest for this exact same scenario.
> 
> BUG=402321
> 
> Review URL: https://codereview.chromium.org/468983002

TBR=weiliangc@chromium.org

Review URL: https://codereview.chromium.org/473813002

Cr-Commit-Position: refs/heads/master@{#289492}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289492 0039d316-1c4b-4281-b951-d872f2087c98

It's not safe to call WebAXObject functions when there's a layout pending.
Chrome never does this, it only calls WebAXObject from
renderer_accessibility_complete, and it makes sure to update layout before
accessing the accessibility tree.

TestRunner didn't have the same protections, so this just explicitly updates
the layout before any accessibility call.

BUG=393829

Review URL: https://codereview.chromium.org/469803003

Cr-Commit-Position: refs/heads/master@{#289489}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289489 0039d316-1c4b-4281-b951-d872f2087c98

BUG=393768, 395895

Review URL: https://codereview.chromium.org/447893003

Cr-Commit-Position: refs/heads/master@{#289488}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289488 0039d316-1c4b-4281-b951-d872f2087c98

R=nednguyen@google.com, tonyg@chromium.org
BUG=

Review URL: https://codereview.chromium.org/474613002

Cr-Commit-Position: refs/heads/master@{#289487}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289487 0039d316-1c4b-4281-b951-d872f2087c98

The default views scrollbars look out of place on Mac OS X.
As a start, theme the scrollbar drawing to look like the native non-overlay
scrollbars. It looks like a simple round-rect that is inset from the track,
with a line border next to the content area.

BUG=401346

Review URL: https://codereview.chromium.org/456473002

Cr-Commit-Position: refs/heads/master@{#289486}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289486 0039d316-1c4b-4281-b951-d872f2087c98

Usage:

chrome --dbus-stub --dbus-unstub-clients=client_1[,client_2[,...]]

where <client_n> is in from the set of (bluetooth, cras, cros_disks,
cryptohome, debug_daemon, easy_unlock, lorgnette_manager, shill, gsm_sms, imageburner,
introspectable, modem_messaging, nfc, permission_broker, power_manager, 
session_manager, sms, system_clock, update_engine)

BUG=401192
TEST=manual + DBusClientBundle.UnstubFlagParser

Review URL: https://codereview.chromium.org/444263002

Cr-Commit-Position: refs/heads/master@{#289485}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289485 0039d316-1c4b-4281-b951-d872f2087c98

BUG=403687
TBR=thesig@chromium.org

Excluding tests that are timing out on drmemory

BUG=403687
TBR=thestig@chromium.org

Review URL: https://codereview.chromium.org/475693002

Cr-Commit-Position: refs/heads/master@{#289484}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289484 0039d316-1c4b-4281-b951-d872f2087c98

vertical and horizontal tracks together.
Update ScrollView to allow the native theme to paint the corner square when
both horizontal and vertical scrollbars are showing.
This is done by installing a view at the corner and have it call
NativeTheme::Paint(..).

BUG=401346

Review URL: https://codereview.chromium.org/462373002

Cr-Commit-Position: refs/heads/master@{#289483}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289483 0039d316-1c4b-4281-b951-d872f2087c98

BUG=403687
TBR=thestig@chromium.org

Review URL: https://codereview.chromium.org/471883002

Cr-Commit-Position: refs/heads/master@{#289482}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289482 0039d316-1c4b-4281-b951-d872f2087c98

Adds the ability for users to change the font size of distilled pages.
Adds SeekBar to layout and supporting observers.

BUG=383630

Review URL: https://codereview.chromium.org/465493002

Cr-Commit-Position: refs/heads/master@{#289481}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289481 0039d316-1c4b-4281-b951-d872f2087c98

When on demand raster is not allowed, when tiles are OOM, checkerboard
or solid color quad should be produced rather than nothing.

Add a unittest for this exact same scenario.

BUG=402321

Review URL: https://codereview.chromium.org/468983002

Cr-Commit-Position: refs/heads/master@{#289480}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289480 0039d316-1c4b-4281-b951-d872f2087c98

BUG=403681
TBR=mallinath@chromium.org

Review URL: https://codereview.chromium.org/477573002

Cr-Commit-Position: refs/heads/master@{#289479}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289479 0039d316-1c4b-4281-b951-d872f2087c98