GitLab

https://skia.googlesource.com/skia.git/+log/5fdbb8a8a76e..2fbf1bc8c96f

$ git log 5fdbb8a8a..2fbf1bc8c --date=short --no-merges --format='%ad %ae %s'
2017-09-20 djsollen Add SK_API to APIs used by the android framework.
2017-09-21 bsalomon Fix wrap mode asserts in GrVkSampler::GenerateKey
2017-09-21 liyuqian Run the first bench for 1000ms to warm up the nanobench if FLAGS_ms < 1000.
2017-09-20 mtklein Teach TSAN directly about semaphore_t.
2017-09-21 angle-deps-roller Roll skia/third_party/externals/angle2/ 1b7ed0ef2..981f0f8f6 (4 commits)
2017-09-21 caryclark add missing param names to SkBitmap.h
2017-09-21 caryclark feedback
2017-09-21 caryclark regenerate includes
2017-09-21 robertphillips Remove pre-attachment of stencil buffers

Created with:
  roll-dep src/third_party/skia
BUG=725308


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=fmalita@chromium.org

Change-Id: Ib8a043fe4d18794fc1b2b89dcba734df555aeaa6
Reviewed-on: https://chromium-review.googlesource.com/677494Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503552}

Bug: 618368
Change-Id: Ida7033ce771a2a7b29e0a49eb425ff67ace4791f
Reviewed-on: https://chromium-review.googlesource.com/677408Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Commit-Queue: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503551}

For benchmarks, this means moving to expectations. For unit tests this
means moving to decorators.Enabled()/Disabled()

TBR=bustamante@chromium.org

Bug: 713222
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester
Change-Id: Ia67b2ce6734740770d33d012f7b557879c47321d
Reviewed-on: https://chromium-review.googlesource.com/663664
Commit-Queue: rnephew <rnephew@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503550}

This is based on svaldez's work in https://codereview.chromium.org/1849773002/.

Bug: 649000,620005
Change-Id: I53eca60688eacb3e2b8472532e14af7c0af8e34e
Reviewed-on: https://chromium-review.googlesource.com/676324Reviewed-by: Steven Valdez <svaldez@chromium.org>
Commit-Queue: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503549}

Bug: 766809
Change-Id: I18c670791e002139256abaf71dcc5c6312f2ba5d
Reviewed-on: https://chromium-review.googlesource.com/677229
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#503548}

BUG=754050
TEST=No visible impact.  Pages should still prerender properly, which can be tested by allowing a URL to inline autocomplete, waiting a few seconds for the prerendered page to load, then pressing Go in the omnibox and verifying that the page appears immediately.

Change-Id: I6af103ce9d5bc4c50f912473bb76c37f0adacbba
Reviewed-on: https://chromium-review.googlesource.com/675835Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: Rohit Rao (ping after 24h) <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503547}

Currently HistoryBackend::GetAllTypedURLs return urls with typed_count > 0 which
omits urls in redirect chain. This causes such urls to not be displayed on
history page.

In this CL I'm changing the way how urls to sync are selected. I query visits
with PAGE_TRANSITION_TYPED transition and build set of urls corresponding to
these visits.

BUG=740876
R=sky@chromium.org

Change-Id: I15f0401972c9277082887d0989a13689ab23d4a8
Reviewed-on: https://chromium-review.googlesource.com/621421
Commit-Queue: Pavel Yatsuk <pavely@chromium.org>
Reviewed-by: Brett Wilson <brettw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503546}

TrackedScopedRefPtr has serveral CHECKs for investigating a memroy
corruption issue. They haven't been triggered after 3 days on Canary.
Therefore, this CL removes some of them. The remaining ones are not
expected to be hit either, but they are left in the code to run on more
users's machines to be extra sure.

BUG=750267,754946

Change-Id: Icd7e6eaedde3c2a21ea4d89449185b144772b562
Reviewed-on: https://chromium-review.googlesource.com/677491Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Yuzhu Shen <yzshen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503545}

Bug: 763263
Change-Id: I676208668f59efaab83ee8a26bad8ba30ff0e5f9
Reviewed-on: https://chromium-review.googlesource.com/677089Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503544}

Convincing evidence of external memory stomping obviates the
need for these checks.

BUG=740044

Change-Id: If614e20f9f6417600603b54acb01bd47a9eef6d0
Reviewed-on: https://chromium-review.googlesource.com/676752Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503543}

This change keeps the content-box centered when the window is between the width
of the .content element (600px + padding, since it uses default box-sizing) and
720px. Below that width, it degrades the old behaviour of left alignment.

The lack of centered alignment was visible on Incognito new tab pages for themes
with a background.

TEST=(1) Install a theme like [1] that has an Incognito NTP background image.
(2) Open an incognito window.
(3) Resize the window to just under 720px
(4) Check that the dark box containing the new tab page message is centered.

Bug: 767179
Change-Id: Id3229917f6311de8e47ff82062697c886efda5a2
Reviewed-on: https://chromium-review.googlesource.com/676131Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Lucas Garron <lgarron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503542}

This CL fixes a bug in UiElement::UpdateInheritedProperties where we
were accidentally pulling the parent's local, not combined opacity.

Bug: 767559
Change-Id: Ie8092299ec32229f73e89172b352959e75b7bfd6
Reviewed-on: https://chromium-review.googlesource.com/676664Reviewed-by: Yash Malik <ymalik@chromium.org>
Commit-Queue: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503541}

When a GLHelper instance was created, it also constructed a
GLHelperReadbackSupport instance. However, in doing so, there were
certain calls being made on the GL context that were synchronous, which
is: 1) bad to do during init time; and 2) really bad to do if the client
code will never use the results anyway. Therefore, this change simply
lazy-creates the GLHelperReadbackSupport instance upon first use.

Bug: 760348, 760351
Change-Id: I44e63a71331f31b6d88305bb00f29af9928a722e
Reviewed-on: https://chromium-review.googlesource.com/676945Reviewed-by: Xiangjun Zhang <xjz@chromium.org>
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503540}

If an auth code is issued for SAML flow, use it to perform
the /MergeSession call to bootstrap the user session.

Bug: 767143
Change-Id: Id42a37c84db468f155edfde557ad789b86ab2c4b
Reviewed-on: https://chromium-review.googlesource.com/677485
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503539}

Especially v8.h is heavy.

Bug: 766315
Change-Id: I9bd71910607f829fd0f71d8de0e64d3dbc741461
Reviewed-on: https://chromium-review.googlesource.com/669019Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@opera.com>
Cr-Commit-Position: refs/heads/master@{#503538}

For go/mustash chrome browser code cannot call into ash. This CL
eliminates several places where chrome code calls into
ash::TabletModeController.

TabletModeClient also allows all chrome code to observe tablet mode
state changes simultaneously, rather than having each chrome class
process an async mojo observer message.

Convert SigninScreenHandler and TabDragController to the new approach.
Fix SigninScreen teardown in tests so we can ensure that the
TabletModeClient observer list is empty at shutdown.

Bug: 766759
Test: browser_tests, unit_tests
Change-Id: I76edd44e83012722973d463073bfec3d395a8243
Reviewed-on: https://chromium-review.googlesource.com/675596
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503537}

This CL introdueces the concept of a Unified Desktop layout matrix.
It implements the conversion from a DisplayLayout (which will be supplied
by the system_display APIs) to the matrix, and the rules regarding
this conversion. It also adds a lot of tests.

BUG=752767
TEST=covered by tests

Change-Id: I588a4df6139b4f90715665ab544f7e48d79ad972
Reviewed-on: https://chromium-review.googlesource.com/660883
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503536}

Reference to BootstrapApplication in ActivityThread needed to be
updated to the RealApplication.

Bug: 765773
Change-Id: I2d26dd691a09bc18b4b409a0d9a3d928609a0671
Reviewed-on: https://chromium-review.googlesource.com/677281Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503535}

https://pdfium.googlesource.com/pdfium.git/+log/b8777a2c5f38..46fc3fa47dc5

$ git log b8777a2c5..46fc3fa47 --date=short --no-merges --format='%ad %ae %s'
2017-09-20 dsinclair Remove old TODO

Created with:
  roll-dep src/third_party/pdfium


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: I3b5e9272180ada8d5734b41008151f26f7422ea0
Reviewed-on: https://chromium-review.googlesource.com/676746
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503534}

Bug: 762823
Change-Id: If75050169ee293d12c1173adc12cbcce9c5924ef
Reviewed-on: https://chromium-review.googlesource.com/677487Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Troy Hildebrandt <thildebr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503533}

changes:
Remove duplicate declaration.
Add forward declaration for those that don't need full definition.

Bug: none
Test: still complies
Change-Id: I68bcd2d7a8f9f6ba19736c42e373adeca645ac78
Reviewed-on: https://chromium-review.googlesource.com/677085Reviewed-by: Dan Erat <derat@chromium.org>
Commit-Queue: Qiang(Joe) Xu <warx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503532}

Bug: 723876
Change-Id: I7219e887970abf5aed950a4d20affc2b7ad660f5
Reviewed-on: https://chromium-review.googlesource.com/675669Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Elliot Glaysher <erg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503531}

Do not send SETTINGS_MAX_HEADER_LIST_SIZE value in initial HTTP/2
SETTINGS frame, because it is known to break some websites.

I locally verified that the following websites do not load
(ERR_SPDY_SERVER_REFUSED_STREAM) without this change but they do load
with this change:

https://depot.sbroker.de
https://www.123-reg.co.uk
https://www.azet.sk
https://www.czc.cz
https://www.goo.ne.jp
https://www.hoeffner.de
https://www.mojezdravi.cz
https://www.rockhard.de
https://www.sportmaster.ru
https://www.zeny.cz

BUG=751642

Change-Id: I5bc9c28b7369a5667a4d1c77833c28dd0d192701
Reviewed-on: https://chromium-review.googlesource.com/677304Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503530}

https://chromium.googlesource.com/angle/angle.git/+log/47bf2dc..1f9d684

BUG=chromium:767279,chromium:725308,chromium:765321,chromium:655534

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Change-Id: I794ad67e2a1ef672855c65eef94959800cba9477
Reviewed-on: https://chromium-review.googlesource.com/677428Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Frank Henigman <fjhenigman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503529}

src/sdch directory is gone. This CL cleans up the reference.

Bug: 762686
Change-Id: I5e5a501c96b8e4d35ebad3afbf1295f06e610d91
Reviewed-on: https://chromium-review.googlesource.com/677277Reviewed-by: Elliot Glaysher <erg@chromium.org>
Commit-Queue: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503528}

There is a core trampler in Android and the belief is that it's a
use-after-free bug.  Unfortunately, there is no information about what
object was previously allocated to the memory being trampled.  This
will track freed objects and the stack at the moment it was freed,
making that information available for when the corruption is detected.

Bug: 744734
Change-Id: Iffbd5c8e6cbfcb98298d835b5514f43b821b70cd
Reviewed-on: https://chromium-review.googlesource.com/662277
Commit-Queue: Brian White <bcwhite@chromium.org>
Reviewed-by: Dmitry Skiba <dskiba@chromium.org>
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503527}

Change-Id: I04d4783fa93540d964721ac4973d186f1399a9bc
Reviewed-on: https://chromium-review.googlesource.com/645148Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503526}

- Do not append a '/' to the cache expression path.
- Do not expect the cache expression path to always end with '/'

Bug: 765826
Change-Id: I7d6266229361a159d7730ca3f057f39f2d0c47c2
Reviewed-on: https://chromium-review.googlesource.com/669820Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503525}

There's currently a very hard to reproduce bug that causes the omnibox
to disappear, typically after a refresh. One theory is that this is due
to the location bar being set to 0 or negative width from some bad
calculation or other.

This change clips the size to the minimum. Specifically, the delta is
clipped, rather than the final size, so that the origin can be correctly
adjusted for RTL.

Bug: 746944
Change-Id: I4a1710f2ac87e70d4b19f88142c6b9fa73a3a0a8
Reviewed-on: https://chromium-review.googlesource.com/677228Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503524}

The idea is to help avoid constant merge conflicts in new patches
on top of Chromium's zlib.

Plus adding instructions on how to generate a patch file.

Bug: 764094
Change-Id: I90260c7b6514171c4cc927a0299acf82b4ca6c2b
Reviewed-on: https://chromium-review.googlesource.com/677495Reviewed-by: Adenilson Cavalcanti <cavalcantii@chromium.org>
Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503523}

AutofillPopupController probably should not be removed and created again if we
are pretty sure it was called for the same element.

Bug: 767008
Change-Id: I559ff60c884466f51d52b04ad18e72fe3a7e1d2d
Reviewed-on: https://chromium-review.googlesource.com/674928
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503522}

Video of the fix in action:
https://drive.google.com/file/d/0B4g_WskzVRJdQUVjLUE2RWRWREE/view?usp=sharing

Bug: 767154
Change-Id: I1881976b27ba6aade47d5d06879fb65dcf3d24de
Reviewed-on: https://chromium-review.googlesource.com/674667Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Marc-Antoine Courteau <macourteau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503521}

Flipping either enable_print_preview or enable_basic_printing to false
used to work on Linux. This fixes the small issues that arised due to
various refactoring breaking these untested configs.

Change-Id: I756d91b5f2f4494b807b4dd6f7b05a72d72b79c1
Reviewed-on: https://chromium-review.googlesource.com/677046Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503520}

Copied the angle roll script fix from:
https://chromium-review.googlesource.com/620386

TBR=kbr@chromium.org

Change-Id: Ic0e70222b5ecd67d2ad716e1225ccbf93bc272c5
Reviewed-on: https://chromium-review.googlesource.com/677523Reviewed-by: Alexis Hétu <sugoi@chromium.org>
Commit-Queue: Alexis Hétu <sugoi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503519}

BUG=b/66193067
TEST=build locally

Change-Id: Ia77a14687679c6b9a2ec9092ff152e619b352194
Reviewed-on: https://chromium-review.googlesource.com/675756Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503518}

This CL wires up the entire warning flow:
(1) modal dialog / security state
(2) chrome://settings
(3) myaccount.google.com
(4) dismiss all warnings upon changing gaia password

Bug: 763453
Change-Id: Iaceb7d0f14b5db5b6d49a310e4f4a7122e42ea6b
Reviewed-on: https://chromium-review.googlesource.com/665340Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Lucas Garron <lgarron@chromium.org>
Reviewed-by: Luke Z <lpz@chromium.org>
Reviewed-by: Nathan Parker <nparker@chromium.org>
Commit-Queue: Jialiu Lin <jialiul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503517}

TBR=phoglund

Bug: webrtc:677256
Change-Id: I84a0fdf08a25204231ee1869918ecbffc8bdca9d
Reviewed-on: https://chromium-review.googlesource.com/677458Reviewed-by: Henrik Andreasson <henrika@chromium.org>
Commit-Queue: Henrik Andreasson <henrika@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503516}

Remove the TODO to migrate file-related extension tasks to the
ExtensionFileTaskRunner. I think we got most of the ones we know about,
and for any others, we still have the guidance above the method.

Bug: None
Change-Id: I9578d41df6bd0faaa541d7e8ea81e83cc83df7e4
Reviewed-on: https://chromium-review.googlesource.com/676325Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503515}

Add basic Mojo struct traits support & test for tap gestures.
(this is the minimum needed for tapping on shelf items)

Warn and bail on sending unsupported event types.
(otherwise it's tough to track these problems down)

Bug: 766783, 767087
Test: Chrome OS shelf items launch via touch w/ about:flags Enable shelf model synchronization"
Change-Id: I2aa813be94ce321897838c2e62de5d3097ac04ca
Reviewed-on: https://chromium-review.googlesource.com/675581Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503514}

BUG=582216

Change-Id: Ia39dd07ab831eca9cc781ad4532f3f2ed0cd21c3
Reviewed-on: https://chromium-review.googlesource.com/676880Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503513}