GitLab

There was a crash when disconnecting from a machine via Windows RDP.  RDP injects client machine printers into the host machine.  GetPrinterCapsAndDefaults blocks on these printers.  When the user disconnects, the printer is deleted and then GetPrinterCapsAndDefaults returns.  The failure handler fires and attempts to access the now-freed PrinterJobHandler that was passed with the callback resulting in a crash.

The solution is to pass a WeakPtr to the callback so that if the PrinterJobHandler is destroyed the
callback wont fire.

BUG=122996
TEST=Verify bug.


Review URL: http://codereview.chromium.org/10079017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132283 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10053019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132282 0039d316-1c4b-4281-b951-d872f2087c98

- Ability for WebContents to be replaced.
- Various focus/destruction observers.
- Hook up to BrowserView, replacing TabContentsContainer.

BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10073014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132281 0039d316-1c4b-4281-b951-d872f2087c98

Eliminate three instances of them, and DCHECK on the condition for the future.

BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10003005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132280 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10079021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132279 0039d316-1c4b-4281-b951-d872f2087c98

used by this test for sections and import dlls, needed to be changed. These values
are different for X86 and X64.

BUG=123096
R=cpu
Review URL: https://chromiumcodereview.appspot.com/10083011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132278 0039d316-1c4b-4281-b951-d872f2087c98

Show actual results for accessibility dump render tree tests as well. Showing a * in front of incorrect expected lines is not enough. We need to see what the actual results were as well.


BUG=120934
TEST=This is a fix for tests


Review URL: http://codereview.chromium.org/10008081

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132277 0039d316-1c4b-4281-b951-d872f2087c98

BUG=123402

Review URL: https://chromiumcodereview.appspot.com/10073021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132276 0039d316-1c4b-4281-b951-d872f2087c98

wrench_menu_model. Chromeos no longer diverges that much from current.

BUG=123233
TEST=make sure menu layout is right.
R=saintlou@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10038033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132275 0039d316-1c4b-4281-b951-d872f2087c98

This archive contains all the files that need to be signed or are
required to build the Me2Me host installer.

Currently only setup for Mac. Other platforms either don't need this (Linux)
or are much simpler (Windows).

BUG=122228
Test=None
Review URL: https://chromiumcodereview.appspot.com/10071027

TBR=garykac@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10083012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132273 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132272 0039d316-1c4b-4281-b951-d872f2087c98

TBR=toyoshim@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10086010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132271 0039d316-1c4b-4281-b951-d872f2087c98

This archive contains all the files that need to be signed or are
required to build the Me2Me host installer.

Currently only setup for Mac. Other platforms either don't need this (Linux)
or are much simpler (Windows).

BUG=122228
Test=None
Review URL: https://chromiumcodereview.appspot.com/10071027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132270 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com/9960083

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132269 0039d316-1c4b-4281-b951-d872f2087c98

Some notification clients expect URLs while others expect URLRows but in some cases the URLRows were not being provided. Eliminated the duplication of data structures by removing the set of URLs and relying only on the vector of URLRows.

tim@ for OWNERS review of sync/...

BUG=122740
TEST=Added unit test.
TBR=tim@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10031028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132268 0039d316-1c4b-4281-b951-d872f2087c98

This refactors the triggering of accessibility mode from a boolean state and
command-line flag to an AccessibilityMode enum that's passed directly
when a new RenderView is created, which is also more readable and avoids the
extra command-line flag.

Adds a new mode that only syncs editable text nodes, and enables this on
Windows 8 so that we can support showing the virtual keyboard when an
editable text field gets focus.

BUG=122061,118641
TEST=Adds new test


Review URL: http://codereview.chromium.org/9939011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132267 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10051022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132266 0039d316-1c4b-4281-b951-d872f2087c98

the margin leaves space so that the menu isn't abutting the edge of the viewport, and is more aligned with the arrow on the button below

BUG=112486
TEST=none


Review URL: http://codereview.chromium.org/10037022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132265 0039d316-1c4b-4281-b951-d872f2087c98

BUG=122187
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10079006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132262 0039d316-1c4b-4281-b951-d872f2087c98

BUG=122933
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10086005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132261 0039d316-1c4b-4281-b951-d872f2087c98

BUG=122450
TEST=Verify fix for issue 122450.


Review URL: http://codereview.chromium.org/10071026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132260 0039d316-1c4b-4281-b951-d872f2087c98

The search tab of chrome://sync would previously perform a string search
of a select set of fields.  This change modifies the search behaviour to
instead perform a regex match against a serialized version of the node.

Part of this change is to move the searching function out of C++ and
into JavaScript.  When a search is performed, all nodes are loaded from
the database, marshalled, and sent over the fence to the JavaScript side
of things.  This comes with a significant performance cost, but it's not
much worse than a search matching all nodes would have been under the
old system.

While there was no such thing as an invalid search string under the
old system, it is possible to enter an invalid regex.  This change adds
some logic to alert the user if their search query is not a valid regex
(ie. if it ends with a backslash).

In order to make it easier to formulate queries, the way we display
results has been changed.  The right pane will now display the
serialization of the raw node (which exactly reflects the text that was
searched) rather than the "details" used in the old system.  This new
format is a subset of the old, and corresponds to the dictionary value
found under "entry" in the old display.

Finally, this change removes support for some JavaScript calls that are
no longer used.

This change fixes JavaScript style-checker issues in the files that it
touches.

BUG=104574, 122021
TEST=

Review URL: http://codereview.chromium.org/9836100

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132259 0039d316-1c4b-4281-b951-d872f2087c98

This should enable removing most (if not all) of the whitelist.

R=thestig@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/10083003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132258 0039d316-1c4b-4281-b951-d872f2087c98

"Detab" content/browser/web_contents.

BUG=105875
TEST=no change


Review URL: http://codereview.chromium.org/10038026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132257 0039d316-1c4b-4281-b951-d872f2087c98

Fix per-tile painting support in Pepper Graphics2D plugins by using a temporary device independent bitmap when necessary.

BUG=122820
TEST=ppapi/example/example.html


Review URL: http://codereview.chromium.org/10069004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132256 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
R=ben@chromium.org


Review URL: http://codereview.chromium.org/10079011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132255 0039d316-1c4b-4281-b951-d872f2087c98

(Seems to be responsible for VMTest failure on ChromiumOS).

BUG=119250
Review URL: https://chromiumcodereview.appspot.com/9958034

TBR=jschuh@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10081018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132254 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=Build 'egl_main_native'. No "file not found" error for third_party/gles2_conform.

Review URL: http://codereview.chromium.org/10072005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132251 0039d316-1c4b-4281-b951-d872f2087c98

Before this patch, if ScriptShape() returned E_OK but there
were missing glyphs, we would only try font linking and not
metafile font fallback. For Armenian text (and probably
others), ScriptShape() returns E_OK with missing glyphs,
but font linking won't find the right font. The metafile
approach is needed.

This change makes sure the metafile font fallback path
is always taken first, before trying font linking to
find the missing font.

BUG=105550, 122974
TEST=Under Windows with use_canvas_skia=1 enabled, go to
http://akumb.am. Make sure the tab title is displayed
correctly.

Review URL: http://codereview.chromium.org/10010047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132250 0039d316-1c4b-4281-b951-d872f2087c98

BUG=118427
TEST=With the "NTP Suggestions page" flag enabled, go to the NTP and switch between panes (e.g. Apps and Suggested), then click on a link in the Suggestd pane. Go back to the NTP and type a URL in the Omnibox. Open a new tab and close it. Then, go to about:histograms and verify that there are data points at least for values 1, 11, 12 and 13 in the NewTabPage.SuggestedSitesAction stat. Other values are OK, as long as these are present.

Review URL: http://codereview.chromium.org/9958116

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132249 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10080011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132248 0039d316-1c4b-4281-b951-d872f2087c98

R=pkasting@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10068025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132247 0039d316-1c4b-4281-b951-d872f2087c98

change we need to adjust based on where the mouse is. Not sure why we
didn't notice this on windows.

BUG=123256
TEST=see bug
R=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10069043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132246 0039d316-1c4b-4281-b951-d872f2087c98

This adds a hang monitor for Pepper plugins. It monitors sync messages on the I/O thread of the renderer and sends a message to the browser if it's blocked for too long.

The browser will show an infobar allowing you to terminate the plugin.

BUG=122795

Review URL: https://chromiumcodereview.appspot.com/10014013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132245 0039d316-1c4b-4281-b951-d872f2087c98

BUG=114179
Review URL: https://chromiumcodereview.appspot.com/10067026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132244 0039d316-1c4b-4281-b951-d872f2087c98

BUG=http://code.google.com/p/chromium/issues/detail?id=123181
TEST=pyauto & browser tests

Review URL: http://codereview.chromium.org/10069041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132243 0039d316-1c4b-4281-b951-d872f2087c98

Change OAuth2MintTokenFlow to use OAuth2ApiCallFlow.
Review URL: https://chromiumcodereview.appspot.com/10012051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132242 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=

Review URL: https://chromiumcodereview.appspot.com/10082015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132241 0039d316-1c4b-4281-b951-d872f2087c98

BUG=121749


Review URL: http://codereview.chromium.org/10071025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132240 0039d316-1c4b-4281-b951-d872f2087c98

BUG=123148


Review URL: http://codereview.chromium.org/10084016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132236 0039d316-1c4b-4281-b951-d872f2087c98