- 29 Nov, 2019 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ae8c170db133..b5a792c5fb9e Created with: gclient setdep -r src-internal@b5a792c5fb9e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None,chromium:None Tbr: jbudorick@google.com Change-Id: I207fc90518cb433536be212e3c05e957baa86d08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944307Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720176}
-
Oleg Davydov authored
This commit is a slightly improvement of the force-installed extension installation reporting system. After it we'll report stats earlier in case of we've receive failure reports: in old approach we'll wait five minutes if any problem exists. Now we'll report instantly when all extensions are loaded or reported as failures. We'll wait only when some extensions are still installing five minutes after login. Bug: 981891 Change-Id: I7da61780691d07f19f37652fbea6993d8c220294 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943135 Commit-Queue: Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#720175}
-
Oriol Brufau authored
The marker-supported-properties.html test was checking that the 'text-combine-upright' property can be set to 'none' in ::marker. However, this wasn't much useful, since 'none' is the initial value. The test would pass even if ::marker ignored the declaration. Change it to check 'text-combine-upright: all' instead. Bug: 457718 Change-Id: Ib3b2109713f474e2fc75918184795036e1fea664 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943239Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#720174}
-
Stephen Nusko authored
browse:news:nytimes:2019 browse:social:facebook_infinite_scroll browse:news:washingtonpost:2019 TBR: crouleau@chromium.org Bug: 1029460,1029465,1029467 Change-Id: I0de4f43db3cc3f499724d71577fe6a0294ff229b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943137Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Commit-Queue: Stephen Nusko <nuskos@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#720173}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I87d4fe227098839028a2fe25a3a08ab7ff6c1b31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943003Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720172}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/fa7ee0b0..b9646867 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3f51f3ae4484c8705dd128742622deb8f9ea3141 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943005Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720171}
-
Juan Antonio Navarro Perez authored
These are no longer url-encoded from Telemetry side. Bug: 1022380 Change-Id: I8a34a9d3a5b58c3add7aec6fcb7c73bb48d92ef3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943132 Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/master@{#720170}
-
Robbie Gibson authored
This CL just adds the framework for the option in the popup menu (gated behind a flag). It uses the same flag that already exists for the text zoom web feature. I'm still waiting on the correct icon from design. I'll update that once I get it. Bug: 1028938 Change-Id: I7fb26da61c10b4550ec836529ec7dbb09b522a75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939972 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#720169}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ffa2b6de4a84..31b0a5681dea git log ffa2b6de4a84..31b0a5681dea --date=short --first-parent --format='%ad %ae %s' 2019-11-29 rslawik@google.com Merge "Find system ion size during LMK" Created with: gclient setdep -r src/third_party/perfetto@31b0a5681dea If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I1f6f350dd3d6bf0b548b22f03ba154c23d24e133 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943381Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720168}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d4c77d971b68..ae8c170db133 Created with: gclient setdep -r src-internal@ae8c170db133 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: I5b2b9a01b74e5dd61744721348c979403bfb6bdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943380Reviewed-by:
-
Guido Urdaneta authored
This reverts commit 0bc25688. Reason for revert: Suspect of causing consistent failures of GPU tests on Chromium bot. First failure: https://ci.chromium.org/p/chromium/builders/ci/Linux%20TSan%20Tests/47651 Original change's description: > Roll src/third_party/angle bc82fb14aab4..c96187a919eb (1 commits) > > https://chromium.googlesource.com/angle/angle.git/+log/bc82fb14aab4..c96187a919eb > > git log bc82fb14aab4..c96187a919eb --date=short --first-parent --format='%ad %ae %s' > 2019-11-29 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader d6e903bdc9ef..fb7ca1d5aca5 (13 commits) > > Created with: > gclient setdep -r src/third_party/angle@c96187a919eb > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/angle-chromium-autoroll > Please CC cwallez@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Bug: chromium:None > Tbr: cwallez@google.com > Change-Id: I59a363871bd6ed3b1fa3eee593c356f6b4b9e780 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944051 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#720145} TBR=cwallez@google.com,chromium-autoroll@skia-public.iam.gserviceaccount.com Change-Id: I20c84205db53ca1a9b579d92c948989c37ab7e2c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:None Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943139Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#720166}
-
Mohamed Amir Yosef authored
Bug: 1012203 Change-Id: I469a9dd2a96d8c50e88e43aa1f2ac06369d9e7f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940167 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#720165}
-
Benoît Lizé authored
Add mutex annotations to replace load-bearing comments in SoftwareImageDecodeCache. This requires adding the proper annotation to Lock::AssertAcquired(), which is also done in this CL. As a consequence, this CL does a few things: In SoftwareImageDecodeCache: - Convert comments to annotations - Make a member const instead of annotating it - Change a test-only method to make compile-time checks pass - Fix "git cl lint" warnings (include what you use) In Lock: - Add a mutex annotation to Lock::AssertAcquired() Bug: 1013082, 831825, 983348 Change-Id: If779a0f6453a2060ed3e7dedf7ad7f6823ebac68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939749 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#720164}
-
Mikhail Khokhlov authored
Turns on the --experimental-proto-trace-format flag to test proto trace generation on bots. Uses the power.desktop benchmark to test metrics computation. TBR=crouleau@chromium.org Bug: 990304 Change-Id: If9a2595a7e41a824d1f23638337806747782b319 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939968 Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Auto-Submit: Mikhail Khokhlov <khokhlov@google.com> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#720163}
-
Guido Urdaneta authored
It is flaking on Linux, Windows and Mac. Marked as RetryOnFailure. Bug: 1028975 Change-Id: I631f50dce9d4836fffbe1852aeb5a130dbdc666c No-Try: True TBR: malaykeshav@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943175Reviewed-by:
-
Peter Marshall authored
Properly order setAutoAttach and onceAttachedToTarget. Change-Id: I15462ac670a691c1bad1859d3b1846e86d21bfce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943133 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Auto-Submit: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#720161}
-
Marc Treib authored
Technically it was used in invalidation::ParseNotifierOptions, which however was itself unused and is also removed. Bug: none Change-Id: Ic3e6bdc88a381875760892131479cecc4ac4dfe4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942658 Commit-Queue: Tim Schumann <tschumann@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Tim Schumann <tschumann@chromium.org> Cr-Commit-Position: refs/heads/master@{#720160}
-
Dominik Röttsches authored
In newer versions of the font the Noto Sans Bengali name tables have added a "-Regular" suffix in the PostScript names of Noto Sans Bengali and Noto Sans Bengali UI regular, which fails to match. Bug: 929889 Change-Id: Ibcea26d3abeb30eba68290632f87bfde88ecebbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943348 Auto-Submit: Dominik Röttsches <drott@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#720159}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/2c594009d354..ffa2b6de4a84 git log 2c594009d354..ffa2b6de4a84 --date=short --first-parent --format='%ad %ae %s' 2019-11-29 hjd@google.com Merge "perfetto-cmd: Add --upload flag" Created with: gclient setdep -r src/third_party/perfetto@ffa2b6de4a84 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I7f3ecacf982c06a391c682b8d6542f747435ae10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943329Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6d86347795cf..d4c77d971b68 Created with: gclient setdep -r src-internal@d4c77d971b68 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: Icc8e4a522f9943a7c00b0b3f6ee34f4ef45e61bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943378Reviewed-by:
-
Peter Marshall authored
There are several ways this test can flake the way it's written. Use a handler for AttachedToTarget instead of onceAttachedToTarget to avoid the ordering problems there. Use evaluateAsync to actually wait for the Promise.all call to resolve. We also can't make any assumption about the resolved status of setAutoAttach except that it is resolved after the two attached events are fired - which is what we are trying to test. So just rely on the ordering of the output to prove that it is resolved after the two events arrive. Drive-by fix to two other tests which used onceAttachedToTarget too late and could flake if the event fires after evaluate() but before the event handler is added. Fixed: 915472 Change-Id: Id4a20488273a0b1a963e732c14e38b5efcd094ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943170Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2b0e60d5..fa7ee0b0 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ibe355b079db7a80d52140db2622491b816c70456 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943002Reviewed-by:
-
Stepan Khapugin authored
This reverts commit f1623afd. Change-Id: I3ce313b7492c18b0fdb257165e4ff258dcf3b1f7 Bug: 1026579 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942687Reviewed-by:
David Jean <djean@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#720154}
-
Noel Gordon authored
More CSS to style directory tree for files-ng. This is the last of the CSS patches needed. Again rules like: .tree-row > .file-row > blah ... are specific to files-ng. The .file-row is needed to effect the design and the specific rules related to it avoid peppering the CSS code with a #directory-tree[files-ng] prefix. There are cases where rules should only be applied to normal files app: they generally being with #directory-tree:not([files-ng]) blah ... And finally, the residual #directory-tree rules (files-ng, or not) are shared by both implementations. Bug: 992819 Change-Id: I7698a23d4c423ccbb27b74bc655fb36d1b93a9ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942750 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#720153}
-
Kinuko Yasuda authored
At least we need to test this code more. (May revert back before branch cut) Bug: 939317 Change-Id: I15d0ad2089501bdadf32e51b36fde248e11f2580 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943075 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#720152}
-
Kuo Jen Wei authored
Bug: b/141518780 Test: Pass closure compiler check, tast run <DUT> 'camera.CCAUI*' and validate all function of CCA on HALv1/v3 device works correctly. Change-Id: Ib7c71fba143b809f612f5148070755cdf1eca131 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933860Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#720151}
-
Andreas Haas authored
There still seem to be issues when ArrayBufferContents::Data() returns nullptr for now, see https://crbug.com/1028766. That's why I undo that change which allows nullptr for now and try to fix it after the branch cut. R=haraken@chromium.org Bug: chromium:1008840, chromium:1027937 Change-Id: I6c541e56ef13d2506c32add301dd92e0475f41c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942695Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#720150}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5e2a454edcf7..6d86347795cf Created with: gclient setdep -r src-internal@6d86347795cf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: I2e18b33fa2d7fc03e8a5cf7c80d398deeb5648e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944054Reviewed-by:
-
Koji Ishii authored
Following r719562 and r719898 to remove the duplicated logic for |NodeForHitTest| in |NGPaintFragment|, this patch moves the rest of this logic in |NGPhysicalFragment| to |LayoutObject| so that it can be shared with |NGFragmentItem|. There should be no behavior changes. Bug: 982194 Change-Id: Iae467845281a9d4fcf479b9b85bb2770132f6f6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942591 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#720148}
-
Malay Keshav authored
The test harness crashes for nexus 5 because of the capture size. TBR=ynovikov@chromium.org BUG=chromium:1029389 Change-Id: Ia64d9f12f761ca0d16e055a3cb77a578a7d94c77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943547Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#720147}
-
Mikel Astiz authored
This affects: Sync.*AssociationTime Sync.*ConfigureFailure Both groups are rarely consumed these days and have competing metrics that are more interesting (although not identical). Bug: 995514 Change-Id: I44f7b1e18db9eebe1d8172a2b2f2ce2fa75e3ee2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937370Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/bc82fb14aab4..c96187a919eb git log bc82fb14aab4..c96187a919eb --date=short --first-parent --format='%ad %ae %s' 2019-11-29 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader d6e903bdc9ef..fb7ca1d5aca5 (13 commits) Created with: gclient setdep -r src/third_party/angle@c96187a919eb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:None Tbr: cwallez@google.com Change-Id: I59a363871bd6ed3b1fa3eee593c356f6b4b9e780 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944051Reviewed-by:
-
Hiroki Nakagawa authored
TL;DR: This CL makes service_worker_client_utils::GetClients() take blink::mojom::ServiceWorkerHost::GetClientsCallback as a callback instead of base::OnceCallback<void(std::unique_ptr<ServiceWorkerClientPtrs>)>. > Details - In the original code, GetClients() uses std::unique_ptr<ServiceWorkerClientPtrs> as a container to collect client information. ServiceWorkerClientsPtrs is an alias of std::vector<blink::mojom::ServiceWorkerClientInfoPtr>> so this is expanded to std::unique_ptr<std::vector<blink::mojom::ServiceWorkerClientInfoPtr>>> std::vector behaves like a smart pointer, so it's not necessary to wrap std::vector with std::unique_ptr, that is, GetClients() can directly uses std::vector<blink::mojom::ServiceWorkerClientInfoPtr>> as the container type. - In the original code, GetClients() takes base::OnceCallback<void(std::unique_ptr<ServiceWorkerClientPtrs>)> as a callback type. As mentioned above, this can be simplified to base::OnceCallback<void(std::vector<blink::mojom::ServiceWorkerClientInfoPtr>>)> This is equal to blink::mojom::ServiceWorkerHost::GetClientsCallback Change-Id: Ie50965a5d44919207d2829c1642449e300ecc9ea Bug: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943717 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#720144}
-
Hiroki Nakagawa authored
This is a part of the effort to split ServiceWorkerProviderHost into ServiceWorkerHost and ServiceWorkerContainerHost. This CL finally makes ServiceWorkerContainerHost inherit blink::mojom::ServiceWorkerContainerHost instead of ServiceWorkerProviderHost. This is mostly mechanical change, and doesn't change behavior. Design doc: https://docs.google.com/document/d/1epWIgelE-7uwxJHrYPKlbwqMRP9in2xLUR6mpiU_afY/edit?usp=sharing Bug: 931087 Change-Id: Ib59a7ae7398e19459c87d0ebf2a79f21f659307a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943630Reviewed-by:
-
Koji Ishii authored
Following bot results are included. 452 453 454 455 457 461 462 4 lines were removed and 18 lines were deflaked by consecutive results since 440. TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: Iae8ec83b3bec1a5e383c8dbfca55c781cb06b663 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943067Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#720142}
-
Hans Wennborg authored
TBR=ehmaldonado Bug: 1018293 Change-Id: Id6ccd9427ccc9444f2f411eab98ce76a8c98e34e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943131Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#720141}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/310ba9ca..2b0e60d5 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ieec59af38bc6179eca26e8f04785cf641e1880ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942999Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes |NGFragmentItem::GetWritingMode()| to work other than text because it is independent from text and value of CSS property. Note: This patch fixes 17 web_test crashes. Bug: 982194 Change-Id: I9f5fdaddb12f3d88b50a1f6c87b026b505ce8ea7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943497 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b97d4ceb42b4..bcfcc04c53f0 git log b97d4ceb42b4..bcfcc04c53f0 --date=short --first-parent --format='%ad %ae %s' 2019-11-29 fancl@chromium.org Fix displaying wrong job when switching between jobs 2019-11-29 abennetts@google.com Add warning that viewing old results2 docs will fail in M80 and above. 2019-11-29 fancl@chromium.org Fix the generated version string when using docker deploy 2019-11-28 abennetts@google.com Give the 'npm' binary dependency a distinct local path to the 'node' dependency. Created with: gclient setdep -r src/third_party/catapult@bcfcc04c53f0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1029412,chromium:1021137,chromium:1029242 Tbr: rmhasan@google.com Change-Id: Iab5f70a04796f7aa10bb4b7daa8de894e56c6e3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943672Reviewed-by:
-
Dominic Battre authored
This fixes the flakiness of the test caused by an asynchronous process. It also adds a helper function to components/prefs to wait for a specific pref value to be set. Fixed: 1028765 Change-Id: I23636d9a19c6db1db4fe01257f13a162007ad5c2 Bug: 1028765 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939488Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#720137}
-
