GitLab

They are always "true" for now, due to the way BLE devices work under Windows 8.

BUG=388016

Review URL: https://codereview.chromium.org/378293007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282286 0039d316-1c4b-4281-b951-d872f2087c98

BUG=338887

Review URL: https://codereview.chromium.org/370383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282285 0039d316-1c4b-4281-b951-d872f2087c98

Previously setClientSession was trying to call clientSession when it's
null.

BUG=392345

Review URL: https://codereview.chromium.org/380053002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282284 0039d316-1c4b-4281-b951-d872f2087c98

This change depends on http://crrev.com/329853012 

The tests for this change will be added in the LayoutTests of Blink: http://crrev.com/373713004


BUG=373120

Review URL: https://codereview.chromium.org/373713003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282283 0039d316-1c4b-4281-b951-d872f2087c98

Addresses are always non-NULL per spec. This merges a change that has already
been applied to the google-internal version of protobuf.

BUG=381910
TBR=cpu@chromium.org

Review URL: https://codereview.chromium.org/379973003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282282 0039d316-1c4b-4281-b951-d872f2087c98

Under-development Android versions do not have a numeric
version, so falls back to a "default version".

Using a real released Android version like 4.3.0 will
incorrectly trigger code paths, such has version-specific
gpu blacklists.

First attempt at fixing this was using 0.0.0, which caused
websites parsing Android version in the user agent to break.

So this is the second attempt, use the latest public major
version and minor version, and use a higher bug release
version to avoid conflicts with the gpu blacklist.

BUG=387179

Review URL: https://codereview.chromium.org/381813002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282281 0039d316-1c4b-4281-b951-d872f2087c98

This contains fixes for the following sorts of issues:
* Assignment inside conditional

This updates the relevant .patch and README files, combining these fixes with
the previous set of MSVC warning fixes.  This also removes the now-unused
vs2013-optimization.patch file.

BUG=81439
TEST=none

Review URL: https://codereview.chromium.org/385503002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282280 0039d316-1c4b-4281-b951-d872f2087c98

The CL removes the unused scaleControl proeprty in the view port class.

BUG=245926
TEST=None

Review URL: https://codereview.chromium.org/383583003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282279 0039d316-1c4b-4281-b951-d872f2087c98

Partially implement OSExchangeDataProviderMac, just enough to get
OSExchangeDataTest and TextFieldTest.DragAndDrop* to pass.
The implementation is backed by NSPasteboard, and relies on the category
NSPasteboard(ChimeraPasteboardURLUtils) defined in third_party/mozilla.

BUG=378134

Review URL: https://codereview.chromium.org/368973003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282277 0039d316-1c4b-4281-b951-d872f2087c98

See http://googleonlinesecurity.blogspot.com/2014/07/maintaining-digital-certificate-security.html

BUG=392251

Review URL: https://codereview.chromium.org/380033002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282276 0039d316-1c4b-4281-b951-d872f2087c98

Based on review comments from https://codereview.chromium.org/337093003/

BUG=

Review URL: https://codereview.chromium.org/361083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282275 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/363563004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282274 0039d316-1c4b-4281-b951-d872f2087c98

Changed registration API to work for one network at once.
Fixed comments.
Replaced argument GCDDevice with just string id.

BUG=383167
R=alexsemenov@chromium.org, asargent@chromium.org, asvitkine@chromium.org, noamsml@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282099

Review URL: https://codereview.chromium.org/363883002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282273 0039d316-1c4b-4281-b951-d872f2087c98

Implementation of shared worker code path when WebView guest creates a shared worker to request file system access.

BUG=343382

Review URL: https://codereview.chromium.org/338353007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282272 0039d316-1c4b-4281-b951-d872f2087c98

BUG=381541

Review URL: https://codereview.chromium.org/360123003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282271 0039d316-1c4b-4281-b951-d872f2087c98

This provides PrintTo(..) functions for the geometric types in ui/gfx/
so that failing gtest assertions pretty-print the values instead of
dumping the bytes of the objects. This way gtest assertions on these
types can be written in the form:

  EXPECT_EQ(a, b);

instead of
  EXPECT_EQ(a.ToString(), b.ToString());

which is currently used (inconsistently) to provide more readable
failure messages.

This is a bit tricky since gtest uses streams and somewhat complicated
template expansion magic to pretty print values and we don't want to
link the stream-based code into production code paths. This declares the
PrintTo() functions in the headers defining each of the geometry types,
using the <iosfwd> header to keep stream bloat to a minimum, and defines
the formatters in gfx_test_support. This way every test that
instantiates these printers has to declare a dependency on
gfx_test_support or it fails to link, but a test does not have to
#include any particular header to see the correct printer declaration
and thus expand the template correctly.

If we were to declare the PrintTo() functions in a test only header such
a gfx_util.h then the pretty printers would work reliably only if
*every* target in a translation unit that instantiated the comparison
saw this declaration. If some unit tests in a target #included the
header and some did not then it would be intederminate whether the
template instantiation linked in to the test binary was the pretty
printed one or the hex dump one (and in practice this appears to be
inconsistent across clang and gcc for whatever reason).

Review URL: https://codereview.chromium.org/368903003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282270 0039d316-1c4b-4281-b951-d872f2087c98

MessagePopupCollection contains plenty size of conditions and ifdefs
to work properly with each type of the desktop we have, and some
logic makes side effects on another desktop. This design is unhealty
and adding more conditions sounds incorrect.

Considering this, it would be better to extract platform dependent
parts as a delegate class (PopupAlignmentDelegate) and allow
subclasses to provide platform-specific features.

This design is also beneficial for win-ash, because we had
OS_CHROMEOS layout data and logic which actually means Ash.

BUG=389656
R=stevenjb@chromium.org, dimich@chromium.org
TBR=jamescook@chromium.org, harrym@chromium.org
TEST=message_center_unittests, ash_unittests, some manual checks

Review URL: https://codereview.chromium.org/369573004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282269 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282268 0039d316-1c4b-4281-b951-d872f2087c98

They started to fail since the switch to Clang on Linux.

BUG=392768
TBR=thakis@chromium.org

Review URL: https://codereview.chromium.org/386543002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282267 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Revert of Turn on clang by default on linux, 3rd try. (https://codereview.chromium.org/378363006/)

Reason for revert:
This change should not have been reverted, since
it was easy to just disable these tests. thakis
explicitly requested "please ping thakis before
reverting it".

Original issue's description:
> Revert of Turn on clang by default on linux, 3rd try. (https://codereview.chromium.org/379413002/)
> 
> Reason for revert:
> NaClBrowserTestNonSfiMode.Messaging and NaClBrowserTestNonSfiMode.Irt failed.
> 
> http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/12124/steps/browser_tests/logs/Irt
> http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/12124/steps/browser_tests/logs/Messaging
> 
> Original issue's description:
> > Turn on clang by default on linux, 3rd try.
> > 
> > This is mostly to collect performance and size data for now, and to find out
> > if more bots need work. Unless things look really good, I'm going to revert
> > this by thursday morning (PDT).
> > 
> > BUG=360311
> > TBR=ajwong@chromium.org
> > 
> > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282246
> 
> TBR=awong@chromium.org,thakis@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=360311
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282265

TBR=awong@chromium.org,thakis@chromium.org,horo@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=360311

Review URL: https://codereview.chromium.org/382743002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282266 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
NaClBrowserTestNonSfiMode.Messaging and NaClBrowserTestNonSfiMode.Irt failed.

http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/12124/steps/browser_tests/logs/Irt
http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/12124/steps/browser_tests/logs/Messaging

Original issue's description:
> Turn on clang by default on linux, 3rd try.
> 
> This is mostly to collect performance and size data for now, and to find out
> if more bots need work. Unless things look really good, I'm going to revert
> this by thursday morning (PDT).
> 
> BUG=360311
> TBR=ajwong@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282246

TBR=awong@chromium.org,thakis@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=360311

Review URL: https://codereview.chromium.org/378363006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282265 0039d316-1c4b-4281-b951-d872f2087c98

BUG=360311
TBR=thestig@chromium.org

Review URL: https://codereview.chromium.org/376403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282261 0039d316-1c4b-4281-b951-d872f2087c98

Match the NSS, CryptoAPI (Win) and Security (OS X) approaches by
declaring the scoped types as specializations of our existing scoped
classes.

Like NSS, this requires an intermediate helper type, because our
scoped_ptr<> doesn't accept deleter functions as template
arguments (though they are valid in C++11's unique_ptr<>). A few base
cryptographic (non-certificate) types are used in
scoped_openssl_types.h, while the remainder are left for
implementations to specialize as needed.

In an ideal world, this would be scoped_ptr<FOO, FOO_free>, but that
will require unique_ptr<> support.

BUG=388904

Review URL: https://codereview.chromium.org/361193003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282257 0039d316-1c4b-4281-b951-d872f2087c98

This contains fixes for the following sorts of issues:
* Signedness mismatch

Defining UChar32 as a signed type may look wrong, but it's actually how the type
is already defined over in third_party/icu/.

BUG=81439
TEST=none

Review URL: https://codereview.chromium.org/380913003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282255 0039d316-1c4b-4281-b951-d872f2087c98

This change plumbs top level window resize notifications from X11 through to the WindowManager and to the GLSurface associated with the top level window. It's an incremental step towards adding support for window manager level layout management (see crbug.com/389785).


BUG=388524

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281955

Review URL: https://codereview.chromium.org/354933002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282254 0039d316-1c4b-4281-b951-d872f2087c98

R=avd@chromium.org,rch@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/380543003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282253 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/380863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282252 0039d316-1c4b-4281-b951-d872f2087c98

The downstream dependencies in Chrome for Android have been
updated to use org.chromium.base.FieldTrialList, so the old
code can be removed.

BUG=378035

Review URL: https://codereview.chromium.org/378403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282251 0039d316-1c4b-4281-b951-d872f2087c98

This patch removes the deprecated ExtensionInstaller and uses
ExtensionInstallChecker in CrxInstaller and UnpackedInstaller.

BUG=386404
TEST=browser_tests
TBR=pam@chromium.org (for include in supervised_user_service_unittest.cc)

Review URL: https://codereview.chromium.org/381553002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282250 0039d316-1c4b-4281-b951-d872f2087c98

We'll have a slightly modified test list.

BUG=382573
TEST=none

Review URL: https://codereview.chromium.org/379933002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282249 0039d316-1c4b-4281-b951-d872f2087c98

This handler was added to forward the message to the parent window for cases where the size of the
parent and the LegacyRenderWidgetHostHWND window were the same.

We can directly call DefWindowProc on the parent window for non client mouse messages which generates
WM_SYSCOMMAND for the parent window.

This simplifies the LegacyRenderWidgetHostHWND class and also fixes bugs with WM_SYSCOMMAND messages not
getting generated correctly due to missing styles on the LegacyRenderWidgetHostHWND hwnd which does not have
the same styles as the parent.

BUG=377367

Review URL: https://codereview.chromium.org/374283002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282248 0039d316-1c4b-4281-b951-d872f2087c98

Previously, we'd halt running all further shards upon a timeout. Now, we'll just
fail the one step and then continue.

BUG=392490

Review URL: https://codereview.chromium.org/378423002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282247 0039d316-1c4b-4281-b951-d872f2087c98

This is mostly to collect performance and size data for now, and to find out
if more bots need work. Unless things look really good, I'm going to revert
this by thursday morning (PDT).

BUG=360311
TBR=ajwong@chromium.org

Review URL: https://codereview.chromium.org/379413002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282246 0039d316-1c4b-4281-b951-d872f2087c98

Currently "warm start" app list cases (i.e. shown via the process
singleton) have noisy UMA data. Whether the profile to show is loaded or
not has a big impact on the metric. We are only interested in the case 
that the app list view is "warm", and can be immediately shown. 
Recording cases that first must load a profile from disk, or switch the 
app list view to a different profile, count as noise and skew the 
metric. 

This change filters out the noise, fixing an incorrect assumption in 
r270615 which resulted in only the noise being recorded (and a failed 
DCHECK otherwise). Before r270615, the UMA included cases requiring a 
profile load as well as those that didn't. After r270615, only cases 
that required a profile load were being recorded. 

Note that ShowAppListInteractiveTest.ShowAppListFlag was updated in
r281213 to include both cold and warm codepaths via
StartupBrowserCreator, to cover the aforementioned DCHECK.

BUG=382793

Review URL: https://codereview.chromium.org/366233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282245 0039d316-1c4b-4281-b951-d872f2087c98

This is a minor refactor, that changes function names.

BUG=NONE

Review URL: https://codereview.chromium.org/375403003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282244 0039d316-1c4b-4281-b951-d872f2087c98

For OMA files, it looks like that android download manager cannot correctly download it.
Some of the files cannot be downloaded, and some of the files downloaded has different binary content as the ones downloaed on chrome desktop.
Bypass android download manager for OMA mime types.

BUG=382698

Review URL: https://codereview.chromium.org/331143010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282243 0039d316-1c4b-4281-b951-d872f2087c98

BUG=NONE

Review URL: https://codereview.chromium.org/383503002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282242 0039d316-1c4b-4281-b951-d872f2087c98

Makes the TwoClientPreferencesSyncTests compatible with
reflection-blocking and enables reflection-blocking in its test harness.

Introduces new StatusCheckers that wait for preferences.  The new
preference status checkers work by observering preference changes rather
than sync cycle completion notifications.  Also introduces some new
status checkers to wait until encryption is enabled.

Removes DisablePreferences and DisableSync tests because we have decided
that there is not enough value in testing disable scenarios to bother
maintaining them for each type.

Removes several translation tests because they seem to not provide much
additional value and they would be particularly onerous to maintain.
Each one of these tests would have needed its own status checker or
a generic status-checker that makes use of an injected Closure.

Removes several encryption tests because they were redundant.

Removes or renames many other redundant tests.

BUG=97780,95742,351159

Review URL: https://codereview.chromium.org/342853004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282241 0039d316-1c4b-4281-b951-d872f2087c98

R=bruening@chromium.org
BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/380813005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282238 0039d316-1c4b-4281-b951-d872f2087c98

Move TemplateURLFetcher and TemplateURLParser to components/search_engines
Add dependencies on libxml and ui/gfx (for gfx::kFaviconSize)

BUG=371535
TEST=build
TBR=sky@chromium.org for include fix under chrome/browser/{importer,profiles}
TBR=danakj@chromium.org as an owner of ui/gfx, a DEPS line moved from chrome/browser/search_engines to components/search_engines
TBR=brettw@chromium.org as an owner of third_party/libxml, a DEPS line moved from chrome/browser/search_engines to components/search_engines

Review URL: https://codereview.chromium.org/373343003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282237 0039d316-1c4b-4281-b951-d872f2087c98