- 06 Jan, 2021 40 commits
-
-
Matt Falkenhagen authored
The "handler" can call the loader callback directly. Bug: 1138155 Change-Id: I618991ca62f83d1336405de7f824fcf43c893ac0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596592 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Asami Doi <asamidoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#840521}
-
Austin Tankiang authored
Bug: 1067346 Change-Id: I32f42a3a4a3c6a1a0d5e24aa013d4610a07fb7bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596471 Auto-Submit: Austin Tankiang <austinct@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#840520}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: I57b45a8093ff7ce88f31bf9c2bb2b6b4fdd1ecaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611087Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840519}
-
Ella Ge authored
Bug: 1152282 Change-Id: I73ea595a0ff4005067510d37790b737d7608fa64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602358Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#840518}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1609890206-499d6ba28146a6731502f2a224934145a8e0db92.profdata to chrome-win64-master-1609901004-14816faec8726b486a5318be3232c28c52f1f131.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I9c05a47718f7c003c7e179f73539455f7111312d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612420Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840517}
-
Shengsong Tan authored
This is part of the "Views Posse" effort. See this document: https://docs.google.com/document/d/1Rst3792TjXtVA8k8GXaPD8MnuB1JAneSOpIILdA4268/edit?usp=sharing Bug: 1159562 Test: build Change-Id: I706f2112b27aceedc94beb081339ed60c11f8c75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599689Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Shengsong Tan <sstan@google.com> Cr-Commit-Position: refs/heads/master@{#840516}
-
Francois Beaufort authored
This CL has no functional changes. It makes aborting operations code much easier to read and maintain in NDEFReader scan and write operations. Bug: 520391 Change-Id: I508819b7083a2b34a1319d53eeffebf0e3ff3ee8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601373 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#840515}
-
Eric Willigers authored
If the script context is not valid during an attempted read, we exit early. This avoids crashes, for example, if navigation or page refresh occurs while a read is pending. Bug: 905818 Change-Id: I1cf2e44eabb6ce35864c3a95e5930ae15c2cc49e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612231Reviewed-by:
Glen Robertson <glenrob@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#840514}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/854ee85736e3..6a718c4e909e 2021-01-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from ff29e249d317 to b9e179f1f239 (1 revision) 2021-01-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 026a067c38ef to b590fd1b9a59 (6 revisions) 2021-01-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from cdbd295cc6c4 to a84acc4fcca8 (7 revisions) 2021-01-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 46171be2 to 302da256 (403 revisions) 2021-01-06 bsalomon@google.com Add more comprehensive test for GPU write pixels. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC johnstiles@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: johnstiles@google.com Change-Id: I0ebe83fce735644c28e6263496d0505f9bac8dde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612419Reviewed-by:
-
Francois Beaufort authored
This CL has no functional changes. It uses scan_resolver_ instead of the redundant has_pending_scan_request_ boolean value in NDEFReader. Bug: 520391 Change-Id: Ia3ee9da792f5f76710474c26f3634d7409bf3ebe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607109 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
-
Sergey Ulanov authored
biffered->buffered Bug: 1162503 Change-Id: I41f54ee15ad364f1fe183954be48604b08e277e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611832 Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#840511}
-
Gyuyoung Kim authored
This reverts commit 8d2f6ff7. Reason for revert: Clusterfuzz reported this CL has caused a crash on Asan build. Original change's description: > Reland "Use blink::mojom::ColorScheme instead of blink::ColorScheme" > > This is a reland of 6ddff235 > > This CL fixes the build error caused by exceeding the max token limit > using the function overloading in text_link_colors.h. This CL makes the > file include forward.h files instead of shared.h using below change. > > FooColor(ColorScheme color_scheme = ColorScheme::kLight) const; > => > FooColor() const; > FooColor(ColorScheme color_scheme) const; > > Original change's description: > > Use blink::mojom::ColorScheme instead of blink::ColorScheme > > > > This CL replaces the existing uses of native ColorScheme > > with ColorScheme Mojo enum type defined in frame_owner_properties.mojom > > in order to remove unnecessary type conversion. > > > > Bug: 919392 > > Change-Id: Iebc2cf4a2094293027a07c643e75e57d75651e91 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473739 > > Reviewed-by: Kentaro Hara <haraken@chromium.org> > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > > Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> > > Cr-Commit-Position: refs/heads/master@{#817773} > > Bug: 919392 > Change-Id: Iaac4bec9df6ee4e68b682658c996618571eb3523 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476695 > Reviewed-by: Kent Tamura <tkent@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> > Cr-Commit-Position: refs/heads/master@{#818774} TBR=kinuko@chromium.org,haraken@chromium.org,tkent@chromium.org,gyuyoung@igalia.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 919392, 1162834 Change-Id: Ic88eca624a189f901b618d3fae414fa26eec52f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612585Reviewed-by:
Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#840510}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I7644dca683edce41e6b58a750d45401515a3a628 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612457Reviewed-by:
-
Weblayer Skew Tests Version Updates authored
This CL will add skew tests for version 88.0.4324.76. R=bsheedy@chromium.org, rmhasan@google.com Bug: 1041619 Change-Id: I111707113bc31bff009349668d721329c68056de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611671 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#840508}
-
Bruce Dawson authored
PartitionAlloc tries to report out-of-memory failures differently depending on whether it thinks that address-space is exhausted. This change improves that by fixing the calculation of how much address space the process has (usually 4 GiB, not 2 GiB, but variable). Bug: 1159694 Change-Id: Ie5dba8ed55f663cf7edbcb824056042953d28c65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606634Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Auto-Submit: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#840507}
-
Matt Falkenhagen authored
ServiceWorkerMainResourceLoaderInteceptor doesn't need to delegate to ServiceWorkerControlleeRequestHandler to create subresource params. It can access the ServiceWorkerProviderHost directly. This simplifies calling the loader callback. Bug: 1138155 Change-Id: Ibf31c379a755c9c94471c707633a582bf7cba85d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602965 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
-
Tim Sergeant authored
This adds support for actions ("send" and "send_multiple") and mime types to filters in the CreateArcIntentFilter function. This isn't currently used, but will be used by the Shadow APKs feature, which needs to send arbitrary IntentFilters through to ARC (see crrev.com/c/2548592). BUG=853604,1099134 Change-Id: Ibf798ac37ca457e112c83a5568d1c064cd8b68f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610409 Commit-Queue: Tim Sergeant <tsergeant@chromium.org> Reviewed-by:Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#840505}
-
Luciano Pacheco authored
Generate JS module for //ui/file_manager/file_manager/background/js/ * device_handler.js * device_handler_unittest.m.js * device_handler_unittest.m.js * launcher.js * launcher_search.js * progress_center.js * volume_manger_unittest.m.js Bug: 1133186 Change-Id: Ib0ffb982f727a76692ceb0ba320269f7ffe9279d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612548 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#840504}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6128ceacf001..3a03505a9fd6 2021-01-06 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com Change-Id: I95aa027d5579244211addfc7fb228311411c6985 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612456Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1609880376-51963dc93137cbb2d9fa681b7bce54c93abd3038.profdata to chrome-win32-master-1609890206-d7d15a5fc738396f6df578241b212439b7df0b43.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Idfe5e2009ecabb7e0514d15d0a17f4e3ea9a9953 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612449Reviewed-by:
-
Yutaka Hirano authored
The shutdown support for keepalive requests (issue 1147162) is not working correctly on some environments. In order to make investigation easier, this CL - adds some VLOGs, and - make the timeout value adjustable. Bug: 1161996 Change-Id: Iccfd491e7fb244c32614221dbf0b96e9bd08d1b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596591 Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
Andrey Kosyakov authored
- introduce experimental PerformanceTimeline domain; - expose LargestContentfulPaint performance event through the above domain; (moar event types are coming) Doc: https://docs.google.com/document/d/180kO9C3yWs5uWuopmCuDjNtGVUNkWY8el07-tyGW7Yk Bug: 1138441 Change-Id: Ie664ef93a609ba6e6f9dcdebd33136f3da5fd8a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606677 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#840500}
-
Matt Falkenhagen authored
Change-Id: I194d88dd986223ab1edae84d26218ea1ff921b29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596734Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#840499}
-
Yunke Zhou authored
This is a reland of b8af3c0a Original change's description: > Oobe: Fix issue with metrics client id reset after sign in > > Issue is due to there's a small time difference between StatsReportingController::SetWithService and pref is properly set. We should only propagate the value from service until it is correctly set. > > Bug: 1154947 > Change-Id: I977249dd25e1402246b383401c9deef4ea8ebc56 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587065 > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org> > Commit-Queue: Yunke Zhou <yunkez@google.com> > Cr-Commit-Position: refs/heads/master@{#838606} Bug: 1154947 Change-Id: I5f61724d871aff31e26411f83ac89b389c2b0c31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599642Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Yunke Zhou <yunkez@google.com> Cr-Commit-Position: refs/heads/master@{#840498}
-
Fergal Daly authored
This is a reland of c669ac6b This is the test only, the fix was landed in https://crrev.com/c/2598087 - the previous test did not reproduce the crash, this one has crash a crash that matches the trace in the wild https://ci.chromium.org/p/chromium/builders/try/linux-dcheck-off-rel/16863? It differs from the previous test by - calling SetNeedsReload (emulating Clank's autorefresh) - navigating to another frame afterwards, triggering Unload - the previous test timed out on some builders. It's possible that the callback was already called before the test's own RunlLoop started, which would mean that the loop never exits. This is avoided by recording whether it has run or not. Original change's description: > [Paint Preview] Post task captured callback > > This CL attempts to fix a bug where calling > WebContents::DecrementCapturerCount in the callback passed to > PaintPreviewClient can result in reloading a crashed render frame. > This is problematic and crashes if it occurs inside RenderFrameDeleted > and PaintPreviewClient::OnFinished is invoked. By posting the callback > it should be invoked after RenderFrameDeleted cleanup is done resulting > in DecrementCapturerCount no longer being called inside > RenderFrameDeleted. > > Bug: 1146573 > Change-Id: Iccb612d89135e058d8fc06de018e7c95cd91657a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595247 > Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> > Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> > Reviewed-by: Mehran Mahmoudi <mahmoudi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#837649} Bug: 1146573, 1160608 Cq-Include-Trybots: luci.chromium.try:linux-dcheck-off-rel Change-Id: I3ef0a81bb4fa99e2f42c6278ba53931aa934793e Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596697Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Auto-Submit: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#840497}
-
Takumi Fujimoto authored
The error message format corresponds to chrome.cast.Error in the Cast SDK, which is also used by the Cast MRP. Bug: 1153895, b/171829399 Change-Id: Ia4c3565472e70d19869bdcf30a7f8cb2897e4691 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585748 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#840496}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I6c765985c6064140eb7b5088a68f8225f6b7cab8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612412Reviewed-by:
-
Hiroshige Hayashizaki authored
Bug: 1033885 Change-Id: Iac5cbc975f4994838fede98e16776ba8039bf201 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612025Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e91097bf3a24..b590fd1b9a59 2021-01-06 ynovikov@chromium.org Roll chromium_revision b5dfde1f..481852c5 (840075:840387) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ianelliott@google.com Change-Id: Idfe124d6467f4bbd95c48d0e01c17ce9a28a8116 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612524Reviewed-by:
-
Luciano Pacheco authored
This script is failing with Python 3. Bug: 1163386 Change-Id: I7d785a1b13ef7fbb91c203be768ba682cc3d6f85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612625 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#840492}
-
Victor Costan authored
Change-Id: I9ca833057c36b2c4242b79a4a536ca814f09c470 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2608759Reviewed-by:
Austin Sullivan <asully@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#840491}
-
Tal Pressman authored
We are in the process of attributing as many mojo interfaces as possible to specific execution contexts, which would enable better control by the browser over those contexts. As part of that effort, this CL uses the execution context's BrowserInterfaceBroker to bind the GamepadHapticsManager remote and moves the code registering the binders accordingly. Bug: 1126758 Change-Id: I6fb734720d56581e7af36a869affe573fc3c4451 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596709Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Commit-Queue: Tal Pressman <talp@google.com> Cr-Commit-Position: refs/heads/master@{#840490}
-
Xiqi Ruan authored
After adding a new category of wallpaper, the category overflows. Adding a scroll bar to make it scrollable. Bug: 1161051 Change-Id: I8e2aee3a04a0c52949824f9a1a0e98ddc8ad9482 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599711 Commit-Queue: Xiqi Ruan <xiqiruan@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#840489}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/200941c79751..a84acc4fcca8 2021-01-06 jiawei.shao@intel.com Enable CompressedTextureZeroInitTest on Win/Intel/Vulkan 2021-01-06 enga@chromium.org Revert "Update PrimitiveTopologyTests to use WGSL" 2021-01-05 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 9a644c7903ca to e6e704145b31 (1 revision) 2021-01-05 enga@chromium.org Update PrimitiveTopologyTests to use WGSL If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC enga@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: enga@google.com Change-Id: I3889ea3aafc8b976d5bb0f8e36a42562a4d59c79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612409Reviewed-by:
-
Jérémie Boulic authored
In //ui/file_manager/file_manager/foreground/js/: - crossover_search_utils.js - fake_android_app_list_model.js - folder_shortcuts_data_model.js - mock_directory_model.js - mock_folder_shortcut_data_model.js - navigation_list_model.js - navigation_list_model_unittest.m.js Bug: 1133186 Change-Id: Iad47cc51481146319fd06c08973544cfd23c609d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612546 Commit-Queue: Jeremie Boulic <jboulic@google.com> Reviewed-by:
-
Bao-Duy Tran authored
Despite being called "util", InputMethodUtil is a stateful class (!) Despite being member of stateful class InputMethodUtil, actually GetInputMethodShortName() is stateless; it's a static util method (!) Except for minor difference in the return type, it operates only on a non-null InputMethodDescriptor instance and is functionally identical to properly object-oriented InputMethodDescriptor::GetIndicator(). The latter is never used anywhere else other than by the former (!) In an attempt to reduce unnecessarily random bags of static utils and promote object-oriented-ness where it deserves for readability, let's fully merge InputMethodUtil::GetInputMethodShortName() into InputMethodDescriptor::GetIndicator(). Bug: 1162216 Change-Id: I085d89ec97bdab03872df696efdb1bcee6865112 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601013Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
My Nguyen <myy@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org> Cr-Commit-Position: refs/heads/master@{#840486}
-
Nicholas Verne authored
Bug: 1131714 Change-Id: Idefdd5ce7c4ae3ca8a99018de500f329ebb39b62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592847Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Reviewed-by:
David Munro <davidmunro@google.com> Commit-Queue: Nicholas Verne <nverne@chromium.org> Auto-Submit: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#840485}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/92311b48d43d..a27c44126b13 2021-01-06 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2021-01-06 glenrob@chromium.org devtools:Update error messages to require a Purpose::ANY icon only. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1151835 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I8dae3a9550fc7b04e9483a5404a53fb72cd3028d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612418Reviewed-by:
-
Jinsuk Kim authored
Follow-up on https://crrev.com/c/2592277 - Move control_container.xml to toolbar/ - Move tab_strip_height dimension to toolbar/ - Merge OWNERS files Bug: 1127732 Change-Id: I143dfb21fbae0f8448d5763b8f7c8ea564ee54c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610387Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#840483}
-
Jérémie Boulic authored
Convert JS files for directory_model.js and dependencies. In //ui/file_manager/file_manager/foreground/js/: - constants.js - directory_contents.js - directory_contents_unittest.m.js - directory_model.js - file_list_model.js - file_list_model_unittest.m.js - file_watcher.js In //ui/file_manager/file_manager/foreground/js/ui/: - file_list_selection_model.js - file_list_selection_model_unittest.m.js In //ui/file_manager/externs/: - entries_changed_event.js To avoid the circular dependency where directory_contents.js depends on directoryModel and directory_model.js depends on DirectoryContents, the constant `DirectoryModel.CROSTINI_CONNECT_ERR` in //u/f/f/f/j/directory_model.js has been moved to `constants.CROSTINI_CONNECT_ERR` in //u/f/f/f/j/constants.js. Remove `DriveMetadataSearchContentScanner.SearchType`, which is a copy of chrome.fileManagerPrivate.SearchType. This makes mocking easier in directory_contents_unittest.m.js. Bug: 1133186 Change-Id: I819da19a9f9c0ab380e4c35c7d6ca3672b2b3556 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610413 Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
-
