- 21 Sep, 2018 40 commits
-
-
Scott Violet authored
And replaces with hit_test_data_.size(). BUG=none TEST=none Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I0bd21c5cfe5ced5df871dc9ed419a291b4633018 Reviewed-on: https://chromium-review.googlesource.com/1239168Reviewed-by:
Ria Jiang <riajiang@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#593352}
-
Dale Curtis authored
base::ResetAndReturn is deprecated and .is_null() syntax is onerous. Mechanically done via: git grep --name-only "base::ResetAndReturn(\&" | \ xargs sed -i "s/base::ResetAndReturn(\&/std::move(/g" git grep --name-only -e "_cb_\.is_null\(\)" *.cc | \ xargs sed -ri "s/!([a-zA-Z0-9_]*)_cb_\.is_null\(\)/\1_cb_/g" git grep --name-only -e "_cb_\.is_null\(\)" *.cc | \ xargs sed -ri "s/([a-zA-Z0-9_]*)_cb_\.is_null\(\)/\!\1_cb_/g" git grep --name-only -e "_cb\.is_null\(\)" *.cc | \ xargs sed -ri "s/!([a-zA-Z0-9_]*)_cb\.is_null\(\)/\1_cb/g" git grep --name-only -e "_cb\.is_null\(\)" *.cc | \ xargs sed -ri "s/([a-zA-Z0-9_]*)_cb\.is_null\(\)/\!\1_cb/g" Bug: none Test: compiles, passes cq Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I7bb2bd9da08a4749b69bfbc6d3f471a1cfc1d6c0 Reviewed-on: https://chromium-review.googlesource.com/1239200Reviewed-by:Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#593351}
-
Eric Karl authored
If we're backgrounded, the OS may aggressively kill procs we try to start. Avoid creating the Viz proc while backgrounded, instead wait for us to come to foreground. Bug: 866631 Change-Id: I01c73707bbb65dcbc87eda1b344de2ce72647b5d Reviewed-on: https://chromium-review.googlesource.com/1239219 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#593350}
-
Kyle Horimoto authored
Previously, the multi-device setup flow ran in a normal user session; when the user wanted to set up a device, the user would be prompted to enter a password before continuing. When the password is entered successfully, an auth token is fetched and is passed to the SetHostDevice() API function. Now, we are adding support for the setup flow as part of OOBE. In OOBE mode, the user has just entered a password in order to sign in, so there is no need to prompt the user a second time. However, since the API function requires that a valid auth token be passed, it is not applicable for this case. This CL creates a new Mojo interface which exposes a function to set a host device without the need for an auth token. The interface is designed to be used only be OOBE. Bug: 884056 Change-Id: Ice02f1d38ed722a97497d5be8b6f603455f8461a Reviewed-on: https://chromium-review.googlesource.com/1235305 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#593349}
-
rbpotter authored
Making divs actionable left the hand pointer on them even when they are disabled. Ensure they are only actionable when not disabled. Bug: 887823 Change-Id: I35ab8355c7ed10d457e3106cd1639b42eb96fd54 Reviewed-on: https://chromium-review.googlesource.com/1239255Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#593348}
-
Leonard Grey authored
Bug: 850098 Change-Id: I8d18484774982a8ec0272f62f0bd77a43668eb0d Reviewed-on: https://chromium-review.googlesource.com/1238796Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#593347}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/0464dbfe8e21..835cc9ad9eb5 git log 0464dbfe8e21..835cc9ad9eb5 --date=short --no-merges --format='%ad %ae %s' 2018-09-21 bhthompson@google.com Add bvt-inline to grunt paladin Created with: gclient setdep -r src/third_party/chromite@835cc9ad9eb5 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ie8c18f652f8664889e0c23d01d02b2225ebf8f96 Reviewed-on: https://chromium-review.googlesource.com/1239205Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#593346}
-
liberato@chromium.org authored
It wasn't included in TestExpectations by https://chromium-review.googlesource.com/c/chromium/src/+/1237235 but it looks like it failed all the same. NOTRY=true TBR=majidvp@chromium.org Bug: 887659 Change-Id: Iabb8204a4b4b05515838cf20378e61d07062ea51 Reviewed-on: https://chromium-review.googlesource.com/1239446Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#593345}
-
sczs authored
Bug: 888107 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I4672a36b92128b3a0fccdfca6f1181b7bcacd0a0 Reviewed-on: https://chromium-review.googlesource.com/1239344Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#593344}
-
Wan-Teh Chang authored
The bitstream for AV1 is frozen now. Change-Id: I3a27762732a6163986720de389a721bb64b0fbbb Reviewed-on: https://chromium-review.googlesource.com/1238657Reviewed-by:
Johann Koenig <johannkoenig@google.com> Commit-Queue: Wan-Teh Chang <wtc@google.com> Cr-Commit-Position: refs/heads/master@{#593343}
-
David Black authored
AssistantWebView observed |content_view_| but did not stop observing it prior to its destruction. When |content_view_| was destroyed, it would attempt to notify AssistantWebView which, in the case of this bug, was already destroyed itself. Note that |content_view_| is owned by ManagedWebContents in chrome/browser. Bug: b:116246256 Change-Id: I5839f60a6ba4c1ba07f0ce0977cdb6e0c4f48158 Reviewed-on: https://chromium-review.googlesource.com/1237412 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#593342}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ab5fb5edb186..9d84ccbaf233 git log ab5fb5edb186..9d84ccbaf233 --date=short --no-merges --format='%ad %ae %s' 2018-09-21 fjhenigman@chromium.org Vulkan: renderer->finish() before reading buffers. Created with: gclient setdep -r src/third_party/angle@9d84ccbaf233 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: Iccf52144b656d9d7ce92ab324226522d030ec124 Reviewed-on: https://chromium-review.googlesource.com/1238860Reviewed-by:
-
Vladislav Kaznacheev authored
This reverts commit 2c775257. Reason for revert: this CL removed badges from ALL search results instead of just local/drive (which is what the bug was for). A better fix is at: crrev.com/c/1238997. Original change's description: > Removes icon badges from app list search result list > > Bug: 872404 > Change-Id: I6b169bf470d9af2ef3c7fca9ef59081615ece5cf > Reviewed-on: https://chromium-review.googlesource.com/1208692 > Reviewed-by: Weidong Guo <weidongg@chromium.org> > Commit-Queue: Kevin Strohbehn <ginko@google.com> > Cr-Commit-Position: refs/heads/master@{#589207} TBR=weidongg@chromium.org,ginko@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 872404 Change-Id: I2ed3f40361473ed590ffbb914fbd7a1e2722aec7 Reviewed-on: https://chromium-review.googlesource.com/1238827Reviewed-by:
Vladislav Kaznacheev <kaznacheev@chromium.org> Reviewed-by:
Weidong Guo <weidongg@chromium.org> Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Cr-Commit-Position: refs/heads/master@{#593340}
-
Charles Zhao authored
This will enable HourAppLaunchPredictor to forget old records so that: (1) Recent actions are more considered. (2) App launching records that have not been used for several months will be deleted from the saved model file. Bug: 871674 Change-Id: Iab08dfedc3b10cb9985030f1141a179529e30798 Reviewed-on: https://chromium-review.googlesource.com/1236614 Commit-Queue: Charles . <charleszhao@chromium.org> Reviewed-by:Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#593339}
-
Robert Ogden authored
Removes the random query param hack and prevents the timeout logic from running in all tests. Bug: 887962, 885252 Change-Id: Icc001d2e6d584228027ae56a12813c02dcaf0b42 Reviewed-on: https://chromium-review.googlesource.com/1239393Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#593338}
-
Francois Doray authored
This CL updates the ProactiveTabFreezeAndDiscard testing config to match variation params that will be used to experiment on stable. Note that we will also experiment with other variation params to assess their impact. The CL also updates the study name to "TooManyTabs", which is the study name used in the server-side config file. Bug: 844426 Change-Id: I3ab5d0d0005843f00c8bb0382ecb66a97670c0fb Reviewed-on: https://chromium-review.googlesource.com/1238996Reviewed-by:
Robert Kaplow (sloooow) <rkaplow@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#593337}
-
Evan Stade authored
1. Remove AshFrameSizeButton dependency on PhantomWindowController via a new interface. For Mash Chrome browser frames, this will be implemented via Mojo (for now, that's a TODO). 2. Add ash::TabletMode utility to //ash/public/cpp, which allows code in //ash/public/cpp to get the status of tablet mode from any process (each process has to provide a callback). 3. Move the files from private Ash to the new directory. Bug: 887051 Change-Id: Ib790a89fae89f02b92b36e1b165d59c9e28b59f7 Reviewed-on: https://chromium-review.googlesource.com/1228978 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#593336}
-
Eric Karl authored
CompositorImplAndroid had sizing logic for gpu::SharedMemoryLimits which was not propogated to Viz. Adding this in. Bug: 886816 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I15b0c75a3a5778bcd912cebd37fa8273736d97d8 Reviewed-on: https://chromium-review.googlesource.com/1237405Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
-
Lukasz Anforowicz authored
This CL also fixes a missing lock that was found by the compile-time analysis in ChildProcessSecurityPolicyImpl::HasPermissionsForFileSystemFile. Bug: 887645 Change-Id: I940ade66bb2d754669c2b5bd408b63c91a1a8d5a Reviewed-on: https://chromium-review.googlesource.com/1237145 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#593334}
-
Michael Giuffrida authored
ArcRobotAuthCodeFetcher will crash if there is no CloudPolicyClient, which can happen when the device hasn't been online since boot. Bug: 875504 Test: ArcRobotAuthCodeFetcherOfflineBrowserTest Change-Id: Ia5412be9a85cfe5028aa30caf74a7b4562d342e7 Reviewed-on: https://chromium-review.googlesource.com/1237255 Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#593333}
-
Kenneth Russell authored
The bots have been upgraded to 10.13.6 and the graphs had to be updated as well. Bug: 885337 Tbr: zmo@chromium.org No-Try: True Change-Id: I676817f3595fee7667c521437bdb907299c08bab Reviewed-on: https://chromium-review.googlesource.com/1239413 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#593332}
-
Tarun Bansal authored
This reverts commit d4d1506d. Reason for revert: Hitting the DCHECK on Chromium startup. crbug.com/888087 Original change's description: > [X11] Don't clear WM state bits when a window is unmapped > > _NET_WM_STATE holds the window state which may be eg: maximized, fullscreen, > minimized, etc. In shutdown, Chrome queries this state so that it can restore > browser windows to the correct state on the next launch. The problem is that > Chrome queries this state (hundreds of times, in fact) after the window has > already gone away. The EWMH spec requires window managers to delete the > _NET_WM_STATE property when a window is unmapped [1], so the state that Chrome > was getting was invalid. > > This CL saves the state when a window becomes unmapped, and includes some small > cleanups. > > [1] https://standards.freedesktop.org/wm-spec/wm-spec-1.3.html#idm140130317598336 > > BUG=882258 > R=sky > > Change-Id: Iacc43563cd54ade77ac83a580ed24434b6802c91 > Reviewed-on: https://chromium-review.googlesource.com/1226645 > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#592570} TBR=sky@chromium.org,thomasanderson@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 882258,888087 Change-Id: Iac2776b33ec366235e233878dcdbfd8530e2ea0b Reviewed-on: https://chromium-review.googlesource.com/1239355 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#593331}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/cd5e40e994a7..f4a7342c6fc4 git log cd5e40e994a7..f4a7342c6fc4 --date=short --no-merges --format='%ad %ae %s' 2018-09-21 hjd@google.com trace_processor: Fix sched_tracker_unittest.cc Created with: gclient setdep -r src/third_party/perfetto@f4a7342c6fc4 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I64c2d4c5b6c154815bdb93d1d2875e03b0d7291c Reviewed-on: https://chromium-review.googlesource.com/1238847Reviewed-by:
-
Clark DuVall authored
Note: Many (all?) of the android_webview multiprocess_mode tests fail when running NS OOP. Bug: 881572 Change-Id: Icca5d99cbaa655153d7ae19eb9283dcb3e4c1946 Reviewed-on: https://chromium-review.googlesource.com/1238820 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#593329}
-
Shakti Sahu authored
Bug: 885322 Change-Id: Ie8b8c31ca6b8aa1a365c69b30d045b9a6eb02ee8 Reviewed-on: https://chromium-review.googlesource.com/1233115 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#593328}
-
Dan Sanders authored
This API allows mojom::VideoDecoder clients to get a list of rules that can be used to reject unsupported Initialize() calls without additional IPC. On the GPU side, this information is gathered from the existing VDA SupportedProfiles factory. On the renderer side, GpuVideoAcceleratorFactories is now responsible for this query, which it does upon construction. If a MojoVideoDecoder is initialized before the query has completed, MojoVideoDecoder will call the remote Intitialize() method as normal. Bug: 839951, 522298 Change-Id: I62b1e2f6ad79f096d273d7591da1e98094b9cbfe Reviewed-on: https://chromium-review.googlesource.com/1066620Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#593327}
-
Pedro Amaral authored
The experimentation with different Clear Tab icons is done so removing the logic that allowed for different icons. Bug: 880758 Change-Id: Iff65898d404cbefa3a3b8c0a65af5d396f68578c Reviewed-on: https://chromium-review.googlesource.com/1228511Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Pedro Amaral <amaralp@chromium.org> Cr-Commit-Position: refs/heads/master@{#593326}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/980ce54f..31b2347a Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If792d9b80550ea70250a1d80f2d4805526973ec9 Reviewed-on: https://chromium-review.googlesource.com/1238830Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#593325}
-
John Rummell authored
Add the encryption scheme used for both the audio and video tracks to the data saved for each media playback. BUG=858855 TEST=new unittests pass Change-Id: I477e3475f6211980d199ab7c873447d70192f719 Reviewed-on: https://chromium-review.googlesource.com/1195924Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#593324}
-
Siddhartha authored
Before this CL lot of proto databases used default write buffer size which is 4MB. Some databases explicitly set write buffer sizes because of telemetry regressions observed. The rest of them were not hit by telemetry stories when they were added. After this CL the default buffer size will be set to 512KB for high end and 128KB for low end devices. Most databases don't store a lot of data, but do a lot of transactions. So, this will cause compaction more often. BUG=851034 Change-Id: Ia0fb28035a8e6e3221ee7dc843924086d062a52b Reviewed-on: https://chromium-review.googlesource.com/1236286 Commit-Queue: Siddhartha S <ssid@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
-
Vladislav Kaznacheev authored
Avoid resizing the badge icon, request it at the required size instead. Bug: 887646 Test: search for "New", see badged "New alarm" action Change-Id: I658356b863dd1334fc9da6187fc7cd86cac7a0d4 Reviewed-on: https://chromium-review.googlesource.com/1239236 Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Reviewed-by:
-
Xiaohan Wang authored
- Fixes ToCdmVideoCodecProfile() to handle VP9 profiles. - Add ToCdmVideoDecoderConfig() helper function. Bug: 592074 Change-Id: I7142fbf8d21e6710f84326235ba1e3b8c52036ee Reviewed-on: https://chromium-review.googlesource.com/1236503Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#593321}
-
John Budorick authored
Bug: 878777 Change-Id: I7d6727fd36523f37db5f670a46e0957b93cb575d Reviewed-on: https://chromium-review.googlesource.com/1239166 Commit-Queue: John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#593320}
-
Tibor Goldschwendt authored
Bug: 884875 Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I402201609f98425169c56983aafb108bb76cb406 Reviewed-on: https://chromium-review.googlesource.com/1238817Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#593319}
-
Khushal authored
Skia doesn't support LCD text for all cases of nested pictures in filters, shaders or picture backed image generators. Make sure we match this for the text analysis canvas in oop raster. R=enne@chromium.org Bug: 878874 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I15c4f2527a9d03dba7f9dcc4e3c999b9a4daebda Reviewed-on: https://chromium-review.googlesource.com/1235151 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#593318}
-
Bruce Dawson authored
While investigating crbug.com/882670 I noticed that the CRT __purecall function was calling the InvalidParameter function instead of the PureCall function. That is happening because the two functions have identical implementations and generate identical code and therefore the linker folds the two functions together. This happens despite compiler optimizations being disabled. This is harmless but causes mild confusion. This CL changes the return code of one of the functions so that the two functions are no longer identical. This change was tested by defining these classes, creating a variable of type Derived, and then checking what call stack appears for the crash in a release build: struct Base { Base() { Middle(); } void Middle() { DerivedFunc(); } virtual void DerivedFunc() = 0; }; struct Derived : public Base { void DerivedFunc() override {} }; I manually confirmed that this fix has the desired effect. Change-Id: I37446600e00a3ee95b009190c471e938ec85e5c0 Reviewed-on: https://chromium-review.googlesource.com/1237539 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#593317}
-
Lukasz Anforowicz authored
This CL cleans-up URLLoaderFactoryBundle[Info] in preparation for adding initiator-origin-keyed factories in the future (for supporting URLLoaderFactories with extension-specific permissions for requests initiated by content scripts). Changes in the CL: - s/factories/scheme_specific_factories/ - s/factories_info/scheme_specific_factory_infos/ Rationale for the changes above: - Making it more explicit that these factories are keyed by a scheme - Differentiating the name from |initiator_specific_factories| that is planned to be introduced in a follow-up CL (https://crrev.com/c/1228478). - Introducing URLLoaderFactoryBundle::SchemeMap - Introducing URLLoaderFactoryBundleInfo::SchemeMap - Fixes for some of issues reported by: git cl lint - Removing URLLoaderFactoryBundle::RegisterFactory that had no callers. - Making URLLoaderFactoryBundle::GetFactoryForURL protected (it used to be unnecessarily public) - Having ChildURLLoaderFactoryBundle delegate to its base class (URLLoaderFactoryBundle) in its implementation of GetFactoryForURL and CreateLoaderAndStart methods. There are no intended behavior changes in this CL (well except skipping a DCHECK in GetFactoryForURL method so that the method can be reused by subclasses with more relaxed invariants). Bug: 846346 Change-Id: Ibbd07debaf518e2b71cf09a2fd92c8b8104b7411 Reviewed-on: https://chromium-review.googlesource.com/1227135Reviewed-by: -
Xiyuan Xia authored
Bug: 794724 Change-Id: Iba80e83e191f616af9331144a372e281dba49fa2 Reviewed-on: https://chromium-review.googlesource.com/1238441 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
-
Vladislav Kaznacheev authored
Previous solution (crrev.com/c/1208692) has to be reverted as it removed badges from a few other search result types where they are actually needed. Bug: 872404 Test: manual Change-Id: I20d3af35a493a52b5a45645e85e5b17f0cbbfeb2 Reviewed-on: https://chromium-review.googlesource.com/1238997Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Cr-Commit-Position: refs/heads/master@{#593314}
-
Bailey Berro authored
- Switches Network file shares settings page to using sentence casing. Bug: chromium:887677 Change-Id: If7bffe4d4b9ffdf464e1d81d782c0a4033b3fb1a Reviewed-on: https://chromium-review.googlesource.com/1237393Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#593313}
-
