- 19 Sep, 2018 40 commits
-
-
Stefan Teodorescu authored
The chrome://management page should only be available on desktop Chrome Bug: 879146 Change-Id: I6ea0d54f1993bbf4875c7479f008eebed5bc3a32 Reviewed-on: https://chromium-review.googlesource.com/1233553Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Stefan Teodorescu <fane@google.com> Cr-Commit-Position: refs/heads/master@{#592494}
-
Wenzhao Zang authored
The screensaver in demo mode should be full-screen and keep staying on top, otherwise user experience would be really bad. If these two things can't be achieved together, I think we should give up using Chrome App for screensaver. The demo mode screensaver app implements its own mechanism to close the window when there's user interaction. If some security issues arise, it'll be the demo mode team's responsibility to fix it. TBR=rdevlin.cronin@chromium.org Bug: 870851 Change-Id: I9773ec9dc99dd6b01c5202bcb5678cd0a59a544b Reviewed-on: https://chromium-review.googlesource.com/1214602 Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#592493}
-
Doug Arnett authored
Bug: 864640 Change-Id: I28f5ac776473882973ab5faad2d4426a1f91b959 Reviewed-on: https://chromium-review.googlesource.com/1228974Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#592492}
-
Antonio Gomes authored
Follow up of [1], that introduces TestURLLoaderFactory::GetPendingRequest. [1] https://crrev.com/c/1234133 TBR=isherman@chromium.org BUG=844938 Change-Id: I59b19774462957fa71e09759f0154471f2a6c8f3 Reviewed-on: https://chromium-review.googlesource.com/1234634Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#592491}
-
Swapnil Raj authored
sync with its server counter part. The auto-fill crowd-sourcing server tries to predicts password length requirements for a form in the classifications pipeline. The server predicts password lengths only for forms which have lengths smaller than the default password length used by Chrome hence the password requirements classifier needs to keep track of the default length of the passwords generated by Chrome, which needs to be kept in sync with the constant on the client to avoid conflicts. Change-Id: I7d8ab63294010989d2996928aa10d25a0d383f7c Reviewed-on: https://chromium-review.googlesource.com/1230064 Commit-Queue: Swapnil Raj <swapnilraj@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#592490}
-
Matthew Jones authored
This is a reland of 27d290e8 Original change's description: > Fix startup grey status bar on < M devices > > This patch moves the white status bar theme to a version specific > v23 directory to prevent L and below devices from using the flashing > between colors. Logic has also been added to ChromeActivity to prevent > these devices from using the grey (darkened version of white) color on > startup. > > Bug: 881239 > Change-Id: I41e5d959fab96623d254f4ff2dd0ea15cb6f9abc > Reviewed-on: https://chromium-review.googlesource.com/1228496 > Commit-Queue: Matthew Jones <mdjones@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Cr-Commit-Position: refs/heads/master@{#591857} Bug: 881239 Change-Id: I96efe736dd6080ba01de2e5c87dca20deac99bf7 Reviewed-on: https://chromium-review.googlesource.com/1230699Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#592489}
-
Michael Spang authored
Bug: 861853 Test: compile Change-Id: Ia9eacbe863736235c64ccbdadaf3f8feaffdd3ee Reviewed-on: https://chromium-review.googlesource.com/1234374Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#592488}
-
Xi Cheng authored
This is a reland of 3d28a29b. In the original change, NotificationPlatformBridgeWinTest.Suppress and NotificationPlatformBridgeWinUITest.GetDisplayed failed in win-asan bot. This CL fixed it. The fix also required MockIToastNotification to derive from RuntimeClass, which significantly simplified its implementation. Original change's description: > Fix a few memory leaks in NotificationPlatformBridgeWin > > We should 1) wrap the bare pointers in ComPtr; and 2) attach > QueryInterfaces to ComPtr directly. > > Bug: 884224 > Change-Id: I91cb5c7312d8e24f59962ffb33faadaba36bd7ef > Reviewed-on: https://chromium-review.googlesource.com/1227493 > Commit-Queue: Xi Cheng <chengx@chromium.org> > Reviewed-by: Finnur Thorarinsson <finnur@chromium.org> > Reviewed-by: Robert Liao <robliao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#591737} Bug: 884224, 886957 Change-Id: If2674299437f04f637f6b2b8278b40a4dbf7b9d0 Reviewed-on: https://chromium-review.googlesource.com/1228991 Commit-Queue: Xi Cheng <chengx@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#592487}
-
Roman Sorokin authored
Now uses '$.' instead of '/deep/' to find elements BUG=chromium:875480 Change-Id: I1c7282cce123047987f436fd90018409545069f7 Reviewed-on: https://chromium-review.googlesource.com/1233839Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
-
Jan Krcal authored
This is a speculative patch for a bug causing a crash in AutofillWalletSyncableService. This CL stops the generic change processor from talking to the syncable service when the service gets stopped. GenericChangeProcessor only talks to the service because it gets pinged by SyncBackendRegistrar. The registrar should not talk to the GenericChangeProcessor after a data type gets deactivated. Normally, a data type should get deactivated before it gets stopped. However, we see crashes in Canary that seem to contradict this expected behavior. Bug: 880029 Change-Id: I64b9ea1c3521a347983a530bc16c1f8e266769b6 Reviewed-on: https://chromium-review.googlesource.com/1230714 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#592485}
-
Brian White authored
Check if the original ranges creation is causing the bad bucket values or if its some kind of corruption since the last time. Bug: 836238 Change-Id: I5b2b72504b6ac6437a9cec3ee42ae7e688be451b Reviewed-on: https://chromium-review.googlesource.com/1234215Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#592484}
-
Steven Bennetts authored
This CL: * Moves KeyboardConfig and the global instance and setter/getter to KeyboardController * Moves KeyboardControlEvent and LogKeyboardControlEvent to KeyboardController (which is the only consumer) * Moves KeyboardOverscrolOverride and SetKeyboardOverscrolOverride to KeyboardController * Removes keyboard::IsKeyboardVisible (only one non test call which already checks enabled() separately) * Moves InsertText to KeyboardController * Makes some changes to KeyboardController to improve alignment of header definitions and implementations. * Removes keyboard_util.h from keyboard_controller.h and removes unnecessary keyboard_util.h includes. For trivial code removal from component_loader.cc: TBR=benwells@chromium.org Bug: 843332 Change-Id: I5226380a80bba1286b36d5d68c5e30c74f4cd9ad Reviewed-on: https://chromium-review.googlesource.com/1225853 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#592483}
-
Xiaoqian Dai authored
This cL does 3 things: - Adjust the functions orders to match the header definitions - Rename AllowEnterExitTabletMode() to AllowUiModeChange() - Make CanEnterTabletMode() private More refactoring is still WIP. Bug: None Change-Id: Ie003023ee40a99907d1030f14f9e7d0c460b6709 Reviewed-on: https://chromium-review.googlesource.com/1234354Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#592482}
-
Antonio Gomes authored
Follow up of [1], that introduces TestURLLoaderFactory::GetPendingRequest. TBR=rogerm@chromium.org [1] https://crrev.com/c/1234133 BUG=844929 Change-Id: I055fb12f77ec3b1511595d7ad111a8cc2091242d Reviewed-on: https://chromium-review.googlesource.com/1234653Reviewed-by:
-
Adrienne Walker authored
These DCHECKs are sometimes being hit in practice, which says that they should not be DCHECKs. Because these are low priority mysteries, remove the DCHECKs and just add an early out to avoid performance cliffs. Bug: 778440, 740113 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I36d1af371127d4d29be608e1351d53a2b547b25c Reviewed-on: https://chromium-review.googlesource.com/1228981Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#592480}
-
Raphael Kubo da Costa authored
This restores part of --no-rebuild's behavior: we only build GN but do not run it afterwards when the option is specified. It's particularly useful when GN is built in a different machine or sysroot than the one where Chromium itself will be built (often with different dependencies installed on the system). Bug: 885139 Change-Id: If9f3386db8324b47b52864bccc685578fd40a689 Reviewed-on: https://chromium-review.googlesource.com/1233708Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Raphael Kubo da Costa (CET) <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#592479}
-
Xiyuan Xia authored
This allows content_browsertests run test_ws in process with single process mash and run it out of process for mash. Changes: - Make test_ws a packaged service in content_browsertests so that it could used in process for single process mash as well as out of process for mash; - Remove the code that launches standalone test_ws for mash; - Update TestWindowService so that it could be createe with content's ContextFactory/Private and CpuInterfaceProvider for single process mash and also works for mash; - Update WmTestHelper to support running in the same process of window service; Bug: 874089 Change-Id: Iece79fb9b96b48b8affb450cb44486c0b7ed00f0 Reviewed-on: https://chromium-review.googlesource.com/1228792Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#592478}
-
Antonio Gomes authored
Follow up of [1], that introduces TestURLLoaderFactory::GetPendingRequest. TBR=droger@chromium.org [1] https://crrev.com/c/1234133 BUG=879774 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I234df7faf00625986e741a5bd3e1b52f34b7191e Reviewed-on: https://chromium-review.googlesource.com/1234554 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1bbc63df5b82..2d4aa9279134 git log 1bbc63df5b82..2d4aa9279134 --date=short --no-merges --format='%ad %ae %s' 2018-09-19 primiano@google.com Merge "trace_processor: Make randomness deterministic" 2018-09-19 lalitm@google.com Merge "trace_processor: Parse systrace counter events" Created with: gclient setdep -r src/third_party/perfetto@2d4aa9279134 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Idc7ad658ccaeebc56f17866a49b9c9e586dfddb3 Reviewed-on: https://chromium-review.googlesource.com/1234573Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592476}
-
liberato@chromium.org authored
While MCVD requests bitstream conversion, AVDA still provided the CSD in the codec config. This CL makes MCVD do that also. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Id27e8833a8d266d5b401bf5c14003ca025bce7b4 Reviewed-on: https://chromium-review.googlesource.com/1228958 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#592475}
-
dpapad authored
Basically eliminating usage of /deep/ selectors. Bug: 875449,860069 Change-Id: I7e53055b712ee6701f240ba6f50c9eb1918d88b1 Reviewed-on: https://chromium-review.googlesource.com/1233113Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#592474}
-
Greg Thompson authored
To prevent users from accidentally restarting or dismissing the dialog if they happen to be typing when it appears. BUG=884831 R=bsep@chromium.org Change-Id: I91c31bd5b122632a3a2ceb13214aac266dfc6020 Reviewed-on: https://chromium-review.googlesource.com/1233576Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#592473}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/eaac597484d5..e5b1844cce9d Created with: gclient setdep -r src-internal@e5b1844cce9d The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I63a5386ec820edbc696fcf752ae6f3b29db37ea3 Reviewed-on: https://chromium-review.googlesource.com/1234574Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592472}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0ff03808e344..c2d0fb17deef git log 0ff03808e344..c2d0fb17deef --date=short --no-merges --format='%ad %ae %s' 2018-09-19 halcanary@google.com include: whitespace changes for clang-format 2018-09-19 mtklein@google.com Revert "Reland "implement SkPixmap::getPixel() with this->readPixels()."" 2018-09-19 halcanary@google.com IWYU: three files 2018-09-19 bsalomon@google.com Revert "Revert "Reland "Add ability to specify different GP textures for each mesh in a draw.""" 2018-09-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 dc8fb9374e0a..5c72f28d1a3f (1 commits) Created with: gclient setdep -r src/third_party/skia@c2d0fb17deef The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=reed@chromium.org Change-Id: I1f07b6b0a733e83cee0d7872c503c8a0f6edff92 Reviewed-on: https://chromium-review.googlesource.com/1233994Reviewed-by:
-
Yuly Novikov authored
TBR=kbr@chromium.org Bug: 883500 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Idfe7f4fe14a9ef18a08a511fcf825862f4f44142 No-try: True Reviewed-on: https://chromium-review.googlesource.com/1234315 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#592470}
-
Antonio Gomes authored
Follow up of [1], that introduces TestURLLoaderFactory::GetPendingRequest. TBR=rdevlin.cronin@chromium.org (straightforward switch after [1]). [1] https://crrev.com/c/1234133 BUG=844928 Change-Id: If14f43964ddc21616cccadc337a8335099567c23 Reviewed-on: https://chromium-review.googlesource.com/1234633Reviewed-by:
-
Ken Rockot authored
Updates Content Service mojom and implementation to tolerate null response headers on navigation completion events. This diff was meant to be part of https://chromium-review.googlesource.com/c/chromium/src/+/1212023 but its boneheaded author failed to upload a new patchset. Bug: 854367 Change-Id: I908badb9103a9da5d5d91ae95019689b286b4ee6 Reviewed-on: https://chromium-review.googlesource.com/1231159Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
-
yileili authored
Bug: b:114756954 Test: Manual Change-Id: I1d58906771ad789232d8c01f6de06ea44ad8e3f8 Reviewed-on: https://chromium-review.googlesource.com/1226527 Commit-Queue: Yilei Li <yileili@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#592467}
-
dpapad authored
Enabling the following tests: CrSettingsChromeCleanupPageTest.All (Removed usage of /deep/) CrSettingsMultidevicePageContainerTest.All (already passing) Also fixing some overlapping inclusion and exclusion patterns (they should not exist). Bug: 875452,860069 Change-Id: Iba0546d24f032af0bfa4c3fb15b383e2ef938269 Reviewed-on: https://chromium-review.googlesource.com/1227479Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#592466}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e4c6d03d..0b5eefe8 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia06993a4dead0ca406a6640e77dff9b72a8cc801 Reviewed-on: https://chromium-review.googlesource.com/1233188Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592465}
-
Doug Arnett authored
Also add check on feature being enabled to also gate instantiating the server blacklist plus a couple tests. Bug: 864640 Change-Id: I332fa10e1fa6711c38a43cef3d179e63b14a5a46 Reviewed-on: https://chromium-review.googlesource.com/1225860 Commit-Queue: Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
-
Ned Nguyen authored
These benchmarks are handy for integration testing our pipeline & to dogfood new big features launch, so keeping them around. *This is part of the effort to add bug components for all perf benchmarks. Change-Id: Id8d8dee935ccc8b58186b2c6f3ec9ea6e5711397 BUG: 886965 Reviewed-on: https://chromium-review.googlesource.com/1234314 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Simon Hatch <simonhatch@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#592463}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/274a6922da39..c57ca0ea3af6 git log 274a6922da39..c57ca0ea3af6 --date=short --no-merges --format='%ad %ae %s' 2018-09-19 stevenjb@chromium.org cros_vm: Do not use sudo for creating VM dir 2018-09-19 manojgupta@google.com chrome_util: Make widevine cdm optional for ARM64. 2018-09-19 achuith@chromium.org cros_vm: Handle SSH port clash better. Created with: gclient setdep -r src/third_party/chromite@c57ca0ea3af6 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ibe8f58d3e1350b60e6cf71429942c04d150591dd Reviewed-on: https://chromium-review.googlesource.com/1233996Reviewed-by:
-
Raphael Kubo da Costa authored
Shaderc was dropped altogether from the tree in commit 7f7dd90b ("Remove Shaderc"), but the code was still being checked out for no reason. Additionally, having third_party/shaderc/src with no accompanying README.chromium causes tools/licenses.py to fail: licenses.LicenseError: missing README.chromium or licenses.py SPECIAL_CASES entry in third_party/shaderc Bug: 39240, 852620 Change-Id: Ic5e98407149ebccf320a976f2810c93f71ee6658 Reviewed-on: https://chromium-review.googlesource.com/1228053Reviewed-by:
Chris Blume <cblume@chromium.org> Commit-Queue: Raphael Kubo da Costa (CET) <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#592461}
-
Sam Maier authored
These are being copied over before the originals are removed to accommodate downstream. TBR=agrieve@chromium.org Bug: 825947 Change-Id: I29a9db48c9d51d80cac8fd2c2d0287844ab8ff75 Reviewed-on: https://chromium-review.googlesource.com/1233718 Commit-Queue: Sam Maier <smaier@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#592460}
-
Robbie McElrath authored
This migrates SyncSchedulerImpl from NetworkChangeNotifier to NetworkConnectionTracker, which works with the network service enabled. Bug: 883126 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I3482c04e6943df0b928eaebd48d9b511c6cb913a Reviewed-on: https://chromium-review.googlesource.com/1222699Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#592459}
-
Daniel Cheng authored
Bug: 742517 Change-Id: Id5ce54250468e9172f65f5dd79b522d08306e086 Reviewed-on: https://chromium-review.googlesource.com/1233121Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#592458}
-
mrefaat authored
Create a field trail entry before experimenting with 50% Beta Bug: 847550 Change-Id: I427bb6d9d798dfe9bd7fa9df8040d790cfa23c44 Reviewed-on: https://chromium-review.googlesource.com/1224797Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#592457}
-
Xiaohui Chen authored
This is a reland of 31a94c76 Original change's description: > assistant: turn on build for chromeos > > Bug: 114082902 > Test: locally build > Change-Id: Id29bb95768d2a6da75b649e4a32b4e37c74a6897 > Reviewed-on: https://chromium-review.googlesource.com/1226263 > Reviewed-by: Mike Frysinger <vapier@chromium.org> > Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#591540} Bug: 114082902 Change-Id: If33405de3b7bb07d3cb048fbb7cd42401a83391a Reviewed-on: https://chromium-review.googlesource.com/1232194Reviewed-by:
Mike Frysinger <vapier@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#592456}
-
Sammie Quon authored
Do not allow app list or its childrens to process events during swipe to close. Cancel swipe to close non scroll/fling event on shelf is seen. Search box widget can still take events on app list, this does not seem to cause any problems, but may need investigating. Also added a test to check local variables get reset after swiping in HomeLauncherGestureHandler. Test: ash_unittest *HomeLauncher*GestureHandlerTest* Bug: 881131 Change-Id: Id0e49e8fc246837900dc1145af12608b5e507874 Reviewed-on: https://chromium-review.googlesource.com/1233193 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
-
