- 21 Sep, 2020 40 commits
-
-
Benoit Lize authored
This was enabled only when DCHECK_IS_ON() to assess stability. Enable it for regular builds as well to assess performance. Bug: 1125999, 1061437 Change-Id: Ia38c81c95ed0e6ba3fab1754cb4809a08f1fea01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421651Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#808942}
-
Ravjit Singh Uppal authored
Bug: 1127074 Change-Id: I99834a4c5efb2dd38ffea9e28f83c8d0592ca9c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405572Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Ravjit Singh Uppal <ravjit@chromium.org> Cr-Commit-Position: refs/heads/master@{#808941}
-
George Burgess IV authored
It seems that this constructor call was intended to be used as a scope guard. In order for that to happen, there has to be a variable name here. Bug: 1130379 Change-Id: I3c5f1ec85cefcfebc6d40ca82488423edb8e7ec1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2420916Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#808940}
-
Collin Baker authored
Bug: 1055150 Change-Id: Iee3d318ff90362a2cc29754b9a118a2a60d5a4c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418809 Commit-Queue: Collin Baker <collinbaker@chromium.org> Commit-Queue: Abigail Klein <abigailbklein@google.com> Auto-Submit: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#808939}
-
Nela Kaczmarek authored
This change adds LookupAffiliationByHashPrefixRequest and LookupAffiliationByHashPrefixResponse to support requesting affiliations by sending only hash prefixes of facets. It will be used in AffiliationServiceImpl to support users requiring more privacy. Bug: 1108279 Change-Id: I69c6d55520d478f276b76b61a47d89d6d14f5958 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421493Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Nela Kaczmarek <nelakaczmarek@google.com> Cr-Commit-Position: refs/heads/master@{#808938}
-
Andrew Grieve authored
Bug: 1130584 Change-Id: I0ad7e220c67f7af029f3e1a4656a832d124b4b0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422119 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#808937}
-
David Tseng authored
This change is somewhat of a workaround to shield Chrome from any issues contained within the underlying tts engine. Issues: - the extension system evicts extensions that don't explicitly fire an Activity as defined by extensions/browser/activity.h - audio playback isn't plumbed through as an activity - engines like Espeak work even for long utterances that hit the eviction time, because they trigger the extension api activity via word callbacks - the Google tts engine currently is buggy for some sentences in emitting callbacks All interleavings of increment/decrements were considered: - engine loads, enable ChromeVox/STS, disable ChromeVox/STS - enable ChromeVox, engine loads, enable STS, disable STS/ChromeVox - enable both STS and ChromeVox, engine loads, disable STS/ChromeVox In all cases, the keep alive count will be 0 at the end. R=dmazzoni@chromium.org Fixed: 1128093 Change-Id: I92b3fc32cd777961e4fbba40c5891c49943b9645 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416571 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#808936}
-
Benoit Lize authored
Bug: 998048 Change-Id: Ida68e21565a44fee0dc22051892eb10c4c806a45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421890Reviewed-by:
-
James Vecore authored
Previously discovery manager assumed transfer updates would only come after a share target was selected. This is not true and can happen when registering the foreground surface if an existing transfer is in progress or recently completed. Fixed: 1128188 Change-Id: I5de66fd895117e37d8f45c76a346e6edabdc564d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419662 Commit-Queue: James Vecore <vecore@google.com> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#808934}
-
Haiyang Pan authored
The graph http://shortn/_OkQ1Rvzvk9 shows the capacity is over OK, only a little bit tight on 09/19. Let's see how it goes after increasing to 60. Bug: 1111436 Change-Id: I65eebf773e9e0ae047ebff7fd0920b7214041483 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422261 Auto-Submit: Haiyang Pan <hypan@google.com> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Commit-Queue: Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#808933}
-
David Bienvenu authored
Change-Id: I6875db3512929aa5671f199acebdd9bbb1d3fefa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422241 Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
Jesse McKenna <jessemckenna@google.com> Cr-Commit-Position: refs/heads/master@{#808932}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 3fb34c1e. With Chromium commits locally applied on WPT: b943d006 "[COOP] Access reporting with 2 reporters." f5abb9c0 "[mathml] Update CSS math-style to match specification update" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: mkwst@chromium.org: external/wpt/cookies NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Change-Id: I81956fd545db263a0b76c022483f4b1f0819d01b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421869Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808931}
-
Filip Gorski authored
The issue observed with Find in Page is that when there is nothing yet to search for (no input) the Talk Back order of visited controls is incorrect: Text entry field is followed by web contents and its elements that can be jumped to, and not by the remaining Find in Page toolbar controls (previous, next and close buttons). The problem happens because the search results counter field, while visible with no input, carries no focusable content. That makes the accessibility API fail and jump to web contents. This patch ensures that the field is gone, when there is no content for it to hold, and makes it visible as soon as there is content. Bug: 1093480 Change-Id: I158114b8b07f7defa12671ab900736ea728401e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421293Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#808930}
-
Alice Wang authored
This CL adjusts the scope of the methods called only in native in WebSigninBridge. Bug: 1124737 Change-Id: I353dea64e7382da0dac4569cd4a4b418d7c869c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421112Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#808929}
-
Tanmoy Mollik authored
Sync error card for sync error incomplete is shown when the ManageSyncSettings page is launched from signin screen. This cl fixes the issue. Bug: 1129935 Change-Id: I9410b902681b2908479f5b64376b34cc57b23a6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418955 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
-
Wan-Teh Chang authored
It is generate_source.py, not generate_sources.py. Change-Id: I2b44dd0ac343d1eaa91b48a4402406009c82b052 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419588Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#808927}
-
Jeffrey Young authored
Append a link to the assistant in launcher results when no tiles are shown. Gated by feature "EnabledEmbeddedAssistantUI". https://screenshot.googleplex.com/9H5Ds7TjUPmgoxi.png BUG=1103703 Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Change-Id: I28dc5c06a85863d0f78eb1da26b214c774008041 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388001Reviewed-by:
Tony Yeoman <tby@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jeffrey Young <cowmoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#808926}
-
Sebastien Lalancette authored
Bug: 1103778 Change-Id: Id4fa1e2ff13e376bfd8d8c99e7405793375225d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422179Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#808925}
-
Martin Šrámek authored
Since we plan to reuse these triggers for another round of surveys soon. Bug: None Change-Id: I7ad17f483288afbac90955ca1a24e21fd9973397 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421489Reviewed-by:
Sean Harrison <harrisonsean@chromium.org> Commit-Queue: Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#808924}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ic87fc75ebf9015fb05d9b71b3d1f06a02573e06e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422205Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808923}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202009210800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/cIWqR5ZGkLWwRsrEQfxfW_msq-yAvUIUa0Xxwz6bCXkC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/138961540,b/152286436,b/159892033,b/162706572,b/165872577,b/165883916,b/168080782 Tbr: media-app@grotations.appspotmail.com Change-Id: I83bad7ba8ef0f532a66b4bb56d9a51a6fe44510a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422206Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808922}
-
Dave Tapuska authored
This change moves the rest of the UpdateVisualState handling into blink. No functional changes are intended. BUG=1097816 Change-Id: Ib162f3add233971c76ceff4206e113bf66c6ad8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402116 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#808921}
-
Victor Hugo Vianna Silva authored
Some code that has minimal dependencies on AndroidSyncSettings depends unnecessarily on SyncContentResolverDelegate in its tests. This CL removes these dependencies (either by mocking AndroidSyncSettings or by using AndroidSyncSettingsTestUtils) and SyncContentResolverDelegate is made a package-private class. Bug: 1129426 Change-Id: I5374ea7378456bc7060e186254d3e6f80523ceb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421811 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#808920}
-
Corentin Wallez authored
Bug: chromium:1130483 Change-Id: Ie339143e1830e70e0da98a3cfc803cc6934f6e65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421509 Commit-Queue: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Austin Eng <enga@chromium.org> Reviewed-by:
Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#808919}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/62f651b1..ef916081 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia4004ba63c758f135307cc524d3252204e68835a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422040Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808918}
-
Mohamed Amir Yosef authored
The feature "AutofillUseApi" is now enabled by default. This CL removes it and starts removing dead code upon the removal of this feature flag. Follow up CLs will do more cleanup! Bug: 1114655 Change-Id: Iff96e341280fe35562469d32660446f5568887f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401040Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#808917}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f343742a8c9d..05f0bbb70bde If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC etiennep@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: etiennep@google.com Change-Id: I3bb0d9354322e82086b035607e5825c868f02449 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422204Reviewed-by:
-
Yves Arrouye authored
This CL inserts the info discussed in go/zt-alt+v-id in the "version" string which already contains the serial number, while preserving the existing placement of the OS version on the left and the serial number on the right. See screenshots in bug. This CL shows the ZTE indication and always includes the ADID even when it is the same as the SN). Bug: chromium:1124875 Test: Build Chrome, deploy and restart UI, see ZTE info if warranted Change-Id: I2a70098546472b2a237ff6f9a0f82f375ab3f3fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404689 Commit-Queue: Yves Arrouye <drcrash@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#808915}
-
dpapad authored
- Emit 'open-changed' events from cr-action-menu and add test. - Update viewer-pdf-toolbar-new to leverage these. - Change viewer-download-controls to use same approach. Previously relied on manually updating a boolean when the menu was triggered and when it was closed. Fixed: 1130107 Change-Id: I9303cd4a6cc4befd5aaf99e7eff9b0b95a8ec5d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421184Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#808914}
-
Tanmoy Mollik authored
The profile image in NewTabPage opens SyncAndServicesSettings page. When MOBILE_IDENTITY_CONSISTENCY is on, it should instead open MainSettings page. Bug: 1129933 Change-Id: I84a1701214b271caf6bf2727391dbc8c7506d468 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421508 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4c87d83d0323..023e1ac7bc8e 2020-09-21 titovartem@google.com Improve reporting of plottable metrics in PC framework 2020-09-21 nisse@webrtc.org Delete unused NetEq stats currentPacketLossRate, currentDiscardRate and addedSamples If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I1054c09fc5ff476fcf67e8e0a13d3f56b8c2228f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422198Reviewed-by:
-
Renato Silva authored
The Assistant flow in OOBE mentions that it will only listen when the device is connected to a power source in order to save battery when no DSP is available. This prevents this message from showing up on Chromebases, Chromebits and Chromeboxes. Fixed: 1109363 Bug: 1109363 Change-Id: I188a06d8e7c42064a6daab8f27a2e963930ee1fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416696 Commit-Queue: Renato Silva <rrsilva@google.com> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
-
David Dorwin authored
Change-Id: Id74811dd56b8a4370959ed5c03a32aeea12ec5a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422338Reviewed-by:
Sharon Yang <yangsharon@chromium.org> Commit-Queue: David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#808910}
-
Rouslan Solomakhin authored
This reverts commit 379dbfae. Reason for revert: Finalizers are banned in Chromium. These finalizers have been causing assertion failures due to being called on the background thread. Bug: 1129695 Original change's description: > Add finalizers to Web Payment Java objects that own native objects > > These C++ objects are destroyed in PaymentRequestImpl.closeUIAndDestroyNativeObjects(). > However, if an object is garbage-collected for any reason without > PaymentRequestImpl.closeUIAndDestroyNativeObjects() being called, > then it will cause a memory leak. > > A finalize method should be added to these objects to ensure destruction > of the owned C++ objects. > > Bug: 1090918 > Change-Id: I12df86f9705d81d630b63223d15354d2b022e888 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392290 > Commit-Queue: DongJun Kim <djmix.kim@samsung.com> > Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#804820} TBR=rouslan@chromium.org,djmix.kim@samsung.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1090918 Change-Id: I7710d7065a7e225be3a331b0dec289506ee1d4c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422238Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#808909}
-
Nate Fischer authored
This adds a collapsible section with manual steps for removing system apps. This is helpful in case the script is broken (I've heard this is still the case for some devices) or someone wants to remove a different system app (ex. WebView shell). Fixed: 1006037 Test: tools/md_browser/md_browser.py Test: Upload to gerrit > open file > click "gitiles" Change-Id: Id7a1bce22df6246bba34b6926a818c24c0e2d37c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419812 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Laís Minchillo <laisminchillo@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#808908}
-
George Burgess IV authored
It seems that this constructor call was intended to be used as a scope guard. In order for that to happen, there has to be a variable name here. Bug: 1130379 Change-Id: I895e76e1f450b944791679e8e2a4df09d5b317f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2420914Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#808907}
-
Ryan Daum authored
* Unless is_char is true blink will interpret the key event as a raw keypress instead of a proper keystroke. Derive and pass through this property correctly. * Mark the event as EF_IS_SYNTHESIZED and ui::kPropertyFromVK, in the same manner that chromeos's virtual keyboard implementation does. Bug: internal b/161811385 Test: manual x86 cast_shell build with wayland_webview_client attached Change-Id: I4d752bd219eb540a719e0bd339ab674bbbd3db23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418999Reviewed-by:Kevin Schoedel <kpschoedel@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Ryan Daum <rdaum@chromium.org> Cr-Commit-Position: refs/heads/master@{#808906}
-
Denis Kuznetsov authored
Also updated OfflineGaiaTestMixin to use new JSChecker features. Bug: 1110790 Change-Id: If30fde066b4768affc1ace615d2a745d791bbc1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418407 Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f2db91bc8aed..2d461fa4a07b 2020-09-21 treehugger-gerrit@google.com Merge "ui: Make it impossible to select the close permalink button" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ia2b549ce5e396bfc678479d7a7c1987914552f21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422200Reviewed-by:
-
Maxim Kolosovskiy authored
The timeout should be in seconds, not minutes. Bug: 1095627 Change-Id: I95b508f6bccaa23150cbf250531e4966c5f35034 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421599 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Milica Selakovic <selakovic@google.com> Auto-Submit: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Milica Selakovic <selakovic@google.com> Cr-Commit-Position: refs/heads/master@{#808903}
-
