- 31 Jul, 2020 40 commits
-
-
David Grogan authored
Even if we have to disable FlexNG via finch, we won't be changing the runtime feature to less than 'experimental', which means layout tests are still run with FlexNG. Bug: 845235 Change-Id: Ia88b647cf3f79ac95b16b3142bbae5de9e618028 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330616Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#793488}
-
Ryo Hashimoto authored
This is a follow-up for http://crrev.com/c/2322426 BUG=None TEST=build Change-Id: Ib7f073356c7949b5eb01e9bba2b06b10d39fc4f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327359Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#793487}
-
Zain Afzal authored
CIPD package: https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/QNVB74wkfoNjZ6cyfuBZDeeNGU4V9H3O7pzdyS84MN4C Release notes: http://go/media_app-x20/relnotes/Stable/media_app_20200729_RC00.html Bug: b/161193547, b/162283554, b/161374196 Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Change-Id: Ieff6b7391eda531d8abdaf6a9e3f1575c66f6480 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328372Reviewed-by:
Rachel Carpenter <carpenterr@chromium.org> Commit-Queue: Zain Afzal <zafzal@google.com> Cr-Commit-Position: refs/heads/master@{#793486}
-
Xing Liu authored
The space between the checkbox drawable and the text is adjusted to 16dp. TBR=dtrainor@chromium.org Bug: 1110521 Change-Id: Id63feab7063908697dcb74a25475af914be674f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330745Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#793485}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d7d79de3af6e..f3a38d978faa 2020-07-30 jmadill@chromium.org Add a custom trace tests loader. 2020-07-30 nguyenmh@google.com Batch-compile and batch-run-replay multiple tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: tobine@google.com Change-Id: Idfc9922d87df7326b3894fc19778b1a11f9199bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331190Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793484}
-
Miguel Casas authored
I was just whipping up a CL to remove the unused |va_vendor_string| param from IsBlockedDriver() when I noticed that there's quite a bit of dance among classes to fill this value: The pre-sandbox singleton VADisplay reads and keeps it as a string (but only valid between InitializeOnce() and Deinitialize()); its client VASupportedProfiles parses it into a VAImplementation enum and holds on to it, and further classes use the enum value. This CL just pushes the enum down to the VADisplay class, removing this info from VASupportedProfiles entirely and simplifying the callsites. Once parsed, it's kept for the lifetime of VADisplay. No new functionality intended. Bug: 1040291 Change-Id: I6f15cdc01977325faf37eada49404b8e0b7222da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329736 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Auto-Submit: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#793483}
-
Tomasz Tylenda authored
The new expiration is M92 release. BUG=b:161834744 TEST=not applicable Change-Id: I57e23d14d6d43471164da0032f072b222d060358 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325298Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Tomasz Tylenda <ttylenda@chromium.org> Auto-Submit: Tomasz Tylenda <ttylenda@chromium.org> Cr-Commit-Position: refs/heads/master@{#793482}
-
Etienne Bergeron authored
There is no behavior change. R=msw@chromium.org Bug: 1025561 Change-Id: I2165cb218cb0fcee4286becc52c95b57f317b904 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331331 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#793481}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/edf39aef..c07c0c93 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I09bede6b40615330b70afa02329dd03be1e26390 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330950Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793480}
-
Jinsuk Kim authored
There are several classes accessing BrowserControlsManager on Chrome- Activity already (being) destroyed. These are abnormal situations where previously BCM has never been instantiated. Rather than letting the flow go through and an exception be thrown, this CL adds the check against the state of the Activity before getting BrowserControlsManager, to prevent the crash in all the reported cases. Bug: 990987 Change-Id: I5fb26495c80af471eeef1929573bd9ede8d3bd09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326551Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#793479}
-
John Delaney authored
These metrics are still in use as heavy ads is still under experimentation and these will be necessary for monitoring post rollout. Bug: 1097939,1097938,1097937,1097929 Change-Id: Ibb2577186bb8dbfb35116290254625c9220065a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329997Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#793478}
-
Etienne Bergeron authored
This CL is changing unicode literal in unittests to follow this order: 1) Ascii only : ASCIIToUTF6(...) 2) Unicode utf8 : UTF8ToUTF16("\u1234") 3) Unicode Wide : WideToUTF16(L"\U12345678") There is no behavior change. R=msw@chromium.org Bug: 1025561 Change-Id: I7b9f15d1cf5a82b3b4ba7a7d23dcac4c6c788e46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330892Reviewed-by: -
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/29cb43d47b7a..bd9fea3cfc8e 2020-07-30 nigi@chromium.org Add a test of rendering with no flags in FPDFViewEmbedderTest.RenderBug664284WithNoNativeText. 2020-07-30 nigi@chromium.org Enable FPDFEditEmbedderTest.SetTextRenderMode for Skia/SkiaPaths. 2020-07-30 thestig@chromium.org Remove |CPDF_RenderOptions::bBGRStripe|. 2020-07-30 thestig@chromium.org Forward declare CFX_TextRenderOptions when possible. 2020-07-30 thestig@chromium.org Remove |CPDF_RenderOptions::bPrintPreview|. 2020-07-30 tsepez@chromium.org Add FXGC_ForceGarbageCollection(). 2020-07-30 thestig@chromium.org Update references to Mac OS X in comments. 2020-07-30 thestig@chromium.org Convert from FPDF_TEXTPAGE to CPDF_TextPage earlier in fpdf_text.cpp. 2020-07-30 thestig@chromium.org Build with -Wc++11-narrowing. 2020-07-30 thestig@chromium.org Move CPDF_CIDFont::LoadMetricsArray() into an anonymous namespace. 2020-07-30 thestig@chromium.org Migrate from OS_MACOSX to OS_APPLE. 2020-07-30 thestig@chromium.org Consistently use defined() with _SKIA_SUPPORT_* macros. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I3af4daabe177fe9377a714821ff1f2498fc175e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330911Reviewed-by:
-
Alexey Baskakov authored
Previously ImageSkia had unscaled ImageSkiaRep inside but MaybeResizeAndPadIconForMd() doesn't understand that. Bug: 1108889 Change-Id: Ic6cbd85c02f93d5fdd527e58c639a2440cf89d44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325349Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#793475}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/0c9204c1839e..ee8c246be71e 2020-07-30 deadbeef@webrtc.org Reland "sdp: parse and serialize b=TIAS" 2020-07-30 deadbeef@webrtc.org Pass NetworkMonitorFactory through PeerConnectionFactory. 2020-07-30 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision f4c74ea1..88f89d7a (792888:793251) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ief99eefa9d9a2d04ab2e36312eaf5008c033a141 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330996 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I274012335ba27fc77762f79fcd6e6479b5872de4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331074Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793473}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/e6061a5922fb..e8c99cbbdd42 2020-07-31 nednguyen@google.com Remove TODO(nednguyen) from the code base If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: rmhasan@google.com Change-Id: I0fd5949619dd01f710cf0123bfcee6ff18d0039f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331191Reviewed-by:
-
Avi Drissman authored
Right now, all flavors of Mac Chrome say “Chrome” in the menu bar. Given that the idea of SxS is to run multiple Chrome instances at once, make that text specify which flavor of Chrome is the active one. The CFBundleName and CFBundleDisplayName in the strings files are always the same as the value in the main Info.plist, so remove them. Those override the value in the Info.plist, and the Info.plist value is modified in packaging to have the “ Dev” and “ Beta” suffixes. Bug: 1111461 Change-Id: I793172d182b7bf6d680136cb357ef2cd627d3cb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330075 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#793471}
-
David Tseng authored
https://chromium-review.googlesource.com/c/chromium/src/+/2330937 disables it on Chrome OS, but msan is the only place it fails. Since the test *only* runs on Chrome OS, the above change is also slightly misleading. TBR=dtseng@chromium.org Fixed: 1111575 Change-Id: I29deca060acd8173c050a368165f9b3a60cfd523 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330744Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#793470}
-
Makoto Shimazu authored
TBR=dominickn@chromium.org No-Try: True Bug: 1111439 Change-Id: Ifc7e9b93b2c010ab22a127bf449664b598761bff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331416 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#793469}
-
Anand K Mistry authored
DictionaryValue::RemoveWithoutPathExpansion() is deprecated. For the case where nullptr is passed for the output argument, Value::RemoveKey() is a trivial replacement. Mostly done with the following command line, plus a bit of finesse: % git grep -l RemoveWithoutPathExpansion | \ xargs sed -E -i 's/RemoveWithoutPathExpansion\((.*), nullptr/RemoveKey\(\1/g' Bug: 646113 This CL was uploaded by git cl split. R=fukino@chromium.org Change-Id: I56d9fac86a971cd2b13fae1a858464ee95afd5e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298781 Auto-Submit: Anand K Mistry <amistry@chromium.org> Reviewed-by:
Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#793468}
-
Piotr Bialecki authored
This reverts commit 0b825660. Reason for revert: causing crashes on Android, see https://crbug.com/1111504 Original change's description: > ExternalVkImageBacking: reuse more VkSemaphores. > > This CL change SharedImageRepresentationSkia::BeginScoped*Access()'s > definition to not pass semaphores's ownership to caller. So the caller > will not release any semaphores, so shared image backings can reuse or > release them. > > Bug: 1004772 > Change-Id: Idfbcf61571a56be6acc8c80ee838ff0e119ba8bf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323562 > Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> > Commit-Queue: Peng Huang <penghuang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#793261} TBR=penghuang@chromium.org,vasilyt@chromium.org Change-Id: I1eb15b90991a7d5a0008e2748850f74c6ca6f7a5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1004772,1111504 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331292 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#793467}
-
Takashi Toyoshima authored
This change clarifies how the Origin header modification works with CORS checks. This wasn't a behavior change from the m79, but the existing behavior. Bug: 1105805 Change-Id: Id3f2e781759a458a8779492fd254cee0c87e3188 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307022 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#793466}
-
Stephen Martinis authored
I forgot to update the reference to the root of the source directory when I moved the script previously. Bug: 1097180 Change-Id: I9b36cb19b627681e806336c94337ad33954d4ede Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330740 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Auto-Submit: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#793465}
-
Avi Drissman authored
Bug: 1105907 Change-Id: I859b63f0e7bb1317084c1dc0f64bdfa4d569a108 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325092 Auto-Submit: Avi Drissman <avi@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#793464}
-
Jongmok Kim authored
Bug: 1100034 Change-Id: Id638fd2fe0f554d7c2c7f440dd27e26954fbec58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325457Reviewed-by:
Caroline Rising <corising@chromium.org> Commit-Queue: Jongmok Kim <jongmok.kim@navercorp.com> Cr-Commit-Position: refs/heads/master@{#793463}
-
Nate Fischer authored
https://crrev.com/c/2309813 recently changed fail_on_output to default to True, but this breaks the internal official build installer script (see bug for details). This sets this back to False at the call site to get the script working again. Fixed: 11115630 Test: install_webview.py -M 86 --bundle Change-Id: If5bc1646bcf6d4ac7e40ee224033cf678b073cd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330813 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#793462}
-
Xing Liu authored
This CL tries to fix test failure on Android P, and reenable several tests. Bug: 1101413 Change-Id: I1f6a3730aac98411d322afbbe456343f491ceef8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330612Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#793461}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1596131728-ae408445987ddd6aa50e0d258bdde96ebf55cf02.profdata to chrome-win32-master-1596139195-1e6f24fe599857a5d76e1ba28ac7e9b1f562f5e8.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com Change-Id: I97cf33dadcd3d1ea844b94c35f2e4d6eb7f72ab6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330991Reviewed-by:
-
Ernesto García authored
Renamed elide_after_interaction_animation to elide_after_web_contents_interaction_animation_ as suggested, to avoid confusion with hover_elide_or_unelide_animation_ Bug: 1106004 Change-Id: I1c1cba6e84f3d0a650905c26dff0fcc65709443c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330532Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Ernesto García <ernestognw@google.com> Cr-Commit-Position: refs/heads/master@{#793459}
-
Rakib M. Hasan authored
Bug: 1050754 Change-Id: I4bae307eb6e5a1758fb87377fce4c5f0fdd46536 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330315 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
-
Kurt Catti-Schmidt authored
This crash occurs when BrowserAccessibility::AccessibilityPerformAction is provided with nodes that span more than one AXTree. BrowserAccessibility::AccessibilityPerformAction does not use the tree ID at all, and assumes all nodes are in the same tree. This is reasonable because most actions are on a single node. However, kSetSelection requires two nodes, and since it's not looking at tree ID's, there is an implicit assumption that the two nodes are in the same tree. When they are not, one of the two nodes is not found and this crash occurs. One possible fix here is to incorporate the tree ID's and allow for selection to span multiple trees. However, Blink doesn't allow for this. So instead, the fix here is to ensure that the selection start and selection end are in the same tree before calling AccessibilityPerformAction. This is done by using the tree ID from the start node and moving until it's at the end of its tree. I added methods in ax_position.h to perform this. I did a look over other calls to AccessibilityPerformAction, in the relevant files and they all appear to be safe from this issue, as they are operating on a single node. Bug: 1105229 Change-Id: I2fa21560ae6d18aa50097e2b3dcd3d2261c5733d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300266 Commit-Queue: Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#793457}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1f05e507a003..f6c424bb5923 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ib812af1a232ad3fdffd5084c534989033000bbe2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330994Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2ddb3ecf006e..7d4d01fbf84f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC petewil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1004848,chromium:1033067,chromium:1046746,chromium:1064151,chromium:1085419,chromium:1090082,chromium:1099917,chromium:1099982,chromium:1100456,chromium:1103655,chromium:1103833,chromium:1105907,chromium:1107615,chromium:1108576,chromium:1108791,chromium:1108957,chromium:1109044,chromium:1110346,chromium:1110902,chromium:1111004,chromium:1111025,chromium:1111363,chromium:1111501,chromium:912681 Tbr: petewil@google.com Change-Id: I51704bc0a1514dbe2d3558e2041391f351df198b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330910Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793455}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 599ebd7d. With Chromium commits locally applied on WPT: 6d63b58a "Split iceGatheringState tests into separate files & update expectations" 5f9b012c "Add wpt/css/css-multicol/multicol-overflow-clip-auto-sized.html" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools jsbell@chromium.org: external/wpt/resources NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Change-Id: I611c8d79a11b24ad77d37b3ea6fa262b1b831685 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330690Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793454}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5a58acd2d744..f6c424bb5923 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I7e02568081f8fcc20cd1a9731902602761362d94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331090Reviewed-by:
-
Brian Sheedy authored
Re-enables testRender_SignInPromo, which was previously flaky due to input events causing captured screenshots to be slightly different. Now that we use Gold for the RenderTests, we can just approve multiple images for the test to work around that particular issue. Bug: 1057843, 898165, 848983 Change-Id: Ibf0df37d35bb7953a3760b68fbe4557f2868eed4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327751 Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
-
Bo Liu authored
Fix a few issues to better handle failure case. * Use MediumTest to get a longer timeout * Use CallbackHelper which has a timeout instead of waiting for draw indefinitely * Allow setting the render callback repeatedly and just use the new one Bug: 1107812 Change-Id: I19c7bed0409f8d1aa3200f06b4bcb9d90f4c5e82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330530Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#793451}
-
Scott Violet authored
BUG=1031060 TEST=covered by tests. Change-Id: Ifdb0db3241c09d8c70cc6e7953fc0278ee913f8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330433 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#793450}
-
Krishna Govind authored
TBR=benmason@chromium.org Change-Id: I5527d5da8d83da1df825825fc46c70a07f0ab8c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330932 Commit-Queue: Krishna Govind <govind@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#793449}
-
