- 02 Aug, 2017 40 commits
-
-
Ella Ge authored
Clean up PointerEventManager:: ProcessCaptureAndPositionOfPointerEvent to replace the last two parameters by a single WebMouseEvent pointer which defaults to null. Bug: 727333 Change-Id: I0af2277b0ecae48ade70d54fdaad4fac16ee23e3 Reviewed-on: https://chromium-review.googlesource.com/598113Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#491453}
-
James Cook authored
When an external display is attached a new RootWindowController and new shelf are created for that display. Shelf alignment is loaded from prefs. However, if the external display is marked as primary then the internal and external displays are swapped. This means that the (new) shelf now on the internal display never reloads its alignment from prefs. Since the screen was locked at attach time, the shelf stays in the bottom_locked state and never becomes visible. Fix this by reloaded shelf alignment from prefs on display swap. Bug: 748291 Test: added to ash_unittests Change-Id: I5780dd3ca3b796b6f46fea9bc46fe875d123701e Reviewed-on: https://chromium-review.googlesource.com/597410 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#491452}
-
Allen Bauer authored
Fix disabled stroke color processing to ensure the non-Harmony disabled color is properly lightened. Bug: 737271 Change-Id: Ie6bb767b8138472037ffb685091cab8c8986b662 Reviewed-on: https://chromium-review.googlesource.com/581630 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#491451}
-
Scott Graham authored
Fuchsia is initially trying to get a headless build up and running so idle detection is unnecessary. Bug: 743296 Change-Id: I497f42d533e853ce397eeae3ced19a490742c0ee Reviewed-on: https://chromium-review.googlesource.com/596505 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#491450}
-
Scott Graham authored
Fuchsia is initially trying to get a headless build up and running so cursors are unnecessary. Bug: 743296 Change-Id: Ia2093400215a00f8dabfbd1365baa4b5f58a556b Reviewed-on: https://chromium-review.googlesource.com/596950 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by:
-
Julien Brianceau authored
Bug: 750830 Change-Id: Ifb5ced5c4dd314b17c0bd1466a5d6bd740753da8 Reviewed-on: https://chromium-review.googlesource.com/598092Reviewed-by:
Nick Carter <nick@chromium.org> Commit-Queue: Nick Carter <nick@chromium.org> Cr-Commit-Position: refs/heads/master@{#491448}
-
dpapad authored
Bug: None Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Icab535f6157bd313cb2fe95ad0a54dd11e6e2da9 Reviewed-on: https://chromium-review.googlesource.com/596682Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#491447}
-
Victor Miura authored
avoid_stencil_buffers blocks MSAA support in Skia. If the compositor requests MSAA surfaces, rendering will fail. R=ericrk@chromium.org BUG=749438,713854 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I887888845a2c1ee18dbccff6e96aa6cd1eac3df2 Reviewed-on: https://chromium-review.googlesource.com/597321Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Victor Miura <vmiura@chromium.org> Cr-Commit-Position: refs/heads/master@{#491446}
-
Yuwei Huang authored
GlDisplayHandlerCore::Initialize is posted before the Core's construction is done, so the app may crash at some point due to race condition. It crashed once in my phone when calling renderer_proxy_->Initialize() while renderer_proxy_ is not ready. Change-Id: If711b56efce2de5f7e4d0a7a883f19b2181ee31e Reviewed-on: https://chromium-review.googlesource.com/597317Reviewed-by:
Scott Nichols <nicholss@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#491445}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5c85b29c..1dc40944 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: I338b78ba745906e8ce6a15c9191d70aca73eb4e3 Reviewed-on: https://chromium-review.googlesource.com/598248Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#491444}
-
Adrienne Walker authored
Also, consolidate all PaintOp validation into new IsValid functions. Reland of https://chromium-review.googlesource.com/c/590749/. TBR=vmpstr@chromium.org,khushal@chromium.org Bug: 749023, 750010 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ifd784e327ddde877e376b5441d88fe4d35cf627a Reviewed-on: https://chromium-review.googlesource.com/596926Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
enne <enne@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#491443}
-
Luna Lu authored
This reverts commit 6829a5b8. Reason for revert: Seems to cause failure in browser_tests SettingsAccessibilityTest.All. See http://crbug.com/749943 Original change's description: > Add accessibility tests for passwords section of Chrome Settings. > > Set up the GTest and Mocha-based a11y testing framework for Chrome WebUI > by defining an accessibility_browsertest.js file for a11y test fixtures > and including this file in the BUILD.gn. > > The passwords section now fires an event when the settings section has > expanded--an event that is responded to in the added a11y test. > > The tests are disabled in debug mode and memory sanitizer mode due to > timeout. > > Bug: 737739 > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation > Change-Id: I8715e83778409802849db38d90fef387db203f9b > Reviewed-on: https://chromium-review.googlesource.com/592156 > Commit-Queue: Tina Quach <quacht@google.com> > Reviewed-by: Hector Carmona <hcarmona@chromium.org> > Reviewed-by: Tommy Li <tommycli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#491409} TBR=aboxhall@chromium.org,tommycli@chromium.org,hcarmona@chromium.org,quacht@google.com Change-Id: I3c96c164e1872946897084a8713317e9d12c0aa5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 737739, 749943 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/598607 Commit-Queue: Luna Lu <loonybear@chromium.org> Reviewed-by:
Luna Lu <loonybear@chromium.org> Cr-Commit-Position: refs/heads/master@{#491442}
-
Walter Korman authored
Bug: 709137 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I5afe52f29511fbb9cd93b086602c48d28eb9f301 Reviewed-on: https://chromium-review.googlesource.com/592291 Commit-Queue: Walter Korman <wkorman@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Vladimir Levin <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#491441}
-
Raphael Kubo da Costa authored
Sync our IDL file with https://github.com/w3c/gamepad/pull/62 ("Switch from WebIDL arrays to FrozenArray<>s in the IDLs"). WebIDL has not had array types since 2015, so finally make our IDL files compliant with modern WebIDL following the spec fix. It is important to note that this change modifies the existing behavior slightly. - |axes| and |buttons| are now frozen objects with all the related consequences for its properties and prototype. - Those two attributes now return the same _object_ until their values change instead of always returning a new object on access. Doing so aligns our code with both the spec as well as Gecko, which has done the above ever since it implemented the Gamepad spec. Bug: 740875 Change-Id: Ifb618c9d4f8860eb55efc882e701dae7390808a5 Reviewed-on: https://chromium-review.googlesource.com/595979Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Commit-Queue: Raphael Kubo da Costa (rakuco) <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#491440}
-
John Abd-El-Malek authored
BUG=598073 Change-Id: I575dec98b3b0145a7fd953de5821f10524a4b8e6 Reviewed-on: https://chromium-review.googlesource.com/588086 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#491439}
-
Xiaocheng Hu authored
This patch replaces a call site of the deprecated function by the proper version (which requires clean layout), which is safe because the layout is: - Either updated by the call site (ExternalRepresentation) - Or intentionally kept dirty due to kLayoutAsTextDontUpdateLayout flag Bug: 698633 Change-Id: I09c3be97ac43e5327cb1175999c83454a15c40f1 Reviewed-on: https://chromium-review.googlesource.com/596709Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#491438}
-
Scott Graham authored
The Fuchsia build is initially trying to get a headless build up and running, so ui/gfx/font is unnecessary currently, other than to link. Bug: 750946 Change-Id: I39607a4dd78d73049d1c33c53e907fdfb7f3cf9c Reviewed-on: https://chromium-review.googlesource.com/596838 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by:
-
Scott Graham authored
Fuchsia is initially trying to get a headless build up and running so a full Screen implementation is unnecessary, other than to be able to link. Bug: 750946, 743296 Change-Id: Ib6333a304deacbd22d3f1b1f3af8fc9ca063bb15 Reviewed-on: https://chromium-review.googlesource.com/596949 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by:
-
Robert Ma authored
Change-Id: Ibe8ccc0be09764fe4aca158dd9fec026bd7b4ce2 Reviewed-on: https://chromium-review.googlesource.com/592414Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#491435}
-
Vadym Doroshenko authored
Normalizing of password form action is done in 2 different cases with different code: 1.On Load, in Obj-C code in password_controller.mm 2.On fill in JS in password_controller.js That's bad, as any duplicating code, because in some cases it generates different canonical actions (for example when the action is empty). This CL unifying canonical action calculation. As a model for canonical action calculation GetCanonicalActionForForm from Desktop/Android implementation is taken. Bug: 710438, 708602 Change-Id: I1ea879c60d01cf02bed6ea9715089221971ff4a0 Reviewed-on: https://chromium-review.googlesource.com/596031 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#491434}
-
Hiroshige Hayashizaki authored
By passing ScriptElementBase/ScriptLoader instead of Element. This CL shouldn't change the behavior. Bug: 686281 Change-Id: I903482390623d18bcff9b6358dc9ee12e1ef7495 Reviewed-on: https://chromium-review.googlesource.com/564144Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#491433}
-
Ken Rockot authored
SingleThreadTaskRunner is still required, but we should not need a specific BrowserThread. This is part of the task scheduler migration effort. BUG=None Change-Id: I23dfba4f9acd51176d8df18f6269090494808a69 Reviewed-on: https://chromium-review.googlesource.com/594719Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#491432}
-
Alexander Timin authored
Use 1 second reporting chunks for main thread load instead of 1 minute. Increase metric version from 3 to 4. R=rkaplow@chromium.org Change-Id: I7faf6ee875a97c9c6545a23760828f4d5dcfbc4b Reviewed-on: https://chromium-review.googlesource.com/583616 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#491431}
-
Elliot Glaysher authored
This code was literally unusued. Bug: 746054 Change-Id: I65b7a748818ee074b48745c0a4f9260e8fd6c852 Reviewed-on: https://chromium-review.googlesource.com/596916Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Elliot Glaysher <erg@chromium.org> Cr-Commit-Position: refs/heads/master@{#491430}
-
Gregory Chatzinoff authored
The print Earl Grey tests were disabled on iOS11 because Earl Grey is unable to interact with the share menu. This CL fixes the test in iOS 11 by going through the dispatcher to open the print view controller instead of through the share menu. Also, iOS 11 changed the print view controller's accessibility labels, so use an accessibility id (which is unchanged) to verify that the print view controller opened. Bug: 747441 Change-Id: I809d089b50c294cc2ac5a9c92bcfefc1da41f8c5 Reviewed-on: https://chromium-review.googlesource.com/597429Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Gregory Chatzinoff <gchatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#491429}
-
Leslie Watkins authored
Previously, the NotificationPresenter was being explicitly destroyed before the NotificationRemover, causing a segfault. This CL corrects that bug. Bug: 751192 Change-Id: I397c1a7d96ddf9a8721ae96716952055ee4e0c75 Reviewed-on: https://chromium-review.googlesource.com/596502 Commit-Queue: Leslie Watkins <lesliewatkins@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#491428}
-
Scott Chen authored
Currently the Pack Extensions dialog just crashes or silently fails when an error or warning is raised. This CL implements an alert system that is in parity with the old extensions page. Bug: 741900 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I6e85b6da179495f20b0c0122a0592607f892d8f9 Reviewed-on: https://chromium-review.googlesource.com/587971 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
-
Ella Ge authored
Remove a line missed when removing enable-pointer-event flag. Related cl: https: //codereview.chromium.org/2921923002 Bug: 687976 Change-Id: I1d129b05fce79a565ff9a92493d2e16c2d383cf8 Reviewed-on: https://chromium-review.googlesource.com/596689Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#491426}
-
Jochen Eisinger authored
R=brettw@chromium.org Change-Id: I049857e9eb094d60e153074b361dab7146a13623 Reviewed-on: https://chromium-review.googlesource.com/596968 Commit-Queue: Brett Wilson <brettw@chromium.org> Reviewed-by:
Brett Wilson <brettw@chromium.org> Cr-Commit-Position: refs/heads/master@{#491425}
-
Charles Burnell authored
Simple guard to prevent tasks with pid 0 from being killable. If a user tries to kill a task with pid 0 there is a crash. By doing a simple check to see if the pid is 0 we prevent this. A pid should also only be 0 for a short period of time in certain race conditions. Bug: 749459 Change-Id: Iba63b63d6606dbf403cbae3bf2fef4c882f395c5 Reviewed-on: https://chromium-review.googlesource.com/594308Reviewed-by:
-
Bin Zhao authored
Currently we have CastSocket::OnOpenCallBack = base::OnceCallback<void(int channel_id, ChannelError error_state)>. We need to call CastSocket* socket = cast_socket_service_->GetSocket(channel_id); to get socket object in callback function, which seems unnecessary. Make CastSocket::OnOpenCallback take CastSocket* parameter instead. Callback is invoked by CastSocket object with 'this' pointer. Since CastSocket only runs on the IO thread, so do callback functions, no post task is involved, raw pointer seems safe. Resolve code review comments for: https://chromium-review.googlesource.com/c/575247 Bug: 749762 Change-Id: Iaab109774fa2c67d99a7fa5afffdf2315b32fd59 Reviewed-on: https://chromium-review.googlesource.com/590588 Commit-Queue: Bin Zhao <zhaobin@chromium.org> Reviewed-by:Derek Cheng <imcheng@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#491423}
-
Vasilii Sukhanov authored
PasswordStore uses SKIP_ON_SHUTDOWN for background sequence. That means that PasswordStore::DestroyOnBackgroundThread() can be skipped. In this case PasswordStore::* may be destroyed on the UI thread. It's not a problem for PasswordSyncableService. We just need to remove the check in the destructor. PasswordReuseDetector has this check implicitly via base::CancelableTaskTracker. Thus, we can just leak the object. Bug: 741660 Change-Id: Ic49cb068733c159bca55e8d76eb58f70793f5fbe Reviewed-on: https://chromium-review.googlesource.com/598008Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#491422}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/33dd830890d3..aea80dcc0abc $ git log 33dd83089..aea80dcc0 --date=short --no-merges --format='%ad %ae %s' 2017-08-01 hnakashima Remove CFX_ByteTextBuf from cpdfsdk_interform.cpp and others. Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: Iae59aa9c663dd1b04b1ccb2bdd7e3b9d23b802ae Reviewed-on: https://chromium-review.googlesource.com/598315 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#491421}
-
cburn authored
RenderProcessHosts. This is useful because it will track processes that are otherwise not included in the current task manager. An example of this is the NTP which has a service worker that lives beyond navigating away from the NTP. With this you can accurately see when the termination of the RenderProcessHost that is running this service worker. This version is requires the commandline flag of "--task-manager-show-extra-renderers" to be used. BUG=716609 Review-Url: https://codereview.chromium.org/2988453002 Cr-Commit-Position: refs/heads/master@{#491420}
-
Wenzhao Zang authored
The current implementation of animated avatar didn't consider small pods, resulting in the listed bug. Also sets a timeout for switch animation. Bug: 751343, 721647 Change-Id: I5b9cafc737c082865d33520cfafca2963554be4f Reviewed-on: https://chromium-review.googlesource.com/597051Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#491419}
-
David Tseng authored
- the RendererAccessibility layer already queues up events - this interferes with scoping of user actions i.e. a posted task is no longer on the same call stack and is no longer identified as an action - cleans up some ChromeVox assumptions - extend ChromeVox read all to sync selection as it goes and enable it to work inside of editables Test: navigate with ChromeVox in a text field; perform a read from here Bug: Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I2df30c907e01fba4760271ee0a3e86b031342f9b Reviewed-on: https://chromium-review.googlesource.com/592514Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#491418}
-
Weiliang Chen authored
Always calls SetNew right after creating SharedQuadstate to set all the values on SharedQuadState. This is to help catch all cases when switching to use id in later CLs. R=danakj@chromium.org Bug: 739429 Change-Id: I029f73d2ff3b261ce12da65ba7eb49b6323f37c1 Reviewed-on: https://chromium-review.googlesource.com/596768 Commit-Queue: weiliangc <weiliangc@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#491417}
-
Ryan Hansberry authored
Without being a system notifier, MultiUserNotificationBlockerChromeOS::ShouldShowNotification() returns false, preventing Tether notifications from displaying. It's appropriate to consider Tether a system notifier given that it is baked into the system tray and Settings. Bug: 747639, 672263 Change-Id: I0f0d9a4ce3da7c62b148af979c611eaca6682053 Reviewed-on: https://chromium-review.googlesource.com/596833 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#491416}
-
spqchan authored
The WebTextfieldTouchBarController observes the autofill popup window to display the autofill items. This CL makes sure that it stops observing the old popup before it observes a new one. Bug: 750570 Change-Id: I8298a83f3cd1fae7363f6a3d16d9a15f24342cb7 Reviewed-on: https://chromium-review.googlesource.com/596915Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#491415}
-
Nektarios Paisios authored
R=dmazzoni@chromium.org Bug: Change-Id: I6663a127e00f45975961e5cacf48c6be32facccf Reviewed-on: https://chromium-review.googlesource.com/596749Reviewed-by:
-
