GitLab

Previously, if there were multiple CVC fields and some were empty, we
would stop looking after encountering an empty one and assume that no
CVC value was available.

BUG=605230

Review URL: https://codereview.chromium.org/1903183003

Cr-Commit-Position: refs/heads/master@{#388586}

Change the cancelable flag to be an enumeration so that we
can determine if it is blocking or non-blocking and the reason.

Wheel events will add this flag in a follow up CL.

BUG=601661

Review URL: https://codereview.chromium.org/1888163003

Cr-Commit-Position: refs/heads/master@{#388585}

https://chromium.googlesource.com/skia.git/+log/36db3f44b6cd..9134686fd9ce

$ git log 36db3f44b..9134686fd --date=short --no-merges --format='%ad %ae %s'
2016-04-20 mtklein Revert of SkOnce: 2 bytes -> 1 byte (patchset #4 id:60001 of https://codereview.chromium.org/1904483003/ )
2016-04-20 msarett Add SkEncodedInfo to report properties of encoded image data
2016-04-20 robertphillips Begin removing deprecated (and now, unused) ImageFilter code paths
2016-04-20 robertphillips Fix ImageFilter fuzzer issue
2016-04-20 mtklein SkOnce: 2 bytes -> 1 byte
2016-04-20 brianosman Get skiaserve working on Windows.
2016-04-20 jvanverth Revert of Use transfer buffer for BatchAtlas texture copies (patchset #9 id:160001 of https://codereview.chromium.org/1888473002/ )
2016-04-20 bungeman SkTArray movable and swap for move only elements.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=fmalita@google.com

Review URL: https://codereview.chromium.org/1899943006

Cr-Commit-Position: refs/heads/master@{#388584}

The original code encodes the PNG and sends the buffer over to the
renderer. The renderer then registers a blob with that buffer, which
transfers all the data back to the browser. Then the data is copied back
over to the renderer when the page tries to read the image/png
DataTransferItem.

Instead of sending the data back and forth so many times, just register
the blob directly in the browser process.

On a 1366x768 test image, there's no measurable difference: it takes
~0.125s to execute DataTransferItem::getAsFile() for an image.

On a 4000x4000 test image, there's a small difference: the old version
takes ~9.1s and the new version takes ~8.9s. It turns out memcpy is
pretty fast!

BUG=none

Review URL: https://codereview.chromium.org/1876653003

Cr-Commit-Position: refs/heads/master@{#388583}

Refactors SourceBufferStream::FindNewSelectedRangeSeekTimestamp() to be more
readable and to handle a few edge cases when the last read position has been
removed and new buffers are appended. Includes new tests for the edge cases.

BUG=140875

Review URL: https://codereview.chromium.org/1898373002

Cr-Commit-Position: refs/heads/master@{#388582}

Add bindings for EGL_ANGLE_stream_producer_d3d_texture_nv12,
EGL_KHR_stream, EGL_KHR_stream_consumer_gltexture, and
EGL_NV_stream_consumer_gltexture_yuv.

BUG=574292

Review URL: https://codereview.chromium.org/1903063002

Cr-Commit-Position: refs/heads/master@{#388581}

It should be true if the GL context supports it, and off otherwise.
Lying isn't helpful.

It was added in the initial blimp/ commit, without discussion about
why it was there, though it was at least considered as it came up
here: https://chromiumcodereview.appspot.com/1295243003/diff/20001/blimp/client/compositor/blimp_context_provider.cc?_ga=1.66997032.780449993.1417466767#newcode101

R=dtrainor@chromium.org
BUG=584497

Review URL: https://codereview.chromium.org/1898983003

Cr-Commit-Position: refs/heads/master@{#388580}

The gn built mini_installer was failing on Windows 10. This was
because the mini_installer was inadvertently launching Chrome when it
was not supposed to. This in turn was because setup.exe was missing its
manifest and therefore thought it was running on an earlier version of
Windows and therefore tried to pin Chrome's shortcut which on Windows 10
launches Chrome through a separate thread that runs inscrutable shell32
goop.

Messy problem, trivial fix.

BUG=604752

Review URL: https://codereview.chromium.org/1900343005

Cr-Commit-Position: refs/heads/master@{#388579}

No real transform changes should be detected in LayoutSVGHiddenContainer
since it's used for things making up (==roots of) "isolated subtrees".

BUG=603956

Review URL: https://codereview.chromium.org/1905533003

Cr-Commit-Position: refs/heads/master@{#388578}

https://storage.spec.whatwg.org/#api

Adds navigator.storage.estimate() which returns a Promise
with {usage, quota} values in bytes. This is behind
the --enable-experimental-web-platform-features flag.

I2I: https://groups.google.com/a/chromium.org/d/msg/blink-dev/P6eY26vB91c/Ri4ohXOPBQAJ

R=kinuko@chromium.org

Review URL: https://codereview.chromium.org/1855623002

Cr-Commit-Position: refs/heads/master@{#388577}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/5a702cdeb6e3..c09ac1b3f0c5

$ git log 5a702cdeb..c09ac1b3f --date=short --no-merges --format='%ad %ae %s'

TBR=catapult-sheriff@chromium.org

Review URL: https://codereview.chromium.org/1905723002

Cr-Commit-Position: refs/heads/master@{#388576}

BUG=553674

Review URL: https://codereview.chromium.org/1911543002

Cr-Commit-Position: refs/heads/master@{#388575}

Review URL: https://codereview.chromium.org/1904803002

Cr-Commit-Position: refs/heads/master@{#388574}

BUG=411892

Review URL: https://codereview.chromium.org/1907453003

Cr-Commit-Position: refs/heads/master@{#388573}

This CL adds the appearance browser proxy and wallpaper
settings in the appearance settings.  Wallpaper settings
only appear on Chrome OS.

BUG=531786

Review URL: https://codereview.chromium.org/1896283003

Cr-Commit-Position: refs/heads/master@{#388572}

This patch takes advantage of the ability to consume a Mojo service
directly in //third_party/WebKit/Source/modules to remove the
//third_party/WebKit/public/platform/modules/webusb,
//content/renderer/usb and the rest of that intermediate layer.

BUG=None

Review URL: https://codereview.chromium.org/1850023002

Cr-Commit-Position: refs/heads/master@{#388571}

This patch removes the following unused test friend:
    FRIEND_TEST_ALL_PREFIXES(
        ImageQualityControllerTest, LowQualityFilterForLiveResize);

In addition, several unused includes have been removed.

BUG=604462

Review URL: https://codereview.chromium.org/1897043003

Cr-Commit-Position: refs/heads/master@{#388570}

Session manages agents list, does bookkeeping and handles messages.
Session only exists while client is attached.
There will be one session per client in multi-client scenario.

Simplified InspectorAgent interface along the way.

BUG=590878

Review URL: https://codereview.chromium.org/1899933003

Cr-Commit-Position: refs/heads/master@{#388569}

BUG=554298

Review URL: https://codereview.chromium.org/1899083003

Cr-Commit-Position: refs/heads/master@{#388568}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/afcc5532..2a883daa

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1901393004

Cr-Commit-Position: refs/heads/master@{#388567}

BUG=596555

Review URL: https://codereview.chromium.org/1900373002

Cr-Commit-Position: refs/heads/master@{#388566}

BUG=b:24572007

Review URL: https://codereview.chromium.org/1891423003

Cr-Commit-Position: refs/heads/master@{#388565}

Remaining dependencies are necessitated by DockedWindowLayoutManager.

BUG=603369
TEST=covered by other tests
R=jamescook@chromium.org

Review URL: https://codereview.chromium.org/1901593004

Cr-Commit-Position: refs/heads/master@{#388564}

Also makes SetServicesDiscoveryComplete virtual. This way we can have
different implementations of these functions.

Also modifies mock adapters to specify what this now virtual functions
return.

BUG=599472

Review URL: https://codereview.chromium.org/1908523002

Cr-Commit-Position: refs/heads/master@{#388563}

The let's add more params approach makes the test very hard to
read, so this pulls out a params/builder-ish method that hopefully
clears this up (for people other than just me).

BUG=

Review URL: https://codereview.chromium.org/1909503003

Cr-Commit-Position: refs/heads/master@{#388562}

CreateSharedMemory() has been deprecated and no longer needs to be
overridden in DesktopCapturer::Callback implementations.

Review URL: https://codereview.chromium.org/1902593004

Cr-Commit-Position: refs/heads/master@{#388561}

If the timeConstant is not strictly positive, setTargetAtTime should
throw an error.

BUG=604775
TEST=audioparam-exceptional-values.html updated with new test

Review URL: https://codereview.chromium.org/1897293002

Cr-Commit-Position: refs/heads/master@{#388560}

After thre refactoring related to remoteviews based bottom bar, the old
API stopped working. This CL fixes the breakage.

BUG=604849

Review URL: https://codereview.chromium.org/1895813004

Cr-Commit-Position: refs/heads/master@{#388559}

Revert of [tracing] Turn StackFrame into struct. (patchset #5 id:80001 of https://codereview.chromium.org/1891543003/ )

Reason for revert:
Broke build on Windows x64 (warning was treated as error): heap_profiler_allocation_context.cc(58): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data

Original issue's description:
> [tracing] Turn StackFrame into struct.
>
> This change turns StackFrame (aka const char*) into a struct and
> introduces 'type' field which controls how stack frame is formatted
> when it's written to trace file. As an example, thread name, which
> previously was just a string like any other function name, is now
> formatted as '[Thread: %s]'.
>
> More stack frame types will be added in the future, for example
> native allocation tracing will add 'program counter' type.
>
> BUG=602701

TBR=primiano@chromium.org,ssid@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=602701

Review URL: https://codereview.chromium.org/1907593002

Cr-Commit-Position: refs/heads/master@{#388558}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/d3578ff8c479..5a702cdeb6e3

$ git log d3578ff8c..5a702cdeb --date=short --no-merges --format='%ad %ae %s'

BUG=602701

TBR=catapult-sheriff@chromium.org

Review URL: https://codereview.chromium.org/1902103004

Cr-Commit-Position: refs/heads/master@{#388557}

I want to store some state in properties that needs to be valid from
the LayoutManagers destructor. This means the LayoutManager needs to
be destroyed before owned properties.

BUG=603369
TEST=none
R=ben@chromium.org

Review URL: https://codereview.chromium.org/1910483002

Cr-Commit-Position: refs/heads/master@{#388556}

TBR=mattm@chromium.org
BUG=598752

Review URL: https://codereview.chromium.org/1908613002

Cr-Commit-Position: refs/heads/master@{#388555}

This flag was recently added in GN. This patch hooks it up to the toolchains
and moves some flags to use it that previously had to be hardcoded on the
tool command itself.

Remove concurrent_links variable from gcc_toolchain which was unused.

BUG=598599

Review URL: https://codereview.chromium.org/1896163003

Cr-Commit-Position: refs/heads/master@{#388554}

This change turns StackFrame (aka const char*) into a struct and
introduces 'type' field which controls how stack frame is formatted
when it's written to trace file. As an example, thread name, which
previously was just a string like any other function name, is now
formatted as '[Thread: %s]'.

More stack frame types will be added in the future, for example
native allocation tracing will add 'program counter' type.

BUG=602701

Review URL: https://codereview.chromium.org/1891543003

Cr-Commit-Position: refs/heads/master@{#388553}

I suspect that the task runner is null for some reason which caused the
crash in the bug. Since I can't repro locally, adding a CHECK so help
investigation.

BUG=604869

Review URL: https://codereview.chromium.org/1896173003

Cr-Commit-Position: refs/heads/master@{#388552}

Currently CanvasPathMethods does a premature optimization in
stroking line, curve, arc, rect---it drops the point when the
 point is identical to current point, or in the case or
curve, drops the curves when the two given points are
identical. The results in incorrect rendering of zero-length
paths with caps, based on the specification
(https://www.w3.org/TR/2dcontext/#drawing-paths-to-the-canvas).

The five layout tests in philip/tests/2d.path.stroke.prune.*.html
are outdated canvas tests. Based on the spec change and the test
results here
 (https://philip.html5.org/tests/canvas/suite/tests/results.html),
other browsers report false positive errors on these
tests too. We thus match what other browsers do in this
aspect and rebaseline the expected outputs.

BUG=322807,577655

Review URL: https://codereview.chromium.org/1883693002

Cr-Commit-Position: refs/heads/master@{#388551}

The spec calls for one additional pt of space between the icon and the
text.

R=avi@chromium.org
BUG=596684

Review URL: https://codereview.chromium.org/1900873004

Cr-Commit-Position: refs/heads/master@{#388550}

Browser tests that do media playback have never worked on internal
builds (they are disabled there) because we block media playback
until an application moves to foreground.  The test page never
reaches this state because it is managed outside ApplicationManager.

With this change, starting a test page can be delegated to internal
code and handled through ApplicationManager.  This allows the test
to reach foreground status and play media.

BUG=internal b/27192870

Review URL: https://codereview.chromium.org/1870443003

Cr-Commit-Position: refs/heads/master@{#388549}

R=brettw@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1895413005

Cr-Commit-Position: refs/heads/master@{#388548}

The OzonePlatform instance doesn't exist in the chrome browser process
when running mash. ImeKeyboardOzone tries to access the instance and
crashes. Always use FakeImeKeyboard with mash until mash IME work is
started and this can be done properly.

BUG=603959

Review URL: https://codereview.chromium.org/1908583002

Cr-Commit-Position: refs/heads/master@{#388547}