- 11 Sep, 2019 40 commits
-
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /chromecast. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=servolk@chromium.org Bug: 891670 Change-Id: Iaa04676f2f42a2be1353c0ac67cfeba6086143b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786985 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#695744}
-
Oksana Zhuravlova authored
This change converts LockManager mojom interface client in blink to use BrowserInterfaceBroker. RenderProcessHost now has a CreateLockManager() method, which is called by handlers for frames and workers. Bug: 936482 Change-Id: I1f3b38549d352593eea27a9a3f12d14fe7681f5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785621 Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#695743}
-
Charlene Yan authored
This would occur due to the pin button appearing after the item was hovered. This change makes this no longer an issue since the pin button will always be visible. Bug: 1001617 Change-Id: If0c5886b2cd7cd33379bbe70ae58cb2c408acb9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798669Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#695742}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /chrome/utility/image_writer. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=haven@chromium.org Bug: 891670 Change-Id: Id42c705ac4a5dba6785b770aa62c377b029e1faa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786968 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#695741}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Icd0a3462102e7bbd3c5335175f1c67e117fc6b19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797491Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695740}
-
Roger Tawa authored
When merging report context, make sure to handle the the new context as a dictionary and make sure to merge sub keys. Bug: 1002764 Change-Id: I5216de7ce5cbf45f08ce75bfe2b1a9290c59628c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797547Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#695739}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 7d12c3fa. With Chromium commits locally applied on WPT: cf88186a "[LayoutNG] Fix `vertical-align: top` and `bottom`" 30dde1e3 "[LayoutNG] Fix `vertical-align: top/bottom` with leading" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: meade@chromium.org: external/wpt/web-animations rego@igalia.com: external/wpt/css/css-grid NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I10878fecaf57a6de2d7775f6e2ed73454727b041 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798277Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695738}
-
manuk authored
Bookmark and history suggestions can be inline autocompleted and be the default match only when the user inputs a prefix of the URL. Document providers can't be autocompleted at all. E.g., if you’ve visited https://en.wikipedia.org/wiki/Space_Shuttle_Discovery, typing ‘space shuttle di’ won’t autocomplete the suggestion, though typing ‘en.wikipedia.org/wiki/space_Shuttle_Di’ will. This has multiple negatives: 1) It’s tedious and inaccurate to type URLs containing symbols and domains that the user isn’t concerned about. E.g. Typing “Bon Jovi” is more natural and shorter than “en.wikipedia.org/wiki/Bon%20Jovi”, which contains details such as ‘en.’, ‘%20’, and ‘wiki/’ that most users do not memorize. 2) Navigating the dropdown causes a delay, not only because it requires either more keystrokes or mouse input, but also because it requires scrolling past a variable length of search suggestions; i.e. it’s difficult to commit to muscle memory: type “jon bovi”, press down 3 times, press enter. 3) Users who expect their input is sufficient to reliably determine their intended navigation may prematurely press “enter” before realizing the default suggestion is incorrect. With this CL, when the input is a prefix of a bookmark, history, or doc title, then the omnibox autocompletes the `title - URL` and allows defaulting the suggestion. Bug: 549677 Change-Id: Ie17ce879f27e1128be2c0fc09a840da6dcde5637 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1711634 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#695737}
-
Evan Stade authored
ProfileManagerObserver::OnProfileAdded() can serve as the signal that the Profile is fully created. This patch also adjusts OwnerSettingsServiceChromeOSFactory to make it more obvious that off the record profiles (both guest and incognito) don't get a service instance. TBR=bartfab@chromium.org,rdevlin.cronin@chromium.org Bug: 268984 Change-Id: I2048d85828863cc9611b724c5b7c5c0b114089ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1794273Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#695736}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/cc6f585f055a..2ae039a065a6 git log cc6f585f055a..2ae039a065a6 --date=short --no-merges --format='%ad %ae %s' 2019-09-11 apolito@google.com Add support for multi argument ands and ors, and the same precedence with Created with: gclient setdep -r src/third_party/depot_tools@2ae039a065a6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:905740 Change-Id: I5aede2a51b480fd875402798a6e65d60ec54047d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797055Reviewed-by:
-
Albert J. Wong authored
As the splitting process for RenderWidget/RenderView continues, it is becoming necessary for RenderWidget to access "page global" state. RenderView has historically held this data. Adding a new PageProperties interface for "page" level concepts will provide the needed access without opening the door to full API coupling that historically occurred when RenderWidgets had full access to the RenderViewImpl interface. Bug: 998273 Change-Id: I2d532e0e88256b04b8c9e3f49607e0e59bc93113 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792795 Commit-Queue: Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Auto-Submit: Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#695734}
-
Eric Roman authored
Adjust the test expectation of ForceNetworkInProcessTest when run from network_service_in_process_browser_tests. Bug: 1002752 Change-Id: Ibeb63eb2044f8a565b29b7821add891d5a4fc339 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797337 Auto-Submit: Eric Roman <eroman@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#695733}
-
Peter Kasting authored
Bug: 618334 Change-Id: Ib6350c3238689eff8af6dc0bb707f61397a32b0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783116 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d9456b258e20..8ac49e182aa0 git log d9456b258e20..8ac49e182aa0 --date=short --no-merges --format='%ad %ae %s' 2019-09-11 timvp@google.com Fix dEQP renderbuffer unspecified attachment test. Created with: gclient setdep -r src/third_party/angle@8ac49e182aa0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@chromium.org Bug: None Change-Id: I4303d0ef18dee761343b876173dba92a22068135 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797178Reviewed-by:
-
Nathan Zabriskie authored
This CL forwards FrameTimingDetails to the CompositorFrameReporter within the Viz client. The timestamps contained in FrameTimingDetails will be used by CompositorFrameReporter in a future CL to measure and report on rendering pipeline stages within the GPU process. Bug: 963787, 971712 Change-Id: I062bf74885a42bca07d542f170615ed6654751d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789471Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Nathan Zabriskie <nazabris@microsoft.com> Cr-Commit-Position: refs/heads/master@{#695730}
-
Tommy Steimel authored
This CL adds destructors to the MediaNotificationController and MediaNotificationContainer interfaces. Bug: 1002746 Change-Id: Ic5d2f7725168bc504827565ac2fbfc9eb8351ee3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798499 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
-
Zhenyao Mo authored
BUG=1002988 TEST=bot R=kbr@chromium.org Change-Id: I3f940a19a067fe9a5aac9c7ca8aababb55b5c13f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798842Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#695728}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/c5f9c0682125..fc09aa89b962 git log c5f9c0682125..fc09aa89b962 --date=short --no-merges --format='%ad %ae %s' 2019-09-11 perezju@chromium.org [Telemetry] Uncaught exceptions should interrupt benchmark Created with: gclient setdep -r src/third_party/catapult@fc09aa89b962 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=oysteine@google.com Bug: chromium:973837 Change-Id: Ia6011a0ecb3d5abba06234fffce15b7ed9d8d9ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797176Reviewed-by:
-
Tommy Li authored
Includes an experiment ID that is hardcoded on the client side for testing purposes only. Bug: 991031 Change-Id: Ib854e3bf6a7571c4d855dc31609b9622f0161ed3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798882Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#695726}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /media/capture/video. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=emircan@chromium.org Bug: 891670 Change-Id: I0fef3a26ba2a58d22bc0e19edbebe90f3d1589e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787181 Auto-Submit: Gabriel Charette <gab@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#695725}
-
Luum Habtemariam authored
PluginVm will be sending PS to be printed, now the pipeline can handle both PS and PDF. Bug: chromium:945409 Test: manually confirmed printer PS doc Change-Id: Id3d3303f4673f65c4098495c83ea19a14f35736d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795993 Commit-Queue: Luum Habtemariam <luum@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#695724}
-
Martin Robinson authored
With the switch to cr-button from paper-button, the component no longer has support for aria-active-attribute. Instead we simply set the expanded value via an element attribute binding. Bug: 967793 Change-Id: I033c025aa25160ede9271cd5e8725e61630183f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798342Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Martin Robinson <mrobinson@igalia.com> Cr-Commit-Position: refs/heads/master@{#695723}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /components/network_time. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=zea@chromium.org Bug: 891670 Change-Id: I444ad4c122f248c1a1116752cc253d55da465708 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786743 Auto-Submit: Gabriel Charette <gab@chromium.org> Commit-Queue: Nicolas Zea <zea@chromium.org> Reviewed-by:
Nicolas Zea <zea@chromium.org> Cr-Commit-Position: refs/heads/master@{#695722}
-
Zhenyao Mo authored
BUG=771119 TEST=bot TBR=sky@chromium.org,kbr@chromium.org Change-Id: Ie94c3b8cae2359a934cabfdf34139e76471f9367 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798984Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#695721}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/120e7d6766e4..ba36ee78262a git log 120e7d6766e4..ba36ee78262a --date=short --no-merges --format='%ad %ae %s' 2019-09-11 benjaminwagner@google.com Update to XCode 10.3 Created with: gclient setdep -r src/third_party/skia@ba36ee78262a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=mtklein@google.com Bug: None Change-Id: I9461ca61c44f4d2df3f42ce022418070f5026115 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797053Reviewed-by:
-
Sadrul Habib Chowdhury authored
Report all the UMA metrics collected in rendering benchmark in cluster_telemetry's rendering benchmark too. BUG=984592 Change-Id: Ic7742eb736bbe353f7676d2e578cc0ee1dcfaa06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795628Reviewed-by:
Ravi Mistry <rmistry@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#695719}
-
Bin Wu authored
Change-Id: I06895589359a77bb771d3b8f8a857ee50398dbec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790488 Commit-Queue: Bin Wu <wub@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#695718}
-
Rakib M. Hasan authored
Bug: chromium:1002309 Change-Id: I63fe8dce194b4d96b6c026995d20f93a54b54fe8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795889Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#695717}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ff060eef97db..7e2441234b94 git log ff060eef97db..7e2441234b94 --date=short --no-merges --format='%ad %ae %s' 2019-09-11 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 95ebb2b7..58a2bab7 (695497:695605) Created with: gclient setdep -r src/third_party/webrtc@7e2441234b94 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: Iaa0d2108b3577516964529f26c0a13a7fbe5734c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797054Reviewed-by:
-
Amin Hassani authored
We are moving toward a more advanced GetStatus() DBus signal and we get the StatusResult object from update_engine.proto. But currently, the update_engine_client.cc has its own Status struct which in theory should always be synced to the Status object of the update_engine in Chrome OS. But there is no way of enforcing those and these two objects have been out of sync for a while. So with the introduction of StatusResult and the new GetStatusAdvanced() DBus method and StatusUpdateAdvanced() DBus signal, we can use this new protobuf object everywhere instead so there is no need to manually sync between the Chrome and Chrome OS. In addition Using GetStatusAdvanced(), we can easily extend its arguments so we don't get into problems like crbug.com/864672. Bug: 977320 Test: locally build a test image and clicked on "check for update button". Change-Id: I6c7f3b934df028d8f102d77ae4ba70e8c92ea4f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693945 Commit-Queue: Amin Hassani <ahassani@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#695715}
-
Matt Simmons authored
Bug: 985386 Change-Id: If3d52d42265219044cf3689b72c4253fc0ccfa00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797026Reviewed-by:
Cathy Li <chili@chromium.org> Commit-Queue: Matt Simmons <mattsimmons@chromium.org> Cr-Commit-Position: refs/heads/master@{#695714}
-
Justin Cohen authored
Bots rolled with the following script: git grep -l '11m392r' | xargs sed -i '' -e 's/11m392r/11a419c/g' CIPD packages: infra_internal/ios/xcode/mac 11a419c infra_internal/ios/xcode/ios 11a419c Bug: 1002734 Change-Id: Ia07b350603c4738bd1ba8a9750ec502c31271eea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797246 Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#695713}
-
Khushal authored
R=ericrk@chromium.org Bug: 997592 Change-Id: I800164a985a9fae6781aad6fcd0666a86fa3a8bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797363 Auto-Submit: Khushal <khushalsagar@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#695712}
-
Jan Wilken Dörrie authored
This change replaces usages of base::Value::GetList() followed by either emplace_back() or push_back() with base::Value::Append(). This is because of the upcoming change to GetList() to return a base::span instead, which does not support either emplace_back() or push_back(). This is a mostly mechanical change. Steps to reproduce: - sed -i 's/GetList().push_back/Append/g' - sed -i 's/GetList().emplace_back/Append/g' - git cl format - Manually fixing the breakage in base/json/json_writer_unittest.cc and tools/json_schema_compiler/util.cc TBR=afakhry,boliu,eugenebut,mmoroz,rdevlin.cronin,rockot@google.com,sandersd Bug: 646113 Change-Id: I2f13fd0efa7fe712f7659500404192be4a344e14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796427 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
-
Aaron Leventhal authored
Anything table-like should support the table interface. This includes the cross platform kTreeGrid role, which is mapped to ROLE_SYSTEM_OUTLINE on MSAA/IA2. Bug: 1002544 Change-Id: Ic97539e9462f7da5c089bbe4f067d56ca2e27dbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796262Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#695710}
-
Mohammad Refaat authored
This should fix the problem of cookies not clearing consistently on iOS 13. More details are on the crbug comments. Also Change onViewUpdated on web_frames_manager_impl to remove all messages instead of looking for specific messages. This is needed as removing specific messages DCHECKs if the message is not registered. and during the Purge which happens in clear browsing data the message router is destroyed so there will be no messages in the registered with the webview. TEST= I tested manually on ipad, iphone for both iOS 12 & 13 on devices , a test on the simulator is meaningless as the simulator doesn't use the same cookie storage that the device use. There exist unit tests but they will not fail in the case that i'm fixing because in these tests we set cookies manually and this current case happen when cookies are set by the web view. I'll discuss further creating EG tests to test the failed scenario using a browsing test page that can set/get cookies. Bug: 997172, 956516 Change-Id: I3befee1bf38ac1d3d86c33e50bbbbd4fb9e75ec9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791629 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#695709}
-
Mohammad Refaat authored
OverlayUIDidFinishPresentation is called from a weakptr, which can be nil and it's not checked. If the weakptr is nil the call is crash as it's called from a C++ object. Change-Id: Idf9a6a73aded75d411e92e35a97a07a2db04b8df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795890Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#695708}
-
Travis Skare authored
Whitespace-only change. Change-Id: I0d87dc3a1e11ec1b9f212298dad77934913c910c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797005 Commit-Queue: Ramya Nagarajan <ramyan@chromium.org> Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#695707}
-
Joshua LeVasseur authored
This supports writing unit tests. Merge-With: eureka-internal/311500 Bug: None Test: build Change-Id: I61d6bd28599f260091f5f9ad43575fe4214d28b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764393 Commit-Queue: Joshua LeVasseur <jlevasseur@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#695706}
-
Jonathan Backer authored
The common case for SkiaRenderer would be to draw to an opaque framebuffer. Tweak the microbenchmark config to match that. Bug: 974359 Change-Id: I95ff319148b3a1e1159aba49974f55fb2a073b47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797701 Commit-Queue: Jonathan Backer <backer@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Auto-Submit: Jonathan Backer <backer@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#695705}
-
