- 28 Jan, 2020 40 commits
-
-
Steve Becker authored
Exposes setExperimentalAppBadge() and clearExperimentalAppBadge() on the navigator for service workers. When a service worker uses the badging API, the badge update affects all web apps within the scope of the service worker's registration. Future changes can expose the badging API to dedicated workers and shared workers. The WICG draft spec (https://wicg.github.io/badging/) states that dedicated workers and shared workers may set a badge when they are a service worker client. To expose badging on WorkerNavigator, this change updates the existing badging code under /blink/renderer/modules/badging/. The change adds a new IDL file, worker_navigator_badge.idl. The new IDL defines a partial WorkerNavigator interface to add the set and clear badging functions. The change updates the existing NavigatorBadge class to include the new WorkerNavigator IDL bindings, which are identical to the existing Navigator IDL bindings except they pass a WorkerNavigator& parameter instead of Navigator&. The change moves the core implementation from the existing Navigator IDL bindings into SetAppBadgeHelper() and ClearAppBadgeHelper(). These helpers enable both the Navigator IDL bindings and the WorkerNavigator IDL bindings to use the same implementation. The next part of the change registers a blink::mojom::BadgeService binder in the ServiceWorkerGlobalScope's browser interface binders. The ServiceWorkerGlobalScope needs this registration to connect the NavigatorBadge class to the badging::BadgeManager class in chrome/browser. Without this registration, the JavaScript badging APIs do not trigger any badge updates for service workers. For the Window, the binder registration occurs through ContentBrowserClient::RegisterBrowserInterfaceBindersForFrame(). Unfortunately, RegisterBrowserInterfaceBindersForServiceWorker() does not exist. Additionally, the Window binder registration provides the RenderFrameHost as context when creating a new mojo binding. The BadgeManager uses the RenderFrameHost as a binding context to find the URL to use when setting a badge. ServiceWorkerProviderHost is like RenderFrameHost, but for service workers. ServiceWorkerProviderHost can provide the service worker registration scope URL to use when setting a badge. Unfortunately, ServiceWorkerProviderHost is not publicly exposed to chrome/browser. This makes creating a RegisterBrowserInterfaceBindersForServiceWorker() problematic since the service worker cannot provide the same amount of context as the Window/Frame. Instead of using something like ContentBrowserClient::RegisterBrowserInterfaceBindersForFrame(), this change registers the badging binder in the content layer in browser_interface_binder.cc. Keeping the binder in the content layer allows it to use the ServiceWorkerProviderHost to get the context it needs and then pass that context to the BadgeManager in chrome/browser. The change adds the ContentBrowserClient::BindBadgeServiceReceiverFromServiceWorker(), which allows the content badging binder to pass the service worker's Render Process Host and its scope URL to the BadgeManager, which the BadgeManager uses as the binding context. The change updates the BadgeManager class to work with both service workers and documents. There are two differences between service worker and document badge updates: 1) A service worker badge update may affect multiple apps. A document badge update may affect up to one app. 2) Service workers and documents provide different mojo binding contexts. Service workers provide a RenderProcessHost and a scope URL. Documents provide a RenderFrameHost and a frame ID. To deal with these differences, this change updates the pre-existing BadgeManager::BindingContext struct to be an abstract interface base class. The class has one method to override: GetAppIdsForBadging(), which returns the list of AppIDs to update after a badge change. The change adds two derived classes FrameBindingContext and ServiceWorkerBindingContext. Each class handles the differences described above. For testing, this change updates WebAppBadgingBrowserTest to include service worker test cases. The change added new test data to chrome/test/data/web_app_badging/ to facilitate service worker testing. The new browser tests use the main frame to post a message to the service worker. Depending on the message content, the service worker responds by either calling setExperimentalAppBadge() or clearExperimentalAppBadge(). The change also generalizes WebAppBadgingBrowserTest to handle when a service worker badge change affects multiple apps. Before this change, WebAppBadgingBrowserTest expected exactly 1 badge update. After this change, the test can expect multiple badge changes with at most 1 badge change per app. The change also updates the badging origin trial API web_tests to include service workers. I attempted to update the existing badging web_tests to include workers, but since these tests run as file://, all workers failed to run due to null origin errors. I was also unsuccessful moving these tests to run as https:// since the https:// server did not have the required resources to mock mojo. Bug: 1036202 Change-Id: I66b2bf66b787965d6aa4ac35b663e522ffc4bd67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2009376 Commit-Queue: Steve Becker <stevebe@microsoft.com> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Jay Harris <harrisjay@chromium.org> Cr-Commit-Position: refs/heads/master@{#735705}
-
David Bokan authored
This reverts commit b746c948. Reason for revert: Still failing on Mac web tests: https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests%20%28dbg%29/16983 Original change's description: > [Reland#2] Make programmatic scrolls respect smooth scroll flag > > Programmatic smooth scrolls should also be instant if the smooth scroll > flag is explicitly disabled. > > Previously landed in https://crrev.com/c/1536759 and in > https://crrev.com/c/2009842 > > To reland, this CL force enables the scroll animator in Blink web > tests. Without this, the usual flow for determining if the animator is > enabled is followed, which leads to inconsistencies. On Mac, the > animator is enabled in Chrome but not in content shell. This leads to > inconsistencies with other platforms (Mac tests ran without smooth > scroll while Linux/Windows ran with) and ensuring we test what we ship. > > This change required some minor fixes to tests that assumed instant > scroll on Mac (and uncovered one real bug). > > Second reland fixes a few more tests on Mac. See diff from original > patchset for changes. > > TBR=flackr@chromium.org,nasko@chromium.org > > Bug: 944583 > Change-Id: Ib91c417f1fcc2b27601f2c7039b02da72b9d5420 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022356 > Reviewed-by: David Bokan <bokan@chromium.org> > Commit-Queue: David Bokan <bokan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#735480} TBR=flackr@chromium.org,nasko@chromium.org,bokan@chromium.org Change-Id: Ifad1c0b6a19f222391c2361e80c699d27da7576b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 944583 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024412Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#735704}
-
Mario Sanchez Prada authored
Add a new method to blink::mojom::LocalFrameHost interface, to be implemented right from RFHI, which will allow us to remove the WebLocalFrameClient::DidChangeLoadProgress() API plus the related bits under //content/renderer. Bug: 1008432, 1041076 Change-Id: Ic5e19292b8c8cce75b519fb516e311fb8d029f9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003309Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#735703}
-
Demetrios Papadopoulos authored
This is in preparation of migrating to Polymer 3. Bug: 1026426 Change-Id: Ia950fecef1b3a13af65d5e1505d2cd37d1e1b5cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024150Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#735702}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f437869d4107..ca7b3bf33052 git log f437869d4107..ca7b3bf33052 --date=short --first-parent --format='%ad %ae %s' 2020-01-27 ukai@google.com roll out new goma client binary (VERSION=188) Created with: gclient setdep -r src/third_party/depot_tools@ca7b3bf33052 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Ib658d3675bf89294b653a574320adc45bca50f65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024126Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735701}
-
John Budorick authored
Bug: 1037892, 1046174 No-Try: true Change-Id: I427a0cd77e79c5cda66e92c931697eb16b28a511 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024160 Auto-Submit: John Budorick <jbudorick@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#735700}
-
Kent Tamura authored
After crrev.com/735492, LayoutTextControlInnerContainer is unnecessary. TextControlInnerContainer exists only to apply LayoutTextControlInnerContainer, so we can remove TextControlInnerContainer too. This CL should have no behavior changes. Bug: 1040828 Change-Id: I091de82bc35f9c0e481edd06cf348205558aa378 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024127Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#735699}
-
Xinghui Lu authored
Bug: 1036042 Change-Id: I1db72655a60ac12b3d88f3c41ccc80cb0725a3c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015661 Auto-Submit: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#735698}
-
Mohsen Izadi authored
A bool is set in CompositorFrameReporter indicating whether the frame was missed or not. Then it is converted to a MissedFrameReportType enum and passed around. First, we can use the enum from the beginning to keep frame miss status. We also don't need to pass it around inside CompositorFrameReporter as everywhere that needs it can query the member variable. The 's' was also removed from the end of the enum name to make it more consistent with the rest of the code base. The unnecessary, deprecated value kDeprecatedMissedFrameLatencyIncrease is also removed. Bug: None Change-Id: Ic65e872aa260c5b6cfbbef030c26ea7203ae6f27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020511Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#735697}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/17a6381c1c98..11b66cf1103c git log 17a6381c1c98..11b66cf1103c --date=short --first-parent --format='%ad %ae %s' 2020-01-27 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 5a8e8ca5..01683979 (735421:735581) Created with: gclient setdep -r src/third_party/webrtc@11b66cf1103c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib8350634d693f4381e1af292a25d37b4e59ddc70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024273Reviewed-by:
-
Tsuyoshi Horo authored
Bug: 1043145 Change-Id: I0b66bb21fbcc8216289445e3826f746c4df22805 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2009597 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#735695}
-
rbpotter authored
- Add rules to autogenerate Polymer3 versions of cr_policy_pref_behavior and cr_policy_pref_indicator at build time - Autogenerate tests for the Polymer 3 version of cr_policy_pref_indicator. This will be used to migrate the chrome://settings page in future. Bug: 1042558 Change-Id: I4721c7c4ae9d898135fea09111dcc6c79b529888 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021335Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#735694}
-
Jamie Walch authored
When pointer lock is active on the client, the host composites the mouse cursor into the desktop image. When pointer lock is deactivated, it sets a blank cursor to disable compositing, but this resulted in no compositing after pointer lock was reactivated until the cursor shape changed. This CL inserts ClientSession between the MouseShapePump and the DesktopAndCursorComposer, allowing cursor shape changes that occur while pointer lock is inactive to be saved so that compositing can resume when pointer lock is reactived. Bug: 1043325 Change-Id: I70edc0ae3d1a45595fe5a7d9298c4f02b921d696 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023519 Auto-Submit: Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#735693}
-
Johannes Henkel authored
This channel transcodes to JSON if needed, and inserts session ids into DevTools messages if needed. This makes it easier for embedders to implement sessions, and also makes it easier to perform session id surgery in Blink, as a follow up to https://chromium-review.googlesource.com/c/chromium/src/+/1783717 Change-Id: I776180f983448c93be2174679f3592b16df150da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994277 Commit-Queue: Johannes Henkel <johannes@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#735692}
-
Daniel Rubery authored
This CL updates a few strings to clarify that "scanning" involves sending data to Google. It also fixes a regression where I removed the code to generate PROMPT_FOR_SCANNING verdicts in https://chromium-review.googlesource.com/c/chromium/src/+/2007972 New screenshot: https://screenshot.googleplex.com/826Qkjdd6ee.png Bug: 1020418 Change-Id: I5fd0a705a87df8781d1e360724e5339701e7b0cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024147 Commit-Queue: Daniel Rubery <drubery@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Auto-Submit: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#735691}
-
Carlos IL authored
With Committed interstitials, ERR_BLOCKED_BY_CLIENT is used instead of ERR_ABORTED when cancelling a safe browsing flagged navigation. This causes an issue when an interstitial is not shown, triggering a net error page. This changes the code back to ERR_ABORTED when no interstitial is shown. The plumbing to the URLLoaderThrottles was also setting showed_interstitial to true in some cases where it should be false. This CL also fixes that. Bug: 1022477, 1045549 Test: This fixes a CTS test that was broken with committed interstitials (android.webkit.cts.WebViewClientTest#testOnSafeBrowsingHit) Change-Id: I8f10bea767749919e4a5ef6b460c9b96d6cbb75f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008310 Commit-Queue: Carlos IL <carlosil@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Reviewed-by:
Tao Bai <michaelbai@chromium.org> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#735690}
-
Hirokazu Honda authored
crrev.com/c/1967217 drops the performance in VP9 720P ARC++ test, approximately from 110fps to 90fps. Bug: b:146842665, b:147642583 Test: android.media.cts.VideoDecoderPerfTest#testVp9Other0Perf1280x0720 on coral Change-Id: Ie1911c60a0f79c703a84d025823424cebdbd3723 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022563Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#735689}
-
Ted Choc authored
The previous implementation provided ChromeActivity without specifying the generic type. By not specifying the generic type (even if that is ?), Java removes the generic type information from all methods inside of the class even if they're unrelated to the type template being left off. If you have: class Foo<T> { public List<Bar> bar() {} } If you are passed a vanilla Foo: Foo foo = new Foo(); Then bar() above will have the return type of List<Object> as it will have lost the <Bar> template. e.g.: List<Bar> bar = foo.bar(); <- This will not work. Thus, you should always pass the generic type information or <?> if the top level generic type does not matter to the code handling the object. BUG= Change-Id: Ie2770e1020f4150f19cca988168a317139be4f0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024269Reviewed-by:Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#735688}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/09dbeace089e..2def28bf1003 git log 09dbeace089e..2def28bf1003 --date=short --first-parent --format='%ad %ae %s' 2020-01-27 tsepez@chromium.org Re-enable test for bug 1265 under all cases. 2020-01-27 thestig@chromium.org Use str.IsEmpty() instead of str.GetLength() == 0. 2020-01-27 thestig@chromium.org Move CPDF_ProgressiveRenderer::ToFPDFStatus() to fpdfsdk/. 2020-01-27 tsepez@chromium.org Cover CJX_DataWindow properties and methods. 2020-01-27 dhoss@chromium.org Rename Mid() to Substr() in {Byte,Wide}String{,View} classes 2020-01-24 tsepez@chromium.org Rename CFWL_Widget::{Get,Set}FFWidget() to {Get,Set}AdapterIface(). 2020-01-24 tsepez@chromium.org Encapsulate SystemFontInfoIface operations behind CFX_FontMapper. Created with: gclient setdep -r src/third_party/pdfium@2def28bf1003 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I61d8f75fff8f8f4716dafbf61631f2a39bc40a0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024115Reviewed-by:
-
Michael Crouse authored
Change-Id: I80ea401676b6cf3ca2fbb579eb663ad676f65b3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019478 Auto-Submit: Michael Crouse <mcrouse@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#735686}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/fc419895da6e..b7a76b287ab0 git log fc419895da6e..b7a76b287ab0 --date=short --first-parent --format='%ad %ae %s' 2020-01-27 mandy.chen@microsoft.com Update frontend to process installabilityErrors Created with: gclient setdep -r src/third_party/devtools-frontend/src@b7a76b287ab0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:946860 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I2cd1ec6f76104ed64d72691445b100257cf93945 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024117Reviewed-by:
-
Akihiro Ota authored
Makes AutomationAXTreeWrapper a subclass of AXTreeManager. This is change lays foundation for AXNodePosition support in automation. Change-Id: Id5c5eaa0e0829dab599b6f7045f649974334faa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018094 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#735684}
-
Josh Nohle authored
These metrics track - DeviceSync v2 invocation reasons, - DeviceSync v2 results, - async ClientAppMetadata fetch success rates, - async ClientAppMetadata fetch execution times for tuning timeout. Bug: 951969, 933656, 936273 Change-Id: I1cf1e1fb2ab2fd4c07ee740783daecb2611ac86f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776217 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
-
Lukasz Anforowicz authored
This CL adds a regression test that ensures that document.write into a new popup can be used to embed a PDF document. Bug: 1041880 Change-Id: I1ec8087dff5f0bc1c4ccc39869949e2496c81df9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019475 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#735682}
-
arthursonzogni authored
There are no more used since: https://chromium-review.googlesource.com/c/chromium/src/+/2000640 Only: content/common/content_security_policy/csp_context.h needs to stay. It contains the definition of CSPViolationParams, which is still a native struct (for now). See UnifyCSP: https://docs.google.com/document/d/1v5mJnXJ5dSVXE_rgvJnNM9bzH0ni0YzdhPQ7GLqyhao Bug: 1021462 Change-Id: I7227fd6b9a75ac24b5e7c60c93c2f0c48dfa6464 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022673 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#735681}
-
Joshua Berenhaus authored
In this change, we are continuing the work from CL 1992009 and setting up the ability for UKM Service to call into the ClonedInstallDetector to understand its state on construction and if it should reset the UKM client id. Bug: 981407 Change-Id: I5a330807bb938e2f2fe6f6e9fe5e8edb5b02432e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018242 Commit-Queue: Joshua Berenhaus <joshber@microsoft.com> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Joshua Berenhaus <joshber@microsoft.com> Cr-Commit-Position: refs/heads/master@{#735680}
-
Josh Nohle authored
Update the multi-device setup service function SetHostDevice() and related functions to accept either a device's Instance ID or legacy RemoteDevice ID. The former is only present for devices using v2 DeviceSync and the latter is the encoded public key--given by RemoteDevice::GetDeviceId(). The legacy device ID will not be available from the v2 DeviceSync service until device metadata can be decrypted. This delay could prevent multi-device setup, especially during OOBE, unless SetHostDevice() also supports use of the Instance ID. By design, the Chrome OS CryptAuth client code guarantees that while v1 DeviceSync is running--whether in parallel with v2 DeviceSync or alone-- every device will always have an unencrypted legacy device ID, though some may not have an Instance ID. When v1 DeviceSync is turned off, however, only an Instance ID is guaranteed, and this CL is necessary. This CL is meant to be temporary. When v1 DeviceSync is turned off and no rollback is expected, the changes in this CL should be revised to only use Instance IDs since those are always guaranteed to exist in v2 DeviceSync. Variable name changes from |host_device_id| to the elegant |host_instance_id_or_legacy_device_id| comprise the bulk of this CL. The crucial logic changes are in start_setup_page.html/js and multidevice_setup_impl.cc. Bug: 951969, 1019206 Change-Id: I99c3b79cbb8414da65ee7b95dab80f661f15b13b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000972Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#735679}
-
Peng Huang authored
Bug: 1015156 Change-Id: Iac379910bc94f003f5911134309c99d92b58cffe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023364Reviewed-by:
Saman Sami <samans@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#735678}
-
Ken Buchanan authored
The Chrome WebAuthn team has decided not to ship support for BLE authenticators in Web Authentication due to reliability issues. This CL removes the flag that allows it to be enabled. BLE authenticators can still be used with Chrome running on versions of Windows 10 that support the Hello API since that does not depend on this flag or Chrome's implementation. BUG=1046131 Change-Id: I2992fec02b95677d84a0b4fc65a5432a325e6c23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023671 Commit-Queue: Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#735677}
-
Jun Mukai authored
This changes the behavior of autotestPrivate.setTabletModeEnabled; it will ensure entering into the specified mode, and will not end and will not be affected by peripherals. As is described in the bug, it is crucial to ensure into a certain mode for conducting an integration test or a performance test, but sometimes the test scenarios or existence of peripherals can affect the intermediate states, which may cause failures when combined with multiple tests. This CL simplifies this situation by adding a new method to ash::TabletMode. Note that we can't change the behavior of existing SetEnabledForTest, because it is widely used by unittests and browsertests. Bug: 1040292 Test: tast run ui.ScreenRotationPerf ui.WindowResizePerf on scarlet Change-Id: I343e2b86c145bae789629df1baaf503fa2dfdef5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016193Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#735676}
-
Ben Joyce authored
Bug: 1021634 Change-Id: I790546c8a78c25cb20a312d50c0c9f45797534cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018255 Commit-Queue: benjamin joyce <bjoyce@google.com> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#735675}
-
Jin Chen authored
* Fuchsia uses a different crash report system (crashpad), so remove crash_reporter_client dependencies on fuchsia builds. R=afelch@google.com, kmackay@chromium.org Change-Id: I823148bf97d3b930d7ad984e071effc9c61affc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024035Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: JinJie Chen <jinjiechen@google.com> Cr-Commit-Position: refs/heads/master@{#735674}
-
Henrique Nakashima authored
Now, dynamic SharedPrefs keys can also be grandfathered, so they don't need to be exhaustively listed anymore. Bug: 1022108 Change-Id: I8432ac41aed64b0e1f6dbee8ed556d32fe66a862 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011284 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#735673}
-
Fabrice de Gans-Riberi authored
This is a preliminary change to share the implementation across multiple Chromium content embedders. Bug: 1042501 Change-Id: I398c0810de589529a0037875a30ad33c2f65aa50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013725 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#735672}
-
Robert Ogden authored
This URL Loader streams the response from memory. It isn't wired up to anything, so it isn't testable yet but is meaty enough to be its own CL. This is based on Offline Page's URL Loader. Bug: 1023483 Change-Id: I04ca25488942f9e901c157f9af4cc921fa7fa3a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018065 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
-
tby authored
In crrev.com/c/1911065 we introduced a ground-truth metric for zero state files appearing in the UI, that was useful but costly to compute. We should take this out before M80 rolls out to stable. This CL deletes the function that computes the metric, to make the change we need to merge back into the M80 branch as small as possible. The rest of the infrastructure for the metric will be deleted in a follow-up CL. Bug: 1011221 Change-Id: I88a610a30347ade7d1a7fdfe3db341adb629b076 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016813Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#735670}
-
Ahmed Mehfooz authored
Need to make sure we add it as observer after fully initializing notification_icons_container_ Change-Id: Icd511f3dfdaac653899ddd9a09f64c62bd459ab4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023853Reviewed-by:
Tim Song <tengs@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#735669}
-
Joe Downing authored
TBR: sullivan@chromium.org Bug: 1041709 Change-Id: Ie993df88a7ab5261659b9f1e04236cbb24df5a61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024121Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#735668}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a1f1cce6054f..2d1d9d35216b git log a1f1cce6054f..2d1d9d35216b --date=short --first-parent --format='%ad %ae %s' 2020-01-27 syoussefi@chromium.org Fix atomicAdd validation w.r.t to swizzles 2020-01-27 jonahr@google.com Expose eglGetMscRateCHROMIUM from EGL_CHROMIUM_sync_control Created with: gclient setdep -r src/third_party/angle@2d1d9d35216b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1042393 Tbr: tobine@google.com Change-Id: I12a7b40a4b2b317c04e9d3539ff359bc8244ff60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023222Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3c0615232489..fbc74b472299 Created with: gclient setdep -r src-internal@fbc74b472299 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1040871,chromium:1045888,chromium:927262 Tbr: jbudorick@google.com Change-Id: I8f03bbe21761094b1942261b079643a6a6d88151 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023235Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735666}
-
