- 22 Oct, 2018 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/20a8c2a7ccc6..ff08d94ee125 Created with: gclient setdep -r src-internal@ff08d94ee125 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ide3b2c8cd6b9f7e28bc94c3c5a2b46e7f443500c Reviewed-on: https://chromium-review.googlesource.com/c/1293241Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601518}
-
Yves Gerey authored
We were relying on brittle transitive #include. Bug: webrtc:8311 Change-Id: I1749d9159c4fbff6658f19fefa84f46b0acabf5c Reviewed-on: https://chromium-review.googlesource.com/c/1290935 Commit-Queue: Yves Gerey <yvesg@google.com> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#601517}
-
Mario Sanchez Prada authored
This will remove a dependency from OAuth2TokenService::Consumer, that will pave the way for further migrations to the IdentityManager. Bug: 809440 Change-Id: I81d77da696078cdc48eee63c466a815fd68062c5 Reviewed-on: https://chromium-review.googlesource.com/c/1288535Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#601516}
-
Nikita Podguzov authored
This is a reland of 43116fdd Original change's description: > Disable editing managed network config fields. > > * Disable network configuration field if the field is enforced by policy. > * Add policy network indicator if the field is controlled by policy. > > Bug: 877424 > Change-Id: Icfdb6d7fb3deb09696b6d2edce27d3c9851043a2 > Reviewed-on: https://chromium-review.googlesource.com/c/1251447 > Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Alexander Hendrich <hendrich@chromium.org> > Cr-Commit-Position: refs/heads/master@{#600735} Bug: 877424 Change-Id: I48473017b8656504de789f2cad9d0fabd89fcec7 Reviewed-on: https://chromium-review.googlesource.com/c/1290914Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com> Cr-Commit-Position: refs/heads/master@{#601515}
-
Florian Uunk authored
We have this check in ModelAssociationManager::Stop, so it makes sense to add it to ModelAssociationManager::StopDatatype too. Bug: 894852 Change-Id: If5f472ea74cba7bbe60f796b1255c8e54d65a069 Reviewed-on: https://chromium-review.googlesource.com/c/1290149 Commit-Queue: Florian Uunk <feuunk@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#601514}
-
Peter E Conn authored
Bug: 888945 Change-Id: I2c2c803bbd51014cc70933fde8cef45e14ddb28b Reviewed-on: https://chromium-review.googlesource.com/c/1290915 Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#601513}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b026043a43f9..b20529ac11a6 git log b026043a43f9..b20529ac11a6 --date=short --no-merges --format='%ad %ae %s' 2018-10-22 perezju@chromium.org [soundwave] Fix encoding when building RequestError message 2018-10-22 perezju@chromium.org [pinpoint_cli] Fix bug when iterating over output isolates Created with: gclient setdep -r src/third_party/catapult@b20529ac11a6 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:897178,chromium:897052 TBR=sullivan@chromium.org Change-Id: I5ca0605b6d78dc87a31ef59c2d0257bf9bffe390 Reviewed-on: https://chromium-review.googlesource.com/c/1293242Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601512}
-
Zhuoyu Qian authored
https://google.github.io/styleguide/cppguide.html#Namespace_Names > Namespace names are all lower-case. This CL has no behavior changes. Bug: 889726 Change-Id: I63e4fd34b8bde448da84a6b2f578dc00a69cf33a Reviewed-on: https://chromium-review.googlesource.com/c/1293067Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Cr-Commit-Position: refs/heads/master@{#601511}
-
Kent Tamura authored
Focus navigation: Fix a null pointer dereference on disconnecting children including a focused shadow element crrev.com/599575 fixed a case where a single host including a focused shadow element is disconnected, but it didn't cover a case where multiple children including a focused shadow element is disconnected. Document::NodeChildrenWillBeRemoved() should handle sequential focus navigation starting point like Document::NodeWillBeRemoved(). Bug: 897403 Change-Id: I15c491ef9b789f1447be752f0ed41f4c7a8702a9 Reviewed-on: https://chromium-review.googlesource.com/c/1292664Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#601510}
-
Ramin Halavati authored
Traffic annotation auditor binaries for Linux and Windows are updates after the change crrev.com/c/1287097. Bug: 878760 Change-Id: I92e7f632cc9343fee93e16f0d6b48f099189d6da TBR: nicolaso@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1292877 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#601509}
-
Anders Hartvoll Ruud authored
This is prerequisite for a subsequent CL. R=futhark@chromium.org Bug: 641877 Change-Id: Ifc8c1df0f80f9c18205b103e13ae90b5e2c63b2e Reviewed-on: https://chromium-review.googlesource.com/c/1290980Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#601508}
-
Kent Tamura authored
https://google.github.io/styleguide/cppguide.html#Namespace_Names > Namespace names are all lower-case. Also, remove |using namespace XMLNames|. https://google.github.io/styleguide/cppguide.html#Namespaces > Do not use using-directives (e.g. using namespace foo). Also, remove unnecessary namespacePrefix definition of xml_attribute_names.json5. Bug: 889726 Change-Id: I5d3de504ad425af4a8ec096f84bc0be6c432aea4 Reviewed-on: https://chromium-review.googlesource.com/c/1293253Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#601507}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d206a4b9..b248a7f6 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib05b0d61ade904fbbd6a4c3eb7ca1cb880f0b21f Reviewed-on: https://chromium-review.googlesource.com/c/1293188Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601506}
-
Michael Lippautz authored
Use GC without scanning stack for testing purposes when necessary. A different strategy for the current architecture would be making tests truly async and scheduling GC from the event loop. Bug: 843903 Change-Id: Ib479d4a090bc04cbc4fe28522f0b9e084f34181d Reviewed-on: https://chromium-review.googlesource.com/c/1292878Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#601505}
-
Zhuoyu Qian authored
https://google.github.io/styleguide/cppguide.html#Namespace_Names > Namespace names are all lower-case. This CL has no behavior changes. Bug: 889726 Change-Id: I150167dadb44bac77af2145f9a87ffa9d0e769c2 Reviewed-on: https://chromium-review.googlesource.com/c/1293291Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium dfc636b6. With Chromium commits locally applied on WPT: f79c6fe7 "Reimplementing getDatabaseNames() as databases() for indexeddb." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/26523 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: mstensho@chromium.org: external/wpt/css/css-multicol NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I02e62904f21d388797ba42a874e08859c43205a6 Reviewed-on: https://chromium-review.googlesource.com/c/1293186 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#601503}
-
Amos Lim authored
Generated header files need to follow chromium style on header guards. This CL has no behavior changes. Bug: 896720 Change-Id: I5ed457086e369fd515f5969daebfc8e1ef623112 Reviewed-on: https://chromium-review.googlesource.com/c/1293059Reviewed-by:
-
Hirokazu Honda authored
Reland "media/gpu/VEA unittest: Fill plane pointer and stride with NULL and 0 for 1- or 2- planes VideoFrame" When I enable VEA unittest to run any yuv format in crrev.com/c/1135106, I didn't realize the code assumed the I420 when creating frame. Therefore, it passes invalid pointer and wrong stride when the number of planes are less than 3. This change fixes it by creating video frame, taking into account the number of planes of input buffer format. BUG=chromium:894381 TEST=VEA unittest for NV12 and I420 on kevin Change-Id: Ie917d5240c05cb32c59f21367252682dc14b573e Reviewed-on: https://chromium-review.googlesource.com/c/1293066Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#601501}
-
Fergal Daly authored
This reverts commit 9e324215. Reason for revert: Breaks Jumbo build https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-jumbo-rel/8154 Original change's description: > Rename RootScrollerUtil namepsace to root_scroller_util > > https://google.github.io/styleguide/cppguide.html#Namespace_Names > > Namespace names are all lower-case. > > This CL has no behavior changes. > > Bug: 889726 > Change-Id: I72347625710f8856e5e742fb4faf5e4ec1291d3e > Reviewed-on: https://chromium-review.googlesource.com/c/1293063 > Reviewed-by: Kent Tamura <tkent@chromium.org> > Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> > Cr-Commit-Position: refs/heads/master@{#601493} TBR=tkent@chromium.org,zhuoyu.qian@samsung.com Change-Id: Ifae2126f4e28f2546b6887a41726dd3b00089b8d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 889726 Reviewed-on: https://chromium-review.googlesource.com/c/1293103Reviewed-by:
Fergal Daly <fergal@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#601500}
-
Marc Treib authored
...by *2 histograms. The old histograms had very weird semantics for when samples were taken. The basic idea was to record only when the state *changed*, which means that for users that just keep using Sync without changing settings, we'd never record anything at all. There were also additional oddities around recording, see bug. Taken together, this makes the old histograms very hard to interpret. The new histograms are recorded when Sync configures the data types, which usually means during Sync startup. These will actually let us answer questions like "how many users have selected custom data types". Bug: 895488 Change-Id: Ie67ddebd562c7007b576dcfc962a3bc058bb9452 Reviewed-on: https://chromium-review.googlesource.com/c/1286812Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#601499}
-
Jochen Eisinger authored
Also unlock any left-over parent profiles now that (legacy) supervised user profiles don't exist anymore. R=msarda@chromium.org Change-Id: I19231e38e9b086c77cb250d14366d6acfa481509 Reviewed-on: https://chromium-review.googlesource.com/c/1292872Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#601498}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/06413e47c96e..20a8c2a7ccc6 Created with: gclient setdep -r src-internal@20a8c2a7ccc6 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ie04bf3d2d1d5dc6b53f335a7296f74bbc53462c7 Reviewed-on: https://chromium-review.googlesource.com/c/1293238Reviewed-by:
-
Zhuoyu Qian authored
https://google.github.io/styleguide/cppguide.html#Namespace_Names > Namespace names are all lower-case. This CL has no behavior changes. Bug: 889726 Change-Id: Ib4d4b483a224bb02217237d85220c3375238955a Reviewed-on: https://chromium-review.googlesource.com/c/1293295 Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Reviewed-by:
-
Zhuoyu Qian authored
https://google.github.io/styleguide/cppguide.html#Namespace_Names > Namespace names are all lower-case. This CL has no behavior changes. Bug: 889726 Change-Id: Ie8abf5434c3501a4b94b99af00cc909a0afac1a2 Reviewed-on: https://chromium-review.googlesource.com/c/1292668Reviewed-by:
-
Zhuoyu Qian authored
https://google.github.io/styleguide/cppguide.html#Namespace_Names > Namespace names are all lower-case. This CL has no behavior changes. Bug: 889726 Change-Id: If8167502426867a143dc15200809b21b08dfb520 Reviewed-on: https://chromium-review.googlesource.com/c/1293293Reviewed-by:
-
Zhuoyu Qian authored
https://google.github.io/styleguide/cppguide.html#Namespace_Names > Namespace names are all lower-case. This CL has no behavior changes. Bug: 889726 Change-Id: I72347625710f8856e5e742fb4faf5e4ec1291d3e Reviewed-on: https://chromium-review.googlesource.com/c/1293063Reviewed-by:
-
Heng-Ruey Hsu authored
Since blob stream needs higher resolution, it causes higher cpu loading to require higher resolution and resize to smaller resolution. In hangout app, we don't need blob stream. Enabling blob stream when needed can save a lot of cpu usage. BUG=b:114676133 TEST=manually test in apprtc and CCA. make sure picture taking still works in CCA. Change-Id: I9144461bc76627903d0b3b359ce9cf962ff3628c Reviewed-on: https://chromium-review.googlesource.com/c/1261242 Commit-Queue: Heng-ruey Hsu <henryhsu@chromium.org> Reviewed-by:
Ricky Liang <jcliang@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#601492}
-
Fergal Daly authored
Revert "media/gpu/VEA unittest: Fill plane pointer and stride with NULL and 0 for 1- or 2- planes VideoFrame" This reverts commit 04f8f2c0. Reason for revert: breaks windowd compile Original change's description: > media/gpu/VEA unittest: Fill plane pointer and stride with NULL and 0 for 1- or 2- planes VideoFrame > > When I enable VEA unittest to run any yuv format in crrev.com/c/1135106, I didn't > realize the code assumed the I420 when creating frame. Therefore, it passes > invalid pointer and wrong stride when the number of planes are less than 3. > This change fixes it by creating video frame, taking into account the number of > planes of input buffer format. > > BUG=chromium:894381 > TEST=VEA unittest for NV12 and I420 on kevin > > Change-Id: I31e157ce9317139e7cc42a38ba77b34c13d70d70 > Reviewed-on: https://chromium-review.googlesource.com/c/1293095 > Commit-Queue: Hirokazu Honda <hiroh@chromium.org> > Reviewed-by: Alexandre Courbot <acourbot@chromium.org> > Cr-Commit-Position: refs/heads/master@{#601489} TBR=hiroh@chromium.org,acourbot@chromium.org Change-Id: I02e53782dd3240da1dfd4548daefe275854601b4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:894381 Reviewed-on: https://chromium-review.googlesource.com/c/1293099Reviewed-by:
-
Kent Tamura authored
This CL makes it blink::foo_names::kNamespaceURI. The new behavior is applied only to lower-cased blink::foo_names. Bug: 889726 Change-Id: Ib1b0e55a7e135941b87055f0fd4e75956568c59a Reviewed-on: https://chromium-review.googlesource.com/c/1293061 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Hirokazu Honda authored
media/gpu/VEA unittest: Fill plane pointer and stride with NULL and 0 for 1- or 2- planes VideoFrame When I enable VEA unittest to run any yuv format in crrev.com/c/1135106, I didn't realize the code assumed the I420 when creating frame. Therefore, it passes invalid pointer and wrong stride when the number of planes are less than 3. This change fixes it by creating video frame, taking into account the number of planes of input buffer format. BUG=chromium:894381 TEST=VEA unittest for NV12 and I420 on kevin Change-Id: I31e157ce9317139e7cc42a38ba77b34c13d70d70 Reviewed-on: https://chromium-review.googlesource.com/c/1293095 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
-
Dong-hee Na authored
SerializeForNumberType() should be used instead of AtomicString::Number() in Element::SetFloatingPointAttribute(). Bug: 894661 Change-Id: I6d4efd2d14fb7e01e0fb47cc703fd2d7d12cde18 Reviewed-on: https://chromium-review.googlesource.com/c/1288929 Commit-Queue: Dong-hee Na <donghee.na92@gmail.com> Reviewed-by:
-
Kent Tamura authored
https://google.github.io/styleguide/cppguide.html#Namespace_Names > Namespace names are all lower-case. This CL has no behavior changes. Bug: 889726 Change-Id: I3857cdbdd245658470a8919255b9d757288131b1 Reviewed-on: https://chromium-review.googlesource.com/c/1293093Reviewed-by:
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: Ia133725981e31017e062449627cd97105abca9bc Reviewed-on: https://chromium-review.googlesource.com/c/1293239Reviewed-by:
-
Stuart Langley authored
Added BUILD target for mock_actions_model.js that is testonly. Bug: 860355 Change-Id: Idb81f1e2bdcbda7ba4164b502e4b81f551f2b0bb Reviewed-on: https://chromium-review.googlesource.com/c/1292660 Commit-Queue: Stuart Langley <slangley@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#601485}
-
Takashi Sakamoto authored
Bug: 888904 Change-Id: I230b9f4370594029d9ae7ecf222e0b04074d7e35 Reviewed-on: https://chromium-review.googlesource.com/c/1285989Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#601484}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b1a002e850e1..80c6909bf7ee git log b1a002e850e1..80c6909bf7ee --date=short --no-merges --format='%ad %ae %s' 2018-10-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 0cc11c684b54..7818a85c33d3 (1 commits) Created with: gclient setdep -r src/third_party/skia@80c6909bf7ee The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=brianosman@chromium.org Change-Id: I899cb511b2056adccaea94e354a510e1339a4132 Reviewed-on: https://chromium-review.googlesource.com/c/1293236Reviewed-by:
-
Fergal Daly authored
This reverts commit 4d310087. Reason for revert: Findit identifies this CL as a source of flakiness with 100% confidence https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy4AELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKpAWNocm9taXVtLndpbi9XaW4gNyBUZXN0cyB4NjQgKDEpLzQ0NTYxL25ldHdvcmtfc2VydmljZV9icm93c2VyX3Rlc3RzL1UyRjJaVU5oY21SQ2RXSmliR1ZXYVdWM2MwWjFiR3hHYjNKdFFuSnZkM05sY2xSbGMzUXVVM1J5YVd0bFJHRjBZV0poYzJWZlZYQnNiMkZrWDBaMWJHeEdiRzkzVkdWemRBPT0MCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA Original change's description: > [Autofill] Add strikes when CC save ignored/denied/fails > > This is a retry/relanding of > https://chromium-review.googlesource.com/c/chromium/src/+/1269524. > We're having a *very* hard time reproducing the flakes that the trybots > experienced, but I've made some improvements to attempt to reduce > possible race conditions in the browsertests. > > Patch set 1 is the original CL; patch set 2 contains the new changes. > > (When a card accrues 3 strikes, future offers to save for that card > should show the omnibox save icon, but NOT pop up the bubble. > On Android, no offer to save is shown at all.) > > TBR=mahmadi@chromium.org > > Bug: 884817 > Change-Id: If641cff300cab6122bfd0a52942376b8b6449fed > Reviewed-on: https://chromium-review.googlesource.com/c/1292169 > Commit-Queue: Jared Saul <jsaul@google.com> > Reviewed-by: Evan Stade <estade@chromium.org> > Cr-Commit-Position: refs/heads/master@{#601278} TBR=estade@chromium.org,mahmadi@chromium.org,jsaul@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 884817 Change-Id: I1761991641b0b89274e2e8233c8150c8d688cb34 Reviewed-on: https://chromium-review.googlesource.com/c/1293055Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2b603f6c919c..06413e47c96e Created with: gclient setdep -r src-internal@06413e47c96e The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I3318804fac62c926eb0f57ddde189cb6edbed296 Reviewed-on: https://chromium-review.googlesource.com/c/1293235Reviewed-by:
-
Sunny authored
According to spec[1], when a string starts with CR/LF set as innerText, the first child node should not be an empty text node. So we adjust the logic in HTMLElement::TextToFragment to make sure it follows the spec. Besides, same in spec[1], there is no special procedure for setting innerText when the element is being rendered and styled as preserving new line, so corresponding code was removed in this commit. 15 failed wpt tests could be passed after this change. [1] https://html.spec.whatwg.org/multipage/dom.html#the-innertext-idl-attribute Bug: 573309, 705478 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I6765601a14c2e95cec3841e084046da79aca065c Reviewed-on: https://chromium-review.googlesource.com/c/1266728Reviewed-by:
-
Mikel Astiz authored
This is a reland of 66a392fa Reland fixes unit tests that accidentally used DCHECKs with side effects, making tests fail in non-debug builds. Original change's description: > Add encryption support to pseudo-USS > > This patch extends SyncableServiceBasedBridge (core to pseudo-USS) > with support for encryption, via a newly introduced interface > (ModelCryptographer), which needs to be usable in the model thread > (where the bridge lives). > > This should unblock the migration of PASSWORDS to pseudo-USS, because > password data must be encrypted at all times. This is a first step of > a proposal described in a dedicated section in the Design Doc: > https://docs.google.com/document/d/14ScYZ0sop921gjBwXuReIEuQJlwftqkuSM1jMK_A_x4/edit#heading=h.ev0xr4j8pkot > > Actual usage of this functionality will be introduced in follow-up > patches. > > Bug: 870624 > Change-Id: I227d429dc952bfe1a3a4fb05cd1ab71cac9ba1c6 > Reviewed-on: https://chromium-review.googlesource.com/c/1288594 > Commit-Queue: Mikel Astiz <mastiz@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> > Cr-Commit-Position: refs/heads/master@{#601254} TBR=treib@chromium.org Bug: 870624 Change-Id: Ie576b1aebf6bb989bba95d808031ab8433ec8b6a Reviewed-on: https://chromium-review.googlesource.com/c/1292556 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
-
