- 10 Jul, 2017 40 commits
-
-
Magnus Jedvert authored
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/74848bb..a5b6c52 $ git log 74848bb..a5b6c52 --date=short --no-merges --format=%ad %ae %s 2017-07-10 magjed@webrtc.org Remove webrtc::VideoEncoderFactory 2017-07-10 minyue@webrtc.org Adding log in OrtcFactoryIntegrationTest and fix a bug. 2017-07-10 minyue@webrtc.org Refactor gunit for synergy to gtest. 2017-07-10 mbonadei@webrtc.org Revert of Change VideoTrack implementation to invoke VideoTrackSourceInterface::AddOrUpdateSink on wt (patchset #2 id:20001 of https://codereview.webrtc.org/2964863002/ ) 2017-07-10 saza@webrtc.org Convert occurrences of deprecated WEBRTC_TRACE logging to LOG style logging in webrtc/modules/audio_device/linux/audio_device_pulse_linux.cc. 2017-07-10 saza@webrtc.org Add a check in the BlockBuffer of AEC2 to guard for buffer overflows. 2017-07-07 yujo@chromium.org Add AudioFrame::ResetWithoutMuting() to address performance regression. 2017-07-07 perkj@webrtc.org Change VideoTrack implementation to invoke VideoTrackSourceInterface::AddOrUpdateSink on the worker thread. 2017-07-07 tommi@webrtc.org Add RTC_FROM_HERE location information to two DCHECKs in ProcessThread. 2017-07-07 zstein@webrtc.org Move SrtpSession and tests to their own files. 2017-07-07 jbauch@webrtc.org Handle case where UDP packet contains multiple DTLS records. 2017-07-07 jtteh@webrtc.org Trace loggging: Check for g_event_logger is not null before calling it. 2017-07-07 peah@webrtc.org Decreased the adaptation rate for the adaptive filter in the echo canceller 3 2017-07-07 henrik.lundin@webrtc.org Fix a variable naming typo 2017-07-07 peah@webrtc.org External APM usage downstream dependency support cleanup 2017-07-07 andersc@webrtc.org Injectable Obj-C video codecs 2017-07-07 ehmaldonado@webrtc.org base->rtc_base: Update .c, .mm and .java files. 2017-07-07 ilnik@webrtc.org Report interframe delay sum in old GetStats 2017-07-06 jbauch@webrtc.org Support re-entrant calls to MessageQueueManager::Clear. 2017-07-06 braveyao@webrtc.org desktop_capture: crop border in window_capture on Win8/10 2017-07-06 ehmaldonado@webrtc.org Rename webrtc/base -> webrtc/rtc_base 2017-07-06 srte@webrtc.org Fixed a miscalculation of sent bitrate caused by mixup of time units 2017-07-06 mbonadei@webrtc.org Moving asm code out of common_audio_c sources list 2017-07-06 oprypin@webrtc.org Remove MAIN_NIB_FILE from Info.plist because the substitution is broken 2017-07-06 henrik.lundin@webrtc.org Let NetEq reset the AudioFrame during muted state 2017-07-06 sprang@webrtc.org Update screen simulcast config 2017-07-06 sprang@webrtc.org Implement RTP keepalive in native stack. 2017-07-06 mbonadei@webrtc.org Moving asm code out of isac_fix_c sources list 2017-07-06 ehmaldonado@webrtc.org Reland of move webrtc/tools (patchset #1 id:1 of https://codereview.webrtc.org/2973493002/ ) 2017-07-06 ilnik@webrtc.org Report timing frames info in GetStats. TBR= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng Bug: Change-Id: I233050e46cec875421b99ca35c07484aa8c87f17 Reviewed-on: https://chromium-review.googlesource.com/564941Reviewed-by:
Magnus Jedvert <magjed@chromium.org> Commit-Queue: Magnus Jedvert <magjed@chromium.org> Cr-Commit-Position: refs/heads/master@{#485236}
-
Mark Cogan authored
This CL removes the remaining usage of IDC_RELOAD now that downstream usage has also been cleaned up. Bug: 738881 Change-Id: I720f8474a97e418efecb16e8940c14d2718db68c Reviewed-on: https://chromium-review.googlesource.com/563797Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#485235}
-
Daniel Vogelheim authored
(This is a follow-up to https://chromium-review.googlesource.com/c/552131/4 ) R=tyoshino@chromium.org Bug: Change-Id: I4b84bfafbcb068a46e96392399a64380e47034a8 Reviewed-on: https://chromium-review.googlesource.com/559338Reviewed-by:
Sigbjørn Finne <sigbjornf@opera.com> Reviewed-by:
Takeshi Yoshino <tyoshino@chromium.org> Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#485234}
-
Finnur Thorarinsson authored
Bug=656015 Change-Id: I20ebfcee39a4c4774abcd71ff5045209af41b715 Reviewed-on: https://chromium-review.googlesource.com/563656 Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#485233}
-
Daniel Bratell authored
Core generated files does not use the same template as most blink core code so it needs to be explicitly turned on (note jumbo is still by default disabled so normal builds are not yet affected). This saves about 8 CPU minutes for me. Bug: 713137 Change-Id: I73ad558021b245c8742672cd3903e27dfdf48ab5 Reviewed-on: https://chromium-review.googlesource.com/563682Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: bratell at Opera <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#485232}
-
bratell authored
The two identical functions CopyBytes collided in a jumbo build so this is primarily to avoid having to exclude one of the files from the jumbo building. BUG= Review-Url: https://codereview.chromium.org/2972023002 Cr-Commit-Position: refs/heads/master@{#485231}
-
Yoshifumi Inoue authored
This patch change handling Shift+Click and mouse drag selection extension with granularity, aka granularity expansion, to use current base position of selection instead of a position where granularity expansion started, e.g. double-click or triple-click. # Background The granularity expansion is started by double-click, for word, or triple-click, for paragraph. Once granularity extending started, farther selection extension is done by granularity, e.g. for word granularity, selection is extended by word, e.g. "^abc de|f" to "^abc def|" where "^" is base position and "|" is extend position. Before this patch, we use base position as a position where user starts granularity expansion and extent which specified by user for constructing |VisibleSelection| and hold base/extent as user specified positions and adjust positions with granularity into start/end positions. After this patch, we use current base position and granularity adjusted extent position for constructing |VisibleSelection| and base/extent and start/end hold extended positions. Note: start/end are result of calling of |Most{Back,For}wardCaretPosition()| of base/extent. # Changes in "shift-click.html" For Mac, it is handled by |ExtendSelectionAsNonDirectional()|, this patch fixes the issue[1], see in "shift-click.html" changes for "mac" behavior. When extent position at end of word, granularity expansion moves extent position to start of words, e.g. "^foo| bar" => "^foo |bar", in other words, word granularity expansion selection whitespaces. For non-Mac, is is handle by |ExtendSelectionAsnDirectional()|, this patch keeps correct direction of selection. Here is steps of user actions: 1. "<div id="first">|one <span id="start"></span>two^ three</div>" base is after "two" 2. "<div id="first">one |<span id="start"></span>two^ three</div>" Shift+Click before "span id=start" 3. "<div id="first">one <span id="start"></span>|two^ three</div>" Granularity expansion with visible position canonicalization Before this patch step 3 is 3. "<div id="first">one <span id="start"></span>^two| three</div>" Granularity expansion with visible position canonicalization for base/extent are before "two" where double-click is occurred. Note: This patch is also a preparation of unify base/extent and start/end[2] [1] https://bugs.webkit.org/show_bug.cgi?id=36256 shift+click to extend a wordgranularity selection backwards selects the space after [2] http://crbug.com/230267 We should get rid of the concept of base and extent Bug: 692923, 230267 Change-Id: Icbb04e4c19637f4a1481891c4d3acdbc885424bc Reviewed-on: https://chromium-review.googlesource.com/562914Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#485230}
-
Becca Hughes authored
Add mojo bindings to expose the Media Engagement scores for the WebUI. BUG=734525 Change-Id: I73800107dfa2bd58f4287397fc6a463248d20249 Reviewed-on: https://chromium-review.googlesource.com/549455 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#485229}
-
Daria Yakovleva authored
Feature per_profile shouldn't be allowed to exist when policy device_only=True Bug: 403736 Change-Id: If07c1772b1aa4ce30abd33dfbc3a6ba7bc7dbca2 Reviewed-on: https://chromium-review.googlesource.com/561522Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Drew Wilson <atwilson@chromium.org> Commit-Queue: Daria Iakovleva <yakovleva@google.com> Cr-Commit-Position: refs/heads/master@{#485228}
-
yuryu authored
This patch introduces ServiceWorkerRegistrationOptions struct to the ServiceWorkerRegistration IPC message. The service worker spec has a couple of options that need to be passed between the browser and blink. It allows future implementation of other options, as currently ServiceWorkerRegistration has the maximum number of arguments. BUG=675540 Review-Url: https://codereview.chromium.org/2968123002 Cr-Commit-Position: refs/heads/master@{#485227}
-
Daniel Bratell authored
There are two namespaces named testing used in Blink unit tests, one from gtest and one internal helper namespace. If both are visible then the gtest testing namespace won't be used unless prepended with ::, as is already done in large parts of the code. This is more important for jumbo builds where the visibility of code expands. BUG=739121 Change-Id: Iaed685c8750fbffbaac384aabc4e2a8f54bcf5c0 Reviewed-on: https://chromium-review.googlesource.com/563619Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: bratell at Opera <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#485226}
-
Ramin Halavati authored
Network traffic annotation auditor have no test support. A unittest is added to cover some tests. Bug: 656607 Bug: 690323 Change-Id: I93b05cf7ec4d89fca07166b230a4fc314fc438e7 Reviewed-on: https://chromium-review.googlesource.com/519244 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#485225}
-
Tsuyoshi Horo authored
This is a follow-up to https://crrev.com/a1c6f54f17c58f01f8aed5c5a0d1c5c095ced1aa Bug: 732682 Change-Id: I512acd72393b8467cfd801411e6113b14dcfa0aa Reviewed-on: https://chromium-review.googlesource.com/564913 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#485224}
-
Hayato Ito authored
TBR=dcheng@chromium.org Bug: 738794 Change-Id: I7097e4cbadcde235248cf0affc2b9c26bc845e0a Reviewed-on: https://chromium-review.googlesource.com/564900 Commit-Queue: Hayato Ito <hayato@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#485223}
-
bratell authored
R=dpranke@chromium.org BUG=713317 Review-Url: https://codereview.chromium.org/2968963002 Cr-Commit-Position: refs/heads/master@{#485222}
-
Mark Cogan authored
This CL removes two further command IDs used in the toolbar and tools menu, replacing them with methods in BrowserCommands. This also "fixes" the hack required to record metrics for taps on the bookmarks button separately when the page is bookmarked and when it isn't (by separating the metrics-identifying ID from the actual thing the button does). Bug: 228521, 73881 Change-Id: I8e046760fef9aca271a5f4cf75c47f1fa7d85e40 Reviewed-on: https://chromium-review.googlesource.com/563307 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Louis Romero <lpromero@chromium.org> Cr-Commit-Position: refs/heads/master@{#485221}
-
Matt Falkenhagen authored
This CL makes RemoveWorkerProcess() match AllocateWorkerProcess(). Now they both must be called on the UI thread. Change-Id: I5e6711a1aadd10aeee1cd896c81db3b1a4cf0225 Reviewed-on: https://chromium-review.googlesource.com/562848 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#485220}
-
Yoshifumi Inoue authored
This patch makes |PreviousLeafWithSameEditability()| in "VisibleUnitsLine.cpp" to take |const Node&| to avoid to use |const_cast<Node*>()| for improving code health. Change-Id: I30d6bc043fc90476decbffe8bd9422c07de28b3d Reviewed-on: https://chromium-review.googlesource.com/564901Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#485219}
-
Jinho Bang authored
Add CanMakePaymentRespondWithObserver to Blink. The class is used for processing result promise of respondWith() in |canmakepayment| event. Related spec change: https://github.com/w3c/payment-handler/pull/170 See the other CLs in this series: [1/4] https://chromium-review.googlesource.com/c/558887 [2/4] https://chromium-review.googlesource.com/c/558888 [3/4] This patch. [4/4] https://chromium-review.googlesource.com/c/558890 Bug: 736745 Change-Id: I74782f924d67cc5cb732dd6797d40b76116f372f Reviewed-on: https://chromium-review.googlesource.com/558889 Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#485218}
-
Sylvain Defresne authored
Add a substitution for ENCRYPTION_EXPORT_COMPLIANCE_CODE if ios_encryption_export_compliance_code is non-empty to fix compilation. Bug: 649854 Change-Id: I55ab7e3467b89bc2970ab5a7fc11fc5baed09518 Reviewed-on: https://chromium-review.googlesource.com/563666Reviewed-by:
Eric Noyau <noyau@chromium.org> Commit-Queue: Eric Noyau <noyau@chromium.org> Cr-Commit-Position: refs/heads/master@{#485217}
-
Marc Treib authored
Hidden behind a new feature "UseDdljsonApi", available on Android and iOS. Bug: 690467 Change-Id: Ia31c1939159a9c1fc093fe478ea6ad91a61d6fe8 Reviewed-on: https://chromium-review.googlesource.com/544869 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#485216}
-
chrome://popular-sites-internalsChris Pickel authored
The one remaining feature that it has and ntp-tiles-internals lacks is that it prints the status of a fetch after updating the URL. This doesn't merit keeping the old page around anymore, in my opinion. BUG=655622 Change-Id: Ia4067f313bc914e7d2e3cba44634d9f906e7de70 Reviewed-on: https://chromium-review.googlesource.com/563360Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Chris Pickel <sfiera@chromium.org> Cr-Commit-Position: refs/heads/master@{#485215}
-
yoichio authored
Before this patch, we use VisibleUnit::ComputeTextRect() to compute a rect to scroll. However, ComputeTextRect() calls InlineTextBox::LocalSelectionRect() which depends on InlineTextBox current SelectionState. To avoid that, update SeletionState and get a rect directly from LayoutSelection::SelectionBounds(). BUG=739062, 740401 TEST=LayoutTests/editing/input/scroll-with-tab-to-input-regression.html Review-Url: https://codereview.chromium.org/2979513002 Cr-Commit-Position: refs/heads/master@{#485214}
-
Jan Krcal authored
This CL extends the metrics that allow to do a what-if analysis for _decreasing_ fetching intervals for remote suggestions. Bug: 739671 Change-Id: I4cb9f87cd5546b54fa9acfd66f26bffeb18483b7 Reviewed-on: https://chromium-review.googlesource.com/561320Reviewed-by:
vitaliii <vitaliii@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#485213}
-
tzik authored
base::Bind is intended to reject raw pointers to ref-counted objects, however, it fails to reject CVR qualified ones. This CL fixes the check for const-qualified cases. Bug: 737010 Change-Id: I0a3c51d36a240257c66682a2fe061dc514e40835 Reviewed-on: https://chromium-review.googlesource.com/558594Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#485212}
-
tzik authored
This CL flips `use_once_callback` flag on the Mojo code generator, and fixes all compile errors after it. After this CL, Mojo interfaces in //media/mojo/interfaces starts using base::OnceCallback instead of base::Callback on its return value handling. The migration recipe was: - Convert pass-by-ref callback objects to pass-by-value. - Use std::move() to forward it to other consumer, or to invoke it with Callback::Run(). - Handle wherever copies are required manually. - Check if the conversion doesn't change the semantics. As the transfer and invocation clobber the callback object, care about use-after-move. It's considered safe to consume almost scoped-out callback. TBR=satorux@chromium.org Bug: 714018 Change-Id: Ic0cad5638bd8e9b05ddb62c028839bb4d0b955b2 Reviewed-on: https://chromium-review.googlesource.com/536384 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#485211}
-
Jan Krcal authored
This CL allows more informative metrics for clients of LargeIconService. Bug: 736265 Change-Id: I5f0b855db06180436a3afba845c702f615eb0f0f Reviewed-on: https://chromium-review.googlesource.com/544931Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#485210}
-
ramyasharma authored
This CL just pulls out the basic views, and models into the super class. Next CLs will pull out delegate logic, and view layouts. BUG=705339 Review-Url: https://codereview.chromium.org/2972733002 Cr-Commit-Position: refs/heads/master@{#485209}
-
Sylvain Defresne authored
During compilation of assets catalogs, actool has the option of recompressing the images (likely with pngcrush as used by older version of Xcode). Add an option to wrapper script to control whether this is enabled and disable it on iOS (as images have already been optimised with imageoptim). Bug: 738359 Change-Id: I8a2b855798bf5f2d221fe9dc1098f8649f77e5a4 Reviewed-on: https://chromium-review.googlesource.com/561777Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#485208}
-
Takeshi Yoshino authored
Bug: Change-Id: I38d1f5a5cbe49909be0b5a394719242f2aec0405 Reviewed-on: https://chromium-review.googlesource.com/564858Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org> Cr-Commit-Position: refs/heads/master@{#485207}
-
Yoshifumi Inoue authored
Make LineDirectionPointForBlockDirectionNavigation() to take const Position& instead of EPositionType This patch makes |LineDirectionPointForBlockDirectionNavigation()| to take |const Position&| and get rid of |EPositionType| enum to simplify source code for improving code health. Change-Id: I640c0391783ac4f8141742ee9495545fe2889fd9 Reviewed-on: https://chromium-review.googlesource.com/564873Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#485206}
-
Yoshifumi Inoue authored
This patch changes |Adjust{Forward,Backward}PositionForUserSelectAll()| in "SelectionModifier.cpp" to take |Const VisbilePosition&| as follow-up of patch[1], since the parameter is "in"-parameter, we don't use it as "out"- parameter for improving code health. [1] http://crrev.com/c/562915 Refactor AdjustPositionForUserSelectAll() in SelectionModifier.cpp Change-Id: I618d48c6a05c015ece70ac1ffa103fbce2e64040 Reviewed-on: https://chromium-review.googlesource.com/564870Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#485205}
-
Kent Tamura authored
Unescaped custom validation messages could cause DCHECK failures. Bug: 739091 Change-Id: Ia7993221cad5d7ff00767cfe676e88da2fba2114 Reviewed-on: https://chromium-review.googlesource.com/564194Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#485204}
-
Vaclav Brozek authored
The password_manager component now has a GetHumanReadableOrigin in its core layer, so iOS settings should no longer use the outdated local replacement. As work progresses on https://crbug.com/628988, this will also allow the iOS settings to use more user-friendly names for credentials coming from Android apps. The difference is currently only subtle: the new function drops the path from the web origin (URL). This seems reasonable, given that it highlights the hostname and the full URL is available in the password details section (as soon as viewing passwords is launched -- tracked at https://crbug.com/739404). Once https://crbug.com/628988 is fixed, there will be a much bigger difference for the credentials coming from Android apps, where the cryptic URL will be replaced by a human readable app name. Screenshots comparing the before and after state for this CL are at https://crbug.com/669538#c2. Bug: 669538 Change-Id: I4ae80be4326c48d44f684b18b73682da99abb8b7 Reviewed-on: https://chromium-review.googlesource.com/563664 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#485203}
-
Yuta Kitamura authored
This patch only touches comments. No code change. Change-Id: Ibc823deb7cfe35dfed400566767e1791ac78e48b Reviewed-on: https://chromium-review.googlesource.com/564876Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#485202}
-
calamity authored
BUG=708487 TBR=primiano@chromium.org Review-Url: https://codereview.chromium.org/2975743002 Cr-Commit-Position: refs/heads/master@{#485201}
-
Yoshifumi Inoue authored
This patch converts "empty-cell-right-click.html" to gTest to narrow scope of verification for improving code health. # Background The bug[1] is happend only on MacOS due by MacOs specific behavior |ShouldSelectOnContextualMenuClick()|. This means "empty-cell-right-click.html" is only meaningful on MacOs. Also, The actual changes of fixing the bug[1] is in |ViisibleSelection|. Hence, using unit test for |VisibleSeleciton| is more suitable for this case. [1] https://bugs.webkit.org/show_bug.cgi?id=32622 Right clicking in a table cell creates a selection that extends into the next cell Change-Id: I806907f6d13008f3b131514e3012fd9fb8bc0561 Reviewed-on: https://chromium-review.googlesource.com/564865Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#485200}
-
gambard authored
When there is an animation on the NTP screen with ContentSuggestions, the appearing and disappearing icons are shown with an alpha of 1 during the whole animation. This CL fixes this by reloading the data during the rotation. Before: https://drive.google.com/open?id=0B21N-0pPGAuJMHVhWDRvdU55ODg After: https://drive.google.com/open?id=0B21N-0pPGAuJYm13cW5IVDRiUjQ BUG=700375 Change-Id: Ie2c928ff1d012439cf329948713f2ff46887b7d2 Reviewed-on: https://chromium-review.googlesource.com/561776 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Louis Romero <lpromero@chromium.org> Cr-Commit-Position: refs/heads/master@{#485199}
-
meade authored
This applies when converting CSSUnitValues to other CSSUnitValues. https://drafts.css-houdini.org/css-typed-om/#dom-cssnumericvalue-to BUG=545318 Review-Url: https://codereview.chromium.org/2958233002 Cr-Commit-Position: refs/heads/master@{#485198}
-
Philip Jägenstedt authored
Bug: 738794 Change-Id: I6926dd2db27f0bd824e4b4566278af27c9feb5cb No-Try: true Reviewed-on: https://chromium-review.googlesource.com/563304Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#485197}
-